Rich Felker [Tue, 11 Sep 2018 19:07:16 +0000 (15:07 -0400)]
rework malloc_usable_size to use malloc_impl.h
Rich Felker [Tue, 11 Sep 2018 19:03:23 +0000 (15:03 -0400)]
remove unused __futex function and source file
the direct syscall or various thin and mostly-inline wrappers around
it are used instead internally. at some point a public futex function
should be added, but it's not yet clear what the signature should be,
and in the mean time this file is not useful.
Rich Felker [Tue, 11 Sep 2018 18:56:09 +0000 (14:56 -0400)]
hide __pthread_once_full symbol
this is a special case that does not need a declaration, because it's
not even a libc-internal interface between translation units. instead
it's a poor hack around compilers' inability to shrink-wrap critical
code paths. after vis.h was disabled, it became more of a
pessimization on many archs due to the extra layer of machinery to
support a call through the PLT, but now it should be efficient again.
Rich Felker [Tue, 11 Sep 2018 18:49:22 +0000 (14:49 -0400)]
declare and make hidden additional internal init/exit symbols
Rich Felker [Tue, 11 Sep 2018 18:28:57 +0000 (14:28 -0400)]
declare and make hidden additional internal stdio symbols
Rich Felker [Tue, 11 Sep 2018 18:21:06 +0000 (14:21 -0400)]
move declaration and apply hidden visibility to __utc string
Rich Felker [Tue, 11 Sep 2018 18:15:03 +0000 (14:15 -0400)]
declare and make hidden more internal locale functions
Rich Felker [Tue, 11 Sep 2018 18:09:20 +0000 (14:09 -0400)]
remove unused __getdents, rename and move file
the __-prefixed filename does not make sense when the only purpose of
this file is implementing a public function that's not used as a
backend for implementing the standard dirent functions.
Rich Felker [Tue, 11 Sep 2018 18:02:58 +0000 (14:02 -0400)]
remove or make static various unused __-prefixed symbols
Rich Felker [Tue, 11 Sep 2018 17:57:17 +0000 (13:57 -0400)]
move additional pthread internal declarations to pthread_impl.h, hide
these were overlooked for various reasons in earlier stages.
Rich Felker [Tue, 11 Sep 2018 16:32:46 +0000 (12:32 -0400)]
apply hidden visibility to various remaining internal interfaces
Rich Felker [Tue, 11 Sep 2018 15:57:31 +0000 (11:57 -0400)]
apply hidden visibility to sigreturn code fragments
these were overlooked in the declarations overhaul work because they
are not properly declared, and the current framework even allows their
declared types to vary by arch. at some point this should be cleaned
up, but I'm not sure what the right way would be.
Rich Felker [Tue, 11 Sep 2018 15:40:51 +0000 (11:40 -0400)]
apply hidden visibility to pthread internals
Rich Felker [Tue, 11 Sep 2018 15:39:07 +0000 (11:39 -0400)]
apply hidden visibility to stdio internals
Rich Felker [Tue, 11 Sep 2018 15:16:55 +0000 (11:16 -0400)]
apply hidden visibility to internal time[zone] implementation functions
Rich Felker [Tue, 11 Sep 2018 15:04:35 +0000 (11:04 -0400)]
apply hidden visibility to internal math functions
this makes significant differences to codegen on archs with an
expensive PLT-calling ABI; on i386 and gcc 7.3 for example, the sin
and sinf functions no longer touch call-saved registers or the stack
except for pushing outgoing arguments. performance is likely improved
too, but no measurements were taken.
Rich Felker [Tue, 11 Sep 2018 03:26:40 +0000 (23:26 -0400)]
overhaul internally-public declarations using wrapper headers
commits leading up to this one have moved the vast majority of
libc-internal interface declarations to appropriate internal headers,
allowing them to be type-checked and setting the stage to limit their
visibility. the ones that have not yet been moved are mostly
namespace-protected aliases for standard/public interfaces, which
exist to facilitate implementing plain C functions in terms of POSIX
functionality, or C or POSIX functionality in terms of extensions that
are not standardized. some don't quite fit this description, but are
"internally public" interfacs between subsystems of libc.
rather than create a number of newly-named headers to declare these
functions, and having to add explicit include directives for them to
every source file where they're needed, I have introduced a method of
wrapping the corresponding public headers.
parallel to the public headers in $(srcdir)/include, we now have
wrappers in $(srcdir)/src/include that come earlier in the include
path order. they include the public header they're wrapping, then add
declarations for namespace-protected versions of the same interfaces
and any "internally public" interfaces for the subsystem they
correspond to.
along these lines, the wrapper for features.h is now responsible for
the definition of the hidden, weak, and weak_alias macros. this means
source files will no longer need to include any special headers to
access these features.
over time, it is my expectation that the scope of what is "internally
public" will expand, reducing the number of source files which need to
include *_impl.h and related headers down to those which are actually
implementing the corresponding subsystems, not just using them.
Rich Felker [Tue, 11 Sep 2018 03:10:18 +0000 (23:10 -0400)]
declare __getopt_msg in stdio_impl.h
it's not ideal, but the function is essentially an extended stdio
function specialized to getopt's needs. the only reason it exists is
avoiding pulling printf code into every program using getopt.
Rich Felker [Tue, 11 Sep 2018 03:04:42 +0000 (23:04 -0400)]
use lighter internal stdio lock in getopt error printing
the public flockfile interface is significantly heavier because it has
to handle the possibility of caller returning or thread exiting while
holding the lock.
Rich Felker [Tue, 11 Sep 2018 00:42:35 +0000 (20:42 -0400)]
add crypt_des header for declarations shared with encrypt function
Rich Felker [Tue, 11 Sep 2018 00:35:58 +0000 (20:35 -0400)]
make mkostemps source file include the header for its declaration
Rich Felker [Tue, 11 Sep 2018 00:28:47 +0000 (20:28 -0400)]
move __memalign declaration to malloc_impl.h
the malloc-implementation-private header is the only right place for
this, because, being in the reserved namespace, __memalign is not
interposable and thus not valid to use anywhere else. anything outside
of the malloc implementation must call an appropriate-namespace public
function (aligned_alloc or posix_memalign).
Rich Felker [Mon, 10 Sep 2018 20:25:49 +0000 (16:25 -0400)]
use hidden visibility for sh __unmapself backends
Rich Felker [Mon, 10 Sep 2018 20:13:29 +0000 (16:13 -0400)]
rework mechanism for posix_spawnp calling posix_spawn
previously, a common __posix_spawnx backend was used that accepted an
additional argument for the execve variant to call in the child. this
moderately bloated up the posix_spawn function, shuffling arguments
between stack and/or registers to call a 7-argument function from a
6-argument one.
instead, tuck the exec function pointer in an unused part of the
(large) pthread_spawnattr_t structure, and have posix_spawnp duplicate
the attributes and fill in a pointer to __execvpe. the net code size
change is minimal, but the weight is shifted to the "heavier" function
which already pulls in more dependencies.
as a bonus, we get rid of an external symbol (__posix_spawnx) that had
no really good place for a declaration because it shouldn't have
existed to begin with.
Rich Felker [Mon, 10 Sep 2018 19:51:44 +0000 (15:51 -0400)]
make arch __fesetround backends hidden
these are not public interfaces and do not match the public function,
but delegate argument checking to it.
Rich Felker [Mon, 10 Sep 2018 19:42:03 +0000 (15:42 -0400)]
make arch __set_thread_area backends hidden
this is not a public interface, and does not even necessarily match
the syscall on all archs that have a syscall by that name.
on archs where it's implemented in C, no action on the source file is
needed; the hidden declaration in pthread_arch.h suffices.
Rich Felker [Mon, 10 Sep 2018 19:36:33 +0000 (15:36 -0400)]
make arch __clone backends hidden
these are not a public interface and are not intended to be callable
from anywhere but the public clone function or other places in libc.
Rich Felker [Sun, 9 Sep 2018 05:12:30 +0000 (01:12 -0400)]
move tlsdesc and internal dl function declarations to dynlink.h
Rich Felker [Sun, 9 Sep 2018 04:55:28 +0000 (00:55 -0400)]
add internal header for declaring __pleval function (used by gettext)
locale_impl.h could have been used, but this function is completely
independent of anything else, and preserving that property seems nice.
Rich Felker [Sun, 9 Sep 2018 04:53:11 +0000 (00:53 -0400)]
move __stdio_exit_needed to stdio_impl.h
this functions is glue for linking dependency logic.
Rich Felker [Sun, 9 Sep 2018 04:34:31 +0000 (00:34 -0400)]
move __loc_is_allocated declaration to locale_impl.h
Rich Felker [Sat, 8 Sep 2018 22:46:06 +0000 (18:46 -0400)]
move declarations of tls setup/access functions to pthread_impl.h
it's already included in all places where these are needed, and aside
from __tls_get_addr, they're all implementation internals.
Rich Felker [Sat, 8 Sep 2018 03:02:40 +0000 (23:02 -0400)]
add and use internal header for *rand48 lcg
Rich Felker [Sat, 8 Sep 2018 02:52:03 +0000 (22:52 -0400)]
move __strftime_fmt_1 declaration to time_impl.h
this is a helper function from strftime that's also used by wcsftime.
Rich Felker [Sat, 8 Sep 2018 02:48:19 +0000 (22:48 -0400)]
move __tm_to_tzname declaration to time_impl.h with related functions
this function was added later for strftime use and the existence of
time_impl.h as the appropriate place for it seems to have been
overlooked.
Rich Felker [Sat, 8 Sep 2018 02:36:12 +0000 (22:36 -0400)]
remove unused code from strcpy.c
Rich Felker [Sat, 8 Sep 2018 00:03:32 +0000 (20:03 -0400)]
move __res_msend_rc declaration to lookup.h
unlike the other res/dn functions, this one is tied to struct
resolvconf which is not a public interface, so put it in the private
header for its subsystem.
Rich Felker [Fri, 7 Sep 2018 23:49:21 +0000 (19:49 -0400)]
fix type-mismatched declarations of __nl_langinfo_l in source files
obviously the type "should be" const, but it inherited non-const from
the standard nl_langinfo_l.
Rich Felker [Fri, 7 Sep 2018 20:20:39 +0000 (16:20 -0400)]
for c11 mtx and cnd functions, use externally consistent type names
despite looking like undefined behavior, the affected code is correct
both before and after this patch. the pairs mtx_t and pthread_mutex_t,
and cnd_t and pthread_cond_t, are not mutually compatible within a
single translation unit (because they are distinct untagged aggregate
instances), but they are compatible with an object of either type from
another translation unit (6.2.7 ¶1), and therefore a given translation
unit can choose which one it wants to use.
in the interest of being able to move declarations out of source files
to headers that facilitate checking, use the pthread type names in
declaring the namespace-safe versions of the pthread functions and
cast the argument pointer types when calling them.
Rich Felker [Fri, 7 Sep 2018 19:51:00 +0000 (15:51 -0400)]
move and deduplicate declarations of __dns_parse to make it checkable
the source file for this function is completely standalone, but it
doesn't seem worth adding a header just for it, so declare it in
lookup.h for now.
Rich Felker [Fri, 7 Sep 2018 16:32:12 +0000 (12:32 -0400)]
move lgamma-related internal declarations to libm.h
Rich Felker [Fri, 7 Sep 2018 02:03:24 +0000 (22:03 -0400)]
declare __syscall_ret as hidden in vfork asm
without this, it's plausible that assembler or linker could complain
about an unsatisfiable relocation.
Patrick Oppenlander [Tue, 10 Apr 2018 01:01:25 +0000 (11:01 +1000)]
add arm asm for vfork
Rich Felker [Thu, 6 Sep 2018 20:32:49 +0000 (16:32 -0400)]
move declarations for malloc internals to malloc_impl.h
Rich Felker [Thu, 6 Sep 2018 20:17:56 +0000 (16:17 -0400)]
improve machinery for ldso to report libc version
eliminate gratuitous glue function for reporting the version, which
was probably leftover from the old dynamic linker design which lacked
a clear barrier for when/how it could access global data. put the
declaration for the data object that replaces it in libc.h where it
can be type checked.
Rich Felker [Thu, 6 Sep 2018 20:06:17 +0000 (16:06 -0400)]
make internal declarations for flockfile tracking functions checkable
logically these belong to the intersection of the stdio and pthread
subsystems, and either place the declarations could go (stdio_impl.h
or pthread_impl.h) requires a forward declaration for one of the
argument types.
Rich Felker [Thu, 6 Sep 2018 18:06:50 +0000 (14:06 -0400)]
make inadvertently exposed __h{create,delete,search}_r functions static
Rich Felker [Thu, 6 Sep 2018 17:55:50 +0000 (13:55 -0400)]
make inadvertently exposed __pthread_{timed,try}join_np functions static
these exist for the sake of defining the corresponding weak public
aliases (for C11 and POSIX namespace conformance reasons). they are
not referenced by anything else in libc, so make them static.
Rich Felker [Thu, 6 Sep 2018 17:51:10 +0000 (13:51 -0400)]
use idiomatic weak alias approach for defining asctime_r
get rid of a gratuitous translation unit and call frame between
asctime_r and the actual implementation of the function. this is the
way gmtime_r and localtime_r are already done.
Rich Felker [Thu, 6 Sep 2018 17:45:31 +0000 (13:45 -0400)]
move and deduplicate declarations of __vdsosym to make it checkable
Rich Felker [Thu, 6 Sep 2018 17:39:08 +0000 (13:39 -0400)]
move and deduplicate declarations of __procfdname to make it checkable
syscall.h was chosen as the header to declare it, since its intended
usage is alongside syscalls as a fallback for operations the direct
syscall does not support.
Rich Felker [Thu, 6 Sep 2018 15:15:15 +0000 (11:15 -0400)]
fix issues from public functions defined without declaration visible
policy is that all public functions which have a public declaration
should be defined in a context where that public declaration is
visible, to avoid preventable type mismatches.
an audit performed using GCC's -Wmissing-declarations turned up the
violations corrected here. in some cases the public header had not
been included; in others, a feature test macro needed to make the
declaration visible had been omitted.
in the case of gethostent and getnetent, the omission seems to have
been intentional, as a hack to admit a single stub definition for both
functions. this kind of hack is no longer acceptable; it's UB and
would not fly with LTO or advanced toolchains. the hack is undone to
make exposure of the declarations possible.
Rich Felker [Wed, 5 Sep 2018 18:11:38 +0000 (14:11 -0400)]
remove leftover declarations for removed functions from pthread_impl.h
Rich Felker [Wed, 5 Sep 2018 16:43:34 +0000 (12:43 -0400)]
define and use internal macros for hidden visibility, weak refs
this cleans up what had become widespread direct inline use of "GNU C"
style attributes directly in the source, and lowers the barrier to
increased use of hidden visibility, which will be useful to recovering
some of the efficiency lost when the protected visibility hack was
dropped in commit
dc2f368e565c37728b0d620380b849c3a1ddd78f, especially
on archs where the PLT ABI is costly.
Rich Felker [Wed, 5 Sep 2018 02:56:57 +0000 (22:56 -0400)]
fix namespace violation for c11 mutex functions
__pthread_mutex_timedlock is used to implement c11 mutex functions,
and therefore cannot call pthread_mutex_trylock by name.
Rich Felker [Wed, 5 Sep 2018 01:31:47 +0000 (21:31 -0400)]
in pthread_mutex_timedlock, avoid repeatedly reading mutex type field
compiler cannot cache immutable fields of the mutex object across
external calls it can't see, much less across atomics.
Rich Felker [Wed, 5 Sep 2018 01:28:38 +0000 (21:28 -0400)]
in pthread_mutex_trylock, EBUSY out more directly when possible
avoid gratuitously setting up and tearing down the robust list pending
slot.
Rich Felker [Tue, 4 Sep 2018 23:27:15 +0000 (19:27 -0400)]
fix mistake/cruft in 1.1.20 release notes
this fix was intended to be amended in before release, but somehow got
missed.
Joseph C. Sible [Sun, 2 Sep 2018 17:42:26 +0000 (13:42 -0400)]
implement fexecve in terms of execveat when it exists
This lets fexecve work even when /proc isn't mounted.
Rich Felker [Tue, 4 Sep 2018 17:11:44 +0000 (13:11 -0400)]
release 1.1.20
Rich Felker [Sun, 2 Sep 2018 21:08:43 +0000 (17:08 -0400)]
fix stack-based oob memory clobber in resolver's result sorting
commit
4f35eb7591031a1e5ef9828f9304361f282f28b9 introduced this bug.
it is not present in any released versions. inadvertent use of the &
operator on an array into which we're indexing produced arithmetic on
the wrong-type pointer, with undefined behavior.
Rich Felker [Sat, 1 Sep 2018 18:14:32 +0000 (14:14 -0400)]
consistently use _NSIG/8 idiom for kernel sigset size in sigaction
this code in sigaction was the only place where sizeof was being
applied to the kernel sigaction's mask member to get the size argument
to pass to the kernel. everywhere else, _NSIG/8 is used for this
purpose.
Rich Felker [Sat, 1 Sep 2018 05:54:44 +0000 (01:54 -0400)]
always terminate by SIGABRT when abort is called
Linux makes this surprisingly difficult, but it can be done. the trick
here is using the fact that we control the implementation of sigaction
to prevent changing the disposition of SIGABRT to anything but SIG_DFL
after abort has tried and failed to terminate the process simply by
calling raise(SIGABRT).
Rich Felker [Sat, 1 Sep 2018 05:46:44 +0000 (01:46 -0400)]
optimize raise not to make a syscall for getting tid
assuming signals are blocked, which they are here, the tid in the
thread structure is always valid and cannot change out from under us.
Rich Felker [Thu, 30 Aug 2018 04:08:16 +0000 (00:08 -0400)]
prevent perror from clobbering stderr's orientation
this requirement is specified by POSIX.
Rich Felker [Thu, 30 Aug 2018 04:00:22 +0000 (00:00 -0400)]
prevent psignal/psiginfo from clobbering stderr orientation, errno
these functions are specified to write to stderr but not set its
orientation, presumably so that they can be used in programs operating
stderr in wide mode. also, they are not allowed to clobber errno on
success. save and restore to meet the requirement.
psiginfo is reduced to a think wrapper around psignal, since it
already behaved the same. if we want to add more detailed siginfo
printing at some point this will need refactoring.
Rich Felker [Thu, 30 Aug 2018 03:53:45 +0000 (23:53 -0400)]
make vfprintf set stream orientation even for zero-length output
if no output is produced, no underlying fwrite will ever be called,
but byte-oriented printf functions are still required to set the
orientation of the stream to byte-oriented. call __towrite explicitly
if the FILE is not already in write mode.
Rich Felker [Thu, 30 Aug 2018 03:45:43 +0000 (23:45 -0400)]
re-fix vfprintf temporary buffer logic
commit
b5a8b28915aad17b6f49ccacd6d3fef3890844d1 setup the write buffer
bound pointers for the temporary buffer manually to fix a buffer
overflow issue, but in doing so, caused vfprintf on unbuffered files
never to call __towrite, thereby failing to set the stream orientation
to byte-oriented, failing to clear any prior read mode, and failing to
produce an error when the stream is not writable.
revert the inline setup of the bounds pointers and instead zero them,
so that the underlying fwrite code will call __towrite to set them up.
Rich Felker [Thu, 30 Aug 2018 03:40:49 +0000 (23:40 -0400)]
fix missing flush of stderr at exit if it was put in buffered mode
commit
0b80a7b0404b6e49b0b724e3e3fe0ed5af3b08ef added the ability to
set application-provided stdio FILE buffers, adding the possibility
that stderr might be buffered at exit time, but __stdio_exit did not
have code to flush it.
this regression was not present in any release.
Rich Felker [Wed, 29 Aug 2018 18:01:46 +0000 (14:01 -0400)]
fix async thread cancellation on sh-fdpic
if __cp_cancel was reached via __syscall_cp, r12 will necessarily
still contain a GOT pointer (for libc.so or for the static-linked main
program) valid for entering __cancel. however, in the case of async
cancellation, r12 may contain any scratch value; it's not necessarily
even a valid GOT pointer for the code that was interrupted.
unlike in commit
0ec49dab6794166d67fae4764ce7fdea42ea6103 where the
corresponding issue was fixed for powerpc64, there is fundamentally no
way for fdpic code to recompute its GOT pointer. so a new mechanism is
introduced for cancel_handler to write a GOT register value into the
interrupted context on archs where it is needed.
Rich Felker [Wed, 29 Aug 2018 16:48:42 +0000 (12:48 -0400)]
fix async thread cancellation on powerpc64
entering the local entry point for __cancel from __cp_cancel is valid
if __cp_cancel was reached from __syscall_cp, since both are in libc
and share the same TOC pointer, but it is not valid if __cp_cancel was
reached when cancel_handler rewrote the program counter for
asynchronous cancellation of code outside libc.
to ensure __cancel is entered with a valid TOC pointer, recompute the
correct value in a PC-relative manner before jumping.
A. Wilcox [Thu, 23 Aug 2018 13:06:12 +0000 (08:06 -0500)]
vfwprintf: honor field width with 'c' format type
Rich Felker [Wed, 29 Aug 2018 01:22:48 +0000 (21:22 -0400)]
fix several values reported by sysconf
- REALTIME_SIGNALS is supposed to be version-valued
- DELAYTIMER_MAX was wrongly using the min allowed max
- unavailable compilation environments wrongly used 0 instead of -1
Rich Felker [Wed, 29 Aug 2018 00:39:26 +0000 (20:39 -0400)]
fix return value of system on failure to spawn child process
the value 0x7f00 (as if by _exit(127)) is specified only for the case
where the child is created but then fails to exec the shell, since
traditional fork+exec implementations do not admit reporting an error
via errno in this case without additional machinery. it's unclear
whether an implementation not subject to this failure mode needs to
emulate it; one could read the standard as requiring that. if so,
additional code will need to be added to map posix_spawn errors into
the form system is expected to return. but for now, returning -1 to
indicate an error is significantly better behavior than always
reporting failures as if the shell failed to exec after fork.
Rich Felker [Tue, 28 Aug 2018 23:22:13 +0000 (19:22 -0400)]
set stream orientations in open_[w]memstream
fundamentally there is no good reason these functions need to set an
orientation (morally it should be possible to write a wchar_t[] memory
stream using byte functions, or a char[] memory stream using wide
functions), but it's a part of the specification that they do. aside
from being able to inspect the orientation with fwide, failure to set
the orientation in open_wmemstream is observable if the locale changes
between open_wmemstream and the first operation on the stream; this is
because the encoding rule (locale) for the stream is required to be
bound at the time the stream becomes wide-oriented.
for open_wmemstream, call fwide to avoid duplicating the logic for
binding the encoding rule. for open_memstream it suffices just to set
the mode field in the FILE struct.
Rich Felker [Tue, 28 Aug 2018 23:16:40 +0000 (19:16 -0400)]
make fmemopen's w+ mode truncate the buffer
the w+ mode is specified to "truncate the buffer contents". like most
of fmemopen, exactly what this means is underspecified. mode w and w+
of course implicitly 'truncate' the buffer if a write from the initial
position is flushed, so in order for this part of the text about w+
not to be spurious, it should be interpreted as requiring something
else, and the obvious reasonable interpretation is that the truncation
is immediately visible if you attempt to read from the stream or the
buffer before writing/flushing.
this interpretation agrees with reported conformance test failures.
Rich Felker [Tue, 28 Aug 2018 22:40:15 +0000 (18:40 -0400)]
set errno when fileno is called on a FILE with no underlying fd
this is a POSIX requirement.
also remove the gratuitous locking shenanigans and simply access f->fd
under control of the lock. there is no advantage to not doing so, and
it made the correctness non-obvious at best.
Rich Felker [Tue, 28 Aug 2018 22:12:17 +0000 (18:12 -0400)]
reject invalid arguments to pthread_barrierattr_setpshared
this is a POSIX requirement.
Szabolcs Nagy [Fri, 24 Aug 2018 23:11:59 +0000 (23:11 +0000)]
rewrite __aeabi_read_tp in asm
__aeabi_read_tp used to call c code, but that was incorrect as the
arm runtime abi specifies special pcs for this function: it is only
allowed to clobber r0, ip, lr and cpsr.
maintainer's note: the old code explicitly saved and restored all
general-purpose registers which are call-clobbered in the normal
calling convention, so it's unlikely that any real-world compilers
produced code that could break. however theoretically they could have
chosen to use floating point registers, in which case the caller's
values of those registers would be clobbered.
Rich Felker [Tue, 28 Aug 2018 17:54:50 +0000 (13:54 -0400)]
fix dubious char signedness check in limits.h
commit
201995f382cc698ae19289623cc06a70048ffe7b introduced a hack
utilizing the signedness of character constants at the preprocessor
level to avoid depending on the gcc-specific __CHAR_UNSIGNED__ predef.
while this trick works on gcc and presumably other compilers being
used, it's not clear that the behavior it depends on is actually
conforming. C11 6.4.4.4 ¶10 defines character constants as having type
int, and 6.10.1 ¶4 defines preprocessor #if arithmetic to take place
in intmax_t or uintmax_t, depending on the signedness of the integer
operand types, and it is specified that "this includes interpreting
character constants".
if character literals had type char and just promoted to int, it would
be clear that when char is unsigned they should behave as uintmax_t at
the preprocessor level. however, as written the text of the standard
seems to require that character constants always behave as intmax_t,
corresponding to int, at the preprocessor level.
since there is a good deal of ambiguity about the correct behavior and
a risk that compilers will disagree or that an interpretation may
mandate a change in the behavior, do not rely on it for defining
CHAR_MIN and CHAR_MAX correctly. instead, use the signedness of the
value (as opposed to the type) of '\xff', which will be positive if
and only if plain char is unsigned. this behavior is clearly
specified, and the specific case '\xff' is even used in an example,
under 6.4.4.4 of the standard.
Rich Felker [Tue, 28 Aug 2018 16:45:44 +0000 (12:45 -0400)]
fix deadlock in async thread self-cancellation
with async cancellation enabled, pthread_cancel(pthread_self())
deadlocked due to pthread_kill holding killlock which is needed by
pthread_exit.
this could be solved by making pthread_kill block signals around the
critical section, at least when the target thread is itself, but the
issue only arises for cancellation, and otherwise would just be
imposing unnecessary cost.
instead just have pthread_cancel explicitly check for async
self-cancellation and call pthread_exit(PTHREAD_CANCELED) directly
rather than going through the signal machinery.
A. Wilcox [Mon, 27 Aug 2018 23:17:20 +0000 (18:17 -0500)]
time: fix incorrect DST offset when using POSIX timezones without DST
This manifests itself in mktime if tm_isdst = 1 and the current TZ= is
a POSIX timezone specification. mktime would see that tm_isdst was set
to 0 by __secs_to_zone, and subtract 'oppoff' (dst_off) - gmtoff from
the resultant time. This meant that mktime returned a time that was
exactly double the GMT offset of the desired timezone when tm_isdst
was = 1.
Szabolcs Nagy [Thu, 23 Aug 2018 10:57:34 +0000 (10:57 +0000)]
fix tls access on arm targets before armv6k
commit
610c5a8524c3d6cd3ac5a5f1231422e7648a3791 changed the thread
pointer setup so tp points at the end of the pthread struct on arm,
but failed to update __aeabi_read_tp so it was off by 8.
this broke tls access in code that is compiled with -mtp=soft, which
is the default when target arch is pre armv6k or thumb1.
maintainer's note: no release versions are affected.
Rich Felker [Thu, 23 Aug 2018 19:56:52 +0000 (15:56 -0400)]
fix missing strerror text for EMULTIHOP
this is an obsolete error code from RFS, an obsolete predecessor of
NFS. POSIX documents it only as "Reserved", but maintains the
requirement that it be defined. as long as it is defined, it needs a
string for strerror to produce; the one chosen matches glibc and
documentation from other language runtimes I could find.
Rich Felker [Thu, 23 Aug 2018 19:24:03 +0000 (15:24 -0400)]
fix printf precision specifier for hex floats on non-ld80 archs
the code to perform rounding to the desired precision wrongly assumed
the long double mantissa was an integral number of nibbles (hex
digits) in length. this is true for 80-bit extended precision (64-bit
mantissa) but not for double (53) or quad (113).
scale the rounding value by 1<<(LDBL_MANT_DIG%4) to compensate.
Rich Felker [Wed, 22 Aug 2018 23:29:56 +0000 (19:29 -0400)]
getopt: update optarg and optind correctly on missing argument
the text of the specification for getopt's handling of options that
require an argument, which requires updating optarg and optind, does
not exclude the error case where the end of the argument list has been
reached. in that case, it is expected that optarg be assigned
argv[argc] (normally null) and optind be incremented by 2, resulting
in a value of argc+1.
Rich Felker [Wed, 22 Aug 2018 23:11:58 +0000 (19:11 -0400)]
fix FP_ILOGB0 and FP_ILOGBNAN definitions to be valid for use in #if
commit
98c9af500125df41fdb46d7e384b00982d72493a wrongly claimed they
do not need to be valid for such usage, but the last sentence of C11
7.1.4 ¶1 imposes a broad requirement that all macros specified as
integer constant expressions also need to be valid for #if.
simply write the value out explicitly. there is no value here in
pretending that the width of int will vary.
Rich Felker [Tue, 21 Aug 2018 00:20:31 +0000 (20:20 -0400)]
remove erroneous SYMLINK_MAX definition from limits.h, pathconf
POSIX requires the symlink function to fail with ENAMETOOLONG if the
link contents to be written exceed SYMLINK_MAX in length, but neither
Linux nor our syscall wrapper code enforce this. the value 255 for
SYMLINK_MAX is not meaningful and does not seem to have been motivated
by anything except perhaps a wrong assumption that a definition was
mandatory. it has been present (though moving through bits to
top-level limits.h) since the beginning of the project history.
[f]pathconf is entitled to return -1 as the limit for conf names for
which there is no hard limit, with the usual POSIX note that an
indefinite limit does not imply an infinite limit. in principle we
might should report a limit for filesystems that impose one, but such
functionality is not currently present for any of the pathconf limits,
and adding it is beyond the scope of fixing the incorrect limit.
Segev Finer [Wed, 15 Aug 2018 17:46:18 +0000 (20:46 +0300)]
mips archs: fix runaway execution if start fn passed to clone returns
Call SYS_exit on return from fn in __clone. This is the expected
behavior of this function. Without this the child task will crash on
return from fn, since it will return to nowhere.
Rich Felker [Thu, 16 Aug 2018 16:16:36 +0000 (12:16 -0400)]
fix pthread_create return value with PTHREAD_EXPLICIT_SCHED
due to moved code, commit
b8742f32602add243ee2ce74d804015463726899
inadvertently used the return value of __clone, rather than the return
value of SYS_sched_setscheduler in the new thread, to check whether it
needed to report failure. since a successful __clone returns the tid
of the new thread, which is never zero, this caused pthread_create
always to return with an invalid error number in the code path for
PTHREAD_EXPLICIT_SCHED.
this regression was not present in any releases.
Rich Felker [Wed, 8 Aug 2018 02:15:04 +0000 (22:15 -0400)]
fix sign of strftime %z output with offsets <1 hour west of UTC
the sign character produced came from the sign of tm_gmtoff/3600 as an
integer division, which is zero for negative offsets smaller in
magnitude than 3600. instead of printing the hours and minutes as
separate fields, print them as a single value of the form
hours*100+minutes, which naturally has the correct sign.
Rich Felker [Thu, 2 Aug 2018 23:15:48 +0000 (19:15 -0400)]
fix musl-gcc wrapper to be compatible with default-pie gcc toolchains
the specfile for the wrapper was written assuming output is pie only
if -pie appears on the command line. recent (and older patched)
versions of gcc can be configured to produce pie output by default,
adn when used with such a toolchain, the wrapper linked the wrong
startfiles (crt*) containing pic-incompatible code.
rather than trying to figure out gcc's default, simply always use the
pic-compatible start files.
Rich Felker [Fri, 27 Jul 2018 16:05:00 +0000 (12:05 -0400)]
make pthread_attr_init honor defaults set by pthread_setattr_default_np
this fixes a major gap in the intended functionality of
pthread_setattr_default_np. if application/library code creating a
thread does not pass a null attribute pointer to pthread_create, but
sets up an attribute object to change other properties while leaving
the stack alone, the created thread will get a stack with size
DEFAULT_STACK_SIZE. this makes pthread_setattr_default_np useless for
working around stack overflow issues in such applications, and leaves
a major risk of regression if previously-working code switches from
using a null attribute pointer to an attribute object.
this change aligns the behavior more closely with the glibc
pthread_setattr_default_np functionality too, albeit via a different
mechanism. glibc encodes "default" specially in the attribute object
and reads the actual default at thread creation time. with this
commit, we now copy the current default into the attribute object at
pthread_attr_init time, so that applications that query the properties
of the attribute object will see the right values.
Fangrui Song [Sun, 22 Jul 2018 00:34:00 +0000 (17:34 -0700)]
bsearch: simplify and optimize
maintainer's note: the key observation here is that the compared
element is the first slot of the second ceil(half) of the array, and
thus can be removed for further comparison when it does not match, so
that we descend into the second ceil(half)-1 rather than ceil(half)
elements. this change ensures that nel strictly decreases with each
iteration, so that the case of != but nel==1 does not need to be
special-cased anymore.
midipix [Sun, 15 Jul 2018 02:51:22 +0000 (22:51 -0400)]
move inclusion of linux headers for kd.h, soundcard.h, vt.h to bits
maintainer's note: while musl does not use the linux kernel headers,
it does provide these three sys/* headers which do nothing but include
the corresponding linux/* headers, since the sys/* versions are the
ones documented for application use (and they arguably provide
interfaces that are not linux-specific but common to other unices).
these headers should probably not be provided by libc (rather by a
separate package), but as long as they are, use the bits header
framework as an aid to out-of-tree ports of musl for non-linux systems
that want to implement them in some other way.
midipix [Sun, 15 Jul 2018 02:49:06 +0000 (22:49 -0400)]
remove inclusion guard hacks for sys/kd.h
maintainer's note: at some point, probably long before linux separated
the uapi headers, it was the case, or at least I believed it was the
case, that linux/types.h was unsafe to include from userspace. thus,
the inclusion guard macro _LINUX_TYPES_H was defined in sys/kd.h to
prevent linux/kd.h from including linux/types.h (which it spuriously
includes but does not use). as far as I can tell, whatever problem
this was meant to solve does not seem to have been present for a long
time, and the hack was not done correctly anyway, so removing it is
the right thing to do.
Rich Felker [Wed, 18 Jul 2018 17:35:35 +0000 (13:35 -0400)]
remove spurious declaration of __getdents from readdir.c
Rich Felker [Wed, 18 Jul 2018 17:25:48 +0000 (13:25 -0400)]
fix regression in alignment of dirent structs produced by readdir
commit
32482f61da7650ff10741bd5aedd66bbc3ea165b reduced the number of
int members before the dirent buf from 4 to 3, thereby misaligning it
mod sizeof(off_t), producing invalid accesses on any arch where
alignof(off_t)==sizeof(off_t).
rather than re-adding wasted padding, reorder the struct to meet the
requirement and add a comment and static assertion to prevent this
from getting broken again.
Szabolcs Nagy [Sun, 8 Jul 2018 13:16:54 +0000 (15:16 +0200)]
add support for arch-specific ptrace command macros
sys/ptrace.h is target specific, use bits/ptrace.h to add target
specific macro definitions.
these macros are kept in the generic sys/ptrace.h even though some
targets don't support them:
PTRACE_GETREGS
PTRACE_SETREGS
PTRACE_GETFPREGS
PTRACE_SETFPREGS
PTRACE_GETFPXREGS
PTRACE_SETFPXREGS
so no macro definition got removed in this patch on any target. only
s390x has a numerically conflicting macro definition (PTRACE_SINGLEBLOCK).
the PT_ aliases follow glibc headers, otherwise the definitions come
from linux uapi headers except ones that are skipped in glibc and
there is no real kernel support (s390x PTRACE_*_AREA) or need special
type definitions (mips PTRACE_*_WATCH_*) or only relevant for linux
2.4 compatibility (PTRACE_OLDSETOPTIONS).
Szabolcs Nagy [Sun, 8 Jul 2018 13:15:06 +0000 (15:15 +0200)]
sys/ptrace.h: add missing PTRACE_EVENT_STOP
new in linux v3.1 commit
3544d72a0e10d0aa1c1bd59ed77a53a59cdc12f7
changed in linux v3.4 commit
5cdf389aee90109e2e3d88085dea4dd5508a3be7
A tracer recieves this event in the waitpid status of a PTRACED_SEIZED
process.