set stream orientations in open_[w]memstream

fundamentally there is no good reason these functions need to set an
orientation (morally it should be possible to write a wchar_t[] memory
stream using byte functions, or a char[] memory stream using wide
functions), but it's a part of the specification that they do. aside
from being able to inspect the orientation with fwide, failure to set
the orientation in open_wmemstream is observable if the locale changes
between open_wmemstream and the first operation on the stream; this is
because the encoding rule (locale) for the stream is required to be
bound at the time the stream becomes wide-oriented.

for open_wmemstream, call fwide to avoid duplicating the logic for
binding the encoding rule. for open_memstream it suffices just to set
the mode field in the FILE struct.

diff --git a/src/stdio/open_memstream.c b/src/stdio/open_memstream.c
index ee834234e5cfa19ccecd3a9f9112c7fa42ff7c7d..40f5ad60caf986e253aa7241be726248b58a806c 100644 (file)
--- a/src/stdio/open_memstream.c
+++ b/src/stdio/open_memstream.c
@@ -89,6 +89,7 @@ FILE *open_memstream(char **bufp, size_t *sizep)
        f->f.write = ms_write;
        f->f.seek = ms_seek;
        f->f.close = ms_close;
+       f->f.mode = -1;
 
        if (!libc.threaded) f->f.lock = -1;
 

diff --git a/src/stdio/open_wmemstream.c b/src/stdio/open_wmemstream.c
index cb693ea75f85d39156b29c0834db74ed968418be..a7c3a64502bcfcdfa452bf3a04b579c1a78da876 100644 (file)
--- a/src/stdio/open_wmemstream.c
+++ b/src/stdio/open_wmemstream.c
@@ -94,5 +94,7 @@ FILE *open_wmemstream(wchar_t **bufp, size_t *sizep)
 
        if (!libc.threaded) f->f.lock = -1;
 
+       fwide(&f->f, 1);
+
        return __ofl_add(&f->f);
 }