firewall3: fix typo that affects ICMPv6 rules with numeric icmp_type
authorAlin Nastac <alin.nastac@gmail.com>
Tue, 10 Sep 2019 14:15:13 +0000 (16:15 +0200)
committerPetr Štetiar <ynezz@true.cz>
Sun, 15 Sep 2019 19:15:05 +0000 (21:15 +0200)
Problem can be reproduced with a rule like this:
   option src 'wan'
   option family 'ipv6'
   option proto 'icmp'
   option icmp_type '128'
   option target 'DROP'
The resulted rule will set --icmpv6-type to 128/255.

Signed-off-by: Alin Nastac <alin.nastac@gmail.com>
options.c

index c763d9e8078207bf50841e9e7b28f85653686e21..7870143b03f55297466a6540efd3730d38773f49 100644 (file)
--- a/options.c
+++ b/options.c
@@ -568,7 +568,7 @@ fw3_parse_icmptype(void *ptr, const char *val, bool is_list)
                }
 
                icmp.type6     = icmp.type;
-               icmp.code6_min = icmp.code_max;
+               icmp.code6_min = icmp.code_min;
                icmp.code6_max = icmp.code_max;
 
                v4 = true;