oweals/minetest.git
7 years agoFix wchar_t type on 605599b6f150b89ba6539c4d088231b326adcb48
Loic Blot [Sat, 20 May 2017 18:13:29 +0000 (20:13 +0200)]
Fix wchar_t type on 605599b6f150b89ba6539c4d088231b326adcb48

event.KeyInput.Char is a wchar_t, iswprint should be used

7 years agoParticle spawner: Do not spawn particles distant from player (#5766)
Paramat [Sat, 20 May 2017 14:46:35 +0000 (15:46 +0100)]
Particle spawner: Do not spawn particles distant from player (#5766)

Previously, every particle was rendered by (even if not actually visible to)
the client regardless of distance. This significantly reduced client FPS.

Acts clientside, particle spawners are always sent to clients, but each
particle is checked for distance from the player.
As with 'add particle' the distance limit is set to 'max block send distance'
as this determines how far a client can see.

7 years ago[CSM] Correct the log destination of print() (#5784)
SmallJoker [Sat, 20 May 2017 14:46:12 +0000 (16:46 +0200)]
[CSM] Correct the log destination of print() (#5784)

7 years agoFix CSM crash (#5779)
red-001 [Sat, 20 May 2017 14:45:49 +0000 (15:45 +0100)]
Fix CSM crash (#5779)

Caused by dc5bc6c and them made worse by 5ebf8f9

7 years agoTypo fix in README.txt
Loic Blot [Sat, 20 May 2017 14:04:44 +0000 (16:04 +0200)]
Typo fix in README.txt

Fix issue #4293

7 years agoAdd /clearinv chat command (#4994)
Elijah Duffy [Sat, 20 May 2017 10:56:17 +0000 (03:56 -0700)]
Add /clearinv chat command (#4994)

Allow players to clear their own inventory or that of another player with /clearinv command. server privilege is required to clear another player's inventory, no privileges are required to clear your own inventory.'

7 years agochat.cpp fix wchar_t isspace -> iswspace & wrong isspace on an index (#5783)
Loïc Blot [Sat, 20 May 2017 10:56:02 +0000 (12:56 +0200)]
chat.cpp fix wchar_t isspace -> iswspace & wrong isspace on an index (#5783)

7 years agoCleanup in content_mapblock (#5746)
numberZero [Sat, 20 May 2017 10:29:54 +0000 (14:29 +0400)]
Cleanup in content_mapblock (#5746)

NDT_LIQUID is being drawn by MapBlockMesh since a long time ago...

7 years agoImprove password change menu (#5757)
red-001 [Sat, 20 May 2017 10:29:44 +0000 (11:29 +0100)]
Improve password change menu (#5757)

- Fix the GUI getting messed up when resizing
- Save the input when resizing

7 years agoFix shift key producing space in console (#5777)
Craig Davison [Sat, 20 May 2017 10:29:31 +0000 (11:29 +0100)]
Fix shift key producing space in console (#5777)

* Fix shift key producing space in console

7 years agothis might fix #5661, needs testing (#5775)
red-001 [Sat, 20 May 2017 08:48:44 +0000 (09:48 +0100)]
this might fix #5661, needs testing (#5775)

7 years ago[CSM] Fix crash when the minimap is disabled. Caused by e25a38e
SmallJoker [Sat, 20 May 2017 08:12:37 +0000 (10:12 +0200)]
[CSM] Fix crash when the minimap is disabled. Caused by e25a38e

7 years agoFix input regression introduced by a4a377ecad6f1732cc54e7ac329fdef9949f9bf7
Loic Blot [Sat, 20 May 2017 08:12:54 +0000 (10:12 +0200)]
Fix input regression introduced by a4a377ecad6f1732cc54e7ac329fdef9949f9bf7

Fix #5776

7 years agoFix mem leak in mesh cache (#5781)
Zeno- [Sat, 20 May 2017 06:16:16 +0000 (16:16 +1000)]
Fix mem leak in mesh cache (#5781)

7 years agoVarious code cleanup & little performance improvement on HTTP download (#5772)
Loïc Blot [Sat, 20 May 2017 06:15:56 +0000 (08:15 +0200)]
Various code cleanup & little performance improvement on HTTP download (#5772)

* Disable or remove unused enum members/functions
* Tiny code style fixes
* Make some functions const
* Replace ClientMediaDownloader std::unordered_map with std::map

7 years agoDo not create dummy normalmaps (#4180)
you [Fri, 19 May 2017 06:08:12 +0000 (08:08 +0200)]
Do not create dummy normalmaps (#4180)

fixes #1811

7 years agoFix textarea bug: clicking right of the end of a line caused the cursor to be in...
you [Fri, 19 May 2017 05:57:21 +0000 (07:57 +0200)]
Fix textarea bug: clicking right of the end of a line caused the cursor to be in one of the next lines (#3474)

7 years agoFix alpha for liquid nodes (#5494)
Dániel Juhász [Fri, 19 May 2017 05:46:10 +0000 (07:46 +0200)]
Fix alpha for liquid nodes (#5494)

7 years agoMainmenu: Fix issues while trying to enable all mods (#5770)
SmallJoker [Fri, 19 May 2017 05:45:47 +0000 (07:45 +0200)]
Mainmenu: Fix issues while trying to enable all mods (#5770)

7 years agoWhen minimap is disabled in configuration, really disable it (#5771)
Loïc Blot [Fri, 19 May 2017 05:25:27 +0000 (07:25 +0200)]
When minimap is disabled in configuration, really disable it (#5771)

* When minimap is disabled in configuration, really disable it

7 years agoFix a warning pointed by GCC 7.1
Loic Blot [Thu, 18 May 2017 18:55:27 +0000 (20:55 +0200)]
Fix a warning pointed by GCC 7.1

lua_tonumber overflow in snprintf (12 bytes and only 10 can be written)

7 years agoBuiltin: Fix subgame mod selection (#5367)
SmallJoker [Wed, 17 May 2017 17:31:57 +0000 (19:31 +0200)]
Builtin: Fix subgame mod selection (#5367)

7 years agoParticles: Do not send single particles to distant clients (#5760)
Paramat [Wed, 17 May 2017 08:37:28 +0000 (09:37 +0100)]
Particles: Do not send single particles to distant clients (#5760)

Previously, every individual particle on a server is sent to, and rendered by
(even if not actually visible), every client regardless of distance. This
significantly reduces client FPS and creates unnecessary network traffic.
Maximum distance is set by 'max block send distance' as this determines how far
a client is able to see.

7 years agoAppend -debug to version string (#5765)
bigfoot547 [Wed, 17 May 2017 07:41:41 +0000 (02:41 -0500)]
Append -debug to version string (#5765)

7 years agoCSM: Document forgotten functions
SmallJoker [Sat, 13 May 2017 11:14:41 +0000 (13:14 +0200)]
CSM: Document forgotten functions

7 years agoCaverns: Remove unnecessary liquid excavation
paramat [Thu, 11 May 2017 02:39:43 +0000 (03:39 +0100)]
Caverns: Remove unnecessary liquid excavation

Also disable CavesRandomWalk at a safer distance from caverns.

Excavating liquids in cavern code is unnecessary as in practice we are already
successfully disabling the generation of liquid caves that could intersect
with caverns and cause excessive amounts of spreading liquids in caverns.

However to be safer this commit now disables liquid caves at a larger distance
from caverns, to compensate for liquid caves being able to generate up to a
mapblock beyond a mapchunk border.

Not excavating liquids in cavern code also allows a feature i am working on in
experimental new core mapgens, but also allows for more flexibility in future.

7 years agoFix a memleak pointed by @Zeno- in MeshUpdateQueue
Loic Blot [Tue, 16 May 2017 06:27:18 +0000 (08:27 +0200)]
Fix a memleak pointed by @Zeno- in MeshUpdateQueue

This leak was introduced when added cache to MeshUpdateQueue and only occurs when leaving world.

7 years agoFix uninitalised variable in event.cpp (#5764)
Zeno- [Mon, 15 May 2017 10:10:29 +0000 (20:10 +1000)]
Fix uninitalised variable in event.cpp (#5764)

7 years agoAdd option to use neither node highlighting nor outlining
ezhh [Thu, 11 May 2017 22:18:36 +0000 (23:18 +0100)]
Add option to use neither node highlighting nor outlining

7 years agoNo cursor lock when window inactive (#5754)
SmallJoker [Sat, 13 May 2017 15:42:42 +0000 (17:42 +0200)]
No cursor lock when window inactive (#5754)

7 years agoAndroid dependencies updates (#5755)
Loïc Blot [Sat, 13 May 2017 11:32:59 +0000 (13:32 +0200)]
Android dependencies updates (#5755)

* irrlicht ogles 5122 -> 5145
* openssl 1.0.2j -> 1.0.2k
* curl 7.52 -> 7.54
* sqlite 3.15.2 -> 3.18.0

7 years agoLimit properly the sound setting at updateSound runtime step (#5753)
Loïc Blot [Sat, 13 May 2017 10:03:11 +0000 (12:03 +0200)]
Limit properly the sound setting at updateSound runtime step (#5753)

* Limit properly the sound setting at updateSound runtime step

Fix #5026

* Add a comment

7 years agoMove KeyList & InputHandler from game.h to client/inputhandler.h (#5752)
Loïc Blot [Sat, 13 May 2017 09:05:16 +0000 (11:05 +0200)]
Move KeyList & InputHandler from game.h to client/inputhandler.h (#5752)

* Move KeyList & InputHandler from game.h to client/inputhandler.h

We have a header for inputs, move inputhandler class & related keylist object to it

Also introduce a cpp file for MyEventReceiver::OnEvent function in inputhandler.h because a so huge function doesn't needs to be inlined

* Pass clang-format on inputhandler.{cpp,h} (compatible)

7 years agoAndroid build fix
Loic Blot [Sat, 13 May 2017 07:09:02 +0000 (09:09 +0200)]
Android build fix

7 years agoMinor pause/escape menu improvements (#5751)
red-001 [Sat, 13 May 2017 06:50:19 +0000 (07:50 +0100)]
Minor pause/escape menu improvements (#5751)

- Split movement keys into separate entries.
- Increase buffer size due to the above change.
- Change capitalisation.
- Remove code-style violating white spaces.

7 years agoReplace inconsistent mentions of core.* with minetest.* (#5749)
rubenwardy [Fri, 12 May 2017 09:27:58 +0000 (10:27 +0100)]
Replace inconsistent mentions of core.* with minetest.* (#5749)

7 years agoRework escape/pause menu (#5719)
red-001 [Thu, 11 May 2017 08:39:37 +0000 (09:39 +0100)]
Rework escape/pause menu (#5719)

* Rework escape/pause menu

- Remove build information
- Use current controls instead of default controls
- Add information about the current server in place of the build information
- Add text saying the game is paused to if in singleplayer mode.
rework pause/escape menu

* improve consistency + display server_name

7 years agoMenu: Fix starting a server if the server address is an empty string. (#5742)
red-001 [Wed, 10 May 2017 21:25:45 +0000 (22:25 +0100)]
Menu: Fix starting a server if the server address is an empty string. (#5742)

Minetest uses an empty string internal to signal that a server should be started.

7 years agoPrivate nodemeta (#5702)
sfan5 [Wed, 10 May 2017 13:29:21 +0000 (15:29 +0200)]
Private nodemeta (#5702)

* Private node metadata that isn't sent to the client

7 years agominetest.deserialize: Throw error when argument not string (#5738)
SmallJoker [Tue, 9 May 2017 21:11:20 +0000 (23:11 +0200)]
minetest.deserialize: Throw error when argument not string (#5738)

7 years agoAndroid: Fix crash while loading main menu (#5736)
red-001 [Tue, 9 May 2017 16:30:34 +0000 (17:30 +0100)]
Android: Fix crash while loading main menu (#5736)

Broken by 43d1f37

7 years agoAdd cancel button to password change menu. (#5720)
red-001 [Tue, 9 May 2017 09:04:45 +0000 (10:04 +0100)]
Add cancel button to password change menu. (#5720)

* Add cancel button to password change menu.

7 years agoMove Pilzadam to previous developers. (#5735)
Auke Kok [Tue, 9 May 2017 06:56:57 +0000 (23:56 -0700)]
Move Pilzadam to previous developers. (#5735)

7 years agoRevert custom player collision box and step height commits
paramat [Tue, 9 May 2017 00:59:02 +0000 (01:59 +0100)]
Revert custom player collision box and step height commits

These caused inability to pass through 2 node high spaces or step up onto slabs
or steps when a new client connected to an older server.

7 years agoread_schematic_replacements: ensure fields are strings (#5726)
Loïc Blot [Mon, 8 May 2017 18:43:03 +0000 (20:43 +0200)]
read_schematic_replacements: ensure fields are strings (#5726)

* read_schematic_replacements: ensure fields are strings

add a type check before reading strings on read_schematic_replacements deserializer

* throw LuaError instead of asserting the whole client

7 years agoCustom step height: Fix implementation
paramat [Mon, 8 May 2017 00:27:11 +0000 (01:27 +0100)]
Custom step height: Fix implementation

Recent commit 45ab62d6a3d90ab3b97aec88251a766cb5dd1899 had a coding error that
made climbing out of water difficult due to an incorrect value of the step height
when not 'touching ground'.
It also incorrectly multiplied the custom stepheight by BS, resulting in being
able to step-up 2 nodes if set to the default of 0.6, or even 0.3.
Also the implementation was wrong because it customised the step height when
not 'touching ground', this step height is for a slight rise when catching the
edge of a node during a jump, and should always remain at 0.2 * BS.

7 years agoShaders: Remove unused water surface shader
paramat [Fri, 5 May 2017 01:12:47 +0000 (02:12 +0100)]
Shaders: Remove unused water surface shader

Also remove hardcoded MTGame node.

The 'water surface shader' was duplicated shader code in preparation for
intended new water surface shaders. For development purposes the MTGame node
'default:water_source' had it's top tile assigned to 'water surface shader'.
Due to shader duplication this commit does not cause any change to shader
behaviour.

7 years agoPlayer attrs: permits to remove an attribute by setting value to nil (#5716)
Loïc Blot [Sun, 7 May 2017 10:13:15 +0000 (12:13 +0200)]
Player attrs: permits to remove an attribute by setting value to nil (#5716)

* Player attrs: permits to remove an attribute by setting value to nil

When doing player:set_attribute("attr", nil) remove attribute

Also remove a useless check on C++ API part (already done by checkplayer)

Fix #5709

7 years agoLINT fix since d0678948165768472fc940c03e78cba787f49ea5
Loic Blot [Sun, 7 May 2017 09:07:17 +0000 (11:07 +0200)]
LINT fix since d0678948165768472fc940c03e78cba787f49ea5

7 years agoPlayer properties: Set correct default collisionbox
paramat [Sun, 7 May 2017 00:48:42 +0000 (01:48 +0100)]
Player properties: Set correct default collisionbox

Recent commit b6f4a9c7e1a4f0bac66fd6f6ff844425ac775975 removed a hardcoded
player collisionbox which resulted on falling back to an incorrect default.
This stopped players walking through 2-node high spaces and made the player
slightly wider.

Improve docs for custom player collisionbox feature and reformat nearby lines.

7 years agoReplace occurrence of luaL_reg in l_camera.cpp
T0ny2 [Sat, 6 May 2017 23:37:37 +0000 (00:37 +0100)]
Replace occurrence of luaL_reg in l_camera.cpp

Related to commit 41c5483. Replace an occurrence of luaL_reg in
src/script/lua_api/l_camera.cpp (added by commit de028fc).

7 years agoFix myfloor(0.0)
ShadowNinja [Fri, 16 Oct 2015 16:52:24 +0000 (12:52 -0400)]
Fix myfloor(0.0)

7 years agoClean up numeric.h and split FacePositionCache from it
ShadowNinja [Mon, 6 Jul 2015 16:53:30 +0000 (12:53 -0400)]
Clean up numeric.h and split FacePositionCache from it

I also optiized FacePositionCache a bit: I removed a map
lookup and vector copy from both branches of getFacePosition.

7 years agoMake the player collisionbox settable
TeTpaAka [Fri, 29 May 2015 18:30:55 +0000 (20:30 +0200)]
Make the player collisionbox settable

7 years agoUse a settings object for the main settings 1949/head
ShadowNinja [Fri, 12 Dec 2014 19:49:19 +0000 (14:49 -0500)]
Use a settings object for the main settings

This unifies the settings APIs.

This also unifies the sync and async registration APIs, since the async
registration API did not support adding non-functions to the API table.

7 years agoFix codestyle since CSM Camera API
Loic Blot [Sat, 6 May 2017 19:30:27 +0000 (21:30 +0200)]
Fix codestyle since CSM Camera API

7 years agoAdd configurable key bindings for hotbar scrolling, and for changing volume.
Wuzzy [Thu, 3 Jul 2014 05:46:19 +0000 (07:46 +0200)]
Add configurable key bindings for hotbar scrolling, and for changing volume.

7 years agoUse stepheight from CAO instead of hardcoded value 5710/head
Sapier [Sat, 19 Dec 2015 15:37:13 +0000 (16:37 +0100)]
Use stepheight from CAO instead of hardcoded value

7 years ago[CSM] add `on_item_use` (#5544)
red-001 [Sat, 6 May 2017 19:12:44 +0000 (20:12 +0100)]
[CSM] add `on_item_use` (#5544)

7 years agoMake players respect makes_footstep_sound in the object properties
TeTpaAka [Sun, 28 Jun 2015 18:51:59 +0000 (20:51 +0200)]
Make players respect makes_footstep_sound in the object properties

7 years ago[CSM] Add camera API (#5609)
bigfoot547 [Fri, 5 May 2017 20:07:36 +0000 (15:07 -0500)]
[CSM] Add camera API (#5609)

* [CSM] Add camera API
roper rebase & squash

* Address nerzhul's review

7 years agoClouds API: Fix yellow clouds at dawn and dusk (#5707)
Paramat [Fri, 5 May 2017 20:07:25 +0000 (21:07 +0100)]
Clouds API: Fix yellow clouds at dawn and dusk (#5707)

7 years agoAdd missing server sending rule for bd921a7916f0fafc493b1c4d0eeb5e2bb1d6a7c2
Loic Blot [Fri, 5 May 2017 18:21:04 +0000 (20:21 +0200)]
Add missing server sending rule for bd921a7916f0fafc493b1c4d0eeb5e2bb1d6a7c2

7 years agoFix Android build (#5706)
Wayward One [Fri, 5 May 2017 15:27:50 +0000 (11:27 -0400)]
Fix Android build (#5706)

* Fix Android build

7 years agoSave minetest screen width/height options when modified (#5683)
Loïc Blot [Fri, 5 May 2017 11:47:11 +0000 (13:47 +0200)]
Save minetest screen width/height options when modified (#5683)

* Save minetest screen width/height options when modified

* Add autosave_screensize setting (default true)

* Fix @SmallJoker comments

7 years agoAdd option to also check the center to `find_node_near` (#5255)
red-001 [Thu, 4 May 2017 20:52:58 +0000 (21:52 +0100)]
Add option to also check the center to `find_node_near` (#5255)

* Add option to also check the center to `find_node_near`

7 years agoTranslated using Weblate (Esperanto)
yellowcrash10 [Mon, 1 May 2017 00:23:55 +0000 (00:23 +0000)]
Translated using Weblate (Esperanto)

Currently translated at 31.9% (293 of 918 strings)

7 years agoTranslated using Weblate (Italian)
Michele Mainardi [Tue, 25 Apr 2017 19:08:03 +0000 (19:08 +0000)]
Translated using Weblate (Italian)

Currently translated at 96.0% (882 of 918 strings)

7 years agoTranslated using Weblate (Portuguese)
Mário [Sun, 23 Apr 2017 14:54:32 +0000 (14:54 +0000)]
Translated using Weblate (Portuguese)

Currently translated at 66.9% (615 of 918 strings)

7 years agoTranslated using Weblate (Belarusian)
Viktar Vauchkevich [Sat, 22 Apr 2017 21:15:02 +0000 (21:15 +0000)]
Translated using Weblate (Belarusian)

Currently translated at 100.0% (918 of 918 strings)

7 years agoTranslated using Weblate (Spanish)
David Capello [Mon, 24 Apr 2017 00:43:47 +0000 (00:43 +0000)]
Translated using Weblate (Spanish)

Currently translated at 58.0% (533 of 918 strings)

7 years agoTranslated using Weblate (Spanish)
Laura Arjona Reina [Tue, 18 Apr 2017 18:24:03 +0000 (18:24 +0000)]
Translated using Weblate (Spanish)

Currently translated at 57.9% (532 of 918 strings)

7 years agoAdded translation using Weblate (Swedish)
metarmask [Fri, 14 Apr 2017 13:17:21 +0000 (13:17 +0000)]
Added translation using Weblate (Swedish)

7 years agoTranslated using Weblate (Japanese)
BreadW [Tue, 18 Apr 2017 12:21:48 +0000 (12:21 +0000)]
Translated using Weblate (Japanese)

Currently translated at 49.6% (456 of 918 strings)

7 years agoTranslated using Weblate (Japanese)
monolifed [Wed, 12 Apr 2017 21:55:43 +0000 (21:55 +0000)]
Translated using Weblate (Japanese)

Currently translated at 49.4% (454 of 918 strings)

7 years agoTranslated using Weblate (Russian)
Andrey K [Fri, 7 Apr 2017 10:25:53 +0000 (10:25 +0000)]
Translated using Weblate (Russian)

Currently translated at 60.1% (552 of 918 strings)

7 years agoTranslated using Weblate (Turkish)
monolifed [Sun, 9 Apr 2017 16:36:26 +0000 (16:36 +0000)]
Translated using Weblate (Turkish)

Currently translated at 93.6% (860 of 918 strings)

7 years agoTranslated using Weblate (Malay)
Muhammad Nur Hidayat Yasuyoshi [Fri, 7 Apr 2017 09:54:49 +0000 (09:54 +0000)]
Translated using Weblate (Malay)

Currently translated at 54.9% (504 of 918 strings)

7 years agoRemove CMAKE -ffast-math flag from OSX/FreeBSD
Vaughan Lapsley [Wed, 12 Apr 2017 12:54:03 +0000 (22:54 +1000)]
Remove CMAKE -ffast-math flag from OSX/FreeBSD

Fixes issue: #4274

I have tested on MacOS 10.12.4

Requires testing on:
FreeBSD, Windows and Linux which I do not have access to.

7 years agoLINT fix since cloud API merge
Loic Blot [Thu, 4 May 2017 05:52:31 +0000 (07:52 +0200)]
LINT fix since cloud API merge

7 years agoDirectional coloured fog: Fix order of SColor components
paramat [Thu, 4 May 2017 02:02:16 +0000 (03:02 +0100)]
Directional coloured fog: Fix order of SColor components

'video::SColor pointcolor' was initialised with order RGBA instead of ARGB.
No change in behaviour as 'm_bgcolor' has alpha 255.

7 years agoClouds: Fix reddish clouds. Add missing alpha update
paramat [Tue, 2 May 2017 00:37:23 +0000 (01:37 +0100)]
Clouds: Fix reddish clouds. Add missing alpha update

Fix accidental swap of red and blue components that caused reddish clouds
Add missing update of alpha in remoteplayer.cpp

7 years agoAdd function to get server info.
red-001 [Wed, 19 Apr 2017 13:16:54 +0000 (14:16 +0100)]
Add function to get server info.

7 years agoFading soungs: Fix client crash on older servers
SmallJoker [Wed, 3 May 2017 11:48:46 +0000 (13:48 +0200)]
Fading soungs: Fix client crash on older servers

7 years agoSet sky API: Add bool for clouds in front of custom skybox
paramat [Fri, 28 Apr 2017 02:06:49 +0000 (03:06 +0100)]
Set sky API: Add bool for clouds in front of custom skybox

Default true.
Add 'm_clouds_enabled' bool to sky.h, set from new bool in 'set sky' API.
Make 'getCloudsVisible()' depend on 'm_clouds_enabled' instead of
'm_visible' (whether normal sky is visible).

7 years agoSneak: Improve and fix various things
SmallJoker [Sat, 1 Apr 2017 18:38:14 +0000 (20:38 +0200)]
Sneak: Improve and fix various things

Remove useless `got_teleported`.
Fix jitter when walking against the sneak limits.
Fix damage evading on sneak ladders.

7 years agoSound API: Add fading sounds
Brandon [Sun, 10 Jul 2016 05:08:26 +0000 (00:08 -0500)]
Sound API: Add fading sounds

7 years agoAdd clouds API
Ben Deutsch [Fri, 17 Mar 2017 09:39:47 +0000 (10:39 +0100)]
Add clouds API

7 years agoOptimize updateFastFaceRow processing by removing some TileSpec copy (#5678)
Loïc Blot [Sat, 29 Apr 2017 18:36:09 +0000 (20:36 +0200)]
Optimize updateFastFaceRow processing by removing some TileSpec copy (#5678)

* Optimize updateFastFaceRow processing by removing some TileSpec copy

It permit to decrease this function from 54% runtime to 45% and reduce copy from 14% runtime to 12.5%
getTileInfo also reduced from 27% to 23%

* makeFastFace should use a const ref too

this trigger a const pointer need in the underlying function

Also fix some code style and prevent calculating 4 times the same position at a point

* Reduce a comparison cost for lights in updateFastFaceRow

7 years agoFix visual slide issue with set_detach, fixes #5620
shivajiva101 [Sat, 29 Apr 2017 16:18:46 +0000 (17:18 +0100)]
Fix visual slide issue with set_detach, fixes #5620

7 years agocontent_cao: fix getPlayerControl structure copy on each step (#5677)
Loïc Blot [Sat, 29 Apr 2017 16:16:58 +0000 (18:16 +0200)]
content_cao: fix getPlayerControl structure copy on each step (#5677)

Also fix some codestyle issues around it.

7 years agoClient & ClientEnvirnment: don't create fake events (#5676)
Loïc Blot [Sat, 29 Apr 2017 15:25:25 +0000 (17:25 +0200)]
Client & ClientEnvirnment: don't create fake events (#5676)

Instead of create fake events on the stack on each loop call (Game::run), verify is queue is empty or not and handle event directly if there is.

This prevents fake ClientEvent creation & memory allocations

Same fix is also applied on ClientEnvironment, & rename getClientEvent to getClientEnvEvent to match ClientEnvEvent object

7 years agoFix Travis/unittest broken since b662a45
SmallJoker [Sat, 29 Apr 2017 12:36:55 +0000 (14:36 +0200)]
Fix Travis/unittest broken since b662a45

7 years agoRemove legacy unused define DIGGING_PARTICLES_AMOUNT
Loic Blot [Sat, 29 Apr 2017 10:18:14 +0000 (12:18 +0200)]
Remove legacy unused define DIGGING_PARTICLES_AMOUNT

7 years ago[CSM] Add event on_place_node API lua (#5548)
Vincent Glize [Sat, 29 Apr 2017 10:08:16 +0000 (12:08 +0200)]
[CSM] Add event on_place_node API lua (#5548)

* [CSM] Add event on_place_node API lua

7 years agoFix Lint broken by b662a4577d692329b9ca83525e6039f2ddcd1ac1
Loic Blot [Sat, 29 Apr 2017 07:47:22 +0000 (09:47 +0200)]
Fix Lint broken by b662a4577d692329b9ca83525e6039f2ddcd1ac1

7 years agoReorder TileLayer. (#5638)
Auke Kok [Sat, 29 Apr 2017 07:16:32 +0000 (00:16 -0700)]
Reorder TileLayer. (#5638)

Despite the split of TileSpec into TileDef and TileLayer, the
TileLayer struct is still 66 bytes large, and doesn't fit in
a single cacheline.

I'm moving the color member to cacheline 2, in the hope that it
is less used and the compiler loads all the hot members in a single
cacheline instead. Only color sits now in cacheline 2, all the
other members are in cacheline 1.

Note: is_color is probably rarely set, most nodes will likely
not use hardware coloring, but this may change in the future.
Ideally, this class is shrunk to 64 bytes.

7 years ago[CSM] add screenshot api lua (#5674)
Vincent Glize [Sat, 29 Apr 2017 07:16:06 +0000 (09:16 +0200)]
[CSM] add screenshot api lua (#5674)

* [CSM] add screenshot api lua

7 years agoClean up getTime helpers
ShadowNinja [Sun, 6 Mar 2016 19:31:16 +0000 (14:31 -0500)]
Clean up getTime helpers

This increases size of the getTime return values to 64 bits.
It also removes the TimeGetter classes since the getTime functions
are now very precise.

7 years agoFix click-digging torches (#5652)
you [Fri, 28 Apr 2017 18:12:28 +0000 (20:12 +0200)]
Fix click-digging torches (#5652)

Torches are dug instantly again.
When the digging time is 0, a delay of 0.15 seconds is added between digging nodes. If the left mouse button is released, the delay is set to 0, thus click-digging.