-removing legacy #ifdefs
[oweals/gnunet.git] / src / util / server.c
index bf4eb45184da4b0c7a25969dca08e98bf0363bae..dc8b402da9ab6374d4812ef95a28d99d18671447 100644 (file)
@@ -22,9 +22,6 @@
  * @file util/server.c
  * @brief library for building GNUnet network servers
  * @author Christian Grothoff
- *
- * TODO:
- * - fix inefficient memmove in message processing
  */
 
 #include "platform.h"
 #include "gnunet_disk_lib.h"
 #include "gnunet_protocols.h"
 
-#define DEBUG_SERVER GNUNET_NO
+#define LOG(kind,...) GNUNET_log_from (kind, "util", __VA_ARGS__)
+
+#define LOG_STRERROR(kind,syscall) GNUNET_log_from_strerror (kind, "util", syscall)
+
+#define LOG_STRERROR_FILE(kind,syscall,filename) GNUNET_log_from_strerror_file (kind, "util", syscall, filename)
+
 
 /**
  * List of arrays of message handlers.
@@ -82,11 +84,6 @@ struct NotifyList
  */
 struct GNUNET_SERVER_Handle
 {
-  /**
-   * My scheduler.
-   */
-  struct GNUNET_SCHEDULER_Handle *sched;
-
   /**
    * List of handlers for incoming messages.
    */
@@ -124,11 +121,6 @@ struct GNUNET_SERVER_Handle
    */
   struct GNUNET_TIME_Relative idle_timeout;
 
-  /**
-   * maximum write buffer size for accepted sockets
-   */
-  size_t maxbuf;
-
   /**
    * Task scheduled to do the listening.
    */
@@ -147,6 +139,10 @@ struct GNUNET_SERVER_Handle
    */
   int clients_ignore_shutdown;
 
+  GNUNET_SERVER_MstCreateCallback mst_create;
+  GNUNET_SERVER_MstDestroyCallback mst_destroy;
+  GNUNET_SERVER_MstReceiveCallback mst_receive;
+  void *mst_cls;
 };
 
 
@@ -157,15 +153,14 @@ struct GNUNET_SERVER_Client
 {
 
   /**
-   * Size of the buffer for incoming data.  Should be
-   * first so we get nice alignment.
+   * This is a linked list.
    */
-  char incoming_buffer[GNUNET_SERVER_MAX_MESSAGE_SIZE];
+  struct GNUNET_SERVER_Client *next;
 
   /**
-   * This is a linked list.
+   * Processing of incoming data.
    */
-  struct GNUNET_SERVER_Client *next;
+  void *mst;
 
   /**
    * Server that this client belongs to.
@@ -175,65 +170,44 @@ struct GNUNET_SERVER_Client
   /**
    * Client closure for callbacks.
    */
-  void *client_closure;
-
-  /**
-   * Callback to receive from client.
-   */
-  GNUNET_SERVER_ReceiveCallback receive;
+  struct GNUNET_CONNECTION_Handle *connection;
 
   /**
-   * Callback to cancel receive from client.
-   */
-  GNUNET_SERVER_ReceiveCancelCallback receive_cancel;
-
-  /**
-   * Callback to ask about transmit-ready notification.
-   */
-  GNUNET_SERVER_TransmitReadyCallback notify_transmit_ready;
-
-  /**
-   * Callback to ask about transmit-ready notification.
+   * ID of task used to restart processing.
    */
-  GNUNET_SERVER_TransmitReadyCancelCallback notify_transmit_ready_cancel;
+  GNUNET_SCHEDULER_TaskIdentifier restart_task;
 
   /**
-   * Callback to check if client is still valid.
+   * Task that warns about missing calls to 'GNUNET_SERVER_receive_done'.
    */
-  GNUNET_SERVER_CheckCallback check;
+  GNUNET_SCHEDULER_TaskIdentifier warn_task;
 
   /**
-   * Callback to destroy client.
+   * Time when the warn task was started.
    */
-  GNUNET_SERVER_DestroyCallback destroy;
+  struct GNUNET_TIME_Absolute warn_start;
 
   /**
-   * Side-buffer for incoming data used when processing
-   * is suspended.
+   * Last activity on this socket (used to time it out
+   * if reference_count == 0).
    */
-  char *side_buf;
+  struct GNUNET_TIME_Absolute last_activity;
 
   /**
-   * ID of task used to restart processing.
+   *
    */
-  GNUNET_SCHEDULER_TaskIdentifier restart_task;
+  GNUNET_CONNECTION_TransmitReadyNotify callback;
 
   /**
-   * Number of bytes in the side buffer.
+   * callback
    */
-  size_t side_buf_size;
-
-  /**
-   * Last activity on this socket (used to time it out
-   * if reference_count == 0).
-   */
-  struct GNUNET_TIME_Absolute last_activity;
+  void *callback_cls;
 
   /**
-   * How many bytes in the "incoming_buffer" are currently
-   * valid? (starting at offset 0).
+   * After how long should an idle connection time
+   * out (on write).
    */
-  size_t receive_pos;
+  struct GNUNET_TIME_Relative idle_timeout;
 
   /**
    * Number of external entities with a reference to
@@ -266,9 +240,27 @@ struct GNUNET_SERVER_Client
   int shutdown_now;
 
   /**
-   * Are we currently trying to receive?
+   * Are we currently trying to receive? (YES if we are, NO if we are not,
+   * SYSERR if data is already available in MST).
    */
   int receive_pending;
+
+  /**
+   * Finish pending write when disconnecting?
+   */
+  int finish_pending_write;
+
+  /**
+   * Persist the file handle for this client no matter what happens,
+   * force the OS to close once the process actually dies.  Should only
+   * be used in special cases!
+   */
+  int persist;
+
+  /**
+   * Type of last message processed (for warn_no_receive_done).
+   */
+  uint16_t warn_type;
 };
 
 
@@ -280,8 +272,7 @@ struct GNUNET_SERVER_Client
  * @param tc reason why we are running right now
  */
 static void
-process_listen_socket (void *cls,
-                       const struct GNUNET_SCHEDULER_TaskContext *tc)
+process_listen_socket (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
 {
   struct GNUNET_SERVER_Handle *server = cls;
   struct GNUNET_CONNECTION_Handle *sock;
@@ -295,52 +286,43 @@ process_listen_socket (void *cls,
   while (NULL != server->listen_sockets[i])
     GNUNET_NETWORK_fdset_set (r, server->listen_sockets[i++]);
   if (0 != (tc->reason & GNUNET_SCHEDULER_REASON_SHUTDOWN))
-    {
-      /* ignore shutdown, someone else will take care of it! */
-      server->listen_task = GNUNET_SCHEDULER_add_select (server->sched,
-                                                         GNUNET_SCHEDULER_PRIORITY_HIGH,
-                                                         GNUNET_SCHEDULER_NO_TASK,
-                                                         GNUNET_TIME_UNIT_FOREVER_REL,
-                                                         r, NULL,
-                                                         &process_listen_socket,
-                                                         server);
-      GNUNET_NETWORK_fdset_destroy (r);
-      return;
-    }
+  {
+    /* ignore shutdown, someone else will take care of it! */
+    server->listen_task =
+        GNUNET_SCHEDULER_add_select (GNUNET_SCHEDULER_PRIORITY_HIGH,
+                                     GNUNET_SCHEDULER_NO_TASK,
+                                     GNUNET_TIME_UNIT_FOREVER_REL, r, NULL,
+                                     &process_listen_socket, server);
+    GNUNET_NETWORK_fdset_destroy (r);
+    return;
+  }
   i = 0;
   while (NULL != server->listen_sockets[i])
+  {
+    if (GNUNET_NETWORK_fdset_isset (tc->read_ready, server->listen_sockets[i]))
     {
-      if (GNUNET_NETWORK_fdset_isset
-          (tc->read_ready, server->listen_sockets[i]))
-        {
-          sock =
-            GNUNET_CONNECTION_create_from_accept (tc->sched, server->access,
-                                                  server->access_cls,
-                                                  server->listen_sockets[i],
-                                                  server->maxbuf);
-          if (sock != NULL)
-            {
-#if DEBUG_SERVER
-              GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                          "Server accepted incoming connection.\n");
-#endif
-              client = GNUNET_SERVER_connect_socket (server, sock);
-              GNUNET_CONNECTION_ignore_shutdown (sock,
-                                                 server->clients_ignore_shutdown);
-              /* decrement reference count, we don't keep "client" alive */
-              GNUNET_SERVER_client_drop (client);
-            }
-        }
-      i++;
+      sock =
+          GNUNET_CONNECTION_create_from_accept (server->access,
+                                                server->access_cls,
+                                                server->listen_sockets[i]);
+      if (sock != NULL)
+      {
+        LOG (GNUNET_ERROR_TYPE_DEBUG, "Server accepted incoming connection.\n");
+        client = GNUNET_SERVER_connect_socket (server, sock);
+        GNUNET_CONNECTION_ignore_shutdown (sock,
+                                           server->clients_ignore_shutdown);
+        /* decrement reference count, we don't keep "client" alive */
+        GNUNET_SERVER_client_drop (client);
+      }
     }
+    i++;
+  }
   /* listen for more! */
-  server->listen_task = GNUNET_SCHEDULER_add_select (server->sched,
-                                                     GNUNET_SCHEDULER_PRIORITY_HIGH,
-                                                     GNUNET_SCHEDULER_NO_TASK,
-                                                     GNUNET_TIME_UNIT_FOREVER_REL,
-                                                     r, NULL,
-                                                     &process_listen_socket,
-                                                     server);
+  server->listen_task =
+      GNUNET_SCHEDULER_add_select (GNUNET_SCHEDULER_PRIORITY_HIGH,
+                                   GNUNET_SCHEDULER_NO_TASK,
+                                   GNUNET_TIME_UNIT_FOREVER_REL, r, NULL,
+                                   &process_listen_socket, server);
   GNUNET_NETWORK_fdset_destroy (r);
 }
 
@@ -361,64 +343,86 @@ open_listen_socket (const struct sockaddr *serverAddr, socklen_t socklen)
   int eno;
 
   switch (serverAddr->sa_family)
-    {
-    case AF_INET:
-      port = ntohs (((const struct sockaddr_in *) serverAddr)->sin_port);
-      break;
-    case AF_INET6:
-      port = ntohs (((const struct sockaddr_in6 *) serverAddr)->sin6_port);
-      break;
-    default:
-      port = 0;
-      break;
-    }
+  {
+  case AF_INET:
+    port = ntohs (((const struct sockaddr_in *) serverAddr)->sin_port);
+    break;
+  case AF_INET6:
+    port = ntohs (((const struct sockaddr_in6 *) serverAddr)->sin6_port);
+    break;
+  case AF_UNIX:
+    port = 0;
+    break;
+  default:
+    GNUNET_break (0);
+    port = 0;
+    break;
+  }
   sock = GNUNET_NETWORK_socket_create (serverAddr->sa_family, SOCK_STREAM, 0);
   if (NULL == sock)
-    {
-      GNUNET_log_strerror (GNUNET_ERROR_TYPE_ERROR, "socket");
-      errno = 0;
-      return NULL;
-    }
-  if ((port != 0) &&
-      (GNUNET_NETWORK_socket_setsockopt
-       (sock, SOL_SOCKET, SO_REUSEADDR, &on, sizeof (on)) != GNUNET_OK))
-    GNUNET_log_strerror (GNUNET_ERROR_TYPE_ERROR | GNUNET_ERROR_TYPE_BULK,
-                         "setsockopt");
+  {
+    LOG_STRERROR (GNUNET_ERROR_TYPE_ERROR, "socket");
+    errno = 0;
+    return NULL;
+  }
+  if (port != 0)
+  {
+    if (GNUNET_NETWORK_socket_setsockopt
+        (sock, SOL_SOCKET, SO_REUSEADDR, &on, sizeof (on)) != GNUNET_OK)
+      LOG_STRERROR (GNUNET_ERROR_TYPE_ERROR | GNUNET_ERROR_TYPE_BULK,
+                    "setsockopt");
+#ifdef IPV6_V6ONLY
+    if ((serverAddr->sa_family == AF_INET6) &&
+        (GNUNET_NETWORK_socket_setsockopt
+         (sock, IPPROTO_IPV6, IPV6_V6ONLY, &on, sizeof (on)) != GNUNET_OK))
+      LOG_STRERROR (GNUNET_ERROR_TYPE_ERROR | GNUNET_ERROR_TYPE_BULK,
+                    "setsockopt");
+#endif
+  }
   /* bind the socket */
   if (GNUNET_NETWORK_socket_bind (sock, serverAddr, socklen) != GNUNET_OK)
+  {
+    eno = errno;
+    if (errno != EADDRINUSE)
     {
-      eno = errno;
-      if (errno != EADDRINUSE)
-        {
-          /* we don't log 'EADDRINUSE' here since an IPv4 bind may
-             fail if we already took the port on IPv6; if both IPv4 and
-             IPv6 binds fail, then our caller will log using the
-             errno preserved in 'eno' */
-          GNUNET_log_strerror (GNUNET_ERROR_TYPE_ERROR, "bind");
-          if (port != 0)
-            GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
-                        _
-                        ("`%s' failed for port %d (%s).\n"),
-                        "bind", port,
-                        (serverAddr->sa_family == AF_INET) ? "IPv4" : "IPv6");
-          eno = 0;
-        }
-      GNUNET_break (GNUNET_OK == GNUNET_NETWORK_socket_close (sock));
-      errno = eno;
-      return NULL;
+      /* we don't log 'EADDRINUSE' here since an IPv4 bind may
+       * fail if we already took the port on IPv6; if both IPv4 and
+       * IPv6 binds fail, then our caller will log using the
+       * errno preserved in 'eno' */
+      LOG_STRERROR (GNUNET_ERROR_TYPE_ERROR, "bind");
+      if (port != 0)
+        LOG (GNUNET_ERROR_TYPE_ERROR, _("`%s' failed for port %d (%s).\n"),
+             "bind", port,
+             (serverAddr->sa_family == AF_INET) ? "IPv4" : "IPv6");
+      eno = 0;
     }
-  if (GNUNET_OK != GNUNET_NETWORK_socket_listen (sock, 5))
+    else
     {
-      GNUNET_log_strerror (GNUNET_ERROR_TYPE_ERROR, "listen");
-      GNUNET_break (GNUNET_OK == GNUNET_NETWORK_socket_close (sock));
-      errno = 0;
-      return NULL;
+      if (port != 0)
+        LOG (GNUNET_ERROR_TYPE_WARNING,
+             _("`%s' failed for port %d (%s): address already in use\n"),
+             "bind", port,
+             (serverAddr->sa_family == AF_INET) ? "IPv4" : "IPv6");
+      else if (serverAddr->sa_family == AF_UNIX)
+        LOG (GNUNET_ERROR_TYPE_WARNING,
+             _("`%s' failed for `%s': address already in use\n"), "bind",
+             ((const struct sockaddr_un *) serverAddr)->sun_path);
+
     }
-#if DEBUG_SERVER
+    GNUNET_break (GNUNET_OK == GNUNET_NETWORK_socket_close (sock));
+    errno = eno;
+    return NULL;
+  }
+  if (GNUNET_OK != GNUNET_NETWORK_socket_listen (sock, 5))
+  {
+    LOG_STRERROR (GNUNET_ERROR_TYPE_ERROR, "listen");
+    GNUNET_break (GNUNET_OK == GNUNET_NETWORK_socket_close (sock));
+    errno = 0;
+    return NULL;
+  }
   if (port != 0)
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                "Server starts to listen on port %u.\n", port);
-#endif
+    LOG (GNUNET_ERROR_TYPE_DEBUG, "Server starts to listen on port %u.\n",
+         port);
   return sock;
 }
 
@@ -426,12 +430,56 @@ open_listen_socket (const struct sockaddr *serverAddr, socklen_t socklen)
 /**
  * Create a new server.
  *
- * @param sched scheduler to use
+ * @param access function for access control
+ * @param access_cls closure for access
+ * @param lsocks NULL-terminated array of listen sockets
+ * @param idle_timeout after how long should we timeout idle connections?
+ * @param require_found if YES, connections sending messages of unknown type
+ *        will be closed
+ * @return handle for the new server, NULL on error
+ *         (typically, "port" already in use)
+ */
+struct GNUNET_SERVER_Handle *
+GNUNET_SERVER_create_with_sockets (GNUNET_CONNECTION_AccessCheck access,
+                                   void *access_cls,
+                                   struct GNUNET_NETWORK_Handle **lsocks,
+                                   struct GNUNET_TIME_Relative idle_timeout,
+                                   int require_found)
+{
+  struct GNUNET_SERVER_Handle *ret;
+  struct GNUNET_NETWORK_FDSet *r;
+  int i;
+
+  ret = GNUNET_malloc (sizeof (struct GNUNET_SERVER_Handle));
+  ret->idle_timeout = idle_timeout;
+  ret->listen_sockets = lsocks;
+  ret->access = access;
+  ret->access_cls = access_cls;
+  ret->require_found = require_found;
+  if (lsocks != NULL)
+  {
+    r = GNUNET_NETWORK_fdset_create ();
+    i = 0;
+    while (NULL != ret->listen_sockets[i])
+      GNUNET_NETWORK_fdset_set (r, ret->listen_sockets[i++]);
+    ret->listen_task =
+        GNUNET_SCHEDULER_add_select (GNUNET_SCHEDULER_PRIORITY_HIGH,
+                                     GNUNET_SCHEDULER_NO_TASK,
+                                     GNUNET_TIME_UNIT_FOREVER_REL, r, NULL,
+                                     &process_listen_socket, ret);
+    GNUNET_NETWORK_fdset_destroy (r);
+  }
+  return ret;
+}
+
+
+/**
+ * Create a new server.
+ *
  * @param access function for access control
  * @param access_cls closure for access
  * @param serverAddr address to listen on (including port), NULL terminated array
  * @param socklen length of serverAddr
- * @param maxbuf maximum write buffer size for accepted sockets
  * @param idle_timeout after how long should we timeout idle connections?
  * @param require_found if YES, connections sending messages of unknown type
  *        will be closed
@@ -439,18 +487,13 @@ open_listen_socket (const struct sockaddr *serverAddr, socklen_t socklen)
  *         (typically, "port" already in use)
  */
 struct GNUNET_SERVER_Handle *
-GNUNET_SERVER_create (struct GNUNET_SCHEDULER_Handle *sched,
-                      GNUNET_CONNECTION_AccessCheck access,
-                      void *access_cls,
+GNUNET_SERVER_create (GNUNET_CONNECTION_AccessCheck access, void *access_cls,
                       struct sockaddr *const *serverAddr,
                       const socklen_t * socklen,
-                      size_t maxbuf,
-                      struct GNUNET_TIME_Relative
-                      idle_timeout, int require_found)
+                      struct GNUNET_TIME_Relative idle_timeout,
+                      int require_found)
 {
-  struct GNUNET_SERVER_Handle *ret;
   struct GNUNET_NETWORK_Handle **lsocks;
-  struct GNUNET_NETWORK_FDSet *r;
   unsigned int i;
   unsigned int j;
 
@@ -458,54 +501,31 @@ GNUNET_SERVER_create (struct GNUNET_SCHEDULER_Handle *sched,
   while (serverAddr[i] != NULL)
     i++;
   if (i > 0)
+  {
+    lsocks = GNUNET_malloc (sizeof (struct GNUNET_NETWORK_Handle *) * (i + 1));
+    i = 0;
+    j = 0;
+    while (serverAddr[i] != NULL)
     {
-      lsocks =
-        GNUNET_malloc (sizeof (struct GNUNET_NETWORK_Handle *) * (i + 1));
-      i = 0;
-      j = 0;
-      while (serverAddr[i] != NULL)
-        {
-          lsocks[j] = open_listen_socket (serverAddr[i], socklen[i]);
-          if (lsocks[j] != NULL)
-            j++;
-          i++;
-        }
-      if (j == 0)
-        {
-          if (errno != 0)
-            GNUNET_log_strerror (GNUNET_ERROR_TYPE_ERROR, "bind");
-          GNUNET_free (lsocks);
-          lsocks = NULL;
-        }
+      lsocks[j] = open_listen_socket (serverAddr[i], socklen[i]);
+      if (lsocks[j] != NULL)
+        j++;
+      i++;
     }
-  else
+    if (j == 0)
     {
+      if (errno != 0)
+        LOG_STRERROR (GNUNET_ERROR_TYPE_ERROR, "bind");
+      GNUNET_free (lsocks);
       lsocks = NULL;
     }
-  ret = GNUNET_malloc (sizeof (struct GNUNET_SERVER_Handle));
-  ret->sched = sched;
-  ret->maxbuf = maxbuf;
-  ret->idle_timeout = idle_timeout;
-  ret->listen_sockets = lsocks;
-  ret->access = access;
-  ret->access_cls = access_cls;
-  ret->require_found = require_found;
-  if (lsocks != NULL)
-    {
-      r = GNUNET_NETWORK_fdset_create ();
-      i = 0;
-      while (NULL != ret->listen_sockets[i])
-        GNUNET_NETWORK_fdset_set (r, ret->listen_sockets[i++]);
-      ret->listen_task = GNUNET_SCHEDULER_add_select (sched,
-                                                      GNUNET_SCHEDULER_PRIORITY_HIGH,
-                                                      GNUNET_SCHEDULER_NO_TASK,
-                                                      GNUNET_TIME_UNIT_FOREVER_REL,
-                                                      r, NULL,
-                                                      &process_listen_socket,
-                                                      ret);
-      GNUNET_NETWORK_fdset_destroy (r);
-    }
-  return ret;
+  }
+  else
+  {
+    lsocks = NULL;
+  }
+  return GNUNET_SERVER_create_with_sockets (access, access_cls, lsocks,
+                                            idle_timeout, require_found);
 }
 
 
@@ -521,36 +541,34 @@ GNUNET_SERVER_destroy (struct GNUNET_SERVER_Handle *s)
   struct NotifyList *npos;
   unsigned int i;
 
-#if DEBUG_SERVER
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Server shutting down.\n");
-#endif
+  LOG (GNUNET_ERROR_TYPE_DEBUG, "Server shutting down.\n");
   if (GNUNET_SCHEDULER_NO_TASK != s->listen_task)
-    {
-      GNUNET_SCHEDULER_cancel (s->sched, s->listen_task);
-      s->listen_task = GNUNET_SCHEDULER_NO_TASK;
-    }
+  {
+    GNUNET_SCHEDULER_cancel (s->listen_task);
+    s->listen_task = GNUNET_SCHEDULER_NO_TASK;
+  }
   if (s->listen_sockets != NULL)
-    {
-      i = 0;
-      while (s->listen_sockets[i] != NULL)
-        GNUNET_break (GNUNET_OK ==
-                      GNUNET_NETWORK_socket_close (s->listen_sockets[i++]));
-      GNUNET_free (s->listen_sockets);
-      s->listen_sockets = NULL;
-    }
+  {
+    i = 0;
+    while (s->listen_sockets[i] != NULL)
+      GNUNET_break (GNUNET_OK ==
+                    GNUNET_NETWORK_socket_close (s->listen_sockets[i++]));
+    GNUNET_free (s->listen_sockets);
+    s->listen_sockets = NULL;
+  }
   while (s->clients != NULL)
     GNUNET_SERVER_client_disconnect (s->clients);
   while (NULL != (hpos = s->handlers))
-    {
-      s->handlers = hpos->next;
-      GNUNET_free (hpos);
-    }
+  {
+    s->handlers = hpos->next;
+    GNUNET_free (hpos);
+  }
   while (NULL != (npos = s->disconnect_notify_list))
-    {
-      npos->callback (npos->callback_cls, NULL);
-      s->disconnect_notify_list = npos->next;
-      GNUNET_free (npos);
-    }
+  {
+    npos->callback (npos->callback_cls, NULL);
+    s->disconnect_notify_list = npos->next;
+    GNUNET_free (npos);
+  }
   GNUNET_free (s);
 }
 
@@ -570,8 +588,7 @@ GNUNET_SERVER_destroy (struct GNUNET_SERVER_Handle *s)
  */
 void
 GNUNET_SERVER_add_handlers (struct GNUNET_SERVER_Handle *server,
-                            const struct GNUNET_SERVER_MessageHandler
-                            *handlers)
+                            const struct GNUNET_SERVER_MessageHandler *handlers)
 {
   struct HandlerList *p;
 
@@ -582,6 +599,62 @@ GNUNET_SERVER_add_handlers (struct GNUNET_SERVER_Handle *server,
 }
 
 
+void
+GNUNET_SERVER_set_callbacks (struct GNUNET_SERVER_Handle *server,
+                             GNUNET_SERVER_MstCreateCallback create,
+                             GNUNET_SERVER_MstDestroyCallback destroy,
+                             GNUNET_SERVER_MstReceiveCallback receive,
+                             void *cls)
+{
+  server->mst_create = create;
+  server->mst_destroy = destroy;
+  server->mst_receive = receive;
+  server->mst_cls = cls;
+}
+
+
+/**
+ * Task run to warn about missing calls to 'GNUNET_SERVER_receive_done'.
+ *
+ * @param cls our 'struct GNUNET_SERVER_Client*' to process more requests from
+ * @param tc scheduler context (unused)
+ */
+static void
+warn_no_receive_done (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
+{
+  struct GNUNET_SERVER_Client *client = cls;
+
+  client->warn_task =
+      GNUNET_SCHEDULER_add_delayed (GNUNET_TIME_UNIT_MINUTES,
+                                    &warn_no_receive_done, client);
+  if (0 == (GNUNET_SCHEDULER_REASON_SHUTDOWN & tc->reason))
+    LOG (GNUNET_ERROR_TYPE_WARNING,
+         _
+         ("Processing code for message of type %u did not call GNUNET_SERVER_receive_done after %llums\n"),
+         (unsigned int) client->warn_type,
+         (unsigned long long)
+         GNUNET_TIME_absolute_get_duration (client->warn_start).rel_value);
+}
+
+
+/**
+ * Disable the warning the server issues if a message is not acknowledged
+ * in a timely fashion.  Use this call if a client is intentionally delayed
+ * for a while.  Only applies to the current message.
+ *
+ * @param client client for which to disable the warning
+ */
+void
+GNUNET_SERVER_disable_receive_done_warning (struct GNUNET_SERVER_Client *client)
+{
+  if (GNUNET_SCHEDULER_NO_TASK != client->warn_task)
+  {
+    GNUNET_SCHEDULER_cancel (client->warn_task);
+    client->warn_task = GNUNET_SCHEDULER_NO_TASK;
+  }
+}
+
+
 /**
  * Inject a message into the server, pretend it came
  * from the specified client.  Delivery of the message
@@ -611,106 +684,128 @@ GNUNET_SERVER_inject (struct GNUNET_SERVER_Handle *server,
 
   type = ntohs (message->type);
   size = ntohs (message->size);
-#if DEBUG_SERVER
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Server schedules transmission of %u-byte message of type %u to client.\n",
-              size, type);
-#endif
+  LOG (GNUNET_ERROR_TYPE_DEBUG,
+       "Server schedules transmission of %u-byte message of type %u to client.\n",
+       size, type);
   pos = server->handlers;
   found = GNUNET_NO;
   while (pos != NULL)
+  {
+    i = 0;
+    while (pos->handlers[i].callback != NULL)
     {
-      i = 0;
-      while (pos->handlers[i].callback != NULL)
+      mh = &pos->handlers[i];
+      if ((mh->type == type) || (mh->type == GNUNET_MESSAGE_TYPE_ALL))
+      {
+        if ((mh->expected_size != 0) && (mh->expected_size != size))
+        {
+#if GNUNET8_NETWORK_IS_DEAD
+          LOG (GNUNET_ERROR_TYPE_WARNING,
+               "Expected %u bytes for message of type %u, got %u\n",
+               mh->expected_size, mh->type, size);
+          GNUNET_break_op (0);
+#endif
+          return GNUNET_SYSERR;
+        }
+        if (sender != NULL)
         {
-          mh = &pos->handlers[i];
-          if ( (mh->type == type) ||
-               (mh->type == GNUNET_MESSAGE_TYPE_ALL) )
-            {
-              if ((mh->expected_size != 0) && (mh->expected_size != size))
-                {
-                  GNUNET_break_op (0);
-                  return GNUNET_SYSERR;
-                }
-              if (sender != NULL)
-                sender->suspended++;
-              mh->callback (mh->callback_cls, sender, message);
-              found = GNUNET_YES;
-            }
-          i++;
+          if (0 == sender->suspended)
+          {
+            sender->warn_start = GNUNET_TIME_absolute_get ();
+            sender->warn_task =
+                GNUNET_SCHEDULER_add_delayed (GNUNET_TIME_UNIT_MINUTES,
+                                              &warn_no_receive_done, sender);
+            sender->warn_type = type;
+          }
+          sender->suspended++;
         }
-      pos = pos->next;
+        mh->callback (mh->callback_cls, sender, message);
+        found = GNUNET_YES;
+      }
+      i++;
     }
+    pos = pos->next;
+  }
   if (found == GNUNET_NO)
-    {
-      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG | GNUNET_ERROR_TYPE_BULK,
-                  _("Received message of unknown type %d\n"), type);
-      if (server->require_found == GNUNET_YES)
-        return GNUNET_SYSERR;
-    }
+  {
+    LOG (GNUNET_ERROR_TYPE_DEBUG | GNUNET_ERROR_TYPE_BULK,
+         "Received message of unknown type %d\n", type);
+    if (server->require_found == GNUNET_YES)
+      return GNUNET_SYSERR;
+  }
   return GNUNET_OK;
 }
 
 
 /**
- * Go over the contents of the client buffer; as long as full messages
- * are available, pass them on for processing.  Update the buffer
- * accordingly.  Handles fatal errors by shutting down the connection.
+ * We are receiving an incoming message.  Process it.
  *
- * @param client identifies which client receive buffer to process
+ * @param cls our closure (handle for the client)
+ * @param buf buffer with data received from network
+ * @param available number of bytes available in buf
+ * @param addr address of the sender
+ * @param addrlen length of addr
+ * @param errCode code indicating errors receiving, 0 for success
  */
 static void
-process_client_buffer (struct GNUNET_SERVER_Client *client)
+process_incoming (void *cls, const void *buf, size_t available,
+                  const struct sockaddr *addr, socklen_t addrlen, int errCode);
+
+
+/**
+ * Process messages from the client's message tokenizer until either
+ * the tokenizer is empty (and then schedule receiving more), or
+ * until some handler is not immediately done (then wait for restart_processing)
+ * or shutdown.
+ *
+ * @param client the client to process, RC must have already been increased
+ *        using GNUNET_SERVER_client_keep and will be decreased by one in this
+ *        function
+ * @param ret GNUNET_NO to start processing from the buffer,
+ *            GNUNET_OK if the mst buffer is drained and we should instantly go back to receiving
+ *            GNUNET_SYSERR if we should instantly abort due to error in a previous step
+ */
+static void
+process_mst (struct GNUNET_SERVER_Client *client, int ret)
 {
-  struct GNUNET_SERVER_Handle *server;
-  const struct GNUNET_MessageHeader *hdr;
-  size_t msize;
-
-  client->in_process_client_buffer = GNUNET_YES;
-  server = client->server;
-#if DEBUG_SERVER
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Private buffer contains %u bytes; client is %s and we are %s\n",
-              client->receive_pos,
-              client->suspended ? "suspended" : "up",
-              client->shutdown_now ? "in shutdown" : "running");
-#endif
-  while ( (client->receive_pos >= sizeof (struct GNUNET_MessageHeader)) &&
-         (0 == client->suspended) && 
-         (GNUNET_YES != client->shutdown_now) )
+  while ((ret != GNUNET_SYSERR) && (client->server != NULL) &&
+         (GNUNET_YES != client->shutdown_now) && (0 == client->suspended))
+  {
+    if (ret == GNUNET_OK)
     {
-      hdr = (const struct GNUNET_MessageHeader *) &client->incoming_buffer;
-      msize = ntohs (hdr->size);
-      if (msize > client->receive_pos)
-        {
-#if DEBUG_SERVER
-          GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                      "Total message size is %u, we only have %u bytes; need more data\n",
-                      msize, client->receive_pos);
-#endif
-          break;
-        }
-#if DEBUG_SERVER
-      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                  "Passing %u bytes to callback for processing\n", msize);
-#endif
-      if ( (msize < sizeof (struct GNUNET_MessageHeader)) ||
-          (GNUNET_OK != GNUNET_SERVER_inject (server, client, hdr)) )
-        {
-          client->in_process_client_buffer = GNUNET_NO;
-          GNUNET_SERVER_client_disconnect (client);
-          return;
-        }
-      /* FIXME: this is highly inefficient; we should
-         try to avoid this if the new base address is
-         already nicely aligned.  See old handler code... */
-      memmove (client->incoming_buffer,
-               &client->incoming_buffer[msize], client->receive_pos - msize);
-      client->receive_pos -= msize;
+      client->receive_pending = GNUNET_YES;
+      LOG (GNUNET_ERROR_TYPE_DEBUG,
+           "Server re-enters receive loop, timeout: %llu.\n",
+           client->idle_timeout.rel_value);
+      GNUNET_CONNECTION_receive (client->connection,
+                                 GNUNET_SERVER_MAX_MESSAGE_SIZE - 1,
+                                 client->idle_timeout, &process_incoming,
+                                 client);
+      break;
     }
-  client->in_process_client_buffer = GNUNET_NO;
-  if (GNUNET_YES == client->shutdown_now)
+    LOG (GNUNET_ERROR_TYPE_DEBUG,
+         "Server processes additional messages instantly.\n");
+    if (client->server->mst_receive != NULL)
+      ret =
+          client->server->mst_receive (client->server->mst_cls, client->mst,
+                                       client, NULL, 0, GNUNET_NO, GNUNET_YES);
+    else
+      ret =
+          GNUNET_SERVER_mst_receive (client->mst, client, NULL, 0, GNUNET_NO,
+                                     GNUNET_YES);
+  }
+  LOG (GNUNET_ERROR_TYPE_DEBUG,
+       "Server leaves instant processing loop: ret = %d, server = %p, shutdown = %d, suspended = %u\n",
+       ret, client->server, client->shutdown_now, client->suspended);
+  if (ret == GNUNET_NO)
+  {
+    LOG (GNUNET_ERROR_TYPE_DEBUG,
+         "Server has more data pending but is suspended.\n");
+    client->receive_pending = GNUNET_SYSERR;    /* data pending */
+  }
+  if ((ret == GNUNET_SYSERR) || (GNUNET_YES == client->shutdown_now))
     GNUNET_SERVER_client_disconnect (client);
+  GNUNET_SERVER_client_drop (client);
 }
 
 
@@ -725,86 +820,59 @@ process_client_buffer (struct GNUNET_SERVER_Client *client)
  * @param errCode code indicating errors receiving, 0 for success
  */
 static void
-process_incoming (void *cls,
-                  const void *buf,
-                  size_t available,
+process_incoming (void *cls, const void *buf, size_t available,
                   const struct sockaddr *addr, socklen_t addrlen, int errCode)
 {
   struct GNUNET_SERVER_Client *client = cls;
   struct GNUNET_SERVER_Handle *server = client->server;
-  const char *cbuf = buf;
-  size_t maxcpy;
+  struct GNUNET_TIME_Absolute end;
+  struct GNUNET_TIME_Absolute now;
+  int ret;
 
+  GNUNET_assert (client->receive_pending == GNUNET_YES);
   client->receive_pending = GNUNET_NO;
-  if ((buf == NULL) ||
-      (available == 0) ||
-      (errCode != 0) ||
-      (server == NULL) ||
+  now = GNUNET_TIME_absolute_get ();
+  end = GNUNET_TIME_absolute_add (client->last_activity, client->idle_timeout);
+
+  if ((buf == NULL) && (available == 0) && (addr == NULL) && (errCode == 0) &&
+      (client->shutdown_now != GNUNET_YES) && (server != NULL) &&
+      (GNUNET_YES == GNUNET_CONNECTION_check (client->connection)) &&
+      (end.abs_value > now.abs_value))
+  {
+    /* wait longer, timeout changed (i.e. due to us sending) */
+    LOG (GNUNET_ERROR_TYPE_DEBUG,
+         "Receive time out, but no disconnect due to sending (%p)\n",
+         GNUNET_a2s (addr, addrlen));
+    client->receive_pending = GNUNET_YES;
+    GNUNET_CONNECTION_receive (client->connection,
+                               GNUNET_SERVER_MAX_MESSAGE_SIZE - 1,
+                               GNUNET_TIME_absolute_get_remaining (end),
+                               &process_incoming, client);
+    return;
+  }
+  if ((buf == NULL) || (available == 0) || (errCode != 0) || (server == NULL) ||
       (client->shutdown_now == GNUNET_YES) ||
-      (GNUNET_YES != client->check (client->client_closure)))
-    {
-      /* other side closed connection, error connecting, etc. */      
-      GNUNET_SERVER_client_disconnect (client);
-      return;
-    }
-#if DEBUG_SERVER
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Server receives %u bytes from `%s'.\n",
-              available, GNUNET_a2s (addr, addrlen));
-#endif
-  GNUNET_SERVER_client_keep (client);
-  client->last_activity = GNUNET_TIME_absolute_get ();
-  /* process data (if available) */
-  while (available > 0)
-    {
-      maxcpy = available;
-      if (maxcpy > sizeof (client->incoming_buffer) - client->receive_pos)
-        maxcpy = sizeof (client->incoming_buffer) - client->receive_pos;
-#if DEBUG_SERVER
-      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                  "Can copy %u bytes to private buffer\n", maxcpy);
-#endif
-      memcpy (&client->incoming_buffer[client->receive_pos], cbuf, maxcpy);
-      client->receive_pos += maxcpy;
-      cbuf += maxcpy;
-      available -= maxcpy;
-      if (0 < client->suspended)
-        {
-          if (available > 0)
-            {
-#if DEBUG_SERVER
-              GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                          "Client has suspended processing; copying %u bytes to side buffer to be used later.\n",
-                          available);
-#endif
-              GNUNET_assert (client->side_buf_size == 0);
-              GNUNET_assert (client->side_buf == NULL);
-              client->side_buf_size = available;
-              client->side_buf = GNUNET_malloc (available);
-              memcpy (client->side_buf, cbuf, available);
-              available = 0;
-            }
-          break;                /* do not run next client iteration! */
-        }
-#if DEBUG_SERVER
-      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                  "Now processing messages in private buffer\n");
-#endif
-      process_client_buffer (client);
-    }
-  GNUNET_assert (available == 0);
-  if ((client->suspended == 0) &&
-      (GNUNET_YES != client->shutdown_now) && (client->server != NULL))
-    {
-      /* Finally, keep receiving! */
-      client->receive_pending = GNUNET_YES;
-      client->receive (client->client_closure,
-                       GNUNET_SERVER_MAX_MESSAGE_SIZE,
-                       server->idle_timeout, &process_incoming, client);
-    }
-  if (GNUNET_YES == client->shutdown_now)
+      (GNUNET_YES != GNUNET_CONNECTION_check (client->connection)))
+  {
+    /* other side closed connection, error connecting, etc. */
     GNUNET_SERVER_client_disconnect (client);
-  GNUNET_SERVER_client_drop (client);
+    return;
+  }
+  LOG (GNUNET_ERROR_TYPE_DEBUG, "Server receives %u bytes from `%s'.\n",
+       (unsigned int) available, GNUNET_a2s (addr, addrlen));
+  GNUNET_SERVER_client_keep (client);
+  client->last_activity = now;
+
+  if (server->mst_receive != NULL)
+    ret =
+        client->server->mst_receive (client->server->mst_cls, client->mst,
+                                     client, buf, available, GNUNET_NO, GNUNET_YES);
+  else
+    ret =
+        GNUNET_SERVER_mst_receive (client->mst, client, buf, available, GNUNET_NO,
+                                   GNUNET_YES);
+
+  process_mst (client, ret);
 }
 
 
@@ -822,122 +890,53 @@ restart_processing (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
   struct GNUNET_SERVER_Handle *server = client->server;
 
   client->restart_task = GNUNET_SCHEDULER_NO_TASK;
-  if ( (0 != (tc->reason & GNUNET_SCHEDULER_REASON_SHUTDOWN)) &&
-       (GNUNET_NO == server->clients_ignore_shutdown) )
-    {
-      GNUNET_SERVER_client_disconnect (client);
-      return;
-    }
+  if ((0 != (tc->reason & GNUNET_SCHEDULER_REASON_SHUTDOWN)) &&
+      (GNUNET_NO == server->clients_ignore_shutdown))
+  {
+    GNUNET_SERVER_client_disconnect (client);
+    return;
+  }
+  if (client->receive_pending == GNUNET_NO)
+  {
+    LOG (GNUNET_ERROR_TYPE_DEBUG, "Server begins to read again from client.\n");
+    client->receive_pending = GNUNET_YES;
+    GNUNET_CONNECTION_receive (client->connection,
+                               GNUNET_SERVER_MAX_MESSAGE_SIZE - 1,
+                               client->idle_timeout, &process_incoming, client);
+    return;
+  }
+  LOG (GNUNET_ERROR_TYPE_DEBUG,
+       "Server continues processing messages still in the buffer.\n");
   GNUNET_SERVER_client_keep (client);
-  process_client_buffer (client);
-  if (0 == client->suspended)
-    {
-      client->receive_pending = GNUNET_YES;
-      client->receive (client->client_closure,
-                      GNUNET_SERVER_MAX_MESSAGE_SIZE,
-                      client->server->idle_timeout, &process_incoming, client);
-    }
-  GNUNET_SERVER_client_drop (client);
-}
-
-
-/**
- * Add a client to the set of our clients and
- * start receiving.
- */
-static void
-add_client (struct GNUNET_SERVER_Handle *server,
-            struct GNUNET_SERVER_Client *client)
-{
-  client->server = server;
-  client->last_activity = GNUNET_TIME_absolute_get ();
-  client->next = server->clients;
-  server->clients = client;
-  client->receive_pending = GNUNET_YES;
-  client->receive (client->client_closure,
-                   GNUNET_SERVER_MAX_MESSAGE_SIZE,
-                   server->idle_timeout, &process_incoming, client);
-}
-
-
-/**
- * Create a request for receiving data from a socket.
- *
- * @param cls identifies the socket to receive from
- * @param max how much data to read at most
- * @param timeout when should this operation time out
- * @param receiver function to call for processing
- * @param receiver_cls closure for receiver
- */
-static void
-sock_receive (void *cls,
-              size_t max,
-              struct GNUNET_TIME_Relative timeout,
-              GNUNET_CONNECTION_Receiver receiver, void *receiver_cls)
-{
-  GNUNET_CONNECTION_receive (cls, max, timeout, receiver, receiver_cls);
-}
-
-
-/**
- * Wrapper to cancel receiving from a socket.
- * 
- * @param cls handle to the GNUNET_CONNECTION_Handle to cancel
- */
-static void
-sock_receive_cancel (void *cls)
-{
-  GNUNET_CONNECTION_receive_cancel (cls);
-}
-
-
-/**
- * FIXME: document.
- */
-static void *
-sock_notify_transmit_ready (void *cls,
-                            size_t size,
-                            struct GNUNET_TIME_Relative timeout,
-                            GNUNET_CONNECTION_TransmitReadyNotify notify,
-                            void *notify_cls)
-{
-  return GNUNET_CONNECTION_notify_transmit_ready (cls, size, timeout, notify,
-                                                  notify_cls);
-}
-
-
-/**
- * FIXME: document.
- */
-static void
-sock_notify_transmit_ready_cancel (void *cls, void *h)
-{
-  GNUNET_CONNECTION_notify_transmit_ready_cancel (h);
-}
-
-
-/**
- * Check if socket is still valid (no fatal errors have happened so far).
- *
- * @param cls the socket
- * @return GNUNET_YES if valid, GNUNET_NO otherwise
- */
-static int
-sock_check (void *cls)
-{
-  return GNUNET_CONNECTION_check (cls);
+  client->receive_pending = GNUNET_NO;
+  process_mst (client, GNUNET_NO);
 }
 
 
 /**
- * Destroy this socket (free resources).
+ * This function is called whenever our inbound message tokenizer has
+ * received a complete message.
  *
- * @param cls the socket
+ * @param cls closure (struct GNUNET_SERVER_Handle)
+ * @param client identification of the client (struct GNUNET_SERVER_Client*)
+ * @param message the actual message
  */
 static void
-sock_destroy (void *cls)
+client_message_tokenizer_callback (void *cls, void *client,
+                                   const struct GNUNET_MessageHeader *message)
 {
-  GNUNET_CONNECTION_destroy (cls);
+  struct GNUNET_SERVER_Handle *server = cls;
+  struct GNUNET_SERVER_Client *sender = client;
+  int ret;
+
+  LOG (GNUNET_ERROR_TYPE_DEBUG,
+       "Tokenizer gives server message of type %u from client\n",
+       ntohs (message->type));
+  sender->in_process_client_buffer = GNUNET_YES;
+  ret = GNUNET_SERVER_inject (server, sender, message);
+  sender->in_process_client_buffer = GNUNET_NO;
+  if (GNUNET_OK != ret)
+    GNUNET_SERVER_client_disconnect (sender);
 }
 
 
@@ -954,74 +953,58 @@ sock_destroy (void *cls)
  *         "client_drop" on the return value eventually)
  */
 struct GNUNET_SERVER_Client *
-GNUNET_SERVER_connect_socket (struct
-                              GNUNET_SERVER_Handle
-                              *server,
+GNUNET_SERVER_connect_socket (struct GNUNET_SERVER_Handle *server,
                               struct GNUNET_CONNECTION_Handle *connection)
 {
   struct GNUNET_SERVER_Client *client;
 
   client = GNUNET_malloc (sizeof (struct GNUNET_SERVER_Client));
-  client->client_closure = connection;
-  client->receive = &sock_receive;
-  client->receive_cancel = &sock_receive_cancel;
-  client->notify_transmit_ready = &sock_notify_transmit_ready;
-  client->notify_transmit_ready_cancel = &sock_notify_transmit_ready_cancel;
-  client->check = &sock_check;
-  client->destroy = &sock_destroy;
+  client->connection = connection;
   client->reference_count = 1;
-  add_client (server, client);
+  client->server = server;
+  client->last_activity = GNUNET_TIME_absolute_get ();
+  client->next = server->clients;
+  client->idle_timeout = server->idle_timeout;
+  server->clients = client;
+  client->receive_pending = GNUNET_YES;
+  client->callback = NULL;
+  client->callback_cls = NULL;
+
+  if (server->mst_create != NULL)
+    client->mst =
+        server->mst_create (server->mst_cls, client);
+  else
+    client->mst =
+        GNUNET_SERVER_mst_create (&client_message_tokenizer_callback, server);
+
+  GNUNET_CONNECTION_receive (client->connection,
+                             GNUNET_SERVER_MAX_MESSAGE_SIZE - 1,
+                             client->idle_timeout, &process_incoming, client);
   return client;
 }
 
 
 /**
- * Add an arbitrary connection to the set of handles managed by this
- * server.  This can be used if a sending and receiving does not
- * really go over the network (internal transmission) or for servers
- * using UDP.
+ * Change the timeout for a particular client.  Decreasing the timeout
+ * may not go into effect immediately (only after the previous timeout
+ * times out or activity happens on the socket).
  *
- * @param server the server to use
- * @param chandle opaque handle for the connection
- * @param creceive receive function for the connection
- * @param ccancel cancel receive function for the connection
- * @param cnotify transmit notification function for the connection
- * @param cnotify_cancel transmit notification cancellation function for the connection
- * @param ccheck function to test if the connection is still up
- * @param cdestroy function to close and free the connection
- * @return the client handle (client should call
- *         "client_drop" on the return value eventually)
+ * @param client the client to update
+ * @param timeout new timeout for activities on the socket
  */
-struct GNUNET_SERVER_Client *
-GNUNET_SERVER_connect_callback (struct
-                                GNUNET_SERVER_Handle
-                                *server,
-                                void *chandle,
-                                GNUNET_SERVER_ReceiveCallback
-                                creceive,
-                                GNUNET_SERVER_ReceiveCancelCallback
-                                ccancel,
-                                GNUNET_SERVER_TransmitReadyCallback
-                                cnotify,
-                                GNUNET_SERVER_TransmitReadyCancelCallback
-                                cnotify_cancel,
-                                GNUNET_SERVER_CheckCallback
-                                ccheck,
-                                GNUNET_SERVER_DestroyCallback cdestroy)
+void
+GNUNET_SERVER_client_set_timeout (struct GNUNET_SERVER_Client *client,
+                                  struct GNUNET_TIME_Relative timeout)
 {
-  struct GNUNET_SERVER_Client *client;
+  client->idle_timeout = timeout;
+}
 
-  client = GNUNET_malloc (sizeof (struct GNUNET_SERVER_Client));
-  client->client_closure = chandle;
-  client->receive = creceive;
-  client->receive_cancel = ccancel;
-  client->notify_transmit_ready = cnotify;
-  client->notify_transmit_ready_cancel = cnotify_cancel;
-  client->check = ccheck;
-  client->destroy = cdestroy;
-  client->reference_count = 1;
-  add_client (server, client);
-  return client;
+
+void
+GNUNET_SERVER_client_set_finish_pending_write (struct GNUNET_SERVER_Client *client,
+                                               int finish)
+{
+  client->finish_pending_write = finish;
 }
 
 
@@ -1052,8 +1035,7 @@ GNUNET_SERVER_client_drop (struct GNUNET_SERVER_Client *client)
 {
   GNUNET_assert (client->reference_count > 0);
   client->reference_count--;
-  if ( (client->shutdown_now == GNUNET_YES) && 
-       (client->reference_count == 0) )
+  if ((client->shutdown_now == GNUNET_YES) && (client->reference_count == 0))
     GNUNET_SERVER_client_disconnect (client);
 }
 
@@ -1070,10 +1052,7 @@ int
 GNUNET_SERVER_client_get_address (struct GNUNET_SERVER_Client *client,
                                   void **addr, size_t * addrlen)
 {
-  if (client->receive != &sock_receive)
-    return GNUNET_SYSERR;       /* not a network client */
-  return GNUNET_CONNECTION_get_address (client->client_closure,
-                                        addr, addrlen);
+  return GNUNET_CONNECTION_get_address (client->connection, addr, addrlen);
 }
 
 
@@ -1111,8 +1090,8 @@ GNUNET_SERVER_disconnect_notify (struct GNUNET_SERVER_Handle *server,
  */
 void
 GNUNET_SERVER_disconnect_notify_cancel (struct GNUNET_SERVER_Handle *server,
-                                       GNUNET_SERVER_DisconnectCallback callback,
-                                       void *callback_cls)
+                                        GNUNET_SERVER_DisconnectCallback
+                                        callback, void *callback_cls)
 {
   struct NotifyList *pos;
   struct NotifyList *prev;
@@ -1120,18 +1099,17 @@ GNUNET_SERVER_disconnect_notify_cancel (struct GNUNET_SERVER_Handle *server,
   prev = NULL;
   pos = server->disconnect_notify_list;
   while (pos != NULL)
-    {
-      if ( (pos->callback == callback) &&
-          (pos->callback_cls == callback_cls ) )
-       break;
-      prev = pos;
-      pos = pos->next;
-    }
+  {
+    if ((pos->callback == callback) && (pos->callback_cls == callback_cls))
+      break;
+    prev = pos;
+    pos = pos->next;
+  }
   if (pos == NULL)
-    {
-      GNUNET_break (0);
-      return;
-    }
+  {
+    GNUNET_break (0);
+    return;
+  }
   if (prev == NULL)
     server->disconnect_notify_list = pos->next;
   else
@@ -1157,53 +1135,118 @@ GNUNET_SERVER_client_disconnect (struct GNUNET_SERVER_Client *client)
   struct NotifyList *n;
   unsigned int rc;
 
+  LOG (GNUNET_ERROR_TYPE_DEBUG,
+       "Client is being disconnected from the server.\n");
   if (client->restart_task != GNUNET_SCHEDULER_NO_TASK)
+  {
+    GNUNET_SCHEDULER_cancel (client->restart_task);
+    client->restart_task = GNUNET_SCHEDULER_NO_TASK;
+  }
+  if (client->warn_task != GNUNET_SCHEDULER_NO_TASK)
+  {
+    GNUNET_SCHEDULER_cancel (client->warn_task);
+    client->warn_task = GNUNET_SCHEDULER_NO_TASK;
+  }
+  if (GNUNET_YES == client->receive_pending)
+  {
+    GNUNET_CONNECTION_receive_cancel (client->connection);
+    client->receive_pending = GNUNET_NO;
+  }
+
+  rc = client->reference_count;
+  if (client->shutdown_now != GNUNET_YES)
+  {
+    server = client->server;
+    client->shutdown_now = GNUNET_YES;
+    prev = NULL;
+    pos = server->clients;
+    while ((pos != NULL) && (pos != client))
+    {
+      prev = pos;
+      pos = pos->next;
+    }
+    GNUNET_assert (pos != NULL);
+    if (prev == NULL)
+      server->clients = pos->next;
+    else
+      prev->next = pos->next;
+    if (client->restart_task != GNUNET_SCHEDULER_NO_TASK)
     {
-      GNUNET_SCHEDULER_cancel (client->server->sched,
-                              client->restart_task);
+      GNUNET_SCHEDULER_cancel (client->restart_task);
       client->restart_task = GNUNET_SCHEDULER_NO_TASK;
     }
-  if (GNUNET_YES == client->receive_pending)
+    if (client->warn_task != GNUNET_SCHEDULER_NO_TASK)
     {
-      client->receive_cancel (client->client_closure);
-      client->receive_pending = GNUNET_NO;
+      GNUNET_SCHEDULER_cancel (client->warn_task);
+      client->warn_task = GNUNET_SCHEDULER_NO_TASK;
     }
-  rc = client->reference_count;  
-  if (client->server != NULL)
+    n = server->disconnect_notify_list;
+    while (n != NULL)
     {
-      server = client->server;
-      client->server = NULL;
-      client->shutdown_now = GNUNET_YES;
-      prev = NULL;
-      pos = server->clients;
-      while ((pos != NULL) && (pos != client))
-        {
-          prev = pos;
-          pos = pos->next;
-        }
-      GNUNET_assert (pos != NULL);
-      if (prev == NULL)
-        server->clients = pos->next;
-      else
-        prev->next = pos->next;
-      n = server->disconnect_notify_list;
-      while (n != NULL)
-        {
-          n->callback (n->callback_cls, client);
-          n = n->next;
-        }
-      if (client->restart_task != GNUNET_SCHEDULER_NO_TASK)
-       GNUNET_SCHEDULER_cancel (client->server->sched,
-                                client->restart_task);
+      n->callback (n->callback_cls, client);
+      n = n->next;
     }
+  }
   if (rc > 0)
+  {
+    LOG (GNUNET_ERROR_TYPE_DEBUG,
+         "RC still positive, not destroying everything.\n");
     return;
-  if (client->in_process_client_buffer)
+  }
+  if (client->in_process_client_buffer == GNUNET_YES)
+  {
+    LOG (GNUNET_ERROR_TYPE_DEBUG,
+         "Still processing inputs, not destroying everything.\n");
     return;
-  client->destroy (client->client_closure);
+  }
+
+  if (client->persist == GNUNET_YES)
+    GNUNET_CONNECTION_persist_ (client->connection);
+  GNUNET_CONNECTION_destroy (client->connection, client->finish_pending_write);
+
+  if (client->server->mst_destroy != NULL)
+    client->server->mst_destroy (client->server->mst_cls, client->mst);
+  else
+    GNUNET_SERVER_mst_destroy (client->mst);
+
   GNUNET_free (client);
+}
+
+
+/**
+ * Disable the "CORK" feature for communication with the given client,
+ * forcing the OS to immediately flush the buffer on transmission
+ * instead of potentially buffering multiple messages.
+ *
+ * @param client handle to the client
+ * @return GNUNET_OK on success
+ */
+int
+GNUNET_SERVER_client_disable_corking (struct GNUNET_SERVER_Client *client)
+{
+  return GNUNET_CONNECTION_disable_corking (client->connection);
+}
+
+
+/**
+ * Wrapper for transmission notification that calls the original
+ * callback and update the last activity time for our connection.
+ *
+ * @param cls the 'struct GNUNET_SERVER_Client'
+ * @param size number of bytes we can transmit
+ * @param buf where to copy the message
+ * @return number of bytes actually transmitted
+ */
+static size_t
+transmit_ready_callback_wrapper (void *cls, size_t size, void *buf)
+{
+  struct GNUNET_SERVER_Client *client = cls;
+  size_t ret;
 
-  
+  ret = client->callback (client->callback_cls, size, buf);
+  if (ret > 0)
+    client->last_activity = GNUNET_TIME_absolute_get ();
+  return ret;
 }
 
 
@@ -1229,9 +1272,25 @@ GNUNET_SERVER_notify_transmit_ready (struct GNUNET_SERVER_Client *client,
                                      GNUNET_CONNECTION_TransmitReadyNotify
                                      callback, void *callback_cls)
 {
-  return client->notify_transmit_ready (client->client_closure,
-                                        size,
-                                        timeout, callback, callback_cls);
+  client->callback_cls = callback_cls;
+  client->callback = callback;
+  return GNUNET_CONNECTION_notify_transmit_ready (client->connection, size,
+                                                  timeout,
+                                                  &transmit_ready_callback_wrapper,
+                                                  client);
+}
+
+
+/**
+ * Set the persistent flag on this client, used to setup client connection
+ * to only be killed when the service it's connected to is actually dead.
+ *
+ * @param client the client to set the persistent flag on
+ */
+void
+GNUNET_SERVER_client_persist_ (struct GNUNET_SERVER_Client *client)
+{
+  client->persist = GNUNET_YES;
 }
 
 
@@ -1250,35 +1309,43 @@ GNUNET_SERVER_notify_transmit_ready (struct GNUNET_SERVER_Client *client,
 void
 GNUNET_SERVER_receive_done (struct GNUNET_SERVER_Client *client, int success)
 {
-  char *sb;
-
   if (client == NULL)
     return;
   GNUNET_assert (client->suspended > 0);
   client->suspended--;
   if (success != GNUNET_OK)
-    {
-      GNUNET_SERVER_client_disconnect (client);
-      return;
-    }
+  {
+    LOG (GNUNET_ERROR_TYPE_DEBUG,
+         "GNUNET_SERVER_receive_done called with failure indication\n");
+    GNUNET_SERVER_client_disconnect (client);
+    return;
+  }
   if (client->suspended > 0)
+  {
+    LOG (GNUNET_ERROR_TYPE_DEBUG,
+         "GNUNET_SERVER_receive_done called, but more clients pending\n");
     return;
+  }
+  if (GNUNET_SCHEDULER_NO_TASK != client->warn_task)
+  {
+    GNUNET_SCHEDULER_cancel (client->warn_task);
+    client->warn_task = GNUNET_SCHEDULER_NO_TASK;
+  }
   if (client->in_process_client_buffer == GNUNET_YES)
+  {
+    LOG (GNUNET_ERROR_TYPE_DEBUG,
+         "GNUNET_SERVER_receive_done called while still in processing loop\n");
     return;
-  if (client->side_buf_size > 0)
-    {
-      /* resume processing from side-buf */
-      sb = client->side_buf;
-      client->side_buf = NULL;
-      /* this will also resume the receive job */
-      process_incoming (client, sb, client->side_buf_size, NULL, 0, 0);
-      /* finally, free the side-buf */
-      GNUNET_free (sb);
-      return;
-    }
-  client->restart_task = GNUNET_SCHEDULER_add_now (client->server->sched,
-                                                  &restart_processing,
-                                                  client);
+  }
+  if ((client->server == NULL) || (GNUNET_YES == client->shutdown_now))
+  {
+    GNUNET_SERVER_client_disconnect (client);
+    return;
+  }
+  LOG (GNUNET_ERROR_TYPE_DEBUG,
+       "GNUNET_SERVER_receive_done causes restart in reading from the socket\n");
+  GNUNET_assert (GNUNET_SCHEDULER_NO_TASK == client->restart_task);
+  client->restart_task = GNUNET_SCHEDULER_add_now (&restart_processing, client);
 }