/*
This file is part of GNUnet.
- (C) 2009-2013 Christian Grothoff (and other contributing authors)
+ (C) 2009-2014 Christian Grothoff (and other contributing authors)
GNUnet is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published
struct GNUNET_TIME_Absolute timeout;
/**
- * Task handle for numeric lookups.
+ * Task handle for making reply callbacks in numeric lookups
+ * asynchronous, and for timeout handling.
*/
GNUNET_SCHEDULER_TaskIdentifier task;
/**
* Has this request been transmitted to the service?
- * GNUNET_YES if transmitted
- * GNUNET_YES if not transmitted
- * GNUNET_SYSERR when request was canceled
+ * #GNUNET_YES if transmitted
+ * #GNUNET_YES if not transmitted
+ * #GNUNET_SYSERR when request was canceled
*/
int was_transmitted;
int direction;
/**
- * GNUNET_YES if a response was received
+ * #GNUNET_YES if a response was received
*/
int received_response;
v6.sin6_len = sizeof (v6);
#endif
if (GNUNET_OK !=
- GNUNET_CONFIGURATION_get_value_string (resolver_cfg, "resolver",
- "HOSTNAME", &hostname))
+ GNUNET_CONFIGURATION_get_value_string (resolver_cfg,
+ "resolver",
+ "HOSTNAME",
+ &hostname))
{
LOG (GNUNET_ERROR_TYPE_ERROR,
- _("Must specify `%s' for `%s' in configuration!\n"), "HOSTNAME",
+ _("Must specify `%s' for `%s' in configuration!\n"),
+ "HOSTNAME",
"resolver");
GNUNET_assert (0);
}
return;
}
i = 0;
- while (loopback[i] != NULL)
+ while (NULL != loopback[i])
if (0 == strcasecmp (loopback[i++], hostname))
{
GNUNET_free (hostname);
return;
}
LOG (GNUNET_ERROR_TYPE_ERROR,
- _
- ("Must specify `%s' or numeric IP address for `%s' of `%s' in configuration!\n"),
- "localhost", "HOSTNAME", "resolver");
+ _("Must specify `%s' or numeric IP address for `%s' of `%s' in configuration!\n"),
+ "localhost",
+ "HOSTNAME",
+ "resolver");
GNUNET_free (hostname);
GNUNET_assert (0);
}
GNUNET_assert (NULL == req_tail);
if (NULL != client)
{
- LOG (GNUNET_ERROR_TYPE_DEBUG, "Disconnecting from DNS service\n");
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Disconnecting from DNS service\n");
GNUNET_CLIENT_disconnect (client);
client = NULL;
}
- if (r_task != GNUNET_SCHEDULER_NO_TASK)
+ if (GNUNET_SCHEDULER_NO_TASK != r_task)
{
GNUNET_SCHEDULER_cancel (r_task);
r_task = GNUNET_SCHEDULER_NO_TASK;
}
- if (s_task != GNUNET_SCHEDULER_NO_TASK)
+ if (GNUNET_SCHEDULER_NO_TASK != s_task)
{
GNUNET_SCHEDULER_cancel (s_task);
s_task = GNUNET_SCHEDULER_NO_TASK;
*
* @param af address family
* @param ip the address
- * @param ip_len number of bytes in ip
+ * @param ip_len number of bytes in @a ip
* @return address as a string, NULL on error
*/
static char *
if (NULL ==
inet_ntop (AF_INET, ip, buf, sizeof (buf)))
{
- LOG_STRERROR (GNUNET_ERROR_TYPE_WARNING, "inet_ntop");
+ LOG_STRERROR (GNUNET_ERROR_TYPE_WARNING,
+ "inet_ntop");
return NULL;
}
break;
if (NULL ==
inet_ntop (AF_INET6, ip, buf, sizeof (buf)))
{
- LOG_STRERROR (GNUNET_ERROR_TYPE_WARNING, "inet_ntop");
+ LOG_STRERROR (GNUNET_ERROR_TYPE_WARNING,
+ "inet_ntop");
return NULL;
}
break;
* Adjust exponential back-off and reconnect to the service.
*/
static void
-reconnect ();
+reconnect (void);
/**
* Process pending requests to the resolver.
*/
static void
-process_requests ();
+process_requests (void);
/**
* Process response with a hostname for a DNS lookup.
*
- * @param cls our "struct GNUNET_RESOLVER_RequestHandle" context
+ * @param cls our `struct GNUNET_RESOLVER_RequestHandle *` context
* @param msg message with the hostname, NULL on error
*/
static void
-handle_response (void *cls, const struct GNUNET_MessageHeader *msg)
+handle_response (void *cls,
+ const struct GNUNET_MessageHeader *msg)
{
struct GNUNET_RESOLVER_RequestHandle *rh = cls;
uint16_t size;
+ char *nret;
- LOG (GNUNET_ERROR_TYPE_DEBUG, "Receiving response from DNS service\n");
- if (msg == NULL)
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Receiving response from DNS service\n");
+ if (NULL == msg)
{
char buf[INET6_ADDRSTRLEN];
if (NULL != rh->name_callback)
LOG (GNUNET_ERROR_TYPE_INFO,
_("Timeout trying to resolve IP address `%s'.\n"),
- inet_ntop (rh->af, (const void *) &rh[1], buf, sizeof(buf)));
+ inet_ntop (rh->af,
+ (const void *) &rh[1],
+ buf,
+ sizeof(buf)));
else
LOG (GNUNET_ERROR_TYPE_INFO,
_("Timeout trying to resolve hostname `%s'.\n"),
(const char *) &rh[1]);
/* check if request was canceled */
- if (rh->was_transmitted != GNUNET_SYSERR)
+ if (GNUNET_SYSERR != rh->was_transmitted)
{
if (NULL != rh->name_callback)
{
- /* no reverse lookup was successful, return ip as string */
- if (rh->received_response == GNUNET_NO)
+ /* no reverse lookup was successful, return IP as string */
+ if (GNUNET_NO == rh->received_response)
{
- rh->name_callback (rh->cls, no_resolve (rh->af, &rh[1], rh->data_len));
- rh->name_callback (rh->cls, NULL);
+ nret = no_resolve (rh->af,
+ &rh[1],
+ rh->data_len);
+ rh->name_callback (rh->cls, nret);
+ GNUNET_free (nret);
}
- /* at least one reverse lookup was successful */
- else
- rh->name_callback (rh->cls, NULL);
+ /* finally, make termination call */
+ rh->name_callback (rh->cls, NULL);
}
if (NULL != rh->addr_callback)
rh->addr_callback (rh->cls, NULL, 0);
}
GNUNET_CONTAINER_DLL_remove (req_head, req_tail, rh);
+ if (GNUNET_SCHEDULER_NO_TASK != rh->task)
+ GNUNET_SCHEDULER_cancel (rh->task);
GNUNET_free (rh);
GNUNET_CLIENT_disconnect (client);
client = NULL;
return;
}
size = ntohs (msg->size);
- /* message contains not data, just header */
if (size == sizeof (struct GNUNET_MessageHeader))
{
+ /* message contains not data, just header; end of replies */
/* check if request was canceled */
- if (rh->was_transmitted != GNUNET_SYSERR)
+ if (GNUNET_SYSERR != rh->was_transmitted)
{
if (NULL != rh->name_callback)
rh->name_callback (rh->cls, NULL);
rh->addr_callback (rh->cls, NULL, 0);
}
GNUNET_CONTAINER_DLL_remove (req_head, req_tail, rh);
+ if (GNUNET_SCHEDULER_NO_TASK != rh->task)
+ GNUNET_SCHEDULER_cancel (rh->task);
GNUNET_free (rh);
process_requests ();
return;
if (hostname[size - sizeof (struct GNUNET_MessageHeader) - 1] != '\0')
{
GNUNET_break (0);
- if (rh->was_transmitted != GNUNET_SYSERR)
+ if (GNUNET_SYSERR != rh->was_transmitted)
rh->name_callback (rh->cls, NULL);
GNUNET_CONTAINER_DLL_remove (req_head, req_tail, rh);
+ if (GNUNET_SCHEDULER_NO_TASK != rh->task)
+ GNUNET_SCHEDULER_cancel (rh->task);
GNUNET_free (rh);
GNUNET_CLIENT_disconnect (client);
client = NULL;
reconnect ();
return;
}
- LOG (GNUNET_ERROR_TYPE_DEBUG, "Resolver returns `%s' for IP `%s'.\n",
- hostname, GNUNET_a2s ((const void *) &rh[1], rh->data_len));
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Resolver returns `%s' for IP `%s'.\n",
+ hostname,
+ GNUNET_a2s ((const void *) &rh[1],
+ rh->data_len));
if (rh->was_transmitted != GNUNET_SYSERR)
rh->name_callback (rh->cls, hostname);
rh->received_response = GNUNET_YES;
- GNUNET_CLIENT_receive (client, &handle_response, rh,
- GNUNET_TIME_absolute_get_remaining (rh->timeout));
}
/* return lookup results to caller */
if (NULL != rh->addr_callback)
else
{
GNUNET_break (0);
- if (rh->was_transmitted != GNUNET_SYSERR)
+ if (GNUNET_SYSERR != rh->was_transmitted)
rh->addr_callback (rh->cls, NULL, 0);
GNUNET_CONTAINER_DLL_remove (req_head, req_tail, rh);
+ if (GNUNET_SCHEDULER_NO_TASK != rh->task)
+ GNUNET_SCHEDULER_cancel (rh->task);
GNUNET_free (rh);
GNUNET_CLIENT_disconnect (client);
client = NULL;
return;
}
rh->addr_callback (rh->cls, sa, salen);
- GNUNET_CLIENT_receive (client, &handle_response, rh,
- GNUNET_TIME_absolute_get_remaining (rh->timeout));
}
+ GNUNET_CLIENT_receive (client,
+ &handle_response,
+ rh,
+ GNUNET_TIME_absolute_get_remaining (rh->timeout));
}
* given a valid numeric string. Perform the callbacks for the
* numeric addresses.
*
- * @param cls struct GNUNET_RESOLVER_RequestHandle for the request
+ * @param cls `struct GNUNET_RESOLVER_RequestHandle` for the request
* @param tc unused scheduler context
*/
static void
-numeric_resolution (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
+numeric_resolution (void *cls,
+ const struct GNUNET_SCHEDULER_TaskContext *tc)
{
struct GNUNET_RESOLVER_RequestHandle *rh = cls;
struct sockaddr_in v4;
struct sockaddr_in6 v6;
const char *hostname;
+ rh->task = GNUNET_SCHEDULER_NO_TASK;
memset (&v4, 0, sizeof (v4));
v4.sin_family = AF_INET;
#if HAVE_SOCKADDR_IN_SIN_LEN
if (((rh->af == AF_UNSPEC) || (rh->af == AF_INET)) &&
(1 == inet_pton (AF_INET, hostname, &v4.sin_addr)))
{
- rh->addr_callback (rh->cls, (const struct sockaddr *) &v4, sizeof (v4));
+ rh->addr_callback (rh->cls,
+ (const struct sockaddr *) &v4,
+ sizeof (v4));
if ((rh->af == AF_UNSPEC) &&
(1 == inet_pton (AF_INET6, hostname, &v6.sin6_addr)))
{
/* this can happen on some systems IF "hostname" is "localhost" */
- rh->addr_callback (rh->cls, (const struct sockaddr *) &v6, sizeof (v6));
+ rh->addr_callback (rh->cls,
+ (const struct sockaddr *) &v6,
+ sizeof (v6));
}
rh->addr_callback (rh->cls, NULL, 0);
GNUNET_free (rh);
return;
}
- if (((rh->af == AF_UNSPEC) || (rh->af == AF_INET6)) &&
- (1 == inet_pton (AF_INET6, hostname, &v6.sin6_addr)))
+ if ( ( (rh->af == AF_UNSPEC) ||
+ (rh->af == AF_INET6) ) &&
+ (1 == inet_pton (AF_INET6, hostname, &v6.sin6_addr) ) )
{
- rh->addr_callback (rh->cls, (const struct sockaddr *) &v6, sizeof (v6));
+ rh->addr_callback (rh->cls,
+ (const struct sockaddr *) &v6,
+ sizeof (v6));
rh->addr_callback (rh->cls, NULL, 0);
GNUNET_free (rh);
return;
* given a variant of "loopback". Perform the callbacks for the
* respective loopback numeric addresses.
*
- * @param cls struct GNUNET_RESOLVER_RequestHandle for the request
+ * @param cls `struct GNUNET_RESOLVER_RequestHandle` for the request
* @param tc unused scheduler context
*/
static void
-loopback_resolution (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
+loopback_resolution (void *cls,
+ const struct GNUNET_SCHEDULER_TaskContext *tc)
{
struct GNUNET_RESOLVER_RequestHandle *rh = cls;
struct sockaddr_in v4;
struct sockaddr_in6 v6;
+ rh->task = GNUNET_SCHEDULER_NO_TASK;
memset (&v4, 0, sizeof (v4));
v4.sin_addr.s_addr = htonl (INADDR_LOOPBACK);
v4.sin_family = AF_INET;
GNUNET_break (0);
break;
}
- rh->addr_callback (rh->cls, NULL, 0);
+ rh->addr_callback (rh->cls,
+ NULL,
+ 0);
GNUNET_free (rh);
}
* Task executed on system shutdown.
*/
static void
-shutdown_task (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
+shutdown_task (void *cls,
+ const struct GNUNET_SCHEDULER_TaskContext *tc)
{
s_task = GNUNET_SCHEDULER_NO_TASK;
GNUNET_RESOLVER_disconnect ();
+ backoff = GNUNET_TIME_UNIT_MILLISECONDS;
}
LOG (GNUNET_ERROR_TYPE_DEBUG,
"Transmitting DNS resolution request to DNS service\n");
if (GNUNET_OK !=
- GNUNET_CLIENT_transmit_and_get_response (client, &msg->header,
- GNUNET_TIME_absolute_get_remaining
- (rh->timeout), GNUNET_YES,
+ GNUNET_CLIENT_transmit_and_get_response (client,
+ &msg->header,
+ GNUNET_TIME_absolute_get_remaining (rh->timeout),
+ GNUNET_YES,
&handle_response, rh))
{
GNUNET_CLIENT_disconnect (client);
client = NULL;
+ GNUNET_break (0);
reconnect ();
return;
}
* @param tc scheduler context
*/
static void
-reconnect_task (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
+reconnect_task (void *cls,
+ const struct GNUNET_SCHEDULER_TaskContext *tc)
{
r_task = GNUNET_SCHEDULER_NO_TASK;
if (NULL == req_head)
return; /* no work pending */
if (0 != (tc->reason & GNUNET_SCHEDULER_REASON_SHUTDOWN))
return;
- LOG (GNUNET_ERROR_TYPE_DEBUG, "Trying to connect to DNS service\n");
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Trying to connect to DNS service\n");
client = GNUNET_CLIENT_connect ("resolver", resolver_cfg);
if (NULL == client)
{
- LOG (GNUNET_ERROR_TYPE_DEBUG, "Failed to connect, will try again later\n");
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Failed to connect, will try again later\n");
reconnect ();
return;
}
}
+/**
+ * A DNS resolution timed out. Notify the application.
+ *
+ * @param cls the `struct GNUNET_RESOLVER_RequestHandle *`
+ * @param tc scheduler context
+ */
+static void
+handle_lookup_timeout (void *cls,
+ const struct GNUNET_SCHEDULER_TaskContext *tc)
+{
+ struct GNUNET_RESOLVER_RequestHandle *rh = cls;
+
+ rh->task = GNUNET_SCHEDULER_NO_TASK;
+ rh->addr_callback (rh->cls,
+ NULL,
+ 0);
+ GNUNET_RESOLVER_request_cancel (rh);
+}
+
+
/**
* Convert a string to one or more IP addresses.
*
* @param hostname the hostname to resolve
* @param af AF_INET or AF_INET6; use AF_UNSPEC for "any"
* @param callback function to call with addresses
- * @param callback_cls closure for callback
+ * @param callback_cls closure for @a callback
* @param timeout how long to try resolving
* @return handle that can be used to cancel the request, NULL on error
*/
rh->af = af;
rh->addr_callback = callback;
rh->cls = callback_cls;
- memcpy (&rh[1], hostname, slen);
+ memcpy (&rh[1],
+ hostname,
+ slen);
rh->data_len = slen;
rh->timeout = GNUNET_TIME_relative_to_absolute (timeout);
rh->direction = GNUNET_NO;
((1 == inet_pton (AF_INET6, hostname, &v6)) &&
((af == AF_INET6) || (af == AF_UNSPEC))))
{
- rh->task = GNUNET_SCHEDULER_add_now (&numeric_resolution, rh);
+ rh->task = GNUNET_SCHEDULER_add_now (&numeric_resolution,
+ rh);
return rh;
}
/* then, check if this is a loopback address */
while (NULL != loopback[i])
if (0 == strcasecmp (loopback[i++], hostname))
{
- rh->task = GNUNET_SCHEDULER_add_now (&loopback_resolution, rh);
+ rh->task = GNUNET_SCHEDULER_add_now (&loopback_resolution,
+ rh);
return rh;
}
+ rh->task = GNUNET_SCHEDULER_add_delayed (timeout,
+ &handle_lookup_timeout,
+ rh);
GNUNET_CONTAINER_DLL_insert_tail (req_head, req_tail, rh);
rh->was_queued = GNUNET_YES;
if (s_task != GNUNET_SCHEDULER_NO_TASK)
/**
* We've been asked to convert an address to a string without
- * a reverse lookup. Do it.
+ * a reverse lookup, either because the client asked for it
+ * or because the DNS lookup hit a timeout. Do the numeric
+ * conversion and invoke the callback.
*
- * @param cls struct GNUNET_RESOLVER_RequestHandle for the request
+ * @param cls `struct GNUNET_RESOLVER_RequestHandle` for the request
* @param tc unused scheduler context
*/
static void
-numeric_reverse (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
+numeric_reverse (void *cls,
+ const struct GNUNET_SCHEDULER_TaskContext *tc)
{
struct GNUNET_RESOLVER_RequestHandle *rh = cls;
char *result;
- result = no_resolve (rh->af, &rh[1], rh->data_len);
- LOG (GNUNET_ERROR_TYPE_DEBUG, "Resolver returns `%s'.\n", result);
- if (result != NULL)
+ rh->task = GNUNET_SCHEDULER_NO_TASK;
+ result = no_resolve (rh->af,
+ &rh[1],
+ rh->data_len);
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Resolver returns `%s'.\n",
+ result);
+ if (NULL != result)
{
rh->name_callback (rh->cls, result);
GNUNET_free (result);
* Get an IP address as a string.
*
* @param sa host address
- * @param salen length of host address
- * @param do_resolve use GNUNET_NO to return numeric hostname
+ * @param salen length of host address in @a sa
+ * @param do_resolve use #GNUNET_NO to return numeric hostname
* @param timeout how long to try resolving
* @param callback function to call with hostnames
* last callback is NULL when finished
- * @param cls closure for callback
+ * @param cls closure for @a callback
* @return handle that can be used to cancel the request
*/
struct GNUNET_RESOLVER_RequestHandle *
-GNUNET_RESOLVER_hostname_get (const struct sockaddr *sa, socklen_t salen,
+GNUNET_RESOLVER_hostname_get (const struct sockaddr *sa,
+ socklen_t salen,
int do_resolve,
struct GNUNET_TIME_Relative timeout,
GNUNET_RESOLVER_HostnameCallback callback,
rh->task = GNUNET_SCHEDULER_add_now (&numeric_reverse, rh);
return rh;
}
- GNUNET_CONTAINER_DLL_insert_tail (req_head, req_tail, rh);
+ rh->task = GNUNET_SCHEDULER_add_delayed (timeout,
+ &numeric_reverse,
+ rh);
+ GNUNET_CONTAINER_DLL_insert_tail (req_head,
+ req_tail,
+ rh);
rh->was_queued = GNUNET_YES;
if (s_task != GNUNET_SCHEDULER_NO_TASK)
{
"gethostname");
return NULL;
}
- LOG (GNUNET_ERROR_TYPE_DEBUG, "Resolving our FQDN `%s'\n", hostname);
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Resolving our FQDN `%s'\n",
+ hostname);
host = gethostbyname (hostname);
if (NULL == host)
{
- LOG (GNUNET_ERROR_TYPE_ERROR, _("Could not resolve our FQDN : %s\n"),
+ LOG (GNUNET_ERROR_TYPE_ERROR,
+ _("Could not resolve our FQDN : %s\n"),
hstrerror (h_errno));
return NULL;
}
* Looking our own hostname.
*
* @param af AF_INET or AF_INET6; use AF_UNSPEC for "any"
- * @param callback function to call with addresses
- * @param cls closure for callback
* @param timeout how long to try resolving
+ * @param callback function to call with addresses
+ * @param cls closure for @a callback
* @return handle that can be used to cancel the request, NULL on error
*/
struct GNUNET_RESOLVER_RequestHandle *
"gethostname");
return NULL;
}
- LOG (GNUNET_ERROR_TYPE_DEBUG, "Resolving our hostname `%s'\n", hostname);
- return GNUNET_RESOLVER_ip_get (hostname, af, timeout, callback, cls);
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Resolving our hostname `%s'\n",
+ hostname);
+ return GNUNET_RESOLVER_ip_get (hostname,
+ af,
+ timeout,
+ callback,
+ cls);
}
GNUNET_SCHEDULER_cancel (rh->task);
rh->task = GNUNET_SCHEDULER_NO_TASK;
}
- if (rh->was_transmitted == GNUNET_NO)
+ if (GNUNET_NO == rh->was_transmitted)
{
if (rh->was_queued == GNUNET_YES)
- GNUNET_CONTAINER_DLL_remove (req_head, req_tail, rh);
+ GNUNET_CONTAINER_DLL_remove (req_head,
+ req_tail,
+ rh);
GNUNET_free (rh);
return;
}
- GNUNET_assert (rh->was_transmitted == GNUNET_YES);
+ GNUNET_assert (GNUNET_YES == rh->was_transmitted);
rh->was_transmitted = GNUNET_SYSERR; /* mark as cancelled */
}
projects / oweals / gnunet.git / blobdiff