/*
This file is part of GNUnet.
- Copyright (C) 2009-2015 GNUnet e.V.
+ Copyright (C) 2009-2018 GNUnet e.V.
- GNUnet is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License as published
- by the Free Software Foundation; either version 3, or (at your
- option) any later version.
+ GNUnet is free software: you can redistribute it and/or modify it
+ under the terms of the GNU Affero General Public License as published
+ by the Free Software Foundation, either version 3 of the License,
+ or (at your option) any later version.
GNUnet is distributed in the hope that it will be useful, but
WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- General Public License for more details.
+ Affero General Public License for more details.
+
+ You should have received a copy of the GNU Affero General Public License
+ along with this program. If not, see <http://www.gnu.org/licenses/>.
- You should have received a copy of the GNU General Public License
- along with GNUnet; see the file COPYING. If not, write to the
- Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
- Boston, MA 02110-1301, USA.
+ SPDX-License-Identifier: AGPL3.0-or-later
*/
/**
#include "gnunet_resolver_service.h"
#include "resolver.h"
-#define LOG(kind,...) GNUNET_log_from (kind, "resolver-api", __VA_ARGS__)
+#define LOG(kind,...) GNUNET_log_from (kind, "util-resolver-api", __VA_ARGS__)
-#define LOG_STRERROR(kind,syscall) GNUNET_log_from_strerror (kind, "resolver-api", syscall)
+#define LOG_STRERROR(kind,syscall) GNUNET_log_from_strerror (kind, "util-resolver-api", syscall)
/**
* Maximum supported length for a hostname
* Our connection to the resolver service, created on-demand, but then
* persists until error or shutdown.
*/
-static struct GNUNET_CLIENT_Connection *client;
+static struct GNUNET_MQ_Handle *mq;
/**
* Head of DLL of requests.
*/
static struct GNUNET_RESOLVER_RequestHandle *req_tail;
+/**
+ * ID of the last request we sent to the service
+ */
+static uint32_t last_request_id;
+
/**
* How long should we wait to reconnect?
*/
GNUNET_RESOLVER_HostnameCallback name_callback;
/**
- * Closure for the respective "callback".
+ * Closure for the callbacks.
*/
void *cls;
* Task handle for making reply callbacks in numeric lookups
* asynchronous, and for timeout handling.
*/
- struct GNUNET_SCHEDULER_Task * task;
+ struct GNUNET_SCHEDULER_Task *task;
/**
* Desired address family.
*/
int af;
+ /**
+ * Identifies the request. The response will contain this id.
+ */
+ uint32_t id;
+
/**
* Has this request been transmitted to the service?
* #GNUNET_YES if transmitted
check_config ()
{
char *hostname;
- unsigned int i;
struct sockaddr_in v4;
struct sockaddr_in6 v6;
+ if (GNUNET_OK ==
+ GNUNET_CONFIGURATION_have_value (resolver_cfg,
+ "resolver",
+ "UNIXPATH"))
+ return GNUNET_OK;
memset (&v4, 0, sizeof (v4));
v4.sin_addr.s_addr = htonl (INADDR_LOOPBACK);
v4.sin_family = AF_INET;
"resolver");
return GNUNET_SYSERR;
}
- if ((1 != inet_pton (AF_INET, hostname, &v4)) ||
- (1 != inet_pton (AF_INET6, hostname, &v6)))
+ if ( (1 == inet_pton (AF_INET, hostname, &v4)) ||
+ (1 == inet_pton (AF_INET6, hostname, &v6)) )
{
GNUNET_free (hostname);
- return GNUNET_SYSERR;
+ return GNUNET_OK;
}
- i = 0;
- while (NULL != loopback[i])
- if (0 == strcasecmp (loopback[i++], hostname))
+ for (unsigned int i = 0;
+ NULL != loopback[i];
+ i++)
+ if (0 == strcasecmp (loopback[i],
+ hostname))
{
GNUNET_free (hostname);
return GNUNET_OK;
GNUNET_assert (NULL != cfg);
backoff = GNUNET_TIME_UNIT_MILLISECONDS;
resolver_cfg = cfg;
- (void) check_config ();
}
void
GNUNET_RESOLVER_disconnect ()
{
- GNUNET_assert (NULL == req_head);
- GNUNET_assert (NULL == req_tail);
- if (NULL != client)
+ struct GNUNET_RESOLVER_RequestHandle *rh;
+
+ while (NULL != (rh = req_head))
+ {
+ GNUNET_assert (GNUNET_SYSERR == rh->was_transmitted);
+ GNUNET_CONTAINER_DLL_remove (req_head,
+ req_tail,
+ rh);
+ GNUNET_free (rh);
+ }
+ if (NULL != mq)
{
LOG (GNUNET_ERROR_TYPE_DEBUG,
"Disconnecting from DNS service\n");
- GNUNET_CLIENT_disconnect (client);
- client = NULL;
+ GNUNET_MQ_destroy (mq);
+ mq = NULL;
}
if (NULL != r_task)
{
}
+/**
+ * Task executed on system shutdown.
+ */
+static void
+shutdown_task (void *cls)
+{
+ (void) cls;
+ s_task = NULL;
+ GNUNET_RESOLVER_disconnect ();
+ backoff = GNUNET_TIME_UNIT_MILLISECONDS;
+}
+
+
+/**
+ * Consider disconnecting if we have no further requests pending.
+ */
+static void
+check_disconnect ()
+{
+ for (struct GNUNET_RESOLVER_RequestHandle *rh = req_head;
+ NULL != rh;
+ rh = rh->next)
+ if (GNUNET_SYSERR != rh->was_transmitted)
+ return;
+ if (NULL != r_task)
+ {
+ GNUNET_SCHEDULER_cancel (r_task);
+ r_task = NULL;
+ }
+ if (NULL != s_task)
+ return;
+ s_task = GNUNET_SCHEDULER_add_delayed (GNUNET_TIME_UNIT_MILLISECONDS,
+ &shutdown_task,
+ NULL);
+}
+
+
/**
* Convert IP address to string without DNS resolution.
*
*/
static char *
no_resolve (int af,
- const void *ip, socklen_t ip_len)
+ const void *ip,
+ socklen_t ip_len)
{
char buf[INET6_ADDRSTRLEN];
if (ip_len != sizeof (struct in_addr))
return NULL;
if (NULL ==
- inet_ntop (AF_INET, ip, buf, sizeof (buf)))
+ inet_ntop (AF_INET,
+ ip,
+ buf,
+ sizeof (buf)))
{
LOG_STRERROR (GNUNET_ERROR_TYPE_WARNING,
"inet_ntop");
if (ip_len != sizeof (struct in6_addr))
return NULL;
if (NULL ==
- inet_ntop (AF_INET6, ip, buf, sizeof (buf)))
+ inet_ntop (AF_INET6,
+ ip,
+ buf,
+ sizeof (buf)))
{
LOG_STRERROR (GNUNET_ERROR_TYPE_WARNING,
"inet_ntop");
reconnect (void);
+/**
+ * Generic error handler, called with the appropriate error code and
+ * the same closure specified at the creation of the message queue.
+ * Not every message queue implementation supports an error handler.
+ *
+ * @param cls NULL
+ * @param error error code
+ */
+static void
+mq_error_handler (void *cls,
+ enum GNUNET_MQ_Error error)
+{
+ (void) cls;
+ GNUNET_MQ_destroy (mq);
+ mq = NULL;
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "MQ error %d, reconnecting\n",
+ error);
+ reconnect ();
+}
+
+
/**
* Process pending requests to the resolver.
*/
static void
-process_requests (void);
+process_requests ()
+{
+ struct GNUNET_RESOLVER_GetMessage *msg;
+ struct GNUNET_MQ_Envelope *env;
+ struct GNUNET_RESOLVER_RequestHandle *rh = req_head;
+
+ if (NULL == mq)
+ {
+ reconnect ();
+ return;
+ }
+ if (NULL == rh)
+ {
+ /* nothing to do, release socket really soon if there is nothing
+ * else happening... */
+ if (NULL == s_task)
+ s_task =
+ GNUNET_SCHEDULER_add_delayed (GNUNET_TIME_UNIT_MILLISECONDS,
+ &shutdown_task,
+ NULL);
+ return;
+ }
+ if (GNUNET_NO != rh->was_transmitted)
+ return; /* waiting for reply */
+ env = GNUNET_MQ_msg_extra (msg,
+ rh->data_len,
+ GNUNET_MESSAGE_TYPE_RESOLVER_REQUEST);
+ msg->direction = htonl (rh->direction);
+ msg->af = htonl (rh->af);
+ msg->client_id = rh->id;
+ GNUNET_memcpy (&msg[1],
+ &rh[1],
+ rh->data_len);
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Transmitting DNS resolution request (ID %u) to DNS service\n",
+ rh->id);
+ GNUNET_MQ_send (mq,
+ env);
+ rh->was_transmitted = GNUNET_YES;
+}
+
+
+/**
+ * Check validity of response with a hostname for a DNS lookup.
+ *
+ * @param cls NULL
+ * @param msg message with the hostname
+ */
+static int
+check_response (void *cls,
+ const struct GNUNET_RESOLVER_ResponseMessage *msg)
+{
+ (void) cls;
+ (void) msg;
+
+ /* implemented in #handle_response() for now */
+ return GNUNET_OK;
+}
/**
- * Process response with a hostname for a DNS lookup.
+ * Check validity of response with a hostname for a DNS lookup.
+ * NOTE: right now rather messy, might want to use different
+ * message types for different response formats in the future.
*
- * @param cls our `struct GNUNET_RESOLVER_RequestHandle *` context
- * @param msg message with the hostname, NULL on error
+ * @param cls NULL
+ * @param msg message with the response
*/
static void
handle_response (void *cls,
- const struct GNUNET_MessageHeader *msg)
+ const struct GNUNET_RESOLVER_ResponseMessage *msg)
{
- struct GNUNET_RESOLVER_RequestHandle *rh = cls;
+ struct GNUNET_RESOLVER_RequestHandle *rh = req_head;
uint16_t size;
char *nret;
+ uint32_t client_request_id = msg->client_id;
- LOG (GNUNET_ERROR_TYPE_DEBUG,
- "Receiving response from DNS service\n");
- if (NULL == msg)
+ for (; rh != NULL; rh = rh->next)
{
- char buf[INET6_ADDRSTRLEN];
-
- if (NULL != rh->name_callback)
- LOG (GNUNET_ERROR_TYPE_INFO,
- _("Timeout trying to resolve IP address `%s'.\n"),
- inet_ntop (rh->af,
- (const void *) &rh[1],
- buf,
- sizeof(buf)));
- else
- LOG (GNUNET_ERROR_TYPE_INFO,
- _("Timeout trying to resolve hostname `%s'.\n"),
- (const char *) &rh[1]);
- /* check if request was canceled */
- if (GNUNET_SYSERR != rh->was_transmitted)
- {
- if (NULL != rh->name_callback)
- {
- /* no reverse lookup was successful, return IP as string */
- if (GNUNET_NO == rh->received_response)
- {
- nret = no_resolve (rh->af,
- &rh[1],
- rh->data_len);
- rh->name_callback (rh->cls, nret);
- GNUNET_free (nret);
- }
- /* finally, make termination call */
- rh->name_callback (rh->cls,
- NULL);
- }
- if (NULL != rh->addr_callback)
- rh->addr_callback (rh->cls,
- NULL,
- 0);
- }
- rh->was_transmitted = GNUNET_NO;
- GNUNET_RESOLVER_request_cancel (rh);
- GNUNET_CLIENT_disconnect (client);
- client = NULL;
- reconnect ();
- return;
+ if (rh->id == client_request_id)
+ break;
}
- if (GNUNET_MESSAGE_TYPE_RESOLVER_RESPONSE != ntohs (msg->type))
+
+ (void) cls;
+ if (NULL == rh)
{
+ /* Resolver service sent extra replies to query (after terminator)? Bad! */
GNUNET_break (0);
- GNUNET_CLIENT_disconnect (client);
- client = NULL;
+ GNUNET_MQ_destroy (mq);
+ mq = NULL;
reconnect ();
return;
}
- size = ntohs (msg->size);
- if (size == sizeof (struct GNUNET_MessageHeader))
+ size = ntohs (msg->header.size);
+ if (size == sizeof (struct GNUNET_RESOLVER_ResponseMessage))
{
LOG (GNUNET_ERROR_TYPE_DEBUG,
"Received empty response from DNS service\n");
GNUNET_free (nret);
}
/* finally, make termination call */
- rh->name_callback (rh->cls,
- NULL);
+ if (GNUNET_SYSERR != rh->was_transmitted)
+ rh->name_callback (rh->cls,
+ NULL);
}
- if (NULL != rh->addr_callback)
- rh->addr_callback (rh->cls,
- NULL,
- 0);
+ if ( (NULL != rh->addr_callback) &&
+ (GNUNET_SYSERR != rh->was_transmitted) )
+ rh->addr_callback (rh->cls,
+ NULL,
+ 0);
}
rh->was_transmitted = GNUNET_NO;
GNUNET_RESOLVER_request_cancel (rh);
const char *hostname;
hostname = (const char *) &msg[1];
- if (hostname[size - sizeof (struct GNUNET_MessageHeader) - 1] != '\0')
+ if (hostname[size - sizeof (struct GNUNET_RESOLVER_ResponseMessage) - 1] != '\0')
{
GNUNET_break (0);
if (GNUNET_SYSERR != rh->was_transmitted)
NULL);
rh->was_transmitted = GNUNET_NO;
GNUNET_RESOLVER_request_cancel (rh);
- GNUNET_CLIENT_disconnect (client);
- client = NULL;
+ GNUNET_MQ_destroy (mq);
+ mq = NULL;
reconnect ();
return;
}
size_t ip_len;
ip = &msg[1];
- ip_len = size - sizeof (struct GNUNET_MessageHeader);
+ ip_len = size - sizeof (struct GNUNET_RESOLVER_ResponseMessage);
if (ip_len == sizeof (struct in_addr))
{
memset (&v4, 0, sizeof (v4));
0);
rh->was_transmitted = GNUNET_NO;
GNUNET_RESOLVER_request_cancel (rh);
- GNUNET_CLIENT_disconnect (client);
- client = NULL;
+ GNUNET_MQ_destroy (mq);
+ mq = NULL;
reconnect ();
return;
}
sa,
salen);
}
- GNUNET_CLIENT_receive (client,
- &handle_response,
- rh,
- GNUNET_TIME_absolute_get_remaining (rh->timeout));
}
* numeric addresses.
*
* @param cls `struct GNUNET_RESOLVER_RequestHandle` for the request
- * @param tc unused scheduler context
*/
static void
-numeric_resolution (void *cls,
- const struct GNUNET_SCHEDULER_TaskContext *tc)
+numeric_resolution (void *cls)
{
struct GNUNET_RESOLVER_RequestHandle *rh = cls;
struct sockaddr_in v4;
v6.sin6_len = sizeof (v6);
#endif
hostname = (const char *) &rh[1];
- if (((rh->af == AF_UNSPEC) || (rh->af == AF_INET)) &&
- (1 == inet_pton (AF_INET, hostname, &v4.sin_addr)))
+ if ( ( (rh->af == AF_UNSPEC) ||
+ (rh->af == AF_INET) ) &&
+ (1 == inet_pton (AF_INET,
+ hostname,
+ &v4.sin_addr)) )
{
rh->addr_callback (rh->cls,
(const struct sockaddr *) &v4,
sizeof (v4));
- if ((rh->af == AF_UNSPEC) &&
- (1 == inet_pton (AF_INET6, hostname, &v6.sin6_addr)))
+ if ( (rh->af == AF_UNSPEC) &&
+ (GNUNET_SYSERR != rh->was_transmitted) &&
+ (1 == inet_pton (AF_INET6,
+ hostname,
+ &v6.sin6_addr)) )
{
/* this can happen on some systems IF "hostname" is "localhost" */
rh->addr_callback (rh->cls,
(const struct sockaddr *) &v6,
sizeof (v6));
}
- rh->addr_callback (rh->cls,
- NULL,
- 0);
+ if (GNUNET_SYSERR != rh->was_transmitted)
+ rh->addr_callback (rh->cls,
+ NULL,
+ 0);
GNUNET_free (rh);
return;
}
if ( ( (rh->af == AF_UNSPEC) ||
(rh->af == AF_INET6) ) &&
- (1 == inet_pton (AF_INET6, hostname, &v6.sin6_addr) ) )
+ (1 == inet_pton (AF_INET6,
+ hostname,
+ &v6.sin6_addr) ) )
{
rh->addr_callback (rh->cls,
(const struct sockaddr *) &v6,
sizeof (v6));
- rh->addr_callback (rh->cls,
- NULL,
- 0);
+ if (GNUNET_SYSERR != rh->was_transmitted)
+ rh->addr_callback (rh->cls,
+ NULL,
+ 0);
GNUNET_free (rh);
return;
}
* respective loopback numeric addresses.
*
* @param cls `struct GNUNET_RESOLVER_RequestHandle` for the request
- * @param tc unused scheduler context
*/
static void
-loopback_resolution (void *cls,
- const struct GNUNET_SCHEDULER_TaskContext *tc)
+loopback_resolution (void *cls)
{
struct GNUNET_RESOLVER_RequestHandle *rh = cls;
struct sockaddr_in v4;
rh->addr_callback (rh->cls,
(const struct sockaddr *) &v4,
sizeof (v4));
+
break;
default:
GNUNET_break (0);
break;
}
- rh->addr_callback (rh->cls,
- NULL,
- 0);
- GNUNET_free (rh);
-}
-
-
-/**
- * Task executed on system shutdown.
- */
-static void
-shutdown_task (void *cls,
- const struct GNUNET_SCHEDULER_TaskContext *tc)
-{
- s_task = NULL;
- GNUNET_RESOLVER_disconnect ();
- backoff = GNUNET_TIME_UNIT_MILLISECONDS;
-}
-
-
-/**
- * Process pending requests to the resolver.
- */
-static void
-process_requests ()
-{
- struct GNUNET_RESOLVER_GetMessage *msg;
- char buf[GNUNET_SERVER_MAX_MESSAGE_SIZE - 1] GNUNET_ALIGN;
- struct GNUNET_RESOLVER_RequestHandle *rh;
-
- if (NULL == client)
- {
- reconnect ();
- return;
- }
- rh = req_head;
- if (NULL == rh)
- {
- /* nothing to do, release socket really soon if there is nothing
- * else happening... */
- s_task =
- GNUNET_SCHEDULER_add_delayed (GNUNET_TIME_UNIT_MILLISECONDS,
- &shutdown_task,
- NULL);
- return;
- }
- if (GNUNET_NO != rh->was_transmitted)
- return; /* waiting for reply */
- msg = (struct GNUNET_RESOLVER_GetMessage *) buf;
- msg->header.size =
- htons (sizeof (struct GNUNET_RESOLVER_GetMessage) + rh->data_len);
- msg->header.type = htons (GNUNET_MESSAGE_TYPE_RESOLVER_REQUEST);
- msg->direction = htonl (rh->direction);
- msg->af = htonl (rh->af);
- memcpy (&msg[1],
- &rh[1],
- rh->data_len);
+ if (GNUNET_SYSERR != rh->was_transmitted)
+ rh->addr_callback (rh->cls,
+ NULL,
+ 0);
LOG (GNUNET_ERROR_TYPE_DEBUG,
- "Transmitting DNS resolution request to DNS service\n");
- if (GNUNET_OK !=
- GNUNET_CLIENT_transmit_and_get_response (client,
- &msg->header,
- GNUNET_TIME_absolute_get_remaining (rh->timeout),
- GNUNET_YES,
- &handle_response,
- rh))
- {
- GNUNET_CLIENT_disconnect (client);
- client = NULL;
- GNUNET_break (0);
- reconnect ();
- return;
- }
- rh->was_transmitted = GNUNET_YES;
+ "Finished resolving hostname `%s'.\n",
+ (const char *) &rh[1]);
+ GNUNET_free (rh);
}
* Now try to reconnect to the resolver service.
*
* @param cls NULL
- * @param tc scheduler context
*/
static void
-reconnect_task (void *cls,
- const struct GNUNET_SCHEDULER_TaskContext *tc)
+reconnect_task (void *cls)
{
+ struct GNUNET_MQ_MessageHandler handlers[] = {
+ GNUNET_MQ_hd_var_size (response,
+ GNUNET_MESSAGE_TYPE_RESOLVER_RESPONSE,
+ struct GNUNET_RESOLVER_ResponseMessage,
+ NULL),
+ GNUNET_MQ_handler_end ()
+ };
+
+ (void) cls;
r_task = NULL;
if (NULL == req_head)
return; /* no work pending */
- if (0 != (tc->reason & GNUNET_SCHEDULER_REASON_SHUTDOWN))
- return;
LOG (GNUNET_ERROR_TYPE_DEBUG,
"Trying to connect to DNS service\n");
- client = GNUNET_CLIENT_connect ("resolver",
- resolver_cfg);
- if (NULL == client)
+ mq = GNUNET_CLIENT_connect (resolver_cfg,
+ "resolver",
+ handlers,
+ &mq_error_handler,
+ NULL);
+ if (NULL == mq)
{
LOG (GNUNET_ERROR_TYPE_DEBUG,
"Failed to connect, will try again later\n");
if (NULL != r_task)
return;
- GNUNET_assert (NULL == client);
+ GNUNET_assert (NULL == mq);
if (NULL != (rh = req_head))
{
switch (rh->was_transmitted)
break;
case GNUNET_SYSERR:
/* request was cancelled, remove entirely */
- GNUNET_CONTAINER_DLL_remove (req_head, req_tail, rh);
+ GNUNET_CONTAINER_DLL_remove (req_head,
+ req_tail,
+ rh);
GNUNET_free (rh);
+ check_disconnect ();
break;
default:
GNUNET_assert (0);
* A DNS resolution timed out. Notify the application.
*
* @param cls the `struct GNUNET_RESOLVER_RequestHandle *`
- * @param tc scheduler context
*/
static void
-handle_lookup_timeout (void *cls,
- const struct GNUNET_SCHEDULER_TaskContext *tc)
+handle_lookup_timeout (void *cls)
{
struct GNUNET_RESOLVER_RequestHandle *rh = cls;
rh->task = NULL;
- rh->addr_callback (rh->cls,
- NULL,
- 0);
+ if (GNUNET_NO == rh->direction)
+ {
+ LOG (GNUNET_ERROR_TYPE_INFO,
+ _("Timeout trying to resolve hostname `%s'.\n"),
+ (const char *) &rh[1]);
+ if (NULL != rh->addr_callback)
+ rh->addr_callback (rh->cls,
+ NULL,
+ 0);
+ }
+ else
+ {
+#if !defined(GNUNET_CULL_LOGGING)
+ char buf[INET6_ADDRSTRLEN];
+
+ LOG (GNUNET_ERROR_TYPE_INFO,
+ _("Timeout trying to resolve IP address `%s'.\n"),
+ inet_ntop (rh->af,
+ (const void *) &rh[1],
+ buf,
+ sizeof(buf)));
+#endif
+ if (GNUNET_NO == rh->received_response)
+ {
+ char *nret;
+
+ nret = no_resolve (rh->af,
+ &rh[1],
+ rh->data_len);
+ if (NULL != rh->name_callback)
+ rh->name_callback (rh->cls, nret);
+ GNUNET_free (nret);
+ }
+ /* finally, make termination call */
+ if (NULL != rh->name_callback)
+ rh->name_callback (rh->cls,
+ NULL);
+ }
+ rh->was_transmitted = GNUNET_NO;
GNUNET_RESOLVER_request_cancel (rh);
+ process_requests ();
}
{
struct GNUNET_RESOLVER_RequestHandle *rh;
size_t slen;
- unsigned int i;
struct in_addr v4;
struct in6_addr v6;
slen = strlen (hostname) + 1;
if (slen + sizeof (struct GNUNET_RESOLVER_GetMessage) >=
- GNUNET_SERVER_MAX_MESSAGE_SIZE)
+ GNUNET_MAX_MESSAGE_SIZE)
{
GNUNET_break (0);
return NULL;
}
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Trying to resolve hostname `%s'.\n",
+ hostname);
rh = GNUNET_malloc (sizeof (struct GNUNET_RESOLVER_RequestHandle) + slen);
rh->af = af;
+ rh->id = ++last_request_id;
rh->addr_callback = callback;
rh->cls = callback_cls;
- memcpy (&rh[1],
- hostname,
- slen);
+ GNUNET_memcpy (&rh[1],
+ hostname,
+ slen);
rh->data_len = slen;
rh->timeout = GNUNET_TIME_relative_to_absolute (timeout);
rh->direction = GNUNET_NO;
/* first, check if this is a numeric address */
- if (((1 == inet_pton (AF_INET, hostname, &v4)) &&
- ((af == AF_INET) || (af == AF_UNSPEC))) ||
- ((1 == inet_pton (AF_INET6, hostname, &v6)) &&
- ((af == AF_INET6) || (af == AF_UNSPEC))))
+ if ( ( (1 == inet_pton (AF_INET,
+ hostname,
+ &v4)) &&
+ ( (af == AF_INET) ||
+ (af == AF_UNSPEC) ) ) ||
+ ( (1 == inet_pton (AF_INET6,
+ hostname,
+ &v6)) &&
+ ( (af == AF_INET6) ||
+ (af == AF_UNSPEC)) ) )
{
rh->task = GNUNET_SCHEDULER_add_now (&numeric_resolution,
rh);
return rh;
}
/* then, check if this is a loopback address */
- i = 0;
- while (NULL != loopback[i])
- if (0 == strcasecmp (loopback[i++],
+ for (unsigned int i = 0;
+ NULL != loopback[i];
+ i++)
+ if (0 == strcasecmp (loopback[i],
hostname))
{
rh->task = GNUNET_SCHEDULER_add_now (&loopback_resolution,
rh);
return rh;
}
+ if (GNUNET_OK != check_config ())
+ {
+ GNUNET_free (rh);
+ return NULL;
+ }
rh->task = GNUNET_SCHEDULER_add_delayed (timeout,
&handle_lookup_timeout,
rh);
* conversion and invoke the callback.
*
* @param cls `struct GNUNET_RESOLVER_RequestHandle` for the request
- * @param tc unused scheduler context
*/
static void
-numeric_reverse (void *cls,
- const struct GNUNET_SCHEDULER_TaskContext *tc)
+numeric_reverse (void *cls)
{
struct GNUNET_RESOLVER_RequestHandle *rh = cls;
char *result;
}
rh->name_callback (rh->cls,
NULL);
+ if (NULL != rh->task)
+ {
+ GNUNET_SCHEDULER_cancel (rh->task);
+ rh->task = NULL;
+ }
GNUNET_free (rh);
}
rh->name_callback = callback;
rh->cls = cls;
rh->af = sa->sa_family;
+ rh->id = ++last_request_id;
rh->timeout = GNUNET_TIME_relative_to_absolute (timeout);
- memcpy (&rh[1], ip, ip_len);
+ GNUNET_memcpy (&rh[1],
+ ip,
+ ip_len);
rh->data_len = ip_len;
rh->direction = GNUNET_YES;
rh->received_response = GNUNET_NO;
if (GNUNET_NO == do_resolve)
{
- rh->task = GNUNET_SCHEDULER_add_now (&numeric_reverse, rh);
+ rh->task = GNUNET_SCHEDULER_add_now (&numeric_reverse,
+ rh);
return rh;
}
+ rh->task = GNUNET_SCHEDULER_add_delayed (timeout,
+ &handle_lookup_timeout,
+ rh);
GNUNET_CONTAINER_DLL_insert_tail (req_head,
req_tail,
rh);
{
char hostname[GNUNET_OS_get_hostname_max_length () + 1];
- if (0 != gethostname (hostname, sizeof (hostname) - 1))
+ if (0 != gethostname (hostname,
+ sizeof (hostname) - 1))
{
LOG_STRERROR (GNUNET_ERROR_TYPE_ERROR | GNUNET_ERROR_TYPE_BULK,
"gethostname");
int ret;
char *rval;
- if (0 != (ret = getaddrinfo (hostname, NULL, NULL, &ai)))
+ if (0 != (ret = getaddrinfo (hostname,
+ NULL,
+ NULL,
+ &ai)))
{
LOG (GNUNET_ERROR_TYPE_ERROR,
_("Could not resolve our FQDN: %s\n"),
{
struct hostent *host;
- host = gethostbyname2 (hostname, AF_INET);
+ host = gethostbyname2 (hostname,
+ AF_INET);
if (NULL == host)
- host = gethostbyname2 (hostname, AF_INET6);
+ host = gethostbyname2 (hostname,
+ AF_INET6);
if (NULL == host)
{
LOG (GNUNET_ERROR_TYPE_ERROR,
void
GNUNET_RESOLVER_request_cancel (struct GNUNET_RESOLVER_RequestHandle *rh)
{
+ if (GNUNET_NO == rh->direction)
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Asked to cancel request to resolve hostname `%s'.\n",
+ (const char *) &rh[1]);
if (NULL != rh->task)
{
GNUNET_SCHEDULER_cancel (rh->task);
req_tail,
rh);
GNUNET_free (rh);
+ check_disconnect ();
return;
}
GNUNET_assert (GNUNET_YES == rh->was_transmitted);
rh->was_transmitted = GNUNET_SYSERR; /* mark as cancelled */
+ check_disconnect ();
}
projects / oweals / gnunet.git / blobdiff