Returns now GNUNET_SYSERR
[oweals/gnunet.git] / src / util / gnunet-service-resolver.c
index 5563d1ea5be1989d306566ebd78805f21ad835f9..68d2daae72527ad5d8ce4e7762bcadeb0d980994 100644 (file)
@@ -19,7 +19,7 @@
 */
 
 /**
- * @file resolver/gnunet-service-resolver.c
+ * @file util/gnunet-service-resolver.c
  * @brief code to do DNS resolution
  * @author Christian Grothoff
  */
 #include "gnunet_time_lib.h"
 #include "resolver.h"
 
-
+/**
+ * A cached DNS lookup result.
+ */
 struct IPCache
 {
+  /**
+   * This is a linked list.
+   */
   struct IPCache *next;
+
+  /**
+   * Hostname in human-readable form.
+   */
   char *addr;
+
+  /**
+   * Hostname in binary format.
+   */
   struct sockaddr *sa;
+
+  /**
+   * Last time this entry was updated.
+   */
   struct GNUNET_TIME_Absolute last_refresh;
+
+  /**
+   * Last time this entry was requested.
+   */
   struct GNUNET_TIME_Absolute last_request;
-  unsigned int salen;
+
+  /**
+   * Number of bytes in sa.
+   */
+  socklen_t salen;
 };
 
 
+/**
+ * Start of the linked list of cached DNS lookup results.
+ */
 static struct IPCache *head;
 
 
-
-
 #if HAVE_GETNAMEINFO
+/**
+ * Resolve the given request using getnameinfo
+ *
+ * @param cache the request to resolve (and where to store the result)
+ */
 static void
 getnameinfo_resolve (struct IPCache *cache)
 {
   char hostname[256];
 
-  if (0 == getnameinfo (cache->sa, 
-                       cache->salen, 
-                       hostname, 
-                       sizeof(hostname), 
-                       NULL, 0, 0))
+  if (0 == getnameinfo (cache->sa,
+                        cache->salen,
+                        hostname, sizeof (hostname), NULL, 0, 0))
     cache->addr = GNUNET_strdup (hostname);
 }
 #endif
 
 
 #if HAVE_GETHOSTBYADDR
+/**
+ * Resolve the given request using gethostbyaddr
+ *
+ * @param cache the request to resolve (and where to store the result)
+ */
 static void
 gethostbyaddr_resolve (struct IPCache *cache)
 {
@@ -92,7 +126,11 @@ gethostbyaddr_resolve (struct IPCache *cache)
 }
 #endif
 
-
+/**
+ * Resolve the given request using the available methods.
+ *
+ * @param cache the request to resolve (and where to store the result)
+ */
 static void
 cache_resolve (struct IPCache *cache)
 {
@@ -114,11 +152,13 @@ cache_resolve (struct IPCache *cache)
  * may not immediately result in the FQN (but instead in a
  * human-readable IP address).
  *
+ * @param client handle to the client making the request (for sending the reply)
  * @param sa should be of type "struct sockaddr*"
+ * @param salen number of bytes in sa
  */
 static void
 get_ip_as_string (struct GNUNET_SERVER_Client *client,
-                  const struct sockaddr *sav, socklen_t salen)
+                  const struct sockaddr *sa, socklen_t salen)
 {
   struct IPCache *cache;
   struct IPCache *prev;
@@ -128,15 +168,16 @@ get_ip_as_string (struct GNUNET_SERVER_Client *client,
   if (salen < sizeof (struct sockaddr))
     {
       GNUNET_break (0);
+      GNUNET_SERVER_receive_done (client, GNUNET_SYSERR);
       return;
     }
   now = GNUNET_TIME_absolute_get ();
   cache = head;
   prev = NULL;
   while ((cache != NULL) &&
-         ((cache->salen != salen) || (0 != memcmp (cache->sa, sav, salen))))
+         ((cache->salen != salen) || (0 != memcmp (cache->sa, sa, salen))))
     {
-      if (GNUNET_TIME_absolute_get_duration (cache->last_request).value <
+      if (GNUNET_TIME_absolute_get_duration (cache->last_request).rel_value <
           60 * 60 * 1000)
         {
           if (prev != NULL)
@@ -163,7 +204,7 @@ get_ip_as_string (struct GNUNET_SERVER_Client *client,
   if (cache != NULL)
     {
       cache->last_request = now;
-      if (GNUNET_TIME_absolute_get_duration (cache->last_request).value <
+      if (GNUNET_TIME_absolute_get_duration (cache->last_request).rel_value <
           60 * 60 * 1000)
         {
           GNUNET_free_non_null (cache->addr);
@@ -178,7 +219,7 @@ get_ip_as_string (struct GNUNET_SERVER_Client *client,
       cache->next = head;
       cache->salen = salen;
       cache->sa = GNUNET_malloc (salen);
-      memcpy (cache->sa, sav, salen);
+      memcpy (cache->sa, sa, salen);
       cache->last_request = GNUNET_TIME_absolute_get ();
       cache->last_refresh = GNUNET_TIME_absolute_get ();
       cache->addr = NULL;
@@ -187,12 +228,12 @@ get_ip_as_string (struct GNUNET_SERVER_Client *client,
     }
   tc = GNUNET_SERVER_transmit_context_create (client);
   if (cache->addr != NULL)
-    GNUNET_SERVER_transmit_context_append (tc,
-                                           cache->addr,
-                                           strlen (cache->addr) + 1,
-                                           GNUNET_MESSAGE_TYPE_RESOLVER_RESPONSE);
-  GNUNET_SERVER_transmit_context_append (tc, NULL, 0,
-                                         GNUNET_MESSAGE_TYPE_RESOLVER_RESPONSE);
+    GNUNET_SERVER_transmit_context_append_data (tc,
+                                               cache->addr,
+                                               strlen (cache->addr) + 1,
+                                               GNUNET_MESSAGE_TYPE_RESOLVER_RESPONSE);
+  GNUNET_SERVER_transmit_context_append_data (tc, NULL, 0,
+                                             GNUNET_MESSAGE_TYPE_RESOLVER_RESPONSE);
   GNUNET_SERVER_transmit_context_run (tc, GNUNET_TIME_UNIT_FOREVER_REL);
 }
 
@@ -229,8 +270,9 @@ getaddrinfo_resolve (struct GNUNET_SERVER_TransmitContext *tc,
           (s == EAI_SYSTEM)
 #else
           // FIXME NILS
+          1
 #endif
-      )
+        )
         return GNUNET_NO;       /* other function may still succeed */
       return GNUNET_SYSERR;
     }
@@ -239,10 +281,10 @@ getaddrinfo_resolve (struct GNUNET_SERVER_TransmitContext *tc,
   pos = result;
   while (pos != NULL)
     {
-      GNUNET_SERVER_transmit_context_append (tc,
-                                             result->ai_addr,
-                                             result->ai_addrlen,
-                                             GNUNET_MESSAGE_TYPE_RESOLVER_RESPONSE);
+      GNUNET_SERVER_transmit_context_append_data (tc,
+                                                 pos->ai_addr,
+                                                 pos->ai_addrlen,
+                                                 GNUNET_MESSAGE_TYPE_RESOLVER_RESPONSE);
       pos = pos->ai_next;
     }
   freeaddrinfo (result);
@@ -286,10 +328,10 @@ gethostbyname2_resolve (struct GNUNET_SERVER_TransmitContext *tc,
       memset (&a4, 0, sizeof (a4));
       a4.sin_family = AF_INET;
       memcpy (&a4.sin_addr, hp->h_addr_list[0], hp->h_length);
-      GNUNET_SERVER_transmit_context_append (tc,
-                                             &a4,
-                                             sizeof (a4),
-                                             GNUNET_MESSAGE_TYPE_RESOLVER_RESPONSE);
+      GNUNET_SERVER_transmit_context_append_data (tc,
+                                                 &a4,
+                                                 sizeof (a4),
+                                                 GNUNET_MESSAGE_TYPE_RESOLVER_RESPONSE);
     }
   else
     {
@@ -297,10 +339,10 @@ gethostbyname2_resolve (struct GNUNET_SERVER_TransmitContext *tc,
       memset (&a6, 0, sizeof (a6));
       a6.sin6_family = AF_INET6;
       memcpy (&a6.sin6_addr, hp->h_addr_list[0], hp->h_length);
-      GNUNET_SERVER_transmit_context_append (tc,
-                                             &a6,
-                                             sizeof (a6),
-                                             GNUNET_MESSAGE_TYPE_RESOLVER_RESPONSE);
+      GNUNET_SERVER_transmit_context_append_data (tc,
+                                                 &a6,
+                                                 sizeof (a6),
+                                                 GNUNET_MESSAGE_TYPE_RESOLVER_RESPONSE);
     }
   return GNUNET_OK;
 }
@@ -331,10 +373,10 @@ gethostbyname_resolve (struct GNUNET_SERVER_TransmitContext *tc,
   memset (&addr, 0, sizeof (addr));
   addr.sin_family = AF_INET;
   memcpy (&addr.sin_addr, hp->h_addr_list[0], hp->h_length);
-  GNUNET_SERVER_transmit_context_append (tc,
-                                         &addr,
-                                         sizeof (addr),
-                                         GNUNET_MESSAGE_TYPE_RESOLVER_RESPONSE);
+  GNUNET_SERVER_transmit_context_append_data (tc,
+                                             &addr,
+                                             sizeof (addr),
+                                             GNUNET_MESSAGE_TYPE_RESOLVER_RESPONSE);
   return GNUNET_OK;
 }
 #endif
@@ -368,8 +410,8 @@ get_ip_from_hostname (struct GNUNET_SERVER_Client *client,
   if ((ret == GNUNET_NO) && ((domain == AF_UNSPEC) || (domain == PF_INET)))
     gethostbyname_resolve (tc, hostname);
 #endif
-  GNUNET_SERVER_transmit_context_append (tc, NULL, 0,
-                                         GNUNET_MESSAGE_TYPE_RESOLVER_RESPONSE);
+  GNUNET_SERVER_transmit_context_append_data (tc, NULL, 0,
+                                             GNUNET_MESSAGE_TYPE_RESOLVER_RESPONSE);
   GNUNET_SERVER_transmit_context_run (tc, GNUNET_TIME_UNIT_FOREVER_REL);
 }
 
@@ -431,30 +473,22 @@ handle_get (void *cls,
 }
 
 
-/**
- * List of handlers for the messages understood by this
- * service.
- */
-static struct GNUNET_SERVER_MessageHandler handlers[] = {
-  {&handle_get, NULL, GNUNET_MESSAGE_TYPE_RESOLVER_REQUEST, 0},
-  {NULL, NULL, 0, 0}
-};
-
-
 /**
  * Process resolver requests.
  *
  * @param cls closure
- * @param sched scheduler to use
  * @param server the initialized server
  * @param cfg configuration to use
  */
 static void
 run (void *cls,
-     struct GNUNET_SCHEDULER_Handle *sched,
      struct GNUNET_SERVER_Handle *server,
      const struct GNUNET_CONFIGURATION_Handle *cfg)
 {
+  static const struct GNUNET_SERVER_MessageHandler handlers[] = {
+    {&handle_get, NULL, GNUNET_MESSAGE_TYPE_RESOLVER_REQUEST, 0},
+    {NULL, NULL, 0, 0}
+  };
   GNUNET_SERVER_add_handlers (server, handlers);
 }
 
@@ -475,7 +509,8 @@ main (int argc, char *const *argv)
   ret = (GNUNET_OK ==
          GNUNET_SERVICE_run (argc,
                              argv,
-                             "resolver", &run, NULL, NULL, NULL)) ? 0 : 1;
+                             "resolver", GNUNET_SERVICE_OPTION_NONE,
+                             &run, NULL)) ? 0 : 1;
 
   while (head != NULL)
     {