-LRN: fix socket_close logging
[oweals/gnunet.git] / src / util / client.c
index 032a6c5e4e3d449f0e3d7cbb511e813a2d66f738..e71ccdf3948ac44d87b18111a9fb2d5ac342c54f 100644 (file)
@@ -34,7 +34,7 @@
 #include "gnunet_server_lib.h"
 #include "gnunet_scheduler_lib.h"
 
-#define DEBUG_CLIENT GNUNET_NO
+#define DEBUG_CLIENT GNUNET_EXTRA_LOGGING
 
 /**
  * How often do we re-try tranmsitting requests before giving up?
@@ -43,6 +43,8 @@
  */
 #define MAX_ATTEMPTS 50
 
+#define LOG(kind,...) GNUNET_log_from (kind, "util",__VA_ARGS__)
+
 /**
  * Handle for a transmission request.
  */
@@ -103,7 +105,7 @@ struct GNUNET_CLIENT_TransmitHandle
 
 
 /**
- * Context for processing 
+ * Context for processing
  * "GNUNET_CLIENT_transmit_and_get_response" requests.
  */
 struct TransmitGetResponseContext
@@ -239,11 +241,6 @@ struct GNUNET_CLIENT_Connection
    */
   int in_receive;
 
-  /**
-   * Are we ignoring shutdown signals?
-   */
-  int ignore_shutdown;
-
   /**
    * How often have we tried to connect?
    */
@@ -281,8 +278,8 @@ do_connect (const char *service_name,
       if (sock != NULL)
       {
 #if DEBUG_CLIENT
-        GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Connected to unixpath `%s'!\n",
-                    unixpath);
+        LOG (GNUNET_ERROR_TYPE_DEBUG, "Connected to unixpath `%s'!\n",
+             unixpath);
 #endif
         GNUNET_free (unixpath);
         return sock;
@@ -293,28 +290,23 @@ do_connect (const char *service_name,
 #endif
 
   if ((GNUNET_OK !=
-       GNUNET_CONFIGURATION_get_value_number (cfg,
-                                              service_name,
-                                              "PORT",
-                                              &port)) ||
-      (port > 65535) ||
+       GNUNET_CONFIGURATION_get_value_number (cfg, service_name, "PORT", &port))
+      || (port > 65535) ||
       (GNUNET_OK !=
-       GNUNET_CONFIGURATION_get_value_string (cfg,
-                                              service_name,
-                                              "HOSTNAME", &hostname)))
+       GNUNET_CONFIGURATION_get_value_string (cfg, service_name, "HOSTNAME",
+                                              &hostname)))
   {
-    GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
-                _
-                ("Could not determine valid hostname and port for service `%s' from configuration.\n"),
-                service_name);
+    LOG (GNUNET_ERROR_TYPE_WARNING,
+         _
+         ("Could not determine valid hostname and port for service `%s' from configuration.\n"),
+         service_name);
     return NULL;
   }
   if (0 == strlen (hostname))
   {
     GNUNET_free (hostname);
-    GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
-                _("Need a non-empty hostname for service `%s'.\n"),
-                service_name);
+    LOG (GNUNET_ERROR_TYPE_WARNING,
+         _("Need a non-empty hostname for service `%s'.\n"), service_name);
     return NULL;
   }
   if (port == 0)
@@ -325,13 +317,12 @@ do_connect (const char *service_name,
       /* try UNIX */
       unixpath = NULL;
       if ((GNUNET_OK ==
-           GNUNET_CONFIGURATION_get_value_string (cfg,
-                                                  service_name,
-                                                  "UNIXPATH", &unixpath)) &&
+           GNUNET_CONFIGURATION_get_value_string (cfg, service_name, "UNIXPATH",
+                                                  &unixpath)) &&
           (0 < strlen (unixpath)))
       {
-        sock = GNUNET_CONNECTION_create_from_connect_to_unixpath (cfg,
-                                                                  unixpath);
+        sock =
+            GNUNET_CONNECTION_create_from_connect_to_unixpath (cfg, unixpath);
         if (sock != NULL)
         {
           GNUNET_free (unixpath);
@@ -343,9 +334,9 @@ do_connect (const char *service_name,
     }
 #endif
 #if DEBUG_CLIENT
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                "Port is 0 for service `%s', UNIXPATH did not work, returning NULL!\n",
-                service_name);
+    LOG (GNUNET_ERROR_TYPE_DEBUG,
+         "Port is 0 for service `%s', UNIXPATH did not work, returning NULL!\n",
+         service_name);
 #endif
     GNUNET_free (hostname);
     return NULL;
@@ -382,22 +373,6 @@ GNUNET_CLIENT_connect (const char *service_name,
 }
 
 
-/**
- * Configure this connection to ignore shutdown signals.
- *
- * @param h client handle
- * @param do_ignore GNUNET_YES to ignore, GNUNET_NO to restore default
- */
-void
-GNUNET_CLIENT_ignore_shutdown (struct GNUNET_CLIENT_Connection *h,
-                               int do_ignore)
-{
-  h->ignore_shutdown = do_ignore;
-  if (h->sock != NULL)
-    GNUNET_CONNECTION_ignore_shutdown (h->sock, do_ignore);
-}
-
-
 /**
  * Destroy connection with the service.  This will automatically
  * cancel any pending "receive" request (however, the handler will
@@ -476,9 +451,7 @@ check_complete (struct GNUNET_CLIENT_Connection *conn)
  * @param errCode value of errno (on errors receiving)
  */
 static void
-receive_helper (void *cls,
-                const void *buf,
-                size_t available,
+receive_helper (void *cls, const void *buf, size_t available,
                 const struct sockaddr *addr, socklen_t addrlen, int errCode)
 {
   struct GNUNET_CLIENT_Connection *conn = cls;
@@ -492,10 +465,10 @@ receive_helper (void *cls,
   {
     /* signal timeout! */
 #if DEBUG_CLIENT
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                "Timeout in receive_helper, available %u, conn->sock %s, errCode `%s'\n",
-                (unsigned int) available,
-                conn->sock == NULL ? "NULL" : "non-NULL", STRERROR (errCode));
+    LOG (GNUNET_ERROR_TYPE_DEBUG,
+         "Timeout in receive_helper, available %u, conn->sock %s, errCode `%s'\n",
+         (unsigned int) available, conn->sock == NULL ? "NULL" : "non-NULL",
+         STRERROR (errCode));
 #endif
     if (NULL != (receive_handler = conn->receiver_handler))
     {
@@ -512,8 +485,8 @@ receive_helper (void *cls,
 
   /* slow path: append to array */
   if (conn->received_size < conn->received_pos + available)
-    GNUNET_array_grow (conn->received_buf,
-                       conn->received_size, conn->received_pos + available);
+    GNUNET_array_grow (conn->received_buf, conn->received_size,
+                       conn->received_pos + available);
   memcpy (&conn->received_buf[conn->received_pos], buf, available);
   conn->received_pos += available;
   check_complete (conn);
@@ -527,8 +500,7 @@ receive_helper (void *cls,
     return;
   }
   /* back to receive -- either for more data or to call callback! */
-  GNUNET_CLIENT_receive (conn,
-                         conn->receiver_handler,
+  GNUNET_CLIENT_receive (conn, conn->receiver_handler,
                          conn->receiver_handler_cls, remaining);
 }
 
@@ -552,16 +524,15 @@ receive_task (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
   struct GNUNET_MessageHeader *msg = (struct GNUNET_MessageHeader *) mbuf;
 
 #if DEBUG_CLIENT
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Received message of type %u and size %u\n",
-              ntohs (cmsg->type), msize);
+  LOG (GNUNET_ERROR_TYPE_DEBUG, "Received message of type %u and size %u\n",
+       ntohs (cmsg->type), msize);
 #endif
   sock->receive_task = GNUNET_SCHEDULER_NO_TASK;
   GNUNET_assert (GNUNET_YES == sock->msg_complete);
   GNUNET_assert (sock->received_pos >= msize);
   memcpy (msg, cmsg, msize);
-  memmove (sock->received_buf,
-           &sock->received_buf[msize], sock->received_pos - msize);
+  memmove (sock->received_buf, &sock->received_buf[msize],
+           sock->received_pos - msize);
   sock->received_pos -= msize;
   sock->msg_complete = GNUNET_NO;
   sock->receiver_handler = NULL;
@@ -581,8 +552,8 @@ receive_task (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
  */
 void
 GNUNET_CLIENT_receive (struct GNUNET_CLIENT_Connection *sock,
-                       GNUNET_CLIENT_MessageHandler handler,
-                       void *handler_cls, struct GNUNET_TIME_Relative timeout)
+                       GNUNET_CLIENT_MessageHandler handler, void *handler_cls,
+                       struct GNUNET_TIME_Relative timeout)
 {
   if (sock->sock == NULL)
   {
@@ -605,10 +576,9 @@ GNUNET_CLIENT_receive (struct GNUNET_CLIENT_Connection *sock,
     GNUNET_assert (sock->in_receive == GNUNET_NO);
     sock->in_receive = GNUNET_YES;
 #if DEBUG_CLIENT
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "calling GNUNET_CONNECTION_receive\n");
+    LOG (GNUNET_ERROR_TYPE_DEBUG, "calling GNUNET_CONNECTION_receive\n");
 #endif
-    GNUNET_CONNECTION_receive (sock->sock,
-                               GNUNET_SERVER_MAX_MESSAGE_SIZE - 1,
+    GNUNET_CONNECTION_receive (sock->sock, GNUNET_SERVER_MAX_MESSAGE_SIZE - 1,
                                timeout, &receive_helper, sock);
   }
 }
@@ -620,8 +590,8 @@ GNUNET_CLIENT_receive (struct GNUNET_CLIENT_Connection *sock,
 static void
 service_test_error (GNUNET_SCHEDULER_Task task, void *task_cls)
 {
-  GNUNET_SCHEDULER_add_continuation (task,
-                                     task_cls, GNUNET_SCHEDULER_REASON_TIMEOUT);
+  GNUNET_SCHEDULER_add_continuation (task, task_cls,
+                                     GNUNET_SCHEDULER_REASON_TIMEOUT);
 }
 
 
@@ -642,11 +612,10 @@ confirm_handler (void *cls, const struct GNUNET_MessageHeader *msg)
   if (msg != NULL)
   {
 #if DEBUG_CLIENT
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                "Received confirmation that service is running.\n");
+    LOG (GNUNET_ERROR_TYPE_DEBUG,
+         "Received confirmation that service is running.\n");
 #endif
-    GNUNET_SCHEDULER_add_continuation (conn->test_cb,
-                                       conn->test_cb_cls,
+    GNUNET_SCHEDULER_add_continuation (conn->test_cb, conn->test_cb_cls,
                                        GNUNET_SCHEDULER_REASON_PREREQ_DONE);
   }
   else
@@ -675,22 +644,19 @@ write_test (void *cls, size_t size, void *buf)
   if (size < sizeof (struct GNUNET_MessageHeader))
   {
 #if DEBUG_CLIENT
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                _("Failure to transmit TEST request.\n"));
+    LOG (GNUNET_ERROR_TYPE_DEBUG, _("Failure to transmit TEST request.\n"));
 #endif
     service_test_error (conn->test_cb, conn->test_cb_cls);
     GNUNET_CLIENT_disconnect (conn, GNUNET_NO);
     return 0;                   /* client disconnected */
   }
 #if DEBUG_CLIENT
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Transmitting `%s' request.\n", "TEST");
+  LOG (GNUNET_ERROR_TYPE_DEBUG, "Transmitting `%s' request.\n", "TEST");
 #endif
   msg = (struct GNUNET_MessageHeader *) buf;
   msg->type = htons (GNUNET_MESSAGE_TYPE_TEST);
   msg->size = htons (sizeof (struct GNUNET_MessageHeader));
-  GNUNET_CLIENT_receive (conn,
-                         &confirm_handler,
-                         conn,
+  GNUNET_CLIENT_receive (conn, &confirm_handler, conn,
                          GNUNET_TIME_absolute_get_remaining
                          (conn->test_deadline));
   return sizeof (struct GNUNET_MessageHeader);
@@ -704,7 +670,7 @@ write_test (void *cls, size_t size, void *buf)
  *
  * @param service name of the service to wait for
  * @param cfg configuration to use
- * @param timeout how long to wait at most 
+ * @param timeout how long to wait at most
  * @param task task to run if service is running
  *        (reason will be "PREREQ_DONE" (service running)
  *         or "TIMEOUT" (service not known to be running))
@@ -722,8 +688,8 @@ GNUNET_CLIENT_service_test (const char *service,
   struct GNUNET_CLIENT_Connection *conn;
 
 #if DEBUG_CLIENT
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Testing if service `%s' is running.\n", service);
+  LOG (GNUNET_ERROR_TYPE_DEBUG, "Testing if service `%s' is running.\n",
+       service);
 #endif
 #ifdef AF_UNIX
   {
@@ -737,9 +703,9 @@ GNUNET_CLIENT_service_test (const char *service,
     {
       if (strlen (unixpath) >= sizeof (s_un.sun_path))
       {
-        GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
-                    _("UNIXPATH `%s' too long, maximum length is %llu\n"),
-                    unixpath, sizeof (s_un.sun_path));
+        LOG (GNUNET_ERROR_TYPE_WARNING,
+             _("UNIXPATH `%s' too long, maximum length is %llu\n"), unixpath,
+             sizeof (s_un.sun_path));
       }
       else
       {
@@ -761,15 +727,13 @@ GNUNET_CLIENT_service_test (const char *service,
           s_un.sun_len = (u_char) slen;
 #endif
           if (GNUNET_OK !=
-              GNUNET_NETWORK_socket_bind (sock,
-                                          (const struct sockaddr *) &s_un,
+              GNUNET_NETWORK_socket_bind (sock, (const struct sockaddr *) &s_un,
                                           slen))
           {
             /* failed to bind => service must be running */
             GNUNET_free (unixpath);
             (void) GNUNET_NETWORK_socket_close (sock);
-            GNUNET_SCHEDULER_add_continuation (task,
-                                               task_cls,
+            GNUNET_SCHEDULER_add_continuation (task, task_cls,
                                                GNUNET_SCHEDULER_REASON_PREREQ_DONE);
             return;
           }
@@ -784,14 +748,11 @@ GNUNET_CLIENT_service_test (const char *service,
 
   hostname = NULL;
   if ((GNUNET_OK !=
-       GNUNET_CONFIGURATION_get_value_number (cfg,
-                                              service,
-                                              "PORT",
-                                              &port)) ||
+       GNUNET_CONFIGURATION_get_value_number (cfg, service, "PORT", &port)) ||
       (port > 65535) ||
       (GNUNET_OK !=
-       GNUNET_CONFIGURATION_get_value_string (cfg,
-                                              service, "HOSTNAME", &hostname)))
+       GNUNET_CONFIGURATION_get_value_string (cfg, service, "HOSTNAME",
+                                              &hostname)))
   {
     /* UNIXPATH failed (if possible) AND IP failed => error */
     service_test_error (task, task_cls);
@@ -799,7 +760,7 @@ GNUNET_CLIENT_service_test (const char *service,
   }
 
   if (0 == strcmp ("localhost", hostname)
-#if WINDOWS
+#if !LINUX
       && 0
 #endif
       )
@@ -809,7 +770,7 @@ GNUNET_CLIENT_service_test (const char *service,
 
     memset (&s_in, 0, sizeof (s_in));
 #if HAVE_SOCKADDR_IN_SIN_LEN
-    s_in.sin_len = saddrlens[1];
+    s_in.sin_len = sizeof (struct sockaddr_in);
 #endif
     s_in.sin_family = AF_INET;
     s_in.sin_port = htons (port);
@@ -818,15 +779,13 @@ GNUNET_CLIENT_service_test (const char *service,
     if (sock != NULL)
     {
       if (GNUNET_OK !=
-          GNUNET_NETWORK_socket_bind (sock,
-                                      (const struct sockaddr *) &s_in,
+          GNUNET_NETWORK_socket_bind (sock, (const struct sockaddr *) &s_in,
                                       sizeof (s_in)))
       {
         /* failed to bind => service must be running */
         GNUNET_free (hostname);
         (void) GNUNET_NETWORK_socket_close (sock);
-        GNUNET_SCHEDULER_add_continuation (task,
-                                           task_cls,
+        GNUNET_SCHEDULER_add_continuation (task, task_cls,
                                            GNUNET_SCHEDULER_REASON_PREREQ_DONE);
         return;
       }
@@ -835,7 +794,7 @@ GNUNET_CLIENT_service_test (const char *service,
   }
 
   if (0 == strcmp ("ip6-localhost", hostname)
-#if WINDOWS
+#if !LINUX
       && 0
 #endif
       )
@@ -845,7 +804,7 @@ GNUNET_CLIENT_service_test (const char *service,
 
     memset (&s_in6, 0, sizeof (s_in6));
 #if HAVE_SOCKADDR_IN_SIN_LEN
-    s_in6.sin6_len = saddrlens[1];
+    s_in6.sin6_len = sizeof (struct sockaddr_in6);
 #endif
     s_in6.sin6_family = AF_INET6;
     s_in6.sin6_port = htons (port);
@@ -854,15 +813,13 @@ GNUNET_CLIENT_service_test (const char *service,
     if (sock != NULL)
     {
       if (GNUNET_OK !=
-          GNUNET_NETWORK_socket_bind (sock,
-                                      (const struct sockaddr *) &s_in6,
+          GNUNET_NETWORK_socket_bind (sock, (const struct sockaddr *) &s_in6,
                                       sizeof (s_in6)))
       {
         /* failed to bind => service must be running */
         GNUNET_free (hostname);
         (void) GNUNET_NETWORK_socket_close (sock);
-        GNUNET_SCHEDULER_add_continuation (task,
-                                           task_cls,
+        GNUNET_SCHEDULER_add_continuation (task, task_cls,
                                            GNUNET_SCHEDULER_REASON_PREREQ_DONE);
         return;
       }
@@ -872,7 +829,7 @@ GNUNET_CLIENT_service_test (const char *service,
 
   if (((0 == strcmp ("localhost", hostname)) ||
        (0 == strcmp ("ip6-localhost", hostname)))
-#if WINDOWS
+#if !LINUX
       && 0
 #endif
       )
@@ -888,10 +845,9 @@ GNUNET_CLIENT_service_test (const char *service,
   conn = GNUNET_CLIENT_connect (service, cfg);
   if (conn == NULL)
   {
-    GNUNET_log (GNUNET_ERROR_TYPE_INFO,
-                _
-                ("Could not connect to service `%s', must not be running.\n"),
-                service);
+    LOG (GNUNET_ERROR_TYPE_INFO,
+         _("Could not connect to service `%s', must not be running.\n"),
+         service);
     service_test_error (task, task_cls);
     return;
   }
@@ -899,14 +855,14 @@ GNUNET_CLIENT_service_test (const char *service,
   conn->test_cb_cls = task_cls;
   conn->test_deadline = GNUNET_TIME_relative_to_absolute (timeout);
 
-  if (NULL == GNUNET_CLIENT_notify_transmit_ready (conn,
-                                                   sizeof (struct
-                                                           GNUNET_MessageHeader),
-                                                   timeout, GNUNET_YES,
-                                                   &write_test, conn))
+  if (NULL ==
+      GNUNET_CLIENT_notify_transmit_ready (conn,
+                                           sizeof (struct GNUNET_MessageHeader),
+                                           timeout, GNUNET_YES, &write_test,
+                                           conn))
   {
-    GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
-                _("Failure to transmit request to service `%s'\n"), service);
+    LOG (GNUNET_ERROR_TYPE_WARNING,
+         _("Failure to transmit request to service `%s'\n"), service);
     service_test_error (task, task_cls);
     GNUNET_CLIENT_disconnect (conn, GNUNET_NO);
     return;
@@ -924,7 +880,8 @@ GNUNET_CLIENT_service_test (const char *service,
  * @param buf where to write them
  * @return number of bytes written to buf
  */
-static size_t client_notify (void *cls, size_t size, void *buf);
+static size_t
+client_notify (void *cls, size_t size, void *buf);
 
 
 /**
@@ -944,16 +901,15 @@ client_delayed_retry (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
   if (0 != (tc->reason & GNUNET_SCHEDULER_REASON_SHUTDOWN))
   {
 #if DEBUG_CLIENT
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                "Transmission failed due to shutdown.\n");
+    LOG (GNUNET_ERROR_TYPE_DEBUG, "Transmission failed due to shutdown.\n");
 #endif
     th->sock->th = NULL;
     th->notify (th->notify_cls, 0, NULL);
     GNUNET_free (th);
     return;
   }
-  th->sock->sock = do_connect (th->sock->service_name,
-                               th->sock->cfg, th->sock->attempts++);
+  th->sock->sock =
+      do_connect (th->sock->service_name, th->sock->cfg, th->sock->attempts++);
   if (NULL == th->sock->sock)
   {
     /* could happen if we're out of sockets */
@@ -965,22 +921,20 @@ client_delayed_retry (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
                                   (th->sock->back_off, 2),
                                   GNUNET_TIME_UNIT_SECONDS);
 #if DEBUG_CLIENT
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                "Transmission failed %u times, trying again in %llums.\n",
-                MAX_ATTEMPTS - th->attempts_left,
-                (unsigned long long) delay.rel_value);
+    LOG (GNUNET_ERROR_TYPE_DEBUG,
+         "Transmission failed %u times, trying again in %llums.\n",
+         MAX_ATTEMPTS - th->attempts_left,
+         (unsigned long long) delay.rel_value);
 #endif
-    th->reconnect_task = GNUNET_SCHEDULER_add_delayed (delay,
-                                                       &client_delayed_retry,
-                                                       th);
+    th->reconnect_task =
+        GNUNET_SCHEDULER_add_delayed (delay, &client_delayed_retry, th);
     return;
   }
-  GNUNET_CONNECTION_ignore_shutdown (th->sock->sock, th->sock->ignore_shutdown);
-  th->th = GNUNET_CONNECTION_notify_transmit_ready (th->sock->sock,
-                                                    th->size,
-                                                    GNUNET_TIME_absolute_get_remaining
-                                                    (th->timeout),
-                                                    &client_notify, th);
+  th->th =
+      GNUNET_CONNECTION_notify_transmit_ready (th->sock->sock, th->size,
+                                               GNUNET_TIME_absolute_get_remaining
+                                               (th->timeout), &client_notify,
+                                               th);
   if (th->th == NULL)
   {
     GNUNET_break (0);
@@ -1020,9 +974,9 @@ client_notify (void *cls, size_t size, void *buf)
         (delay.rel_value < 1))
     {
 #if DEBUG_CLIENT
-      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                  "Transmission failed %u times, giving up.\n",
-                  MAX_ATTEMPTS - th->attempts_left);
+      LOG (GNUNET_ERROR_TYPE_DEBUG,
+           "Transmission failed %u times, giving up.\n",
+           MAX_ATTEMPTS - th->attempts_left);
 #endif
       GNUNET_break (0 == th->notify (th->notify_cls, 0, NULL));
       GNUNET_free (th);
@@ -1030,28 +984,26 @@ client_notify (void *cls, size_t size, void *buf)
     }
     /* auto-retry */
 #if DEBUG_CLIENT
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                "Failed to connect to `%s', automatically trying again.\n",
-                th->sock->service_name);
+    LOG (GNUNET_ERROR_TYPE_DEBUG,
+         "Failed to connect to `%s', automatically trying again.\n",
+         th->sock->service_name);
 #endif
     GNUNET_CONNECTION_destroy (th->sock->sock, GNUNET_NO);
     th->sock->sock = NULL;
     delay = GNUNET_TIME_relative_min (delay, th->sock->back_off);
-    th->sock->back_off
-        =
+    th->sock->back_off =
         GNUNET_TIME_relative_min (GNUNET_TIME_relative_multiply
                                   (th->sock->back_off, 2),
                                   GNUNET_TIME_UNIT_SECONDS);
 #if DEBUG_CLIENT
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                "Transmission failed %u times, trying again in %llums.\n",
-                MAX_ATTEMPTS - th->attempts_left,
-                (unsigned long long) delay.rel_value);
+    LOG (GNUNET_ERROR_TYPE_DEBUG,
+         "Transmission failed %u times, trying again in %llums.\n",
+         MAX_ATTEMPTS - th->attempts_left,
+         (unsigned long long) delay.rel_value);
 #endif
     th->sock->th = th;
-    th->reconnect_task = GNUNET_SCHEDULER_add_delayed (delay,
-                                                       &client_delayed_retry,
-                                                       th);
+    th->reconnect_task =
+        GNUNET_SCHEDULER_add_delayed (delay, &client_delayed_retry, th);
     return 0;
   }
   GNUNET_assert (size >= th->size);
@@ -1108,17 +1060,16 @@ GNUNET_CLIENT_notify_transmit_ready (struct GNUNET_CLIENT_Connection *sock,
   sock->th = th;
   if (sock->sock == NULL)
   {
-    th->reconnect_task = GNUNET_SCHEDULER_add_delayed (sock->back_off,
-                                                       &client_delayed_retry,
-                                                       th);
+    th->reconnect_task =
+        GNUNET_SCHEDULER_add_delayed (sock->back_off, &client_delayed_retry,
+                                      th);
 
   }
   else
   {
-    th->th = GNUNET_CONNECTION_notify_transmit_ready (sock->sock,
-                                                      size,
-                                                      timeout,
-                                                      &client_notify, th);
+    th->th =
+        GNUNET_CONNECTION_notify_transmit_ready (sock->sock, size, timeout,
+                                                 &client_notify, th);
     if (NULL == th->th)
     {
       GNUNET_break (0);
@@ -1133,12 +1084,12 @@ GNUNET_CLIENT_notify_transmit_ready (struct GNUNET_CLIENT_Connection *sock,
 
 /**
  * Cancel a request for notification.
- * 
+ *
  * @param th handle from the original request.
  */
 void
-GNUNET_CLIENT_notify_transmit_ready_cancel (struct
-                                            GNUNET_CLIENT_TransmitHandle *th)
+GNUNET_CLIENT_notify_transmit_ready_cancel (struct GNUNET_CLIENT_TransmitHandle
+                                            *th)
 {
   if (th->reconnect_task != GNUNET_SCHEDULER_NO_TASK)
   {
@@ -1178,9 +1129,8 @@ transmit_for_response (void *cls, size_t size, void *buf)
   if (NULL == buf)
   {
 #if DEBUG_CLIENT
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                _
-                ("Could not submit request, not expecting to receive a response.\n"));
+    LOG (GNUNET_ERROR_TYPE_DEBUG,
+         _("Could not submit request, not expecting to receive a response.\n"));
 #endif
     if (NULL != tc->rn)
       tc->rn (tc->rn_cls, NULL);
@@ -1189,9 +1139,7 @@ transmit_for_response (void *cls, size_t size, void *buf)
   }
   GNUNET_assert (size >= msize);
   memcpy (buf, tc->hdr, msize);
-  GNUNET_CLIENT_receive (tc->sock,
-                         tc->rn,
-                         tc->rn_cls,
+  GNUNET_CLIENT_receive (tc->sock, tc->rn, tc->rn_cls,
                          GNUNET_TIME_absolute_get_remaining (tc->timeout));
   GNUNET_free (tc);
   return msize;
@@ -1215,15 +1163,13 @@ transmit_for_response (void *cls, size_t size, void *buf)
  *        if the caller does not care about temporary connection errors,
  *        for example because the protocol is stateless
  * @param rn function to call with the response
- * @param rn_cls closure for rn 
+ * @param rn_cls closure for rn
  * @return GNUNET_OK on success, GNUNET_SYSERR if a request
  *         is already pending
  */
 int
-GNUNET_CLIENT_transmit_and_get_response (struct GNUNET_CLIENT_Connection
-                                         *sock,
-                                         const struct GNUNET_MessageHeader
-                                         *hdr,
+GNUNET_CLIENT_transmit_and_get_response (struct GNUNET_CLIENT_Connection *sock,
+                                         const struct GNUNET_MessageHeader *hdr,
                                          struct GNUNET_TIME_Relative timeout,
                                          int auto_retry,
                                          GNUNET_CLIENT_MessageHandler rn,
@@ -1243,11 +1189,9 @@ GNUNET_CLIENT_transmit_and_get_response (struct GNUNET_CLIENT_Connection
   tc->timeout = GNUNET_TIME_relative_to_absolute (timeout);
   tc->rn = rn;
   tc->rn_cls = rn_cls;
-  if (NULL == GNUNET_CLIENT_notify_transmit_ready (sock,
-                                                   msize,
-                                                   timeout,
-                                                   auto_retry,
-                                                   &transmit_for_response, tc))
+  if (NULL ==
+      GNUNET_CLIENT_notify_transmit_ready (sock, msize, timeout, auto_retry,
+                                           &transmit_for_response, tc))
   {
     GNUNET_break (0);
     GNUNET_free (tc);