fixed coverity bug #10042
[oweals/gnunet.git] / src / transport / transport_api.c
index a392b65fb104dfb084073de3db3a7e1a9b946665..6fb35b5d6b1855b07bf770ac4b24d01e8a0f131d 100644 (file)
@@ -4,7 +4,7 @@
 
      GNUnet is free software; you can redistribute it and/or modify
      it under the terms of the GNU General Public License as published
-     by the Free Software Foundation; either version 2, or (at your
+     by the Free Software Foundation; either version 3, or (at your
      option) any later version.
 
      GNUnet is distributed in the hope that it will be useful, but
@@ -326,11 +326,6 @@ struct GNUNET_TRANSPORT_Handle
    */
   struct HelloWaitList *hwl_head;
 
-  /**
-   * My scheduler.
-   */
-  struct GNUNET_SCHEDULER_Handle *sched;
-
   /**
    * My configuration.
    */
@@ -341,6 +336,11 @@ struct GNUNET_TRANSPORT_Handle
    */
   struct NeighbourList *neighbours;
 
+  /**
+   * Peer identity as assumed by this process, or all zeros.
+   */
+  struct GNUNET_PeerIdentity self;
+
   /**
    * ID of the task trying to reconnect to the service.
    */
@@ -356,13 +356,18 @@ struct GNUNET_TRANSPORT_Handle
    * Delay until we try to reconnect.
    */
   struct GNUNET_TIME_Relative reconnect_delay;
-  
+
   /**
    * Set once we are in the process of disconnecting from the
    * service.
    */
   int in_disconnect;
 
+  /**
+   * Should we check that 'self' matches what the service thinks?
+   * (if GNUNET_NO, then 'self' is all zeros!).
+   */
+  int check_self;
 };
 
 
@@ -434,8 +439,7 @@ schedule_peer_transmission (struct GNUNET_TRANSPORT_Handle *h)
 
   if (h->quota_task != GNUNET_SCHEDULER_NO_TASK)
     {
-      GNUNET_SCHEDULER_cancel (h->sched,
-                              h->quota_task);
+      GNUNET_SCHEDULER_cancel (h->quota_task);
       h->quota_task = GNUNET_SCHEDULER_NO_TASK;
     }
   retry_time = GNUNET_TIME_UNIT_FOREVER_REL;
@@ -446,39 +450,43 @@ schedule_peer_transmission (struct GNUNET_TRANSPORT_Handle *h)
       next = n->next;
       if (n->transmit_stage != TS_QUEUED)
        continue; /* not eligible */
+      if (n->is_connected != GNUNET_YES)
+        continue;
+
       th = &n->transmit_handle;
       GNUNET_break (n == th->neighbour);
       /* check outgoing quota */
       duration = GNUNET_BANDWIDTH_tracker_get_delay (&n->out_tracker,
                                                     th->notify_size - sizeof (struct OutboundMessage));
-      if (th->timeout.value < duration.value)
+      struct GNUNET_TIME_Absolute duration_abs = GNUNET_TIME_relative_to_absolute (duration);
+      if (th->timeout.abs_value < duration_abs.abs_value)
        {
          /* signal timeout! */
 #if DEBUG_TRANSPORT
          GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                      "Would need %llu ms before bandwidth is available for delivery to `%4s', that is too long.  Signaling timeout.\n",
-                     duration.value, 
+                     duration.rel_value,
                      GNUNET_i2s (&n->id));
 #endif
          if (th->notify_delay_task != GNUNET_SCHEDULER_NO_TASK)
            {
-             GNUNET_SCHEDULER_cancel (h->sched, th->notify_delay_task);
+             GNUNET_SCHEDULER_cancel (th->notify_delay_task);
              th->notify_delay_task = GNUNET_SCHEDULER_NO_TASK;
-           }         
+           }   
          n->transmit_stage = TS_NEW;
          if (NULL != th->notify)
            GNUNET_assert (0 == th->notify (th->notify_cls, 0, NULL));
          continue;
        }
-      if (duration.value > 0)
+      if (duration.rel_value > 0)
        {
 #if DEBUG_TRANSPORT
          GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                      "Need more bandwidth (%u b/s allowed, %u b needed), delaying delivery to `%4s' by %llu ms\n",
                      (unsigned int) n->out_tracker.available_bytes_per_s__,
                      (unsigned int) th->notify_size - sizeof (struct OutboundMessage),
-                     GNUNET_i2s (&n->id), 
-                     duration.value);
+                     GNUNET_i2s (&n->id),
+                     duration.rel_value);
 #endif
          retry_time = GNUNET_TIME_relative_min (retry_time,
                                                 duration);
@@ -490,13 +498,13 @@ schedule_peer_transmission (struct GNUNET_TRANSPORT_Handle *h)
                  th->notify_size - sizeof (struct OutboundMessage),
                  GNUNET_i2s (&n->id));
 #endif 
+
       if ( (ret == NULL) ||
           (ret->priority < th->priority) )
        ret = th;
     }
   if (ret == NULL)
-    h->quota_task = GNUNET_SCHEDULER_add_delayed (h->sched,
-                                                 retry_time,
+    h->quota_task = GNUNET_SCHEDULER_add_delayed (retry_time,
                                                  &quota_transmit_ready,
                                                  h);
   return ret;
@@ -506,7 +514,7 @@ schedule_peer_transmission (struct GNUNET_TRANSPORT_Handle *h)
 /**
  * Transmit message(s) to service.
  *
- * @param cls handle to transport 
+ * @param cls handle to transport
  * @param size number of bytes available in buf
  * @param buf where to copy the message
  * @return number of bytes copied to buf
@@ -541,13 +549,19 @@ transport_notify_ready (void *cls, size_t size, void *buf)
     {
       if (cm->notify_delay_task != GNUNET_SCHEDULER_NO_TASK)
         {
-          GNUNET_SCHEDULER_cancel (h->sched, cm->notify_delay_task);
+          GNUNET_SCHEDULER_cancel (cm->notify_delay_task);
           cm->notify_delay_task = GNUNET_SCHEDULER_NO_TASK;
         }
       GNUNET_CONTAINER_DLL_remove (h->control_head,
                                   h->control_tail,
                                   cm);
       nret = cm->notify (cm->notify_cls, size, &cbuf[ret]);
+#if DEBUG_TRANSPORT
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                 "Added %u bytes of control message at %u\n",
+                 nret,
+                 ret);
+#endif
       GNUNET_free (cm);
       ret += nret;
       size -= nret;
@@ -557,7 +571,7 @@ transport_notify_ready (void *cls, size_t size, void *buf)
     {
       if (th->notify_delay_task != GNUNET_SCHEDULER_NO_TASK)
         {
-          GNUNET_SCHEDULER_cancel (h->sched, th->notify_delay_task);
+          GNUNET_SCHEDULER_cancel (th->notify_delay_task);
           th->notify_delay_task = GNUNET_SCHEDULER_NO_TASK;
         }
       n = th->neighbour;
@@ -579,19 +593,20 @@ transport_notify_ready (void *cls, size_t size, void *buf)
          GNUNET_break (0);
        }
       GNUNET_assert (size >= sizeof (struct OutboundMessage));
-      mret = th->notify (th->notify_cls, 
+      mret = th->notify (th->notify_cls,
                         size - sizeof (struct OutboundMessage),
                         &cbuf[ret + sizeof (struct OutboundMessage)]);
       GNUNET_assert (mret <= size - sizeof (struct OutboundMessage));
 #if DEBUG_TRANSPORT
       GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                  "Message of %u bytes with timeout %llums constructed for `%4s'\n",
-                 (unsigned int) mret, 
-                 (unsigned long long) GNUNET_TIME_absolute_get_remaining (th->timeout).value,
+                 (unsigned int) mret,
+                 (unsigned long long) GNUNET_TIME_absolute_get_remaining (th->timeout).rel_value,
                  GNUNET_i2s (&n->id));
 #endif
       if (mret != 0)   
        {
+         GNUNET_assert (mret + sizeof (struct OutboundMessage) < GNUNET_SERVER_MAX_MESSAGE_SIZE);
          obm.header.type = htons (GNUNET_MESSAGE_TYPE_TRANSPORT_SEND);
          obm.header.size = htons (mret + sizeof (struct OutboundMessage));
          obm.priority = htonl (th->priority);
@@ -638,7 +653,7 @@ transport_notify_ready (void *cls, size_t size, void *buf)
  */
 static void
 schedule_transmission (struct GNUNET_TRANSPORT_Handle *h)
-{  
+{
   size_t size;
   struct GNUNET_TIME_Relative timeout;
   struct GNUNET_TRANSPORT_TransmitHandle *th;
@@ -647,11 +662,11 @@ schedule_transmission (struct GNUNET_TRANSPORT_Handle *h)
     return;
   if (h->client == NULL)
     {
-      GNUNET_log (GNUNET_ERROR_TYPE_INFO,
-                  "Could not yet schedule transmission: we are not yet connected to the transport service!\n");
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                  _("Could not yet schedule transmission: we are not yet connected to the transport service!\n"));
       return;                   /* not yet connected */
     }
-  if (NULL != h->control_head) 
+  if (NULL != h->control_head)
     {
       size = h->control_head->notify_size;
       timeout = GNUNET_TIME_UNIT_FOREVER_REL;
@@ -662,12 +677,20 @@ schedule_transmission (struct GNUNET_TRANSPORT_Handle *h)
       if (th == NULL)
        {
          /* no transmission ready right now */
+#if DEBUG_TRANSPORT
+         GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                     "Could not yet schedule transmission: none ready\n");
+#endif
          return;
        }
       size = th->notify_size;
       timeout = GNUNET_TIME_absolute_get_remaining (th->timeout);
     }
-  h->network_handle = 
+#if DEBUG_TRANSPORT
+    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                "Calling notify_transmit_ready\n");
+#endif
+  h->network_handle =
     GNUNET_CLIENT_notify_transmit_ready (h->client,
                                         size,
                                         timeout,
@@ -725,7 +748,7 @@ schedule_control_transmit (struct GNUNET_TRANSPORT_Handle *h,
 #if DEBUG_TRANSPORT
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
               "Control transmit of %u bytes within %llums requested\n",
-              size, (unsigned long long) timeout.value);
+              size, (unsigned long long) timeout.rel_value);
 #endif
   th = GNUNET_malloc (sizeof (struct ControlMessage));
   th->h = h;
@@ -733,9 +756,8 @@ schedule_control_transmit (struct GNUNET_TRANSPORT_Handle *h,
   th->notify_cls = notify_cls;
   th->notify_size = size;
   th->notify_delay_task
-    = GNUNET_SCHEDULER_add_delayed (h->sched,
-                                    timeout, &control_transmit_timeout, th);
-  if (at_head)    
+    = GNUNET_SCHEDULER_add_delayed (timeout, &control_transmit_timeout, th);
+  if (at_head)
     GNUNET_CONTAINER_DLL_insert (h->control_head,
                                 h->control_tail,
                                 th);
@@ -780,8 +802,7 @@ send_set_quota (void *cls, size_t size, void *buf)
 
   if (buf == NULL)
     {
-      GNUNET_SCHEDULER_add_continuation (sqc->handle->sched,
-                                         sqc->cont,
+      GNUNET_SCHEDULER_add_continuation (sqc->cont,
                                          sqc->cont_cls,
                                          GNUNET_SCHEDULER_REASON_TIMEOUT);
       GNUNET_free (sqc);
@@ -790,7 +811,7 @@ send_set_quota (void *cls, size_t size, void *buf)
 #if DEBUG_TRANSPORT
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
               "Transmitting `%s' request with respect to `%4s'.\n",
-              "SET_QUOTA", 
+              "SET_QUOTA",
              GNUNET_i2s (&sqc->target));
 #endif
   GNUNET_assert (size >= sizeof (struct QuotaSetMessage));
@@ -800,8 +821,7 @@ send_set_quota (void *cls, size_t size, void *buf)
   msg->quota = sqc->quota_in;
   memcpy (&msg->peer, &sqc->target, sizeof (struct GNUNET_PeerIdentity));
   if (sqc->cont != NULL)
-    GNUNET_SCHEDULER_add_continuation (sqc->handle->sched,
-                                       sqc->cont,
+    GNUNET_SCHEDULER_add_continuation (sqc->cont,
                                        sqc->cont_cls,
                                        GNUNET_SCHEDULER_REASON_PREREQ_DONE);
   GNUNET_free (sqc);
@@ -899,7 +919,7 @@ GNUNET_TRANSPORT_get_hello (struct GNUNET_TRANSPORT_Handle *handle,
   hwl->rec = rec;
   hwl->rec_cls = rec_cls;
   if (handle->my_hello == NULL)
-    return;    
+    return;
   rec (rec_cls, (const struct GNUNET_MessageHeader *) handle->my_hello);
 }
 
@@ -958,7 +978,7 @@ send_hello (void *cls, size_t size, void *buf)
   if (buf == NULL)
     {
 #if DEBUG_TRANSPORT_TIMEOUT
-      GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                   "Timeout while trying to transmit `%s' request.\n",
                   "HELLO");
 #endif
@@ -1002,7 +1022,7 @@ GNUNET_TRANSPORT_offer_hello (struct GNUNET_TRANSPORT_Handle *handle,
       GNUNET_break (0);
       return;
     }
-#if DEBUG_TRANSPORT 
+#if DEBUG_TRANSPORT
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
              "Offering `%s' message of `%4s' to transport for validation.\n",
              "HELLO",
@@ -1027,7 +1047,8 @@ GNUNET_TRANSPORT_offer_hello (struct GNUNET_TRANSPORT_Handle *handle,
 static size_t
 send_start (void *cls, size_t size, void *buf)
 {
-  struct GNUNET_MessageHeader *s = buf;
+  struct GNUNET_TRANSPORT_Handle *h = cls;
+  struct StartMessage s;
 
   if (buf == NULL)
     {
@@ -1043,16 +1064,19 @@ send_start (void *cls, size_t size, void *buf)
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
               "Transmitting `%s' request.\n", "START");
 #endif
-  GNUNET_assert (size >= sizeof (struct GNUNET_MessageHeader));
-  s->size = htons (sizeof (struct GNUNET_MessageHeader));
-  s->type = htons (GNUNET_MESSAGE_TYPE_TRANSPORT_START);
-  return sizeof (struct GNUNET_MessageHeader);
+  GNUNET_assert (size >= sizeof (struct StartMessage));
+  s.header.size = htons (sizeof (struct StartMessage));
+  s.header.type = htons (GNUNET_MESSAGE_TYPE_TRANSPORT_START);
+  s.do_check = htonl (h->check_self);
+  s.self = h->self;
+  memcpy (buf, &s, sizeof (struct StartMessage));
+  return sizeof (struct StartMessage);
 }
 
 
 /**
- * Free neighbour. 
- * 
+ * Free neighbour.
+ *
  * @param n the entry to free
  */
 static void
@@ -1087,8 +1111,8 @@ neighbour_free (struct NeighbourList *n)
 
 
 /**
- * Mark neighbour as disconnected. 
- * 
+ * Mark neighbour as disconnected.
+ *
  * @param n the entry to mark as disconnected
  */
 static void
@@ -1102,7 +1126,7 @@ neighbour_disconnect (struct NeighbourList *n)
 #endif
   GNUNET_break (n->is_connected == GNUNET_YES);
   n->is_connected = GNUNET_NO;
-  if (h->nc_cb != NULL)
+  if (h->nd_cb != NULL)
     h->nd_cb (h->cls, &n->id);
   if (n->transmit_stage == TS_NEW)
     neighbour_free (n);
@@ -1126,7 +1150,7 @@ static void demultiplexer (void *cls,
  * @param tc scheduler context
  */
 static void
-reconnect (void *cls, 
+reconnect (void *cls,
           const struct GNUNET_SCHEDULER_TaskContext *tc)
 {
   struct GNUNET_TRANSPORT_Handle *h = cls;
@@ -1154,11 +1178,11 @@ reconnect (void *cls,
       n = next;
     }
 #if DEBUG_TRANSPORT
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, 
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
              "Connecting to transport service.\n");
 #endif
   GNUNET_assert (h->client == NULL);
-  h->client = GNUNET_CLIENT_connect (h->sched, "transport", h->cfg);
+  h->client = GNUNET_CLIENT_connect ("transport", h->cfg);
   GNUNET_assert (h->client != NULL);
   /* make sure we don't send "START" twice, remove existing entry from
      queue (if present) */
@@ -1172,7 +1196,7 @@ reconnect (void *cls,
                                       pos);
           if (GNUNET_SCHEDULER_NO_TASK != pos->notify_delay_task)
             {
-              GNUNET_SCHEDULER_cancel (h->sched, pos->notify_delay_task);
+              GNUNET_SCHEDULER_cancel (pos->notify_delay_task);
               pos->notify_delay_task = GNUNET_SCHEDULER_NO_TASK;
             }
           GNUNET_free (pos);
@@ -1181,9 +1205,9 @@ reconnect (void *cls,
       pos = pos->next;
     }
   schedule_control_transmit (h,
-                             sizeof (struct GNUNET_MessageHeader),
+                             sizeof (struct StartMessage),
                              GNUNET_YES,
-                             GNUNET_TIME_UNIT_FOREVER_REL, &send_start, NULL);
+                             GNUNET_TIME_UNIT_FOREVER_REL, &send_start, h);
   GNUNET_CLIENT_receive (h->client,
                          &demultiplexer, h, GNUNET_TIME_UNIT_FOREVER_REL);
 }
@@ -1201,18 +1225,17 @@ schedule_reconnect (struct GNUNET_TRANSPORT_Handle *h)
 #if DEBUG_TRANSPORT
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
               "Scheduling task to reconnect to transport service in %llu ms.\n",
-              h->reconnect_delay.value);
+              h->reconnect_delay.rel_value);
 #endif
   GNUNET_assert (h->client == NULL);
   GNUNET_assert (h->reconnect_task == GNUNET_SCHEDULER_NO_TASK);
   h->reconnect_task
-    = GNUNET_SCHEDULER_add_delayed (h->sched,
-                                    h->reconnect_delay, &reconnect, h);
-  if (h->reconnect_delay.value == 0)
+    = GNUNET_SCHEDULER_add_delayed (h->reconnect_delay, &reconnect, h);
+  if (h->reconnect_delay.rel_value == 0)
     {
       h->reconnect_delay = GNUNET_TIME_UNIT_MILLISECONDS;
     }
-  else 
+  else
     {
       h->reconnect_delay = GNUNET_TIME_relative_multiply (h->reconnect_delay, 2);
       h->reconnect_delay = GNUNET_TIME_relative_min (GNUNET_TIME_UNIT_SECONDS,
@@ -1221,6 +1244,62 @@ schedule_reconnect (struct GNUNET_TRANSPORT_Handle *h)
 }
 
 
+/**
+ * Send request connect message to the service.
+ *
+ * @param cls the TransportRequestConnectMessage
+ * @param size number of bytes available in buf
+ * @param buf where to copy the message
+ * @return number of bytes copied to buf
+ */
+static size_t
+send_transport_request_connect (void *cls, size_t size, void *buf)
+{
+  struct TransportRequestConnectMessage *trcm = cls;
+
+  if (buf == NULL)
+    {
+#if DEBUG_TRANSPORT
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                  "Buffer null for %s\n",
+                  "REQUEST_CONNECT");
+#endif
+      GNUNET_free (trcm);
+      return 0;
+    }
+#if DEBUG_TRANSPORT
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+              "Transmitting `%s' request for `%4s'.\n",
+              "REQUEST_CONNECT",
+              GNUNET_i2s (&trcm->peer));
+#endif
+  GNUNET_assert (size >= sizeof (struct TransportRequestConnectMessage));
+  memcpy(buf, trcm, sizeof(struct TransportRequestConnectMessage));
+  return sizeof(struct TransportRequestConnectMessage);
+}
+
+/**
+ * Create and send a request connect message to
+ * the transport service for a particular peer.
+ *
+ * @param h handle to the transport service
+ * @param n the neighbor to send the request connect message about
+ *
+ */
+static void send_request_connect_message(struct GNUNET_TRANSPORT_Handle *h, struct NeighbourList *n)
+{
+  struct TransportRequestConnectMessage *trcm;
+
+  trcm = GNUNET_malloc(sizeof(struct TransportRequestConnectMessage));
+  trcm->header.type = htons(GNUNET_MESSAGE_TYPE_TRANSPORT_REQUEST_CONNECT);
+  trcm->header.size = htons(sizeof(struct TransportRequestConnectMessage));
+  memcpy(&trcm->peer, &n->id, sizeof(struct GNUNET_PeerIdentity));
+  schedule_control_transmit (h,
+                             sizeof (struct TransportRequestConnectMessage),
+                             GNUNET_NO,
+                             GNUNET_TIME_UNIT_FOREVER_REL, &send_transport_request_connect, trcm);
+}
+
 /**
  * Add neighbour to our list
  *
@@ -1242,7 +1321,7 @@ neighbour_add (struct GNUNET_TRANSPORT_Handle *h,
     }
 #if DEBUG_TRANSPORT
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Creating entry for neighbour `%4s'.\n", 
+              "Creating entry for neighbour `%4s'.\n",
              GNUNET_i2s (pid));
 #endif
   n = GNUNET_malloc (sizeof (struct NeighbourList));
@@ -1252,7 +1331,9 @@ neighbour_add (struct GNUNET_TRANSPORT_Handle *h,
                                 MAX_BANDWIDTH_CARRY_S);
   n->next = h->neighbours;
   n->h = h;
-  h->neighbours = n;  
+  h->neighbours = n;
+
+
   return n;
 }
 
@@ -1261,16 +1342,17 @@ neighbour_add (struct GNUNET_TRANSPORT_Handle *h,
  * Connect to the transport service.  Note that the connection may
  * complete (or fail) asynchronously.
  *
- * @param sched scheduler to use
  * @param cfg configuration to use
+ * @param self our own identity (API should check that it matches
+ *             the identity found by transport), or NULL (no check)
  * @param cls closure for the callbacks
  * @param rec receive function to call
  * @param nc function to call on connect events
  * @param nd function to call on disconnect events
  */
 struct GNUNET_TRANSPORT_Handle *
-GNUNET_TRANSPORT_connect (struct GNUNET_SCHEDULER_Handle *sched,
-                          const struct GNUNET_CONFIGURATION_Handle *cfg,
+GNUNET_TRANSPORT_connect (const struct GNUNET_CONFIGURATION_Handle *cfg,
+                         const struct GNUNET_PeerIdentity *self,
                           void *cls,
                           GNUNET_TRANSPORT_ReceiveCallback rec,
                           GNUNET_TRANSPORT_NotifyConnect nc,
@@ -1278,9 +1360,12 @@ GNUNET_TRANSPORT_connect (struct GNUNET_SCHEDULER_Handle *sched,
 {
   struct GNUNET_TRANSPORT_Handle *ret;
 
-  GNUNET_ARM_start_services (cfg, sched, "peerinfo", "transport", NULL);
   ret = GNUNET_malloc (sizeof (struct GNUNET_TRANSPORT_Handle));
-  ret->sched = sched;
+  if (self != NULL)
+    {
+      ret->self = *self;
+      ret->check_self = GNUNET_YES;
+    }
   ret->cfg = cfg;
   ret->cls = cls;
   ret->rec = rec;
@@ -1322,11 +1407,10 @@ GNUNET_TRANSPORT_disconnect (struct GNUNET_TRANSPORT_Handle *handle)
          th = &n->transmit_handle;
          if (th->notify_delay_task != GNUNET_SCHEDULER_NO_TASK)
            {
-             GNUNET_SCHEDULER_cancel (handle->sched,
-                                      th->notify_delay_task);
+             GNUNET_SCHEDULER_cancel (th->notify_delay_task);
              th->notify_delay_task = GNUNET_SCHEDULER_NO_TASK;
            }
-         GNUNET_assert (0 == th->notify (th->notify_cls, 0, NULL));        
+         GNUNET_assert (0 == th->notify (th->notify_cls, 0, NULL));
          break;
        default:
          GNUNET_break (0);
@@ -1349,11 +1433,13 @@ GNUNET_TRANSPORT_disconnect (struct GNUNET_TRANSPORT_Handle *handle)
   /* Added because somehow a notify_delay_task is remaining scheduled and is ever so annoying */
   while ( (NULL != (cm = handle->control_head)))
     {
-      GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
-                  _("Disconnect before control message sent!\n"));
+#if DEBUG_TRANSPORT
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                  "Disconnect before control message sent!\n");
+#endif
       if (cm->notify_delay_task != GNUNET_SCHEDULER_NO_TASK)
         {
-          GNUNET_SCHEDULER_cancel (handle->sched, cm->notify_delay_task);
+          GNUNET_SCHEDULER_cancel (cm->notify_delay_task);
           cm->notify_delay_task = GNUNET_SCHEDULER_NO_TASK;
         }
       GNUNET_CONTAINER_DLL_remove (handle->control_head,
@@ -1365,12 +1451,12 @@ GNUNET_TRANSPORT_disconnect (struct GNUNET_TRANSPORT_Handle *handle)
 
   if (handle->reconnect_task != GNUNET_SCHEDULER_NO_TASK)
     {
-      GNUNET_SCHEDULER_cancel (handle->sched, handle->reconnect_task);
+      GNUNET_SCHEDULER_cancel (handle->reconnect_task);
       handle->reconnect_task = GNUNET_SCHEDULER_NO_TASK;
     }
   if (handle->quota_task != GNUNET_SCHEDULER_NO_TASK)
     {
-      GNUNET_SCHEDULER_cancel (handle->sched, handle->quota_task);
+      GNUNET_SCHEDULER_cancel (handle->quota_task);
       handle->quota_task = GNUNET_SCHEDULER_NO_TASK;
     }
   GNUNET_free_non_null (handle->my_hello);
@@ -1422,7 +1508,7 @@ demultiplexer (void *cls, const struct GNUNET_MessageHeader *msg)
       GNUNET_free (h);
       return;
     }
-  if (msg == NULL) 
+  if (msg == NULL)
     {
 #if DEBUG_TRANSPORT
       GNUNET_log (GNUNET_ERROR_TYPE_INFO,
@@ -1496,7 +1582,7 @@ demultiplexer (void *cls, const struct GNUNET_MessageHeader *msg)
       n->is_connected = GNUNET_YES;
       if (h->nc_cb != NULL)
        h->nc_cb (h->cls, &n->id,
-                 GNUNET_TIME_relative_ntoh (cim->latency), 
+                 GNUNET_TIME_relative_ntoh (cim->latency),
                  ntohl (cim->distance));
       break;
     case GNUNET_MESSAGE_TYPE_TRANSPORT_DISCONNECT:
@@ -1506,6 +1592,7 @@ demultiplexer (void *cls, const struct GNUNET_MessageHeader *msg)
           break;
         }
       dim = (const struct DisconnectInfoMessage *) msg;
+      GNUNET_break (ntohl (dim->reserved) == 0);
 #if DEBUG_TRANSPORT_DISCONNECT
       GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                   "Receiving `%s' message for `%4s'.\n",
@@ -1513,7 +1600,7 @@ demultiplexer (void *cls, const struct GNUNET_MessageHeader *msg)
                  GNUNET_i2s (&dim->peer));
 #endif
       n = neighbour_find (h, &dim->peer);
-      GNUNET_break (n != NULL);      
+      GNUNET_break (n != NULL);
       if (n != NULL)
        neighbour_disconnect (n);       
       break;
@@ -1563,6 +1650,7 @@ demultiplexer (void *cls, const struct GNUNET_MessageHeader *msg)
           break;
         }
       im = (const struct InboundMessage *) msg;
+      GNUNET_break (0 == ntohl (im->reserved));
       imm = (const struct GNUNET_MessageHeader *) &im[1];
       if (ntohs (imm->size) + sizeof (struct InboundMessage) != size)
         {
@@ -1573,7 +1661,7 @@ demultiplexer (void *cls, const struct GNUNET_MessageHeader *msg)
       GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                  "Received message of type %u from `%4s'.\n",
                  ntohs (imm->type), GNUNET_i2s (&im->peer));
-#endif      
+#endif
       n = neighbour_find (h, &im->peer);
       if (n == NULL)
        {
@@ -1621,11 +1709,11 @@ peer_transmit_timeout (void *cls,
   th->notify_delay_task = GNUNET_SCHEDULER_NO_TASK;
   n = th->neighbour;
 #if DEBUG_TRANSPORT
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+  GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
              "Triggering timeout for request to transmit to `%4s' (%d)\n",
              GNUNET_i2s (&n->id),
              n->transmit_stage);
-#endif  
+#endif
   notify = th->notify;
   notify_cls = th->notify_cls;
   switch (n->transmit_stage)
@@ -1690,7 +1778,7 @@ GNUNET_TRANSPORT_notify_transmit_ready (struct GNUNET_TRANSPORT_Handle
 #if DEBUG_TRANSPORT
       GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                   "Message size is %d, max allowed is %d.\n",
-                  size + sizeof (struct OutboundMessage), GNUNET_SERVER_MAX_MESSAGE_SIZE);
+                  size + sizeof (struct OutboundMessage), GNUNET_SERVER_MAX_MESSAGE_SIZE - 1);
 #endif
       GNUNET_break (0);
       return NULL;
@@ -1699,13 +1787,35 @@ GNUNET_TRANSPORT_notify_transmit_ready (struct GNUNET_TRANSPORT_Handle
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
               "Asking transport service for transmission of %u bytes to peer `%4s' within %llu ms.\n",
               size, GNUNET_i2s (target),
-             (unsigned long long) timeout.value);
+             (unsigned long long) timeout.rel_value);
 #endif
   n = neighbour_find (handle, target);
   if (n == NULL)
-    n = neighbour_add (handle, target);
-  if (n == NULL) 
-    return NULL;
+    {
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                  "Created neighbour entry for peer `%s'\n",
+                  GNUNET_i2s (target));
+      n = neighbour_add (handle, target);
+
+    }
+  if (n == NULL)
+    {
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                 "Could not create neighbour entry for peer `%s'\n",
+                 GNUNET_i2s (target));
+      return NULL;
+    }
+
+  /**
+   *  Send a request connect message if not connected,
+   *  otherwise we will never send anything to
+   *  transport service
+   */
+  if (n->is_connected == GNUNET_NO)
+    {
+      send_request_connect_message(handle, n);
+    }
+
   switch (n->transmit_stage)
     {
     case TS_NEW:
@@ -1732,8 +1842,8 @@ GNUNET_TRANSPORT_notify_transmit_ready (struct GNUNET_TRANSPORT_Handle
   th->notify_size = size + sizeof (struct OutboundMessage);
   th->priority = priority;
   th->notify_delay_task
-    = GNUNET_SCHEDULER_add_delayed (handle->sched, timeout,
-                                   &peer_transmit_timeout, th);
+    = GNUNET_SCHEDULER_add_delayed (timeout,
+                                    &peer_transmit_timeout, th);
   schedule_transmission (handle);
   return th;
 }
@@ -1775,6 +1885,11 @@ GNUNET_TRANSPORT_notify_transmit_ready_cancel (struct
     default:
       GNUNET_break (0);
     }
+  if (th->notify_delay_task != GNUNET_SCHEDULER_NO_TASK)
+    {
+      GNUNET_SCHEDULER_cancel (th->notify_delay_task);
+      th->notify_delay_task = GNUNET_SCHEDULER_NO_TASK;
+    }
 }