stuff
[oweals/gnunet.git] / src / transport / test_plugin_transport_http.c
index 855dc535054edd9bd0809e4fff8f23b6df201eae..5ba8c573a37e24735ef2fb431074c93f92726da6 100644 (file)
 #include "gnunet_service_lib.h"
 #include "gnunet_crypto_lib.h"
 
-#include "plugin_transport.h"
+#include "gnunet_transport_plugin.h"
 #include "gnunet_statistics_service.h"
 #include "transport.h"
 #include <curl/curl.h>
-#include <netinet/in.h>
-#include <arpa/inet.h>
 
 #define VERBOSE GNUNET_NO
 #define DEBUG_CURL GNUNET_NO
@@ -55,7 +53,7 @@
 /**
  * How long until we give up on transmitting the message?
  */
-#define TIMEOUT GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_SECONDS, 90)
+#define TIMEOUT GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_SECONDS, 60)
 
 /**
  * Testcase timeout
@@ -164,6 +162,10 @@ struct HTTP_Transfer
  */
 struct IPv4HttpAddress
 {
+  struct IPv4HttpAddress * next;
+
+  struct IPv4HttpAddress * prev;
+
   /**
    * IPv4 address, in network byte order.
    */
@@ -182,6 +184,10 @@ struct IPv4HttpAddress
  */
 struct IPv6HttpAddress
 {
+  struct IPv6HttpAddress * next;
+
+  struct IPv6HttpAddress * prev;
+
   /**
    * IPv6 address.
    */
@@ -194,6 +200,7 @@ struct IPv6HttpAddress
 
 };
 
+
 /**
  * Our public key.
  */
@@ -224,11 +231,6 @@ static long long unsigned int port;
  */
 static char * test_addr;
 
-/**
- * Our scheduler.
- */
-struct GNUNET_SCHEDULER_Handle *sched;
-
 /**
  * Our statistics handle.
  */
@@ -384,42 +386,58 @@ static CURLM *multi_handle;
  */
 static GNUNET_SCHEDULER_TaskIdentifier http_task_send;
 
+static char * servicehome;
+
 /**
  * Shutdown testcase
  */
 static void
 shutdown_clean ()
 {
-  struct Plugin_Address * cur;
   struct Plugin_Address * tmp;
 
   /* Evaluate results  */
   fail = 0;
-  if ((fail_notify_address == GNUNET_YES) || (fail_pretty_printer == GNUNET_YES) || (fail_addr_to_str == GNUNET_YES))
-  {
-    GNUNET_log (GNUNET_ERROR_TYPE_ERROR, "Phase 0: Test plugin functions failed\n");
-    fail = 1;
-  }
-  if ((test_no_ident.test_failed == GNUNET_YES) || (test_too_short_ident.test_failed == GNUNET_YES) || (test_too_long_ident.test_failed == GNUNET_YES) || (test_valid_ident.test_failed == GNUNET_YES))
-  {
-    GNUNET_log (GNUNET_ERROR_TYPE_ERROR, "Phase 1: Test connect with wrong data failed\n");
-    fail = 1;
-  }
-  if ((fail_session_selection_any != GNUNET_NO) || (fail_session_selection_reliable != GNUNET_NO) || (fail_session_selection_session != GNUNET_NO) || (fail_session_selection_session_big != GNUNET_NO))
-  {
-    GNUNET_log (GNUNET_ERROR_TYPE_ERROR, "Phase 2: Test session selection failed\n");
-    fail = 1;
-  }
-  if ((fail_msgs_transmited_to_local_addrs != count_str_addr) || (fail_multiple_msgs_in_transmission != 2) || (fail_msg_transmited_max_size == GNUNET_YES))
+  if ( (fail_notify_address == GNUNET_YES) || 
+       (fail_pretty_printer == GNUNET_YES) || 
+       (fail_addr_to_str == GNUNET_YES))
+    {
+      GNUNET_log (GNUNET_ERROR_TYPE_ERROR, 
+                  "Phase 0: Test plugin functions failed\n");
+      fail = 1;
+    }
+  if ( (test_no_ident.test_failed == GNUNET_YES) || 
+       (test_too_short_ident.test_failed == GNUNET_YES) || 
+       (test_too_long_ident.test_failed == GNUNET_YES) || 
+       (test_valid_ident.test_failed == GNUNET_YES) )
   {
-    GNUNET_log (GNUNET_ERROR_TYPE_ERROR, "Phase 3: Test sending with plugin failed\n");
+    GNUNET_log (GNUNET_ERROR_TYPE_ERROR, 
+                "Phase 1: Test connect with wrong data failed\n");
     fail = 1;
   }
+  if ( (fail_session_selection_any != GNUNET_NO) || 
+       (fail_session_selection_reliable != GNUNET_NO) ||
+       (fail_session_selection_session != GNUNET_NO) || 
+       (fail_session_selection_session_big != GNUNET_NO) )
+    {
+      GNUNET_log (GNUNET_ERROR_TYPE_ERROR, 
+                  "Phase 2: Test session selection failed\n");
+      fail = 1;
+    }
+  if ( (fail_msgs_transmited_to_local_addrs != count_str_addr) ||
+       (fail_multiple_msgs_in_transmission != 2) || 
+       (fail_msg_transmited_max_size == GNUNET_YES) )
+    {
+      GNUNET_log (GNUNET_ERROR_TYPE_ERROR, 
+                  "Phase 3: Test sending with plugin failed\n");
+      fail = 1;
+    }
   if (fail != 1)
-  {
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "All tests successful\n");
-  }
-
+    {
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, 
+                  "All tests successful\n");
+    }
+  
   api->disconnect(api->cls,&my_identity);
 
   curl_multi_cleanup(multi_handle);
@@ -430,7 +448,6 @@ shutdown_clean ()
   /* cleaning addresses */
   while (addr_head != NULL)
   {
-    cur = addr_head;
     tmp = addr_head->next;
     GNUNET_free (addr_head->addr);
     GNUNET_free (addr_head);
@@ -439,30 +456,39 @@ shutdown_clean ()
 
   if (ti_send != GNUNET_SCHEDULER_NO_TASK)
   {
-    GNUNET_SCHEDULER_cancel(sched,ti_send);
+    GNUNET_SCHEDULER_cancel(ti_send);
     ti_send = GNUNET_SCHEDULER_NO_TASK;
   }
 
   if (http_task_send != GNUNET_SCHEDULER_NO_TASK)
   {
-    GNUNET_SCHEDULER_cancel(sched,http_task_send);
+    GNUNET_SCHEDULER_cancel(http_task_send);
     http_task_send = GNUNET_SCHEDULER_NO_TASK;
   }
 
   if (ti_timeout != GNUNET_SCHEDULER_NO_TASK)
   {
-    GNUNET_SCHEDULER_cancel(sched,ti_timeout);
+    GNUNET_SCHEDULER_cancel(ti_timeout);
     ti_timeout = GNUNET_SCHEDULER_NO_TASK;
   }
 
   GNUNET_free(test_addr);
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Unloading http plugin\n");
-  GNUNET_assert (NULL == GNUNET_PLUGIN_unload ("libgnunet_plugin_transport_http", api));
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, 
+              "Unloading http plugin\n");
+  GNUNET_assert (NULL == GNUNET_PLUGIN_unload ("libgnunet_gnunet_transport_plugin_http", api));
+
+  GNUNET_SCHEDULER_shutdown();
+  GNUNET_DISK_directory_remove ("/tmp/test_gnunet_transport_plugin_http");
+
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, 
+              "Exiting testcase\n");
 
-  GNUNET_SCHEDULER_shutdown(sched);
-  GNUNET_DISK_directory_remove ("/tmp/test_plugin_transport_http");
+  if (servicehome != NULL)
+  {
+    GNUNET_DISK_directory_remove (servicehome);
+    GNUNET_free (servicehome);
+  }
 
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Exiting testcase\n");
   exit(fail);
   return;
 }
@@ -475,25 +501,26 @@ shutdown_clean ()
  * @result GNUNET_OK or GNUNET_SYSERR
  */
 
-static void task_send_cont (void *cls,
-                            const struct GNUNET_PeerIdentity * target,
-                            int result)
+static void
+task_send_cont (void *cls,
+                const struct GNUNET_PeerIdentity * target,
+                int result)
 {
-  struct Plugin_Address * tmp_addr;
-  tmp_addr = addr_head;
-
   if ((cls == &fail_msg_transmited_bigger_max_size) && (result == GNUNET_SYSERR))
-  {
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Message bigger max msg size was not sent!\n");
-    fail_msg_transmited_bigger_max_size = GNUNET_NO;
-    return;
-  }
+    {
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, 
+                  "Message bigger max msg size was not sent!\n");
+      fail_msg_transmited_bigger_max_size = GNUNET_NO;
+      return;
+    }
 
   if ((cls == &fail_msg_transmited_max_size) && (result == GNUNET_OK))
-  {
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Message with max msg size succesfully sent!\n",fail_msgs_transmited_to_local_addrs);
-    fail_msg_transmited_max_size = GNUNET_NO;
-  }
+    {
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, 
+                  "Message with max msg size succesfully sent!\n",
+                  fail_msgs_transmited_to_local_addrs);
+      fail_msg_transmited_max_size = GNUNET_NO;
+    }
 }
 
 
@@ -503,59 +530,60 @@ static void run_connection_tests( int phase , void * cls);
  * Recieves messages from plugin, in real world transport
  */
 static struct GNUNET_TIME_Relative
-receive (void *cls,
-         const struct GNUNET_PeerIdentity * peer,
-         const struct GNUNET_MessageHeader * message,
-         uint32_t distance,
-         struct Session *session,
-         const char *sender_address,
-         uint16_t sender_address_len)
+receive (void *cls, const struct GNUNET_PeerIdentity *peer,
+        const struct GNUNET_MessageHeader *message,
+        const struct GNUNET_TRANSPORT_ATS_Information *ats,
+        uint32_t ats_count,
+        struct Session *session,
+        const char *sender_address,
+        uint16_t sender_address_len)
 {
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Testcase recieved new message from peer `%s' with type %u and length %u, session %X\n",  GNUNET_i2s(peer), ntohs(message->type), ntohs(message->size),session);
-
-  if ((ntohs(message->type)>=10) && (ntohs(message->type)<20))
-  {
-    fail_msgs_transmited_to_local_addrs++;
-    if (fail_msgs_transmited_to_local_addrs == count_str_addr)
-      run_connection_tests(2, session);
-  }
-
-
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+              "Testcase recieved new message from peer `%s' with type %u and length %u, session %X\n",
+              GNUNET_i2s(peer),
+              ntohs(message->type),
+              ntohs(message->size),
+              session);
+
+  if ( (ntohs(message->type)>=10) && 
+       (ntohs(message->type)<20) )
+    {
+      fail_msgs_transmited_to_local_addrs++;
+      if (fail_msgs_transmited_to_local_addrs == count_str_addr)
+        run_connection_tests(2, session);
+    }
   if ((ntohs(message->type)==20))
-  {
-    fail_session_selection_reliable = GNUNET_NO;
-  }
-
+    {
+      fail_session_selection_reliable = GNUNET_NO;
+    }  
   if ((ntohs(message->type)==21))
-  {
-    fail_session_selection_any = GNUNET_NO;
-  }
+    {
+      fail_session_selection_any = GNUNET_NO;
+    }
   if ((ntohs(message->type)==22))
-  {
-    fail_session_selection_session = GNUNET_NO;
-  }
-
+    {
+      fail_session_selection_session = GNUNET_NO;
+    }  
   if ((ntohs(message->type)==23))
-  {
-    fail_session_selection_session_big = GNUNET_NO;
-    run_connection_tests(3, NULL);
-  }
-
+    {
+      fail_session_selection_session_big = GNUNET_NO;
+      run_connection_tests(3, NULL);
+    }  
   if ((ntohs(message->type)==30) || (ntohs(message->type)==31))
-  {
-    fail_multiple_msgs_in_transmission ++;
-  }
-
+    {
+      fail_multiple_msgs_in_transmission ++;
+    }  
   if ((ntohs(message->type)==32) && (ntohs(message->size) == GNUNET_SERVER_MAX_MESSAGE_SIZE-1))
-  {
-    fail_msg_transmited_max_size = GNUNET_NO;
-    shutdown_clean();
-  }
-
+    {
+      fail_msg_transmited_max_size = GNUNET_NO;
+      shutdown_clean();
+    }  
   return GNUNET_TIME_UNIT_ZERO;
 }
 
-static size_t send_function (void *stream, size_t size, size_t nmemb, void *ptr)
+
+static size_t 
+send_function (void *stream, size_t size, size_t nmemb, void *ptr)
 {
   unsigned int len;
 
@@ -566,9 +594,11 @@ static size_t send_function (void *stream, size_t size, size_t nmemb, void *ptr)
   memcpy(stream, buffer_out.buf, len);
   buffer_out.pos = len;
   return len;
+
 }
 
-static size_t recv_function (void *ptr, size_t size, size_t nmemb, void *ctx)
+static size_t 
+recv_function (void *ptr, size_t size, size_t nmemb, void *ctx)
 {
 
   if (buffer_in.pos + size * nmemb > buffer_in.size)
@@ -582,9 +612,10 @@ static size_t recv_function (void *ptr, size_t size, size_t nmemb, void *ctx)
   return buffer_in.pos;
 }
 
-static size_t header_function( void *ptr, size_t size, size_t nmemb, void *stream)
+static size_t
+header_function( void *ptr, size_t size, size_t nmemb, void *stream)
 {
-  struct HTTP_Transfer * res = (struct HTTP_Transfer *) stream;
+  struct HTTP_Transfer * res = stream;
   char * tmp;
   unsigned int len = size * nmemb;
 
@@ -593,39 +624,43 @@ static size_t header_function( void *ptr, size_t size, size_t nmemb, void *strea
   if (tmp[len-2] == 13)
     tmp[len-2]= '\0';
 #if DEBUG_CURL
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Header: `%s'\n",tmp);
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+              "Header: `%s'\n",
+              tmp);
 #endif
   if (0==strcmp (tmp,"HTTP/1.1 100 Continue"))
-  {
-    res->http_result_code=100;
-  }
+    {
+      res->http_result_code=100;
+    }
   if (0==strcmp (tmp,"HTTP/1.1 200 OK"))
-  {
-    res->http_result_code=200;
-  }
+    {
+      res->http_result_code=200;
+    }
   if (0==strcmp (tmp,"HTTP/1.1 400 Bad Request"))
-  {
-    res->http_result_code=400;
-  }
+    {
+      res->http_result_code=400;
+    }
   if (0==strcmp (tmp,"HTTP/1.1 404 Not Found"))
-  {
-    res->http_result_code=404;
-  }
+    {
+      res->http_result_code=404;
+    }
   if (0==strcmp (tmp,"HTTP/1.1 413 Request entity too large"))
-  {
-    res->http_result_code=413;
-  }
-
+    {
+      res->http_result_code=413;
+    }
+  
   GNUNET_free (tmp);
   return size * nmemb;
 }
 
-static size_t send_prepare( struct HTTP_Transfer * result);
 
+static size_t 
+send_prepare( struct HTTP_Transfer * result);
 
 
-static void send_execute (void *cls,
-             const struct GNUNET_SCHEDULER_TaskContext *tc)
+static void 
+send_execute (void *cls,
+              const struct GNUNET_SCHEDULER_TaskContext *tc)
 {
   struct HTTP_Transfer *res;
 
@@ -676,42 +711,50 @@ static void send_execute (void *cls,
                   if (res == &test_no_ident)
                   {
                     if  ((res->http_result_code==404) && (buffer_in.len==208))
-                    {
-                      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Connecting to peer without any peer identification: test passed\n");
+                      {
+                      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                                  "Connecting to peer without any peer identification: test passed\n");
                       res->test_failed = GNUNET_NO;
                     }
                     else
-                      GNUNET_log (GNUNET_ERROR_TYPE_ERROR, _("Connecting to peer without any peer identification: test failed\n"));
+                      GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+                                  _("Connecting to peer without any peer identification: test failed\n"));
                   }
                   if (res == &test_too_short_ident)
                   {
                     if  ((res->http_result_code==404) && (buffer_in.len==208))
                     {
-                      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Connecting to peer with too short peer identification: test passed\n");
+                      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                                  "Connecting to peer with too short peer identification: test passed\n");
                       res->test_failed = GNUNET_NO;
                     }
                     else
-                      GNUNET_log (GNUNET_ERROR_TYPE_ERROR, _("Connecting to peer with too short peer identification: test failed\n"));
+                      GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+                                  _("Connecting to peer with too short peer identification: test failed\n"));
                   }
                   if (res == &test_too_long_ident)
                   {
                     if  ((res->http_result_code==404) && (buffer_in.len==208))
                       {
-                      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Connecting to peer with too long peer identification: test passed\n");
+                      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                                  "Connecting to peer with too long peer identification: test passed\n");
                       res->test_failed = GNUNET_NO;
                       }
                     else
-                      GNUNET_log (GNUNET_ERROR_TYPE_ERROR, _("Connecting to peer with too long peer identification: test failed\n"));
+                      GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+                                  _("Connecting to peer with too long peer identification: test failed\n"));
                   }
                   if (res == &test_valid_ident)
                   {
                     if  ((res->http_result_code==200))
                     {
-                      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Connecting to peer with valid peer identification: test passed\n");
+                      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                                  "Connecting to peer with valid peer identification: test passed\n");
                       res->test_failed = GNUNET_NO;
                     }
                     else
-                      GNUNET_log (GNUNET_ERROR_TYPE_ERROR, "Connecting to peer with valid peer identification: test failed\n");
+                      GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+                                  "Connecting to peer with valid peer identification: test failed\n");
                   }
                   curl_easy_cleanup(curl_handle);
                   curl_handle=NULL;
@@ -731,12 +774,14 @@ static void send_execute (void *cls,
   send_prepare(cls);
 }
 
+
 /**
  * Function setting up file descriptors and scheduling task to run
  * @param ses session to send data to
  * @return bytes sent to peer
  */
-static size_t send_prepare( struct HTTP_Transfer * result)
+static size_t
+send_prepare( struct HTTP_Transfer * result)
 {
   fd_set rs;
   fd_set ws;
@@ -774,14 +819,13 @@ static size_t send_prepare( struct HTTP_Transfer * result)
   gws = GNUNET_NETWORK_fdset_create ();
   GNUNET_NETWORK_fdset_copy_native (grs, &rs, max + 1);
   GNUNET_NETWORK_fdset_copy_native (gws, &ws, max + 1);
-  http_task_send = GNUNET_SCHEDULER_add_select (sched,
-                                   GNUNET_SCHEDULER_PRIORITY_DEFAULT,
-                                   GNUNET_SCHEDULER_NO_TASK,
-                                   GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_SECONDS, 0),
-                                   grs,
-                                   gws,
-                                   &send_execute,
-                                   result);
+  http_task_send = GNUNET_SCHEDULER_add_select (GNUNET_SCHEDULER_PRIORITY_DEFAULT,
+                                                GNUNET_SCHEDULER_NO_TASK,
+                                                GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_SECONDS, 0),
+                                                grs,
+                                                gws,
+                                                &send_execute,
+                                                result);
   GNUNET_NETWORK_fdset_destroy (gws);
   GNUNET_NETWORK_fdset_destroy (grs);
 
@@ -792,15 +836,17 @@ static size_t send_prepare( struct HTTP_Transfer * result)
 /**
  * function to send data to server
  */
-static int send_data( struct HTTP_Transfer * result, char * url)
+static int 
+send_data(struct HTTP_Transfer * result,
+          char * url)
 {
 
   curl_handle = curl_easy_init();
   if( NULL == curl_handle)
-  {
-    printf("easy_init failed \n");
-    return GNUNET_SYSERR;
-  }
+    {
+      printf("easy_init failed \n");
+      return GNUNET_SYSERR;
+    }
 #if DEBUG_CURL
   curl_easy_setopt(curl_handle, CURLOPT_VERBOSE, 1L);
 #endif
@@ -826,12 +872,11 @@ static int send_data( struct HTTP_Transfer * result, char * url)
 /**
  * Plugin notifies transport (aka testcase) about its addresses
  */
-void
+static void
 notify_address (void *cls,
-                const char *name,
+                int add_remove,
                 const void *addr,
-                uint16_t addrlen,
-                struct GNUNET_TIME_Relative expires)
+                size_t addrlen)
 {
   char address[INET6_ADDRSTRLEN];
   unsigned int port;
@@ -857,10 +902,10 @@ notify_address (void *cls,
                 addrlen);
       return;
     }
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, 
-             _("Transport plugin notification for address: `%s':%u\n"),
-             address,
-             port);
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+              _("Transport plugin notification for address: `%s':%u\n"),
+              address,
+              port);
   pl_addr = GNUNET_malloc (sizeof (struct Plugin_Address) );
   pl_addr->addrlen = addrlen;
   pl_addr->addr = GNUNET_malloc(addrlen);
@@ -875,9 +920,9 @@ notify_address (void *cls,
     {
       cur = addr_head;
       while (NULL != cur->next)
-       {
-         cur = cur->next;
-       }
+        {
+          cur = cur->next;
+        }
       cur->next = pl_addr;
     }
   fail_notify_address_count++;
@@ -885,11 +930,14 @@ notify_address (void *cls,
 }
 
 static void
-plugin_env_session_end  (void *cls,
-                        const struct GNUNET_PeerIdentity *peer,
-                        struct Session *session)
+plugin_env_session_end (void *cls,
+                        const struct GNUNET_PeerIdentity *peer,
+                        struct Session *session)
 {
-         GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,"Pluging tells me: session %X to peer `%s' ended\n", session, GNUNET_i2s(peer));
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+              "Pluging tells me: session %X to peer `%s' ended\n",
+              session,
+              GNUNET_i2s(peer));
 }
 
 
@@ -900,7 +948,6 @@ static void
 setup_plugin_environment ()
 {
   env.cfg = cfg;
-  env.sched = sched;
   env.stats = stats;
   env.my_identity = &my_identity;
   env.cls = &env;
@@ -928,19 +975,24 @@ task_timeout (void *cls,
   return;
 }
 
-static void pretty_printer_cb (void *cls,
-                               const char *address)
+
+static void 
+pretty_printer_cb (void *cls,
+                   const char *address)
 {
   if (NULL==address)
     return;
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,"Plugin returned pretty address: `%s'\n",address);
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+              "Plugin returned pretty address: `%s'\n",
+              address);
   fail_pretty_printer_count++;
 }
 
 /**
  * Runs every single test to test the plugin
  */
-static void run_connection_tests( int phase , void * cls)
+static void 
+run_connection_tests( int phase , void * cls)
 {
   struct GNUNET_MessageHeader * msg;
   unsigned int size;
@@ -958,136 +1010,184 @@ static void run_connection_tests( int phase , void * cls)
     buffer_out.len = 0;
 
     if (test_no_ident.test_executed == GNUNET_NO)
-    {
-      /* Connecting to peer without identification */
-      char * ident = "";
-      GNUNET_asprintf (&host_str, "%s://%s/%s",PROTOCOL_PREFIX, test_addr,ident);
-      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, _("Connecting to peer without any peer identification.\n"));
-      test_no_ident.test_executed = GNUNET_YES;
-      send_data ( &test_no_ident, host_str);
-      GNUNET_free (host_str);
-      return;
-    }
+      {
+        /* Connecting to peer without identification */
+        const char * ident = "";
+        GNUNET_asprintf (&host_str,
+                         "%s://%s/%s",
+                         PROTOCOL_PREFIX,
+                         test_addr,ident);
+        GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                    _("Connecting to peer without any peer identification.\n"));
+        test_no_ident.test_executed = GNUNET_YES;
+        send_data ( &test_no_ident, host_str);
+        GNUNET_free (host_str);
+        return;
+      }
     if (test_too_short_ident.test_executed == GNUNET_NO)
-    {
-      char * ident = "AAAAAAAAAA";
-      /* Connecting to peer with too short identification */
-      GNUNET_asprintf (&host_str, "%s://%s/%s",PROTOCOL_PREFIX,test_addr,ident);
-      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, _("Connecting to peer with too short peer identification.\n"));
-      test_too_short_ident.test_executed = GNUNET_YES;
-      send_data ( &test_too_short_ident, host_str);
-      GNUNET_free (host_str);
-      return;
-    }
+      {
+        const char * ident = "AAAAAAAAAA";
+        /* Connecting to peer with too short identification */
+        GNUNET_asprintf (&host_str,
+                         "%s://%s/%s",
+                         PROTOCOL_PREFIX,
+                         test_addr,
+                         ident);
+        GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                    _("Connecting to peer with too short peer identification.\n"));
+        test_too_short_ident.test_executed = GNUNET_YES;
+        send_data ( &test_too_short_ident, host_str);
+        GNUNET_free (host_str);
+        return;
+      }
 
     if (test_too_long_ident.test_executed == GNUNET_NO)
-    {
-      char * ident = "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA";
-
-      /* Connecting to peer with too long identification */
-      GNUNET_asprintf (&host_str, "%s://%s/%s",PROTOCOL_PREFIX, test_addr,ident);
-      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, _("Connecting to peer with too long peer identification.\n"));
-      test_too_long_ident.test_executed = GNUNET_YES;
-      send_data ( &test_too_long_ident, host_str);
-      GNUNET_free (host_str);
-      return;
+      {
+        const char * ident = "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA";
+
+        /* Connecting to peer with too long identification */
+        GNUNET_asprintf (&host_str, "%s://%s/%s",PROTOCOL_PREFIX, test_addr,ident);
+        GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                    _("Connecting to peer with too long peer identification.\n"));
+        test_too_long_ident.test_executed = GNUNET_YES;
+        send_data ( &test_too_long_ident, host_str);
+        GNUNET_free (host_str);
+        return;
     }
     if (test_valid_ident.test_executed == GNUNET_NO)
-    {
-      struct GNUNET_CRYPTO_HashAsciiEncoded ident;
-      GNUNET_CRYPTO_hash_to_enc(&my_identity.hashPubKey,&ident);
-      GNUNET_asprintf (&host_str, "%s://%s/%s%s",PROTOCOL_PREFIX, test_addr,(char *) &ident,";0");
-      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, _("Connecting to peer with valid peer identification.\n"));
-      test_valid_ident.test_executed = GNUNET_YES;
-      send_data ( &test_valid_ident, host_str);
-      GNUNET_free (host_str);
-      return;
-    }
+      {
+        struct GNUNET_CRYPTO_HashAsciiEncoded ident;
+        GNUNET_CRYPTO_hash_to_enc(&my_identity.hashPubKey,&ident);
+        GNUNET_asprintf (&host_str,
+                         "%s://%s/%s%s",
+                         PROTOCOL_PREFIX,
+                         test_addr,
+                         (char *) &ident,
+                         ";0");
+        GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                    _("Connecting to peer with valid peer identification.\n"));
+        test_valid_ident.test_executed = GNUNET_YES;
+        send_data ( &test_valid_ident, host_str);
+        GNUNET_free (host_str);
+        return;
+      }
   }
   if (phase==1)
-  {
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "\nPhase 1: transmit data to all suggested addresses\n\n");
-    /* Using one of the addresses the plugin proposed */
-    GNUNET_assert (addr_head->addr != NULL);
-
-    struct Plugin_Address * tmp_addr;
-    struct GNUNET_MessageHeader msg;
-    char * tmp = GNUNET_malloc(sizeof(struct GNUNET_MessageHeader));
-    char address[INET6_ADDRSTRLEN];
-    unsigned int port;
-    unsigned int type = 10;
-
-    msg.size=htons(sizeof(struct GNUNET_MessageHeader));
-    tmp_addr = addr_head;
-    /* send a message to all addresses advertised by plugin */
-
-    int count = 0;
-    while (tmp_addr != NULL)
     {
-      if (tmp_addr->addrlen == (sizeof (struct IPv4HttpAddress)))
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                  "\nPhase 1: transmit data to all suggested addresses\n\n");
+      /* Using one of the addresses the plugin proposed */
+      GNUNET_assert (addr_head->addr != NULL);
+      
+      struct Plugin_Address * tmp_addr;
+      struct GNUNET_MessageHeader msg;
+      char * tmp = GNUNET_malloc(sizeof(struct GNUNET_MessageHeader));
+      char address[INET6_ADDRSTRLEN];
+      unsigned int port;
+      unsigned int type = 10;
+      
+      msg.size=htons(sizeof(struct GNUNET_MessageHeader));
+      tmp_addr = addr_head;
+      /* send a message to all addresses advertised by plugin */
+      
+      int count = 0;
+      while (tmp_addr != NULL)
         {
-          inet_ntop(AF_INET, (struct in_addr *) tmp_addr->addr,address,INET_ADDRSTRLEN);
-          port = ntohs(((struct IPv4HttpAddress *) tmp_addr->addr)->u_port);
-          GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,"Sending message to addres no. %u: `%s':%u\n", count,address, port);
-        }
-      if (tmp_addr->addrlen == (sizeof (struct IPv6HttpAddress)))
-        {
-          inet_ntop(AF_INET6, (struct in6_addr *) tmp_addr->addr,address,INET6_ADDRSTRLEN);
-          port = ntohs(((struct IPv6HttpAddress *) tmp_addr->addr)->u6_port);
-          GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,"Sending message to addres no. %u: `%s':%u\n", count,address,port);
+          if (tmp_addr->addrlen == (sizeof (struct IPv4HttpAddress)))
+            {
+              inet_ntop(AF_INET, (struct in_addr *) tmp_addr->addr,address,INET_ADDRSTRLEN);
+              port = ntohs(((struct IPv4HttpAddress *) tmp_addr->addr)->u_port);
+              GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                          "Sending message to addres no. %u: `%s':%u\n",
+                          count,
+                          address,
+                          port);
+            }
+          if (tmp_addr->addrlen == (sizeof (struct IPv6HttpAddress)))
+            {
+              inet_ntop(AF_INET6, (struct in6_addr *) tmp_addr->addr,address,INET6_ADDRSTRLEN);
+              port = ntohs(((struct IPv6HttpAddress *) tmp_addr->addr)->u6_port);
+              GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                          "Sending message to addres no. %u: `%s':%u\n",
+                          count,
+                          address,
+                          port);
+            }
+          msg.type=htons(type);
+          memcpy(tmp,&msg,sizeof(struct GNUNET_MessageHeader));
+          api->send(api->cls,
+                    &my_identity,
+                    tmp, sizeof(struct GNUNET_MessageHeader),
+                    0, TIMEOUT,
+                    NULL,
+                    tmp_addr->addr, tmp_addr->addrlen,
+                    GNUNET_YES,
+                    &task_send_cont, &fail_msgs_transmited_to_local_addrs);
+          tmp_addr = tmp_addr->next;
+          count++;
+          type++;
         }
-      msg.type=htons(type);
-      memcpy(tmp,&msg,sizeof(struct GNUNET_MessageHeader));
-      api->send(api->cls, &my_identity, tmp, sizeof(struct GNUNET_MessageHeader), 0, TIMEOUT, NULL,tmp_addr->addr, tmp_addr->addrlen, GNUNET_YES, &task_send_cont, &fail_msgs_transmited_to_local_addrs);
-      tmp_addr = tmp_addr->next;
-
-      count ++;
-      type ++;
+      GNUNET_free(tmp);
+      return;
     }
-    GNUNET_free(tmp);
-    return;
-  }
 
   if (phase==2)
-  {
-    struct Session * session = cls;
-    msg = GNUNET_malloc (sizeof(struct GNUNET_MessageHeader));
-
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Phase 2: session selection\n\n");
-    size = sizeof(struct GNUNET_MessageHeader);
-    msg->size=htons(size);
-    msg->type = htons(20);
-    api->send(api->cls, &my_identity, (const char *) msg, size, 0, TIMEOUT, NULL, NULL, 0, GNUNET_NO, &task_send_cont, NULL);
-
-    msg->type = htons(21);
-    api->send(api->cls, &my_identity, (const char *) msg, size, 0, TIMEOUT, NULL, NULL, 0, GNUNET_SYSERR, &task_send_cont, NULL);
-
-    /* answer on session*/
-    size = sizeof( struct GNUNET_MessageHeader);
-    msg->size = htons(size);
-    msg->type = htons(22);
-    api->send(api->cls, &my_identity, (const char *) msg, size, 0, TIMEOUT, session, NULL, 0, GNUNET_SYSERR, &task_send_cont, NULL);
-
-    GNUNET_free(msg);
-
-    /* answer on session with big message not fitting in mhd send buffer*/
-    size = GNUNET_SERVER_MAX_MESSAGE_SIZE-1;
-    msg = GNUNET_malloc (size);
-    msg->size=htons(size);
-    msg->type = htons(23);
-    api->send(api->cls, &my_identity, (const char *) msg, size, 0, TIMEOUT, session, NULL, 0, GNUNET_NO, &task_send_cont, NULL);
-    GNUNET_free(msg);
-    return;
-  }
-
+    {
+      struct Session * session = cls;
+      msg = GNUNET_malloc (sizeof(struct GNUNET_MessageHeader));
+      
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, 
+                  "Phase 2: session selection\n\n");
+      size = sizeof(struct GNUNET_MessageHeader);
+      msg->size=htons(size);
+      msg->type = htons(20);
+      api->send(api->cls, 
+                &my_identity,
+                (const char *) msg, size,
+                0, TIMEOUT, NULL, NULL, 0, GNUNET_NO,
+                &task_send_cont, NULL);
+      
+      msg->type = htons(21);
+      api->send(api->cls, 
+                &my_identity,
+                (const char *) msg, size,
+                0, TIMEOUT, NULL, NULL, 0, GNUNET_SYSERR,
+                &task_send_cont, NULL);
+      
+      /* answer on session*/
+      size = sizeof( struct GNUNET_MessageHeader);
+      msg->size = htons(size);
+      msg->type = htons(22);
+      api->send(api->cls, 
+                &my_identity,
+                (const char *) msg, size,
+                0, TIMEOUT, session, NULL, 0, GNUNET_SYSERR,
+                &task_send_cont, NULL);
+      GNUNET_free(msg);
+      
+      /* answer on session with big message not fitting in mhd send buffer*/
+      size = GNUNET_SERVER_MAX_MESSAGE_SIZE-1;
+      msg = GNUNET_malloc (size);
+      msg->size=htons(size);
+      msg->type = htons(23);
+      api->send(api->cls,
+                &my_identity,
+                (const char *) msg, size,
+                0, TIMEOUT, session, NULL, 0, GNUNET_NO,
+                &task_send_cont, NULL);
+      GNUNET_free(msg);
+      return;
+    }
+  
   if (phase==3)
-  {
-
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Phase 3: send multiple or big messages after disconnect\n\n");
+    {
+      
+    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, 
+                "Phase 3: send multiple or big messages after disconnect\n\n");
     /* disconnect from peer, so new connections are created */
     GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,"Disconnect from peer: `%s'\n", GNUNET_i2s(&my_identity));
     api->disconnect(api->cls, &my_identity);
-
+    
     GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Phase 3: sending messages\n");
     /* send a multiple GNUNET_messages at a time*/
     size = 2 * sizeof(struct GNUNET_MessageHeader);
@@ -1097,7 +1197,13 @@ static void run_connection_tests( int phase , void * cls)
     struct GNUNET_MessageHeader * msg2 = &msg[2];
     msg2->size = htons(2 * sizeof(struct GNUNET_MessageHeader));
     msg2->type = htons(31);
-    api->send(api->cls, &my_identity, (const char *) msg, 4 * sizeof(struct GNUNET_MessageHeader), 0, TIMEOUT, NULL,addr_head->addr, addr_head->addrlen, GNUNET_NO, &task_send_cont, &fail_multiple_msgs_in_transmission);
+    api->send(api->cls,
+              &my_identity,
+              (const char *) msg, 4 * sizeof(struct GNUNET_MessageHeader),
+              0, TIMEOUT, NULL,
+              addr_head->addr, addr_head->addrlen,
+              GNUNET_NO,
+              &task_send_cont, &fail_multiple_msgs_in_transmission);
     GNUNET_free(msg);
     /* send a message with size GNUNET_SERVER_MAX_MESSAGE_SIZE-1  */
 
@@ -1105,9 +1211,16 @@ static void run_connection_tests( int phase , void * cls)
     msg = GNUNET_malloc(size);
     msg->size = htons(size);
     msg->type = htons(32);
-    api->send(api->cls, &my_identity, (const char *) msg, size, 0, TIMEOUT, NULL,addr_head->addr, addr_head->addrlen, GNUNET_NO, &task_send_cont, &fail_msg_transmited_max_size);
+    api->send(api->cls,
+              &my_identity,
+              (const char *) msg, size,
+              0, TIMEOUT, NULL,
+              addr_head->addr, addr_head->addrlen,
+              GNUNET_NO,
+              &task_send_cont, &fail_msg_transmited_max_size);
     GNUNET_free(msg);
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,"No more tests to run\n");
+    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                "No more tests to run\n");
   }
 }
 
@@ -1116,17 +1229,14 @@ static void run_connection_tests( int phase , void * cls)
  * Runs the test.
  *
  * @param cls closure
- * @param s scheduler to use
  * @param c configuration to use
  */
 static void
 run (void *cls,
-     struct GNUNET_SCHEDULER_Handle *s,
      char *const *args,
      const char *cfgfile, const struct GNUNET_CONFIGURATION_Handle *c)
 {
   char * libname;
-  sched = s;
   cfg = c;
   char *keyfile;
   unsigned long long tneigh;
@@ -1150,6 +1260,9 @@ run (void *cls,
   addr_head = NULL;
   count_str_addr = 0;
   /* parse configuration */
+  if (GNUNET_CONFIGURATION_have_value (c,"PATHS", "SERVICEHOME"))
+      GNUNET_CONFIGURATION_get_value_string (c, "PATHS", "SERVICEHOME", &servicehome);
+
   if ((GNUNET_OK !=
        GNUNET_CONFIGURATION_get_value_number (c,
                                               "TRANSPORT",
@@ -1162,7 +1275,7 @@ run (void *cls,
     {
       GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                   _("Transport service is lacking key configuration settings.  Exiting.\n"));
-      GNUNET_SCHEDULER_shutdown (s);
+      GNUNET_SCHEDULER_shutdown ();
       fail = 1;
       return;
     }
@@ -1188,7 +1301,7 @@ run (void *cls,
     {
       GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                   _("Transport service could not access hostkey.  Exiting.\n"));
-      GNUNET_SCHEDULER_shutdown (s);
+      GNUNET_SCHEDULER_shutdown ();
       fail = 1;
       return;
     }
@@ -1198,13 +1311,13 @@ run (void *cls,
 
   /* assertions before start */
   GNUNET_assert ((port > 0) && (port <= 65535));
-  GNUNET_assert(&my_public_key != NULL);
-  GNUNET_assert(&my_identity.hashPubKey != NULL);
 
   /* load plugins... */
   setup_plugin_environment ();
-  GNUNET_log (GNUNET_ERROR_TYPE_INFO, _("Loading HTTP transport plugin `%s'\n"),"libgnunet_plugin_transport_http");
   GNUNET_asprintf (&libname, "libgnunet_plugin_transport_http");
+  GNUNET_log (GNUNET_ERROR_TYPE_INFO, 
+              _("Loading HTTP transport plugin `%s'\n"),
+              libname);
   api = GNUNET_PLUGIN_load (libname, &env);
   GNUNET_free (libname);
   if (api == NULL)
@@ -1215,18 +1328,22 @@ run (void *cls,
     return;
   }
 
-  ti_timeout = GNUNET_SCHEDULER_add_delayed (sched, TEST_TIMEOUT, &task_timeout, NULL);
+
+  ti_timeout = GNUNET_SCHEDULER_add_delayed (TEST_TIMEOUT, &task_timeout, NULL);
 
   /* testing plugin functionality */
   GNUNET_assert (0!=fail_notify_address_count);
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Transport plugin returned %u addresses to connect to\n",  fail_notify_address_count);
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, 
+              "Transport plugin returned %u addresses to connect to\n",
+              fail_notify_address_count);
 
   /* testing pretty printer with all addresses obtained from the plugin*/
   cur = addr_head;
   while (cur != NULL)
   {
-
-    api->address_pretty_printer (api->cls, "http",cur->addr,cur->addrlen, GNUNET_NO,TEST_TIMEOUT, &pretty_printer_cb,NULL);
+    api->address_pretty_printer (api->cls, "http",
+                                 cur->addr,cur->addrlen, GNUNET_NO,TEST_TIMEOUT,
+                                 &pretty_printer_cb, NULL);
     addr_str = api->address_to_string (api->cls, cur->addr, cur->addrlen);
     suggest_res = api->check_address (api->cls, cur->addr, cur->addrlen);
 
@@ -1242,12 +1359,7 @@ run (void *cls,
   fail_pretty_printer=GNUNET_NO;
   fail_addr_to_str=GNUNET_NO;
 
-  /* Suggesting addresses with wrong port*/
   struct IPv4HttpAddress failing_addr;
-  failing_addr.ipv4_addr = htonl(INADDR_LOOPBACK);
-  failing_addr.u_port = htons(0);
-  suggest_res = api->check_address (api->cls,&failing_addr,sizeof (struct IPv4HttpAddress));
-  GNUNET_assert (GNUNET_SYSERR == suggest_res);
 
   /* Suggesting addresses with wrong size*/
   failing_addr.ipv4_addr = htonl(INADDR_LOOPBACK);
@@ -1295,10 +1407,7 @@ run (void *cls,
 
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, _("Phase 0\n\n"));
   run_connection_tests(0, NULL);
-
   /* testing finished */
-
-  return;
 }
 
 
@@ -1312,13 +1421,12 @@ run (void *cls,
 int
 main (int argc, char *const *argv)
 {
-
   static struct GNUNET_GETOPT_CommandLineOption options[] = {
     GNUNET_GETOPT_OPTION_END
   };
   int ret;
   char *const argv_prog[] = {
-    "test_plugin_transport_http",
+    "test_gnunet_transport_plugin_http",
     "-c",
     "test_plugin_transport_data_http.conf",
     "-L",
@@ -1329,7 +1437,7 @@ main (int argc, char *const *argv)
 #endif
     NULL
   };
-  GNUNET_log_setup ("test_plugin_transport_http",
+  GNUNET_log_setup ("test_gnunet_transport_plugin_http",
 #if VERBOSE
                     "DEBUG",
 #else
@@ -1337,15 +1445,29 @@ main (int argc, char *const *argv)
 #endif
                     NULL);
 
+  struct GNUNET_CONFIGURATION_Handle *cfg;
+  cfg = GNUNET_CONFIGURATION_create ();
+
+  GNUNET_assert (GNUNET_OK == GNUNET_CONFIGURATION_load (cfg, "test_plugin_transport_data_http.conf"));
+  if (GNUNET_CONFIGURATION_have_value (cfg,"PATHS", "SERVICEHOME"))
+      GNUNET_CONFIGURATION_get_value_string (cfg, "PATHS", "SERVICEHOME", &servicehome);
+  GNUNET_DISK_directory_remove (servicehome);
+  GNUNET_CONFIGURATION_destroy (cfg);
+
   ret = (GNUNET_OK ==
          GNUNET_PROGRAM_run (5,
                              argv_prog,
-                             "test_plugin_transport_http",
+                             "test_gnunet_transport_plugin_http",
                              "testcase", options, &run, NULL)) ? GNUNET_NO : GNUNET_YES;
 
-    GNUNET_DISK_directory_remove ("/tmp/test_plugin_transport_http");
-
+  if (servicehome != NULL)
+  {
+    GNUNET_DISK_directory_remove (servicehome);
+    GNUNET_free (servicehome);
+  }
+  if (ret != GNUNET_OK)
+    return 1;
   return fail;
 }
 
-/* end of test_plugin_transport_http.c */
+/* end of test_gnunet_transport_plugin_http.c */