-indentation
[oweals/gnunet.git] / src / transport / plugin_transport_wlan.c
index 103d21ae18a14ff1d55ca9efcf97fa8ba211e67d..49dfee8161afcd44a9af899489767b53ab670125 100644 (file)
@@ -192,6 +192,11 @@ struct Session
    */
   struct MacEndpoint *mac;
 
+  /**
+   * Address associated with this session and MAC endpoint
+   */
+  struct GNUNET_HELLO_Address *address;
+
   /**
    * Head of messages currently pending for transmission to this peer.
    */
@@ -211,9 +216,6 @@ struct Session
    * Timeout task (for the session).
    */
   GNUNET_SCHEDULER_TaskIdentifier timeout_task;
-
-  int inbound;
-
 };
 
 
@@ -349,16 +351,9 @@ struct MacEndpoint
   unsigned int fragment_messages_out_count;
 
   /**
-   * peer mac address
-   */
-  //struct WlanAddress addr;
-
-  struct GNUNET_HELLO_Address *address;
-
-  /**
-   * Inbound or outbound session
+   * peer MAC address
    */
-  int inbound;
+  struct WlanAddress wlan_addr;
 
   /**
    * Message delay for fragmentation context
@@ -614,8 +609,8 @@ send_ack (void *cls, uint32_t msg_id,
   get_radiotap_header (endpoint, radio_header, size);
   get_wlan_header (endpoint->plugin,
                   &radio_header->frame,
-                  endpoint->address->address,
-                  endpoint->address->address_length);
+                  &endpoint->wlan_addr.mac,
+                  sizeof (endpoint->wlan_addr.mac));
   memcpy (&radio_header[1], hdr, msize);
   if (NULL !=
       GNUNET_HELPER_send (endpoint->plugin->suid_helper,
@@ -667,7 +662,7 @@ wlan_plugin_disconnect_session (void *cls,
   struct PendingMessage *pm;
 
   endpoint->plugin->env->session_end (endpoint->plugin->env->cls,
-                                     &session->target,
+                                     session->address,
                                      session);
   while (NULL != (pm = session->pending_message_head))
   {
@@ -692,6 +687,7 @@ wlan_plugin_disconnect_session (void *cls,
   GNUNET_STATISTICS_update (endpoint->plugin->env->stats,
                             _("# WLAN sessions allocated"), -1,
                             GNUNET_NO);
+  GNUNET_HELLO_address_free (session->address);
   GNUNET_free (session);
   return GNUNET_OK;
 }
@@ -743,19 +739,16 @@ session_timeout (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
  *
  * @param endpoint pointer to the mac endpoint of the peer
  * @param peer peer identity to use for this session
- * @param inbound inbound session?
  * @return returns the session or NULL
  */
 static struct Session *
 lookup_session (struct MacEndpoint *endpoint,
-                const struct GNUNET_PeerIdentity *peer,
-                int inbound)
+                const struct GNUNET_PeerIdentity *peer)
 {
   struct Session *session;
 
   for (session = endpoint->sessions_head; NULL != session; session = session->next)
-    if (0 == memcmp (peer, &session->target, sizeof (struct GNUNET_PeerIdentity)) &&
-               (session->inbound == inbound))
+    if (0 == memcmp (peer, &session->target, sizeof (struct GNUNET_PeerIdentity)))
     {
       session->timeout = GNUNET_TIME_relative_to_absolute (GNUNET_CONSTANTS_IDLE_CONNECTION_TIMEOUT);
       return session;
@@ -768,12 +761,11 @@ lookup_session (struct MacEndpoint *endpoint,
  *
  * @param endpoint pointer to the mac endpoint of the peer
  * @param peer peer identity to use for this session
- * @param inbound inbound session?
  * @return returns the session or NULL
  */
 static struct Session *
 create_session (struct MacEndpoint *endpoint,
-                const struct GNUNET_PeerIdentity *peer, int inbound)
+                const struct GNUNET_PeerIdentity *peer)
 {
   struct Session *session;
 
@@ -783,19 +775,19 @@ create_session (struct MacEndpoint *endpoint,
   GNUNET_CONTAINER_DLL_insert_tail (endpoint->sessions_head,
                                     endpoint->sessions_tail,
                                    session);
-  session->inbound = inbound;
+  session->address = GNUNET_HELLO_address_allocate (peer, PLUGIN_NAME,
+      &endpoint->wlan_addr, sizeof (endpoint->wlan_addr),
+      GNUNET_HELLO_ADDRESS_INFO_NONE);
   session->mac = endpoint;
   session->target = *peer;
   session->timeout = GNUNET_TIME_relative_to_absolute (GNUNET_CONSTANTS_IDLE_CONNECTION_TIMEOUT);
   session->timeout_task =
       GNUNET_SCHEDULER_add_delayed (GNUNET_CONSTANTS_IDLE_CONNECTION_TIMEOUT, &session_timeout, session);
   LOG (GNUNET_ERROR_TYPE_DEBUG,
-       "Created new %s session %p for peer `%s' with endpoint %s\n",
-
-       (GNUNET_YES == inbound) ? "inbound" : "outbound",
+       "Created new session %p for peer `%s' with endpoint %s\n",
        session,
        GNUNET_i2s (peer),
-       mac_to_string (endpoint->address->address));
+       mac_to_string (&endpoint->wlan_addr.mac));
 
   return session;
 }
@@ -806,18 +798,16 @@ create_session (struct MacEndpoint *endpoint,
  *
  * @param endpoint pointer to the mac endpoint of the peer
  * @param peer peer identity to use for this session
- * @param inbound inbound session?
  * @return returns the session
  */
 static struct Session *
 get_session (struct MacEndpoint *endpoint,
-                const struct GNUNET_PeerIdentity *peer,
-                int inbound)
+                const struct GNUNET_PeerIdentity *peer)
 {
   struct Session *session;
-  if (NULL != (session = lookup_session (endpoint, peer, inbound)))
+  if (NULL != (session = lookup_session (endpoint, peer)))
        return session;
-  return create_session (endpoint, peer, inbound);
+  return create_session (endpoint, peer);
 }
 
 
@@ -873,8 +863,8 @@ transmit_fragment (void *cls,
     get_radiotap_header (endpoint, radio_header, size);
     get_wlan_header (endpoint->plugin,
                     &radio_header->frame,
-                    endpoint->address->address,
-                    endpoint->address->address_length);
+                    &endpoint->wlan_addr.mac,
+                    sizeof (endpoint->wlan_addr.mac));
     memcpy (&radio_header[1], hdr, msize);
     GNUNET_assert (NULL == fm->sh);
     fm->sh = GNUNET_HELPER_send (endpoint->plugin->suid_helper,
@@ -1037,7 +1027,6 @@ free_macendpoint (struct MacEndpoint *endpoint)
     GNUNET_SCHEDULER_cancel (endpoint->timeout_task);
     endpoint->timeout_task = GNUNET_SCHEDULER_NO_TASK;
   }
-  GNUNET_HELLO_address_free (endpoint->address);
   GNUNET_free (endpoint);
 }
 
@@ -1071,21 +1060,27 @@ macendpoint_timeout (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
  * Find (or create) a MacEndpoint with a specific MAC address
  *
  * @param plugin pointer to the plugin struct
- * @param addr the MAC address of the endpoint
+ * @param mac the MAC address of the endpoint
  * @return handle to our data structure for this MAC
  */
 static struct MacEndpoint *
-create_macendpoint (struct Plugin *plugin,
-                   const struct GNUNET_HELLO_Address *address)
+create_macendpoint (struct Plugin *plugin, struct WlanAddress *mac)
 {
   struct MacEndpoint *pos;
 
   for (pos = plugin->mac_head; NULL != pos; pos = pos->next)
-    if (0 == memcmp (address->address, pos->address->address,
-        pos->address->address_length))
+  {
+    if (0 == memcmp (mac, &pos->wlan_addr, sizeof (pos->wlan_addr)))
+    {
+      LOG (GNUNET_ERROR_TYPE_DEBUG, "Found existing MAC endpoint `%s'\n",
+        wlan_plugin_address_to_string (NULL,
+                                       &pos->wlan_addr.mac,
+                                       sizeof (pos->wlan_addr)));
       return pos;
+    }
+  }
   pos = GNUNET_new (struct MacEndpoint);
-  pos->address = GNUNET_HELLO_address_copy (address);
+  pos->wlan_addr = (*mac);
   pos->plugin = plugin;
   pos->defrag =
     GNUNET_DEFRAGMENT_context_create (plugin->env->stats, WLAN_MTU,
@@ -1104,8 +1099,11 @@ create_macendpoint (struct Plugin *plugin,
   plugin->mac_count++;
   GNUNET_STATISTICS_update (plugin->env->stats, _("# WLAN MAC endpoints allocated"),
                            1, GNUNET_NO);
-  LOG (GNUNET_ERROR_TYPE_DEBUG, "New MAC endpoint `%s'\n",
-       wlan_plugin_address_to_string(NULL, address->address, address->address_length));
+  LOG (GNUNET_ERROR_TYPE_DEBUG,
+       "New MAC endpoint `%s'\n",
+       wlan_plugin_address_to_string (NULL,
+                                      &pos->wlan_addr,
+                                      sizeof (struct WlanAddress)));
   return pos;
 }
 
@@ -1151,9 +1149,11 @@ wlan_plugin_get_session (void *cls,
   LOG (GNUNET_ERROR_TYPE_DEBUG,
        "Service asked to create session for peer `%s' with MAC `%s'\n",
        GNUNET_i2s (&address->peer),
-       wlan_plugin_address_to_string(NULL, address->address, address->address_length));
-  endpoint = create_macendpoint (plugin, address);
-  return get_session (endpoint, &address->peer, GNUNET_NO);
+       wlan_plugin_address_to_string (NULL,
+                                      address->address,
+                                      address->address_length));
+  endpoint = create_macendpoint (plugin, (struct WlanAddress *) address->address);
+  return get_session (endpoint, &address->peer);
 }
 
 
@@ -1285,30 +1285,39 @@ process_data (void *cls, void *client, const struct GNUNET_MessageHeader *hdr)
   switch (ntohs (hdr->type))
   {
   case GNUNET_MESSAGE_TYPE_HELLO:
+
     if (GNUNET_OK !=
        GNUNET_HELLO_get_id ((const struct GNUNET_HELLO_Message *) hdr, &tmpsource))
     {
       GNUNET_break_op (0);
       break;
     }
+    if (NULL == mas->endpoint)
+    {
+      GNUNET_break (0);
+      break;
+    }
+
     LOG (GNUNET_ERROR_TYPE_DEBUG,
         "Processing %u bytes of HELLO from peer `%s' at MAC %s\n",
         (unsigned int) msize,
         GNUNET_i2s (&tmpsource),
-        wlan_plugin_address_to_string (NULL, mas->endpoint->address->address, mas->endpoint->address->address_length));
+        wlan_plugin_address_to_string (NULL,
+                                        &mas->endpoint->wlan_addr,
+                                        sizeof (mas->endpoint->wlan_addr)));
 
     GNUNET_STATISTICS_update (plugin->env->stats,
                              _("# HELLO messages received via WLAN"), 1,
                              GNUNET_NO);
 
+    address = GNUNET_HELLO_address_allocate (&tmpsource, PLUGIN_NAME,
+        &mas->endpoint->wlan_addr, sizeof (mas->endpoint->wlan_addr),
+        GNUNET_HELLO_ADDRESS_INFO_INBOUND);
     plugin->env->receive (plugin->env->cls,
-                          mas->endpoint->address,
-                          mas->session,
-                         hdr);
+        address, mas->session, hdr);
     plugin->env->update_address_metrics (plugin->env->cls,
-                                         mas->endpoint->address,
-                                        mas->session,
-                                        &ats, 1);
+        address, mas->session, &ats, 1);
+    GNUNET_HELLO_address_free (address);
     break;
   case GNUNET_MESSAGE_TYPE_FRAGMENT:
     if (NULL == mas->endpoint)
@@ -1319,8 +1328,9 @@ process_data (void *cls, void *client, const struct GNUNET_MessageHeader *hdr)
     LOG (GNUNET_ERROR_TYPE_DEBUG,
         "Processing %u bytes of FRAGMENT from MAC %s\n",
         (unsigned int) msize,
-        wlan_plugin_address_to_string (NULL, mas->endpoint->address->address,
-            mas->endpoint->address->address_length));
+        wlan_plugin_address_to_string (NULL,
+                                        &mas->endpoint->wlan_addr,
+                                        sizeof (mas->endpoint->wlan_addr)));
     GNUNET_STATISTICS_update (plugin->env->stats,
                               _("# fragments received via WLAN"), 1, GNUNET_NO);
     (void) GNUNET_DEFRAGMENT_process_fragment (mas->endpoint->defrag,
@@ -1341,8 +1351,9 @@ process_data (void *cls, void *client, const struct GNUNET_MessageHeader *hdr)
       {
         LOG (GNUNET_ERROR_TYPE_DEBUG,
             "Got last ACK, finished message transmission to `%s' (%p)\n",
-            wlan_plugin_address_to_string (NULL, mas->endpoint->address->address,
-                         mas->endpoint->address->address_length),
+             wlan_plugin_address_to_string (NULL,
+                                            &mas->endpoint->wlan_addr,
+                                            sizeof (mas->endpoint->wlan_addr)),
             fm);
        mas->endpoint->timeout = GNUNET_TIME_relative_to_absolute (MACENDPOINT_TIMEOUT);
        if (NULL != fm->cont)
@@ -1357,15 +1368,17 @@ process_data (void *cls, void *client, const struct GNUNET_MessageHeader *hdr)
       {
         LOG (GNUNET_ERROR_TYPE_DEBUG,
             "Got an ACK, message transmission to `%s' not yet finished\n",
-                  wlan_plugin_address_to_string (NULL, mas->endpoint->address->address,
-                                 mas->endpoint->address->address_length));
+             wlan_plugin_address_to_string (NULL,
+                                            &mas->endpoint->wlan_addr,
+                                            sizeof (mas->endpoint->wlan_addr)));
         break;
       }
     }
     LOG (GNUNET_ERROR_TYPE_DEBUG,
         "ACK not matched against any active fragmentation with MAC `%s'\n",
-         wlan_plugin_address_to_string (NULL, mas->endpoint->address->address,
-                       mas->endpoint->address->address_length));
+         wlan_plugin_address_to_string (NULL,
+                                        &mas->endpoint->wlan_addr,
+                                        sizeof (mas->endpoint->wlan_addr)));
     break;
   case GNUNET_MESSAGE_TYPE_WLAN_DATA:
     if (NULL == mas->endpoint)
@@ -1397,15 +1410,15 @@ process_data (void *cls, void *client, const struct GNUNET_MessageHeader *hdr)
       break;
     }
     xmas.endpoint = mas->endpoint;
-    if (NULL == (xmas.session = lookup_session (mas->endpoint, &wlanheader->sender, GNUNET_YES)))
+    if (NULL == (xmas.session = lookup_session (mas->endpoint, &wlanheader->sender)))
     {
-      xmas.session = create_session (mas->endpoint, &wlanheader->sender, GNUNET_YES);
+      xmas.session = create_session (mas->endpoint, &wlanheader->sender);
       address = GNUNET_HELLO_address_allocate (&wlanheader->sender, PLUGIN_NAME,
-          &mas->endpoint->address, sizeof (struct WlanAddress),
+          &mas->endpoint->wlan_addr, sizeof (struct WlanAddress),
           GNUNET_HELLO_ADDRESS_INFO_NONE);
       plugin->env->session_start (NULL, address, xmas.session, NULL, 0);
       LOG (GNUNET_ERROR_TYPE_DEBUG,
-          "Notifying transport about peer `%s''s new inbound session %p \n",
+          "Notifying transport about peer `%s''s new session %p \n",
           GNUNET_i2s (&wlanheader->sender), xmas.session);
       GNUNET_HELLO_address_free (address);
     }
@@ -1436,11 +1449,11 @@ process_data (void *cls, void *client, const struct GNUNET_MessageHeader *hdr)
         (unsigned int) ntohs (hdr->type),
         GNUNET_i2s (&mas->session->target));
     plugin->env->receive (plugin->env->cls,
-        mas->session->mac->address,
+        mas->session->address,
         mas->session,
         hdr);
     plugin->env->update_address_metrics (plugin->env->cls,
-        mas->session->mac->address,
+        mas->session->address,
         mas->session,
         &ats, 1);
     break;
@@ -1461,7 +1474,7 @@ handle_helper_message (void *cls, void *client,
                       const struct GNUNET_MessageHeader *hdr)
 {
   struct Plugin *plugin = cls;
-  struct GNUNET_HELLO_Address *address;
+  struct GNUNET_HELLO_Address *my_address;
   const struct GNUNET_TRANSPORT_WLAN_RadiotapReceiveMessage *rxinfo;
   const struct GNUNET_TRANSPORT_WLAN_HelperControlMessage *cm;
   struct WlanAddress wa;
@@ -1488,10 +1501,10 @@ handle_helper_message (void *cls, void *client,
       memset (&wa, 0, sizeof (struct WlanAddress));
       wa.mac = plugin->mac_address;
       wa.options = htonl(plugin->options);
-      address = GNUNET_HELLO_address_allocate (plugin->env->my_identity,
+      my_address = GNUNET_HELLO_address_allocate (plugin->env->my_identity,
           PLUGIN_NAME, &wa, sizeof (wa), GNUNET_HELLO_ADDRESS_INFO_NONE);
-      plugin->env->notify_address (plugin->env->cls, GNUNET_NO, address);
-      GNUNET_HELLO_address_free (address);
+      plugin->env->notify_address (plugin->env->cls, GNUNET_NO, my_address);
+      GNUNET_HELLO_address_free (my_address);
     }
     plugin->mac_address = cm->mac;
     plugin->have_mac = GNUNET_YES;
@@ -1499,15 +1512,15 @@ handle_helper_message (void *cls, void *client,
     memset (&wa, 0, sizeof (struct WlanAddress));
     wa.mac = plugin->mac_address;
     wa.options = htonl(plugin->options);
-    address = GNUNET_HELLO_address_allocate (plugin->env->my_identity,
+    my_address = GNUNET_HELLO_address_allocate (plugin->env->my_identity,
         PLUGIN_NAME, &wa, sizeof (wa), GNUNET_HELLO_ADDRESS_INFO_NONE);
 
     LOG (GNUNET_ERROR_TYPE_DEBUG,
         "Received WLAN_HELPER_CONTROL message with MAC address `%s' for peer `%s'\n",
         mac_to_string (&cm->mac),
         GNUNET_i2s (plugin->env->my_identity));
-    plugin->env->notify_address (plugin->env->cls, GNUNET_YES, address);
-    GNUNET_HELLO_address_free (address);
+    plugin->env->notify_address (plugin->env->cls, GNUNET_YES, my_address);
+    GNUNET_HELLO_address_free (my_address);
     break;
   case GNUNET_MESSAGE_TYPE_WLAN_DATA_FROM_HELPER:
     LOG (GNUNET_ERROR_TYPE_DEBUG,
@@ -1557,12 +1570,7 @@ handle_helper_message (void *cls, void *client,
         mac_to_string (&rxinfo->frame.addr2));
     wa.mac = rxinfo->frame.addr2;
     wa.options = htonl (0);
-    struct GNUNET_PeerIdentity dummy;
-    memset (&dummy, '\0', sizeof (dummy));
-    address = GNUNET_HELLO_address_allocate (&dummy, PLUGIN_NAME, &wa,
-        sizeof (struct WlanAddress), GNUNET_HELLO_ADDRESS_INFO_NONE);
-    mas.endpoint = create_macendpoint (plugin, address);
-    GNUNET_HELLO_address_free (address);
+    mas.endpoint = create_macendpoint (plugin, &wa);
     mas.session = NULL;
     (void) GNUNET_SERVER_mst_receive (plugin->helper_payload_tokenizer,
                                      &mas,
@@ -1638,8 +1646,8 @@ send_hello_beacon (void *cls,
  *
  * @param cls closure
  * @param addr pointer to the address
- * @param addrlen length of addr
- * @return GNUNET_OK if this is a plausible address for this peer
+ * @param addrlen length of @a addr
+ * @return #GNUNET_OK if this is a plausible address for this peer
  *         and transport
  */
 static int
@@ -1685,7 +1693,9 @@ wlan_plugin_address_suggested (void *cls, const void *addr, size_t addrlen)
  * @return string representing the same address
  */
 static const char *
-wlan_plugin_address_to_string (void *cls, const void *addr, size_t addrlen)
+wlan_plugin_address_to_string (void *cls,
+                               const void *addr,
+                               size_t addrlen)
 {
   const struct GNUNET_TRANSPORT_WLAN_MacAddress *mac;
   static char macstr[36];
@@ -1696,9 +1706,12 @@ wlan_plugin_address_to_string (void *cls, const void *addr, size_t addrlen)
     return NULL;
   }
   mac = &((struct WlanAddress *) addr)->mac;
-  GNUNET_snprintf (macstr, sizeof (macstr), "%s.%u.%s",
-               PLUGIN_NAME, ntohl (((struct WlanAddress *) addr)->options),
-               mac_to_string (mac));
+  GNUNET_snprintf (macstr,
+                   sizeof (macstr),
+                   "%s.%u.%s",
+                   PLUGIN_NAME,
+                   ntohl (((struct WlanAddress *) addr)->options),
+                   mac_to_string (mac));
   return macstr;
 }
 
@@ -1714,30 +1727,30 @@ wlan_plugin_address_to_string (void *cls, const void *addr, size_t addrlen)
  * @param numeric should (IP) addresses be displayed in numeric form?
  * @param timeout after how long should we give up?
  * @param asc function to call on each string
- * @param asc_cls closure for asc
+ * @param asc_cls closure for @a asc
  */
 static void
-wlan_plugin_address_pretty_printer (void *cls, const char *type,
-                                    const void *addr, size_t addrlen,
+wlan_plugin_address_pretty_printer (void *cls,
+                                    const char *type,
+                                    const void *addr,
+                                    size_t addrlen,
                                     int numeric,
                                     struct GNUNET_TIME_Relative timeout,
                                     GNUNET_TRANSPORT_AddressStringCallback asc,
                                     void *asc_cls)
 {
-  char *ret;
+  const char *ret;
 
-  if (sizeof (struct WlanAddress) != addrlen)
-  {
-    /* invalid address  */
-    LOG (GNUNET_ERROR_TYPE_WARNING,
-        _("WLAN address with invalid size encountered\n"));
-    asc (asc_cls, NULL);
-    return;
-  }
-  ret = GNUNET_strdup (wlan_plugin_address_to_string(NULL, addr, addrlen));
-  asc (asc_cls, ret);
-  GNUNET_free (ret);
-  asc (asc_cls, NULL);
+  if (sizeof (struct WlanAddress) == addrlen)
+    ret = wlan_plugin_address_to_string (NULL,
+                                         addr,
+                                         addrlen);
+  else
+    ret = NULL;
+  asc (asc_cls,
+       ret,
+       (NULL == ret) ? GNUNET_SYSERR : GNUNET_OK);
+  asc (asc_cls, NULL, GNUNET_OK);
 }
 
 
@@ -1819,13 +1832,13 @@ libgnunet_plugin_transport_wlan_done (void *cls)
  * Function called to convert a string address to
  * a binary address.
  *
- * @param cls closure ('struct Plugin*')
+ * @param cls closure (`struct Plugin *`)
  * @param addr string address
  * @param addrlen length of the address
  * @param buf location to store the buffer
  * @param added location to store the number of bytes in the buffer.
- *        If the function returns GNUNET_SYSERR, its contents are undefined.
- * @return GNUNET_OK on success, GNUNET_SYSERR on failure
+ *        If the function returns #GNUNET_SYSERR, its contents are undefined.
+ * @return #GNUNET_OK on success, #GNUNET_SYSERR on failure
  */
 static int
 wlan_string_to_address (void *cls, const char *addr, uint16_t addrlen,
@@ -1953,7 +1966,7 @@ libgnunet_plugin_transport_wlan_init (void *cls)
                          0, GNUNET_NO);
   GNUNET_STATISTICS_set (plugin->env->stats, _("# WLAN MAC endpoints allocated"),
                          0, 0);
-  GNUNET_BANDWIDTH_tracker_init (&plugin->tracker,
+  GNUNET_BANDWIDTH_tracker_init (&plugin->tracker, NULL, NULL,
                                  GNUNET_BANDWIDTH_value_init (100 * 1024 *
                                                               1024 / 8), 100);
   plugin->fragment_data_tokenizer = GNUNET_SERVER_mst_create (&process_data, plugin);