wip
[oweals/gnunet.git] / src / transport / plugin_transport_udp.c
index d371067783f1d152ea5777e5f19008321efbd33c..26644bdd34e86f00161aa690f4670de98a73ca5a 100644 (file)
 #include "gnunet_protocols.h"
 #include "gnunet_resolver_service.h"
 #include "gnunet_server_lib.h"
-#include "gnunet_service_lib.h"
 #include "gnunet_signatures.h"
 #include "gnunet_statistics_service.h"
 #include "gnunet_transport_service.h"
-#include "plugin_transport.h"
+#include "gnunet_transport_plugin.h"
 #include "transport.h"
 
 #define DEBUG_UDP GNUNET_YES
@@ -217,7 +216,7 @@ struct UDP_NAT_ProbeMessageConfirmation
  */
 struct LocalAddrList
 {
-  
+
   /**
    * This is a doubly linked list.
    */
@@ -334,12 +333,12 @@ struct UDP_NAT_Probes
 struct UDP_Sock_Info
 {
   /**
-   * The network handle 
+   * The network handle
    */
   struct GNUNET_NETWORK_Handle *desc;
 
   /**
-   * The port we bound to 
+   * The port we bound to
    */
   uint16_t port;
 };
@@ -355,11 +354,6 @@ struct Plugin
    */
   struct GNUNET_TRANSPORT_PluginEnvironment *env;
 
-  /**
-   * Handle to the network service.
-   */
-  struct GNUNET_SERVICE_Context *service;
-
   /*
    * Session of peers with whom we are currently connected
    */
@@ -410,10 +404,10 @@ struct Plugin
    * List of our IP addresses.
    */
   struct LocalAddrList *lal_head;
-  
+
   /**
    * Tail of our IP address list.
-   */ 
+   */
   struct LocalAddrList *lal_tail;
 
   /**
@@ -471,7 +465,7 @@ struct Plugin
   /**
    * The process id of the server process (if behind NAT)
    */
-  pid_t server_pid;
+  struct GNUNET_OS_Process *server_proc;
 
 };
 
@@ -513,7 +507,7 @@ udp_transport_server_stop (void *cls)
 
   if (plugin->select_task != GNUNET_SCHEDULER_NO_TASK)
     {
-      GNUNET_SCHEDULER_cancel (plugin->env->sched, plugin->select_task);
+      GNUNET_SCHEDULER_cancel (plugin->select_task);
       plugin->select_task = GNUNET_SCHEDULER_NO_TASK;
     }
   if (plugin->udp_sockv4.desc != NULL)
@@ -528,16 +522,18 @@ udp_transport_server_stop (void *cls)
     }
   if (plugin->behind_nat == GNUNET_YES)
     {
-      if (0 != PLIBC_KILL (plugin->server_pid, SIGTERM))
+      if (0 != GNUNET_OS_process_kill (plugin->server_proc, SIGTERM))
        GNUNET_log_strerror (GNUNET_ERROR_TYPE_WARNING, "kill");
-      GNUNET_OS_process_wait (plugin->server_pid);
+      GNUNET_OS_process_wait (plugin->server_proc);
+      GNUNET_OS_process_close (plugin->server_proc);
+      plugin->server_proc = NULL;
     }
   return GNUNET_OK;
 }
 
 
 struct PeerSession *
-find_session (struct Plugin *plugin, 
+find_session (struct Plugin *plugin,
              const struct GNUNET_PeerIdentity *peer)
 {
   struct PeerSession *pos;
@@ -666,10 +662,12 @@ udp_real_send (void *cls,
     GNUNET_NETWORK_socket_sendto (send_handle, message, ssize,
                                   sb,
                                   sbs);
+  if (GNUNET_SYSERR == sent)
+    GNUNET_log_strerror(GNUNET_ERROR_TYPE_DEBUG, "sendto");
   GNUNET_log (GNUNET_ERROR_TYPE_INFO,
              "UDP transmit %u-byte message to %s (%d: %s)\n",
              (unsigned int) ssize,
-             GNUNET_a2s (sb, sbs), 
+             GNUNET_a2s (sb, sbs),
              (int) sent,
              (sent < 0) ? STRERROR (errno) : "ok");
   if (cont != NULL)
@@ -700,7 +698,7 @@ run_gnunet_nat_client (struct Plugin *plugin, const char *addr, size_t addrlen)
   char addr_buf[INET_ADDRSTRLEN];
   char *address_as_string;
   char *port_as_string;
-  pid_t pid;
+  struct GNUNET_OS_Process *proc;
   const struct IPv4UdpAddress *t4;
 
   GNUNET_assert(addrlen == sizeof(struct IPv4UdpAddress));
@@ -721,10 +719,15 @@ run_gnunet_nat_client (struct Plugin *plugin, const char *addr, size_t addrlen)
 #endif
 
   /* Start the server process */
-  pid = GNUNET_OS_start_process(NULL, NULL, "gnunet-nat-client", "gnunet-nat-client", plugin->external_address, address_as_string, port_as_string, NULL);
+  proc = GNUNET_OS_start_process (NULL, NULL, "gnunet-nat-client", "gnunet-nat-client", plugin->external_address, address_as_string, port_as_string, NULL);
   GNUNET_free(address_as_string);
   GNUNET_free(port_as_string);
-  GNUNET_OS_process_wait (pid);
+  if (proc != NULL)
+    {
+      GNUNET_OS_process_wait (proc);
+      GNUNET_OS_process_close (proc);
+      proc = NULL;
+    }
 }
 
 /**
@@ -833,7 +836,7 @@ udp_plugin_send (void *cls,
                                   target,
                                   msgbuf, msgbuf_size,
                                   priority, timeout,
-                                  peer_session->connect_addr, peer_session->connect_alen, 
+                                  peer_session->connect_addr, peer_session->connect_alen,
                                   cont, cont_cls);
             }
           else /* Haven't gotten a response from this peer, queue message */
@@ -852,11 +855,11 @@ udp_plugin_send (void *cls,
     }
   else if (other_peer_natd == GNUNET_NO) /* Other peer not behind a NAT, so we can just send the message as is */
     {
-      sent = udp_real_send(cls, 
-                          (addrlen == sizeof (struct IPv4UdpAddress)) ? plugin->udp_sockv4.desc : plugin->udp_sockv6.desc, 
+      sent = udp_real_send(cls,
+                          (addrlen == sizeof (struct IPv4UdpAddress)) ? plugin->udp_sockv4.desc : plugin->udp_sockv6.desc,
                           target,
                           msgbuf, msgbuf_size,
-                          priority, timeout, addr, addrlen, 
+                          priority, timeout, addr, addrlen,
                           cont, cont_cls);
     }
   else /* Other peer is NAT'd, but we don't want to play with them (or can't!) */
@@ -978,7 +981,8 @@ process_interfaces (void *cls,
               &((struct sockaddr_in6 *) addr)->sin6_addr,
               sizeof (struct in6_addr));
       GNUNET_assert(NULL != inet_ntop(AF_INET6, &t6.ipv6_addr, &buf[0], INET6_ADDRSTRLEN));
-      if ((plugin->bind_address != NULL) || ((plugin->bind6_address != NULL) && (0 != strcmp(buf, plugin->bind_address))))
+      if (((plugin->bind_address != NULL) && (0 != strcmp(buf, plugin->bind_address)))
+          || ((plugin->bind6_address != NULL) && (0 != strcmp(buf, plugin->bind6_address))))
         {
           GNUNET_log(GNUNET_ERROR_TYPE_DEBUG, "%s: Not notifying transport of address %s\n", "UDP", GNUNET_a2s (addr, addrlen));
           return GNUNET_OK;
@@ -1008,12 +1012,12 @@ process_interfaces (void *cls,
       GNUNET_break (0);
       return GNUNET_OK;
     }
-  
+
   GNUNET_log (GNUNET_ERROR_TYPE_INFO |
              GNUNET_ERROR_TYPE_BULK,
              _("Found address `%s' (%s)\n"),
              GNUNET_a2s (addr, addrlen), name);
-  
+
   if (addr_nat != NULL)
     {
       plugin->env->notify_address (plugin->env->cls,
@@ -1083,11 +1087,11 @@ send_udp_probe_message (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc
                       _("Sending a probe to port %d\n"), ntohs(probe->addr.u_port));
 #endif
   probe->count++;
-  udp_real_send(plugin, 
-               plugin->udp_sockv4.desc, 
+  udp_real_send(plugin,
+               plugin->udp_sockv4.desc,
                NULL,
-               (char *)&message, ntohs(message.header.size), 0, 
-               GNUNET_TIME_relative_get_unit(), 
+               (char *)&message, ntohs(message.header.size), 0,
+               GNUNET_TIME_relative_get_unit(),
                &probe->addr, sizeof(struct IPv4UdpAddress),
                &udp_probe_continuation, probe);
 }
@@ -1102,7 +1106,7 @@ void
 udp_probe_continuation (void *cls, const struct GNUNET_PeerIdentity *target, int result)
 {
   struct UDP_NAT_Probes *probe = cls;
-  struct Plugin *plugin = probe->plugin;
+  /*struct Plugin *plugin = probe->plugin;*/
 
   if ((result == GNUNET_OK) && (probe->count < MAX_PROBES))
     {
@@ -1110,7 +1114,7 @@ udp_probe_continuation (void *cls, const struct GNUNET_PeerIdentity *target, int
       GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                        _("Scheduling next probe for 10000 milliseconds\n"));
 #endif
-      probe->task = GNUNET_SCHEDULER_add_delayed(plugin->env->sched, GNUNET_TIME_relative_multiply(GNUNET_TIME_UNIT_MILLISECONDS, 10000), &send_udp_probe_message, probe);
+      probe->task = GNUNET_SCHEDULER_add_delayed(GNUNET_TIME_relative_multiply(GNUNET_TIME_UNIT_MILLISECONDS, 10000), &send_udp_probe_message, probe);
     }
   else /* Destroy the probe context. */
     {
@@ -1163,7 +1167,7 @@ udp_plugin_server_read (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc
   char *port_start;
   struct IPv4UdpAddress a4;
 
-  if (tc->reason == GNUNET_SCHEDULER_REASON_SHUTDOWN)
+  if ( (tc->reason & GNUNET_SCHEDULER_REASON_SHUTDOWN) != 0)
     return;
 
   bytes = GNUNET_DISK_file_read(plugin->server_stdout_handle, &mybuf, sizeof(mybuf));
@@ -1177,7 +1181,6 @@ udp_plugin_server_read (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc
       return;
     }
 
-  port = 0;
   port_start = NULL;
   for (i = 0; i < sizeof(mybuf); i++)
     {
@@ -1196,8 +1199,7 @@ udp_plugin_server_read (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc
   else
     {
       plugin->server_read_task =
-           GNUNET_SCHEDULER_add_read_file (plugin->env->sched,
-                                           GNUNET_TIME_UNIT_FOREVER_REL,
+           GNUNET_SCHEDULER_add_read_file (GNUNET_TIME_UNIT_FOREVER_REL,
                                            plugin->server_stdout_handle, &udp_plugin_server_read, plugin);
       return;
     }
@@ -1218,8 +1220,7 @@ udp_plugin_server_read (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc
                   _("nat-server-read malformed address\n"), &mybuf, port);
 
       plugin->server_read_task =
-          GNUNET_SCHEDULER_add_read_file (plugin->env->sched,
-                                          GNUNET_TIME_UNIT_FOREVER_REL,
+          GNUNET_SCHEDULER_add_read_file (GNUNET_TIME_UNIT_FOREVER_REL,
                                           plugin->server_stdout_handle, &udp_plugin_server_read, plugin);
       return;
     }
@@ -1234,13 +1235,12 @@ udp_plugin_server_read (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc
       temp_probe->addr.u_port = htons(port);
       temp_probe->next = plugin->probes;
       temp_probe->plugin = plugin;
-      temp_probe->task = GNUNET_SCHEDULER_add_delayed(plugin->env->sched, GNUNET_TIME_relative_multiply(GNUNET_TIME_UNIT_MILLISECONDS, 500), &send_udp_probe_message, temp_probe);
+      temp_probe->task = GNUNET_SCHEDULER_add_delayed(GNUNET_TIME_relative_multiply(GNUNET_TIME_UNIT_MILLISECONDS, 500), &send_udp_probe_message, temp_probe);
       plugin->probes = temp_probe;
     }
 
   plugin->server_read_task =
-       GNUNET_SCHEDULER_add_read_file (plugin->env->sched,
-                                       GNUNET_TIME_UNIT_FOREVER_REL,
+       GNUNET_SCHEDULER_add_read_file (GNUNET_TIME_UNIT_FOREVER_REL,
                                        plugin->server_stdout_handle, &udp_plugin_server_read, plugin);
 
 }
@@ -1257,14 +1257,14 @@ udp_plugin_server_read (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc
  * @param sockinfo which socket did we receive the message on
  */
 static void
-udp_demultiplexer(struct Plugin *plugin, struct GNUNET_PeerIdentity *sender,
+udp_demultiplexer(struct Plugin *plugin, 
+                 struct GNUNET_PeerIdentity *sender,
                   const struct GNUNET_MessageHeader *currhdr,
                   const void *sender_addr,
                   size_t fromlen, struct UDP_Sock_Info *sockinfo)
 {
   struct UDP_NAT_ProbeMessageReply *outgoing_probe_reply;
   struct UDP_NAT_ProbeMessageConfirmation *outgoing_probe_confirmation;
-
   char addr_buf[INET_ADDRSTRLEN];
   struct UDP_NAT_Probes *outgoing_probe;
   struct PeerSession *peer_session;
@@ -1329,7 +1329,7 @@ udp_demultiplexer(struct Plugin *plugin, struct GNUNET_PeerIdentity *sender,
       if (fromlen == sizeof(struct IPv4UdpAddress))
         {
           memset(&addr_buf, 0, sizeof(addr_buf));
-          if (NULL == inet_ntop (AF_INET, 
+          if (NULL == inet_ntop (AF_INET,
                                 &((struct IPv4UdpAddress *) sender_addr)->ipv4_addr, addr_buf,
                                 INET_ADDRSTRLEN))
            {
@@ -1346,15 +1346,15 @@ udp_demultiplexer(struct Plugin *plugin, struct GNUNET_PeerIdentity *sender,
               outgoing_probe_confirmation = GNUNET_malloc(sizeof(struct UDP_NAT_ProbeMessageConfirmation));
               outgoing_probe_confirmation->header.size = htons(sizeof(struct UDP_NAT_ProbeMessageConfirmation));
               outgoing_probe_confirmation->header.type = htons(GNUNET_MESSAGE_TYPE_TRANSPORT_UDP_NAT_PROBE_CONFIRM);
-              udp_real_send(plugin, sockinfo->desc, NULL, 
-                           (char *)outgoing_probe_confirmation, 
-                           ntohs(outgoing_probe_confirmation->header.size), 0, 
-                           GNUNET_TIME_relative_get_unit(), 
+              udp_real_send(plugin, sockinfo->desc, NULL,
+                           (char *)outgoing_probe_confirmation,
+                           ntohs(outgoing_probe_confirmation->header.size), 0,
+                           GNUNET_TIME_relative_get_unit(),
                            sender_addr, fromlen, NULL, NULL);
 
               if (outgoing_probe->task != GNUNET_SCHEDULER_NO_TASK)
                 {
-                  GNUNET_SCHEDULER_cancel(plugin->env->sched, outgoing_probe->task);
+                  GNUNET_SCHEDULER_cancel(outgoing_probe->task);
                   outgoing_probe->task = GNUNET_SCHEDULER_NO_TASK;
                   /* Schedule task to timeout and remove probe if confirmation not received */
                 }
@@ -1476,7 +1476,14 @@ udp_demultiplexer(struct Plugin *plugin, struct GNUNET_PeerIdentity *sender,
                   "Sending message type %d to transport!\n",
                   ntohs(currhdr->type));
 #endif
-      plugin->env->receive (plugin->env->cls, sender, currhdr, UDP_DIRECT_DISTANCE, 
+      struct GNUNET_TRANSPORT_ATS_Information distance[2];
+      distance[0].type = htonl (GNUNET_TRANSPORT_ATS_QUALITY_NET_DISTANCE);
+      distance[0].value = htonl (UDP_DIRECT_DISTANCE);
+      distance[1].type = htonl (GNUNET_TRANSPORT_ATS_ARRAY_TERMINATOR);
+      distance[1].value = htonl (0);
+
+      plugin->env->receive (plugin->env->cls, sender, currhdr,
+                   (const struct GNUNET_TRANSPORT_ATS_Information *) &distance, 2,
                            NULL, sender_addr, fromlen);
   }
 
@@ -1504,7 +1511,6 @@ udp_plugin_select (void *cls,
   char addr[32];
   ssize_t ret;
   int offset;
-  int count;
   int tsize;
   char *msgbuf;
   const struct GNUNET_MessageHeader *currhdr;
@@ -1515,9 +1521,10 @@ udp_plugin_select (void *cls,
   const void *ca;
   size_t calen;
   struct UDP_Sock_Info *udp_sock;
+  uint16_t csize;
 
   plugin->select_task = GNUNET_SCHEDULER_NO_TASK;
-  if (tc->reason == GNUNET_SCHEDULER_REASON_SHUTDOWN)
+  if ( (tc->reason & GNUNET_SCHEDULER_REASON_SHUTDOWN) != 0)
     return;
   udp_sock = NULL;
   if (GNUNET_NETWORK_fdset_isset (tc->read_ready,
@@ -1565,20 +1572,20 @@ udp_plugin_select (void *cls,
     {
       GNUNET_break_op (0);
       plugin->select_task =
-       GNUNET_SCHEDULER_add_select (plugin->env->sched,
-                                    GNUNET_SCHEDULER_PRIORITY_DEFAULT,
+       GNUNET_SCHEDULER_add_select (GNUNET_SCHEDULER_PRIORITY_DEFAULT,
                                     GNUNET_SCHEDULER_NO_TASK,
                                     GNUNET_TIME_UNIT_FOREVER_REL, plugin->rs,
                                     NULL, &udp_plugin_select, plugin);
       return;
     }
   msg = (struct UDPMessage *) buf;
-  if (ntohs (msg->header.size) < sizeof (struct UDPMessage))
+  csize = ntohs (msg->header.size);
+  if ( (csize < sizeof (struct UDPMessage)) ||
+       (csize > ret) )
     {
       GNUNET_break_op (0);
       plugin->select_task =
-       GNUNET_SCHEDULER_add_select (plugin->env->sched,
-                                    GNUNET_SCHEDULER_PRIORITY_DEFAULT,
+       GNUNET_SCHEDULER_add_select (GNUNET_SCHEDULER_PRIORITY_DEFAULT,
                                     GNUNET_SCHEDULER_NO_TASK,
                                     GNUNET_TIME_UNIT_FOREVER_REL, plugin->rs,
                                     NULL, &udp_plugin_select, plugin);
@@ -1587,18 +1594,23 @@ udp_plugin_select (void *cls,
   msgbuf = (char *)&msg[1];
   memcpy (&sender, &msg->sender, sizeof (struct GNUNET_PeerIdentity));
   offset = 0;
-  count = 0;
-  tsize = ntohs (msg->header.size) - sizeof(struct UDPMessage);
-  while (offset < tsize)
+  tsize = csize - sizeof (struct UDPMessage);
+  while (offset + sizeof (struct GNUNET_MessageHeader) <= tsize)
     {
       currhdr = (struct GNUNET_MessageHeader *)&msgbuf[offset];
-      udp_demultiplexer(plugin, &sender, currhdr, ca, calen, udp_sock);
-      offset += ntohs(currhdr->size);
-      count++;
+      csize = ntohs (currhdr->size);
+      if ( (csize < sizeof (struct GNUNET_MessageHeader)) ||
+          (csize > tsize - offset) )
+       {
+         GNUNET_break_op (0);
+         break;
+       }
+      udp_demultiplexer(plugin, &sender, currhdr, 
+                       ca, calen, udp_sock);
+      offset += csize;
     }
   plugin->select_task =
-    GNUNET_SCHEDULER_add_select (plugin->env->sched,
-                                 GNUNET_SCHEDULER_PRIORITY_DEFAULT,
+    GNUNET_SCHEDULER_add_select (GNUNET_SCHEDULER_PRIORITY_DEFAULT,
                                  GNUNET_SCHEDULER_NO_TASK,
                                  GNUNET_TIME_UNIT_FOREVER_REL, plugin->rs,
                                  NULL, &udp_plugin_select, plugin);
@@ -1627,7 +1639,7 @@ udp_transport_server_start (void *cls)
   if (plugin->behind_nat == GNUNET_YES)
     {
       /* Pipe to read from started processes stdout (on read end) */
-      plugin->server_stdout = GNUNET_DISK_pipe(GNUNET_YES);
+      plugin->server_stdout = GNUNET_DISK_pipe(GNUNET_YES, GNUNET_NO, GNUNET_YES);
       if (plugin->server_stdout == NULL)
         return sockets_created;
 #if DEBUG_UDP
@@ -1637,12 +1649,12 @@ udp_transport_server_start (void *cls)
                   plugin->internal_address);
 #endif
       /* Start the server process */
-      plugin->server_pid = GNUNET_OS_start_process(NULL, 
-                                                  plugin->server_stdout, 
-                                                  "gnunet-nat-server", 
-                                                  "gnunet-nat-server", 
+      plugin->server_proc = GNUNET_OS_start_process(NULL,
+                                                  plugin->server_stdout,
+                                                  "gnunet-nat-server",
+                                                  "gnunet-nat-server",
                                                   plugin->internal_address, NULL);
-      if (plugin->server_pid == GNUNET_SYSERR)
+      if (plugin->server_proc == NULL)
         {
 #if DEBUG_UDP
           GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
@@ -1652,11 +1664,10 @@ udp_transport_server_start (void *cls)
         }
       /* Close the write end of the read pipe */
       GNUNET_DISK_pipe_close_end(plugin->server_stdout, GNUNET_DISK_PIPE_END_WRITE);
-      
+
       plugin->server_stdout_handle = GNUNET_DISK_pipe_handle(plugin->server_stdout, GNUNET_DISK_PIPE_END_READ);
       plugin->server_read_task =
-       GNUNET_SCHEDULER_add_read_file (plugin->env->sched,
-                                       GNUNET_TIME_UNIT_FOREVER_REL,
+       GNUNET_SCHEDULER_add_read_file (GNUNET_TIME_UNIT_FOREVER_REL,
                                        plugin->server_stdout_handle, &udp_plugin_server_read, plugin);
     }
 
@@ -1689,7 +1700,7 @@ udp_transport_server_start (void *cls)
           serverAddr = (struct sockaddr *) &serverAddrv6;
 #if DEBUG_UDP
          GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                          "Binding to IPv6 port %d\n", 
+                          "Binding to IPv6 port %d\n",
                           ntohs(serverAddrv6.sin6_port));
 #endif
          tries = 0;
@@ -1699,7 +1710,7 @@ udp_transport_server_start (void *cls)
              serverAddrv6.sin6_port = htons (GNUNET_CRYPTO_random_u32(GNUNET_CRYPTO_QUALITY_STRONG, 33537) + 32000); /* Find a good, non-root port */
 #if DEBUG_UDP
              GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                              "IPv6 Binding failed, trying new port %d\n", 
+                              "IPv6 Binding failed, trying new port %d\n",
                               ntohs(serverAddrv6.sin6_port));
 #endif
              tries++;
@@ -1708,7 +1719,7 @@ udp_transport_server_start (void *cls)
                  GNUNET_NETWORK_socket_close (plugin->udp_sockv6.desc);
                  plugin->udp_sockv6.desc = NULL;
                  break;
-               }             
+               }       
            }
          if (plugin->udp_sockv6.desc != NULL)
            {
@@ -1741,7 +1752,7 @@ udp_transport_server_start (void *cls)
       serverAddr = (struct sockaddr *) &serverAddrv4;
 #if DEBUG_UDP
       GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                      "Binding to IPv4 port %d\n", 
+                      "Binding to IPv4 port %d\n",
                       ntohs(serverAddrv4.sin_port));
 #endif
       tries = 0;
@@ -1751,7 +1762,7 @@ udp_transport_server_start (void *cls)
          serverAddrv4.sin_port = htons (GNUNET_CRYPTO_random_u32(GNUNET_CRYPTO_QUALITY_STRONG, 33537) + 32000); /* Find a good, non-root port */
 #if DEBUG_UDP
          GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                          "IPv4 Binding failed, trying new port %d\n", 
+                          "IPv4 Binding failed, trying new port %d\n",
                           ntohs(serverAddrv4.sin_port));
 #endif
          tries++;
@@ -1760,7 +1771,7 @@ udp_transport_server_start (void *cls)
              GNUNET_NETWORK_socket_close (plugin->udp_sockv4.desc);
              plugin->udp_sockv4.desc = NULL;
              break;
-           }         
+           }   
        }
       if (plugin->udp_sockv4.desc != NULL)
        {
@@ -1772,15 +1783,14 @@ udp_transport_server_start (void *cls)
   plugin->rs = GNUNET_NETWORK_fdset_create ();
   GNUNET_NETWORK_fdset_zero (plugin->rs);
   if (NULL != plugin->udp_sockv4.desc)
-    GNUNET_NETWORK_fdset_set (plugin->rs, 
+    GNUNET_NETWORK_fdset_set (plugin->rs,
                              plugin->udp_sockv4.desc);
   if (NULL != plugin->udp_sockv6.desc)
-    GNUNET_NETWORK_fdset_set (plugin->rs, 
+    GNUNET_NETWORK_fdset_set (plugin->rs,
                              plugin->udp_sockv6.desc);
 
   plugin->select_task =
-    GNUNET_SCHEDULER_add_select (plugin->env->sched,
-                                 GNUNET_SCHEDULER_PRIORITY_DEFAULT,
+    GNUNET_SCHEDULER_add_select (GNUNET_SCHEDULER_PRIORITY_DEFAULT,
                                  GNUNET_SCHEDULER_NO_TASK,
                                  GNUNET_TIME_UNIT_FOREVER_REL, plugin->rs,
                                  NULL, &udp_plugin_select, plugin);
@@ -1806,7 +1816,7 @@ check_port (struct Plugin *plugin, uint16_t in_port)
   if ( (plugin->only_nat_addresses == GNUNET_YES) &&
        (plugin->behind_nat == GNUNET_YES) )
     return GNUNET_SYSERR; /* odd case... */
-  if (in_port == plugin->port) 
+  if (in_port == plugin->port)
     return GNUNET_OK;
   return GNUNET_SYSERR;
 }
@@ -1829,8 +1839,8 @@ check_port (struct Plugin *plugin, uint16_t in_port)
  *
  */
 static int
-udp_check_address (void *cls, 
-                  const void *addr, 
+udp_check_address (void *cls,
+                  const void *addr,
                   size_t addrlen)
 {
   struct Plugin *plugin = cls;
@@ -1873,7 +1883,7 @@ udp_check_address (void *cls,
          GNUNET_break_op (0);
          return GNUNET_SYSERR;
        }
-      if (GNUNET_OK != 
+      if (GNUNET_OK !=
          check_port (plugin, ntohs (v6->u6_port)))
        return GNUNET_SYSERR;
       if (GNUNET_OK !=
@@ -1944,12 +1954,40 @@ udp_plugin_address_pretty_printer (void *cls,
                                    void *asc_cls)
 {
   struct Plugin *plugin = cls;
-  const struct sockaddr_in *v4;
-  const struct sockaddr_in6 *v6;
   struct PrettyPrinterContext *ppc;
+  const void *sb;
+  size_t sbs;
+  struct sockaddr_in a4;
+  struct sockaddr_in6 a6;
+  const struct IPv4UdpAddress *u4;
+  const struct IPv6UdpAddress *u6;
+  uint16_t port;
 
-  if ((addrlen != sizeof (struct sockaddr_in)) &&
-      (addrlen != sizeof (struct sockaddr_in6)))
+  if (addrlen == sizeof (struct IPv6UdpAddress))
+    {
+      u6 = addr;
+      memset (&a6, 0, sizeof (a6));
+      a6.sin6_family = AF_INET6;
+      a6.sin6_port = u6->u6_port;
+      memcpy (&a6.sin6_addr,
+              &u6->ipv6_addr,
+              sizeof (struct in6_addr));
+      port = ntohs (u6->u6_port);
+      sb = &a6;
+      sbs = sizeof (a6);
+    }
+  else if (addrlen == sizeof (struct IPv4UdpAddress))
+    {
+      u4 = addr;
+      memset (&a4, 0, sizeof (a4));
+      a4.sin_family = AF_INET;
+      a4.sin_port = u4->u_port;
+      a4.sin_addr.s_addr = u4->ipv4_addr;
+      port = ntohs (u4->u_port);
+      sb = &a4;
+      sbs = sizeof (a4);
+    }
+  else
     {
       /* invalid address */
       GNUNET_break_op (0);
@@ -1959,21 +1997,10 @@ udp_plugin_address_pretty_printer (void *cls,
   ppc = GNUNET_malloc (sizeof (struct PrettyPrinterContext));
   ppc->asc = asc;
   ppc->asc_cls = asc_cls;
-  if (addrlen == sizeof (struct sockaddr_in))
-    {
-      v4 = (const struct sockaddr_in *) addr;
-      ppc->port = ntohs (v4->sin_port);
-    }
-  else
-    {
-      v6 = (const struct sockaddr_in6 *) addr;
-      ppc->port = ntohs (v6->sin6_port);
-
-    }
-  GNUNET_RESOLVER_hostname_get (plugin->env->sched,
-                                plugin->env->cfg,
-                                addr,
-                                addrlen,
+  ppc->port = port;
+  GNUNET_RESOLVER_hostname_get (plugin->env->cfg,
+                                sb,
+                                sbs,
                                 !numeric, timeout, &append_port, ppc);
 }
 
@@ -1999,7 +2026,7 @@ get_path_from_PATH (char *binary)
   buf = GNUNET_malloc (strlen (path) + 20);
   pos = path;
 
-  while (NULL != (end = strchr (pos, ':')))
+  while (NULL != (end = strchr (pos, PATH_SEPARATOR)))
     {
       *end = '\0';
       sprintf (buf, "%s/%s", pos, binary);
@@ -2033,8 +2060,18 @@ check_gnunet_nat_binary(char *binary)
 {
   struct stat statbuf;
   char *p;
+#ifdef MINGW
+  SOCKET rawsock;
+#endif
 
+#ifdef MINGW
+  char *binaryexe;
+  GNUNET_asprintf (&binaryexe, "%s.exe", binary);
+  p = get_path_from_PATH (binaryexe);
+  free (binaryexe);
+#else
   p = get_path_from_PATH (binary);
+#endif
   if (p == NULL)
     return GNUNET_NO;
   if (0 != STAT (p, &statbuf))
@@ -2043,10 +2080,22 @@ check_gnunet_nat_binary(char *binary)
       return GNUNET_SYSERR;
     }
   GNUNET_free (p);
+#ifndef MINGW
   if ( (0 != (statbuf.st_mode & S_ISUID)) &&
        (statbuf.st_uid == 0) )
     return GNUNET_YES;
   return GNUNET_NO;
+#else
+  rawsock = socket (AF_INET, SOCK_RAW, IPPROTO_ICMP);
+  if (INVALID_SOCKET == rawsock)
+  {
+    DWORD err = GetLastError ();
+    GNUNET_log (GNUNET_ERROR_TYPE_WARNING, "socket (AF_INET, SOCK_RAW, IPPROTO_ICMP) have failed! GLE = %d\n", err);
+    return GNUNET_NO; /* not running as administrator */
+  }
+  closesocket (rawsock);
+  return GNUNET_YES;
+#endif
 }
 
 /**
@@ -2114,7 +2163,6 @@ libgnunet_plugin_transport_udp_init (void *cls)
   unsigned long long port;
   struct GNUNET_TRANSPORT_PluginFunctions *api;
   struct Plugin *plugin;
-  struct GNUNET_SERVICE_Context *service;
   int sockets_created;
   int behind_nat;
   int allow_nat;
@@ -2123,15 +2171,6 @@ libgnunet_plugin_transport_udp_init (void *cls)
   char *external_address;
   struct IPv4UdpAddress v4_address;
 
-  service = GNUNET_SERVICE_start ("transport-udp", env->sched, env->cfg);
-  if (service == NULL)
-    {
-      GNUNET_log (GNUNET_ERROR_TYPE_WARNING, _
-                       ("Failed to start service for `%s' transport plugin.\n"),
-                       "udp");
-      return NULL;
-    }
-
   if (GNUNET_YES == GNUNET_CONFIGURATION_get_value_yesno (env->cfg,
                                                          "transport-udp",
                                                          "BEHIND_NAT"))
@@ -2181,7 +2220,6 @@ libgnunet_plugin_transport_udp_init (void *cls)
       GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                   _("Require EXTERNAL_ADDRESS for service `%s' in configuration (either BEHIND_NAT or ALLOW_NAT set to YES)!\n"),
                   "transport-udp");
-      GNUNET_SERVICE_stop (service);
       return NULL;
     }
 
@@ -2200,7 +2238,6 @@ libgnunet_plugin_transport_udp_init (void *cls)
       GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                        _("Require INTERNAL_ADDRESS for service `%s' in configuration!\n"),
                        "transport-udp");
-      GNUNET_SERVICE_stop (service);
       GNUNET_free_non_null(external_address);
       return NULL;
     }
@@ -2223,10 +2260,9 @@ libgnunet_plugin_transport_udp_init (void *cls)
                   "PORT",
                   port,
                   65535);
-      GNUNET_SERVICE_stop (service);
       GNUNET_free_non_null(external_address);
       GNUNET_free_non_null(internal_address);
-      return NULL;      
+      return NULL;
     }
 
   mtu = 1240;
@@ -2253,19 +2289,17 @@ libgnunet_plugin_transport_udp_init (void *cls)
   api->address_to_string = &udp_address_to_string;
   api->check_address = &udp_check_address;
 
-  plugin->service = service;
-
-  GNUNET_CONFIGURATION_get_value_string(env->cfg, "transport-udp", "BINDTO", &plugin->bind_address);
-
-  GNUNET_CONFIGURATION_get_value_string(env->cfg, "transport-udp", "BINDTO6", &plugin->bind6_address);
+  if (GNUNET_YES == GNUNET_CONFIGURATION_get_value_string(env->cfg, "transport-udp", "BINDTO", &plugin->bind_address))
+    GNUNET_log(GNUNET_ERROR_TYPE_DEBUG, "Binding udp plugin to specific address: `%s'\n", plugin->bind_address);
+  if (GNUNET_YES == GNUNET_CONFIGURATION_get_value_string(env->cfg, "transport-udp", "BINDTO6", &plugin->bind6_address))
+    GNUNET_log(GNUNET_ERROR_TYPE_DEBUG, "Binding udp plugin to specific address: `%s'\n", plugin->bind6_address);
 
   if (plugin->behind_nat == GNUNET_NO)
     {
       GNUNET_OS_network_interfaces_list (&process_interfaces, plugin);
     }
 
-  plugin->hostname_dns = GNUNET_RESOLVER_hostname_resolve (env->sched,
-                                                           env->cfg,
+  plugin->hostname_dns = GNUNET_RESOLVER_hostname_resolve (env->cfg,
                                                            AF_UNSPEC,
                                                            HOSTNAME_RESOLVE_TIMEOUT,
                                                            &process_hostname_ips,
@@ -2277,6 +2311,8 @@ libgnunet_plugin_transport_udp_init (void *cls)
       plugin->env->notify_address (plugin->env->cls,
                                   "udp",
                                   &v4_address, sizeof(v4_address), GNUNET_TIME_UNIT_FOREVER_REL);
+      add_to_address_list (plugin, &v4_address.ipv4_addr, sizeof (uint32_t));
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Notifying plugin of address %s:0\n", plugin->external_address);
     }
   else if ((plugin->external_address != NULL) && (inet_pton(AF_INET, plugin->external_address, &v4_address.ipv4_addr) == 1))
     {
@@ -2284,6 +2320,7 @@ libgnunet_plugin_transport_udp_init (void *cls)
       plugin->env->notify_address (plugin->env->cls,
                                   "udp",
                                   &v4_address, sizeof(v4_address), GNUNET_TIME_UNIT_FOREVER_REL);
+      add_to_address_list (plugin, &v4_address.ipv4_addr, sizeof (uint32_t));
     }
 
   sockets_created = udp_transport_server_start (plugin);
@@ -2307,8 +2344,6 @@ libgnunet_plugin_transport_udp_done (void *cls)
       plugin->hostname_dns = NULL;
     }
 
-  GNUNET_SERVICE_stop (plugin->service);
-
   GNUNET_NETWORK_fdset_destroy (plugin->rs);
   while (NULL != (lal = plugin->lal_head))
     {