more code cleanup
[oweals/gnunet.git] / src / transport / plugin_transport_tcp.c
index cdaef4b483053341df5c3ba1e547bcbac8d77028..f38c08c654399a497e1a263b858d9fc5185c411d 100644 (file)
@@ -4,7 +4,7 @@
 
      GNUnet is free software; you can redistribute it and/or modify
      it under the terms of the GNU General Public License as published
-     by the Free Software Foundation; either version 2, or (at your
+     by the Free Software Foundation; either version 3, or (at your
      option) any later version.
 
      GNUnet is distributed in the hope that it will be useful, but
@@ -37,8 +37,8 @@
 #include "plugin_transport.h"
 #include "transport.h"
 
-#define DEBUG_TCP GNUNET_NO
-#define DEBUG_TCP_NAT GNUNET_NO
+#define DEBUG_TCP GNUNET_YES
+#define DEBUG_TCP_NAT GNUNET_YES
 
 /**
  * How long until we give up on transmitting the welcome message?
@@ -116,12 +116,12 @@ struct IPv4TcpAddress
   /**
    * IPv4 address, in network byte order.
    */
-  uint32_t ipv4_addr;
+  uint32_t ipv4_addr GNUNET_PACKED;
 
   /**
    * Port number, in network byte order.
    */
-  uint16_t t_port;
+  uint16_t t_port GNUNET_PACKED;
 
 };
 
@@ -134,12 +134,12 @@ struct IPv6TcpAddress
   /**
    * IPv6 address.
    */
-  struct in6_addr ipv6_addr;
+  struct in6_addr ipv6_addr GNUNET_PACKED;
 
   /**
    * Port number, in network byte order.
    */
-  uint16_t t6_port;
+  uint16_t t6_port GNUNET_PACKED;
 
 };
 
@@ -149,6 +149,31 @@ struct IPv6TcpAddress
 struct Plugin;
 
 
+/**
+ * Local network addresses (actual IP address follows this struct).
+ * PORT is NOT included!
+ */
+struct LocalAddrList
+{
+  
+  /**
+   * This is a doubly linked list.
+   */
+  struct LocalAddrList *next;
+
+  /**
+   * This is a doubly linked list.
+   */
+  struct LocalAddrList *prev;
+
+  /**
+   * Number of bytes of the address that follow
+   */
+  size_t size;
+
+};
+
+
 /**
  * Information kept for each message that is yet to
  * be transmitted.
@@ -204,6 +229,11 @@ struct PendingMessage
 struct Session
 {
 
+  /**
+   * API requirement.
+   */
+  struct SessionHeader header;
+
   /**
    * Stored in a linked list.
    */
@@ -292,12 +322,12 @@ struct Plugin
    */
   struct GNUNET_CONNECTION_Handle *lsock;
 
-  /*
+  /**
    * stdout pipe handle for the gnunet-nat-server process
    */
   struct GNUNET_DISK_PipeHandle *server_stdout;
 
-  /*
+  /**
    * stdout file handle (for reading) for the gnunet-nat-server process
    */
   const struct GNUNET_DISK_FileHandle *server_stdout_handle;
@@ -354,6 +384,21 @@ struct Plugin
    */
   char *internal_address;
 
+  /**
+   * Address given for us to bind to (ONLY).
+   */
+  char *bind_address;
+
+  /**
+   * List of our IP addresses.
+   */
+  struct LocalAddrList *lal_head;
+  
+  /**
+   * Tail of our IP address list.
+   */ 
+  struct LocalAddrList *lal_tail;
+
   /**
    * ID of task used to update our addresses when one expires.
    */
@@ -380,9 +425,57 @@ struct Plugin
    */
   int allow_nat;
 
+  /**
+   * Should this transport advertise only NAT addresses (port set to 0)?
+   * If not, all addresses will be duplicated for NAT punching and regular
+   * ports.
+   */
+  int only_nat_addresses;
+
 };
 
 
+static void
+add_to_address_list (struct Plugin *plugin,
+                    const void *arg,
+                    size_t arg_size)
+{
+  struct LocalAddrList *lal;
+
+  lal = plugin->lal_head;
+  while (NULL != lal)
+    {
+      if ( (lal->size == arg_size) &&
+          (0 == memcmp (&lal[1], arg, arg_size)) )
+       return;
+      lal = lal->next;
+    }
+  lal = GNUNET_malloc (sizeof (struct LocalAddrList) + arg_size);
+  lal->size = arg_size;
+  memcpy (&lal[1], arg, arg_size);
+  GNUNET_CONTAINER_DLL_insert (plugin->lal_head,
+                              plugin->lal_tail,
+                              lal);
+}
+
+
+static int
+check_local_addr (struct Plugin *plugin,
+                 const void *arg,
+                 size_t arg_size)
+{
+  struct LocalAddrList *lal;
+
+  lal = plugin->lal_head;
+  while (NULL != lal)
+    {
+      if ( (lal->size == arg_size) &&
+          (0 == memcmp (&lal[1], arg, arg_size)) )
+       return GNUNET_OK;
+      lal = lal->next;
+    }
+  return GNUNET_SYSERR;
+}
 
 
 /**
@@ -429,14 +522,17 @@ tcp_address_to_string (void *cls,
     }
   else
     {
-      GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR,
-                      "tcp",
-                      _("Unexected address length: %u\n"),
-                      addrlen);
+      GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+                 _("Unexpected address length: %u\n"),
+                 addrlen);
       GNUNET_break (0);
       return NULL;
     }
-  inet_ntop (af, sb, buf, INET6_ADDRSTRLEN);
+  if (NULL == inet_ntop (af, sb, buf, INET6_ADDRSTRLEN))
+    {
+      GNUNET_log_strerror (GNUNET_ERROR_TYPE_WARNING, "inet_ntop");
+      return NULL;
+    }
   GNUNET_snprintf (rbuf,
                   sizeof (rbuf),
                   (af == AF_INET6) ? "[%s]:%u" : "%s:%u",
@@ -489,8 +585,7 @@ create_session (struct Plugin *plugin,
     GNUNET_assert (client == NULL);
 
 #if DEBUG_TCP
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                  "tcp",
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                   "Creating new session for peer `%4s'\n",
                   GNUNET_i2s (target));
 #endif
@@ -567,8 +662,7 @@ do_transmit (void *cls, size_t size, void *buf)
   if (buf == NULL)
     {
 #if DEBUG_TCP
-      GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                       "tcp",
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                        "Timeout trying to transmit to peer `%4s', discarding message queue.\n",
                        GNUNET_i2s (&session->target));
 #endif
@@ -584,8 +678,7 @@ do_transmit (void *cls, size_t size, void *buf)
                                       session->pending_messages_tail,
                                       pos);
 #if DEBUG_TCP
-          GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                           "tcp",
+          GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                            "Failed to transmit %u byte message to `%4s'.\n",
                           pos->message_size,
                            GNUNET_i2s (&session->target));
@@ -631,6 +724,7 @@ do_transmit (void *cls, size_t size, void *buf)
                                   session->pending_messages_tail,
                                   pos);
       GNUNET_assert (size >= pos->message_size);
+      /* FIXME: this memcpy can be up to 7% of our total runtime */
       memcpy (cbuf, pos->msg, pos->message_size);
       cbuf += pos->message_size;
       ret += pos->message_size;
@@ -656,8 +750,8 @@ do_transmit (void *cls, size_t size, void *buf)
   GNUNET_assert (hd == NULL);
   GNUNET_assert (tl == NULL);
 #if DEBUG_TCP > 1
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                   "tcp", "Transmitting %u bytes\n", ret);
+  GNUNET_log(GNUNET_ERROR_TYPE_DEBUG,
+             "Transmitting %u bytes\n", ret);
 #endif
   GNUNET_STATISTICS_update (plugin->env->stats,
                            gettext_noop ("# bytes currently in TCP buffers"),
@@ -687,6 +781,7 @@ process_pending_messages (struct Session *session)
     return;
   if (NULL == (pm = session->pending_messages_head))
     return;
+
   session->transmit_handle
     = GNUNET_SERVER_notify_transmit_ready (session->client,
                                            pm->message_size,
@@ -711,8 +806,7 @@ disconnect_session (struct Session *session)
   struct PendingMessage *pm;
 
 #if DEBUG_TCP
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                   "tcp",
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                    "Disconnecting from `%4s' at %s (session %p).\n",
                    GNUNET_i2s (&session->target),
                    (session->connect_addr != NULL) ?
@@ -734,8 +828,8 @@ disconnect_session (struct Session *session)
   else
     prev->next = session->next;
   session->plugin->env->session_end (session->plugin->env->cls,
-                           &session->target,
-                           session);
+                                    &session->target,
+                                    session);
   /* clean up state */
   if (session->transmit_handle != NULL)
     {
@@ -746,8 +840,8 @@ disconnect_session (struct Session *session)
   while (NULL != (pm = session->pending_messages_head))
     {
 #if DEBUG_TCP
-      GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                       "tcp",
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+
                        pm->transmit_cont != NULL
                        ? "Could not deliver message to `%4s'.\n"
                        :
@@ -775,10 +869,12 @@ disconnect_session (struct Session *session)
     {
       GNUNET_SCHEDULER_cancel (session->plugin->env->sched,
                               session->receive_delay_task);
-      GNUNET_SERVER_receive_done (session->client, 
-                                 GNUNET_SYSERR);       
+      if (session->client != NULL)
+       GNUNET_SERVER_receive_done (session->client, 
+                                   GNUNET_SYSERR);     
     }
-  GNUNET_SERVER_client_drop (session->client);
+  if (session->client != NULL)      
+    GNUNET_SERVER_client_drop (session->client);
   GNUNET_STATISTICS_update (session->plugin->env->stats,
                            gettext_noop ("# TCP sessions active"),
                            -1,
@@ -839,8 +935,9 @@ run_gnunet_nat_client (struct Plugin *plugin, const char *addr, size_t addrlen)
   char *port_as_string;
   pid_t pid;
   const struct sockaddr *sa = (const struct sockaddr *)addr;
+
 #if DEBUG_TCP_NAT
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                   _("called run_gnunet_nat_client addrlen %d others are %d and %d\n"), addrlen, sizeof (struct sockaddr), sizeof (struct sockaddr_in));
 #endif
 
@@ -852,9 +949,13 @@ run_gnunet_nat_client (struct Plugin *plugin, const char *addr, size_t addrlen)
     case AF_INET:
       if (addrlen != sizeof (struct sockaddr_in))
         return;
-      inet_ntop (AF_INET,
-                 &((struct sockaddr_in *) sa)->sin_addr,
-                 inet4, INET_ADDRSTRLEN);
+      if (NULL == inet_ntop (AF_INET,
+                            &((struct sockaddr_in *) sa)->sin_addr,
+                            inet4, INET_ADDRSTRLEN))
+       {
+         GNUNET_log_strerror (GNUNET_ERROR_TYPE_WARNING, "inet_ntop");
+         return;
+       }
       address_as_string = GNUNET_strdup (inet4);
       break;
     case AF_INET6:
@@ -864,7 +965,7 @@ run_gnunet_nat_client (struct Plugin *plugin, const char *addr, size_t addrlen)
 
   GNUNET_asprintf(&port_as_string, "%d", plugin->adv_port);
 #if DEBUG_TCP_NAT
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                   _("Running gnunet-nat-client with arguments: %s %s %d\n"), plugin->external_address, address_as_string, plugin->adv_port);
 #endif
 
@@ -992,8 +1093,7 @@ tcp_plugin_send (void *cls,
        (addr == NULL) )
     {
 #if DEBUG_TCP
-      GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                       "tcp",
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                        "Asked to transmit to `%4s' without address and I have no existing connection (failing).\n",
                        GNUNET_i2s (target));
 #endif
@@ -1041,8 +1141,7 @@ tcp_plugin_send (void *cls,
        }
       else
        {
-         GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR,
-                          "tcp",
+         GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                           _("Address of unexpected length: %u\n"),
                           addrlen);
          GNUNET_break (0);
@@ -1057,8 +1156,7 @@ tcp_plugin_send (void *cls,
            (GNUNET_NO == GNUNET_CONTAINER_multihashmap_contains(plugin->nat_wait_conns, &target->hashPubKey)))
         {
 #if DEBUG_TCP_NAT
-          GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                           "tcp",
+          GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                            _("Found valid IPv4 NAT address!\n"));
 #endif
           session = create_session (plugin,
@@ -1067,8 +1165,11 @@ tcp_plugin_send (void *cls,
 
           /* create new message entry */
           pm = GNUNET_malloc (sizeof (struct PendingMessage) + msgbuf_size);
+         /* FIXME: the memset of this malloc can be up to 2% of our total runtime */
           pm->msg = (const char*) &pm[1];
-          memcpy (&pm[1], msg, msgbuf_size);
+          memcpy (&pm[1], msg, msgbuf_size); 
+         /* FIXME: this memcpy can be up to 7% of our total run-time 
+            (for transport service) */
           pm->message_size = msgbuf_size;
           pm->timeout = GNUNET_TIME_relative_to_absolute (timeout);
           pm->transmit_cont = cont;
@@ -1080,15 +1181,14 @@ tcp_plugin_send (void *cls,
                                              session->pending_messages_tail,
                                              pm);
 
-          GNUNET_CONTAINER_multihashmap_put(plugin->nat_wait_conns, &target->hashPubKey, session, GNUNET_CONTAINER_MULTIHASHMAPOPTION_UNIQUE_ONLY);
+          GNUNET_assert(GNUNET_CONTAINER_multihashmap_put(plugin->nat_wait_conns, &target->hashPubKey, session, GNUNET_CONTAINER_MULTIHASHMAPOPTION_UNIQUE_ONLY) == GNUNET_OK);
 #if DEBUG_TCP_NAT
-          GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                           "tcp",
+          GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                            "Created NAT WAIT connection to `%4s' at `%s'\n",
                            GNUNET_i2s (target),
                            GNUNET_a2s (sb, sbs));
 #endif
-          run_gnunet_nat_client(plugin, sb, sbs);
+          run_gnunet_nat_client (plugin, sb, sbs);
           return 0;
         }
       else if ((plugin->allow_nat == GNUNET_YES) && (is_natd == GNUNET_YES) && (GNUNET_YES == GNUNET_CONTAINER_multihashmap_contains(plugin->nat_wait_conns, &target->hashPubKey)))
@@ -1097,13 +1197,11 @@ tcp_plugin_send (void *cls,
           return -1;
         }
       sa = GNUNET_CONNECTION_create_from_sockaddr (plugin->env->sched,
-                                                  af, sb, sbs,
-                                                  GNUNET_SERVER_MAX_MESSAGE_SIZE);
+                                                  af, sb, sbs);
       if (sa == NULL)
        {
 #if DEBUG_TCP
-         GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                          "tcp",
+         GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                           "Failed to create connection to `%4s' at `%s'\n",
                           GNUNET_i2s (target),
                           GNUNET_a2s (sb, sbs));
@@ -1115,8 +1213,7 @@ tcp_plugin_send (void *cls,
          return -1;
        }
 #if DEBUG_TCP
-      GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                       "tcp",
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                        "Asked to transmit to `%4s', creating fresh session using address `%s'.\n",
                       GNUNET_i2s (target),
                       GNUNET_a2s (sb, sbs));
@@ -1152,8 +1249,7 @@ tcp_plugin_send (void *cls,
                                     session->pending_messages_tail,
                                     pm);
 #if DEBUG_TCP
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                   "tcp",
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                   "Asked to transmit %u bytes to `%s', added message to list.\n",
                   msgbuf_size,
                   GNUNET_i2s (target));
@@ -1189,8 +1285,7 @@ tcp_plugin_disconnect (void *cls,
   struct PendingMessage *pm;
 
 #if DEBUG_TCP
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                  "tcp",
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                    "Asked to cancel session with `%4s'\n",
                    GNUNET_i2s (target));
 #endif
@@ -1340,29 +1435,36 @@ tcp_plugin_address_pretty_printer (void *cls,
 /**
  * Check if the given port is plausible (must be either
  * our listen port or our advertised port).  If it is
- * neither, we return one of these two ports at random.
+ * neither, we return GNUNET_SYSERR.
  *
  * @param plugin global variables
  * @param in_port port number to check
- * @return either in_port or a more plausible port
+ * @return GNUNET_OK if port is either open_port or adv_port
  */
-static uint16_t
+static int
 check_port (struct Plugin *plugin, uint16_t in_port)
 {
+  if ( (plugin->behind_nat == GNUNET_YES) && (in_port == 0) )
+    return GNUNET_OK;
+  if ( (plugin->only_nat_addresses == GNUNET_YES) &&
+       (plugin->behind_nat == GNUNET_YES) )
+    {
+      return GNUNET_SYSERR; /* odd case... */
+    }
   if ((in_port == plugin->adv_port) || (in_port == plugin->open_port))
-    return in_port;
-  return (GNUNET_CRYPTO_random_u32 (GNUNET_CRYPTO_QUALITY_WEAK,
-                                    2) == 0)
-    ? plugin->open_port : plugin->adv_port;
+    return GNUNET_OK;
+  return GNUNET_SYSERR;
 }
 
 
-/**
- * Another peer has suggested an address for this peer and transport
- * plugin.  Check that this could be a valid address. This function
- * is not expected to 'validate' the address in the sense of trying to
- * connect to it but simply to see if the binary format is technically
- * legal for establishing a connection.
+/** 
+ * Function that will be called to check if a binary address for this
+ * plugin is well-formed and corresponds to an address for THIS peer
+ * (as per our configuration).  Naturally, if absolutely necessary,
+ * plugins can be a bit conservative in their answer, but in general
+ * plugins should make sure that the address does not redirect
+ * traffic to a 3rd party that might try to man-in-the-middle our
+ * traffic.
  *
  * @param cls closure, our 'struct Plugin*'
  * @param addr pointer to the address
@@ -1371,7 +1473,9 @@ check_port (struct Plugin *plugin, uint16_t in_port)
  *         and transport, GNUNET_SYSERR if not
  */
 static int
-tcp_plugin_check_address (void *cls, void *addr, size_t addrlen)
+tcp_plugin_check_address (void *cls, 
+                         const void *addr, 
+                         size_t addrlen)
 {
   struct Plugin *plugin = cls;
   struct IPv4TcpAddress *v4;
@@ -1386,7 +1490,14 @@ tcp_plugin_check_address (void *cls, void *addr, size_t addrlen)
   if (addrlen == sizeof (struct IPv4TcpAddress))
     {
       v4 = (struct IPv4TcpAddress *) addr;
-      v4->t_port = htons (check_port (plugin, ntohs (v4->t_port)));
+      if (GNUNET_OK !=
+         check_port (plugin, ntohs (v4->t_port)))
+       return GNUNET_SYSERR;
+      if (GNUNET_OK !=
+         check_local_addr (plugin, &v4->ipv4_addr, sizeof (uint32_t)))
+       {
+         return GNUNET_SYSERR;
+       }
     }
   else
     {
@@ -1396,7 +1507,14 @@ tcp_plugin_check_address (void *cls, void *addr, size_t addrlen)
          GNUNET_break_op (0);
          return GNUNET_SYSERR;
        }
-      v6->t6_port = htons (check_port (plugin, ntohs (v6->t6_port)));
+      if (GNUNET_OK != 
+         check_port (plugin, ntohs (v6->t6_port)))
+       return GNUNET_SYSERR;
+      if (GNUNET_OK !=
+         check_local_addr (plugin, &v6->ipv6_addr, sizeof (struct in6_addr)))
+       {
+         return GNUNET_SYSERR;
+       }
     }
   return GNUNET_OK;
 }
@@ -1426,7 +1544,7 @@ handle_tcp_nat_probe (void *cls,
   const struct sockaddr_in6 *s6;
 
 #if DEBUG_TCP_NAT
-  GNUNET_log_from(GNUNET_ERROR_TYPE_DEBUG, "tcp", "received tcp NAT probe\n");
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "received tcp NAT probe\n");
 #endif
   /* We have received a TCP NAT probe, meaning we (hopefully) initiated
    * a connection to this peer by running gnunet-nat-client.  This peer
@@ -1437,7 +1555,7 @@ handle_tcp_nat_probe (void *cls,
   if (ntohs(message->size) != sizeof(struct TCP_NAT_ProbeMessage))
     {
 #if DEBUG_TCP_NAT
-      GNUNET_log_from(GNUNET_ERROR_TYPE_DEBUG, "tcp", "Bad size fo tcp NAT probe, expected %d got %d.\n", sizeof(struct TCP_NAT_ProbeMessage), ntohs(message->size));
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Bad size for tcp NAT probe, expected %d got %d.\n", sizeof(struct TCP_NAT_ProbeMessage), ntohs(message->size));
 #endif
       GNUNET_break_op(0);
       return;
@@ -1447,25 +1565,30 @@ handle_tcp_nat_probe (void *cls,
   if (GNUNET_CONTAINER_multihashmap_contains(plugin->nat_wait_conns, &tcp_nat_probe->clientIdentity.hashPubKey) == GNUNET_YES)
     {
 #if DEBUG_TCP_NAT
-      GNUNET_log_from(GNUNET_ERROR_TYPE_DEBUG, "tcp", "Found session for NAT probe!\n");
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Found session for NAT probe!\n");
 #endif
       session = GNUNET_CONTAINER_multihashmap_get(plugin->nat_wait_conns, &tcp_nat_probe->clientIdentity.hashPubKey);
       GNUNET_assert(session != NULL);
+      GNUNET_assert(GNUNET_CONTAINER_multihashmap_remove(plugin->nat_wait_conns, &tcp_nat_probe->clientIdentity.hashPubKey, session) == GNUNET_YES);
       GNUNET_SERVER_client_keep (client);
       session->client = client;
       session->last_activity = GNUNET_TIME_absolute_get ();
+      /* FIXME: Should this be inbound or outbound?
+       * I think it should be outbound because we technically
+       * initiated it... But something goes wrong somewhere. */
+      /* session->inbound = GNUNET_YES; */
+      session->inbound = GNUNET_YES;
 
       if (GNUNET_OK ==
           GNUNET_SERVER_client_get_address (client, &vaddr, &alen))
         {
 #if DEBUG_TCP_NAT
-          GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                           "tcp",
+          GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                            "Found address `%s' for incoming connection %p\n",
                            GNUNET_a2s (vaddr, alen),
                            client);
 #endif
-          if (alen == sizeof (struct sockaddr_in))
+          if (((const struct sockaddr *)vaddr)->sa_family == AF_INET)
             {
               s4 = vaddr;
               t4 = GNUNET_malloc (sizeof (struct IPv4TcpAddress));
@@ -1474,7 +1597,7 @@ handle_tcp_nat_probe (void *cls,
               session->connect_addr = t4;
               session->connect_alen = sizeof (struct IPv4TcpAddress);
             }
-          else if (alen == sizeof (struct sockaddr_in6))
+          else if (((const struct sockaddr *)vaddr)->sa_family == AF_INET6)
             {
               s6 = vaddr;
               t6 = GNUNET_malloc (sizeof (struct IPv6TcpAddress));
@@ -1485,37 +1608,32 @@ handle_tcp_nat_probe (void *cls,
               session->connect_addr = t6;
               session->connect_alen = sizeof (struct IPv6TcpAddress);
             }
-
-          session->connect_addr = GNUNET_malloc (alen);
-          memcpy (session->connect_addr,
-                  vaddr,
-                  alen);
-          session->connect_alen = alen;
+          else
+            {
+#if DEBUG_TCP_NAT
+              GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                          "Bad address for incoming connection!\n");
+#endif
+            }
           GNUNET_free (vaddr);
         }
-      else
-        {
-          /* FIXME: free partial session? */
-        }
 
       session->next = plugin->sessions;
       plugin->sessions = session;
-
       GNUNET_STATISTICS_update (plugin->env->stats,
                                 gettext_noop ("# TCP sessions active"),
                                 1,
                                 GNUNET_NO);
-      /*GNUNET_SERVER_connect_socket (plugin->server,
-                                    client->);*/
-
       process_pending_messages (session);
     }
   else
     {
 #if DEBUG_TCP_NAT
-      GNUNET_log_from(GNUNET_ERROR_TYPE_DEBUG, "tcp", "Did NOT find session for NAT probe!\n");
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Did NOT find session for NAT probe!\n");
 #endif
     }
+
+  GNUNET_SERVER_receive_done (client, GNUNET_OK);
 }
 
 /**
@@ -1541,10 +1659,8 @@ handle_tcp_welcome (void *cls,
   const struct sockaddr_in *s4;
   const struct sockaddr_in6 *s6;
 
-
 #if DEBUG_TCP
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                   "tcp",
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                    "Received %s message from a `%4s/%p'.\n", 
                   "WELCOME",
                    GNUNET_i2s (&wm->clientIdentity), client);
@@ -1564,8 +1680,7 @@ handle_tcp_welcome (void *cls,
          GNUNET_SERVER_client_get_address (client, &vaddr, &alen))
        {
 #if DEBUG_TCP
-         GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                          "tcp",
+         GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                           "Found address `%s' for incoming connection %p\n",
                           GNUNET_a2s (vaddr, alen),
                           client);
@@ -1595,14 +1710,12 @@ handle_tcp_welcome (void *cls,
       else
         {
 #if DEBUG_TCP
-         GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                          "tcp",
+         GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                           "Did not obtain TCP socket address for incoming connection\n");
 #endif
         }
 #if DEBUG_TCP
-      GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                       "tcp",
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                        "Creating new session %p for connection %p\n",
                        session, client);
 #endif
@@ -1679,8 +1792,7 @@ handle_tcp_data (void *cls,
     }
   session->last_activity = GNUNET_TIME_absolute_get ();
 #if DEBUG_TCP
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                   "tcp", 
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                   "Passing %u bytes of type %u from `%4s' to transport service.\n",
                    (unsigned int) ntohs (message->size), 
                   (unsigned int) ntohs (message->type),
@@ -1703,18 +1815,6 @@ handle_tcp_data (void *cls,
 }
 
 
-/**
- * Handlers for the various TCP messages.
- */
-static struct GNUNET_SERVER_MessageHandler my_handlers[] = {
-  {&handle_tcp_welcome, NULL, GNUNET_MESSAGE_TYPE_TRANSPORT_TCP_WELCOME,
-   sizeof (struct WelcomeMessage)},
-  {&handle_tcp_nat_probe, NULL, GNUNET_MESSAGE_TYPE_TRANSPORT_TCP_NAT_PROBE, sizeof (struct TCP_NAT_ProbeMessage)},
-  {&handle_tcp_data, NULL, GNUNET_MESSAGE_TYPE_ALL, 0},
-  {NULL, NULL, 0, 0}
-};
-
-
 /**
  * Functions with this signature are called whenever a peer
  * is disconnected on the network level.
@@ -1735,8 +1835,7 @@ disconnect_notify (void *cls,
   if (session == NULL)
     return;                     /* unknown, nothing to do */
 #if DEBUG_TCP
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                   "tcp",
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                    "Destroying session of `%4s' with %s (%p) due to network-level disconnect.\n",
                    GNUNET_i2s (&session->target),
                    (session->connect_addr != NULL) ?
@@ -1770,15 +1869,33 @@ process_interfaces (void *cls,
   int af;
   struct IPv4TcpAddress t4;
   struct IPv6TcpAddress t6;
+  struct IPv4TcpAddress t4_nat;
+  struct IPv6TcpAddress t6_nat;
   void *arg;
   uint16_t args;
+  void *arg_nat;
+  char buf[INET_ADDRSTRLEN];
 
   af = addr->sa_family;
+  arg_nat = NULL;
   if (af == AF_INET)
     {
       t4.ipv4_addr = ((struct sockaddr_in *) addr)->sin_addr.s_addr;
-      if (plugin->behind_nat)
+      GNUNET_assert(NULL != inet_ntop(AF_INET, &t4.ipv4_addr, &buf[0], INET_ADDRSTRLEN));
+      if ((plugin->bind_address != NULL) && (0 != strcmp(buf, plugin->bind_address)))
+        {
+          GNUNET_log(GNUNET_ERROR_TYPE_DEBUG, "%s: Not notifying transport of address %s\n", "TCP", GNUNET_a2s (addr, addrlen));
+          return GNUNET_OK;
+        }
+      add_to_address_list (plugin, &t4.ipv4_addr, sizeof (uint32_t));
+      if ((plugin->behind_nat == GNUNET_YES) && (plugin->only_nat_addresses == GNUNET_YES))
         t4.t_port = htons(0);
+      else if (plugin->behind_nat == GNUNET_YES) /* We are behind NAT, but will advertise NAT and normal addresses */
+        {
+          t4_nat.ipv4_addr = ((struct sockaddr_in *) addr)->sin_addr.s_addr;
+          t4_nat.t_port = htons(plugin->adv_port);
+          arg_nat = &t4_nat;
+        }
       else
         t4.t_port = htons (plugin->adv_port);
       arg = &t4;
@@ -1786,7 +1903,7 @@ process_interfaces (void *cls,
     }
   else if (af == AF_INET6)
     {
-      if (IN6_IS_ADDR_LINKLOCAL (&((struct sockaddr_in6 *) addr)->sin6_addr))
+      if ((IN6_IS_ADDR_LINKLOCAL (&((struct sockaddr_in6 *) addr)->sin6_addr)) || (GNUNET_YES == GNUNET_CONFIGURATION_get_value_yesno(plugin->env->cfg, "transport-tcp", "disablev6")))
        {
          /* skip link local addresses */
          return GNUNET_OK;
@@ -1794,8 +1911,17 @@ process_interfaces (void *cls,
       memcpy (&t6.ipv6_addr,
              &((struct sockaddr_in6 *) addr)->sin6_addr,
              sizeof (struct in6_addr));
-      if (plugin->behind_nat)
+      add_to_address_list (plugin, &t6.ipv6_addr, sizeof (struct in6_addr));
+      if ((plugin->behind_nat == GNUNET_YES) && (plugin->only_nat_addresses == GNUNET_YES))
         t6.t6_port = htons(0);
+      else if (plugin->behind_nat == GNUNET_YES) /* We are behind NAT, but will advertise NAT and normal addresses */
+        {
+          memcpy (&t6_nat.ipv6_addr,
+                  &((struct sockaddr_in6 *) addr)->sin6_addr,
+                  sizeof (struct in6_addr));
+          t6_nat.t6_port = htons(plugin->adv_port);
+          arg_nat = &t6;
+        }
       else
         t6.t6_port = htons (plugin->adv_port);
       arg = &t6;
@@ -1806,14 +1932,26 @@ process_interfaces (void *cls,
       GNUNET_break (0);
       return GNUNET_OK;
     }
-  GNUNET_log_from (GNUNET_ERROR_TYPE_INFO |
+  GNUNET_log (GNUNET_ERROR_TYPE_INFO |
                    GNUNET_ERROR_TYPE_BULK,
-                   "tcp", 
                   _("Found address `%s' (%s)\n"),
                    GNUNET_a2s (addr, addrlen), name);
+
   plugin->env->notify_address (plugin->env->cls,
                                "tcp",
                                arg, args, GNUNET_TIME_UNIT_FOREVER_REL);
+
+  if (arg_nat != NULL)
+    {
+      GNUNET_log (GNUNET_ERROR_TYPE_INFO |
+                       GNUNET_ERROR_TYPE_BULK,
+                      _("Found address `%s' (%s)\n"),
+                      GNUNET_a2s (addr, addrlen), name);
+      plugin->env->notify_address (plugin->env->cls,
+                                   "tcp",
+                                   arg_nat, args, GNUNET_TIME_UNIT_FOREVER_REL);
+    }
+
   return GNUNET_OK;
 }
 
@@ -1899,7 +2037,7 @@ tcp_plugin_server_read (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc
   if (bytes < 1)
     {
 #if DEBUG_TCP_NAT
-      GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                       _("Finished reading from server stdout with code: %d\n"), bytes);
 #endif
       return;
@@ -1930,8 +2068,8 @@ tcp_plugin_server_read (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc
       return;
     }
 
-#if DEBUG_UDP_NAT
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
+#if DEBUG_TCP_NAT
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                   _("nat-server-read read: %s port %d\n"), &mybuf, port);
 #endif
 
@@ -1939,7 +2077,7 @@ tcp_plugin_server_read (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc
   if (inet_pton(AF_INET, &mybuf[0], &in_addr.sin_addr) != 1)
     {
 
-      GNUNET_log_from (GNUNET_ERROR_TYPE_WARNING, "tcp",
+      GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
                   _("nat-server-read malformed address\n"), &mybuf, port);
 
       plugin->server_read_task =
@@ -1956,7 +2094,9 @@ tcp_plugin_server_read (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc
    *  that wants to connect to us! Send a message to establish a connection.
    */
   sock = GNUNET_CONNECTION_create_from_sockaddr (plugin->env->sched, AF_INET, (struct sockaddr *)&in_addr,
-                                                 sizeof(in_addr), GNUNET_SERVER_MAX_MESSAGE_SIZE);
+                                                 sizeof(in_addr));
+
+
   if (sock == NULL)
     {
       plugin->server_read_task =
@@ -1967,8 +2107,10 @@ tcp_plugin_server_read (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc
     }
   else
     {
-      tcp_probe_ctx = GNUNET_malloc(sizeof(struct TCPProbeContext));
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                _("Sending TCP probe message!\n"), &mybuf, port);
 
+      tcp_probe_ctx = GNUNET_malloc(sizeof(struct TCPProbeContext));
       tcp_probe_ctx->message.header.size = htons(sizeof(struct TCP_NAT_ProbeMessage));
       tcp_probe_ctx->message.header.type = htons(GNUNET_MESSAGE_TYPE_TRANSPORT_TCP_NAT_PROBE);
       memcpy(&tcp_probe_ctx->message.clientIdentity, plugin->env->my_identity, sizeof(struct GNUNET_PeerIdentity));
@@ -1981,6 +2123,7 @@ tcp_plugin_server_read (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc
 
     }
 
+  /*GNUNET_SERVER_connect_socket(plugin->server, sock);*/
   plugin->server_read_task =
       GNUNET_SCHEDULER_add_read_file (plugin->env->sched,
                                       GNUNET_TIME_UNIT_FOREVER_REL,
@@ -2003,8 +2146,7 @@ tcp_transport_start_nat_server(struct Plugin *plugin)
     return GNUNET_SYSERR;
 
 #if DEBUG_TCP_NAT
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                   "tcp",
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                    "Starting gnunet-nat-server process cmd: %s %s\n", "gnunet-nat-server", plugin->internal_address);
 #endif
   /* Start the server process */
@@ -2012,8 +2154,7 @@ tcp_transport_start_nat_server(struct Plugin *plugin)
   if (plugin->server_pid == GNUNET_SYSERR)
     {
 #if DEBUG_TCP_NAT
-    GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                     "tcp",
+    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                      "Failed to start gnunet-nat-server process\n");
 #endif
       return GNUNET_SYSERR;
@@ -2110,6 +2251,13 @@ check_gnunet_nat_binary(char *binary)
 void *
 libgnunet_plugin_transport_tcp_init (void *cls)
 {
+  static const struct GNUNET_SERVER_MessageHandler my_handlers[] = {
+    {&handle_tcp_welcome, NULL, GNUNET_MESSAGE_TYPE_TRANSPORT_TCP_WELCOME,
+     sizeof (struct WelcomeMessage)},
+    {&handle_tcp_nat_probe, NULL, GNUNET_MESSAGE_TYPE_TRANSPORT_TCP_NAT_PROBE, sizeof (struct TCP_NAT_ProbeMessage)},
+    {&handle_tcp_data, NULL, GNUNET_MESSAGE_TYPE_ALL, 0},
+    {NULL, NULL, 0, 0}
+  };
   struct GNUNET_TRANSPORT_PluginEnvironment *env = cls;
   struct GNUNET_TRANSPORT_PluginFunctions *api;
   struct Plugin *plugin;
@@ -2119,17 +2267,18 @@ libgnunet_plugin_transport_tcp_init (void *cls)
   unsigned int i;
   int behind_nat;
   int allow_nat;
+  int only_nat_addresses;
   char *internal_address;
   char *external_address;
+  struct sockaddr_in in_addr;
+  struct IPv4TcpAddress t4;
 
   service = GNUNET_SERVICE_start ("transport-tcp", env->sched, env->cfg);
   if (service == NULL)
     {
-      GNUNET_log_from (GNUNET_ERROR_TYPE_WARNING,
-                       "tcp",
-                       _
-                       ("Failed to start service for `%s' transport plugin.\n"),
-                       "tcp");
+      GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
+                 _("Failed to start service for `%s' transport plugin.\n"),
+                 "tcp");
       return NULL;
     }
 
@@ -2145,7 +2294,7 @@ libgnunet_plugin_transport_tcp_init (void *cls)
       else
         {
           behind_nat = GNUNET_NO;
-          GNUNET_log_from (GNUNET_ERROR_TYPE_WARNING, "tcp", "Configuration specified you are behind a NAT, but gnunet-nat-server is not installed properly (suid bit not set)!\n");
+          GNUNET_log (GNUNET_ERROR_TYPE_WARNING, "Configuration specified you are behind a NAT, but gnunet-nat-server is not installed properly (suid bit not set)!\n");
         }
     }
   else
@@ -2160,13 +2309,20 @@ libgnunet_plugin_transport_tcp_init (void *cls)
       else
       {
         allow_nat = GNUNET_NO;
-        GNUNET_log_from (GNUNET_ERROR_TYPE_WARNING, "tcp", "Configuration specified you want to connect to NAT'd peers, but gnunet-nat-client is not installed properly (suid bit not set)!\n");
+        GNUNET_log (GNUNET_ERROR_TYPE_WARNING, "Configuration specified you want to connect to NAT'd peers, but gnunet-nat-client is not installed properly (suid bit not set)!\n");
       }
-
     }
   else
     allow_nat = GNUNET_NO; /* We don't want to try to help NAT'd peers */
 
+
+  if (GNUNET_YES == GNUNET_CONFIGURATION_get_value_yesno (env->cfg,
+                                                           "transport-tcp",
+                                                           "ONLY_NAT_ADDRESSES"))
+    only_nat_addresses = GNUNET_YES; /* We will only report our addresses as NAT'd */
+  else
+    only_nat_addresses = GNUNET_NO; /* We will report our addresses as NAT'd and non-NAT'd */
+
   external_address = NULL;
   if (((GNUNET_YES == behind_nat) || (GNUNET_YES == allow_nat)) && (GNUNET_OK !=
          GNUNET_CONFIGURATION_get_value_string (env->cfg,
@@ -2174,8 +2330,7 @@ libgnunet_plugin_transport_tcp_init (void *cls)
                                                 "EXTERNAL_ADDRESS",
                                                 &external_address)))
     {
-      GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR,
-                       "tcp",
+      GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                        _
                        ("Require EXTERNAL_ADDRESS for service `%s' in configuration (either BEHIND_NAT or ALLOW_NAT set to YES)!\n"),
                        "transport-tcp");
@@ -2183,6 +2338,11 @@ libgnunet_plugin_transport_tcp_init (void *cls)
       return NULL;
     }
 
+  if ((external_address != NULL) && (inet_pton(AF_INET, external_address, &in_addr.sin_addr) != 1))
+    {
+      GNUNET_log (GNUNET_ERROR_TYPE_WARNING, "Malformed EXTERNAL_ADDRESS %s given in configuration!\n", external_address);
+    }
+
   internal_address = NULL;
   if ((GNUNET_YES == behind_nat) && (GNUNET_OK !=
          GNUNET_CONFIGURATION_get_value_string (env->cfg,
@@ -2190,16 +2350,18 @@ libgnunet_plugin_transport_tcp_init (void *cls)
                                                 "INTERNAL_ADDRESS",
                                                 &internal_address)))
     {
-      GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR,
-                       "tcp",
-                       _
-                       ("Require INTERNAL_ADDRESS for service `%s' in configuration!\n"),
-                       "transport-tcp");
+      GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+                 _("Require INTERNAL_ADDRESS for service `%s' in configuration!\n"),
+                 "transport-tcp");
       GNUNET_SERVICE_stop (service);
       GNUNET_free_non_null(external_address);
       return NULL;
     }
 
+  if ((internal_address != NULL) && (inet_pton(AF_INET, internal_address, &in_addr.sin_addr) != 1))
+    {
+      GNUNET_log (GNUNET_ERROR_TYPE_WARNING, "Malformed INTERNAL_ADDRESS %s given in configuration!\n", internal_address);
+    }
 
   aport = 0;
   if ((GNUNET_OK !=
@@ -2214,8 +2376,7 @@ libgnunet_plugin_transport_tcp_init (void *cls)
                                                "ADVERTISED-PORT",
                                                &aport)) && (aport > 65535)))
     {
-      GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR,
-                       "tcp",
+      GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                        _
                        ("Require valid port number for service `%s' in configuration!\n"),
                        "transport-tcp");
@@ -2234,6 +2395,7 @@ libgnunet_plugin_transport_tcp_init (void *cls)
   plugin->internal_address = internal_address;
   plugin->behind_nat = behind_nat;
   plugin->allow_nat = allow_nat;
+  plugin->only_nat_addresses = only_nat_addresses;
   plugin->env = env;
   plugin->lsock = NULL;
   api = GNUNET_malloc (sizeof (struct GNUNET_TRANSPORT_PluginFunctions));
@@ -2254,12 +2416,12 @@ libgnunet_plugin_transport_tcp_init (void *cls)
     plugin->handlers[i].callback_cls = plugin;
   GNUNET_SERVER_add_handlers (plugin->server, plugin->handlers);
 
-  if (behind_nat == GNUNET_YES)
+  if (plugin->behind_nat == GNUNET_YES)
     {
       if (GNUNET_YES != tcp_transport_start_nat_server(plugin))
         {
-          GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR,
-                           "tcp",
+          GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+
                            _
                            ("Failed to start %s required for NAT in %s!\n"),
                            "gnunet-nat-server"
@@ -2267,6 +2429,7 @@ libgnunet_plugin_transport_tcp_init (void *cls)
           GNUNET_free_non_null(external_address);
           GNUNET_free_non_null(internal_address);
           GNUNET_SERVICE_stop (service);
+         GNUNET_free (api);
           return NULL;
         }
     }
@@ -2277,25 +2440,46 @@ libgnunet_plugin_transport_tcp_init (void *cls)
       GNUNET_assert(plugin->nat_wait_conns != NULL);
     }
 
-  GNUNET_log_from (GNUNET_ERROR_TYPE_INFO,
-                   "tcp", _("TCP transport listening on port %llu\n"), bport);
+  GNUNET_log (GNUNET_ERROR_TYPE_INFO, _("TCP transport listening on port %llu\n"), bport);
   if (aport != bport)
-    GNUNET_log_from (GNUNET_ERROR_TYPE_INFO,
-                     "tcp",
+    GNUNET_log (GNUNET_ERROR_TYPE_INFO,
                      _("TCP transport advertises itself as being on port %llu\n"),
                      aport);
   GNUNET_SERVER_disconnect_notify (plugin->server, 
                                   &disconnect_notify,
                                    plugin);
-  /* FIXME: do the two calls below periodically again and
-     not just once (since the info we get might change...) */
-  GNUNET_OS_network_interfaces_list (&process_interfaces, plugin);
+  GNUNET_CONFIGURATION_get_value_string(env->cfg, "transport-tcp", "BINDTO", &plugin->bind_address);
+
+  if (plugin->behind_nat == GNUNET_NO)
+    {
+      GNUNET_OS_network_interfaces_list (&process_interfaces, plugin);
+    }
+
   plugin->hostname_dns = GNUNET_RESOLVER_hostname_resolve (env->sched,
                                                            env->cfg,
                                                            AF_UNSPEC,
                                                            HOSTNAME_RESOLVE_TIMEOUT,
                                                            &process_hostname_ips,
                                                            plugin);
+
+  if ((plugin->behind_nat == GNUNET_YES) && (inet_pton(AF_INET, plugin->external_address, &t4.ipv4_addr) == 1))
+    {
+      GNUNET_log(GNUNET_ERROR_TYPE_DEBUG, "Notifying transport of address %s:0\n", plugin->external_address);
+      t4.t_port = htons(0);
+      add_to_address_list (plugin, &t4.ipv4_addr, sizeof (uint32_t));
+      plugin->env->notify_address (plugin->env->cls,
+                                  "tcp",
+                                  &t4, sizeof(t4), GNUNET_TIME_UNIT_FOREVER_REL);
+    }
+  else if ((plugin->external_address != NULL) && (inet_pton(AF_INET, plugin->external_address, &t4.ipv4_addr) == 1))
+    {
+      t4.t_port = htons(plugin->adv_port);
+      add_to_address_list (plugin, &t4.ipv4_addr, sizeof (uint32_t));
+      plugin->env->notify_address (plugin->env->cls,
+                                   "tcp",
+                                   &t4, sizeof(t4), GNUNET_TIME_UNIT_FOREVER_REL);
+    }
+
   return api;
 }
 
@@ -2309,6 +2493,7 @@ libgnunet_plugin_transport_tcp_done (void *cls)
   struct GNUNET_TRANSPORT_PluginFunctions *api = cls;
   struct Plugin *plugin = api->cls;
   struct Session *session;
+  struct LocalAddrList *lal;
 
   while (NULL != (session = plugin->sessions))
     disconnect_session (session);
@@ -2319,6 +2504,21 @@ libgnunet_plugin_transport_tcp_done (void *cls)
     }
   GNUNET_SERVICE_stop (plugin->service);
   GNUNET_free (plugin->handlers);
+  while (NULL != (lal = plugin->lal_head))
+    {
+      GNUNET_CONTAINER_DLL_remove (plugin->lal_head,
+                                  plugin->lal_tail,
+                                  lal);
+      GNUNET_free (lal);
+    }
+
+  if (plugin->behind_nat == GNUNET_YES)
+    {
+      if (0 != PLIBC_KILL (plugin->server_pid, SIGTERM))
+        GNUNET_log_strerror (GNUNET_ERROR_TYPE_WARNING, "kill");
+      GNUNET_OS_process_wait (plugin->server_pid);
+    }
+  GNUNET_free_non_null(plugin->bind_address);
   GNUNET_free (plugin);
   GNUNET_free (api);
   return NULL;