remove port from transport section because it was getting in the way of making sense...
[oweals/gnunet.git] / src / transport / plugin_transport_tcp.c
index 7fe7481bf53e936b98f56e17b01125b06fafc8f7..8c1d3d3339399447cc771b76c72ab1ff128df3c7 100644 (file)
@@ -38,7 +38,7 @@
 #include "transport.h"
 
 #define DEBUG_TCP GNUNET_NO
-#define DEBUG_TCP_NAT GNUNET_YES
+#define DEBUG_TCP_NAT GNUNET_NO
 
 /**
  * How long until we give up on transmitting the welcome message?
@@ -155,7 +155,7 @@ struct Plugin;
  */
 struct LocalAddrList
 {
-  
+
   /**
    * This is a doubly linked list.
    */
@@ -304,6 +304,11 @@ struct Session
    */
   int inbound;
 
+  /**
+   * Was this session created using NAT traversal?
+   */
+  int is_nat;
+
 };
 
 
@@ -384,14 +389,19 @@ struct Plugin
    */
   char *internal_address;
 
+  /**
+   * Address given for us to bind to (ONLY).
+   */
+  char *bind_address;
+
   /**
    * List of our IP addresses.
    */
   struct LocalAddrList *lal_head;
-  
+
   /**
    * Tail of our IP address list.
-   */ 
+   */
   struct LocalAddrList *lal_tail;
 
   /**
@@ -475,16 +485,16 @@ check_local_addr (struct Plugin *plugin,
 
 /**
  * Function called for a quick conversion of the binary address to
- * a numeric address.  Note that the caller must not free the 
+ * a numeric address.  Note that the caller must not free the
  * address and that the next call to this function is allowed
  * to override the address again.
  *
  * @param cls closure ('struct Plugin*')
  * @param addr binary address
  * @param addrlen length of the address
- * @return string representing the same address 
+ * @return string representing the same address
  */
-static const char* 
+static const char*
 tcp_address_to_string (void *cls,
                       const void *addr,
                       size_t addrlen)
@@ -580,14 +590,14 @@ create_session (struct Plugin *plugin,
     GNUNET_assert (client == NULL);
 
 #if DEBUG_TCP
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                  "tcp",
+  GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
                   "Creating new session for peer `%4s'\n",
                   GNUNET_i2s (target));
 #endif
   ret = GNUNET_malloc (sizeof (struct Session));
   ret->last_activity = GNUNET_TIME_absolute_get ();
   ret->plugin = plugin;
+  ret->is_nat = is_nat;
   if (is_nat != GNUNET_YES) /* If not a NAT WAIT conn, add it to global list */
     {
       ret->next = plugin->sessions;
@@ -607,7 +617,7 @@ create_session (struct Plugin *plugin,
   GNUNET_STATISTICS_update (plugin->env->stats,
                            gettext_noop ("# bytes currently in TCP buffers"),
                            pm->message_size,
-                           GNUNET_NO);      
+                           GNUNET_NO);
   GNUNET_CONTAINER_DLL_insert (ret->pending_messages_head,
                               ret->pending_messages_tail,
                               pm);
@@ -658,8 +668,7 @@ do_transmit (void *cls, size_t size, void *buf)
   if (buf == NULL)
     {
 #if DEBUG_TCP
-      GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                       "tcp",
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                        "Timeout trying to transmit to peer `%4s', discarding message queue.\n",
                        GNUNET_i2s (&session->target));
 #endif
@@ -675,8 +684,7 @@ do_transmit (void *cls, size_t size, void *buf)
                                       session->pending_messages_tail,
                                       pos);
 #if DEBUG_TCP
-          GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                           "tcp",
+          GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                            "Failed to transmit %u byte message to `%4s'.\n",
                           pos->message_size,
                            GNUNET_i2s (&session->target));
@@ -687,7 +695,7 @@ do_transmit (void *cls, size_t size, void *buf)
       /* do this call before callbacks (so that if callbacks destroy
         session, they have a chance to cancel actions done by this
         call) */
-      process_pending_messages (session);  
+      process_pending_messages (session);
       pid = session->target;
       /* no do callbacks and do not use session again since
         the callbacks may abort the session */
@@ -702,11 +710,11 @@ do_transmit (void *cls, size_t size, void *buf)
       GNUNET_STATISTICS_update (plugin->env->stats,
                                gettext_noop ("# bytes currently in TCP buffers"),
                                - (int64_t) ret,
-                               GNUNET_NO); 
+                               GNUNET_NO);
       GNUNET_STATISTICS_update (plugin->env->stats,
                                gettext_noop ("# bytes discarded by TCP (timeout)"),
                                ret,
-                               GNUNET_NO);      
+                               GNUNET_NO);
       return 0;
     }
   /* copy all pending messages that would fit */
@@ -714,9 +722,9 @@ do_transmit (void *cls, size_t size, void *buf)
   cbuf = buf;
   hd = NULL;
   tl = NULL;
-  while (NULL != (pos = session->pending_messages_head)) 
+  while (NULL != (pos = session->pending_messages_head))
     {
-      if (ret + pos->message_size > size) 
+      if (ret + pos->message_size > size)
        break;
       GNUNET_CONTAINER_DLL_remove (session->pending_messages_head,
                                   session->pending_messages_tail,
@@ -732,7 +740,7 @@ do_transmit (void *cls, size_t size, void *buf)
   /* schedule 'continuation' before callbacks so that callbacks that
      cancel everything don't cause us to use a session that no longer
      exists... */
-  process_pending_messages (session);  
+  process_pending_messages (session);
   session->last_activity = GNUNET_TIME_absolute_get ();
   pid = session->target;
   /* we'll now call callbacks that may cancel the session; hence
@@ -748,17 +756,17 @@ do_transmit (void *cls, size_t size, void *buf)
   GNUNET_assert (hd == NULL);
   GNUNET_assert (tl == NULL);
 #if DEBUG_TCP > 1
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                   "tcp", "Transmitting %u bytes\n", ret);
+  GNUNET_log(GNUNET_ERROR_TYPE_DEBUG,
+             "Transmitting %u bytes\n", ret);
 #endif
   GNUNET_STATISTICS_update (plugin->env->stats,
                            gettext_noop ("# bytes currently in TCP buffers"),
                            - (int64_t) ret,
-                           GNUNET_NO);       
+                           GNUNET_NO);
   GNUNET_STATISTICS_update (plugin->env->stats,
                            gettext_noop ("# bytes transmitted via TCP"),
                            ret,
-                           GNUNET_NO);      
+                           GNUNET_NO);
   return ret;
 }
 
@@ -779,7 +787,7 @@ process_pending_messages (struct Session *session)
     return;
   if (NULL == (pm = session->pending_messages_head))
     return;
-  GNUNET_log(GNUNET_ERROR_TYPE_DEBUG, "processing a pending message\n");
+
   session->transmit_handle
     = GNUNET_SERVER_notify_transmit_ready (session->client,
                                            pm->message_size,
@@ -804,14 +812,13 @@ disconnect_session (struct Session *session)
   struct PendingMessage *pm;
 
 #if DEBUG_TCP
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                   "tcp",
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                    "Disconnecting from `%4s' at %s (session %p).\n",
                    GNUNET_i2s (&session->target),
                    (session->connect_addr != NULL) ?
                    tcp_address_to_string (session->plugin,
                                          session->connect_addr,
-                                         session->connect_alen) : "*", 
+                                         session->connect_alen) : "*",
                   session);
 #endif
   /* remove from session list */
@@ -839,8 +846,8 @@ disconnect_session (struct Session *session)
   while (NULL != (pm = session->pending_messages_head))
     {
 #if DEBUG_TCP
-      GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                       "tcp",
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+
                        pm->transmit_cont != NULL
                        ? "Could not deliver message to `%4s'.\n"
                        :
@@ -850,11 +857,11 @@ disconnect_session (struct Session *session)
       GNUNET_STATISTICS_update (session->plugin->env->stats,
                                gettext_noop ("# bytes currently in TCP buffers"),
                                - (int64_t) pm->message_size,
-                               GNUNET_NO);      
+                               GNUNET_NO);
       GNUNET_STATISTICS_update (session->plugin->env->stats,
                                gettext_noop ("# bytes discarded by TCP (disconnect)"),
                                pm->message_size,
-                               GNUNET_NO);      
+                               GNUNET_NO);
       GNUNET_CONTAINER_DLL_remove (session->pending_messages_head,
                                   session->pending_messages_tail,
                                   pm);
@@ -869,15 +876,15 @@ disconnect_session (struct Session *session)
       GNUNET_SCHEDULER_cancel (session->plugin->env->sched,
                               session->receive_delay_task);
       if (session->client != NULL)
-       GNUNET_SERVER_receive_done (session->client, 
+       GNUNET_SERVER_receive_done (session->client,
                                    GNUNET_SYSERR);     
     }
-  if (session->client != NULL)      
+  if (session->client != NULL) 
     GNUNET_SERVER_client_drop (session->client);
   GNUNET_STATISTICS_update (session->plugin->env->stats,
                            gettext_noop ("# TCP sessions active"),
                            -1,
-                           GNUNET_NO);      
+                           GNUNET_NO);
   GNUNET_free_non_null (session->connect_addr);
   GNUNET_free (session);
 }
@@ -885,7 +892,7 @@ disconnect_session (struct Session *session)
 
 /**
  * Given two otherwise equivalent sessions, pick the better one.
- * 
+ *
  * @param s1 one session (also default)
  * @param s2 other session
  * @return "better" session (more active)
@@ -934,6 +941,7 @@ run_gnunet_nat_client (struct Plugin *plugin, const char *addr, size_t addrlen)
   char *port_as_string;
   pid_t pid;
   const struct sockaddr *sa = (const struct sockaddr *)addr;
+
 #if DEBUG_TCP_NAT
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                   _("called run_gnunet_nat_client addrlen %d others are %d and %d\n"), addrlen, sizeof (struct sockaddr), sizeof (struct sockaddr_in));
@@ -1041,7 +1049,7 @@ tcp_plugin_send (void *cls,
   GNUNET_STATISTICS_update (plugin->env->stats,
                            gettext_noop ("# bytes TCP was asked to transmit"),
                            msgbuf_size,
-                           GNUNET_NO);      
+                           GNUNET_NO);
   /* FIXME: we could do this cheaper with a hash table
      where we could restrict the iteration to entries that match
      the target peer... */
@@ -1050,17 +1058,17 @@ tcp_plugin_send (void *cls,
     {
       cand_session = NULL;
       next = plugin->sessions;
-      while (NULL != (session = next)) 
+      while (NULL != (session = next))
        {
          next = session->next;
          GNUNET_assert (session->client != NULL);
          if (0 != memcmp (target,
-                          &session->target, 
+                          &session->target,
                           sizeof (struct GNUNET_PeerIdentity)))
            continue;
          if ( ( (GNUNET_SYSERR == force_address) &&
                 (session->expecting_welcome == GNUNET_NO) ) ||
-              (GNUNET_NO == force_address) )   
+              (GNUNET_NO == force_address) )
            {
              cand_session = select_better_session (cand_session,
                                                    session);
@@ -1074,16 +1082,16 @@ tcp_plugin_send (void *cls,
              GNUNET_break (0);
              break;
            }
-         if (session->inbound == GNUNET_YES) 
+         if (session->inbound == GNUNET_YES)
            continue;
-         if (addrlen != session->connect_alen)
+         if ((addrlen != session->connect_alen) && (session->is_nat == GNUNET_NO))
            continue;
-         if (0 != memcmp (session->connect_addr,
+         if ((0 != memcmp (session->connect_addr,
                           addr,
-                          addrlen))
+                          addrlen)) && (session->is_nat == GNUNET_NO))
            continue;
          cand_session = select_better_session (cand_session,
-                                               session);             
+                                               session);       
        }
       session = cand_session;
     }
@@ -1091,15 +1099,14 @@ tcp_plugin_send (void *cls,
        (addr == NULL) )
     {
 #if DEBUG_TCP
-      GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                       "tcp",
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                        "Asked to transmit to `%4s' without address and I have no existing connection (failing).\n",
                        GNUNET_i2s (target));
 #endif
       GNUNET_STATISTICS_update (plugin->env->stats,
                                gettext_noop ("# bytes discarded by TCP (no address and no connection)"),
                                msgbuf_size,
-                               GNUNET_NO);      
+                               GNUNET_NO);
       return -1;
     }
   if (session == NULL)
@@ -1118,7 +1125,7 @@ tcp_plugin_send (void *cls,
            is_natd = GNUNET_YES;
          memcpy (&a6.sin6_addr,
                  &t6->ipv6_addr,
-                 sizeof (struct in6_addr));      
+                 sizeof (struct in6_addr));
          sb = &a6;
          sbs = sizeof (a6);
        }
@@ -1151,12 +1158,12 @@ tcp_plugin_send (void *cls,
         return -1; /* NAT client only works with IPv4 addresses */
 
 
-      if ( (plugin->allow_nat == GNUNET_YES) && (is_natd == GNUNET_YES) &&
+      if ((plugin->allow_nat == GNUNET_YES) && (is_natd == GNUNET_YES) &&
            (GNUNET_NO == GNUNET_CONTAINER_multihashmap_contains(plugin->nat_wait_conns, &target->hashPubKey)))
         {
 #if DEBUG_TCP_NAT
-          GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                           _("Found valid IPv4 NAT address!\n"));
+          GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
+                           _("Found valid IPv4 NAT address (creating session)!\n"));
 #endif
           session = create_session (plugin,
                                     target,
@@ -1166,8 +1173,8 @@ tcp_plugin_send (void *cls,
           pm = GNUNET_malloc (sizeof (struct PendingMessage) + msgbuf_size);
          /* FIXME: the memset of this malloc can be up to 2% of our total runtime */
           pm->msg = (const char*) &pm[1];
-          memcpy (&pm[1], msg, msgbuf_size); 
-         /* FIXME: this memcpy can be up to 7% of our total run-time 
+          memcpy (&pm[1], msg, msgbuf_size);
+         /* FIXME: this memcpy can be up to 7% of our total run-time
             (for transport service) */
           pm->message_size = msgbuf_size;
           pm->timeout = GNUNET_TIME_relative_to_absolute (timeout);
@@ -1182,12 +1189,12 @@ tcp_plugin_send (void *cls,
 
           GNUNET_assert(GNUNET_CONTAINER_multihashmap_put(plugin->nat_wait_conns, &target->hashPubKey, session, GNUNET_CONTAINER_MULTIHASHMAPOPTION_UNIQUE_ONLY) == GNUNET_OK);
 #if DEBUG_TCP_NAT
-          GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+          GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
                            "Created NAT WAIT connection to `%4s' at `%s'\n",
                            GNUNET_i2s (target),
                            GNUNET_a2s (sb, sbs));
 #endif
-          run_gnunet_nat_client(plugin, sb, sbs);
+          run_gnunet_nat_client (plugin, sb, sbs);
           return 0;
         }
       else if ((plugin->allow_nat == GNUNET_YES) && (is_natd == GNUNET_YES) && (GNUNET_YES == GNUNET_CONTAINER_multihashmap_contains(plugin->nat_wait_conns, &target->hashPubKey)))
@@ -1200,8 +1207,7 @@ tcp_plugin_send (void *cls,
       if (sa == NULL)
        {
 #if DEBUG_TCP
-         GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                          "tcp",
+         GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                           "Failed to create connection to `%4s' at `%s'\n",
                           GNUNET_i2s (target),
                           GNUNET_a2s (sb, sbs));
@@ -1209,12 +1215,11 @@ tcp_plugin_send (void *cls,
          GNUNET_STATISTICS_update (plugin->env->stats,
                                    gettext_noop ("# bytes discarded by TCP (failed to connect)"),
                                    msgbuf_size,
-                                   GNUNET_NO);      
+                                   GNUNET_NO);
          return -1;
        }
 #if DEBUG_TCP
-      GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                       "tcp",
+      GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
                        "Asked to transmit to `%4s', creating fresh session using address `%s'.\n",
                       GNUNET_i2s (target),
                       GNUNET_a2s (sb, sbs));
@@ -1234,7 +1239,7 @@ tcp_plugin_send (void *cls,
   GNUNET_STATISTICS_update (plugin->env->stats,
                            gettext_noop ("# bytes currently in TCP buffers"),
                            msgbuf_size,
-                           GNUNET_NO);      
+                           GNUNET_NO);
   /* create new message entry */
   pm = GNUNET_malloc (sizeof (struct PendingMessage) + msgbuf_size);
   pm->msg = (const char*) &pm[1];
@@ -1250,8 +1255,7 @@ tcp_plugin_send (void *cls,
                                     session->pending_messages_tail,
                                     pm);
 #if DEBUG_TCP
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                   "tcp",
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                   "Asked to transmit %u bytes to `%s', added message to list.\n",
                   msgbuf_size,
                   GNUNET_i2s (target));
@@ -1287,8 +1291,7 @@ tcp_plugin_disconnect (void *cls,
   struct PendingMessage *pm;
 
 #if DEBUG_TCP
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                  "tcp",
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                    "Asked to cancel session with `%4s'\n",
                    GNUNET_i2s (target));
 #endif
@@ -1400,7 +1403,7 @@ tcp_plugin_address_pretty_printer (void *cls,
       a6.sin6_port = t6->t6_port;
       memcpy (&a6.sin6_addr,
              &t6->ipv6_addr,
-             sizeof (struct in6_addr));      
+             sizeof (struct in6_addr));
       port = ntohs (t6->t6_port);
       sb = &a6;
       sbs = sizeof (a6);
@@ -1460,7 +1463,7 @@ check_port (struct Plugin *plugin, uint16_t in_port)
 }
 
 
-/** 
+/**
  * Function that will be called to check if a binary address for this
  * plugin is well-formed and corresponds to an address for THIS peer
  * (as per our configuration).  Naturally, if absolutely necessary,
@@ -1476,8 +1479,8 @@ check_port (struct Plugin *plugin, uint16_t in_port)
  *         and transport, GNUNET_SYSERR if not
  */
 static int
-tcp_plugin_check_address (void *cls, 
-                         const void *addr, 
+tcp_plugin_check_address (void *cls,
+                         const void *addr,
                          size_t addrlen)
 {
   struct Plugin *plugin = cls;
@@ -1510,7 +1513,7 @@ tcp_plugin_check_address (void *cls,
          GNUNET_break_op (0);
          return GNUNET_SYSERR;
        }
-      if (GNUNET_OK != 
+      if (GNUNET_OK !=
          check_port (plugin, ntohs (v6->t6_port)))
        return GNUNET_SYSERR;
       if (GNUNET_OK !=
@@ -1576,17 +1579,18 @@ handle_tcp_nat_probe (void *cls,
       GNUNET_SERVER_client_keep (client);
       session->client = client;
       session->last_activity = GNUNET_TIME_absolute_get ();
+      session->inbound = GNUNET_NO;
 
       if (GNUNET_OK ==
           GNUNET_SERVER_client_get_address (client, &vaddr, &alen))
         {
 #if DEBUG_TCP_NAT
-          GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+          GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
                            "Found address `%s' for incoming connection %p\n",
                            GNUNET_a2s (vaddr, alen),
                            client);
 #endif
-          if (alen == sizeof (struct sockaddr_in))
+          if (((const struct sockaddr *)vaddr)->sa_family == AF_INET)
             {
               s4 = vaddr;
               t4 = GNUNET_malloc (sizeof (struct IPv4TcpAddress));
@@ -1595,7 +1599,7 @@ handle_tcp_nat_probe (void *cls,
               session->connect_addr = t4;
               session->connect_alen = sizeof (struct IPv4TcpAddress);
             }
-          else if (alen == sizeof (struct sockaddr_in6))
+          else if (((const struct sockaddr *)vaddr)->sa_family == AF_INET6)
             {
               s6 = vaddr;
               t6 = GNUNET_malloc (sizeof (struct IPv6TcpAddress));
@@ -1606,12 +1610,13 @@ handle_tcp_nat_probe (void *cls,
               session->connect_addr = t6;
               session->connect_alen = sizeof (struct IPv6TcpAddress);
             }
-
-          session->connect_addr = GNUNET_malloc (alen);
-          memcpy (session->connect_addr,
-                  vaddr,
-                  alen);
-          session->connect_alen = alen;
+          else
+            {
+#if DEBUG_TCP_NAT
+              GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                          "Bad address for incoming connection!\n");
+#endif
+            }
           GNUNET_free (vaddr);
         }
 
@@ -1629,6 +1634,8 @@ handle_tcp_nat_probe (void *cls,
       GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Did NOT find session for NAT probe!\n");
 #endif
     }
+
+  GNUNET_SERVER_receive_done (client, GNUNET_OK);
 }
 
 /**
@@ -1654,22 +1661,26 @@ handle_tcp_welcome (void *cls,
   const struct sockaddr_in *s4;
   const struct sockaddr_in6 *s6;
 
-
 #if DEBUG_TCP
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                   "tcp",
-                   "Received %s message from a `%4s/%p'.\n", 
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                   "Received %s message from a `%4s/%p'.\n",
                   "WELCOME",
                    GNUNET_i2s (&wm->clientIdentity), client);
 #endif
   GNUNET_STATISTICS_update (plugin->env->stats,
                            gettext_noop ("# TCP WELCOME messages received"),
                            1,
-                           GNUNET_NO);      
+                           GNUNET_NO);
   session = find_session_by_client (plugin, client);
   if (session == NULL)
     {
       GNUNET_SERVER_client_keep (client);
+#if DEBUG_TCP_NAT
+      GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
+                       "Received %s message from a `%4s/%p', creating session\n",
+                       "WELCOME",
+                       GNUNET_i2s (&wm->clientIdentity), client);
+#endif
       session = create_session (plugin,
                                &wm->clientIdentity, client, GNUNET_NO);
       session->inbound = GNUNET_YES;
@@ -1677,8 +1688,7 @@ handle_tcp_welcome (void *cls,
          GNUNET_SERVER_client_get_address (client, &vaddr, &alen))
        {
 #if DEBUG_TCP
-         GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                          "tcp",
+         GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                           "Found address `%s' for incoming connection %p\n",
                           GNUNET_a2s (vaddr, alen),
                           client);
@@ -1708,14 +1718,12 @@ handle_tcp_welcome (void *cls,
       else
         {
 #if DEBUG_TCP
-         GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                          "tcp",
+         GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                           "Did not obtain TCP socket address for incoming connection\n");
 #endif
         }
 #if DEBUG_TCP
-      GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                       "tcp",
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                        "Creating new session %p for connection %p\n",
                        session, client);
 #endif
@@ -1749,13 +1757,13 @@ delayed_done (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
   session->receive_delay_task = GNUNET_SCHEDULER_NO_TASK;
   delay = session->plugin->env->receive (session->plugin->env->cls,
                                         &session->target,
-                                        NULL, 0, 
+                                        NULL, 0,
                                         session,
                                         NULL, 0);
   if (delay.value == 0)
     GNUNET_SERVER_receive_done (session->client, GNUNET_OK);
   else
-    session->receive_delay_task = 
+    session->receive_delay_task =
       GNUNET_SCHEDULER_add_delayed (session->plugin->env->sched,
                                    delay, &delayed_done, session);
 }
@@ -1782,8 +1790,8 @@ handle_tcp_data (void *cls,
     {
       /* We don't want to propagate WELCOME and NAT Probe messages up! */
       GNUNET_SERVER_receive_done (client, GNUNET_OK);
-      return; 
-    }    
+      return;
+    }
   session = find_session_by_client (plugin, client);
   if ( (NULL == session) || (GNUNET_YES == session->expecting_welcome))
     {
@@ -1792,25 +1800,24 @@ handle_tcp_data (void *cls,
     }
   session->last_activity = GNUNET_TIME_absolute_get ();
 #if DEBUG_TCP
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                   "tcp", 
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                   "Passing %u bytes of type %u from `%4s' to transport service.\n",
-                   (unsigned int) ntohs (message->size), 
+                   (unsigned int) ntohs (message->size),
                   (unsigned int) ntohs (message->type),
                   GNUNET_i2s (&session->target));
 #endif
   GNUNET_STATISTICS_update (plugin->env->stats,
                            gettext_noop ("# bytes received via TCP"),
                            ntohs (message->size),
-                           GNUNET_NO); 
+                           GNUNET_NO);
   delay = plugin->env->receive (plugin->env->cls, &session->target, message, 1,
-                               session, 
+                               session,
                                (GNUNET_YES == session->inbound) ? NULL : session->connect_addr,
                                (GNUNET_YES == session->inbound) ? 0 : session->connect_alen);
   if (delay.value == 0)
     GNUNET_SERVER_receive_done (client, GNUNET_OK);
   else
-    session->receive_delay_task = 
+    session->receive_delay_task =
       GNUNET_SCHEDULER_add_delayed (session->plugin->env->sched,
                                    delay, &delayed_done, session);
 }
@@ -1824,7 +1831,7 @@ handle_tcp_data (void *cls,
  * @param client identification of the client
  */
 static void
-disconnect_notify (void *cls, 
+disconnect_notify (void *cls,
                   struct GNUNET_SERVER_Client *client)
 {
   struct Plugin *plugin = cls;
@@ -1836,8 +1843,7 @@ disconnect_notify (void *cls,
   if (session == NULL)
     return;                     /* unknown, nothing to do */
 #if DEBUG_TCP
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
-                   "tcp",
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                    "Destroying session of `%4s' with %s (%p) due to network-level disconnect.\n",
                    GNUNET_i2s (&session->target),
                    (session->connect_addr != NULL) ?
@@ -1876,12 +1882,19 @@ process_interfaces (void *cls,
   void *arg;
   uint16_t args;
   void *arg_nat;
+  char buf[INET_ADDRSTRLEN];
 
   af = addr->sa_family;
   arg_nat = NULL;
   if (af == AF_INET)
     {
       t4.ipv4_addr = ((struct sockaddr_in *) addr)->sin_addr.s_addr;
+      GNUNET_assert(NULL != inet_ntop(AF_INET, &t4.ipv4_addr, &buf[0], INET_ADDRSTRLEN));
+      if ((plugin->bind_address != NULL) && (0 != strcmp(buf, plugin->bind_address)))
+        {
+          GNUNET_log(GNUNET_ERROR_TYPE_DEBUG, "%s: Not notifying transport of address %s\n", "TCP", GNUNET_a2s (addr, addrlen));
+          return GNUNET_OK;
+        }
       add_to_address_list (plugin, &t4.ipv4_addr, sizeof (uint32_t));
       if ((plugin->behind_nat == GNUNET_YES) && (plugin->only_nat_addresses == GNUNET_YES))
         t4.t_port = htons(0);
@@ -1898,7 +1911,7 @@ process_interfaces (void *cls,
     }
   else if (af == AF_INET6)
     {
-      if (IN6_IS_ADDR_LINKLOCAL (&((struct sockaddr_in6 *) addr)->sin6_addr))
+      if ((IN6_IS_ADDR_LINKLOCAL (&((struct sockaddr_in6 *) addr)->sin6_addr)) || (GNUNET_YES == GNUNET_CONFIGURATION_get_value_yesno(plugin->env->cfg, "transport-tcp", "disablev6")))
        {
          /* skip link local addresses */
          return GNUNET_OK;
@@ -1927,11 +1940,9 @@ process_interfaces (void *cls,
       GNUNET_break (0);
       return GNUNET_OK;
     }
-  GNUNET_log_from (GNUNET_ERROR_TYPE_INFO |
-                   GNUNET_ERROR_TYPE_BULK,
-                   "tcp", 
-                  _("Found address `%s' (%s)\n"),
-                   GNUNET_a2s (addr, addrlen), name);
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                  _("Found address `%s' (%s) len %d\n"),
+                   GNUNET_a2s (addr, addrlen), name, args);
 
   plugin->env->notify_address (plugin->env->cls,
                                "tcp",
@@ -1939,11 +1950,9 @@ process_interfaces (void *cls,
 
   if (arg_nat != NULL)
     {
-      GNUNET_log_from (GNUNET_ERROR_TYPE_INFO |
-                       GNUNET_ERROR_TYPE_BULK,
-                      "tcp",
-                      _("Found address `%s' (%s)\n"),
-                      GNUNET_a2s (addr, addrlen), name);
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                      _("Found address `%s' (%s) len %d\n"),
+                      GNUNET_a2s (addr, addrlen), name, args);
       plugin->env->notify_address (plugin->env->cls,
                                    "tcp",
                                    arg_nat, args, GNUNET_TIME_UNIT_FOREVER_REL);
@@ -2034,13 +2043,12 @@ tcp_plugin_server_read (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc
   if (bytes < 1)
     {
 #if DEBUG_TCP_NAT
-      GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                       _("Finished reading from server stdout with code: %d\n"), bytes);
 #endif
       return;
     }
 
-  port = 0;
   port_start = NULL;
   for (i = 0; i < sizeof(mybuf); i++)
     {
@@ -2092,6 +2100,8 @@ tcp_plugin_server_read (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc
    */
   sock = GNUNET_CONNECTION_create_from_sockaddr (plugin->env->sched, AF_INET, (struct sockaddr *)&in_addr,
                                                  sizeof(in_addr));
+
+
   if (sock == NULL)
     {
       plugin->server_read_task =
@@ -2102,10 +2112,10 @@ tcp_plugin_server_read (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc
     }
   else
     {
-      GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                 _("Sending TCP probe message!\n"), &mybuf, port);
-      tcp_probe_ctx = GNUNET_malloc(sizeof(struct TCPProbeContext));
 
+      tcp_probe_ctx = GNUNET_malloc(sizeof(struct TCPProbeContext));
       tcp_probe_ctx->message.header.size = htons(sizeof(struct TCP_NAT_ProbeMessage));
       tcp_probe_ctx->message.header.type = htons(GNUNET_MESSAGE_TYPE_TRANSPORT_TCP_NAT_PROBE);
       memcpy(&tcp_probe_ctx->message.clientIdentity, plugin->env->my_identity, sizeof(struct GNUNET_PeerIdentity));
@@ -2118,6 +2128,7 @@ tcp_plugin_server_read (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc
 
     }
 
+  /*GNUNET_SERVER_connect_socket(plugin->server, sock);*/
   plugin->server_read_task =
       GNUNET_SCHEDULER_add_read_file (plugin->env->sched,
                                       GNUNET_TIME_UNIT_FOREVER_REL,
@@ -2270,11 +2281,9 @@ libgnunet_plugin_transport_tcp_init (void *cls)
   service = GNUNET_SERVICE_start ("transport-tcp", env->sched, env->cfg);
   if (service == NULL)
     {
-      GNUNET_log_from (GNUNET_ERROR_TYPE_WARNING,
-                       "tcp",
-                       _
-                       ("Failed to start service for `%s' transport plugin.\n"),
-                       "tcp");
+      GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
+                 _("Failed to start service for `%s' transport plugin.\n"),
+                 "tcp");
       return NULL;
     }
 
@@ -2290,7 +2299,7 @@ libgnunet_plugin_transport_tcp_init (void *cls)
       else
         {
           behind_nat = GNUNET_NO;
-          GNUNET_log_from (GNUNET_ERROR_TYPE_WARNING, "tcp", "Configuration specified you are behind a NAT, but gnunet-nat-server is not installed properly (suid bit not set)!\n");
+          GNUNET_log (GNUNET_ERROR_TYPE_WARNING, "Configuration specified you are behind a NAT, but gnunet-nat-server is not installed properly (suid bit not set)!\n");
         }
     }
   else
@@ -2305,7 +2314,7 @@ libgnunet_plugin_transport_tcp_init (void *cls)
       else
       {
         allow_nat = GNUNET_NO;
-        GNUNET_log_from (GNUNET_ERROR_TYPE_WARNING, "tcp", "Configuration specified you want to connect to NAT'd peers, but gnunet-nat-client is not installed properly (suid bit not set)!\n");
+        GNUNET_log (GNUNET_ERROR_TYPE_WARNING, "Configuration specified you want to connect to NAT'd peers, but gnunet-nat-client is not installed properly (suid bit not set)!\n");
       }
     }
   else
@@ -2326,8 +2335,7 @@ libgnunet_plugin_transport_tcp_init (void *cls)
                                                 "EXTERNAL_ADDRESS",
                                                 &external_address)))
     {
-      GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR,
-                       "tcp",
+      GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                        _
                        ("Require EXTERNAL_ADDRESS for service `%s' in configuration (either BEHIND_NAT or ALLOW_NAT set to YES)!\n"),
                        "transport-tcp");
@@ -2337,7 +2345,7 @@ libgnunet_plugin_transport_tcp_init (void *cls)
 
   if ((external_address != NULL) && (inet_pton(AF_INET, external_address, &in_addr.sin_addr) != 1))
     {
-      GNUNET_log_from(GNUNET_ERROR_TYPE_WARNING, "udp", "Malformed EXTERNAL_ADDRESS %s given in configuration!\n", external_address);
+      GNUNET_log (GNUNET_ERROR_TYPE_WARNING, "Malformed EXTERNAL_ADDRESS %s given in configuration!\n", external_address);
     }
 
   internal_address = NULL;
@@ -2347,11 +2355,9 @@ libgnunet_plugin_transport_tcp_init (void *cls)
                                                 "INTERNAL_ADDRESS",
                                                 &internal_address)))
     {
-      GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR,
-                       "tcp",
-                       _
-                       ("Require INTERNAL_ADDRESS for service `%s' in configuration!\n"),
-                       "transport-tcp");
+      GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+                 _("Require INTERNAL_ADDRESS for service `%s' in configuration!\n"),
+                 "transport-tcp");
       GNUNET_SERVICE_stop (service);
       GNUNET_free_non_null(external_address);
       return NULL;
@@ -2359,7 +2365,7 @@ libgnunet_plugin_transport_tcp_init (void *cls)
 
   if ((internal_address != NULL) && (inet_pton(AF_INET, internal_address, &in_addr.sin_addr) != 1))
     {
-      GNUNET_log_from(GNUNET_ERROR_TYPE_WARNING, "udp", "Malformed INTERNAL_ADDRESS %s given in configuration!\n", internal_address);
+      GNUNET_log (GNUNET_ERROR_TYPE_WARNING, "Malformed INTERNAL_ADDRESS %s given in configuration!\n", internal_address);
     }
 
   aport = 0;
@@ -2375,8 +2381,7 @@ libgnunet_plugin_transport_tcp_init (void *cls)
                                                "ADVERTISED-PORT",
                                                &aport)) && (aport > 65535)))
     {
-      GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR,
-                       "tcp",
+      GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                        _
                        ("Require valid port number for service `%s' in configuration!\n"),
                        "transport-tcp");
@@ -2416,12 +2421,12 @@ libgnunet_plugin_transport_tcp_init (void *cls)
     plugin->handlers[i].callback_cls = plugin;
   GNUNET_SERVER_add_handlers (plugin->server, plugin->handlers);
 
-  if (behind_nat == GNUNET_YES)
+  if (plugin->behind_nat == GNUNET_YES)
     {
       if (GNUNET_YES != tcp_transport_start_nat_server(plugin))
         {
-          GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR,
-                           "tcp",
+          GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+
                            _
                            ("Failed to start %s required for NAT in %s!\n"),
                            "gnunet-nat-server"
@@ -2440,16 +2445,16 @@ libgnunet_plugin_transport_tcp_init (void *cls)
       GNUNET_assert(plugin->nat_wait_conns != NULL);
     }
 
-  GNUNET_log_from (GNUNET_ERROR_TYPE_INFO,
-                   "tcp", _("TCP transport listening on port %llu\n"), bport);
+  GNUNET_log (GNUNET_ERROR_TYPE_INFO, _("TCP transport listening on port %llu\n"), bport);
   if (aport != bport)
-    GNUNET_log_from (GNUNET_ERROR_TYPE_INFO,
-                     "tcp",
+    GNUNET_log (GNUNET_ERROR_TYPE_INFO,
                      _("TCP transport advertises itself as being on port %llu\n"),
                      aport);
-  GNUNET_SERVER_disconnect_notify (plugin->server, 
+  GNUNET_SERVER_disconnect_notify (plugin->server,
                                   &disconnect_notify,
                                    plugin);
+  GNUNET_CONFIGURATION_get_value_string(env->cfg, "transport-tcp", "BINDTO", &plugin->bind_address);
+
   if (plugin->behind_nat == GNUNET_NO)
     {
       GNUNET_OS_network_interfaces_list (&process_interfaces, plugin);
@@ -2464,14 +2469,18 @@ libgnunet_plugin_transport_tcp_init (void *cls)
 
   if ((plugin->behind_nat == GNUNET_YES) && (inet_pton(AF_INET, plugin->external_address, &t4.ipv4_addr) == 1))
     {
+      GNUNET_log(GNUNET_ERROR_TYPE_DEBUG, "Notifying transport of address %s:0\n", plugin->external_address);
       t4.t_port = htons(0);
+      add_to_address_list (plugin, &t4.ipv4_addr, sizeof (uint32_t));
       plugin->env->notify_address (plugin->env->cls,
                                   "tcp",
-                                  &t4, sizeof(t4), GNUNET_TIME_UNIT_FOREVER_REL);
+                                   &t4, sizeof(t4), GNUNET_TIME_UNIT_FOREVER_REL);
     }
   else if ((plugin->external_address != NULL) && (inet_pton(AF_INET, plugin->external_address, &t4.ipv4_addr) == 1))
     {
       t4.t_port = htons(plugin->adv_port);
+      GNUNET_log(GNUNET_ERROR_TYPE_DEBUG, "Notifying transport of address %s:%d\n", plugin->external_address, plugin->adv_port);
+      add_to_address_list (plugin, &t4.ipv4_addr, sizeof (uint32_t));
       plugin->env->notify_address (plugin->env->cls,
                                    "tcp",
                                    &t4, sizeof(t4), GNUNET_TIME_UNIT_FOREVER_REL);
@@ -2515,7 +2524,7 @@ libgnunet_plugin_transport_tcp_done (void *cls)
         GNUNET_log_strerror (GNUNET_ERROR_TYPE_WARNING, "kill");
       GNUNET_OS_process_wait (plugin->server_pid);
     }
-
+  GNUNET_free_non_null(plugin->bind_address);
   GNUNET_free (plugin);
   GNUNET_free (api);
   return NULL;