-doxygen
[oweals/gnunet.git] / src / transport / plugin_transport_tcp.c
index 1850c3fdac458afe51ef6ed9d33b036ddb1a50fb..113cb70c553a9ac01ca054d8faeaaf5d5aa44ef8 100644 (file)
@@ -1,6 +1,6 @@
 /*
      This file is part of GNUnet
-     (C) 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Christian Grothoff (and other contributing authors)
+     (C) 2002--2013 Christian Grothoff (and other contributing authors)
 
      GNUnet is free software; you can redistribute it and/or modify
      it under the terms of the GNU General Public License as published
 #include "gnunet_transport_plugin.h"
 #include "transport.h"
 
-#define DEBUG_TCP GNUNET_EXTRA_LOGGING
-
-#define DEBUG_TCP_NAT GNUNET_EXTRA_LOGGING
+#define LOG(kind,...) GNUNET_log_from (kind, "transport-tcp",__VA_ARGS__)
 
+#define PLUGIN_NAME "tcp"
 
 /**
  * How long until we give up on establishing an NAT connection?
 
 GNUNET_NETWORK_STRUCT_BEGIN
 
+/**
+ * Address options
+ */
+static uint32_t myoptions;
+
 /**
  * Initial handshake message for a session.
  */
@@ -135,6 +139,11 @@ GNUNET_NETWORK_STRUCT_BEGIN
  */
 struct IPv4TcpAddress
 {
+       /**
+        * Optional options and flags for this address
+        */
+       uint32_t options;
+
   /**
    * IPv4 address, in network byte order.
    */
@@ -153,6 +162,11 @@ struct IPv4TcpAddress
  */
 struct IPv6TcpAddress
 {
+       /**
+        * Optional flags for this address
+        */
+       uint32_t options;
+
   /**
    * IPv6 address.
    */
@@ -226,16 +240,16 @@ struct PendingMessage
  */
 struct Session
 {
-
   /**
-   * API requirement.
+   * To whom are we talking to (set to our identity
+   * if we are still waiting for the welcome message)
    */
-  struct SessionHeader header;
+  struct GNUNET_PeerIdentity target;
 
   /**
-   * Stored in a linked list.
+   * API requirement.
    */
-  struct Session *next;
+  struct SessionHeader header;
 
   /**
    * Pointer to the global plugin struct.
@@ -267,18 +281,17 @@ struct Session
   /**
    * Handle for pending transmission request.
    */
-  struct GNUNET_CONNECTION_TransmitHandle *transmit_handle;
+  struct GNUNET_SERVER_TransmitHandle *transmit_handle;
 
   /**
-   * To whom are we talking to (set to our identity
-   * if we are still waiting for the welcome message)
+   * ID of task used to delay receiving more to throttle sender.
    */
-  struct GNUNET_PeerIdentity target;
+  GNUNET_SCHEDULER_TaskIdentifier receive_delay_task;
 
   /**
-   * ID of task used to delay receiving more to throttle sender.
+   * Session timeout task
    */
-  GNUNET_SCHEDULER_TaskIdentifier receive_delay_task;
+  GNUNET_SCHEDULER_TaskIdentifier timeout_task;
 
   /**
    * Address of the other peer (either based on our 'connect'
@@ -342,7 +355,10 @@ struct Plugin
    */
   struct GNUNET_NAT_Handle *nat;
 
-  struct GNUNET_CONTAINER_MultiHashMap * sessionmap;
+  /**
+   * Map from peer identities to sessions for the given peer.
+   */
+  struct GNUNET_CONTAINER_MultiPeerMap *sessionmap;
 
   /**
    * Handle to the network service.
@@ -363,7 +379,7 @@ struct Plugin
   /**
    * Map of peers we have tried to contact behind a NAT
    */
-  struct GNUNET_CONTAINER_MultiHashMap *nat_wait_conns;
+  struct GNUNET_CONTAINER_MultiPeerMap *nat_wait_conns;
 
   /**
    * List of active TCP probes.
@@ -385,6 +401,11 @@ struct Plugin
    */
   unsigned long long max_connections;
 
+  /**
+   * How many more TCP sessions do we have right now?
+   */
+  unsigned long long cur_connections;
+
   /**
    * ID of task used to update our addresses when one expires.
    */
@@ -404,6 +425,71 @@ struct Plugin
 };
 
 
+/**
+ * Start session timeout
+ */
+static void
+start_session_timeout (struct Session *s);
+
+
+/**
+ * Increment session timeout due to activity
+ */
+static void
+reschedule_session_timeout (struct Session *s);
+
+
+/**
+ * Cancel timeout
+ */
+static void
+stop_session_timeout (struct Session *s);
+
+
+/* DEBUG CODE */
+static const char *
+tcp_address_to_string (void *cls, const void *addr, size_t addrlen);
+
+
+static unsigned int sessions;
+
+
+static void
+inc_sessions (struct Plugin *plugin, struct Session *session, int line)
+{
+  sessions++;
+  unsigned int size = GNUNET_CONTAINER_multipeermap_size(plugin->sessionmap);
+  if (sessions != size)
+    LOG (GNUNET_ERROR_TYPE_DEBUG, "Inconsistent sessions %u <-> session map size: %u\n",
+        sessions, size);
+  LOG (GNUNET_ERROR_TYPE_DEBUG, "%4i Session increased to %u (session map size: %u): `%s' `%s'\n",
+      line,
+      sessions,
+      size,
+      GNUNET_i2s (&session->target),
+      tcp_address_to_string (NULL, session->addr, session->addrlen));
+}
+
+
+static void
+dec_sessions (struct Plugin *plugin, struct Session *session, int line)
+{
+  GNUNET_assert (sessions > 0);
+  unsigned int size = GNUNET_CONTAINER_multipeermap_size(plugin->sessionmap);
+  sessions--;
+  if (sessions != size)
+    LOG (GNUNET_ERROR_TYPE_DEBUG, "Inconsistent sessions %u <-> session map size: %u\n",
+      sessions, size);
+  LOG (GNUNET_ERROR_TYPE_DEBUG, "%4i Session decreased to %u (session map size: %u): `%s' `%s'\n",
+      line,
+      sessions,
+      size,
+      GNUNET_i2s (&session->target),
+      tcp_address_to_string (NULL, session->addr, session->addrlen));
+}
+/* DEBUG CODE */
+
+
 /**
  * Function to check if an inbound connection is acceptable.
  * Mostly used to limit the total number of open connections
@@ -422,10 +508,12 @@ plugin_tcp_access_check (void *cls,
                          const struct sockaddr *addr, socklen_t addrlen)
 {
   struct Plugin *plugin = cls;
-
-  if (0 == plugin->max_connections)
+  LOG (GNUNET_ERROR_TYPE_DEBUG,
+       "Accepting new incoming TCP connection from `%s'\n",
+       GNUNET_a2s (addr, addrlen));
+  if (plugin->cur_connections >= plugin->max_connections)
     return GNUNET_NO;
-  plugin->max_connections--;
+  plugin->cur_connections ++;
   return GNUNET_YES;
 }
 
@@ -449,14 +537,17 @@ tcp_nat_port_map_callback (void *cls, int add_remove,
   void *arg;
   size_t args;
 
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
-                   "NPMC called with %d for address `%s'\n", add_remove,
-                   GNUNET_a2s (addr, addrlen));
+  LOG (GNUNET_ERROR_TYPE_INFO,
+       "NAT notification to %s address `%s'\n",
+       (GNUNET_YES == add_remove) ? "add" : "remove",
+       GNUNET_a2s (addr, addrlen));
   /* convert 'addr' to our internal format */
   switch (addr->sa_family)
   {
   case AF_INET:
     GNUNET_assert (addrlen == sizeof (struct sockaddr_in));
+    memset (&t4,0, sizeof (t4));
+    t4.options = htonl (myoptions);
     t4.ipv4_addr = ((struct sockaddr_in *) addr)->sin_addr.s_addr;
     t4.t4_port = ((struct sockaddr_in *) addr)->sin_port;
     arg = &t4;
@@ -464,8 +555,10 @@ tcp_nat_port_map_callback (void *cls, int add_remove,
     break;
   case AF_INET6:
     GNUNET_assert (addrlen == sizeof (struct sockaddr_in6));
+    memset (&t6, 0, sizeof (t6));
     memcpy (&t6.ipv6_addr, &((struct sockaddr_in6 *) addr)->sin6_addr,
             sizeof (struct in6_addr));
+    t6.options = htonl (myoptions);
     t6.t6_port = ((struct sockaddr_in6 *) addr)->sin6_port;
     arg = &t6;
     args = sizeof (t6);
@@ -475,7 +568,7 @@ tcp_nat_port_map_callback (void *cls, int add_remove,
     return;
   }
   /* modify our published address list */
-  plugin->env->notify_address (plugin->env->cls, add_remove, arg, args);
+  plugin->env->notify_address (plugin->env->cls, add_remove, arg, args, "tcp");
 }
 
 
@@ -502,29 +595,36 @@ tcp_address_to_string (void *cls, const void *addr, size_t addrlen)
   const struct IPv6TcpAddress *t6;
   int af;
   uint16_t port;
+  uint32_t options;
 
-  if (addrlen == sizeof (struct IPv6TcpAddress))
+  switch (addrlen)
   {
+  case sizeof (struct IPv6TcpAddress):
     t6 = addr;
     af = AF_INET6;
     port = ntohs (t6->t6_port);
+    options = ntohl (t6->options);
     memcpy (&a6, &t6->ipv6_addr, sizeof (a6));
     sb = &a6;
-  }
-  else if (addrlen == sizeof (struct IPv4TcpAddress))
-  {
+    break;
+  case sizeof (struct IPv4TcpAddress):
     t4 = addr;
     af = AF_INET;
     port = ntohs (t4->t4_port);
+    options = ntohl (t4->options);
     memcpy (&a4, &t4->ipv4_addr, sizeof (a4));
     sb = &a4;
-  }
-  else
-  {
-    GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR, "tcp",
-                     _("Unexpected address length: %u bytes\n"),
-                     (unsigned int) addrlen);
-    GNUNET_break (0);
+    break;
+  case 0:
+    {
+      GNUNET_snprintf (rbuf, sizeof (rbuf), "%s",
+               TRANSPORT_SESSION_INBOUND_STRING);
+      return rbuf;
+    }
+  default:
+    LOG (GNUNET_ERROR_TYPE_WARNING,
+               _("Unexpected address length: %u bytes\n"),
+               (unsigned int) addrlen);
     return NULL;
   }
   if (NULL == inet_ntop (af, sb, buf, INET6_ADDRSTRLEN))
@@ -532,8 +632,8 @@ tcp_address_to_string (void *cls, const void *addr, size_t addrlen)
     GNUNET_log_strerror (GNUNET_ERROR_TYPE_WARNING, "inet_ntop");
     return NULL;
   }
-  GNUNET_snprintf (rbuf, sizeof (rbuf), (af == AF_INET6) ? "[%s]:%u" : "%s:%u",
-                   buf, port);
+  GNUNET_snprintf (rbuf, sizeof (rbuf), (af == AF_INET6) ? "%s.%u.[%s]:%u" : "%s.%u.%s:%u",
+                   PLUGIN_NAME, options, buf, port);
   return rbuf;
 }
 
@@ -550,38 +650,95 @@ tcp_address_to_string (void *cls, const void *addr, size_t addrlen)
  *        If the function returns GNUNET_SYSERR, its contents are undefined.
  * @return GNUNET_OK on success, GNUNET_SYSERR on failure
  */
-int
+static int
 tcp_string_to_address (void *cls, const char *addr, uint16_t addrlen,
     void **buf, size_t *added)
 {
   struct sockaddr_storage socket_address;
-  int ret = GNUNET_STRINGS_to_address_ip (addr, addrlen,
-    &socket_address);
+  char *address;
+  char *plugin;
+  char *optionstr;
+  uint32_t options;
 
-  if (ret != GNUNET_OK)
+  /* Format tcp.options.address:port */
+  address = NULL;
+  plugin = NULL;
+  optionstr = NULL;
+  if ((NULL == addr) || (addrlen == 0))
+  {
+    GNUNET_break (0);
     return GNUNET_SYSERR;
+  }
+  if ('\0' != addr[addrlen - 1])
+  {
+    GNUNET_break (0);
+    return GNUNET_SYSERR;
+  }
+  if (strlen (addr) != addrlen - 1)
+  {
+    GNUNET_break (0);
+    return GNUNET_SYSERR;
+  }
+  plugin = GNUNET_strdup (addr);
+  optionstr = strchr (plugin, '.');
+  if (NULL == optionstr)
+  {
+    GNUNET_break (0);
+    GNUNET_free (plugin);
+    return GNUNET_SYSERR;
+  }
+  optionstr[0] = '\0';
+  optionstr ++;
+  options = atol (optionstr);
+  address = strchr (optionstr, '.');
+  if (NULL == address)
+  {
+    GNUNET_break (0);
+    GNUNET_free (plugin);
+    return GNUNET_SYSERR;
+  }
+  address[0] = '\0';
+  address ++;
 
-  if (socket_address.ss_family == AF_INET)
+  if (GNUNET_OK !=
+      GNUNET_STRINGS_to_address_ip (address, strlen (address),
+                                   &socket_address))
   {
-    struct IPv4TcpAddress *t4;
-    struct sockaddr_in *in4 = (struct sockaddr_in *) &socket_address;
-    t4 = GNUNET_malloc (sizeof (struct IPv4TcpAddress));
-    t4->ipv4_addr = in4->sin_addr.s_addr;
-    t4->t4_port = in4->sin_port;
-    *buf = t4;
-    *added = sizeof (struct IPv4TcpAddress);
+    GNUNET_break (0);
+    GNUNET_free (plugin);
+    return GNUNET_SYSERR;
   }
-  else if (socket_address.ss_family == AF_INET6)
+
+  GNUNET_free (plugin);
+  switch (socket_address.ss_family)
   {
-    struct IPv6TcpAddress *t6;
-    struct sockaddr_in6 *in6 = (struct sockaddr_in6 *) &socket_address;
-    t6 = GNUNET_malloc (sizeof (struct IPv6TcpAddress));
-    t6->ipv6_addr = in6->sin6_addr;
-    t6->t6_port = in6->sin6_port;
-    *buf = t6;
-    *added = sizeof (struct IPv6TcpAddress);
+  case AF_INET:
+    {
+      struct IPv4TcpAddress *t4;
+      struct sockaddr_in *in4 = (struct sockaddr_in *) &socket_address;
+      t4 = GNUNET_malloc (sizeof (struct IPv4TcpAddress));
+      t4->options =  htonl (options);
+      t4->ipv4_addr = in4->sin_addr.s_addr;
+      t4->t4_port = in4->sin_port;
+      *buf = t4;
+      *added = sizeof (struct IPv4TcpAddress);
+      return GNUNET_OK;
+    }
+  case AF_INET6:
+    {
+      struct IPv6TcpAddress *t6;
+      struct sockaddr_in6 *in6 = (struct sockaddr_in6 *) &socket_address;
+      t6 = GNUNET_malloc (sizeof (struct IPv6TcpAddress));
+      t6->options = htonl (options);
+      t6->ipv6_addr = in6->sin6_addr;
+      t6->t6_port = in6->sin6_port;
+      *buf = t6;
+      *added = sizeof (struct IPv6TcpAddress);
+      return GNUNET_OK;
+    }
+  default:
+    return GNUNET_SYSERR;
   }
-  return GNUNET_SYSERR;
 }
 
 
@@ -591,9 +748,11 @@ struct SessionClientCtx
   struct Session *ret;
 };
 
-int session_lookup_by_client_it (void *cls,
-               const GNUNET_HashCode * key,
-               void *value)
+
+static int
+session_lookup_by_client_it (void *cls,
+                            const struct GNUNET_PeerIdentity *key,
+                            void *value)
 {
   struct SessionClientCtx *sc_ctx = cls;
   struct Session *s = value;
@@ -606,6 +765,7 @@ int session_lookup_by_client_it (void *cls,
   return GNUNET_YES;
 }
 
+
 /**
  * Find the session handle for the given client.
  *
@@ -615,14 +775,13 @@ int session_lookup_by_client_it (void *cls,
  */
 static struct Session *
 lookup_session_by_client (struct Plugin *plugin,
-                        const struct GNUNET_SERVER_Client *client)
+                         const struct GNUNET_SERVER_Client *client)
 {
   struct SessionClientCtx sc_ctx;
+
   sc_ctx.client = client;
   sc_ctx.ret = NULL;
-
-  GNUNET_CONTAINER_multihashmap_iterate (plugin->sessionmap, &session_lookup_by_client_it, &sc_ctx);
-
+  GNUNET_CONTAINER_multipeermap_iterate (plugin->sessionmap, &session_lookup_by_client_it, &sc_ctx);
   return sc_ctx.ret;
 }
 
@@ -632,7 +791,7 @@ lookup_session_by_client (struct Plugin *plugin,
  *
  * @param plugin the plugin
  * @param target peer to connect to
- * @param client client to use
+ * @param client client to use, reference counter must have already been increased
  * @param is_nat this a NAT session, we should wait for a client to
  *               connect to us from an address, then assign that to
  *               the session
@@ -642,27 +801,26 @@ static struct Session *
 create_session (struct Plugin *plugin, const struct GNUNET_PeerIdentity *target,
                 struct GNUNET_SERVER_Client *client, int is_nat)
 {
-  struct Session *ret;
+  struct Session *session;
   struct PendingMessage *pm;
   struct WelcomeMessage welcome;
 
-  if (is_nat != GNUNET_YES)
-    GNUNET_assert (client != NULL);
+  if (GNUNET_YES != is_nat)
+    GNUNET_assert (NULL != client);
   else
-    GNUNET_assert (client == NULL);
-
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
-                   "Creating new session for peer `%4s'\n",
-                   GNUNET_i2s (target));
-
-  ret = GNUNET_malloc (sizeof (struct Session));
-  ret->last_activity = GNUNET_TIME_absolute_get ();
-  ret->plugin = plugin;
-  ret->is_nat = is_nat;
-  ret->client = client;
-  ret->target = *target;
-  ret->expecting_welcome = GNUNET_YES;
-  ret->ats_address_network_type = htonl (GNUNET_ATS_NET_UNSPECIFIED);
+    GNUNET_assert (NULL == client);
+
+  LOG (GNUNET_ERROR_TYPE_DEBUG,
+       "Creating new session for peer `%4s'\n",
+       GNUNET_i2s (target));
+  session = GNUNET_malloc (sizeof (struct Session));
+  session->last_activity = GNUNET_TIME_absolute_get ();
+  session->plugin = plugin;
+  session->is_nat = is_nat;
+  session->client = client;
+  session->target = *target;
+  session->expecting_welcome = GNUNET_YES;
+  session->ats_address_network_type = htonl (GNUNET_ATS_NET_UNSPECIFIED);
   pm = GNUNET_malloc (sizeof (struct PendingMessage) +
                       sizeof (struct WelcomeMessage));
   pm->msg = (const char *) &pm[1];
@@ -675,13 +833,17 @@ create_session (struct Plugin *plugin, const struct GNUNET_PeerIdentity *target,
   GNUNET_STATISTICS_update (plugin->env->stats,
                             gettext_noop ("# bytes currently in TCP buffers"),
                             pm->message_size, GNUNET_NO);
-  GNUNET_CONTAINER_DLL_insert (ret->pending_messages_head,
-                               ret->pending_messages_tail, pm);
-  if (is_nat != GNUNET_YES)
+  GNUNET_CONTAINER_DLL_insert (session->pending_messages_head,
+                               session->pending_messages_tail, pm);
+  if (GNUNET_YES != is_nat)
+  {
     GNUNET_STATISTICS_update (plugin->env->stats,
                               gettext_noop ("# TCP sessions active"), 1,
                               GNUNET_NO);
-  return ret;
+  }
+  start_session_timeout (session);
+
+  return session;
 }
 
 
@@ -719,31 +881,27 @@ do_transmit (void *cls, size_t size, void *buf)
   char *cbuf;
   size_t ret;
 
-  GNUNET_assert (session != NULL);
+  GNUNET_assert (NULL != session);
   session->transmit_handle = NULL;
   plugin = session->plugin;
-  if (buf == NULL)
+  if (NULL == buf)
   {
-#if DEBUG_TCP
-    GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
-                     "Timeout trying to transmit to peer `%4s', discarding message queue.\n",
-                     GNUNET_i2s (&session->target));
-#endif
+    LOG (GNUNET_ERROR_TYPE_DEBUG,
+        "Timeout trying to transmit to peer `%4s', discarding message queue.\n",
+        GNUNET_i2s (&session->target));
     /* timeout; cancel all messages that have already expired */
     hd = NULL;
     tl = NULL;
     ret = 0;
     now = GNUNET_TIME_absolute_get ();
     while ((NULL != (pos = session->pending_messages_head)) &&
-           (pos->timeout.abs_value <= now.abs_value))
+           (pos->timeout.abs_value_us <= now.abs_value_us))
     {
       GNUNET_CONTAINER_DLL_remove (session->pending_messages_head,
                                    session->pending_messages_tail, pos);
-#if DEBUG_TCP
-      GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
-                       "Failed to transmit %u byte message to `%4s'.\n",
-                       pos->message_size, GNUNET_i2s (&session->target));
-#endif
+      LOG (GNUNET_ERROR_TYPE_DEBUG,
+          "Failed to transmit %u byte message to `%4s'.\n",
+          pos->message_size, GNUNET_i2s (&session->target));
       ret += pos->message_size;
       GNUNET_CONTAINER_DLL_insert_after (hd, tl, tl, pos);
     }
@@ -758,7 +916,7 @@ do_transmit (void *cls, size_t size, void *buf)
     {
       GNUNET_CONTAINER_DLL_remove (hd, tl, pos);
       if (pos->transmit_cont != NULL)
-        pos->transmit_cont (pos->transmit_cont_cls, &pid, GNUNET_SYSERR);
+        pos->transmit_cont (pos->transmit_cont_cls, &pid, GNUNET_SYSERR, pos->message_size, 0);
       GNUNET_free (pos);
     }
     GNUNET_STATISTICS_update (plugin->env->stats,
@@ -782,9 +940,9 @@ do_transmit (void *cls, size_t size, void *buf)
     GNUNET_CONTAINER_DLL_remove (session->pending_messages_head,
                                  session->pending_messages_tail, pos);
     GNUNET_assert (size >= pos->message_size);
-    GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
-                     "Transmitting message of type %u\n",
-                     ntohs (((struct GNUNET_MessageHeader *) pos->msg)->type));
+    LOG (GNUNET_ERROR_TYPE_DEBUG,
+        "Transmitting message of type %u\n",
+        ntohs (((struct GNUNET_MessageHeader *) pos->msg)->type));
     /* FIXME: this memcpy can be up to 7% of our total runtime */
     memcpy (cbuf, pos->msg, pos->message_size);
     cbuf += pos->message_size;
@@ -804,15 +962,13 @@ do_transmit (void *cls, size_t size, void *buf)
   {
     GNUNET_CONTAINER_DLL_remove (hd, tl, pos);
     if (pos->transmit_cont != NULL)
-      pos->transmit_cont (pos->transmit_cont_cls, &pid, GNUNET_OK);
+      pos->transmit_cont (pos->transmit_cont_cls, &pid, GNUNET_OK, pos->message_size, pos->message_size); /* FIXME: include TCP overhead */
     GNUNET_free (pos);
   }
   GNUNET_assert (hd == NULL);
   GNUNET_assert (tl == NULL);
-#if DEBUG_TCP > 1
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp", "Transmitting %u bytes\n",
+  LOG (GNUNET_ERROR_TYPE_DEBUG, "Transmitting %u bytes\n",
                    ret);
-#endif
   GNUNET_STATISTICS_update (plugin->env->stats,
                             gettext_noop ("# bytes currently in TCP buffers"),
                             -(int64_t) ret, GNUNET_NO);
@@ -861,25 +1017,32 @@ disconnect_session (struct Session *session)
   struct PendingMessage *pm;
   struct Plugin * plugin = session->plugin;
 
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
-                   "Disconnecting session %p for peer `%s' address `%s'\n",
-                   session,
-                   GNUNET_i2s (&session->target),
-                   tcp_address_to_string(NULL, session->addr, session->addrlen));
+  LOG (GNUNET_ERROR_TYPE_DEBUG,
+       "Disconnecting session of peer `%s' address `%s'\n",
+       GNUNET_i2s (&session->target),
+       tcp_address_to_string (NULL, session->addr, session->addrlen));
 
-  GNUNET_assert (GNUNET_YES  == GNUNET_CONTAINER_multihashmap_remove(plugin->sessionmap, &session->target.hashPubKey, session) ||
-                 GNUNET_YES  == GNUNET_CONTAINER_multihashmap_remove(plugin->nat_wait_conns, &session->target.hashPubKey, session));
+  stop_session_timeout (session);
+
+  if (GNUNET_YES == GNUNET_CONTAINER_multipeermap_remove (plugin->sessionmap, &session->target, session))
+  {
+    GNUNET_STATISTICS_update (session->plugin->env->stats,
+                             gettext_noop ("# TCP sessions active"), -1,
+                             GNUNET_NO);
+    dec_sessions (plugin, session, __LINE__);
+  }
+  else GNUNET_assert (GNUNET_YES == GNUNET_CONTAINER_multipeermap_remove (plugin->nat_wait_conns, &session->target, session));
 
   /* clean up state */
   if (session->transmit_handle != NULL)
   {
-    GNUNET_CONNECTION_notify_transmit_ready_cancel (session->transmit_handle);
+    GNUNET_SERVER_notify_transmit_ready_cancel (session->transmit_handle);
     session->transmit_handle = NULL;
   }
   session->plugin->env->session_end (session->plugin->env->cls,
                                      &session->target, session);
 
-  if (session->nat_connection_timeout != GNUNET_SCHEDULER_NO_TASK)
+  if (GNUNET_SCHEDULER_NO_TASK != session->nat_connection_timeout)
   {
     GNUNET_SCHEDULER_cancel (session->nat_connection_timeout);
     session->nat_connection_timeout = GNUNET_SCHEDULER_NO_TASK;
@@ -887,13 +1050,11 @@ disconnect_session (struct Session *session)
 
   while (NULL != (pm = session->pending_messages_head))
   {
-#if DEBUG_TCP
-    GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
-                     pm->transmit_cont !=
-                     NULL ? "Could not deliver message to `%4s'.\n" :
-                     "Could not deliver message to `%4s', notifying.\n",
-                     GNUNET_i2s (&session->target));
-#endif
+    LOG (GNUNET_ERROR_TYPE_DEBUG,
+        pm->transmit_cont !=
+        NULL ? "Could not deliver message to `%4s'.\n" :
+        "Could not deliver message to `%4s', notifying.\n",
+        GNUNET_i2s (&session->target));
     GNUNET_STATISTICS_update (session->plugin->env->stats,
                               gettext_noop ("# bytes currently in TCP buffers"),
                               -(int64_t) pm->message_size, GNUNET_NO);
@@ -905,29 +1066,73 @@ disconnect_session (struct Session *session)
                                  session->pending_messages_tail, pm);
     if (NULL != pm->transmit_cont)
       pm->transmit_cont (pm->transmit_cont_cls, &session->target,
-                         GNUNET_SYSERR);
+                         GNUNET_SYSERR, pm->message_size, 0);
     GNUNET_free (pm);
   }
   if (session->receive_delay_task != GNUNET_SCHEDULER_NO_TASK)
   {
     GNUNET_SCHEDULER_cancel (session->receive_delay_task);
-    if (session->client != NULL)
+    if (NULL != session->client)
       GNUNET_SERVER_receive_done (session->client, GNUNET_SYSERR);
   }
-  if (session->client != NULL)
+  if (NULL != session->client)
   {
+    GNUNET_SERVER_client_disconnect (session->client);
     GNUNET_SERVER_client_drop (session->client);
     session->client = NULL;
   }
-  GNUNET_STATISTICS_update (session->plugin->env->stats,
-                            gettext_noop ("# TCP sessions active"), -1,
-                            GNUNET_NO);
   GNUNET_free_non_null (session->addr);
   GNUNET_assert (NULL == session->transmit_handle);
   GNUNET_free (session);
 }
 
 
+struct FindSessionContext
+{
+  struct Session *s;
+  int res;
+};
+
+
+static int
+session_it (void *cls,
+           const struct GNUNET_PeerIdentity * key,
+           void *value)
+{
+  struct FindSessionContext *res = cls;
+
+  if (res->s == value)
+  {
+    res->res = GNUNET_OK;
+    return GNUNET_NO;
+  }
+  return GNUNET_YES;
+}
+
+
+static int
+find_session (struct Plugin *plugin, struct Session *session)
+{
+  struct FindSessionContext session_map_res;
+  struct FindSessionContext nat_map_res;
+
+  session_map_res.s = session;
+  session_map_res.res = GNUNET_SYSERR;
+  GNUNET_CONTAINER_multipeermap_iterate (plugin->sessionmap, &session_it, &session_map_res);
+
+  nat_map_res.s = session;
+  nat_map_res.res = GNUNET_SYSERR;
+  GNUNET_CONTAINER_multipeermap_iterate (plugin->nat_wait_conns, &session_it, &nat_map_res);
+
+  if ((session_map_res.res == GNUNET_SYSERR) && (nat_map_res.res == GNUNET_SYSERR))
+  {
+    GNUNET_break (0);
+    return GNUNET_SYSERR;
+  }
+  return GNUNET_OK;
+}
+
+
 /**
  * Function that can be used by the transport service to transmit
  * a message using the plugin.   Note that in the case of a
@@ -966,8 +1171,15 @@ tcp_plugin_send (void *cls,
   struct Plugin * plugin = cls;
   struct PendingMessage *pm;
 
-  GNUNET_assert (plugin != NULL);
-  GNUNET_assert (session != NULL);
+  GNUNET_assert (NULL != plugin);
+  GNUNET_assert (NULL != session);
+
+  if (GNUNET_SYSERR == find_session(plugin, session))
+  {
+      LOG (GNUNET_ERROR_TYPE_ERROR,
+           _("Trying to send with invalid session %p\n"));
+      return GNUNET_SYSERR;
+  }
 
   /* create new message entry */
   pm = GNUNET_malloc (sizeof (struct PendingMessage) + msgbuf_size);
@@ -978,15 +1190,16 @@ tcp_plugin_send (void *cls,
   pm->transmit_cont = cont;
   pm->transmit_cont_cls = cont_cls;
 
+  LOG (GNUNET_ERROR_TYPE_DEBUG,
+       "Asked to transmit %u bytes to `%s', added message to list.\n",
+       msgbuf_size, GNUNET_i2s (&session->target));
 
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
-                   "Asked to transmit %u bytes to `%s', added message to list.\n",
-                   msgbuf_size, GNUNET_i2s (&session->target));
-
-  if (GNUNET_YES == GNUNET_CONTAINER_multihashmap_contains_value(plugin->sessionmap, &session->target.hashPubKey, session))
+  if (GNUNET_YES == GNUNET_CONTAINER_multipeermap_contains_value (plugin->sessionmap,
+                                                                 &session->target,
+                                                                 session))
   {
     GNUNET_assert (session->client != NULL);
-
+    reschedule_session_timeout (session);
     GNUNET_SERVER_client_set_timeout (session->client,
                                       GNUNET_CONSTANTS_IDLE_CONNECTION_TIMEOUT);
     GNUNET_STATISTICS_update (plugin->env->stats,
@@ -1000,12 +1213,12 @@ tcp_plugin_send (void *cls,
     process_pending_messages (session);
     return msgbuf_size;
   }
-  else if (GNUNET_YES == GNUNET_CONTAINER_multihashmap_contains_value(plugin->nat_wait_conns, &session->target.hashPubKey, session))
+  else if (GNUNET_YES == GNUNET_CONTAINER_multipeermap_contains_value(plugin->nat_wait_conns, &session->target, session))
   {
-    GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
-                     "This NAT WAIT session for peer `%s' is not yet ready!\n",
-                     GNUNET_i2s (&session->target));
-
+    LOG (GNUNET_ERROR_TYPE_DEBUG,
+        "This NAT WAIT session for peer `%s' is not yet ready!\n",
+        GNUNET_i2s (&session->target));
+    reschedule_session_timeout (session);
     GNUNET_STATISTICS_update (plugin->env->stats,
                               gettext_noop ("# bytes currently in TCP buffers"),
                               msgbuf_size, GNUNET_NO);
@@ -1017,36 +1230,41 @@ tcp_plugin_send (void *cls,
   }
   else
   {
-    if (cont != NULL)
-      cont (cont_cls, &session->target, GNUNET_SYSERR);
+    LOG (GNUNET_ERROR_TYPE_ERROR,
+         "Invalid session %p\n", session);
+    if (NULL != cont)
+      cont (cont_cls, &session->target, GNUNET_SYSERR, pm->message_size, 0);
     GNUNET_break (0);
     GNUNET_free (pm);
     return GNUNET_SYSERR; /* session does not exist here */
   }
 }
 
+
 struct SessionItCtx
 {
-  void * addr;
+  void *addr;
   size_t addrlen;
-  struct Session * result;
+  struct Session *result;
 };
 
-int session_lookup_it (void *cls,
-               const GNUNET_HashCode * key,
-               void *value)
+
+static int
+session_lookup_it (void *cls,
+                  const struct GNUNET_PeerIdentity *key,
+                  void *value)
 {
   struct SessionItCtx * si_ctx = cls;
   struct Session * session = value;
 #if 0
   char * a1 = strdup (tcp_address_to_string(NULL, session->addr, session->addrlen));
   char * a2 = strdup (tcp_address_to_string(NULL, si_ctx->addr, si_ctx->addrlen));
-  GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR, "tcp",
-                   "Comparing: %s %u <-> %s %u\n",
-                   a1,
-                   session->addrlen,
-                   a2,
-                   si_ctx->addrlen);
+  LOG (GNUNET_ERROR_TYPE_DEBUG,
+       "Comparing: %s %u <-> %s %u\n",
+       a1,
+       session->addrlen,
+       a2,
+       si_ctx->addrlen);
   GNUNET_free (a1);
   GNUNET_free (a2);
 #endif
@@ -1061,12 +1279,12 @@ int session_lookup_it (void *cls,
 #if 0
   a1 = strdup (tcp_address_to_string(NULL, session->addr, session->addrlen));
   a2 = strdup (tcp_address_to_string(NULL, si_ctx->addr, si_ctx->addrlen));
-  GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR, "tcp",
-                   "Comparing: %s %u <-> %s %u , OK!\n",
-                   a1,
-                   session->addrlen,
-                   a2,
-                   si_ctx->addrlen);
+  LOG (GNUNET_ERROR_TYPE_DEBUG,
+       "Comparing: %s %u <-> %s %u , OK!\n",
+       a1,
+       session->addrlen,
+       a2,
+       si_ctx->addrlen);
   GNUNET_free (a1);
   GNUNET_free (a2);
 #endif
@@ -1075,23 +1293,23 @@ int session_lookup_it (void *cls,
   return GNUNET_NO;
 }
 
+
 /**
  * Task cleaning up a NAT connection attempt after timeout
  */
-
 static void
 nat_connect_timeout (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
 {
   struct Session *session = cls;
 
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
-                   "NAT WAIT connection to `%4s' at `%s' could not be established, removing session\n",
-                   GNUNET_i2s (&session->target), tcp_address_to_string(NULL, session->addr, session->addrlen));
-
+  session->nat_connection_timeout = GNUNET_SCHEDULER_NO_TASK;
+  LOG (GNUNET_ERROR_TYPE_DEBUG,
+       "NAT WAIT connection to `%4s' at `%s' could not be established, removing session\n",
+       GNUNET_i2s (&session->target), tcp_address_to_string(NULL, session->addr, session->addrlen));
   disconnect_session (session);
-
 }
 
+
 /**
  * Create a new session to transmit data to the target
  * This session will used to send data to this peer and the plugin will
@@ -1103,11 +1321,10 @@ nat_connect_timeout (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
  */
 static struct Session *
 tcp_plugin_get_session (void *cls,
-                      const struct GNUNET_HELLO_Address *address)
+                       const struct GNUNET_HELLO_Address *address)
 {
-  struct Plugin * plugin = cls;
-  struct Session * session = NULL;
-
+  struct Plugin *plugin = cls;
+  struct Session *session = NULL;
   int af;
   const void *sb;
   size_t sbs;
@@ -1118,20 +1335,20 @@ tcp_plugin_get_session (void *cls,
   const struct IPv6TcpAddress *t6;
   struct GNUNET_ATS_Information ats;
   unsigned int is_natd = GNUNET_NO;
-  size_t addrlen = 0;
+  size_t addrlen;
 
   GNUNET_assert (plugin != NULL);
   GNUNET_assert (address != NULL);
-
   addrlen = address->address_length;
-
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
-                   "Trying to get session for `%s' address length %i\n",
-                   tcp_address_to_string(NULL, address->address, address->address_length),
-                   addrlen);
+  LOG (GNUNET_ERROR_TYPE_DEBUG,
+       "Trying to get session for `%s' address of peer `%s'\n",
+       tcp_address_to_string(NULL, address->address, address->address_length),
+       GNUNET_i2s (&address->peer));
 
   /* look for existing session */
-  if (GNUNET_CONTAINER_multihashmap_contains(plugin->sessionmap, &address->peer.hashPubKey))
+  if (GNUNET_YES ==
+      GNUNET_CONTAINER_multipeermap_contains (plugin->sessionmap,
+                                             &address->peer))
   {
     struct SessionItCtx si_ctx;
 
@@ -1140,17 +1357,23 @@ tcp_plugin_get_session (void *cls,
 
     si_ctx.result = NULL;
 
-    GNUNET_CONTAINER_multihashmap_get_multiple(plugin->sessionmap, &address->peer.hashPubKey, &session_lookup_it, &si_ctx);
+    GNUNET_CONTAINER_multipeermap_get_multiple (plugin->sessionmap,
+                                               &address->peer,
+                                               &session_lookup_it, &si_ctx);
     if (si_ctx.result != NULL)
     {
       session = si_ctx.result;
-      GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
-                       "Found exisiting session for `%s' address `%s' session %p\n",
-                       GNUNET_i2s (&address->peer),
-                       tcp_address_to_string(NULL, address->address, address->address_length),
-                       session);
+      LOG (GNUNET_ERROR_TYPE_DEBUG,
+          "Found existing session for `%s' address `%s' session %p\n",
+          GNUNET_i2s (&address->peer),
+          tcp_address_to_string(NULL, address->address, address->address_length),
+          session);
       return session;
     }
+    LOG (GNUNET_ERROR_TYPE_DEBUG,
+        "Existing sessions did not match address `%s' or peer `%s'\n",
+        tcp_address_to_string(NULL, address->address, address->address_length),
+        GNUNET_i2s (&address->peer));
   }
 
   if (addrlen == sizeof (struct IPv6TcpAddress))
@@ -1189,9 +1412,10 @@ tcp_plugin_get_session (void *cls,
   }
   else
   {
-    GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR, "tcp",
-                     _("Address of unexpected length: %u\n"), addrlen);
-    GNUNET_break (0);
+    GNUNET_STATISTICS_update (plugin->env->stats,
+                              gettext_noop
+                              ("# requests to create session with invalid address"),
+                              1, GNUNET_NO);
     return NULL;
   }
 
@@ -1203,7 +1427,7 @@ tcp_plugin_get_session (void *cls,
     return NULL;
   }
 
-  if (0 == plugin->max_connections)
+  if (plugin->cur_connections >= plugin->max_connections)
   {
     /* saturated */
     return NULL;
@@ -1211,8 +1435,8 @@ tcp_plugin_get_session (void *cls,
 
   if ((is_natd == GNUNET_YES) &&
       (GNUNET_YES ==
-       GNUNET_CONTAINER_multihashmap_contains (plugin->nat_wait_conns,
-                                               &address->peer.hashPubKey)))
+       GNUNET_CONTAINER_multipeermap_contains (plugin->nat_wait_conns,
+                                               &address->peer)))
   {
     /* Only do one NAT punch attempt per peer identity */
      return NULL;
@@ -1220,60 +1444,58 @@ tcp_plugin_get_session (void *cls,
 
   if ((is_natd == GNUNET_YES) && (NULL != plugin->nat) &&
       (GNUNET_NO ==
-       GNUNET_CONTAINER_multihashmap_contains (plugin->nat_wait_conns,
-                                               &address->peer.hashPubKey)))
+       GNUNET_CONTAINER_multipeermap_contains (plugin->nat_wait_conns,
+                                               &address->peer)))
   {
-#if DEBUG_TCP_NAT
-    GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
-                     _("Found valid IPv4 NAT address (creating session)!\n"));
-#endif
+    LOG (GNUNET_ERROR_TYPE_DEBUG,
+        "Found valid IPv4 NAT address (creating session)!\n") ;
     session = create_session (plugin, &address->peer, NULL, GNUNET_YES);
     session->addrlen = 0;
     session->addr = NULL;
     session->ats_address_network_type = ats.value;
-    session->nat_connection_timeout = GNUNET_SCHEDULER_add_delayed(NAT_TIMEOUT,
-        &nat_connect_timeout,
-        session);
+    session->nat_connection_timeout = GNUNET_SCHEDULER_add_delayed (NAT_TIMEOUT,
+                                                                   &nat_connect_timeout,
+                                                                   session);
     GNUNET_assert (session != NULL);
+    GNUNET_assert (GNUNET_OK ==
+                  GNUNET_CONTAINER_multipeermap_put (plugin->nat_wait_conns,
+                                                     &session->target,
+                                                     session,
+                                                     GNUNET_CONTAINER_MULTIHASHMAPOPTION_UNIQUE_ONLY));
 
-    GNUNET_assert (GNUNET_CONTAINER_multihashmap_put
-                   (plugin->nat_wait_conns, &address->peer.hashPubKey, session,
-                    GNUNET_CONTAINER_MULTIHASHMAPOPTION_UNIQUE_ONLY) == GNUNET_OK);
-
-    GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
-                     "Created NAT WAIT connection to `%4s' at `%s'\n",
-                     GNUNET_i2s (&session->target), GNUNET_a2s (sb, sbs));
+    LOG (GNUNET_ERROR_TYPE_DEBUG,
+        "Created NAT WAIT connection to `%4s' at `%s'\n",
+        GNUNET_i2s (&session->target), GNUNET_a2s (sb, sbs));
 
     if (GNUNET_OK == GNUNET_NAT_run_client (plugin->nat, &a4))
       return session;
     else
     {
-      GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
-                       "Running NAT client for `%4s' at `%s' failed\n",
-                       GNUNET_i2s (&session->target), GNUNET_a2s (sb, sbs));
-
+      LOG (GNUNET_ERROR_TYPE_DEBUG,
+          "Running NAT client for `%4s' at `%s' failed\n",
+          GNUNET_i2s (&session->target), GNUNET_a2s (sb, sbs));
       disconnect_session (session);
       return NULL;
     }
   }
 
   /* create new outbound session */
-  GNUNET_assert (0 != plugin->max_connections);
+  GNUNET_assert (plugin->cur_connections <= plugin->max_connections);
   sa = GNUNET_CONNECTION_create_from_sockaddr (af, sb, sbs);
   if (sa == NULL)
   {
-#if DEBUG_TCP
-    GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
-                     "Failed to create connection to `%4s' at `%s'\n",
-                     GNUNET_i2s (&session->target), GNUNET_a2s (sb, sbs));
-#endif
+    LOG (GNUNET_ERROR_TYPE_DEBUG,
+        "Failed to create connection to `%4s' at `%s'\n",
+        GNUNET_i2s (&address->peer), GNUNET_a2s (sb, sbs));
     return NULL;
   }
-  plugin->max_connections--;
+  plugin->cur_connections++;
+  if (plugin->cur_connections == plugin->max_connections)
+       GNUNET_SERVER_suspend (plugin->server); /* Maximum number of connections rechead */
 
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
-                   "Asked to transmit to `%4s', creating fresh session using address `%s'.\n",
-                   GNUNET_i2s (&address->peer), GNUNET_a2s (sb, sbs));
+  LOG (GNUNET_ERROR_TYPE_DEBUG,
+       "Asked to transmit to `%4s', creating fresh session using address `%s'.\n",
+       GNUNET_i2s (&address->peer), GNUNET_a2s (sb, sbs));
 
   session = create_session (plugin,
                             &address->peer,
@@ -1284,14 +1506,15 @@ tcp_plugin_get_session (void *cls,
   session->addrlen = addrlen;
   session->ats_address_network_type = ats.value;
 
-  GNUNET_CONTAINER_multihashmap_put(plugin->sessionmap, &address->peer.hashPubKey, session, GNUNET_CONTAINER_MULTIHASHMAPOPTION_MULTIPLE);
-
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
-                   "Creating new session for `%s' address `%s' session %p\n",
-                   GNUNET_i2s (&address->peer),
-                   tcp_address_to_string(NULL, address->address, address->address_length),
-                   session);
-
+  GNUNET_CONTAINER_multipeermap_put (plugin->sessionmap,
+                                    &session->target,
+                                    session, GNUNET_CONTAINER_MULTIHASHMAPOPTION_MULTIPLE);
+  inc_sessions (plugin, session, __LINE__);
+  LOG (GNUNET_ERROR_TYPE_DEBUG,
+       "Creating new session for `%s' address `%s' session %p\n",
+       GNUNET_i2s (&address->peer),
+       tcp_address_to_string(NULL, address->address, address->address_length),
+       session);
   /* Send TCP Welcome */
   process_pending_messages (session);
 
@@ -1299,9 +1522,10 @@ tcp_plugin_get_session (void *cls,
 }
 
 
-int session_disconnect_it (void *cls,
-               const GNUNET_HashCode * key,
-               void *value)
+static int
+session_disconnect_it (void *cls,
+                      const struct GNUNET_PeerIdentity *key,
+                      void *value)
 {
   struct Session *session = value;
 
@@ -1313,6 +1537,7 @@ int session_disconnect_it (void *cls,
   return GNUNET_YES;
 }
 
+
 /**
  * Function that can be called to force a disconnect from the
  * specified neighbour.  This should also cancel all previously
@@ -1333,28 +1558,51 @@ static void
 tcp_plugin_disconnect (void *cls, const struct GNUNET_PeerIdentity *target)
 {
   struct Plugin *plugin = cls;
-  struct Session *nat_session = NULL;
 
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
-                   "Disconnecting peer `%4s'\n", GNUNET_i2s (target));
+  LOG (GNUNET_ERROR_TYPE_DEBUG,
+       "Disconnecting peer `%4s'\n", GNUNET_i2s (target));
+  GNUNET_CONTAINER_multipeermap_get_multiple (plugin->sessionmap, target,
+                                             &session_disconnect_it, plugin);
+  GNUNET_CONTAINER_multipeermap_get_multiple (plugin->nat_wait_conns, target,
+                                             &session_disconnect_it, plugin);
+}
 
-  GNUNET_CONTAINER_multihashmap_get_multiple (plugin->sessionmap, &target->hashPubKey, session_disconnect_it, plugin);
 
-  nat_session = GNUNET_CONTAINER_multihashmap_get(plugin->nat_wait_conns, &target->hashPubKey);
-  if (nat_session != NULL)
-  {
-    GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
-                     "Cleaning up pending NAT session for peer `%4s'\n", GNUNET_i2s (target));
-    disconnect_session (nat_session);
-  }
-}
+/**
+ * Running pretty printers: head
+ */
+static struct PrettyPrinterContext *ppc_dll_head;
 
+/**
+ * Running pretty printers: tail
+ */
+static struct PrettyPrinterContext *ppc_dll_tail;
 
 /**
  * Context for address to string conversion.
  */
 struct PrettyPrinterContext
 {
+       /**
+        * DLL
+        */
+       struct PrettyPrinterContext *next;
+
+       /**
+        * DLL
+        */
+       struct PrettyPrinterContext *prev;
+
+       /**
+        * Timeout task
+        */
+       GNUNET_SCHEDULER_TaskIdentifier timeout_task;
+
+       /**
+        * Resolver handle
+        */
+       struct GNUNET_RESOLVER_RequestHandle *resolver_handle;
+
   /**
    * Function to call with the result.
    */
@@ -1369,9 +1617,45 @@ struct PrettyPrinterContext
    * Port to add after the IP address.
    */
   uint16_t port;
+
+  /**
+   * IPv6 address
+   */
+  int ipv6;
+
+  /**
+   * Options
+   */
+  uint32_t options;
 };
 
 
+
+void
+ppc_cancel_task (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
+{
+       int count = 0;
+  struct PrettyPrinterContext *ppc = cls;
+  struct PrettyPrinterContext *cur;
+       for (cur = ppc_dll_head; (NULL != cur); cur = cur->next)
+       {
+               if (cur != ppc)
+                       count++;
+       }
+
+       // GNUNET_log (GNUNET_ERROR_TYPE_ERROR, "Cancel request %p, %u pending\n", ppc, count);
+       ppc->timeout_task = GNUNET_SCHEDULER_NO_TASK;
+       if (NULL != ppc->resolver_handle)
+       {
+               GNUNET_RESOLVER_request_cancel (ppc->resolver_handle);
+               ppc->resolver_handle = NULL;
+       }
+
+       GNUNET_CONTAINER_DLL_remove (ppc_dll_head, ppc_dll_tail, ppc);
+       GNUNET_free (ppc);
+}
+
+
 /**
  * Append our port and forward the result.
  *
@@ -1382,15 +1666,42 @@ static void
 append_port (void *cls, const char *hostname)
 {
   struct PrettyPrinterContext *ppc = cls;
+  struct PrettyPrinterContext *cur;
   char *ret;
-
+  int count = 0;
+
+       for (cur = ppc_dll_head; (NULL != cur); cur = cur->next)
+       {
+               if (cur != ppc)
+                       count++;
+       }
+       //GNUNET_log (GNUNET_ERROR_TYPE_ERROR, "Callback request %p == %s, %u pending\n", ppc, hostname, count);
   if (hostname == NULL)
   {
     ppc->asc (ppc->asc_cls, NULL);
+    GNUNET_CONTAINER_DLL_remove (ppc_dll_head, ppc_dll_tail, ppc);
+    GNUNET_SCHEDULER_cancel (ppc->timeout_task);
+    ppc->timeout_task = GNUNET_SCHEDULER_NO_TASK;
+    ppc->resolver_handle = NULL;
+    //GNUNET_log (GNUNET_ERROR_TYPE_ERROR, "Done request %p, %u pending\n", ppc, count);
     GNUNET_free (ppc);
     return;
   }
-  GNUNET_asprintf (&ret, "%s:%d", hostname, ppc->port);
+  for (cur = ppc_dll_head; (NULL != cur); cur = cur->next)
+  {
+       if (cur == ppc)
+               break;
+  }
+  if (NULL == cur)
+  {
+       GNUNET_log (GNUNET_ERROR_TYPE_ERROR, "Invalid callback for PPC %p \n", ppc);
+       return;
+  }
+
+  if (GNUNET_YES == ppc->ipv6)
+    GNUNET_asprintf (&ret, "%s.%u.[%s]:%d", PLUGIN_NAME, ppc->options, hostname, ppc->port);
+  else
+    GNUNET_asprintf (&ret, "%s.%u.%s:%d", PLUGIN_NAME, ppc->options, hostname, ppc->port);
   ppc->asc (ppc->asc_cls, ret);
   GNUNET_free (ret);
 }
@@ -1426,6 +1737,7 @@ tcp_plugin_address_pretty_printer (void *cls, const char *type,
   const struct IPv4TcpAddress *t4;
   const struct IPv6TcpAddress *t6;
   uint16_t port;
+  uint32_t options;
 
   if (addrlen == sizeof (struct IPv6TcpAddress))
   {
@@ -1435,6 +1747,7 @@ tcp_plugin_address_pretty_printer (void *cls, const char *type,
     a6.sin6_port = t6->t6_port;
     memcpy (&a6.sin6_addr, &t6->ipv6_addr, sizeof (struct in6_addr));
     port = ntohs (t6->t6_port);
+    options = ntohl (t6->options);
     sb = &a6;
     sbs = sizeof (a6);
   }
@@ -1446,9 +1759,16 @@ tcp_plugin_address_pretty_printer (void *cls, const char *type,
     a4.sin_port = t4->t4_port;
     a4.sin_addr.s_addr = t4->ipv4_addr;
     port = ntohs (t4->t4_port);
+    options = ntohl (t4->options);
     sb = &a4;
     sbs = sizeof (a4);
   }
+  else if (0 == addrlen)
+  {
+    asc (asc_cls, TRANSPORT_SESSION_INBOUND_STRING);
+    asc (asc_cls, NULL);
+    return;
+  }
   else
   {
     /* invalid address */
@@ -1457,10 +1777,28 @@ tcp_plugin_address_pretty_printer (void *cls, const char *type,
     return;
   }
   ppc = GNUNET_malloc (sizeof (struct PrettyPrinterContext));
+  if (addrlen == sizeof (struct IPv6TcpAddress))
+    ppc->ipv6 = GNUNET_YES;
+  else
+    ppc->ipv6 = GNUNET_NO;
   ppc->asc = asc;
   ppc->asc_cls = asc_cls;
   ppc->port = port;
-  GNUNET_RESOLVER_hostname_get (sb, sbs, !numeric, timeout, &append_port, ppc);
+  ppc->options = options;
+  ppc->timeout_task = GNUNET_SCHEDULER_add_delayed (GNUNET_TIME_relative_multiply(timeout, 2),
+               &ppc_cancel_task, ppc);
+       ppc->resolver_handle =  GNUNET_RESOLVER_hostname_get (sb, sbs, !numeric,
+                       timeout, &append_port, ppc);
+       if (NULL != ppc->resolver_handle)
+       {
+               //GNUNET_log (GNUNET_ERROR_TYPE_ERROR, "Adding request %p\n", ppc);
+               GNUNET_CONTAINER_DLL_insert (ppc_dll_head, ppc_dll_tail, ppc);
+       }
+       else
+       {
+               GNUNET_break (0);
+               GNUNET_free (ppc);
+       }
 }
 
 
@@ -1508,12 +1846,19 @@ tcp_plugin_check_address (void *cls, const void *addr, size_t addrlen)
   if ((addrlen != sizeof (struct IPv4TcpAddress)) &&
       (addrlen != sizeof (struct IPv6TcpAddress)))
   {
-    GNUNET_break_op (0);
-    return GNUNET_SYSERR;
+
+
+       return GNUNET_SYSERR;
   }
+
   if (addrlen == sizeof (struct IPv4TcpAddress))
   {
     v4 = (struct IPv4TcpAddress *) addr;
+    if (0 != memcmp (&v4->options, &myoptions, sizeof (myoptions)))
+    {
+       GNUNET_break (0);
+       return GNUNET_SYSERR;
+    }
     if (GNUNET_OK != check_port (plugin, ntohs (v4->t4_port)))
       return GNUNET_SYSERR;
     if (GNUNET_OK !=
@@ -1529,6 +1874,11 @@ tcp_plugin_check_address (void *cls, const void *addr, size_t addrlen)
       GNUNET_break_op (0);
       return GNUNET_SYSERR;
     }
+    if (0 != memcmp (&v6->options, &myoptions, sizeof (myoptions)))
+    {
+       GNUNET_break (0);
+       return GNUNET_SYSERR;
+    }
     if (GNUNET_OK != check_port (plugin, ntohs (v6->t6_port)))
       return GNUNET_SYSERR;
     if (GNUNET_OK !=
@@ -1563,7 +1913,7 @@ handle_tcp_nat_probe (void *cls, struct GNUNET_SERVER_Client *client,
   const struct sockaddr_in *s4;
   const struct sockaddr_in6 *s6;
 
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp", "received NAT probe\n");
+  LOG (GNUNET_ERROR_TYPE_DEBUG, "Received NAT probe\n");
 
   /* We have received a TCP NAT probe, meaning we (hopefully) initiated
    * a connection to this peer by running gnunet-nat-client.  This peer
@@ -1589,18 +1939,18 @@ handle_tcp_nat_probe (void *cls, struct GNUNET_SERVER_Client *client,
   }
 
   session =
-      GNUNET_CONTAINER_multihashmap_get (plugin->nat_wait_conns,
+      GNUNET_CONTAINER_multipeermap_get (plugin->nat_wait_conns,
                                          &tcp_nat_probe->
-                                         clientIdentity.hashPubKey);
+                                         clientIdentity);
   if (session == NULL)
   {
-    GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
-                     "Did NOT find session for NAT probe!\n");
+    LOG (GNUNET_ERROR_TYPE_DEBUG,
+        "Did NOT find session for NAT probe!\n");
     GNUNET_SERVER_receive_done (client, GNUNET_OK);
     return;
   }
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
-                   "Found session for NAT probe!\n");
+  LOG (GNUNET_ERROR_TYPE_DEBUG,
+       "Found session for NAT probe!\n");
 
   if (session->nat_connection_timeout != GNUNET_SCHEDULER_NO_TASK)
   {
@@ -1608,33 +1958,31 @@ handle_tcp_nat_probe (void *cls, struct GNUNET_SERVER_Client *client,
     session->nat_connection_timeout = GNUNET_SCHEDULER_NO_TASK;
   }
 
-  GNUNET_assert (GNUNET_CONTAINER_multihashmap_remove
-                 (plugin->nat_wait_conns,
-                  &tcp_nat_probe->clientIdentity.hashPubKey,
-                  session) == GNUNET_YES);
   if (GNUNET_OK != GNUNET_SERVER_client_get_address (client, &vaddr, &alen))
   {
     GNUNET_break (0);
-    GNUNET_free (session);
-    GNUNET_SERVER_receive_done (client, GNUNET_OK);
+    GNUNET_SERVER_receive_done (client, GNUNET_SYSERR);
+    disconnect_session (session);
     return;
   }
-
-  GNUNET_SERVER_client_keep (client);
-  session->client = client;
+  GNUNET_assert (GNUNET_CONTAINER_multipeermap_remove
+                 (plugin->nat_wait_conns,
+                  &tcp_nat_probe->clientIdentity,
+                  session) == GNUNET_YES);
+  GNUNET_CONTAINER_multipeermap_put (plugin->sessionmap,
+                                    &session->target, session,
+                                    GNUNET_CONTAINER_MULTIHASHMAPOPTION_MULTIPLE);
   session->last_activity = GNUNET_TIME_absolute_get ();
   session->inbound = GNUNET_NO;
-
-#if DEBUG_TCP_NAT
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
-                   "Found address `%s' for incoming connection\n",
-                   GNUNET_a2s (vaddr, alen));
-#endif
+  LOG (GNUNET_ERROR_TYPE_DEBUG,
+       "Found address `%s' for incoming connection\n",
+       GNUNET_a2s (vaddr, alen));
   switch (((const struct sockaddr *) vaddr)->sa_family)
   {
   case AF_INET:
     s4 = vaddr;
     t4 = GNUNET_malloc (sizeof (struct IPv4TcpAddress));
+    t4->options = 0;
     t4->t4_port = s4->sin_port;
     t4->ipv4_addr = s4->sin_addr.s_addr;
     session->addr = t4;
@@ -1643,6 +1991,7 @@ handle_tcp_nat_probe (void *cls, struct GNUNET_SERVER_Client *client,
   case AF_INET6:
     s6 = vaddr;
     t6 = GNUNET_malloc (sizeof (struct IPv6TcpAddress));
+    t6->options = 0;
     t6->t6_port = s6->sin6_port;
     memcpy (&t6->ipv6_addr, &s6->sin6_addr, sizeof (struct in6_addr));
     session->addr = t6;
@@ -1650,20 +1999,18 @@ handle_tcp_nat_probe (void *cls, struct GNUNET_SERVER_Client *client,
     break;
   default:
     GNUNET_break_op (0);
-
-    GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
-                     "Bad address for incoming connection!\n");
+    LOG (GNUNET_ERROR_TYPE_DEBUG,
+        "Bad address for incoming connection!\n");
     GNUNET_free (vaddr);
-
-    GNUNET_SERVER_client_drop (client);
-    GNUNET_free (session);
     GNUNET_SERVER_receive_done (client, GNUNET_SYSERR);
+    disconnect_session (session);
     return;
   }
   GNUNET_free (vaddr);
-
-  GNUNET_CONTAINER_multihashmap_put(plugin->sessionmap, &session->target.hashPubKey, session, GNUNET_CONTAINER_MULTIHASHMAPOPTION_MULTIPLE);
-
+  GNUNET_break (NULL == session->client);
+  GNUNET_SERVER_client_keep (client);
+  session->client = client;
+  inc_sessions (plugin, session, __LINE__);
   GNUNET_STATISTICS_update (plugin->env->stats,
                             gettext_noop ("# TCP sessions active"), 1,
                             GNUNET_NO);
@@ -1693,6 +2040,7 @@ handle_tcp_welcome (void *cls, struct GNUNET_SERVER_Client *client,
   struct IPv6TcpAddress *t6;
   const struct sockaddr_in *s4;
   const struct sockaddr_in6 *s6;
+  struct GNUNET_ATS_Information ats;
 
   if (0 ==
       memcmp (&wm->clientIdentity, plugin->env->my_identity,
@@ -1700,40 +2048,51 @@ handle_tcp_welcome (void *cls, struct GNUNET_SERVER_Client *client,
   {
     /* refuse connections from ourselves */
     GNUNET_SERVER_receive_done (client, GNUNET_SYSERR);
+    if (GNUNET_OK == GNUNET_SERVER_client_get_address (client, &vaddr, &alen))
+    {
+       LOG (GNUNET_ERROR_TYPE_WARNING,
+         "Received %s message from my own identity `%4s' on address `%s'\n",
+         "WELCOME", GNUNET_i2s (&wm->clientIdentity), GNUNET_a2s (vaddr, alen));
+       GNUNET_free (vaddr);
+    }
+    GNUNET_break_op (0);
     return;
   }
-
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
-                   "Received %s message from `%4s'\n", "WELCOME",
-                   GNUNET_i2s (&wm->clientIdentity));
+  LOG (GNUNET_ERROR_TYPE_DEBUG,
+       "Received %s message from `%4s' %p\n", "WELCOME",
+       GNUNET_i2s (&wm->clientIdentity), client);
   GNUNET_STATISTICS_update (plugin->env->stats,
                             gettext_noop ("# TCP WELCOME messages received"), 1,
                             GNUNET_NO);
-
   session = lookup_session_by_client (plugin, client);
   if (session != NULL)
   {
     if (GNUNET_OK == GNUNET_SERVER_client_get_address (client, &vaddr, &alen))
     {
-      GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
-                       "Found existing session %p for peer `%s'\n",
-                       session,
-                       GNUNET_a2s (vaddr, alen));
+      LOG (GNUNET_ERROR_TYPE_DEBUG,
+          "Found existing session %p for peer `%s'\n",
+          session,
+          GNUNET_a2s (vaddr, alen));
       GNUNET_free (vaddr);
     }
   }
   else
   {
     GNUNET_SERVER_client_keep (client);
+    if (plugin->service != NULL) /* Otherwise value is incremented in tcp_access_check */
+       plugin->cur_connections++;
+    if (plugin->cur_connections == plugin->max_connections)
+       GNUNET_SERVER_suspend (plugin->server); /* Maximum number of connections rechead */
+
     session = create_session (plugin, &wm->clientIdentity, client, GNUNET_NO);
     session->inbound = GNUNET_YES;
-
     if (GNUNET_OK == GNUNET_SERVER_client_get_address (client, &vaddr, &alen))
     {
       if (alen == sizeof (struct sockaddr_in))
       {
         s4 = vaddr;
         t4 = GNUNET_malloc (sizeof (struct IPv4TcpAddress));
+        t4->options = htonl (0);
         t4->t4_port = s4->sin_port;
         t4->ipv4_addr = s4->sin_addr.s_addr;
         session->addr = t4;
@@ -1743,37 +2102,52 @@ handle_tcp_welcome (void *cls, struct GNUNET_SERVER_Client *client,
       {
         s6 = vaddr;
         t6 = GNUNET_malloc (sizeof (struct IPv6TcpAddress));
+        t6->options = htonl (0);
         t6->t6_port = s6->sin6_port;
         memcpy (&t6->ipv6_addr, &s6->sin6_addr, sizeof (struct in6_addr));
         session->addr = t6;
         session->addrlen = sizeof (struct IPv6TcpAddress);
       }
 
-      struct GNUNET_ATS_Information ats;
       ats = plugin->env->get_address_type (plugin->env->cls, vaddr ,alen);
       session->ats_address_network_type = ats.value;
-
+      LOG (GNUNET_ERROR_TYPE_DEBUG,
+     "Creating new session %p for peer `%s'\n",
+     session,
+     GNUNET_a2s (vaddr, alen));
       GNUNET_free (vaddr);
+      GNUNET_CONTAINER_multipeermap_put (plugin->sessionmap,
+                                      &session->target,
+                                      session,
+                                      GNUNET_CONTAINER_MULTIHASHMAPOPTION_MULTIPLE);
+      inc_sessions (plugin, session, __LINE__);
     }
     else
     {
-#if DEBUG_TCP
-      GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
-                       "Did not obtain TCP socket address for incoming connection\n");
-#endif
+      LOG (GNUNET_ERROR_TYPE_DEBUG,
+          "Did not obtain TCP socket address for incoming connection\n");
+      GNUNET_break (0);
     }
-    GNUNET_CONTAINER_multihashmap_put(plugin->sessionmap, &wm->clientIdentity.hashPubKey, session, GNUNET_CONTAINER_MULTIHASHMAPOPTION_MULTIPLE);
   }
 
   if (session->expecting_welcome != GNUNET_YES)
   {
     GNUNET_break_op (0);
     GNUNET_SERVER_receive_done (client, GNUNET_SYSERR);
+    GNUNET_break (0);
     return;
   }
   session->last_activity = GNUNET_TIME_absolute_get ();
   session->expecting_welcome = GNUNET_NO;
 
+  /* Notify transport and ATS about new session */
+  if (GNUNET_YES == session->inbound)
+  {
+       plugin->env->session_start (NULL, &wm->clientIdentity, PLUGIN_NAME,
+               (GNUNET_YES == session->inbound) ? NULL : session->addr,
+                 (GNUNET_YES == session->inbound) ? 0 : session->addrlen,
+                 session, &ats, 1);
+  }
 
   process_pending_messages (session);
 
@@ -1794,19 +2168,11 @@ static void
 delayed_done (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
 {
   struct Session *session = cls;
-  struct GNUNET_TIME_Relative delay;
-  struct GNUNET_ATS_Information ats;
 
   session->receive_delay_task = GNUNET_SCHEDULER_NO_TASK;
-  delay =
-      session->plugin->env->receive (session->plugin->env->cls,
-                                     &session->target, NULL, &ats, 0, session,
-                                     NULL, 0);
-  if (delay.rel_value == 0)
-    GNUNET_SERVER_receive_done (session->client, GNUNET_OK);
-  else
-    session->receive_delay_task =
-        GNUNET_SCHEDULER_add_delayed (delay, &delayed_done, session);
+  reschedule_session_timeout (session);
+
+  GNUNET_SERVER_receive_done (session->client, GNUNET_OK);
 }
 
 
@@ -1839,8 +2205,18 @@ handle_tcp_data (void *cls, struct GNUNET_SERVER_Client *client,
   if (NULL == session)
   {
     /* No inbound session found */
+    void *vaddr;
+    size_t alen;
+
+    GNUNET_SERVER_client_get_address (client, &vaddr, &alen);
+    LOG (GNUNET_ERROR_TYPE_ERROR,
+        "Received unexpected %u bytes of type %u from `%s'\n",
+        (unsigned int) ntohs (message->size),
+        (unsigned int) ntohs (message->type),
+        GNUNET_a2s(vaddr, alen));
     GNUNET_break_op (0);
     GNUNET_SERVER_receive_done (client, GNUNET_SYSERR);
+    GNUNET_free_non_null(vaddr);
     return;
   }
   else if (GNUNET_YES == session->expecting_welcome)
@@ -1848,20 +2224,21 @@ handle_tcp_data (void *cls, struct GNUNET_SERVER_Client *client,
     /* Session is expecting WELCOME message */
     void *vaddr;
     size_t alen;
+
     GNUNET_SERVER_client_get_address (client, &vaddr, &alen);
-    GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR, "tcp",
-                     "Received unexpected %u bytes of type %u from `%s'\n",
-                     (unsigned int) ntohs (message->size),
-                     (unsigned int) ntohs (message->type),
-                     GNUNET_a2s(vaddr, alen));
+    LOG (GNUNET_ERROR_TYPE_ERROR,
+        "Received unexpected %u bytes of type %u from `%s'\n",
+        (unsigned int) ntohs (message->size),
+        (unsigned int) ntohs (message->type),
+        GNUNET_a2s(vaddr, alen));
     GNUNET_break_op (0);
     GNUNET_SERVER_receive_done (client, GNUNET_SYSERR);
+    GNUNET_free_non_null(vaddr);
     return;
   }
 
   session->last_activity = GNUNET_TIME_absolute_get ();
-
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
+  LOG (GNUNET_ERROR_TYPE_DEBUG,
                    "Passing %u bytes of type %u from `%4s' to transport service.\n",
                    (unsigned int) ntohs (message->size),
                    (unsigned int) ntohs (message->type),
@@ -1870,33 +2247,40 @@ handle_tcp_data (void *cls, struct GNUNET_SERVER_Client *client,
   GNUNET_STATISTICS_update (plugin->env->stats,
                             gettext_noop ("# bytes received via TCP"),
                             ntohs (message->size), GNUNET_NO);
-  struct GNUNET_ATS_Information distance[2];
+  struct GNUNET_ATS_Information distance;
 
-  distance[0].type = htonl (GNUNET_ATS_QUALITY_NET_DISTANCE);
-  distance[0].value = htonl (1);
-  distance[1].type = htonl (GNUNET_ATS_NETWORK_TYPE);
-  distance[1].value = session->ats_address_network_type;
+  distance.type = htonl (GNUNET_ATS_NETWORK_TYPE);
+  distance.value = session->ats_address_network_type;
   GNUNET_break (ntohl(session->ats_address_network_type) != GNUNET_ATS_NET_UNSPECIFIED);
 
+  GNUNET_assert (GNUNET_CONTAINER_multipeermap_contains_value (plugin->sessionmap,
+                                                              &session->target,
+                                                              session));
+
   delay = plugin->env->receive (plugin->env->cls,
                                 &session->target,
                                 message,
-                                (const struct GNUNET_ATS_Information *) &distance,
-                                1, session,
+                                session,
                                 (GNUNET_YES == session->inbound) ? NULL : session->addr,
                                 (GNUNET_YES == session->inbound) ? 0 : session->addrlen);
-  if (delay.rel_value == 0)
+  plugin->env->update_address_metrics (plugin->env->cls,
+               &session->target,
+               (GNUNET_YES == session->inbound) ? NULL : session->addr,
+                 (GNUNET_YES == session->inbound) ? 0 : session->addrlen,
+                 session, &distance, 1);
+
+  reschedule_session_timeout (session);
+
+  if (0 == delay.rel_value_us)
   {
     GNUNET_SERVER_receive_done (client, GNUNET_OK);
   }
   else
   {
-#if DEBUG_TCP
-    GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
-                     "Throttling receiving from `%s' for %llu ms\n",
-                     GNUNET_i2s (&session->target),
-                     (unsigned long long) delay.rel_value);
-#endif
+    LOG (GNUNET_ERROR_TYPE_DEBUG,
+        "Throttling receiving from `%s' for %s\n",
+        GNUNET_i2s (&session->target),
+        GNUNET_STRINGS_relative_time_to_string (delay, GNUNET_YES));
     GNUNET_SERVER_disable_receive_done_warning (client);
     session->receive_delay_task =
         GNUNET_SCHEDULER_add_delayed (delay, &delayed_done, session);
@@ -1919,20 +2303,26 @@ disconnect_notify (void *cls, struct GNUNET_SERVER_Client *client)
 
   if (client == NULL)
     return;
-  plugin->max_connections++;
   session = lookup_session_by_client (plugin, client);
   if (session == NULL)
     return;                     /* unknown, nothing to do */
-#if DEBUG_TCP
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
-                   "Destroying session of `%4s' with %s due to network-level disconnect.\n",
-                   GNUNET_i2s (&session->target),
-                   (session->addr !=
-                    NULL) ? tcp_address_to_string (session->plugin,
-                                                   session->addr,
-                                                   session->addrlen) :
-                   "*");
-#endif
+  LOG (GNUNET_ERROR_TYPE_DEBUG,
+       "Destroying session of `%4s' with %s due to network-level disconnect.\n",
+       GNUNET_i2s (&session->target),
+       (session->addr !=
+       NULL) ? tcp_address_to_string (session->plugin,
+                                      session->addr,
+                                      session->addrlen) :
+       "*");
+
+  if (plugin->cur_connections == plugin->max_connections)
+       GNUNET_SERVER_resume (plugin->server); /* Resume server  */
+
+  if (plugin->cur_connections < 1)
+       GNUNET_break (0);
+  else
+       plugin->cur_connections--;
+
   GNUNET_STATISTICS_update (session->plugin->env->stats,
                             gettext_noop
                             ("# network-level TCP disconnect events"), 1,
@@ -1961,7 +2351,7 @@ notify_send_probe (void *cls, size_t size, void *buf)
                                tcp_probe_ctx);
   if (buf == NULL)
   {
-    GNUNET_CONNECTION_destroy (tcp_probe_ctx->sock, GNUNET_NO);
+    GNUNET_CONNECTION_destroy (tcp_probe_ctx->sock);
     GNUNET_free (tcp_probe_ctx);
     return 0;
   }
@@ -2027,6 +2417,100 @@ try_connection_reversal (void *cls, const struct sockaddr *addr,
 }
 
 
+/**
+ * Session was idle, so disconnect it
+ */
+static void
+session_timeout (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
+{
+  GNUNET_assert (NULL != cls);
+  struct Session *s = cls;
+
+  s->timeout_task = GNUNET_SCHEDULER_NO_TASK;
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+             "Session %p was idle for %s, disconnecting\n",
+             s,
+             GNUNET_STRINGS_relative_time_to_string (GNUNET_CONSTANTS_IDLE_CONNECTION_TIMEOUT,
+                                                     GNUNET_YES));
+  /* call session destroy function */
+  disconnect_session(s);
+}
+
+
+/**
+ * Start session timeout
+ */
+static void
+start_session_timeout (struct Session *s)
+{
+  GNUNET_assert (NULL != s);
+  GNUNET_assert (GNUNET_SCHEDULER_NO_TASK == s->timeout_task);
+  s->timeout_task =  GNUNET_SCHEDULER_add_delayed (GNUNET_CONSTANTS_IDLE_CONNECTION_TIMEOUT,
+                                                   &session_timeout,
+                                                   s);
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+             "Timeout for session %p set to %s\n",
+             s,
+             GNUNET_STRINGS_relative_time_to_string (GNUNET_CONSTANTS_IDLE_CONNECTION_TIMEOUT,
+                                                     GNUNET_YES));
+}
+
+
+/**
+ * Increment session timeout due to activity
+ */
+static void
+reschedule_session_timeout (struct Session *s)
+{
+  GNUNET_assert (NULL != s);
+  GNUNET_assert (GNUNET_SCHEDULER_NO_TASK != s->timeout_task);
+
+  GNUNET_SCHEDULER_cancel (s->timeout_task);
+  s->timeout_task =  GNUNET_SCHEDULER_add_delayed (GNUNET_CONSTANTS_IDLE_CONNECTION_TIMEOUT,
+                                                   &session_timeout,
+                                                   s);
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+              "Timeout rescheduled for session %p set to %s\n",
+             s,
+             GNUNET_STRINGS_relative_time_to_string (GNUNET_CONSTANTS_IDLE_CONNECTION_TIMEOUT,
+                                                     GNUNET_YES));
+}
+
+
+/**
+ * Cancel timeout
+ */
+static void
+stop_session_timeout (struct Session *s)
+{
+  GNUNET_assert (NULL != s);
+
+  if (GNUNET_SCHEDULER_NO_TASK != s->timeout_task)
+  {
+    GNUNET_SCHEDULER_cancel (s->timeout_task);
+    s->timeout_task = GNUNET_SCHEDULER_NO_TASK;
+    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                "Timeout stopped for session %p canceled\n",
+                s);
+  }
+}
+
+/**
+ * Function obtain the network type for a session
+ *
+ * @param cls closure ('struct Plugin*')
+ * @param session the session
+ * @return the network type in HBO or GNUNET_SYSERR
+ */
+static enum GNUNET_ATS_Network_Type
+tcp_get_network (void *cls,
+                struct Session *session)
+{
+  GNUNET_assert (NULL != session);
+  return ntohl (session->ats_address_network_type);
+}
+
+
 /**
  * Entry point for the plugin.
  *
@@ -2054,9 +2538,11 @@ libgnunet_plugin_transport_tcp_init (void *cls)
   unsigned int i;
   struct GNUNET_TIME_Relative idle_timeout;
   int ret;
+  int ret_s;
   struct sockaddr **addrs;
   socklen_t *addrlens;
 
+
   if (NULL == env->receive)
   {
     /* run in 'stub' mode (i.e. as part of gnunet-peerinfo), don't fully
@@ -2069,6 +2555,7 @@ libgnunet_plugin_transport_tcp_init (void *cls)
     return api;
   }
 
+  GNUNET_assert (NULL != env->cfg);
   if (GNUNET_OK !=
       GNUNET_CONFIGURATION_get_value_number (env->cfg, "transport-tcp",
                                              "MAX_CONNECTIONS",
@@ -2084,10 +2571,10 @@ libgnunet_plugin_transport_tcp_init (void *cls)
                                                "ADVERTISED-PORT", &aport)) &&
        (aport > 65535)))
   {
-    GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR, "tcp",
-                     _
-                     ("Require valid port number for service `%s' in configuration!\n"),
-                     "transport-tcp");
+    LOG (GNUNET_ERROR_TYPE_ERROR,
+        _
+        ("Require valid port number for service `%s' in configuration!\n"),
+        "transport-tcp");
     return NULL;
   }
   if (aport == 0)
@@ -2096,38 +2583,45 @@ libgnunet_plugin_transport_tcp_init (void *cls)
     aport = 0;
   if (bport != 0)
   {
-    service = GNUNET_SERVICE_start ("transport-tcp", env->cfg);
+    service = GNUNET_SERVICE_start ("transport-tcp", env->cfg, GNUNET_SERVICE_OPTION_NONE);
     if (service == NULL)
     {
-      GNUNET_log_from (GNUNET_ERROR_TYPE_WARNING, "tcp",
-                       _("Failed to start service.\n"));
+      LOG (GNUNET_ERROR_TYPE_WARNING,
+          _("Failed to start service.\n"));
       return NULL;
     }
   }
   else
     service = NULL;
 
+  /* Initialize my flags */
+  myoptions = 0;
+
   plugin = GNUNET_malloc (sizeof (struct Plugin));
-  plugin->sessionmap = GNUNET_CONTAINER_multihashmap_create(max_connections);
+  plugin->sessionmap = GNUNET_CONTAINER_multipeermap_create (max_connections, GNUNET_YES);
   plugin->max_connections = max_connections;
+  plugin->cur_connections = 0;
   plugin->open_port = bport;
   plugin->adv_port = aport;
   plugin->env = env;
   plugin->lsock = NULL;
   if ((service != NULL) &&
       (GNUNET_SYSERR !=
-       (ret =
+       (ret_s =
         GNUNET_SERVICE_get_server_addresses ("transport-tcp", env->cfg, &addrs,
                                              &addrlens))))
   {
+    for (ret = ret_s-1; ret >= 0; ret--)
+      LOG (GNUNET_ERROR_TYPE_INFO,
+          "Binding to address `%s'\n",
+          GNUNET_a2s (addrs[ret], addrlens[ret]));
     plugin->nat =
-        GNUNET_NAT_register (env->cfg, GNUNET_YES, aport, (unsigned int) ret,
+        GNUNET_NAT_register (env->cfg, GNUNET_YES, aport, (unsigned int) ret_s,
                              (const struct sockaddr **) addrs, addrlens,
                              &tcp_nat_port_map_callback,
                              &try_connection_reversal, plugin);
-    while (ret > 0)
+    for (ret = ret_s -1; ret >= 0; ret--)
     {
-      ret--;
       GNUNET_assert (addrs[ret] != NULL);
       GNUNET_free (addrs[ret]);
     }
@@ -2136,9 +2630,9 @@ libgnunet_plugin_transport_tcp_init (void *cls)
   }
   else
   {
-    plugin->nat =
-        GNUNET_NAT_register (env->cfg, GNUNET_YES, 0, 0, NULL, NULL, NULL,
-                             &try_connection_reversal, plugin);
+    plugin->nat = GNUNET_NAT_register (plugin->env->cfg,
+                                      GNUNET_YES, 0, 0, NULL, NULL, NULL,
+                                      &try_connection_reversal, plugin);
   }
   api = GNUNET_malloc (sizeof (struct GNUNET_TRANSPORT_PluginFunctions));
   api->cls = plugin;
@@ -2150,6 +2644,7 @@ libgnunet_plugin_transport_tcp_init (void *cls)
   api->check_address = &tcp_plugin_check_address;
   api->address_to_string = &tcp_address_to_string;
   api->string_to_address = &tcp_string_to_address;
+  api->get_network = &tcp_get_network;
   plugin->service = service;
   if (service != NULL)
   {
@@ -2161,9 +2656,8 @@ libgnunet_plugin_transport_tcp_init (void *cls)
         GNUNET_CONFIGURATION_get_value_time (env->cfg, "transport-tcp",
                                              "TIMEOUT", &idle_timeout))
     {
-      GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR, "tcp",
-                       _("Failed to find option %s in section %s!\n"),
-                       "TIMEOUT", "transport-tcp");
+      GNUNET_log_config_missing (GNUNET_ERROR_TYPE_ERROR,
+                                "transport-tcp", "TIMEOUT");
       if (plugin->nat != NULL)
         GNUNET_NAT_unregister (plugin->nat);
       GNUNET_free (plugin);
@@ -2180,21 +2674,27 @@ libgnunet_plugin_transport_tcp_init (void *cls)
        i < sizeof (my_handlers) / sizeof (struct GNUNET_SERVER_MessageHandler);
        i++)
     plugin->handlers[i].callback_cls = plugin;
+
   GNUNET_SERVER_add_handlers (plugin->server, plugin->handlers);
   GNUNET_SERVER_disconnect_notify (plugin->server, &disconnect_notify, plugin);
-  plugin->nat_wait_conns = GNUNET_CONTAINER_multihashmap_create (16);
+  plugin->nat_wait_conns = GNUNET_CONTAINER_multipeermap_create (16, GNUNET_YES);
   if (bport != 0)
-    GNUNET_log_from (GNUNET_ERROR_TYPE_INFO, "tcp",
-                     _("TCP transport listening on port %llu\n"), bport);
+    LOG (GNUNET_ERROR_TYPE_INFO,
+        _("TCP transport listening on port %llu\n"), bport);
   else
-    GNUNET_log_from (GNUNET_ERROR_TYPE_INFO, "tcp",
-                     _
-                     ("TCP transport not listening on any port (client only)\n"));
+    LOG (GNUNET_ERROR_TYPE_INFO,
+        _
+        ("TCP transport not listening on any port (client only)\n"));
   if (aport != bport)
-    GNUNET_log_from (GNUNET_ERROR_TYPE_INFO, "tcp",
+    LOG (GNUNET_ERROR_TYPE_INFO,
                      _
                      ("TCP transport advertises itself as being on port %llu\n"),
                      aport);
+  /* Initially set connections to 0 */
+  GNUNET_assert (NULL != plugin->env->stats);
+  GNUNET_STATISTICS_set (plugin->env->stats,
+                        gettext_noop ("# TCP sessions active"), 0,
+                        GNUNET_NO);
   return api;
 }
 
@@ -2208,18 +2708,32 @@ libgnunet_plugin_transport_tcp_done (void *cls)
   struct GNUNET_TRANSPORT_PluginFunctions *api = cls;
   struct Plugin *plugin = api->cls;
   struct TCPProbeContext *tcp_probe;
+  struct PrettyPrinterContext *cur;
+  struct PrettyPrinterContext *next;
 
   if (NULL == plugin)
   {
     GNUNET_free (api);
     return NULL;
   }
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp", "Shutting down TCP plugin\n");
+  LOG (GNUNET_ERROR_TYPE_DEBUG, "Shutting down TCP plugin\n");
 
   /* Removing leftover sessions */
-  GNUNET_CONTAINER_multihashmap_iterate(plugin->sessionmap, &session_disconnect_it, NULL);
+  GNUNET_CONTAINER_multipeermap_iterate(plugin->sessionmap, &session_disconnect_it, NULL);
   /* Removing leftover NAT sessions */
-  GNUNET_CONTAINER_multihashmap_iterate(plugin->nat_wait_conns, &session_disconnect_it, NULL);
+  GNUNET_CONTAINER_multipeermap_iterate(plugin->nat_wait_conns, &session_disconnect_it, NULL);
+
+  next = ppc_dll_head;
+  for (cur = next; NULL != cur; cur = next)
+  {
+       next = cur->next;
+       GNUNET_CONTAINER_DLL_remove (ppc_dll_head, ppc_dll_tail, cur);
+       if (NULL != cur->resolver_handle)
+               GNUNET_RESOLVER_request_cancel (cur->resolver_handle);
+       GNUNET_SCHEDULER_cancel (cur->timeout_task);
+       GNUNET_free (cur);
+       GNUNET_break (0);
+  }
 
   if (plugin->service != NULL)
     GNUNET_SERVICE_stop (plugin->service);
@@ -2232,11 +2746,11 @@ libgnunet_plugin_transport_tcp_done (void *cls)
   {
     GNUNET_CONTAINER_DLL_remove (plugin->probe_head, plugin->probe_tail,
                                  tcp_probe);
-    GNUNET_CONNECTION_destroy (tcp_probe->sock, GNUNET_NO);
+    GNUNET_CONNECTION_destroy (tcp_probe->sock);
     GNUNET_free (tcp_probe);
   }
-  GNUNET_CONTAINER_multihashmap_destroy (plugin->nat_wait_conns);
-  GNUNET_CONTAINER_multihashmap_destroy (plugin->sessionmap);
+  GNUNET_CONTAINER_multipeermap_destroy (plugin->nat_wait_conns);
+  GNUNET_CONTAINER_multipeermap_destroy (plugin->sessionmap);
   GNUNET_free (plugin);
   GNUNET_free (api);
   return NULL;