/*
This file is part of GNUnet
- (C) 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Christian Grothoff (and other contributing authors)
+ (C) 2002--2012 Christian Grothoff (and other contributing authors)
GNUnet is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published
#include "gnunet_transport_plugin.h"
#include "transport.h"
-#define DEBUG_TCP GNUNET_EXTRA_LOGGING
-
-#define DEBUG_TCP_NAT GNUNET_EXTRA_LOGGING
-
+#define LOG(kind,...) GNUNET_log_from (kind, "transport-tcp",__VA_ARGS__)
/**
* How long until we give up on establishing an NAT connection?
*/
struct Session
{
-
/**
- * API requirement.
+ * To whom are we talking to (set to our identity
+ * if we are still waiting for the welcome message)
*/
- struct SessionHeader header;
+ struct GNUNET_PeerIdentity target;
/**
- * Stored in a linked list.
+ * API requirement.
*/
- struct Session *next;
+ struct SessionHeader header;
/**
* Pointer to the global plugin struct.
/**
* Handle for pending transmission request.
*/
- struct GNUNET_CONNECTION_TransmitHandle *transmit_handle;
+ struct GNUNET_SERVER_TransmitHandle *transmit_handle;
/**
- * To whom are we talking to (set to our identity
- * if we are still waiting for the welcome message)
+ * ID of task used to delay receiving more to throttle sender.
*/
- struct GNUNET_PeerIdentity target;
+ GNUNET_SCHEDULER_TaskIdentifier receive_delay_task;
/**
- * ID of task used to delay receiving more to throttle sender.
+ * Session timeout task
*/
- GNUNET_SCHEDULER_TaskIdentifier receive_delay_task;
+ GNUNET_SCHEDULER_TaskIdentifier timeout_task;
/**
* Address of the other peer (either based on our 'connect'
*/
struct GNUNET_NAT_Handle *nat;
- struct GNUNET_CONTAINER_MultiHashMap * sessionmap;
+ /**
+ * Map from peer identities to sessions for the given peer.
+ */
+ struct GNUNET_CONTAINER_MultiHashMap *sessionmap;
/**
* Handle to the network service.
};
+/**
+ * Start session timeout
+ */
+static void
+start_session_timeout (struct Session *s);
+
+
+/**
+ * Increment session timeout due to activity
+ */
+static void
+reschedule_session_timeout (struct Session *s);
+
+
+/**
+ * Cancel timeout
+ */
+static void
+stop_session_timeout (struct Session *s);
+
+
+/* DEBUG CODE */
+static const char *
+tcp_address_to_string (void *cls, const void *addr, size_t addrlen);
+
+
+static unsigned int sessions;
+
+
+static void
+inc_sessions (struct Plugin *plugin, struct Session *session, int line)
+{
+ sessions++;
+ unsigned int size = GNUNET_CONTAINER_multihashmap_size(plugin->sessionmap);
+ if (sessions != size)
+ LOG (GNUNET_ERROR_TYPE_DEBUG, "Inconsistent sessions %u <-> session map size: %u\n",
+ sessions, size);
+ LOG (GNUNET_ERROR_TYPE_DEBUG, "%4i Session increased to %u (session map size: %u): `%s' `%s'\n",
+ line,
+ sessions,
+ size,
+ GNUNET_i2s (&session->target),
+ tcp_address_to_string (NULL, session->addr, session->addrlen));
+}
+
+
+static void
+dec_sessions (struct Plugin *plugin, struct Session *session, int line)
+{
+ GNUNET_assert (sessions > 0);
+ unsigned int size = GNUNET_CONTAINER_multihashmap_size(plugin->sessionmap);
+ sessions--;
+ if (sessions != size)
+ LOG (GNUNET_ERROR_TYPE_DEBUG, "Inconsistent sessions %u <-> session map size: %u\n",
+ sessions, size);
+ LOG (GNUNET_ERROR_TYPE_DEBUG, "%4i Session decreased to %u (session map size: %u): `%s' `%s'\n",
+ line,
+ sessions,
+ size,
+ GNUNET_i2s (&session->target),
+ tcp_address_to_string (NULL, session->addr, session->addrlen));
+}
+/* DEBUG CODE */
+
+
/**
* Function to check if an inbound connection is acceptable.
* Mostly used to limit the total number of open connections
{
struct Plugin *plugin = cls;
+ LOG (GNUNET_ERROR_TYPE_ERROR,
+ "Accepting new incoming TCP connection from `%s'\n",
+ GNUNET_a2s (addr, addrlen));
if (0 == plugin->max_connections)
return GNUNET_NO;
plugin->max_connections--;
void *arg;
size_t args;
- GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
- "NPMC called with %d for address `%s'\n", add_remove,
- GNUNET_a2s (addr, addrlen));
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "NPMC called with %d for address `%s'\n", add_remove,
+ GNUNET_a2s (addr, addrlen));
/* convert 'addr' to our internal format */
switch (addr->sa_family)
{
return;
}
/* modify our published address list */
- plugin->env->notify_address (plugin->env->cls, add_remove, arg, args);
+ plugin->env->notify_address (plugin->env->cls, add_remove, arg, args, "tcp");
}
int af;
uint16_t port;
- if (addrlen == sizeof (struct IPv6TcpAddress))
+ switch (addrlen)
{
+ case sizeof (struct IPv6TcpAddress):
t6 = addr;
af = AF_INET6;
port = ntohs (t6->t6_port);
memcpy (&a6, &t6->ipv6_addr, sizeof (a6));
sb = &a6;
- }
- else if (addrlen == sizeof (struct IPv4TcpAddress))
- {
+ break;
+ case sizeof (struct IPv4TcpAddress):
t4 = addr;
af = AF_INET;
port = ntohs (t4->t4_port);
memcpy (&a4, &t4->ipv4_addr, sizeof (a4));
sb = &a4;
- }
- else
- {
- GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR, "tcp",
- _("Unexpected address length: %u bytes\n"),
- (unsigned int) addrlen);
+ break;
+ default:
+ LOG (GNUNET_ERROR_TYPE_ERROR,
+ _("Unexpected address length: %u bytes\n"),
+ (unsigned int) addrlen);
GNUNET_break (0);
return NULL;
}
* If the function returns GNUNET_SYSERR, its contents are undefined.
* @return GNUNET_OK on success, GNUNET_SYSERR on failure
*/
-int
+static int
tcp_string_to_address (void *cls, const char *addr, uint16_t addrlen,
void **buf, size_t *added)
{
struct sockaddr_storage socket_address;
- int ret = GNUNET_STRINGS_to_address_ip (addr, addrlen,
- &socket_address);
- if (ret != GNUNET_OK)
+ if ((NULL == addr) || (addrlen == 0))
+ {
+ GNUNET_break (0);
return GNUNET_SYSERR;
-
- if (socket_address.ss_family == AF_INET)
+ }
+ if ('\0' != addr[addrlen - 1])
{
- struct IPv4TcpAddress *t4;
- struct sockaddr_in *in4 = (struct sockaddr_in *) &socket_address;
- t4 = GNUNET_malloc (sizeof (struct IPv4TcpAddress));
- t4->ipv4_addr = in4->sin_addr.s_addr;
- t4->t4_port = in4->sin_port;
- *buf = t4;
- *added = sizeof (struct IPv4TcpAddress);
+ GNUNET_break (0);
+ return GNUNET_SYSERR;
}
- else if (socket_address.ss_family == AF_INET6)
+ if (strlen (addr) != addrlen - 1)
{
- struct IPv6TcpAddress *t6;
- struct sockaddr_in6 *in6 = (struct sockaddr_in6 *) &socket_address;
- t6 = GNUNET_malloc (sizeof (struct IPv6TcpAddress));
- t6->ipv6_addr = in6->sin6_addr;
- t6->t6_port = in6->sin6_port;
- *buf = t6;
- *added = sizeof (struct IPv6TcpAddress);
+ GNUNET_break (0);
+ return GNUNET_SYSERR;
+ }
+ if (GNUNET_OK !=
+ GNUNET_STRINGS_to_address_ip (addr, strlen (addr),
+ &socket_address))
+ {
+ GNUNET_break (0);
+ return GNUNET_SYSERR;
+ }
+ switch (socket_address.ss_family)
+ {
+ case AF_INET:
+ {
+ struct IPv4TcpAddress *t4;
+ struct sockaddr_in *in4 = (struct sockaddr_in *) &socket_address;
+
+ t4 = GNUNET_malloc (sizeof (struct IPv4TcpAddress));
+ t4->ipv4_addr = in4->sin_addr.s_addr;
+ t4->t4_port = in4->sin_port;
+ *buf = t4;
+ *added = sizeof (struct IPv4TcpAddress);
+ return GNUNET_OK;
+ }
+ case AF_INET6:
+ {
+ struct IPv6TcpAddress *t6;
+ struct sockaddr_in6 *in6 = (struct sockaddr_in6 *) &socket_address;
+ t6 = GNUNET_malloc (sizeof (struct IPv6TcpAddress));
+ t6->ipv6_addr = in6->sin6_addr;
+ t6->t6_port = in6->sin6_port;
+ *buf = t6;
+ *added = sizeof (struct IPv6TcpAddress);
+ return GNUNET_OK;
+ }
+ default:
+ return GNUNET_SYSERR;
}
- return GNUNET_SYSERR;
}
struct Session *ret;
};
-int session_lookup_by_client_it (void *cls,
- const GNUNET_HashCode * key,
- void *value)
+
+static int
+session_lookup_by_client_it (void *cls,
+ const struct GNUNET_HashCode * key,
+ void *value)
{
struct SessionClientCtx *sc_ctx = cls;
struct Session *s = value;
return GNUNET_YES;
}
+
/**
* Find the session handle for the given client.
*
*/
static struct Session *
lookup_session_by_client (struct Plugin *plugin,
- const struct GNUNET_SERVER_Client *client)
+ const struct GNUNET_SERVER_Client *client)
{
struct SessionClientCtx sc_ctx;
+
sc_ctx.client = client;
sc_ctx.ret = NULL;
-
GNUNET_CONTAINER_multihashmap_iterate (plugin->sessionmap, &session_lookup_by_client_it, &sc_ctx);
-
return sc_ctx.ret;
}
*
* @param plugin the plugin
* @param target peer to connect to
- * @param client client to use
+ * @param client client to use, reference counter must have already been increased
* @param is_nat this a NAT session, we should wait for a client to
* connect to us from an address, then assign that to
* the session
struct PendingMessage *pm;
struct WelcomeMessage welcome;
- if (is_nat != GNUNET_YES)
- GNUNET_assert (client != NULL);
+ if (GNUNET_YES != is_nat)
+ GNUNET_assert (NULL != client);
else
- GNUNET_assert (client == NULL);
-
- GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
- "Creating new session for peer `%4s'\n",
- GNUNET_i2s (target));
+ GNUNET_assert (NULL == client);
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Creating new session for peer `%4s'\n",
+ GNUNET_i2s (target));
ret = GNUNET_malloc (sizeof (struct Session));
ret->last_activity = GNUNET_TIME_absolute_get ();
ret->plugin = plugin;
pm->message_size, GNUNET_NO);
GNUNET_CONTAINER_DLL_insert (ret->pending_messages_head,
ret->pending_messages_tail, pm);
- if (is_nat != GNUNET_YES)
+ if (GNUNET_YES != is_nat)
+ {
GNUNET_STATISTICS_update (plugin->env->stats,
gettext_noop ("# TCP sessions active"), 1,
GNUNET_NO);
+ }
+ start_session_timeout (ret);
+
return ret;
}
char *cbuf;
size_t ret;
- GNUNET_assert (session != NULL);
+ GNUNET_assert (NULL != session);
session->transmit_handle = NULL;
plugin = session->plugin;
- if (buf == NULL)
+ if (NULL == buf)
{
-#if DEBUG_TCP
- GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
- "Timeout trying to transmit to peer `%4s', discarding message queue.\n",
- GNUNET_i2s (&session->target));
-#endif
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Timeout trying to transmit to peer `%4s', discarding message queue.\n",
+ GNUNET_i2s (&session->target));
/* timeout; cancel all messages that have already expired */
hd = NULL;
tl = NULL;
{
GNUNET_CONTAINER_DLL_remove (session->pending_messages_head,
session->pending_messages_tail, pos);
-#if DEBUG_TCP
- GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
- "Failed to transmit %u byte message to `%4s'.\n",
- pos->message_size, GNUNET_i2s (&session->target));
-#endif
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Failed to transmit %u byte message to `%4s'.\n",
+ pos->message_size, GNUNET_i2s (&session->target));
ret += pos->message_size;
GNUNET_CONTAINER_DLL_insert_after (hd, tl, tl, pos);
}
GNUNET_CONTAINER_DLL_remove (session->pending_messages_head,
session->pending_messages_tail, pos);
GNUNET_assert (size >= pos->message_size);
- GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
- "Transmitting message of type %u\n",
- ntohs (((struct GNUNET_MessageHeader *) pos->msg)->type));
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Transmitting message of type %u\n",
+ ntohs (((struct GNUNET_MessageHeader *) pos->msg)->type));
/* FIXME: this memcpy can be up to 7% of our total runtime */
memcpy (cbuf, pos->msg, pos->message_size);
cbuf += pos->message_size;
}
GNUNET_assert (hd == NULL);
GNUNET_assert (tl == NULL);
-#if DEBUG_TCP > 1
- GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp", "Transmitting %u bytes\n",
+ LOG (GNUNET_ERROR_TYPE_DEBUG, "Transmitting %u bytes\n",
ret);
-#endif
GNUNET_STATISTICS_update (plugin->env->stats,
gettext_noop ("# bytes currently in TCP buffers"),
-(int64_t) ret, GNUNET_NO);
struct PendingMessage *pm;
struct Plugin * plugin = session->plugin;
- GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
- "Disconnecting session %p for peer `%s' address `%s'\n",
- session,
- GNUNET_i2s (&session->target),
- tcp_address_to_string(NULL, session->addr, session->addrlen));
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Disconnecting session of peer `%s' address `%s'\n",
+ GNUNET_i2s (&session->target),
+ tcp_address_to_string (NULL, session->addr, session->addrlen));
- GNUNET_assert (GNUNET_YES == GNUNET_CONTAINER_multihashmap_remove(plugin->sessionmap, &session->target.hashPubKey, session) ||
- GNUNET_YES == GNUNET_CONTAINER_multihashmap_remove(plugin->nat_wait_conns, &session->target.hashPubKey, session));
+ stop_session_timeout (session);
+
+ if (GNUNET_YES == GNUNET_CONTAINER_multihashmap_remove (plugin->sessionmap, &session->target.hashPubKey, session))
+ {
+ GNUNET_STATISTICS_update (session->plugin->env->stats,
+ gettext_noop ("# TCP sessions active"), -1,
+ GNUNET_NO);
+ dec_sessions (plugin, session, __LINE__);
+ }
+ else GNUNET_assert (GNUNET_YES == GNUNET_CONTAINER_multihashmap_remove (plugin->nat_wait_conns, &session->target.hashPubKey, session));
/* clean up state */
if (session->transmit_handle != NULL)
{
- GNUNET_CONNECTION_notify_transmit_ready_cancel (session->transmit_handle);
+ GNUNET_SERVER_notify_transmit_ready_cancel (session->transmit_handle);
session->transmit_handle = NULL;
}
session->plugin->env->session_end (session->plugin->env->cls,
&session->target, session);
- if (session->nat_connection_timeout != GNUNET_SCHEDULER_NO_TASK)
+ if (GNUNET_SCHEDULER_NO_TASK != session->nat_connection_timeout)
{
GNUNET_SCHEDULER_cancel (session->nat_connection_timeout);
session->nat_connection_timeout = GNUNET_SCHEDULER_NO_TASK;
while (NULL != (pm = session->pending_messages_head))
{
-#if DEBUG_TCP
- GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
- pm->transmit_cont !=
- NULL ? "Could not deliver message to `%4s'.\n" :
- "Could not deliver message to `%4s', notifying.\n",
- GNUNET_i2s (&session->target));
-#endif
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ pm->transmit_cont !=
+ NULL ? "Could not deliver message to `%4s'.\n" :
+ "Could not deliver message to `%4s', notifying.\n",
+ GNUNET_i2s (&session->target));
GNUNET_STATISTICS_update (session->plugin->env->stats,
gettext_noop ("# bytes currently in TCP buffers"),
-(int64_t) pm->message_size, GNUNET_NO);
if (session->receive_delay_task != GNUNET_SCHEDULER_NO_TASK)
{
GNUNET_SCHEDULER_cancel (session->receive_delay_task);
- if (session->client != NULL)
+ if (NULL != session->client)
GNUNET_SERVER_receive_done (session->client, GNUNET_SYSERR);
}
- if (session->client != NULL)
+ if (NULL != session->client)
{
+ GNUNET_SERVER_client_disconnect (session->client);
GNUNET_SERVER_client_drop (session->client);
session->client = NULL;
}
- GNUNET_STATISTICS_update (session->plugin->env->stats,
- gettext_noop ("# TCP sessions active"), -1,
- GNUNET_NO);
GNUNET_free_non_null (session->addr);
GNUNET_assert (NULL == session->transmit_handle);
GNUNET_free (session);
}
+/* FIXME WORKAROUND FOR MANTIS 0002445 */
+struct result
+{
+ struct Session *s;
+ int res;
+};
+
+int session_it (void *cls,
+ const struct GNUNET_HashCode * key,
+ void *value)
+{
+ struct result *res = cls;
+
+ if (res->s == value)
+ {
+ res->res = GNUNET_OK;
+ return GNUNET_NO;
+ }
+ else
+ {
+ return GNUNET_YES;
+ }
+}
+
+/* FIXME END WORKAROUND FOR MANTIS 0002445 */
/**
* Function that can be used by the transport service to transmit
struct Plugin * plugin = cls;
struct PendingMessage *pm;
- GNUNET_assert (plugin != NULL);
- GNUNET_assert (session != NULL);
+ GNUNET_assert (NULL != plugin);
+ GNUNET_assert (NULL != session);
+
+ /* FIXME WORKAROUND FOR MANTIS 0002445 */
+ struct result res1;
+ struct result res2;
+
+ res1.s = session;
+ res1.res = GNUNET_SYSERR;
+ GNUNET_CONTAINER_multihashmap_iterate (plugin->sessionmap, &session_it, &res1);
+
+ res2.s = session;
+ res2.res = GNUNET_SYSERR;
+ GNUNET_CONTAINER_multihashmap_iterate (plugin->sessionmap, &session_it, &res2);
+
+ if ((res1.res == GNUNET_SYSERR) && (res2.res == GNUNET_SYSERR))
+ {
+ LOG (GNUNET_ERROR_TYPE_ERROR,
+ "WORKAROUND MANTIS BUG 2445: This Trying to send to invalid session %p\n", session);
+ GNUNET_break (0);
+ return GNUNET_SYSERR;
+ }
+ /* FIXME END WORKAROUND FOR MANTIS 0002445 */
/* create new message entry */
pm = GNUNET_malloc (sizeof (struct PendingMessage) + msgbuf_size);
pm->transmit_cont = cont;
pm->transmit_cont_cls = cont_cls;
-
- GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
- "Asked to transmit %u bytes to `%s', added message to list.\n",
- msgbuf_size, GNUNET_i2s (&session->target));
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Asked to transmit %u bytes to `%s', added message to list.\n",
+ msgbuf_size, GNUNET_i2s (&session->target));
if (GNUNET_YES == GNUNET_CONTAINER_multihashmap_contains_value(plugin->sessionmap, &session->target.hashPubKey, session))
{
GNUNET_assert (session->client != NULL);
-
+ reschedule_session_timeout (session);
GNUNET_SERVER_client_set_timeout (session->client,
GNUNET_CONSTANTS_IDLE_CONNECTION_TIMEOUT);
GNUNET_STATISTICS_update (plugin->env->stats,
}
else if (GNUNET_YES == GNUNET_CONTAINER_multihashmap_contains_value(plugin->nat_wait_conns, &session->target.hashPubKey, session))
{
- GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
- "This NAT WAIT session for peer `%s' is not yet ready!\n",
- GNUNET_i2s (&session->target));
-
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "This NAT WAIT session for peer `%s' is not yet ready!\n",
+ GNUNET_i2s (&session->target));
+ reschedule_session_timeout (session);
GNUNET_STATISTICS_update (plugin->env->stats,
gettext_noop ("# bytes currently in TCP buffers"),
msgbuf_size, GNUNET_NO);
}
else
{
- if (cont != NULL)
+ LOG (GNUNET_ERROR_TYPE_ERROR,
+ "Invalid session %p\n", session);
+ if (NULL != cont)
cont (cont_cls, &session->target, GNUNET_SYSERR);
GNUNET_break (0);
GNUNET_free (pm);
}
}
+
struct SessionItCtx
{
- void * addr;
+ void *addr;
size_t addrlen;
- struct Session * result;
+ struct Session *result;
};
-int session_lookup_it (void *cls,
- const GNUNET_HashCode * key,
- void *value)
+
+static int
+session_lookup_it (void *cls,
+ const struct GNUNET_HashCode *key,
+ void *value)
{
struct SessionItCtx * si_ctx = cls;
struct Session * session = value;
#if 0
char * a1 = strdup (tcp_address_to_string(NULL, session->addr, session->addrlen));
char * a2 = strdup (tcp_address_to_string(NULL, si_ctx->addr, si_ctx->addrlen));
- GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR, "tcp",
- "Comparing: %s %u <-> %s %u\n",
- a1,
- session->addrlen,
- a2,
- si_ctx->addrlen);
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Comparing: %s %u <-> %s %u\n",
+ a1,
+ session->addrlen,
+ a2,
+ si_ctx->addrlen);
GNUNET_free (a1);
GNUNET_free (a2);
#endif
#if 0
a1 = strdup (tcp_address_to_string(NULL, session->addr, session->addrlen));
a2 = strdup (tcp_address_to_string(NULL, si_ctx->addr, si_ctx->addrlen));
- GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR, "tcp",
- "Comparing: %s %u <-> %s %u , OK!\n",
- a1,
- session->addrlen,
- a2,
- si_ctx->addrlen);
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Comparing: %s %u <-> %s %u , OK!\n",
+ a1,
+ session->addrlen,
+ a2,
+ si_ctx->addrlen);
GNUNET_free (a1);
GNUNET_free (a2);
#endif
return GNUNET_NO;
}
+
/**
* Task cleaning up a NAT connection attempt after timeout
*/
-
static void
nat_connect_timeout (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
{
struct Session *session = cls;
- GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
- "NAT WAIT connection to `%4s' at `%s' could not be established, removing session\n",
- GNUNET_i2s (&session->target), tcp_address_to_string(NULL, session->addr, session->addrlen));
-
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "NAT WAIT connection to `%4s' at `%s' could not be established, removing session\n",
+ GNUNET_i2s (&session->target), tcp_address_to_string(NULL, session->addr, session->addrlen));
disconnect_session (session);
-
}
+
/**
* Create a new session to transmit data to the target
* This session will used to send data to this peer and the plugin will
*/
static struct Session *
tcp_plugin_get_session (void *cls,
- const struct GNUNET_HELLO_Address *address)
+ const struct GNUNET_HELLO_Address *address)
{
struct Plugin * plugin = cls;
struct Session * session = NULL;
-
int af;
const void *sb;
size_t sbs;
const struct IPv6TcpAddress *t6;
struct GNUNET_ATS_Information ats;
unsigned int is_natd = GNUNET_NO;
- size_t addrlen = 0;
+ size_t addrlen;
GNUNET_assert (plugin != NULL);
GNUNET_assert (address != NULL);
-
addrlen = address->address_length;
-
- GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
- "Trying to get session for `%s' address length %i\n",
- tcp_address_to_string(NULL, address->address, address->address_length),
- addrlen);
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Trying to get session for `%s' address of peer `%s'\n",
+ tcp_address_to_string(NULL, address->address, address->address_length),
+ GNUNET_i2s (&address->peer));
/* look for existing session */
- if (GNUNET_CONTAINER_multihashmap_contains(plugin->sessionmap, &address->peer.hashPubKey))
+ if (GNUNET_YES ==
+ GNUNET_CONTAINER_multihashmap_contains(plugin->sessionmap, &address->peer.hashPubKey))
{
struct SessionItCtx si_ctx;
if (si_ctx.result != NULL)
{
session = si_ctx.result;
- GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
- "Found exisiting session for `%s' address `%s' session %p\n",
- GNUNET_i2s (&address->peer),
- tcp_address_to_string(NULL, address->address, address->address_length),
- session);
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Found exisiting session for `%s' address `%s' session %p\n",
+ GNUNET_i2s (&address->peer),
+ tcp_address_to_string(NULL, address->address, address->address_length),
+ session);
return session;
}
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Existing sessions did not match address `%s' or peer `%s'\n",
+ tcp_address_to_string(NULL, address->address, address->address_length),
+ GNUNET_i2s (&address->peer));
}
if (addrlen == sizeof (struct IPv6TcpAddress))
}
else
{
- GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR, "tcp",
- _("Address of unexpected length: %u\n"), addrlen);
+ LOG (GNUNET_ERROR_TYPE_ERROR,
+ _("Address of unexpected length: %u\n"), addrlen);
GNUNET_break (0);
return NULL;
}
GNUNET_CONTAINER_multihashmap_contains (plugin->nat_wait_conns,
&address->peer.hashPubKey)))
{
-#if DEBUG_TCP_NAT
- GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
- _("Found valid IPv4 NAT address (creating session)!\n"));
-#endif
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Found valid IPv4 NAT address (creating session)!\n") ;
session = create_session (plugin, &address->peer, NULL, GNUNET_YES);
session->addrlen = 0;
session->addr = NULL;
&nat_connect_timeout,
session);
GNUNET_assert (session != NULL);
-
GNUNET_assert (GNUNET_CONTAINER_multihashmap_put
(plugin->nat_wait_conns, &address->peer.hashPubKey, session,
GNUNET_CONTAINER_MULTIHASHMAPOPTION_UNIQUE_ONLY) == GNUNET_OK);
- GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
- "Created NAT WAIT connection to `%4s' at `%s'\n",
- GNUNET_i2s (&session->target), GNUNET_a2s (sb, sbs));
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Created NAT WAIT connection to `%4s' at `%s'\n",
+ GNUNET_i2s (&session->target), GNUNET_a2s (sb, sbs));
if (GNUNET_OK == GNUNET_NAT_run_client (plugin->nat, &a4))
return session;
else
{
- GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
- "Running NAT client for `%4s' at `%s' failed\n",
- GNUNET_i2s (&session->target), GNUNET_a2s (sb, sbs));
-
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Running NAT client for `%4s' at `%s' failed\n",
+ GNUNET_i2s (&session->target), GNUNET_a2s (sb, sbs));
disconnect_session (session);
return NULL;
}
sa = GNUNET_CONNECTION_create_from_sockaddr (af, sb, sbs);
if (sa == NULL)
{
-#if DEBUG_TCP
- GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
- "Failed to create connection to `%4s' at `%s'\n",
- GNUNET_i2s (&session->target), GNUNET_a2s (sb, sbs));
-#endif
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Failed to create connection to `%4s' at `%s'\n",
+ GNUNET_i2s (&session->target), GNUNET_a2s (sb, sbs));
return NULL;
}
plugin->max_connections--;
- GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
- "Asked to transmit to `%4s', creating fresh session using address `%s'.\n",
- GNUNET_i2s (&address->peer), GNUNET_a2s (sb, sbs));
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Asked to transmit to `%4s', creating fresh session using address `%s'.\n",
+ GNUNET_i2s (&address->peer), GNUNET_a2s (sb, sbs));
session = create_session (plugin,
&address->peer,
session->ats_address_network_type = ats.value;
GNUNET_CONTAINER_multihashmap_put(plugin->sessionmap, &address->peer.hashPubKey, session, GNUNET_CONTAINER_MULTIHASHMAPOPTION_MULTIPLE);
-
- GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
- "Creating new session for `%s' address `%s' session %p\n",
- GNUNET_i2s (&address->peer),
- tcp_address_to_string(NULL, address->address, address->address_length),
- session);
-
+ inc_sessions (plugin, session, __LINE__);
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Creating new session for `%s' address `%s' session %p\n",
+ GNUNET_i2s (&address->peer),
+ tcp_address_to_string(NULL, address->address, address->address_length),
+ session);
/* Send TCP Welcome */
process_pending_messages (session);
}
-int session_disconnect_it (void *cls,
- const GNUNET_HashCode * key,
- void *value)
+static int
+session_disconnect_it (void *cls,
+ const struct GNUNET_HashCode * key,
+ void *value)
{
struct Session *session = value;
return GNUNET_YES;
}
+
/**
* Function that can be called to force a disconnect from the
* specified neighbour. This should also cancel all previously
tcp_plugin_disconnect (void *cls, const struct GNUNET_PeerIdentity *target)
{
struct Plugin *plugin = cls;
- struct Session *nat_session = NULL;
-
- GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
- "Disconnecting peer `%4s'\n", GNUNET_i2s (target));
-
- GNUNET_CONTAINER_multihashmap_get_multiple (plugin->sessionmap, &target->hashPubKey, session_disconnect_it, plugin);
- nat_session = GNUNET_CONTAINER_multihashmap_get(plugin->nat_wait_conns, &target->hashPubKey);
- if (nat_session != NULL)
- {
- GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
- "Cleaning up pending NAT session for peer `%4s'\n", GNUNET_i2s (target));
- disconnect_session (nat_session);
- }
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Disconnecting peer `%4s'\n", GNUNET_i2s (target));
+ GNUNET_CONTAINER_multihashmap_get_multiple (plugin->sessionmap, &target->hashPubKey, &session_disconnect_it, plugin);
+ GNUNET_CONTAINER_multihashmap_get_multiple (plugin->nat_wait_conns, &target->hashPubKey, &session_disconnect_it, plugin);
}
* Port to add after the IP address.
*/
uint16_t port;
+
+ int ipv6;
};
GNUNET_free (ppc);
return;
}
- GNUNET_asprintf (&ret, "%s:%d", hostname, ppc->port);
+ if (GNUNET_YES == ppc->ipv6)
+ GNUNET_asprintf (&ret, "[%s]:%d", hostname, ppc->port);
+ else
+ GNUNET_asprintf (&ret, "%s:%d", hostname, ppc->port);
ppc->asc (ppc->asc_cls, ret);
GNUNET_free (ret);
}
sb = &a4;
sbs = sizeof (a4);
}
+ else if (0 == addrlen)
+ {
+ asc (asc_cls, "<inbound connection>");
+ asc (asc_cls, NULL);
+ return;
+ }
else
{
/* invalid address */
return;
}
ppc = GNUNET_malloc (sizeof (struct PrettyPrinterContext));
+ if (addrlen == sizeof (struct IPv6TcpAddress))
+ ppc->ipv6 = GNUNET_YES;
+ else
+ ppc->ipv6 = GNUNET_NO;
ppc->asc = asc;
ppc->asc_cls = asc_cls;
ppc->port = port;
const struct sockaddr_in *s4;
const struct sockaddr_in6 *s6;
- GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp", "received NAT probe\n");
+ LOG (GNUNET_ERROR_TYPE_DEBUG, "Received NAT probe\n");
/* We have received a TCP NAT probe, meaning we (hopefully) initiated
* a connection to this peer by running gnunet-nat-client. This peer
clientIdentity.hashPubKey);
if (session == NULL)
{
- GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
- "Did NOT find session for NAT probe!\n");
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Did NOT find session for NAT probe!\n");
GNUNET_SERVER_receive_done (client, GNUNET_OK);
return;
}
- GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
- "Found session for NAT probe!\n");
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Found session for NAT probe!\n");
if (session->nat_connection_timeout != GNUNET_SCHEDULER_NO_TASK)
{
session->nat_connection_timeout = GNUNET_SCHEDULER_NO_TASK;
}
- GNUNET_assert (GNUNET_CONTAINER_multihashmap_remove
- (plugin->nat_wait_conns,
- &tcp_nat_probe->clientIdentity.hashPubKey,
- session) == GNUNET_YES);
if (GNUNET_OK != GNUNET_SERVER_client_get_address (client, &vaddr, &alen))
{
GNUNET_break (0);
- GNUNET_free (session);
- GNUNET_SERVER_receive_done (client, GNUNET_OK);
+ GNUNET_SERVER_receive_done (client, GNUNET_SYSERR);
+ disconnect_session (session);
return;
}
-
- GNUNET_SERVER_client_keep (client);
- session->client = client;
+ GNUNET_assert (GNUNET_CONTAINER_multihashmap_remove
+ (plugin->nat_wait_conns,
+ &tcp_nat_probe->clientIdentity.hashPubKey,
+ session) == GNUNET_YES);
+ GNUNET_CONTAINER_multihashmap_put(plugin->sessionmap,
+ &session->target.hashPubKey, session,
+ GNUNET_CONTAINER_MULTIHASHMAPOPTION_MULTIPLE);
session->last_activity = GNUNET_TIME_absolute_get ();
session->inbound = GNUNET_NO;
-
-#if DEBUG_TCP_NAT
- GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
- "Found address `%s' for incoming connection\n",
- GNUNET_a2s (vaddr, alen));
-#endif
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Found address `%s' for incoming connection\n",
+ GNUNET_a2s (vaddr, alen));
switch (((const struct sockaddr *) vaddr)->sa_family)
{
case AF_INET:
break;
default:
GNUNET_break_op (0);
-
- GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
- "Bad address for incoming connection!\n");
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Bad address for incoming connection!\n");
GNUNET_free (vaddr);
-
- GNUNET_SERVER_client_drop (client);
- GNUNET_free (session);
GNUNET_SERVER_receive_done (client, GNUNET_SYSERR);
+ disconnect_session (session);
return;
}
GNUNET_free (vaddr);
-
- GNUNET_CONTAINER_multihashmap_put(plugin->sessionmap, &session->target.hashPubKey, session, GNUNET_CONTAINER_MULTIHASHMAPOPTION_MULTIPLE);
-
+ GNUNET_break (NULL == session->client);
+ GNUNET_SERVER_client_keep (client);
+ session->client = client;
+ inc_sessions (plugin, session, __LINE__);
GNUNET_STATISTICS_update (plugin->env->stats,
gettext_noop ("# TCP sessions active"), 1,
GNUNET_NO);
GNUNET_SERVER_receive_done (client, GNUNET_SYSERR);
return;
}
-
- GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
- "Received %s message from `%4s'\n", "WELCOME",
- GNUNET_i2s (&wm->clientIdentity));
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Received %s message from `%4s'\n", "WELCOME",
+ GNUNET_i2s (&wm->clientIdentity));
GNUNET_STATISTICS_update (plugin->env->stats,
gettext_noop ("# TCP WELCOME messages received"), 1,
GNUNET_NO);
-
session = lookup_session_by_client (plugin, client);
if (session != NULL)
{
if (GNUNET_OK == GNUNET_SERVER_client_get_address (client, &vaddr, &alen))
{
- GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
- "Found existing session %p for peer `%s'\n",
- session,
- GNUNET_a2s (vaddr, alen));
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Found existing session %p for peer `%s'\n",
+ session,
+ GNUNET_a2s (vaddr, alen));
GNUNET_free (vaddr);
}
}
GNUNET_SERVER_client_keep (client);
session = create_session (plugin, &wm->clientIdentity, client, GNUNET_NO);
session->inbound = GNUNET_YES;
-
if (GNUNET_OK == GNUNET_SERVER_client_get_address (client, &vaddr, &alen))
{
if (alen == sizeof (struct sockaddr_in))
}
else
{
-#if DEBUG_TCP
- GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
- "Did not obtain TCP socket address for incoming connection\n");
-#endif
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Did not obtain TCP socket address for incoming connection\n");
}
GNUNET_CONTAINER_multihashmap_put(plugin->sessionmap, &wm->clientIdentity.hashPubKey, session, GNUNET_CONTAINER_MULTIHASHMAPOPTION_MULTIPLE);
+ inc_sessions (plugin, session, __LINE__);
}
if (session->expecting_welcome != GNUNET_YES)
session->plugin->env->receive (session->plugin->env->cls,
&session->target, NULL, &ats, 0, session,
NULL, 0);
+ reschedule_session_timeout (session);
+
if (delay.rel_value == 0)
GNUNET_SERVER_receive_done (session->client, GNUNET_OK);
else
if (NULL == session)
{
/* No inbound session found */
+ void *vaddr;
+ size_t alen;
+
+ GNUNET_SERVER_client_get_address (client, &vaddr, &alen);
+ LOG (GNUNET_ERROR_TYPE_ERROR,
+ "Received unexpected %u bytes of type %u from `%s'\n",
+ (unsigned int) ntohs (message->size),
+ (unsigned int) ntohs (message->type),
+ GNUNET_a2s(vaddr, alen));
GNUNET_break_op (0);
GNUNET_SERVER_receive_done (client, GNUNET_SYSERR);
+ GNUNET_free_non_null(vaddr);
return;
}
else if (GNUNET_YES == session->expecting_welcome)
/* Session is expecting WELCOME message */
void *vaddr;
size_t alen;
+
GNUNET_SERVER_client_get_address (client, &vaddr, &alen);
- GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR, "tcp",
- "Received unexpected %u bytes of type %u from `%s'\n",
- (unsigned int) ntohs (message->size),
- (unsigned int) ntohs (message->type),
- GNUNET_a2s(vaddr, alen));
+ LOG (GNUNET_ERROR_TYPE_ERROR,
+ "Received unexpected %u bytes of type %u from `%s'\n",
+ (unsigned int) ntohs (message->size),
+ (unsigned int) ntohs (message->type),
+ GNUNET_a2s(vaddr, alen));
GNUNET_break_op (0);
GNUNET_SERVER_receive_done (client, GNUNET_SYSERR);
+ GNUNET_free_non_null(vaddr);
return;
}
session->last_activity = GNUNET_TIME_absolute_get ();
-
- GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
"Passing %u bytes of type %u from `%4s' to transport service.\n",
(unsigned int) ntohs (message->size),
(unsigned int) ntohs (message->type),
distance[1].value = session->ats_address_network_type;
GNUNET_break (ntohl(session->ats_address_network_type) != GNUNET_ATS_NET_UNSPECIFIED);
+ GNUNET_assert (GNUNET_CONTAINER_multihashmap_contains_value (plugin->sessionmap,
+ &session->target.hashPubKey,
+ session));
+
delay = plugin->env->receive (plugin->env->cls,
&session->target,
message,
1, session,
(GNUNET_YES == session->inbound) ? NULL : session->addr,
(GNUNET_YES == session->inbound) ? 0 : session->addrlen);
+
+ reschedule_session_timeout (session);
+
if (delay.rel_value == 0)
{
GNUNET_SERVER_receive_done (client, GNUNET_OK);
}
else
{
-#if DEBUG_TCP
- GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
- "Throttling receiving from `%s' for %llu ms\n",
- GNUNET_i2s (&session->target),
- (unsigned long long) delay.rel_value);
-#endif
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Throttling receiving from `%s' for %llu ms\n",
+ GNUNET_i2s (&session->target),
+ (unsigned long long) delay.rel_value);
GNUNET_SERVER_disable_receive_done_warning (client);
session->receive_delay_task =
GNUNET_SCHEDULER_add_delayed (delay, &delayed_done, session);
session = lookup_session_by_client (plugin, client);
if (session == NULL)
return; /* unknown, nothing to do */
-#if DEBUG_TCP
- GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp",
- "Destroying session of `%4s' with %s due to network-level disconnect.\n",
- GNUNET_i2s (&session->target),
- (session->addr !=
- NULL) ? tcp_address_to_string (session->plugin,
- session->addr,
- session->addrlen) :
- "*");
-#endif
+ LOG (GNUNET_ERROR_TYPE_DEBUG,
+ "Destroying session of `%4s' with %s due to network-level disconnect.\n",
+ GNUNET_i2s (&session->target),
+ (session->addr !=
+ NULL) ? tcp_address_to_string (session->plugin,
+ session->addr,
+ session->addrlen) :
+ "*");
GNUNET_STATISTICS_update (session->plugin->env->stats,
gettext_noop
("# network-level TCP disconnect events"), 1,
tcp_probe_ctx);
if (buf == NULL)
{
- GNUNET_CONNECTION_destroy (tcp_probe_ctx->sock, GNUNET_NO);
+ GNUNET_CONNECTION_destroy (tcp_probe_ctx->sock);
GNUNET_free (tcp_probe_ctx);
return 0;
}
}
+/**
+ * Session was idle, so disconnect it
+ */
+static void
+session_timeout (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
+{
+ GNUNET_assert (NULL != cls);
+ struct Session *s = cls;
+
+ s->timeout_task = GNUNET_SCHEDULER_NO_TASK;
+ GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+ "Session %p was idle for %llu ms, disconnecting\n",
+ s, (unsigned long long) GNUNET_CONSTANTS_IDLE_CONNECTION_TIMEOUT.rel_value);
+ /* call session destroy function */
+ disconnect_session(s);
+}
+
+
+/**
+ * Start session timeout
+ */
+static void
+start_session_timeout (struct Session *s)
+{
+ GNUNET_assert (NULL != s);
+ GNUNET_assert (GNUNET_SCHEDULER_NO_TASK == s->timeout_task);
+ s->timeout_task = GNUNET_SCHEDULER_add_delayed (GNUNET_CONSTANTS_IDLE_CONNECTION_TIMEOUT,
+ &session_timeout,
+ s);
+ GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+ "Timeout for session %p set to %llu ms\n",
+ s, (unsigned long long) GNUNET_CONSTANTS_IDLE_CONNECTION_TIMEOUT.rel_value);
+}
+
+
+/**
+ * Increment session timeout due to activity
+ */
+static void
+reschedule_session_timeout (struct Session *s)
+{
+ GNUNET_assert (NULL != s);
+ GNUNET_assert (GNUNET_SCHEDULER_NO_TASK != s->timeout_task);
+
+ GNUNET_SCHEDULER_cancel (s->timeout_task);
+ s->timeout_task = GNUNET_SCHEDULER_add_delayed (GNUNET_CONSTANTS_IDLE_CONNECTION_TIMEOUT,
+ &session_timeout,
+ s);
+ GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+ "Timeout rescheduled for session %p set to %llu ms\n",
+ s, (unsigned long long) GNUNET_CONSTANTS_IDLE_CONNECTION_TIMEOUT.rel_value);
+}
+
+
+/**
+ * Cancel timeout
+ */
+static void
+stop_session_timeout (struct Session *s)
+{
+ GNUNET_assert (NULL != s);
+
+ if (GNUNET_SCHEDULER_NO_TASK != s->timeout_task)
+ {
+ GNUNET_SCHEDULER_cancel (s->timeout_task);
+ s->timeout_task = GNUNET_SCHEDULER_NO_TASK;
+ GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+ "Timeout stopped for session %p canceled\n",
+ s, (unsigned long long) GNUNET_CONSTANTS_IDLE_CONNECTION_TIMEOUT.rel_value);
+ }
+}
+
+
/**
* Entry point for the plugin.
*
"ADVERTISED-PORT", &aport)) &&
(aport > 65535)))
{
- GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR, "tcp",
- _
- ("Require valid port number for service `%s' in configuration!\n"),
- "transport-tcp");
+ LOG (GNUNET_ERROR_TYPE_ERROR,
+ _
+ ("Require valid port number for service `%s' in configuration!\n"),
+ "transport-tcp");
return NULL;
}
if (aport == 0)
aport = 0;
if (bport != 0)
{
- service = GNUNET_SERVICE_start ("transport-tcp", env->cfg);
+ service = GNUNET_SERVICE_start ("transport-tcp", env->cfg, GNUNET_SERVICE_OPTION_NONE);
if (service == NULL)
{
- GNUNET_log_from (GNUNET_ERROR_TYPE_WARNING, "tcp",
- _("Failed to start service.\n"));
+ LOG (GNUNET_ERROR_TYPE_WARNING,
+ _("Failed to start service.\n"));
return NULL;
}
}
GNUNET_CONFIGURATION_get_value_time (env->cfg, "transport-tcp",
"TIMEOUT", &idle_timeout))
{
- GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR, "tcp",
- _("Failed to find option %s in section %s!\n"),
- "TIMEOUT", "transport-tcp");
+ LOG (GNUNET_ERROR_TYPE_ERROR,
+ _("Failed to find option %s in section %s!\n"),
+ "TIMEOUT", "transport-tcp");
if (plugin->nat != NULL)
GNUNET_NAT_unregister (plugin->nat);
GNUNET_free (plugin);
GNUNET_SERVER_disconnect_notify (plugin->server, &disconnect_notify, plugin);
plugin->nat_wait_conns = GNUNET_CONTAINER_multihashmap_create (16);
if (bport != 0)
- GNUNET_log_from (GNUNET_ERROR_TYPE_INFO, "tcp",
- _("TCP transport listening on port %llu\n"), bport);
+ LOG (GNUNET_ERROR_TYPE_INFO,
+ _("TCP transport listening on port %llu\n"), bport);
else
- GNUNET_log_from (GNUNET_ERROR_TYPE_INFO, "tcp",
- _
- ("TCP transport not listening on any port (client only)\n"));
+ LOG (GNUNET_ERROR_TYPE_INFO,
+ _
+ ("TCP transport not listening on any port (client only)\n"));
if (aport != bport)
- GNUNET_log_from (GNUNET_ERROR_TYPE_INFO, "tcp",
+ LOG (GNUNET_ERROR_TYPE_INFO,
_
("TCP transport advertises itself as being on port %llu\n"),
aport);
GNUNET_free (api);
return NULL;
}
- GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "tcp", "Shutting down TCP plugin\n");
+ LOG (GNUNET_ERROR_TYPE_DEBUG, "Shutting down TCP plugin\n");
/* Removing leftover sessions */
GNUNET_CONTAINER_multihashmap_iterate(plugin->sessionmap, &session_disconnect_it, NULL);
{
GNUNET_CONTAINER_DLL_remove (plugin->probe_head, plugin->probe_tail,
tcp_probe);
- GNUNET_CONNECTION_destroy (tcp_probe->sock, GNUNET_NO);
+ GNUNET_CONNECTION_destroy (tcp_probe->sock);
GNUNET_free (tcp_probe);
}
GNUNET_CONTAINER_multihashmap_destroy (plugin->nat_wait_conns);
projects / oweals / gnunet.git / blobdiff