error msg
[oweals/gnunet.git] / src / transport / plugin_transport_http_common.c
index e71b16e932c957519c92b3f04eb08d9394775b67..bf983302e2da40bc5d8c15870173a3ab390ea440 100644 (file)
 #include "platform.h"
 #include "gnunet_common.h"
 #include "gnunet_transport_plugin.h"
+#include "plugin_transport_http_common.h"
+
+struct SplittedHTTPAddress
+{
+       char *protocol;
+       char *host;
+       char *path;
+       int port;
+};
+
+static void
+http_clean_splitted (struct SplittedHTTPAddress *spa)
+{
+       if (NULL != spa)
+       {
+                       GNUNET_free_non_null (spa->protocol);
+                       GNUNET_free_non_null (spa->host);
+                       GNUNET_free_non_null (spa->path);
+                       GNUNET_free_non_null (spa);
+       }
+}
+
+struct SplittedHTTPAddress *
+http_split_address (const char * addr)
+{
+       struct SplittedHTTPAddress  *sp;
+       char *src = GNUNET_strdup (addr);
+       char *protocol_start = NULL;
+       char *host_start = NULL;
+       char *v6_end = NULL;
+       char *port_start = NULL;
+       char *path_start = NULL;
+       protocol_start = src;
+       sp = GNUNET_malloc (sizeof (struct SplittedHTTPAddress));
+
+       /* Address string consists of protocol://host[:port]path*/
+
+       host_start = strstr (src, "://");
+       if (NULL == host_start)
+       {
+                       GNUNET_free (src);
+                       GNUNET_free (sp);
+                       return NULL;
+       }
+
+       host_start[0] = '\0';
+       sp->protocol = GNUNET_strdup (protocol_start);
+
+       host_start += strlen ("://");
+       if (strlen (host_start) == 0)
+       {
+                       GNUNET_free (src);
+                       GNUNET_free (sp->protocol);
+                       GNUNET_free (sp);
+                       return NULL;
+       }
+
+       /* Find path start */
+       path_start = strchr (host_start, '/');
+       if (NULL != path_start)
+       {
+                       sp->path = GNUNET_strdup (path_start);
+                       path_start[0] = '\0';
+       }
+       else
+               sp->path = GNUNET_strdup ("");
+
+       if (strlen(host_start) < 1)
+       {
+                       GNUNET_free (src);
+                       GNUNET_free (sp->protocol);
+                       GNUNET_free (sp->path);
+                       GNUNET_free (sp);
+                       return NULL;
+       }
+
+       if (NULL != (port_start = strrchr (host_start, ':')))
+       {
+                       /* *We COULD have a port, but also an IPv6 address! */
+                       if (NULL != (v6_end = strchr(host_start, ']')))
+                       {
+                                       if  (v6_end < port_start)
+                                       {
+                                                       /* IPv6 address + port */
+                                                       port_start[0] = '\0';
+                                                       port_start ++;
+                                                       sp->port = atoi (port_start);
+                                                       if ((0 == sp->port) || (65535 < sp->port))
+                                                       {
+                                                               GNUNET_free (src);
+                                                               GNUNET_free (sp->protocol);
+                                                               GNUNET_free (sp->path);
+                                                               GNUNET_free (sp);
+                                                               return NULL;
+                                                       }
+                                       }
+                                       else
+                                       {
+                                                       /* IPv6 address + no port */
+                                                       if (0 == strcmp(sp->protocol, "https"))
+                                                               sp->port = HTTPS_DEFAULT_PORT;
+                                                       else if (0 == strcmp(sp->protocol, "http"))
+                                                               sp->port = HTTP_DEFAULT_PORT;
+                                       }
+                       }
+                       else
+                       {
+                                       /* No IPv6 address */
+                                       port_start[0] = '\0';
+                                       port_start ++;
+                                       sp->port = atoi (port_start);
+                                       if ((0 == sp->port) || (65535 < sp->port))
+                                       {
+                                               GNUNET_free (src);
+                                               GNUNET_free (sp->protocol);
+                                               GNUNET_free (sp->path);
+                                               GNUNET_free (sp);
+                                               return NULL;
+                                       }
+                       }
+       }
+       else
+       {
+               /* No ':' as port separator, default port for protocol */
+               if (0 == strcmp(sp->protocol, "https"))
+                       sp->port = HTTPS_DEFAULT_PORT;
+               else if (0 == strcmp(sp->protocol, "http"))
+                       sp->port = HTTP_DEFAULT_PORT;
+               else
+               {
+                               GNUNET_break (0);
+                               GNUNET_free (src);
+                               GNUNET_free (sp->protocol);
+                               GNUNET_free (sp->path);
+                               GNUNET_free (sp);
+                               return NULL;
+               }
+       }
+       if (strlen (host_start) > 0)
+                       sp->host = GNUNET_strdup (host_start);
+       else
+       {
+                       GNUNET_break (0);
+                       GNUNET_free (src);
+                       GNUNET_free (sp->protocol);
+                       GNUNET_free (sp->path);
+                       GNUNET_free (sp);
+                       return NULL;
+       }
+       GNUNET_free (src);
+       return sp;
+}
 
 /**
  * Convert the transports address to a nice, human-readable
@@ -51,24 +203,16 @@ http_common_plugin_address_pretty_printer (void *cls, const char *type,
                                         asc, void *asc_cls)
 {
   const char *saddr = (const char *) addr;
-  if (NULL == saddr)
-  {
-      asc (asc_cls, NULL);
-      return;
-  }
-  if (0 >= addrlen)
-  if (NULL == saddr)
-  {
-      asc (asc_cls, NULL);
-      return;
-  }
-  if (saddr[addrlen-1] != '\0')
-  if (NULL == saddr)
+
+  if ( (NULL == saddr) ||
+       (0 >= addrlen) ||
+       ('\0' != saddr[addrlen-1]) )
   {
       asc (asc_cls, NULL);
       return;
   }
   asc (asc_cls, saddr);
+  asc (asc_cls, NULL);
 }
 
 
@@ -146,7 +290,6 @@ http_common_address_from_socket (const char *protocol, const struct sockaddr *ad
 /**
  * Create a socketaddr from a HTTP address
  *
- * @param protocol protocol
  * @param addr sockaddr * address
  * @param addrlen length of the address
  * @param res the result:
@@ -158,11 +301,10 @@ http_common_address_from_socket (const char *protocol, const struct sockaddr *ad
 struct sockaddr *
 http_common_socket_from_address (const void *addr, size_t addrlen, int *res)
 {
+       struct SplittedHTTPAddress * spa;
   struct sockaddr_storage *s;
-  char *addrs;
-  char *addrs_org;
-  char *addrs_end;
   (*res) = GNUNET_SYSERR;
+  char * to_conv;
 
   if (NULL == addr)
     {
@@ -180,50 +322,35 @@ http_common_socket_from_address (const void *addr, size_t addrlen, int *res)
       return NULL;
     }
 
-  addrs_org = strdup ((char *) addr);
-  addrs = strstr (addrs_org , "://");
-  if (NULL == addrs)
+  spa = http_split_address (addr);
+  if (NULL == spa)
   {
-    GNUNET_break (0);
-    GNUNET_free (addrs_org);
-    return NULL;
-  }
-
-  if (strlen (addrs) < 3)
-  {
-    GNUNET_break (0);
-    GNUNET_free (addrs_org);
-    return NULL;
+      (*res) = GNUNET_SYSERR;
+      return NULL;
   }
 
-  addrs += 3;
-
-  addrs_end = strchr (addrs, '/');
-  if (NULL != addrs_end)
-    addrs[strlen (addrs) - strlen(addrs_end)] = '\0';
-
   s = GNUNET_malloc (sizeof (struct sockaddr_storage));
-  if (GNUNET_SYSERR == GNUNET_STRINGS_to_address_ip (addrs, strlen(addrs), s))
+  GNUNET_asprintf (&to_conv, "%s:%u", spa->host, spa->port);
+  if (GNUNET_SYSERR == GNUNET_STRINGS_to_address_ip (to_conv, strlen(to_conv), s))
   {
     /* could be a hostname */
-    GNUNET_free (s);
-    GNUNET_free (addrs_org);
+       GNUNET_free (s);
     (*res) = GNUNET_NO;
-    return NULL;
+    s = NULL;
+  }
+  else if ((AF_INET != s->ss_family) && (AF_INET6 != s->ss_family))
+  {
+
+               GNUNET_free (s);
+               (*res) = GNUNET_SYSERR;
+               s = NULL;
   }
   else
   {
-    if ((AF_INET != s->ss_family) && (AF_INET6 != s->ss_family))
-    {
-      GNUNET_break (0);
-      GNUNET_free (s);
-      GNUNET_free (addrs_org);
-      (*res) = GNUNET_SYSERR;
-      return NULL;
-    }
+               (*res) = GNUNET_YES;
   }
-  (*res) = GNUNET_YES;
-  GNUNET_free (addrs_org);
+       http_clean_splitted (spa);
+  GNUNET_free (to_conv);
   return (struct sockaddr *) s;
 }
 
@@ -248,7 +375,7 @@ http_common_address_get_size (const void *addr)
  * @param addrlen2 address 2 length
  * @return GNUNET_YES if equal, GNUNET_NO if not, GNUNET_SYSERR on error
  */
-int
+size_t
 http_common_cmp_addresses (const void *addr1, size_t addrlen1, const void *addr2, size_t addrlen2)
 {
   const char *a1 = (const char *) addr1;