-some fixes for monkey
[oweals/gnunet.git] / src / transport / plugin_transport_http_client.c
index 3c422cf3e10a4eef36cac2029a8e96e01be4518c..536e7382b6ae79398ee11ccf3f9620ea7dd26f81 100644 (file)
@@ -153,10 +153,27 @@ struct Session
    */
   void *client_put;
 
+
+  /**
+   * Is the client PUT handle currently paused
+   */
   int put_paused;
 
+  /**
+   * Is the client PUT handle disconnect in progress?
+   */
   int put_tmp_disconnecting;
 
+  /**
+   * Is the client PUT handle temporarily disconnected?
+   */
+  int put_tmp_disconnected;
+
+  /**
+   * We received data to send while disconnecting, reconnect immediately
+   */
+  int put_reconnect_required;
+
   /**
    * Client receive handle
    */
@@ -398,7 +415,7 @@ client_log (CURL * curl, curl_infotype type, char *data, size_t size, void *cls)
  * a fresh connection to another peer.
  *
  * @param cls closure
- * @param session which session must be used
+ * @param s which session must be used
  * @param msgbuf the message to transmit
  * @param msgbuf_size number of bytes in 'msgbuf'
  * @param priority how important is the message (most plugins will
@@ -426,6 +443,7 @@ http_client_plugin_send (void *cls,
 {
   struct HTTP_Client_Plugin *plugin = cls;
   struct HTTP_Message *msg;
+  char *stat_txt;
 
   GNUNET_assert (plugin != NULL);
   GNUNET_assert (s != NULL);
@@ -438,7 +456,7 @@ http_client_plugin_send (void *cls,
   }
 
   GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, s->plugin->name,
-                   "Session %p/connection %p: Sending message with %u to peer `%s' with \n",
+                   "Session %p/connection %p: Sending message with %u to peer `%s' \n",
                    s, s->client_put,
                    msgbuf_size, GNUNET_i2s (&s->target));
 
@@ -453,20 +471,24 @@ http_client_plugin_send (void *cls,
   memcpy (msg->buf, msgbuf, msgbuf_size);
   GNUNET_CONTAINER_DLL_insert_tail (s->msg_head, s->msg_tail, msg);
 
+  GNUNET_asprintf (&stat_txt, "# bytes currently in %s_client buffers", plugin->protocol);
+  GNUNET_STATISTICS_update (plugin->env->stats,
+                            stat_txt, msgbuf_size, GNUNET_NO);
+
+  GNUNET_free (stat_txt);
+
   if (GNUNET_YES == s->put_tmp_disconnecting)
   {
-      GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, s->plugin->name,
-                       "Session %p: Reconnecting PUT connection\n",
-                       s);
-      s->put_tmp_disconnecting = GNUNET_NO;
-      if (GNUNET_SYSERR == client_connect_put (s))
-      {
-        return GNUNET_SYSERR;
-      }
+    /* PUT connection is currently getting disconnected */
+    s->put_reconnect_required = GNUNET_YES;
+    GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, s->plugin->name,
+                     "Session %p/connection %jp: currently disconnecting, reconnecting immediately\n",
+                     s, s->client_put);
+    return msgbuf_size;
   }
-
-  if (GNUNET_YES == s->put_paused)
+  else if (GNUNET_YES == s->put_paused)
   {
+    /* PUT connection was paused, unpause */
     GNUNET_assert (s->put_disconnect_task != GNUNET_SCHEDULER_NO_TASK);
     GNUNET_SCHEDULER_cancel (s->put_disconnect_task);
     s->put_disconnect_task = GNUNET_SCHEDULER_NO_TASK;
@@ -476,6 +498,20 @@ http_client_plugin_send (void *cls,
     s->put_paused = GNUNET_NO;
     curl_easy_pause (s->client_put, CURLPAUSE_CONT);
   }
+  else if (GNUNET_YES == s->put_tmp_disconnected)
+  {
+    /* PUT connection was disconnected, reconnect */
+    GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, s->plugin->name,
+                     "Session %p: Reconnecting PUT connection\n",
+                     s);
+    s->put_tmp_disconnected = GNUNET_NO;
+    GNUNET_break (s->client_put == NULL);
+    if (GNUNET_SYSERR == client_connect_put (s))
+    {
+      return GNUNET_SYSERR;
+    }
+  }
+
   client_schedule (s->plugin, GNUNET_YES);
   client_reschedule_session_timeout (s);
   return msgbuf_size;
@@ -708,6 +744,7 @@ client_send_cb (void *stream, size_t size, size_t nmemb, void *cls)
   struct HTTP_Client_Plugin *plugin = s->plugin;
   struct HTTP_Message *msg = s->msg_head;
   size_t len;
+  char *stat_txt;
 
   if (GNUNET_YES != client_exist_session (plugin, s))
   {
@@ -750,6 +787,17 @@ client_send_cb (void *stream, size_t size, size_t nmemb, void *cls)
       msg->transmit_cont (msg->transmit_cont_cls, &s->target, GNUNET_OK);
     GNUNET_free (msg);
   }
+
+  GNUNET_asprintf (&stat_txt, "# bytes currently in %s_client buffers", plugin->protocol);
+  GNUNET_STATISTICS_update (plugin->env->stats,
+                            stat_txt, -len, GNUNET_NO);
+  GNUNET_free (stat_txt);
+
+  GNUNET_asprintf (&stat_txt, "# bytes transmitted via %s_client", plugin->protocol);
+  GNUNET_STATISTICS_update (plugin->env->stats,
+                            stat_txt, len, GNUNET_NO);
+  GNUNET_free (stat_txt);
+
   client_reschedule_session_timeout (s);
   return len;
 }
@@ -797,6 +845,7 @@ client_receive_mst_cb (void *cls, void *client,
   struct HTTP_Client_Plugin *plugin;
   struct GNUNET_TIME_Relative delay;
   struct GNUNET_ATS_Information atsi[2];
+  char *stat_txt;
   if (GNUNET_YES != client_exist_session(p, s))
   {
     GNUNET_break (0);
@@ -814,6 +863,11 @@ client_receive_mst_cb (void *cls, void *client,
                                    (const struct GNUNET_ATS_Information *) &atsi, 2,
                                    s, s->addr, s->addrlen);
 
+  GNUNET_asprintf (&stat_txt, "# bytes received via %s_client", plugin->protocol);
+  GNUNET_STATISTICS_update (plugin->env->stats,
+                            stat_txt, ntohs(message->size), GNUNET_NO);
+  GNUNET_free (stat_txt);
+
   s->next_receive =
       GNUNET_TIME_absolute_add (GNUNET_TIME_absolute_get (), delay);
 
@@ -866,8 +920,9 @@ client_receive (void *stream, size_t size, size_t nmemb, void *cls)
   struct HTTP_Client_Plugin *plugin = s->plugin;
 
   GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, plugin->name,
-                   "Received %u bytes from peer `%s'\n", len,
-                   GNUNET_i2s (&s->target));
+                   "Session %p / connection %p: Received %u bytes from peer `%s'\n",
+                   s, s->client_get,
+                   len, GNUNET_i2s (&s->target));
   now = GNUNET_TIME_absolute_get ();
   if (now.abs_value < s->next_receive.abs_value)
   {
@@ -875,8 +930,8 @@ client_receive (void *stream, size_t size, size_t nmemb, void *cls)
     struct GNUNET_TIME_Relative delta =
         GNUNET_TIME_absolute_get_difference (now, s->next_receive);
     GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, plugin->name,
-                     "No inbound bandwidth for session %p available! Next read was delayed for %llu ms\n",
-                     s, delta.rel_value);
+                     "Session %p / connection %p: No inbound bandwidth available! Next read was delayed for %llu ms\n",
+                     s, s->client_get, delta.rel_value);
     if (s->recv_wakeup_task != GNUNET_SCHEDULER_NO_TASK)
     {
       GNUNET_SCHEDULER_cancel (s->recv_wakeup_task);
@@ -884,7 +939,7 @@ client_receive (void *stream, size_t size, size_t nmemb, void *cls)
     }
     s->recv_wakeup_task =
         GNUNET_SCHEDULER_add_delayed (delta, &client_wake_up, s);
-    return CURLPAUSE_ALL;
+    return CURL_WRITEFUNC_PAUSE;
   }
   if (NULL == s->msg_tk)
     s->msg_tk = GNUNET_SERVER_mst_create (&client_receive_mst_cb, s);
@@ -983,7 +1038,7 @@ client_run (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
 {
   struct HTTP_Client_Plugin *plugin = cls;
   int running;
-  int http_statuscode;
+  long http_statuscode;
   CURLMcode mret;
 
   GNUNET_assert (cls != NULL);
@@ -1051,7 +1106,20 @@ client_run (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
             }
             curl_multi_remove_handle (plugin->curl_multi_handle, easy_h);
             curl_easy_cleanup (easy_h);
+            s->put_tmp_disconnecting = GNUNET_NO;
+            s->put_tmp_disconnected = GNUNET_YES;
             s->client_put = NULL;
+
+            /*
+             * Handling a rare case:
+             * plugin_send was called during temporary put disconnect,
+             * reconnect required after connection was disconnected
+             */
+            if (GNUNET_YES == s->put_reconnect_required)
+            {
+                s->put_reconnect_required = GNUNET_NO;
+                client_connect_put(s);
+            }
         }
         if (easy_h == s->client_get)
         {
@@ -1132,17 +1200,9 @@ client_connect_put (struct Session *s)
 {
   CURLMcode mret;
   /* create put connection */
-  if (NULL == s->client_put)
-  {
-      GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR, s->plugin->name,
+  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, s->plugin->name,
                        "Session %p : Init PUT handle \n", s);
-    s->client_put = curl_easy_init ();
-  }
-  else
-  {
-      GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR, s->plugin->name,
-                       "Session %p : Reusing PUT handle %p \n", s, s->client_put);
-  }
+  s->client_put = curl_easy_init ();
 #if VERBOSE_CURL
   curl_easy_setopt (s->client_put, CURLOPT_VERBOSE, 1L);
   curl_easy_setopt (s->client_put, CURLOPT_DEBUGFUNCTION, &client_log);
@@ -1321,7 +1381,7 @@ http_client_plugin_get_session (void *cls,
   s->ats_address_network_type = ats.value;
   s->put_paused = GNUNET_NO;
   s->put_tmp_disconnecting = GNUNET_NO;
-
+  s->put_tmp_disconnected = GNUNET_NO;
   client_start_session_timeout (s);
 
   /* add new session */