transport service hello reduction, klocwork fixes
[oweals/gnunet.git] / src / transport / plugin_transport_http.c
index c5de1cc7863d42cc97b265a1822ecd9f13e071c7..952078865020fc62d8e5248513d8702753894763 100644 (file)
 #include "microhttpd.h"
 #include <curl/curl.h>
 
-#define DEBUG_HTTP GNUNET_YES
-#define DEBUG_CURL GNUNET_YES
-#define DEBUG_CONNECTIONS GNUNET_YES
-#define DEBUG_SESSION_SELECTION GNUNET_YES
+#define DEBUG_HTTP GNUNET_NO
+#define DEBUG_CURL GNUNET_NO
+#define DEBUG_MHD GNUNET_YES
+#define DEBUG_CONNECTIONS GNUNET_NO
+#define DEBUG_SESSION_SELECTION GNUNET_NO
 
 #define INBOUND GNUNET_NO
 #define OUTBOUND GNUNET_YES
 
+#define PROTOCOL_PREFIX "http"
+
 /**
  * Text of the response sent back after the last bytes of a PUT
  * request have been received (just to formally obey the HTTP
@@ -361,6 +364,7 @@ struct Plugin
   char * bind_hostname;
   int use_ipv6;
   int use_ipv4;
+  void * mhd_log;
 };
 
 
@@ -415,13 +419,13 @@ static char * create_url(void * cls, const void * addr, size_t addrlen, size_t i
 {
   struct Plugin *plugin = cls;
   char *url = NULL;
+  char *addr_str = (char *) http_plugin_address_to_string(NULL, addr, addrlen);
 
   GNUNET_assert ((addr!=NULL) && (addrlen != 0));
   GNUNET_asprintf(&url,
-                  "http://%s/%s;%u",
-                  http_plugin_address_to_string(NULL, addr, addrlen),
+                  "%s://%s/%s;%u", PROTOCOL_PREFIX, addr_str,
                   (char *) (&plugin->my_ascii_hash_ident),id);
-
+  GNUNET_free_non_null(addr_str);
   return url;
 }
 
@@ -438,6 +442,8 @@ static int remove_http_message (struct Session * ps, struct HTTP_Message * msg)
   return GNUNET_OK;
 }
 
+int remove_peer_context_Iterator (void *cls, const GNUNET_HashCode *key, void *value);
+
 /**
  * Removes a session from the linked list of sessions
  * @param pc peer context
@@ -460,6 +466,20 @@ static int remove_session (struct HTTP_PeerContext * pc, struct Session * ps,  i
   GNUNET_SERVER_mst_destroy (ps->msgtok);
   GNUNET_free(ps->url);
 
+  if (ps->direction==INBOUND)
+  {
+         if (ps->recv_endpoint != NULL)
+         {
+                 curl_easy_cleanup(ps->recv_endpoint);
+                 ps->recv_endpoint = NULL;
+         }
+         if (ps->send_endpoint != NULL)
+         {
+                 curl_easy_cleanup(ps->send_endpoint);
+                 ps->send_endpoint = NULL;
+         }
+  }
+
   msg = ps->pending_msgs_head;
   while (msg!=NULL)
   {
@@ -467,14 +487,24 @@ static int remove_session (struct HTTP_PeerContext * pc, struct Session * ps,  i
     {
       msg->transmit_cont (msg->transmit_cont_cls,&pc->identity,call_msg_cont_result);
     }
-    GNUNET_free(msg);
     GNUNET_CONTAINER_DLL_remove(ps->pending_msgs_head,ps->pending_msgs_head,msg);
+    GNUNET_free(msg);
     msg = ps->pending_msgs_head;
   }
 
   GNUNET_CONTAINER_DLL_remove(pc->head,pc->tail,ps);
   GNUNET_free(ps);
   ps = NULL;
+
+  /* no sessions left remove peer */
+  if (pc->head==NULL)
+  {
+#if DEBUG_HTTP
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,"No sessions left for peer `%s', removing context\n",GNUNET_i2s(&pc->identity));
+#endif
+       remove_peer_context_Iterator(plugin, &pc->identity.hashPubKey, pc);
+  }
+
   return GNUNET_OK;
 }
 
@@ -489,6 +519,7 @@ int remove_peer_context_Iterator (void *cls, const GNUNET_HashCode *key, void *v
 #if DEBUG_HTTP
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,"Freeing context for peer `%s'\n",GNUNET_i2s(&pc->identity));
 #endif
+  GNUNET_CONTAINER_multihashmap_remove (plugin->peers, &pc->identity.hashPubKey, pc);
   while (ps!=NULL)
   {
        plugin->env->session_end(plugin, &pc->identity, ps);
@@ -518,6 +549,10 @@ int remove_peer_context_Iterator (void *cls, const GNUNET_HashCode *key, void *v
     ps=tmp;
   }
   GNUNET_free(pc);
+  GNUNET_STATISTICS_update (plugin->env->stats,
+                           gettext_noop ("# HTTP peers active"),
+                           -1,
+                           GNUNET_NO);
   return GNUNET_YES;
 }
 
@@ -575,12 +610,12 @@ process_interfaces (void *cls,
   else if ((af == AF_INET6) && (plugin->use_ipv6 == GNUNET_YES)  && (plugin->bind4_address == NULL))
     {
          struct in6_addr bnd_cmp6 = ((struct sockaddr_in6 *) addr)->sin6_addr;
-      t6 = GNUNET_malloc(sizeof(struct IPv6HttpAddress));
       if (IN6_IS_ADDR_LINKLOCAL (&((struct sockaddr_in6 *) addr)->sin6_addr))
         {
           return GNUNET_OK;
         }
-
+      t6 = GNUNET_malloc(sizeof(struct IPv6HttpAddress));
+      GNUNET_assert(t6 != NULL);
       if (plugin->bind6_address != NULL)
       {
          if (0 == memcmp(&plugin->bind6_address->sin6_addr, &bnd_cmp6, sizeof (struct in6_addr)))
@@ -605,6 +640,13 @@ process_interfaces (void *cls,
   return GNUNET_OK;
 }
 
+void mhd_logger (void * arg, const char * fmt, va_list ap)
+{
+       char text[1024];
+       vsnprintf(text, 1024, fmt, ap);
+       va_end(ap);
+       GNUNET_log (GNUNET_ERROR_TYPE_ERROR,"MHD: %s \n", text);
+}
 
 /**
  * Callback called by MHD when a connection is terminated
@@ -639,6 +681,10 @@ static void mhd_termination_cb (void *cls, struct MHD_Connection * connection, v
   /* if both connections disconnected, remove session */
   if ((ps->send_connected == GNUNET_NO) && (ps->recv_connected == GNUNET_NO))
   {
+      GNUNET_STATISTICS_update (pc->plugin->env->stats,
+                           gettext_noop ("# HTTP inbound sessions for peers active"),
+                           -1,
+                           GNUNET_NO);
     remove_session(pc,ps,GNUNET_YES,GNUNET_SYSERR);
   }
 }
@@ -649,8 +695,9 @@ static void mhd_write_mst_cb (void *cls,
 {
 
   struct Session *ps  = cls;
-  struct HTTP_PeerContext *pc = ps->peercontext;
   GNUNET_assert(ps != NULL);
+
+  struct HTTP_PeerContext *pc = ps->peercontext;
   GNUNET_assert(pc != NULL);
 #if DEBUG_HTTP
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
@@ -761,8 +808,8 @@ mdh_access_cb (void *cls,
 
   int res = GNUNET_NO;
   int send_error_to_client;
-  void * addr;
-  size_t addr_len;
+  void * addr = NULL;
+  size_t addr_len = 0 ;
 
   GNUNET_assert(cls !=NULL);
   send_error_to_client = GNUNET_NO;
@@ -817,6 +864,10 @@ mdh_access_cb (void *cls,
       pc->last_session = NULL;
       memcpy(&pc->identity, &pi_in, sizeof(struct GNUNET_PeerIdentity));
       GNUNET_CONTAINER_multihashmap_put(plugin->peers, &pc->identity.hashPubKey, pc, GNUNET_CONTAINER_MULTIHASHMAPOPTION_UNIQUE_ONLY);
+      GNUNET_STATISTICS_update (plugin->env->stats,
+                           gettext_noop ("# HTTP peers active"),
+                           1,
+                           GNUNET_NO);
     }
 
     conn_info = MHD_get_connection_info(mhd_connection, MHD_CONNECTION_INFO_CLIENT_ADDRESS );
@@ -841,6 +892,9 @@ mdh_access_cb (void *cls,
       addr_len = sizeof(struct IPv6HttpAddress);
     }
 
+    GNUNET_assert (addr != NULL);
+    GNUNET_assert (addr_len != 0);
+
     ps = NULL;
     /* only inbound sessions here */
 
@@ -873,6 +927,10 @@ mdh_access_cb (void *cls,
       ps->session_id =id_num;
       ps->url = create_url (plugin, ps->addr, ps->addrlen, ps->session_id);
       GNUNET_CONTAINER_DLL_insert(pc->head,pc->tail,ps);
+      GNUNET_STATISTICS_update (plugin->env->stats,
+                           gettext_noop ("# HTTP inbound sessions for peers active"),
+                           1,
+                           GNUNET_NO);
     }
 
     *httpSessionCache = ps;
@@ -1086,16 +1144,12 @@ static size_t curl_get_header_cb( void *ptr, size_t size, size_t nmemb, void *st
 {
   struct Session * ps = stream;
 
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,"Connection %X: curl_get_header_cb\n",ps);
-
-  char * tmp;
-  size_t len = size * nmemb;
   long http_result = 0;
   int res;
   /* Getting last http result code */
+  GNUNET_assert(NULL!=ps);
   if (ps->recv_connected==GNUNET_NO)
   {
-    GNUNET_assert(NULL!=ps);
     res = curl_easy_getinfo(ps->recv_endpoint, CURLINFO_RESPONSE_CODE, &http_result);
     if (CURLE_OK == res)
     {
@@ -1112,6 +1166,9 @@ static size_t curl_get_header_cb( void *ptr, size_t size, size_t nmemb, void *st
     }
   }
 
+#if DEBUG_CURL
+  char * tmp;
+  size_t len = size * nmemb;
   tmp = NULL;
   if ((size * nmemb) < SIZE_MAX)
     tmp = GNUNET_malloc (len+1);
@@ -1128,6 +1185,7 @@ static size_t curl_get_header_cb( void *ptr, size_t size, size_t nmemb, void *st
   }
   if (NULL != tmp)
     GNUNET_free (tmp);
+#endif
 
   return size * nmemb;
 }
@@ -1212,7 +1270,8 @@ static size_t curl_send_cb(void *stream, size_t size, size_t nmemb, void *ptr)
     return CURL_READFUNC_PAUSE;
   }
 
-  msg = ps->pending_msgs_tail;
+  GNUNET_assert (msg!=NULL);
+
   /* data to send */
   if (msg->pos < msg->size)
   {
@@ -1244,7 +1303,7 @@ static size_t curl_send_cb(void *stream, size_t size, size_t nmemb, void *ptr)
     GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,"Connection %X: Message with %u bytes sent, removing message from queue \n",ps, msg->pos);
 #endif
     /* Calling transmit continuation  */
-    if (( NULL != ps->pending_msgs_tail) && (NULL != ps->pending_msgs_tail->transmit_cont))
+    if (NULL != ps->pending_msgs_tail->transmit_cont)
       msg->transmit_cont (ps->pending_msgs_tail->transmit_cont_cls,&(ps->peercontext)->identity,GNUNET_OK);
     remove_http_message(ps, msg);
   }
@@ -1256,8 +1315,9 @@ static void curl_receive_mst_cb  (void *cls,
                                 const struct GNUNET_MessageHeader *message)
 {
   struct Session *ps  = cls;
-  struct HTTP_PeerContext *pc = ps->peercontext;
   GNUNET_assert(ps != NULL);
+
+  struct HTTP_PeerContext *pc = ps->peercontext;
   GNUNET_assert(pc != NULL);
 #if DEBUG_HTTP
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
@@ -1307,6 +1367,7 @@ static void curl_perform (void *cls,
   struct HTTP_PeerContext *pc = NULL;
   struct HTTP_Message * cur_msg = NULL;
   long http_result;
+  char * tmp;
 
   GNUNET_assert(cls !=NULL);
 
@@ -1328,7 +1389,8 @@ static void curl_perform (void *cls,
                  break;
               /* get session for affected curl handle */
               GNUNET_assert ( msg->easy_handle != NULL );
-              curl_easy_getinfo(msg->easy_handle, CURLINFO_PRIVATE, (char *) &ps);
+              curl_easy_getinfo(msg->easy_handle, CURLINFO_PRIVATE, &tmp);
+              ps = (struct Session *) tmp;
               GNUNET_assert ( ps != NULL );
               pc = ps->peercontext;
               GNUNET_assert ( pc != NULL );
@@ -1354,8 +1416,8 @@ static void curl_perform (void *cls,
                       ps->send_connected = GNUNET_NO;
                       ps->send_active = GNUNET_NO;
                       curl_multi_remove_handle(plugin->multi_handle,ps->send_endpoint);
-                      curl_easy_cleanup(ps->send_endpoint);
-                      ps->send_endpoint=NULL;
+                      //curl_easy_cleanup(ps->send_endpoint);
+                      //ps->send_endpoint=NULL;
                       cur_msg = ps->pending_msgs_tail;
                       if (( NULL != cur_msg) && ( NULL != cur_msg->transmit_cont))
                         cur_msg->transmit_cont (cur_msg->transmit_cont_cls,&pc->identity,GNUNET_SYSERR);
@@ -1375,8 +1437,8 @@ static void curl_perform (void *cls,
                       ps->recv_connected = GNUNET_NO;
                       ps->recv_active = GNUNET_NO;
                       curl_multi_remove_handle(plugin->multi_handle,ps->recv_endpoint);
-                      curl_easy_cleanup(ps->recv_endpoint);
-                      ps->recv_endpoint=NULL;
+                      //curl_easy_cleanup(ps->recv_endpoint);
+                      //ps->recv_endpoint=NULL;
                     }
                   }
                   else
@@ -1409,8 +1471,8 @@ static void curl_perform (void *cls,
                       ps->send_connected = GNUNET_NO;
                       ps->send_active = GNUNET_NO;
                       curl_multi_remove_handle(plugin->multi_handle,ps->send_endpoint);
-                      curl_easy_cleanup(ps->send_endpoint);
-                      ps->send_endpoint =NULL;
+                      //curl_easy_cleanup(ps->send_endpoint);
+                      //ps->send_endpoint =NULL;
                     }
                     if (msg->easy_handle == ps->recv_endpoint)
                     {
@@ -1425,8 +1487,8 @@ static void curl_perform (void *cls,
                       ps->recv_connected = GNUNET_NO;
                       ps->recv_active = GNUNET_NO;
                       curl_multi_remove_handle(plugin->multi_handle,ps->recv_endpoint);
-                      curl_easy_cleanup(ps->recv_endpoint);
-                      ps->recv_endpoint=NULL;
+                      //curl_easy_cleanup(ps->recv_endpoint);
+                      //ps->recv_endpoint=NULL;
                     }
                   }
                   if ((ps->recv_connected == GNUNET_NO) && (ps->send_connected == GNUNET_NO))
@@ -1534,9 +1596,12 @@ static ssize_t send_check_connections (void *cls, struct Session *ps)
     /* Check if session is connected to receive data, otherwise connect to peer */
     if (ps->recv_connected == GNUNET_NO)
     {
+       int fresh = GNUNET_NO;
         if (ps->recv_endpoint == NULL)
         {
-          ps->recv_endpoint = curl_easy_init();
+            fresh = GNUNET_YES;
+               ps->recv_endpoint = curl_easy_init();
+        }
 #if DEBUG_CURL
         curl_easy_setopt(ps->recv_endpoint, CURLOPT_VERBOSE, 1L);
 #endif
@@ -1552,15 +1617,18 @@ static ssize_t send_check_connections (void *cls, struct Session *ps)
         curl_easy_setopt(ps->recv_endpoint, CURLOPT_CONNECTTIMEOUT, HTTP_CONNECT_TIMEOUT);
         curl_easy_setopt(ps->recv_endpoint, CURLOPT_BUFFERSIZE, GNUNET_SERVER_MAX_MESSAGE_SIZE);
 
-        mret = curl_multi_add_handle(plugin->multi_handle, ps->recv_endpoint);
-        if (mret != CURLM_OK)
+        if (fresh==GNUNET_YES)
         {
-          GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
-                                         _("Connection: %X: %s failed at %s:%d: `%s'\n"),
-                                         ps,
-                      "curl_multi_add_handle", __FILE__, __LINE__,
-                      curl_multi_strerror (mret));
-          return GNUNET_SYSERR;
+                       mret = curl_multi_add_handle(plugin->multi_handle, ps->recv_endpoint);
+                       if (mret != CURLM_OK)
+                       {
+                         GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+                                                 _("Connection: %X: %s failed at %s:%d: `%s'\n"),
+                                                 ps,
+                                                 "curl_multi_add_handle", __FILE__, __LINE__,
+                                                 curl_multi_strerror (mret));
+                         return GNUNET_SYSERR;
+                       }
         }
         if (curl_schedule (plugin) == GNUNET_SYSERR)
         {
@@ -1572,7 +1640,6 @@ static ssize_t send_check_connections (void *cls, struct Session *ps)
 #if DEBUG_CONNECTIONS
         GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,"Connection %X: inbound not connected, initiating connection\n",ps);
 #endif
-      }
     }
 
     /* waiting for receive direction */
@@ -1605,9 +1672,14 @@ static ssize_t send_check_connections (void *cls, struct Session *ps)
       }
     }
     /* not connected, initiate connection */
-    if ((ps->send_connected==GNUNET_NO) && (NULL == ps->send_endpoint))
+    if (ps->send_connected==GNUNET_NO)
     {
-       ps->send_endpoint = curl_easy_init();
+       int fresh = GNUNET_NO;
+       if (NULL == ps->send_endpoint)
+       {
+               ps->send_endpoint = curl_easy_init();
+               fresh = GNUNET_YES;
+       }
                GNUNET_assert (ps->send_endpoint != NULL);
                GNUNET_assert (NULL != ps->pending_msgs_tail);
 #if DEBUG_CONNECTIONS
@@ -1632,15 +1704,18 @@ static ssize_t send_check_connections (void *cls, struct Session *ps)
                curl_easy_setopt(ps->send_endpoint, CURLOPT_CONNECTTIMEOUT, HTTP_CONNECT_TIMEOUT);
                curl_easy_setopt(ps->send_endpoint, CURLOPT_BUFFERSIZE, GNUNET_SERVER_MAX_MESSAGE_SIZE);
 
-               mret = curl_multi_add_handle(plugin->multi_handle, ps->send_endpoint);
-               if (mret != CURLM_OK)
+               if (fresh==GNUNET_YES)
                {
-                 GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
-                                         _("Connection: %X: %s failed at %s:%d: `%s'\n"),
-                                         ps,
-                                         "curl_multi_add_handle", __FILE__, __LINE__,
-                                         curl_multi_strerror (mret));
-                 return GNUNET_SYSERR;
+                       mret = curl_multi_add_handle(plugin->multi_handle, ps->send_endpoint);
+                       if (mret != CURLM_OK)
+                       {
+                         GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+                                                 _("Connection: %X: %s failed at %s:%d: `%s'\n"),
+                                                 ps,
+                                                 "curl_multi_add_handle", __FILE__, __LINE__,
+                                                 curl_multi_strerror (mret));
+                         return GNUNET_SYSERR;
+                       }
                }
     }
     if (curl_schedule (plugin) == GNUNET_SYSERR)
@@ -1851,6 +1926,10 @@ http_plugin_send (void *cls,
     pc->last_session = NULL;
     memcpy(&pc->identity, target, sizeof(struct GNUNET_PeerIdentity));
     GNUNET_CONTAINER_multihashmap_put(plugin->peers, &pc->identity.hashPubKey, pc, GNUNET_CONTAINER_MULTIHASHMAPOPTION_UNIQUE_ONLY);
+    GNUNET_STATISTICS_update (plugin->env->stats,
+                           gettext_noop ("# HTTP peers active"),
+                           1,
+                           GNUNET_NO);
   }
 
   ps = send_select_session (plugin, pc, addr, addrlen, force_address, session);
@@ -1892,6 +1971,12 @@ http_plugin_send (void *cls,
       if (ps->msgtok == NULL)
         ps->msgtok = GNUNET_SERVER_mst_create (&curl_receive_mst_cb, ps);
       GNUNET_CONTAINER_DLL_insert(pc->head,pc->tail,ps);
+/* FIXME */
+
+      GNUNET_STATISTICS_update (plugin->env->stats,
+                           gettext_noop ("# HTTP outbound sessions for peers active"),
+                           1,
+                           GNUNET_NO);
     }
     else
     {
@@ -2048,7 +2133,7 @@ http_plugin_address_pretty_printer (void *cls,
     asc (asc_cls, NULL);
     return;
   }
-  res = GNUNET_asprintf(&ret,"http://%s:%u/",address,port);
+  res = GNUNET_asprintf(&ret,"%s://%s:%u/", PROTOCOL_PREFIX, address, port);
   GNUNET_free (address);
   GNUNET_assert(res != 0);
   asc (asc_cls, ret);
@@ -2339,26 +2424,26 @@ libgnunet_plugin_transport_http_init (void *cls)
   if ((plugin->use_ipv6==GNUNET_YES) && (GNUNET_CONFIGURATION_have_value (env->cfg,
                                                                   "transport-http", "BINDTO6")))
   {
-         GNUNET_break (GNUNET_OK ==
-                                       GNUNET_CONFIGURATION_get_value_string (env->cfg,
+         if (GNUNET_OK == GNUNET_CONFIGURATION_get_value_string (env->cfg,
                                                                                                                   "transport-http",
                                                                                                                   "BINDTO6",
-                                                                                                                  &plugin->bind_hostname));
-
-         plugin->bind6_address = GNUNET_malloc(sizeof(struct sockaddr_in6));
-         plugin->bind6_address->sin6_family = AF_INET6;
-         plugin->bind6_address->sin6_port = htons (port);
-
-      if (inet_pton(AF_INET6,plugin->bind_hostname, &plugin->bind6_address->sin6_addr)<=0)
+                                                                                                                  &plugin->bind_hostname))
          {
-                 GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR,
-                                                  "http",
-                                                  _("Misconfigured address to bind to in configuration!\n"),
-                                                  "transport-http");
-                 GNUNET_free(plugin->bind6_address);
-                 GNUNET_free(plugin->bind_hostname);
-                 plugin->bind_hostname = NULL;
-                 plugin->bind6_address = NULL;
+                 plugin->bind6_address = GNUNET_malloc(sizeof(struct sockaddr_in6));
+                 plugin->bind6_address->sin6_family = AF_INET6;
+                 plugin->bind6_address->sin6_port = htons (port);
+
+                 if (inet_pton(AF_INET6,plugin->bind_hostname, &plugin->bind6_address->sin6_addr)<=0)
+                 {
+                         GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR,
+                                                          "http",
+                                                          _("Misconfigured address to bind to in configuration!\n"),
+                                                          "transport-http");
+                         GNUNET_free(plugin->bind6_address);
+                         GNUNET_free(plugin->bind_hostname);
+                         plugin->bind_hostname = NULL;
+                         plugin->bind6_address = NULL;
+                 }
          }
   }
 
@@ -2370,7 +2455,7 @@ libgnunet_plugin_transport_http_init (void *cls)
   {
        struct sockaddr * tmp = (struct sockaddr *) plugin->bind6_address;
     plugin->http_server_daemon_v6 = MHD_start_daemon (
-#if DEBUG_CONNECTIONS
+#if DEBUG_MHD
                                                                   MHD_USE_DEBUG |
 #endif
                                                                   MHD_USE_IPv6,
@@ -2383,12 +2468,13 @@ libgnunet_plugin_transport_http_init (void *cls)
                                        MHD_OPTION_CONNECTION_TIMEOUT, (unsigned int) timeout,
                                        MHD_OPTION_CONNECTION_MEMORY_LIMIT, (size_t) (16 * 1024),
                                        MHD_OPTION_NOTIFY_COMPLETED, &mhd_termination_cb, NULL,
+                                       MHD_OPTION_EXTERNAL_LOGGER, mhd_logger, plugin->mhd_log,
                                        MHD_OPTION_END);
   }
   if ((plugin->http_server_daemon_v4 == NULL) && (plugin->use_ipv4 == GNUNET_YES) && (port != 0))
   {
   plugin->http_server_daemon_v4 = MHD_start_daemon (
-#if DEBUG_CONNECTIONS
+#if DEBUG_MHD
                                                                   MHD_USE_DEBUG |
 #endif
                                                                   MHD_NO_FLAG,
@@ -2401,6 +2487,7 @@ libgnunet_plugin_transport_http_init (void *cls)
                                        MHD_OPTION_CONNECTION_TIMEOUT, (unsigned int) timeout,
                                        MHD_OPTION_CONNECTION_MEMORY_LIMIT, (size_t) (16 * 1024),
                                        MHD_OPTION_NOTIFY_COMPLETED, &mhd_termination_cb, NULL,
+                                       MHD_OPTION_EXTERNAL_LOGGER, mhd_logger, plugin->mhd_log,
                                        MHD_OPTION_END);
   }
   if (plugin->http_server_daemon_v4 != NULL)
@@ -2429,9 +2516,17 @@ libgnunet_plugin_transport_http_init (void *cls)
   }
   else
   {
-#if DEBUG_HTTP
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,"No MHD was started, transport plugin not functional!\n");
-#endif
+       char * tmp = NULL;
+       if ((plugin->use_ipv6 == GNUNET_YES) && (plugin->use_ipv4 == GNUNET_YES))
+               GNUNET_asprintf(&tmp,"with IPv4 and IPv6 enabled");
+       if ((plugin->use_ipv6 == GNUNET_NO) && (plugin->use_ipv4 == GNUNET_YES))
+               GNUNET_asprintf(&tmp,"with IPv4 enabled");
+       if ((plugin->use_ipv6 == GNUNET_YES) && (plugin->use_ipv4 == GNUNET_NO))
+               GNUNET_asprintf(&tmp,"with IPv6 enabled");
+       if ((plugin->use_ipv6 == GNUNET_NO) && (plugin->use_ipv4 == GNUNET_NO))
+               GNUNET_asprintf(&tmp,"with NO IP PROTOCOL enabled");
+       GNUNET_log (GNUNET_ERROR_TYPE_ERROR,"HTTP Server with %s could not be started on port %u! https plugin failed!\n",tmp, port);
+       GNUNET_free(tmp);
     libgnunet_plugin_transport_http_done (api);
     return NULL;
   }
@@ -2443,9 +2538,9 @@ libgnunet_plugin_transport_http_init (void *cls)
   if ( NULL == plugin->multi_handle )
   {
     GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR,
-                                  "http",
+                                  "https",
                                   _("Could not initialize curl multi handle, failed to start http plugin!\n"),
-                                  "transport-http");
+                                  "transport-https");
     libgnunet_plugin_transport_http_done (api);
     return NULL;
   }