(no commit message)
[oweals/gnunet.git] / src / transport / plugin_transport_http.c
index da298308e4a75ee14ccf458210ef5b67287eec8d..5cd611d1f1b5783c1434a90b94b9c1f7960f4180 100644 (file)
 #include "microhttpd.h"
 #include <curl/curl.h>
 
-
-#define DEBUG_CURL GNUNET_NO
 #define DEBUG_HTTP GNUNET_NO
+#define DEBUG_CURL GNUNET_NO
 #define DEBUG_CONNECTIONS GNUNET_NO
-#define DEBUG_SESSION_SELECTION GNUNET_YES
+#define DEBUG_SESSION_SELECTION GNUNET_NO
 
 #define INBOUND GNUNET_NO
 #define OUTBOUND GNUNET_YES
@@ -357,7 +356,11 @@ struct Plugin
    */
   struct GNUNET_CRYPTO_HashAsciiEncoded my_ascii_hash_ident;
 
-  struct in_addr * bind_address;
+  struct sockaddr_in * bind4_address;
+  struct sockaddr_in6 * bind6_address;
+  char * bind_hostname;
+  int use_ipv6;
+  int use_ipv4;
 };
 
 
@@ -448,7 +451,9 @@ static int remove_session (struct HTTP_PeerContext * pc, struct Session * ps,  i
   struct HTTP_Message * msg;
   struct Plugin * plugin = ps->peercontext->plugin;
 
+#if DEBUG_CONNECTIONS
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,"Connection %X: removing %s session %X with id %u\n", ps, (ps->direction == INBOUND) ? "inbound" : "outbound", ps, ps->session_id);
+#endif
   plugin->env->session_end(plugin, &pc->identity, ps);
 
   GNUNET_free_non_null (ps->addr);
@@ -481,9 +486,9 @@ int remove_peer_context_Iterator (void *cls, const GNUNET_HashCode *key, void *v
   struct Session * tmp = NULL;
   struct HTTP_Message * msg = NULL;
   struct HTTP_Message * msg_tmp = NULL;
-
+#if DEBUG_HTTP
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,"Freeing context for peer `%s'\n",GNUNET_i2s(&pc->identity));
-
+#endif
   while (ps!=NULL)
   {
        plugin->env->session_end(plugin, &pc->identity, ps);
@@ -537,12 +542,13 @@ process_interfaces (void *cls,
   struct IPv4HttpAddress * t4;
   struct IPv6HttpAddress * t6;
   int af;
-  struct in_addr bnd_cmp = ((struct sockaddr_in *) addr)->sin_addr;
+
 
   GNUNET_assert(cls !=NULL);
   af = addr->sa_family;
-  if (af == AF_INET)
+  if ((af == AF_INET) && (plugin->use_ipv4 == GNUNET_YES) && (plugin->bind6_address == NULL))
     {
+         struct in_addr bnd_cmp = ((struct sockaddr_in *) addr)->sin_addr;
       t4 = GNUNET_malloc(sizeof(struct IPv4HttpAddress));
       /* Not skipping loopback addresses
       if (INADDR_LOOPBACK == ntohl(((struct sockaddr_in *) addr)->sin_addr.s_addr))
@@ -553,39 +559,49 @@ process_interfaces (void *cls,
       */
       t4->ipv4_addr = ((struct sockaddr_in *) addr)->sin_addr.s_addr;
       t4->u_port = htons (plugin->port_inbound);
-      if (plugin->bind_address != NULL)
+      if (plugin->bind4_address != NULL)
       {
-         if (0 == memcmp(plugin->bind_address, &bnd_cmp, sizeof (struct in_addr)))
+         if (0 == memcmp(&plugin->bind4_address->sin_addr, &bnd_cmp, sizeof (struct in_addr)))
+         {
                  plugin->env->notify_address(plugin->env->cls,"http",t4, sizeof (struct IPv4HttpAddress), GNUNET_TIME_UNIT_FOREVER_REL);
+         }
       }
       else
       {
          plugin->env->notify_address(plugin->env->cls,"http",t4, sizeof (struct IPv4HttpAddress), GNUNET_TIME_UNIT_FOREVER_REL);
       }
-
+      GNUNET_free (t4);
     }
-  else if ((af == AF_INET6) && (plugin->bind_address == NULL))
+  else if ((af == AF_INET6) && (plugin->use_ipv6 == GNUNET_YES)  && (plugin->bind4_address == NULL))
     {
+         struct in6_addr bnd_cmp6 = ((struct sockaddr_in6 *) addr)->sin6_addr;
       t6 = GNUNET_malloc(sizeof(struct IPv6HttpAddress));
       if (IN6_IS_ADDR_LINKLOCAL (&((struct sockaddr_in6 *) addr)->sin6_addr))
         {
-          /* skip link local addresses */
           return GNUNET_OK;
         }
-      /* Not skipping loopback addresses
-      if (IN6_IS_ADDR_LOOPBACK (&((struct sockaddr_in6 *) addr)->sin6_addr))
-        {
 
-          return GNUNET_OK;
-        }
-      */
-      memcpy (&t6->ipv6_addr,
-              &((struct sockaddr_in6 *) addr)->sin6_addr,
-              sizeof (struct in6_addr));
-      t6->u6_port = htons (plugin->port_inbound);
-      plugin->env->notify_address(plugin->env->cls,"http",t6,sizeof (struct IPv6HttpAddress) , GNUNET_TIME_UNIT_FOREVER_REL);
+      if (plugin->bind6_address != NULL)
+      {
+         if (0 == memcmp(&plugin->bind6_address->sin6_addr, &bnd_cmp6, sizeof (struct in6_addr)))
+         {
+             memcpy (&t6->ipv6_addr,
+                     &((struct sockaddr_in6 *) addr)->sin6_addr,
+                     sizeof (struct in6_addr));
+             t6->u6_port = htons (plugin->port_inbound);
+             plugin->env->notify_address(plugin->env->cls,"http",t6,sizeof (struct IPv6HttpAddress) , GNUNET_TIME_UNIT_FOREVER_REL);
+         }
+      }
+      else
+      {
+          memcpy (&t6->ipv6_addr,
+                  &((struct sockaddr_in6 *) addr)->sin6_addr,
+                  sizeof (struct in6_addr));
+          t6->u6_port = htons (plugin->port_inbound);
+          plugin->env->notify_address(plugin->env->cls,"http",t6,sizeof (struct IPv6HttpAddress) , GNUNET_TIME_UNIT_FOREVER_REL);
+      }
+      GNUNET_free (t6);
     }
-  //return GNUNET_NO;
   return GNUNET_OK;
 }
 
@@ -636,14 +652,14 @@ static void mhd_write_mst_cb (void *cls,
   struct HTTP_PeerContext *pc = ps->peercontext;
   GNUNET_assert(ps != NULL);
   GNUNET_assert(pc != NULL);
-
+#if DEBUG_HTTP
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
              "Connection %X: Forwarding message to transport service, type %u and size %u from `%s' (`%s')\n",
              ps,
              ntohs(message->type),
               ntohs(message->size),
              GNUNET_i2s(&(ps->peercontext)->identity),http_plugin_address_to_string(NULL,ps->addr,ps->addrlen));
-
+#endif
   pc->plugin->env->receive (ps->peercontext->plugin->env->cls,
                            &pc->identity,
                            message, 1, ps,
@@ -773,10 +789,12 @@ mdh_access_cb (void *cls,
       response = MHD_create_response_from_data (strlen (HTTP_ERROR_RESPONSE),HTTP_ERROR_RESPONSE, MHD_NO, MHD_NO);
       res = MHD_queue_response (mhd_connection, MHD_HTTP_NOT_FOUND, response);
       MHD_destroy_response (response);
+#if DEBUG_CONNECTIONS
       if (res == MHD_YES)
         GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,"Peer has no valid ident, sent HTTP 1.1/404\n");
       else
         GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,"Peer has no valid ident, could not send error\n");
+#endif
       return res;
     }
   }
@@ -860,12 +878,13 @@ mdh_access_cb (void *cls,
     *httpSessionCache = ps;
     if (ps->msgtok==NULL)
       ps->msgtok = GNUNET_SERVER_mst_create (&mhd_write_mst_cb, ps);
-
+#if DEBUG_HTTP
     GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,"Connection %X: HTTP Daemon has new an incoming `%s' request from peer `%s' (`%s')\n",
                 ps,
                 method,
                 GNUNET_i2s(&pc->identity),
                 http_plugin_address_to_string(NULL, ps->addr, ps->addrlen));
+#endif
   }
 
   /* Is it a PUT or a GET request */
@@ -1103,9 +1122,6 @@ static size_t curl_get_header_cb( void *ptr, size_t size, size_t nmemb, void *st
       if (tmp[len-2] == 13)
         tmp[len-2]= '\0';
     }
-#if DEBUG_HTTP
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Header: `%s' %u \n",tmp, http_result);
-#endif
   }
   if (NULL != tmp)
     GNUNET_free (tmp);
@@ -1157,9 +1173,6 @@ static size_t curl_put_header_cb( void *ptr, size_t size, size_t nmemb, void *st
       if (tmp[len-2] == 13)
         tmp[len-2]= '\0';
     }
-#if DEBUG_HTTP
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Header: `%s' %u \n",tmp, http_result);
-#endif
   }
   if (NULL != tmp)
     GNUNET_free (tmp);
@@ -1243,14 +1256,14 @@ static void curl_receive_mst_cb  (void *cls,
   struct HTTP_PeerContext *pc = ps->peercontext;
   GNUNET_assert(ps != NULL);
   GNUNET_assert(pc != NULL);
-
+#if DEBUG_HTTP
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
               "Connection %X: Forwarding message to transport service, type %u and size %u from `%s' (`%s')\n",
               ps,
               ntohs(message->type),
               ntohs(message->size),
               GNUNET_i2s(&(pc->identity)),http_plugin_address_to_string(NULL,ps->addr,ps->addrlen));
-
+#endif
   pc->plugin->env->receive (pc->plugin->env->cls,
                             &pc->identity,
                             message, 1, ps,
@@ -1637,7 +1650,7 @@ static ssize_t send_check_connections (void *cls, struct Session *ps)
   return GNUNET_SYSERR;
 }
 
-static struct Session * send_get_session (void * cls, struct HTTP_PeerContext *pc, const void * addr, size_t addrlen, int force_address, struct Session * session)
+static struct Session * send_select_session (void * cls, struct HTTP_PeerContext *pc, const void * addr, size_t addrlen, int force_address, struct Session * session)
 {
        struct Session * tmp = NULL;
        int addr_given = GNUNET_NO;
@@ -1655,7 +1668,7 @@ static struct Session * send_get_session (void * cls, struct HTTP_PeerContext *p
                        /* connection can not be used, since it is disconnected */
                        if ((session->recv_force_disconnect==GNUNET_NO) && (session->send_force_disconnect==GNUNET_NO))
                        {
-#ifdef DEBUG_SESSION_SELECTION
+#if DEBUG_SESSION_SELECTION
                                  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,"Session %X selected: Using session passed by transport to send to forced address \n", session);
 #endif
                                return session;
@@ -1670,7 +1683,7 @@ static struct Session * send_get_session (void * cls, struct HTTP_PeerContext *p
                        /* connection can not be used, since it is disconnected */
                        if ((pc->last_session->recv_force_disconnect==GNUNET_NO) && (pc->last_session->send_force_disconnect==GNUNET_NO))
                        {
-#ifdef DEBUG_SESSION_SELECTION
+#if DEBUG_SESSION_SELECTION
                                  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,"Session %X selected: Using last session used to send to forced address \n", pc->last_session);
 #endif
                                return pc->last_session;
@@ -1687,7 +1700,7 @@ static struct Session * send_get_session (void * cls, struct HTTP_PeerContext *p
                        /* connection can not be used, since it is disconnected */
                        if ((tmp->recv_force_disconnect==GNUNET_NO) && (tmp->send_force_disconnect==GNUNET_NO))
                        {
-#ifdef DEBUG_SESSION_SELECTION
+#if DEBUG_SESSION_SELECTION
                                  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,"Session %X selected: Using existing session to send to forced address \n", session);
 #endif
                                  return session;
@@ -1707,7 +1720,7 @@ static struct Session * send_get_session (void * cls, struct HTTP_PeerContext *p
                        /* connection can not be used, since it is disconnected */
                        if ((session->recv_force_disconnect==GNUNET_NO) && (session->send_force_disconnect==GNUNET_NO))
                        {
-#ifdef DEBUG_SESSION_SELECTION
+#if DEBUG_SESSION_SELECTION
                                  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,"Session %X selected: Using session passed by transport to send not-forced address \n", session);
 #endif
                                  return session;
@@ -1720,7 +1733,7 @@ static struct Session * send_get_session (void * cls, struct HTTP_PeerContext *p
                        /* connection can not be used, since it is disconnected */
                        if ((pc->last_session->recv_force_disconnect==GNUNET_NO) && (pc->last_session->send_force_disconnect==GNUNET_NO))
                        {
-#ifdef DEBUG_SESSION_SELECTION
+#if DEBUG_SESSION_SELECTION
                                  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,"Session %X selected: Using last session to send to not-forced address \n", pc->last_session);
 #endif
                                return pc->last_session;
@@ -1733,7 +1746,7 @@ static struct Session * send_get_session (void * cls, struct HTTP_PeerContext *p
                        /* connection can not be used, since it is disconnected */
                        if ((tmp->recv_force_disconnect==GNUNET_NO) && (tmp->send_force_disconnect==GNUNET_NO))
                        {
-#ifdef DEBUG_SESSION_SELECTION
+#if DEBUG_SESSION_SELECTION
                                  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,"Session %X selected: Using existing session to send to not-forced address \n", tmp);
 #endif
                                return tmp;
@@ -1797,13 +1810,12 @@ http_plugin_send (void *cls,
 {
   struct Plugin *plugin = cls;
   struct HTTP_Message *msg;
-
   struct HTTP_PeerContext * pc;
   struct Session * ps = NULL;
-  //struct Session * ps_tmp = NULL;
 
   GNUNET_assert(cls !=NULL);
 
+#if DEBUG_HTTP
   char * force = GNUNET_malloc(40);
   if (force_address == GNUNET_YES)
     strcpy(force,"forced addr.");
@@ -1811,13 +1823,16 @@ http_plugin_send (void *cls,
     strcpy(force,"any addr.");
   if (force_address == GNUNET_SYSERR)
     strcpy(force,"reliable bi-direc. address addr.");
+
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,"Transport tells me to send %u bytes to `%s' using %s (%s) and session: %X\n",
                                       msgbuf_size,
                                       GNUNET_i2s(target),
                                       force,
                                       http_plugin_address_to_string(NULL, addr, addrlen),
                                       session);
+
   GNUNET_free(force);
+#endif
 
   pc = GNUNET_CONTAINER_multihashmap_get (plugin->peers, &target->hashPubKey);
   /* Peer unknown */
@@ -1831,7 +1846,7 @@ http_plugin_send (void *cls,
     GNUNET_CONTAINER_multihashmap_put(plugin->peers, &pc->identity.hashPubKey, pc, GNUNET_CONTAINER_MULTIHASHMAPOPTION_UNIQUE_ONLY);
   }
 
-  ps = send_get_session (plugin, pc, addr, addrlen, force_address, session);
+  ps = send_select_session (plugin, pc, addr, addrlen, force_address, session);
 
   /* session not existing, but address forced -> creating new session */
   if (ps==NULL)
@@ -1839,11 +1854,12 @@ http_plugin_send (void *cls,
     if ((addr!=NULL) && (addrlen!=0))
     {
       ps = GNUNET_malloc(sizeof (struct Session));
+#if DEBUG_SESSION_SELECTION
       if (force_address == GNUNET_YES)
         GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,"No existing connection & forced address: creating new session %X to peer %s\n", ps, GNUNET_i2s(target));
       if (force_address != GNUNET_YES)
         GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,"No existing connection: creating new session %X to peer %s\n", ps, GNUNET_i2s(target));
-
+#endif
       if ((addrlen!=0) && (addr!=NULL))
       {
       ps->addr = GNUNET_malloc(addrlen);
@@ -1872,7 +1888,9 @@ http_plugin_send (void *cls,
     }
     else
     {
+#if DEBUG_HTTP
       GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,"No existing session found & and no address given: no way to send this message to peer `%s'!\n", GNUNET_i2s(target));
+#endif
       return GNUNET_SYSERR;
     }
   }
@@ -2026,8 +2044,8 @@ http_plugin_address_pretty_printer (void *cls,
   res = GNUNET_asprintf(&ret,"http://%s:%u/",address,port);
   GNUNET_free (address);
   GNUNET_assert(res != 0);
-
   asc (asc_cls, ret);
+  GNUNET_free_non_null (ret);
 }
 
 
@@ -2190,8 +2208,10 @@ libgnunet_plugin_transport_http_done (void *cls)
   if (plugin->multi_handle!=NULL)
   {
          mret = curl_multi_cleanup(plugin->multi_handle);
+#if DEBUG_HTTP
          if ( CURLM_OK != mret)
                GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,"curl multihandle clean up failed\n");
+#endif
          plugin->multi_handle = NULL;
   }
   curl_global_cleanup();
@@ -2202,10 +2222,14 @@ libgnunet_plugin_transport_http_done (void *cls)
     plugin->http_curl_task = GNUNET_SCHEDULER_NO_TASK;
   }
 
-  GNUNET_free_non_null (plugin->bind_address);
+  GNUNET_free_non_null (plugin->bind4_address);
+  GNUNET_free_non_null (plugin->bind6_address);
+  GNUNET_free_non_null(plugin->bind_hostname);
   GNUNET_free (plugin);
   GNUNET_free (api);
+#if DEBUG_HTTP
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,"Unload http plugin complete...\n");
+#endif
   return NULL;
 }
 
@@ -2221,16 +2245,19 @@ libgnunet_plugin_transport_http_init (void *cls)
   struct GNUNET_TRANSPORT_PluginFunctions *api;
   struct GNUNET_TIME_Relative gn_timeout;
   long long unsigned int port;
-  char * hostname;
 
   GNUNET_assert(cls !=NULL);
+#if DEBUG_HTTP
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,"Starting http plugin...\n");
+#endif
 
   plugin = GNUNET_malloc (sizeof (struct Plugin));
   plugin->stats = env->stats;
   plugin->env = env;
   plugin->peers = NULL;
-  plugin->bind_address = GNUNET_malloc(sizeof(struct in_addr*));
+  plugin->bind4_address = NULL;
+  plugin->use_ipv6  = GNUNET_YES;
+  plugin->use_ipv4  = GNUNET_YES;
 
   api = GNUNET_malloc (sizeof (struct GNUNET_TRANSPORT_PluginFunctions));
   api->cls = plugin;
@@ -2243,6 +2270,22 @@ libgnunet_plugin_transport_http_init (void *cls)
   /* Hashing our identity to use it in URLs */
   GNUNET_CRYPTO_hash_to_enc ( &(plugin->env->my_identity->hashPubKey), &plugin->my_ascii_hash_ident);
 
+  /* Reading port number from config file */
+  if (GNUNET_CONFIGURATION_have_value (env->cfg,
+                                                                  "transport-http", "USE_IPv6"))
+    {
+         plugin->use_ipv6 = GNUNET_CONFIGURATION_get_value_yesno (env->cfg,
+                                                                                                          "transport-http",
+                                                                                                          "USE_IPv6");
+    }
+  /* Reading port number from config file */
+  if (GNUNET_CONFIGURATION_have_value (env->cfg,
+                                                                  "transport-http", "USE_IPv4"))
+    {
+         plugin->use_ipv4 = GNUNET_CONFIGURATION_get_value_yesno (env->cfg,
+                                                                                                          "transport-http",
+                                                                                                          "USE_IPv4");
+    }
   /* Reading port number from config file */
   if ((GNUNET_OK !=
        GNUNET_CONFIGURATION_get_value_number (env->cfg,
@@ -2253,78 +2296,135 @@ libgnunet_plugin_transport_http_init (void *cls)
     {
       GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR,
                        "http",
-                       _
-                       ("Require valid port number for transport plugin `%s' in configuration!\n"),
+                       _("Require valid port number for transport plugin `%s' in configuration!\n"),
                        "transport-http");
       libgnunet_plugin_transport_http_done (api);
       return NULL;
     }
 
-  /* Reading port number from config file */
-  if (GNUNET_CONFIGURATION_have_value (env->cfg,
-                                                                  "transport-http", "BINDTO"))
-    {
-      GNUNET_break (GNUNET_OK ==
-                    GNUNET_CONFIGURATION_get_value_string (env->cfg,
-                                                                                          "transport-http",
-                                                           "BINDTO",
-                                                           &hostname));
-      if (inet_aton(hostname, plugin->bind_address)==0)
-      {
-         GNUNET_log (GNUNET_ERROR_TYPE_ERROR,"Misconfigured address to bind to in configuration\n");
-         GNUNET_free(plugin->bind_address);
-         plugin->bind_address = NULL;
-      }
-    }
+  /* Reading ipv4 addresse to bind to from config file */
+  if ((plugin->use_ipv4==GNUNET_YES) && (GNUNET_CONFIGURATION_have_value (env->cfg,
+                                                                  "transport-http", "BINDTO4")))
+  {
+         GNUNET_break (GNUNET_OK ==
+                                       GNUNET_CONFIGURATION_get_value_string (env->cfg,
+                                                                                                                  "transport-http",
+                                                                                                                  "BINDTO4",
+                                                                                                                  &plugin->bind_hostname));
+         plugin->bind4_address = GNUNET_malloc(sizeof(struct sockaddr_in));
+         plugin->bind4_address->sin_family = AF_INET;
+         plugin->bind4_address->sin_port = htons (port);
+
+         if (inet_pton(AF_INET,plugin->bind_hostname, &plugin->bind4_address->sin_addr)<=0)
+         {
+                 GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR,
+                                                  "http",
+                                                  _("Misconfigured address to bind to in configuration!\n"),
+                                                  "transport-http");
+                 GNUNET_free(plugin->bind4_address);
+                 GNUNET_free(plugin->bind_hostname);
+                 plugin->bind_hostname = NULL;
+                 plugin->bind4_address = NULL;
+         }
+  }
+
+  /* Reading ipv4 addresse to bind to from config file */
+  if ((plugin->use_ipv6==GNUNET_YES) && (GNUNET_CONFIGURATION_have_value (env->cfg,
+                                                                  "transport-http", "BINDTO6")))
+  {
+         GNUNET_break (GNUNET_OK ==
+                                       GNUNET_CONFIGURATION_get_value_string (env->cfg,
+                                                                                                                  "transport-http",
+                                                                                                                  "BINDTO6",
+                                                                                                                  &plugin->bind_hostname));
+
+         plugin->bind6_address = GNUNET_malloc(sizeof(struct sockaddr_in6));
+         plugin->bind6_address->sin6_family = AF_INET6;
+         plugin->bind6_address->sin6_port = htons (port);
+
+      if (inet_pton(AF_INET6,plugin->bind_hostname, &plugin->bind6_address->sin6_addr)<=0)
+         {
+                 GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR,
+                                                  "http",
+                                                  _("Misconfigured address to bind to in configuration!\n"),
+                                                  "transport-http");
+                 GNUNET_free(plugin->bind6_address);
+                 GNUNET_free(plugin->bind_hostname);
+                 plugin->bind_hostname = NULL;
+                 plugin->bind6_address = NULL;
+         }
+  }
+
   GNUNET_assert ((port > 0) && (port <= 65535));
   plugin->port_inbound = port;
   gn_timeout = GNUNET_CONSTANTS_IDLE_CONNECTION_TIMEOUT;
   unsigned int timeout = (gn_timeout.value) / 1000;
-  if ((plugin->http_server_daemon_v4 == NULL) && (plugin->http_server_daemon_v6 == NULL) && (port != 0))
-    {
+  if ((plugin->http_server_daemon_v6 == NULL) && (plugin->use_ipv6 == GNUNET_YES) && (port != 0))
+  {
+       struct sockaddr * tmp = (struct sockaddr *) plugin->bind6_address;
     plugin->http_server_daemon_v6 = MHD_start_daemon (
-#if DEBUG_HTTP
+#if DEBUG_CONNECTIONS
                                                                   MHD_USE_DEBUG |
 #endif
                                                                   MHD_USE_IPv6,
                                        port,
                                        &mhd_accept_cb,
                                        plugin , &mdh_access_cb, plugin,
+                                       MHD_OPTION_SOCK_ADDR, tmp,
                                        MHD_OPTION_CONNECTION_LIMIT, (unsigned int) 32,
                                        MHD_OPTION_PER_IP_CONNECTION_LIMIT, (unsigned int) 6,
                                        MHD_OPTION_CONNECTION_TIMEOUT, (unsigned int) timeout,
                                        MHD_OPTION_CONNECTION_MEMORY_LIMIT, (size_t) (16 * 1024),
                                        MHD_OPTION_NOTIFY_COMPLETED, &mhd_termination_cb, NULL,
                                        MHD_OPTION_END);
-
-    plugin->http_server_daemon_v4 = MHD_start_daemon (
-#if DEBUG_HTTP
+  }
+  if ((plugin->http_server_daemon_v4 == NULL) && (plugin->use_ipv4 == GNUNET_YES) && (port != 0))
+  {
+  plugin->http_server_daemon_v4 = MHD_start_daemon (
+#if DEBUG_CONNECTIONS
                                                                   MHD_USE_DEBUG |
 #endif
                                                                   MHD_NO_FLAG,
                                        port,
                                        &mhd_accept_cb,
                                        plugin , &mdh_access_cb, plugin,
-                                       //MHD_OPTION_SOCK_ADDR, (struct sockaddr *) &in4,
+                                       MHD_OPTION_SOCK_ADDR, (struct sockaddr_in *)plugin->bind4_address,
                                        MHD_OPTION_CONNECTION_LIMIT, (unsigned int) 32,
                                        MHD_OPTION_PER_IP_CONNECTION_LIMIT, (unsigned int) 6,
                                        MHD_OPTION_CONNECTION_TIMEOUT, (unsigned int) timeout,
                                        MHD_OPTION_CONNECTION_MEMORY_LIMIT, (size_t) (16 * 1024),
                                        MHD_OPTION_NOTIFY_COMPLETED, &mhd_termination_cb, NULL,
                                        MHD_OPTION_END);
-    }
+  }
   if (plugin->http_server_daemon_v4 != NULL)
     plugin->http_server_task_v4 = http_server_daemon_prepare (plugin, plugin->http_server_daemon_v4);
   if (plugin->http_server_daemon_v6 != NULL)
     plugin->http_server_task_v6 = http_server_daemon_prepare (plugin, plugin->http_server_daemon_v6);
 
+
   if (plugin->http_server_task_v4 != GNUNET_SCHEDULER_NO_TASK)
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,"Starting MHD with IPv4 on port %u\n",port);
-  else if (plugin->http_server_task_v6 != GNUNET_SCHEDULER_NO_TASK)
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,"Starting MHD with IPv4 and IPv6 on port %u\n",port);
+  {
+#if DEBUG_HTTP
+         GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,"Starting MHD with IPv4 bound to %s with port %u\n",(plugin->bind_hostname!=NULL) ? plugin->bind_hostname : "every address",port);
+#endif
+  }
+  else if ((plugin->http_server_task_v6 != GNUNET_SCHEDULER_NO_TASK) && (plugin->http_server_task_v4 != GNUNET_SCHEDULER_NO_TASK))
+  {
+#if DEBUG_HTTP
+    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,"Starting MHD with IPv6 bound to %s with port %u\n",(plugin->bind_hostname!=NULL) ? plugin->bind_hostname : "every address", port);
+#endif
+  }
+  else if ((plugin->http_server_task_v6 != GNUNET_SCHEDULER_NO_TASK) && (plugin->http_server_task_v4 == GNUNET_SCHEDULER_NO_TASK))
+  {
+#if DEBUG_HTTP
+    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,"Starting MHD with IPv4 and IPv6 bound to %s with port %u\n",(plugin->bind_hostname!=NULL) ? plugin->bind_hostname : "every address", port);
+#endif
+  }
   else
   {
+#if DEBUG_HTTP
     GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,"No MHD was started, transport plugin not functional!\n");
+#endif
     libgnunet_plugin_transport_http_done (api);
     return NULL;
   }
@@ -2336,9 +2436,9 @@ libgnunet_plugin_transport_http_init (void *cls)
   if ( NULL == plugin->multi_handle )
   {
     GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR,
-                     "http",
-                     _("Could not initialize curl multi handle, failed to start http plugin!\n"),
-                     "transport-http");
+                                  "http",
+                                  _("Could not initialize curl multi handle, failed to start http plugin!\n"),
+                                  "transport-http");
     libgnunet_plugin_transport_http_done (api);
     return NULL;
   }