- use proper signedness
[oweals/gnunet.git] / src / transport / gnunet-transport.c
index 312859695cded03a414c8d01bdb6ab4244ec03d2..bb856bd6fc95804e59773914180562486f7b83e6 100644 (file)
  * How long do we wait for the NAT test to report success?
  * Should match NAT_SERVER_TIMEOUT in 'nat_test.c'.
  */
-#define TIMEOUT GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_SECONDS, 30)
-#define RESOLUTION_TIMEOUT GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_SECONDS, 10)
+#define TIMEOUT GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_SECONDS, 60)
+#define RESOLUTION_TIMEOUT GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_SECONDS, 30)
+#define OP_TIMEOUT GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_SECONDS, 30)
+
+/**
+ * Benchmarking block size in KB
+ */
+#define BLOCKSIZE 4
+
 
 /**
  * Which peer should we connect to?
@@ -52,6 +59,16 @@ static char *cpid;
  */
 static struct GNUNET_TRANSPORT_Handle *handle;
 
+/**
+ * Configuration handle
+ */
+static struct GNUNET_CONFIGURATION_Handle *cfg;
+
+/**
+ * Try_connect handle
+ */
+struct GNUNET_TRANSPORT_TryConnectHandle * tc_handle;
+
 /**
  * Option -s.
  */
@@ -143,7 +160,10 @@ static struct GNUNET_PeerIdentity pid;
  */
 static GNUNET_SCHEDULER_TaskIdentifier end;
 
-static struct GNUNET_CONTAINER_MultiHashMap *peers;
+/**
+ * Task for operation timeout
+ */
+static GNUNET_SCHEDULER_TaskIdentifier op_timeout;
 
 /**
  * Selected level of verbosity.
@@ -205,6 +225,18 @@ static void
 shutdown_task (void *cls,
                const struct GNUNET_SCHEDULER_TaskContext *tc)
 {
+  struct GNUNET_TIME_Relative duration;
+  end = GNUNET_SCHEDULER_NO_TASK;
+  if (GNUNET_SCHEDULER_NO_TASK != op_timeout)
+  {
+      GNUNET_SCHEDULER_cancel (op_timeout);
+      op_timeout = GNUNET_SCHEDULER_NO_TASK;
+  }
+  if (NULL != tc_handle)
+  {
+      GNUNET_TRANSPORT_try_connect_cancel (tc_handle);
+      tc_handle = NULL;
+  }
   if (NULL != pic)
   {
       GNUNET_TRANSPORT_peer_get_active_addresses_cancel (pic);
@@ -220,18 +252,86 @@ shutdown_task (void *cls,
     GNUNET_TRANSPORT_disconnect(handle);
     handle = NULL;
   }
-  if (NULL != peers)
+  if (benchmark_send)
+  {
+    duration = GNUNET_TIME_absolute_get_duration (start_time);
+    FPRINTF (stdout, _("Transmitted %llu bytes/s (%llu bytes in %s)\n"),
+             1000LL * 1000LL * traffic_sent / (1 + duration.rel_value_us), traffic_sent,
+             GNUNET_STRINGS_relative_time_to_string (duration, GNUNET_YES));
+  }
+  if (benchmark_receive)
   {
-    GNUNET_CONTAINER_multihashmap_destroy (peers);
-    peers = NULL;
+    duration = GNUNET_TIME_absolute_get_duration (start_time);
+    FPRINTF (stdout, _("Received %llu bytes/s (%llu bytes in %s)\n"),
+             1000LL * 1000LL * traffic_received / (1 + duration.rel_value_us),
+             traffic_received,
+             GNUNET_STRINGS_relative_time_to_string (duration, GNUNET_YES));
+  }
+}
+
+
+static struct ResolutionContext *rc_head;
+static struct ResolutionContext *rc_tail;
+
+struct ResolutionContext
+{
+  struct ResolutionContext *next;
+  struct ResolutionContext *prev;
+  struct GNUNET_HELLO_Address *addrcp;
+  struct GNUNET_TRANSPORT_AddressToStringContext *asc;
+  int printed;
+};
+
+
+static void
+operation_timeout (void *cls,
+                   const struct GNUNET_SCHEDULER_TaskContext *tc)
+{
+  struct ResolutionContext *cur;
+  struct ResolutionContext *next;
+  op_timeout = GNUNET_SCHEDULER_NO_TASK;
+  if ((try_connect) || (benchmark_send) ||
+               (benchmark_receive))
+  {
+      FPRINTF (stdout, _("Failed to connect to `%s'\n"), GNUNET_i2s_full (&pid));
+      if (GNUNET_SCHEDULER_NO_TASK != end)
+        GNUNET_SCHEDULER_cancel (end);
+      end = GNUNET_SCHEDULER_add_now (&shutdown_task, NULL);
+      ret = 1;
+      return;
+  }
+  if (iterate_connections)
+  {
+               next = rc_head;
+               while (NULL != (cur = next))
+               {
+                               next = cur->next;
+                               FPRINTF (stdout, _("Failed to resolve address for peer `%s'\n"),
+                                               GNUNET_i2s (&cur->addrcp->peer));
+
+                               GNUNET_CONTAINER_DLL_remove (rc_head, rc_tail, cur);
+                               GNUNET_TRANSPORT_address_to_string_cancel (cur->asc);
+                               GNUNET_free (cur->addrcp);
+                               GNUNET_free (cur);
+
+               }
+               FPRINTF (stdout, "%s", _("Failed to list connections, timeout occured\n"));
+      if (GNUNET_SCHEDULER_NO_TASK != end)
+        GNUNET_SCHEDULER_cancel (end);
+      end = GNUNET_SCHEDULER_add_now (&shutdown_task, NULL);
+      ret = 1;
+      return;
   }
+
 }
 
+
+
 /**
  * Display the result of the test.
  *
  * @param tc test context
- * @param result GNUNET_YES on success
+ * @param result #GNUNET_YES on success
  */
 static void
 display_test_result (struct TestContext *tc, int result)
@@ -258,7 +358,7 @@ display_test_result (struct TestContext *tc, int result)
   resolver_users--;
   if ((0 == resolver_users) && (NULL != resolver))
   {
-    GNUNET_break (0 == GNUNET_OS_process_kill (resolver, SIGTERM));
+    GNUNET_break (0 == GNUNET_OS_process_kill (resolver, GNUNET_TERM_SIG));
     GNUNET_OS_process_destroy (resolver);
     resolver = NULL;
   }
@@ -270,7 +370,7 @@ display_test_result (struct TestContext *tc, int result)
  * Clean up and update GUI (with success).
  *
  * @param cls test context
- * @param success currently always GNUNET_OK
+ * @param success currently always #GNUNET_OK
  */
 static void
 result_callback (void *cls, int success)
@@ -311,6 +411,7 @@ do_test_configuration (const struct GNUNET_CONFIGURATION_Handle *cfg)
   unsigned long long bnd_port;
   unsigned long long adv_port;
   struct TestContext *tc;
+  char *binary;
 
   if (GNUNET_OK !=
       GNUNET_CONFIGURATION_get_value_string (cfg, "transport", "plugins",
@@ -340,12 +441,17 @@ do_test_configuration (const struct GNUNET_CONFIGURATION_Handle *cfg)
                                                &adv_port))
       adv_port = bnd_port;
     if (NULL == resolver)
+    {
+      binary = GNUNET_OS_get_libexec_binary_path ("gnunet-service-resolver");
       resolver =
-         GNUNET_OS_start_process (GNUNET_YES, GNUNET_OS_INHERIT_STD_OUT_AND_ERR, NULL, NULL, "gnunet-service-resolver",
+         GNUNET_OS_start_process (GNUNET_YES, GNUNET_OS_INHERIT_STD_OUT_AND_ERR, NULL, NULL,
+                                   binary,
                                    "gnunet-service-resolver", NULL);
+      GNUNET_free (binary);
+    }
     resolver_users++;
     GNUNET_RESOLVER_connect (cfg);
-    tc = GNUNET_malloc (sizeof (struct TestContext));
+    tc = GNUNET_new (struct TestContext);
     tc->name = GNUNET_strdup (tok);
     tc->tst =
         GNUNET_NAT_test_start (cfg,
@@ -365,55 +471,23 @@ do_test_configuration (const struct GNUNET_CONFIGURATION_Handle *cfg)
 }
 
 
-/**
- * Shutdown, print statistics.
- */
-static void
-do_disconnect (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
-{
-  struct GNUNET_TIME_Relative duration;
-
-  if (NULL != th)
-  {
-    GNUNET_TRANSPORT_notify_transmit_ready_cancel (th);
-    th = NULL;
-  }
-  GNUNET_TRANSPORT_disconnect (handle);
-  if (benchmark_receive)
-  {
-    duration = GNUNET_TIME_absolute_get_duration (start_time);
-    FPRINTF (stdout, _("Received %llu bytes/s (%llu bytes in %s)\n"),
-             1000 * traffic_received / (1 + duration.rel_value),
-             traffic_received,
-            GNUNET_STRINGS_relative_time_to_string (duration, GNUNET_YES));
-  }
-  if (benchmark_send)
-  {
-    duration = GNUNET_TIME_absolute_get_duration (start_time);
-    FPRINTF (stdout, _("Transmitted %llu bytes/s (%llu bytes in %s)\n"),
-             1000 * traffic_sent / (1 + duration.rel_value), traffic_sent,
-             GNUNET_STRINGS_relative_time_to_string (duration, GNUNET_YES));
-  }
-}
-
-
 /**
  * Function called to notify a client about the socket
- * begin ready to queue more data.  "buf" will be
- * NULL and "size" zero if the socket was closed for
+ * begin ready to queue more data.  @a buf will be
+ * NULL and @a size zero if the socket was closed for
  * writing in the meantime.
  *
  * @param cls closure
- * @param size number of bytes available in buf
+ * @param size number of bytes available in @a buf
  * @param buf where the callee should write the message
- * @return number of bytes written to buf
+ * @return number of bytes written to @a buf
  */
 static size_t
 transmit_data (void *cls, size_t size, void *buf)
 {
   struct GNUNET_MessageHeader *m = buf;
 
-  if ((NULL == buf) && (0 == size))
+  if ((NULL == buf) || (0 == size))
   {
     th = NULL;
     return 0;
@@ -425,7 +499,7 @@ transmit_data (void *cls, size_t size, void *buf)
   m->type = ntohs (GNUNET_MESSAGE_TYPE_DUMMY);
   memset (&m[1], 52, size - sizeof (struct GNUNET_MessageHeader));
   traffic_sent += size;
-  th = GNUNET_TRANSPORT_notify_transmit_ready (handle, &pid, 32 * 1024, 0,
+  th = GNUNET_TRANSPORT_notify_transmit_ready (handle, &pid, BLOCKSIZE * 1024, 0,
                                                GNUNET_TIME_UNIT_FOREVER_REL,
                                                &transmit_data, NULL);
   if (verbosity > 0)
@@ -441,39 +515,51 @@ transmit_data (void *cls, size_t size, void *buf)
  *
  * @param cls closure
  * @param peer the peer that connected
- * @param ats performance data
- * @param ats_count number of entries in ats (excluding 0-termination)
  */
 static void
-notify_connect (void *cls, const struct GNUNET_PeerIdentity *peer,
-                const struct GNUNET_ATS_Information *ats, uint32_t ats_count)
+notify_connect (void *cls, const struct GNUNET_PeerIdentity *peer)
 {
-  if (verbosity > 0)
-    FPRINTF (stdout, _("Connected to %s\n"), GNUNET_i2s (peer));
   if (0 != memcmp (&pid, peer, sizeof (struct GNUNET_PeerIdentity)))
     return;
   ret = 0;
   if (try_connect)
   {
       /* all done, terminate instantly */
-      if (verbosity > 0)
-        FPRINTF (stdout, _("Successfully connected to %s\n"), GNUNET_i2s (peer));
-      GNUNET_SCHEDULER_cancel (end);
-      end = GNUNET_SCHEDULER_add_now (&do_disconnect, NULL);
+      FPRINTF (stdout,
+              _("Successfully connected to `%s'\n"),
+              GNUNET_i2s_full (peer));
+      ret = 0;
+
+      if (GNUNET_SCHEDULER_NO_TASK != op_timeout)
+      {
+        GNUNET_SCHEDULER_cancel (op_timeout);
+        op_timeout = GNUNET_SCHEDULER_NO_TASK;
+      }
+
+      if (GNUNET_SCHEDULER_NO_TASK != end)
+        GNUNET_SCHEDULER_cancel (end);
+      end = GNUNET_SCHEDULER_add_now (&shutdown_task, NULL);
+      return;
   }
-  else if (benchmark_send)
+  if (benchmark_send)
   {
+    if (GNUNET_SCHEDULER_NO_TASK != op_timeout)
+    {
+      GNUNET_SCHEDULER_cancel (op_timeout);
+      op_timeout = GNUNET_SCHEDULER_NO_TASK;
+    }
+    if (verbosity > 0)
+      FPRINTF (stdout, _("Successfully connected to `%s', starting to send benchmark data in %u Kb blocks\n"),
+          GNUNET_i2s (&pid), BLOCKSIZE);
     start_time = GNUNET_TIME_absolute_get ();
     if (NULL == th)
-      th = GNUNET_TRANSPORT_notify_transmit_ready (handle, peer, 32 * 1024, 0,
-                                                 GNUNET_TIME_UNIT_FOREVER_REL,
-                                                 &transmit_data, NULL);
-  }
-  else
-  {
-    /* all done, terminate instantly */
-    GNUNET_SCHEDULER_cancel (end);
-    end = GNUNET_SCHEDULER_add_now (&do_disconnect, NULL);
+      th = GNUNET_TRANSPORT_notify_transmit_ready (handle, peer,
+                                                   BLOCKSIZE * 1024, 0,
+                                                   GNUNET_TIME_UNIT_FOREVER_REL,
+                                                   &transmit_data, NULL);
+    else
+      GNUNET_break (0);
+    return;
   }
 }
 
@@ -488,14 +574,21 @@ notify_connect (void *cls, const struct GNUNET_PeerIdentity *peer,
 static void
 notify_disconnect (void *cls, const struct GNUNET_PeerIdentity *peer)
 {
-  if (verbosity > 0)
-    FPRINTF (stdout, _("Disconnected from %s\n"), GNUNET_i2s (peer));
+  if (0 != memcmp (&pid, peer, sizeof (struct GNUNET_PeerIdentity)))
+    return;
+
   if (NULL != th)
   {
     GNUNET_TRANSPORT_notify_transmit_ready_cancel (th);
     th = NULL;
   }
-
+  if (benchmark_send)
+  {
+      FPRINTF (stdout, _("Disconnected from peer `%s' while benchmarking\n"), GNUNET_i2s (&pid));
+      if (GNUNET_SCHEDULER_NO_TASK != end)
+        GNUNET_SCHEDULER_cancel (end);
+      return;
+  }
 }
 
 /**
@@ -504,18 +597,16 @@ notify_disconnect (void *cls, const struct GNUNET_PeerIdentity *peer)
  *
  * @param cls closure
  * @param peer the peer that connected
- * @param ats performance data
- * @param ats_count number of entries in ats (excluding 0-termination)
  */
 static void
-monitor_notify_connect (void *cls, const struct GNUNET_PeerIdentity *peer,
-                const struct GNUNET_ATS_Information *ats, uint32_t ats_count)
+monitor_notify_connect (void *cls, const struct GNUNET_PeerIdentity *peer)
 {
   monitor_connect_counter ++;
   struct GNUNET_TIME_Absolute now = GNUNET_TIME_absolute_get();
   const char *now_str = GNUNET_STRINGS_absolute_time_to_string (now);
 
-  FPRINTF (stdout, _("%24s: %-17s %4s   (%u connections in total)\n"),
+  FPRINTF (stdout,
+           _("%24s: %-17s %4s   (%u connections in total)\n"),
            now_str,
            _("Connected to"),
            GNUNET_i2s (peer),
@@ -539,7 +630,8 @@ monitor_notify_disconnect (void *cls, const struct GNUNET_PeerIdentity *peer)
   GNUNET_assert (monitor_connect_counter > 0);
   monitor_connect_counter --;
 
-  FPRINTF (stdout, _("%24s: %-17s %4s   (%u connections in total)\n"),
+  FPRINTF (stdout,
+           _("%24s: %-17s %4s   (%u connections in total)\n"),
            now_str,
            _("Disconnected from"),
            GNUNET_i2s (peer),
@@ -554,32 +646,31 @@ monitor_notify_disconnect (void *cls, const struct GNUNET_PeerIdentity *peer)
  * @param cls closure
  * @param peer (claimed) identity of the other peer
  * @param message the message
- * @param ats performance data
- * @param ats_count number of entries in ats
  */
 static void
 notify_receive (void *cls, const struct GNUNET_PeerIdentity *peer,
-                const struct GNUNET_MessageHeader *message,
-                const struct GNUNET_ATS_Information *ats, uint32_t ats_count)
+                const struct GNUNET_MessageHeader *message)
 {
-  if (!benchmark_receive)
-    return;
-  if (GNUNET_MESSAGE_TYPE_DUMMY != ntohs (message->type))
+  if (benchmark_receive)
+  {
+    if (GNUNET_MESSAGE_TYPE_DUMMY != ntohs (message->type))
+      return;
+    if (verbosity > 0)
+      FPRINTF (stdout,
+               _("Received %u bytes from %s\n"),
+               (unsigned int) ntohs (message->size), GNUNET_i2s (peer));
+
+    if (traffic_received == 0)
+      start_time = GNUNET_TIME_absolute_get ();
+    traffic_received += ntohs (message->size);
     return;
-  if (verbosity > 0)
-    FPRINTF (stdout, _("Received %u bytes from %s\n"),
-             (unsigned int) ntohs (message->size), GNUNET_i2s (peer));
-  if (traffic_received == 0)
-    start_time = GNUNET_TIME_absolute_get ();
-  traffic_received += ntohs (message->size);
+  }
 }
 
-struct ResolutionContext
-{
-  struct GNUNET_HELLO_Address *addrcp;
 
-  int printed;
-};
+static void
+resolve_address (const struct GNUNET_HELLO_Address *address,
+                 int numeric);
 
 
 static void
@@ -590,7 +681,11 @@ process_string (void *cls, const char *address)
 
   if (address != NULL)
   {
-    FPRINTF (stdout, _("Peer `%s': %s %s\n"), GNUNET_i2s (&addrcp->peer), addrcp->transport_name, address);
+    FPRINTF (stdout,
+             _("Peer `%s': %s %s\n"),
+             GNUNET_i2s (&addrcp->peer),
+             addrcp->transport_name,
+             address);
     rc->printed = GNUNET_YES;
   }
   else
@@ -599,18 +694,58 @@ process_string (void *cls, const char *address)
     GNUNET_assert (address_resolutions > 0);
     address_resolutions --;
     if (GNUNET_NO == rc->printed)
-      FPRINTF (stdout, _("Peer `%s': %s <unable to resolve address>\n"), GNUNET_i2s (&addrcp->peer), addrcp->transport_name);
+    {
+      if (numeric == GNUNET_NO)
+      {
+        resolve_address (rc->addrcp, GNUNET_YES ); /* Failed to resolve address, try numeric lookup */
+      }
+      else
+       FPRINTF (stdout,
+                 _("Peer `%s': %s <unable to resolve address>\n"),
+                 GNUNET_i2s (&addrcp->peer),
+                 addrcp->transport_name);
+    }
     GNUNET_free (rc->addrcp);
+    GNUNET_CONTAINER_DLL_remove (rc_head, rc_tail, rc);
     GNUNET_free (rc);
-    if (0 == address_resolutions)
+    if ((0 == address_resolutions) && (iterate_connections))
     {
         if (GNUNET_SCHEDULER_NO_TASK != end)
+        {
           GNUNET_SCHEDULER_cancel (end);
+          end = GNUNET_SCHEDULER_NO_TASK;
+        }
+        if (GNUNET_SCHEDULER_NO_TASK != op_timeout)
+        {
+               GNUNET_SCHEDULER_cancel (op_timeout);
+               op_timeout = GNUNET_SCHEDULER_NO_TASK;
+        }
+        ret = 0;
         end = GNUNET_SCHEDULER_add_now (&shutdown_task, NULL);
     }
   }
 }
 
+
+static void
+resolve_address (const struct GNUNET_HELLO_Address *address,
+                 int numeric)
+{
+  struct ResolutionContext *rc;
+
+  rc = GNUNET_new (struct ResolutionContext);
+  GNUNET_assert (NULL != rc);
+  GNUNET_CONTAINER_DLL_insert (rc_head, rc_tail, rc);
+  address_resolutions ++;
+
+  rc->addrcp = GNUNET_HELLO_address_copy(address);
+  rc->printed = GNUNET_NO;
+  /* Resolve address to string */
+  rc->asc = GNUNET_TRANSPORT_address_to_string (cfg, address, numeric,
+                                      RESOLUTION_TIMEOUT, &process_string,
+                                      rc);
+}
+
 /**
  * Function to call with a binary address
  *
@@ -622,14 +757,14 @@ static void
 process_address (void *cls, const struct GNUNET_PeerIdentity *peer,
                  const struct GNUNET_HELLO_Address *address)
 {
-  const struct GNUNET_CONFIGURATION_Handle *cfg = cls;
-  struct ResolutionContext *rc;
-
   if (peer == NULL)
   {
     /* done */
     address_resolution_in_progress = GNUNET_NO;
     pic = NULL;
+    if (GNUNET_SCHEDULER_NO_TASK != end)
+      GNUNET_SCHEDULER_cancel (end);
+    end = GNUNET_SCHEDULER_add_now (&shutdown_task, NULL);
     return;
   }
   if (address == NULL)
@@ -638,38 +773,70 @@ process_address (void *cls, const struct GNUNET_PeerIdentity *peer,
     return;
   }
 
-  rc = GNUNET_malloc(sizeof (struct ResolutionContext));
-  rc->addrcp = GNUNET_HELLO_address_copy(address);
-  rc->printed = GNUNET_NO;
+  if (GNUNET_SCHEDULER_NO_TASK != op_timeout)
+       GNUNET_SCHEDULER_cancel (op_timeout);
+  op_timeout = GNUNET_SCHEDULER_add_delayed (OP_TIMEOUT,
+                                             &operation_timeout, NULL);
 
-  GNUNET_assert (NULL != rc);
-  address_resolutions ++;
-  /* Resolve address to string */
-  GNUNET_TRANSPORT_address_to_string (cfg, address, numeric,
-                                      RESOLUTION_TIMEOUT, &process_string,
-                                      rc);
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Received address for peer `%s': %s\n",
+               GNUNET_i2s (peer), address->transport_name);
+  resolve_address (address, numeric);
+}
+
+
+static void
+try_connect_cb (void *cls,
+                const int result)
+{
+  static int retries = 0;
+  if (GNUNET_OK == result)
+  {
+      tc_handle = NULL;
+      return;
+  }
+  retries ++;
+  if (retries < 10)
+    tc_handle = GNUNET_TRANSPORT_try_connect (handle, &pid, try_connect_cb, NULL);
+  else
+  {
+    FPRINTF (stderr, "%s", _("Failed to send connect request to transport service\n"));
+    if (GNUNET_SCHEDULER_NO_TASK != end)
+      GNUNET_SCHEDULER_cancel (end);
+    ret = 1;
+    end = GNUNET_SCHEDULER_add_now (&shutdown_task, NULL);
+    return;
+  }
 }
 
 
+/**
+ * Function called with the result of the check if the 'transport'
+ * service is running.
+ *
+ * @param cls closure with our configuration
+ * @param result #GNUNET_YES if transport is running
+ */
 static void
 testservice_task (void *cls,
-                  const struct GNUNET_SCHEDULER_TaskContext *tc)
+                  int result)
 {
-  struct GNUNET_CONFIGURATION_Handle *cfg = cls;
   int counter = 0;
-  int try_connect = 0;
-
+  ret = 1;
 
-  if (0 != (tc->reason & GNUNET_SCHEDULER_REASON_TIMEOUT))
+  if (GNUNET_YES != result)
   {
-      FPRINTF (stderr, _("Service `%s' is not running\n"), "transport");
-      return;
+    FPRINTF (stderr,
+            _("Service `%s' is not running\n"), "transport");
+    return;
   }
 
-  if ((NULL != cpid) && (GNUNET_OK != GNUNET_CRYPTO_hash_from_string (cpid, &pid.hashPubKey)))
+  if ( (NULL != cpid) &&
+       (GNUNET_OK != GNUNET_CRYPTO_eddsa_public_key_from_string (cpid,
+                                                                   strlen (cpid),
+                                                                   &pid.public_key)))
   {
-      FPRINTF (stderr, _("Failed to parse peer identity `%s'\n"), cpid);
-      return;
+    FPRINTF (stderr, _("Failed to parse peer identity `%s'\n"), cpid);
+    return;
   }
 
   counter = benchmark_send + benchmark_receive + iterate_connections +
@@ -677,27 +844,27 @@ testservice_task (void *cls,
 
   if (1 < counter)
   {
-    FPRINTF (stderr, _("Multiple operations given. Please choose only one operation: %s, %s, %s, %s, %s, %s\n"),
+    FPRINTF (stderr,
+             _("Multiple operations given. Please choose only one operation: %s, %s, %s, %s, %s, %s\n"),
              "connect", "benchmark send", "benchmark receive", "information", "monitor", "events");
     return;
   }
   if (0 == counter)
   {
-    FPRINTF (stderr, _("No operation given. Please choose one operation: %s, %s, %s, %s, %s, %s\n"),
+    FPRINTF (stderr,
+             _("No operation given. Please choose one operation: %s, %s, %s, %s, %s, %s\n"),
              "connect", "benchmark send", "benchmark receive", "information", "monitor", "events");
     return;
   }
 
-  end = GNUNET_SCHEDULER_add_delayed (GNUNET_TIME_UNIT_FOREVER_REL,
-                                      &shutdown_task,
-                                      NULL);
-
-  if (try_connect)
+  if (try_connect) /* -C: Connect to peer */
   {
     if (NULL == cpid)
     {
-      FPRINTF (stderr, _("Option `%s' makes no sense without option `%s'.\n"),
+      FPRINTF (stderr,
+               _("Option `%s' makes no sense without option `%s'.\n"),
                "-C", "-p");
+      ret = 1;
       return;
     }
     handle = GNUNET_TRANSPORT_connect (cfg, NULL, NULL,
@@ -706,69 +873,87 @@ testservice_task (void *cls,
                                        &notify_disconnect);
     if (NULL == handle)
     {
-        FPRINTF (stderr, _("Failed to connect to transport service\n"));
+        FPRINTF (stderr,
+                 "%s",
+                 _("Failed to connect to transport service\n"));
+        ret = 1;
         return;
     }
-
-    GNUNET_TRANSPORT_try_connect (handle, &pid);
+    tc_handle = GNUNET_TRANSPORT_try_connect (handle, &pid, try_connect_cb, NULL);
+    if (NULL == tc_handle)
+    {
+      FPRINTF (stderr,
+               "%s",
+               _("Failed to send request to transport service\n"));
+      ret = 1;
+      return;
+    }
+    op_timeout = GNUNET_SCHEDULER_add_delayed (OP_TIMEOUT,
+                                               &operation_timeout, NULL);
 
   }
-  else if (benchmark_send) /* Benchmark sending */
+  else if (benchmark_send) /* -s: Benchmark sending */
   {
     if (NULL == cpid)
     {
       FPRINTF (stderr, _("Option `%s' makes no sense without option `%s'.\n"),
                "-s", "-p");
+      ret = 1;
       return;
     }
-    ret = 1;
     handle = GNUNET_TRANSPORT_connect (cfg, NULL, NULL,
                                        &notify_receive,
                                        &notify_connect,
                                        &notify_disconnect);
     if (NULL == handle)
     {
-        FPRINTF (stderr, _("Failed to connect to transport service\n"));
+        FPRINTF (stderr, "%s", _("Failed to connect to transport service\n"));
+        ret = 1;
         return;
     }
-    GNUNET_TRANSPORT_try_connect (handle, &pid);
-    /*
-    end = GNUNET_SCHEDULER_add_delayed (benchmark_send ?
-                                        GNUNET_TIME_UNIT_FOREVER_REL :
-                                        GNUNET_TIME_UNIT_SECONDS,
-                                        &do_disconnect,
-                                        NULL);*/
+    tc_handle =  GNUNET_TRANSPORT_try_connect (handle, &pid, try_connect_cb, NULL);
+    if (NULL == tc_handle)
+    {
+        FPRINTF (stderr, "%s", _("Failed to send request to transport service\n"));
+        ret = 1;
+        return;
+    }
+    start_time = GNUNET_TIME_absolute_get ();
+    op_timeout = GNUNET_SCHEDULER_add_delayed (OP_TIMEOUT,
+                                               &operation_timeout, NULL);
   }
-  else if (benchmark_receive) /* Benchmark receiving */
+  else if (benchmark_receive) /* -b: Benchmark receiving */
   {
     handle =
         GNUNET_TRANSPORT_connect (cfg, NULL, NULL, &notify_receive,
-                                  &notify_connect, &notify_disconnect);
+                                  NULL, NULL);
     if (NULL == handle)
     {
-        FPRINTF (stderr, _("Failed to connect to transport service\n"));
+        FPRINTF (stderr, "%s", _("Failed to connect to transport service\n"));
+        ret = 1;
         return;
     }
-    GNUNET_TRANSPORT_try_connect (handle, &pid);
+    if (verbosity > 0)
+      FPRINTF (stdout, "%s", _("Starting to receive benchmark data\n"));
     start_time = GNUNET_TIME_absolute_get ();
-    /*
-    end = GNUNET_SCHEDULER_add_delayed (GNUNET_TIME_UNIT_FOREVER_REL,
-                                      &do_disconnect, NULL);*/
+
   }
   else if (iterate_connections) /* -i: List all active addresses once */
   {
-    peers = GNUNET_CONTAINER_multihashmap_create (20, GNUNET_NO);
     address_resolution_in_progress = GNUNET_YES;
-    pic = GNUNET_TRANSPORT_peer_get_active_addresses (cfg, NULL,
+    pic = GNUNET_TRANSPORT_peer_get_active_addresses (cfg,
+                                                (NULL == cpid) ? NULL : &pid,
                                                 GNUNET_YES,
                                                 TIMEOUT,
                                                 &process_address, (void *) cfg);
+    op_timeout = GNUNET_SCHEDULER_add_delayed (OP_TIMEOUT,
+                                               &operation_timeout, NULL);
   }
   else if (monitor_connections) /* -m: List all active addresses continously */
   {
-    peers = GNUNET_CONTAINER_multihashmap_create (20, GNUNET_NO);
     address_resolution_in_progress = GNUNET_YES;
-    pic = GNUNET_TRANSPORT_peer_get_active_addresses (cfg, NULL,
+    pic = GNUNET_TRANSPORT_peer_get_active_addresses (cfg,
+                                                (NULL == cpid) ? NULL : &pid,
                                                 GNUNET_NO,
                                                 TIMEOUT,
                                                 &process_address, (void *) cfg);
@@ -781,15 +966,22 @@ testservice_task (void *cls,
                                        &monitor_notify_disconnect);
     if (NULL == handle)
     {
-      FPRINTF (stderr, _("Failed to connect to transport service\n"));
+      FPRINTF (stderr, "%s", _("Failed to connect to transport service\n"));
+      ret = 1;
       return;
     }
+    ret = 0;
   }
   else
   {
     GNUNET_break (0);
     return;
   }
+
+  end = GNUNET_SCHEDULER_add_delayed (GNUNET_TIME_UNIT_FOREVER_REL,
+                                      &shutdown_task,
+                                      NULL);
+
 }
 
 
@@ -799,21 +991,22 @@ testservice_task (void *cls,
  * @param cls closure
  * @param args remaining command-line arguments
  * @param cfgfile name of the configuration file used (for saving, can be NULL!)
- * @param cfg configuration
+ * @param mycfg configuration
  */
 static void
 run (void *cls, char *const *args, const char *cfgfile,
-     const struct GNUNET_CONFIGURATION_Handle *cfg)
+     const struct GNUNET_CONFIGURATION_Handle *mycfg)
 {
+  cfg = (struct GNUNET_CONFIGURATION_Handle *) mycfg;
   if (test_configuration)
   {
     do_test_configuration (cfg);
+    return;
   }
-
   GNUNET_CLIENT_service_test ("transport", cfg,
-      GNUNET_TIME_UNIT_SECONDS,
-      &testservice_task,
-      (void *) cfg);
+                             GNUNET_TIME_UNIT_SECONDS,
+                             &testservice_task,
+                             (void *) cfg);
 }
 
 
@@ -823,7 +1016,7 @@ main (int argc, char *const *argv)
   int res;
   static const struct GNUNET_GETOPT_CommandLineOption options[] = {
     {'b', "benchmark", NULL,
-     gettext_noop ("measure how fast we are receiving data (until CTRL-C)"),
+     gettext_noop ("measure how fast we are receiving data from all peers (until CTRL-C)"),
      0, &GNUNET_GETOPT_set_one, &benchmark_receive},
     {'C', "connect", NULL,
      gettext_noop ("connect to a peer"),