-bringing copyright tags up to FSF standard
[oweals/gnunet.git] / src / transport / gnunet-transport.c
index 7f1c056ea4309f6a1dbb7174bcd40ea20e57e774..8e8c173af2246a390df8c6ed52d74f525c71a5de 100644 (file)
@@ -1,6 +1,6 @@
 /*
  This file is part of GNUnet.
- (C) 2011-2014 Christian Grothoff (and other contributing authors)
Copyright (C) 2011-2014 Christian Grothoff (and other contributing authors)
 
  GNUnet is free software; you can redistribute it and/or modify
  it under the terms of the GNU General Public License as published
@@ -66,11 +66,6 @@ struct ValidationResolutionContext
    */
   struct ValidationResolutionContext *prev;
 
-  /**
-   * Peer identity
-   */
-  struct GNUNET_PeerIdentity id;
-
   /**
    * Address to resolve
    */
@@ -208,7 +203,7 @@ struct TestContext
   /**
    * Task identifier for the timeout.
    */
-  GNUNET_SCHEDULER_TaskIdentifier tsk;
+  struct GNUNET_SCHEDULER_Task * tsk;
 
   /**
    * Name of plugin under test.
@@ -281,10 +276,15 @@ static struct GNUNET_TRANSPORT_Handle *handle;
 static struct GNUNET_CONFIGURATION_Handle *cfg;
 
 /**
- * Try_connect handle
+ * Try connect handle
  */
 struct GNUNET_TRANSPORT_TryConnectHandle *tc_handle;
 
+/**
+ * Try disconnect handle
+ */
+struct GNUNET_TRANSPORT_TryDisconnectHandle *td_handle;
+
 /**
  * Option -s.
  */
@@ -335,6 +335,11 @@ static int monitor_connections;
  */
 static int monitor_validation;
 
+/**
+ * Option -P.
+ */
+static int monitor_plugins;
+
 /**
  * Option -C.
  */
@@ -386,15 +391,25 @@ static struct GNUNET_TRANSPORT_TransmitHandle *th;
 static struct GNUNET_CONTAINER_MultiPeerMap *monitored_peers;
 
 /**
- *
+ * Map storing information about monitored plugins's sessions.
+ */
+static struct GNUNET_CONTAINER_MultiPeerMap *monitored_plugins;
+
+/**
+ * Handle if we are monitoring peers at the transport level.
  */
 static struct GNUNET_TRANSPORT_PeerMonitoringContext *pic;
 
 /**
- *
+ * Handle if we are monitoring transport validation activity.
  */
 static struct GNUNET_TRANSPORT_ValidationMonitoringContext *vic;
 
+/**
+ * Handle if we are monitoring plugin session activity.
+ */
+static struct GNUNET_TRANSPORT_PluginMonitor *pm;
+
 /**
  * Identity of the peer we transmit to / connect to.
  * (equivalent to 'cpid' string).
@@ -404,12 +419,12 @@ static struct GNUNET_PeerIdentity pid;
 /**
  * Task scheduled for cleanup / termination of the process.
  */
-static GNUNET_SCHEDULER_TaskIdentifier end;
+static struct GNUNET_SCHEDULER_Task * end;
 
 /**
  * Task for operation timeout
  */
-static GNUNET_SCHEDULER_TaskIdentifier op_timeout;
+static struct GNUNET_SCHEDULER_Task * op_timeout;
 
 /**
  * Selected level of verbosity.
@@ -462,6 +477,14 @@ static struct PeerResolutionContext *rc_head;
 static struct PeerResolutionContext *rc_tail;
 
 
+/**
+ * Function called to release data stored in the #monitored_peers map.
+ *
+ * @param cls unused
+ * @param key the peer identity
+ * @param value a `struct MonitoredPeer` to release
+ * @return #GNUNET_OK (continue to iterate)
+ */
 static int
 destroy_it (void *cls,
             const struct GNUNET_PeerIdentity *key,
@@ -494,11 +517,11 @@ shutdown_task (void *cls,
   struct ValidationResolutionContext *cur;
   struct ValidationResolutionContext *next;
 
-  end = GNUNET_SCHEDULER_NO_TASK;
-  if (GNUNET_SCHEDULER_NO_TASK != op_timeout)
+  end = NULL;
+  if (NULL != op_timeout)
   {
     GNUNET_SCHEDULER_cancel (op_timeout);
-    op_timeout = GNUNET_SCHEDULER_NO_TASK;
+    op_timeout = NULL;
   }
   if (NULL != tc_handle)
   {
@@ -515,6 +538,11 @@ shutdown_task (void *cls,
     GNUNET_TRANSPORT_monitor_validation_entries_cancel (vic);
     vic = NULL;
   }
+  if (NULL != pm)
+  {
+    GNUNET_TRANSPORT_monitor_plugins_cancel (pm);
+    pm = NULL;
+  }
 
   next = vc_head;
   for (cur = next; NULL != cur; cur = next)
@@ -563,6 +591,13 @@ shutdown_task (void *cls,
     GNUNET_CONTAINER_multipeermap_destroy (monitored_peers);
     monitored_peers = NULL;
   }
+  if (NULL != monitored_plugins)
+  {
+    GNUNET_break (0 ==
+                  GNUNET_CONTAINER_multipeermap_size (monitored_plugins));
+    GNUNET_CONTAINER_multipeermap_destroy (monitored_plugins);
+    monitored_plugins = NULL;
+  }
 }
 
 
@@ -572,13 +607,13 @@ operation_timeout (void *cls,
 {
   struct PeerResolutionContext *cur;
   struct PeerResolutionContext *next;
-  op_timeout = GNUNET_SCHEDULER_NO_TASK;
+  op_timeout = NULL;
   if ((try_connect) || (benchmark_send) || (benchmark_receive))
   {
     FPRINTF (stdout,
              _("Failed to connect to `%s'\n"),
              GNUNET_i2s_full (&pid));
-    if (GNUNET_SCHEDULER_NO_TASK != end)
+    if (NULL != end)
       GNUNET_SCHEDULER_cancel (end);
     end = GNUNET_SCHEDULER_add_now (&shutdown_task, NULL);
     ret = 1;
@@ -604,7 +639,7 @@ operation_timeout (void *cls,
     FPRINTF (stdout,
              "%s",
              _("Failed to list connections, timeout occured\n"));
-    if (GNUNET_SCHEDULER_NO_TASK != end)
+    if (NULL != end)
       GNUNET_SCHEDULER_cancel (end);
     end = GNUNET_SCHEDULER_add_now (&shutdown_task, NULL);
     ret = 1;
@@ -654,25 +689,15 @@ display_test_result (struct TestContext *tc,
                tc->name);
       break;
     default:
+      FPRINTF (stderr,
+               _("Configuration for plugin `%s' did not work!\n"),
+               tc->name);
       break;
   }
-
-  if (GNUNET_YES != result)
-  {
-    FPRINTF (stderr,
-             _("Configuration for plugin `%s' did not work!\n"),
-             tc->name);
-  }
-  else
-  {
-    FPRINTF (stderr,
-             _("Configuration for plugin `%s' is working!\n"),
-             tc->name);
-  }
-  if (GNUNET_SCHEDULER_NO_TASK != tc->tsk)
+  if (NULL != tc->tsk)
   {
     GNUNET_SCHEDULER_cancel (tc->tsk);
-    tc->tsk = GNUNET_SCHEDULER_NO_TASK;
+    tc->tsk = NULL;
   }
   if (NULL != tc->tst)
   {
@@ -715,7 +740,6 @@ result_callback (void *cls,
 /**
  * Resolve address we got a validation state for to a string.
  *
- * @param id peer identity the address is for
  * @param address the address itself
  * @param numeric #GNUNET_YES to disable DNS, #GNUNET_NO to try reverse lookup
  * @param last_validation when was the address validated last
@@ -724,8 +748,7 @@ result_callback (void *cls,
  * @param state where are we in the validation state machine
  */
 static void
-resolve_validation_address (const struct GNUNET_PeerIdentity *id,
-                            const struct GNUNET_HELLO_Address *address,
+resolve_validation_address (const struct GNUNET_HELLO_Address *address,
                             int numeric,
                             struct GNUNET_TIME_Absolute last_validation,
                             struct GNUNET_TIME_Absolute valid_until,
@@ -764,10 +787,10 @@ process_validation_string (void *cls,
     if (GNUNET_SYSERR == res)
     {
       FPRINTF (stderr,
-               "Failed to convert address for peer `%s' plugin `%s' length %lu to string \n",
-               GNUNET_i2s (&vc->id),
+               "Failed to convert address for peer `%s' plugin `%s' length %u to string \n",
+               GNUNET_i2s (&vc->addrcp->peer),
                vc->addrcp->transport_name,
-               vc->addrcp->address_length);
+               (unsigned int) vc->addrcp->address_length);
     }
     if (GNUNET_TIME_UNIT_ZERO_ABS.abs_value_us == vc->valid_until.abs_value_us)
       s_valid = GNUNET_strdup ("never");
@@ -786,7 +809,7 @@ process_validation_string (void *cls,
 
     FPRINTF (stdout,
              _("Peer `%s' %s %s\n\t%s%s\n\t%s%s\n\t%s%s\n"),
-             GNUNET_i2s (&vc->id),
+             GNUNET_i2s (&vc->addrcp->peer),
              (GNUNET_OK == res) ? address : "<invalid address>",
              (monitor_validation) ? GNUNET_TRANSPORT_vs2s (vc->state) : "",
              "Valid until    : ", s_valid,
@@ -810,8 +833,7 @@ process_validation_string (void *cls,
          (note: this should be unnecessary, as
          transport should fallback to numeric lookup
          internally if DNS takes too long anyway) */
-      resolve_validation_address (&vc->id,
-                                  vc->addrcp,
+      resolve_validation_address (vc->addrcp,
                                   GNUNET_NO,
                                   vc->last_validation,
                                   vc->valid_until,
@@ -822,7 +844,7 @@ process_validation_string (void *cls,
     {
       FPRINTF (stdout,
                _("Peer `%s' %s `%s' \n"),
-               GNUNET_i2s (&vc->id),
+               GNUNET_i2s (&vc->addrcp->peer),
                "<unable to resolve address>",
                GNUNET_TRANSPORT_vs2s (vc->state));
     }
@@ -833,15 +855,15 @@ process_validation_string (void *cls,
   GNUNET_free (vc);
   if ((0 == address_resolutions) && (iterate_validation))
   {
-    if (GNUNET_SCHEDULER_NO_TASK != end)
+    if (NULL != end)
     {
       GNUNET_SCHEDULER_cancel (end);
-      end = GNUNET_SCHEDULER_NO_TASK;
+      end = NULL;
     }
-    if (GNUNET_SCHEDULER_NO_TASK != op_timeout)
+    if (NULL != op_timeout)
     {
       GNUNET_SCHEDULER_cancel (op_timeout);
-      op_timeout = GNUNET_SCHEDULER_NO_TASK;
+      op_timeout = NULL;
     }
     ret = 0;
     end = GNUNET_SCHEDULER_add_now (&shutdown_task, NULL);
@@ -852,7 +874,6 @@ process_validation_string (void *cls,
 /**
  * Resolve address we got a validation state for to a string.
  *
- * @param id peer identity the address is for
  * @param address the address itself
  * @param numeric #GNUNET_YES to disable DNS, #GNUNET_NO to try reverse lookup
  * @param last_validation when was the address validated last
@@ -861,8 +882,7 @@ process_validation_string (void *cls,
  * @param state where are we in the validation state machine
  */
 static void
-resolve_validation_address (const struct GNUNET_PeerIdentity *id,
-                            const struct GNUNET_HELLO_Address *address,
+resolve_validation_address (const struct GNUNET_HELLO_Address *address,
                             int numeric,
                             struct GNUNET_TIME_Absolute last_validation,
                             struct GNUNET_TIME_Absolute valid_until,
@@ -876,7 +896,6 @@ resolve_validation_address (const struct GNUNET_PeerIdentity *id,
   GNUNET_CONTAINER_DLL_insert(vc_head, vc_tail, vc);
   address_resolutions++;
 
-  vc->id = (*id);
   vc->transport = GNUNET_strdup(address->transport_name);
   vc->addrcp = GNUNET_HELLO_address_copy (address);
   vc->printed = GNUNET_NO;
@@ -898,7 +917,6 @@ resolve_validation_address (const struct GNUNET_PeerIdentity *id,
  * Resolve address we got a validation state for to a string.
  *
  * @param cls NULL
- * @param peer peer identity the address is for
  * @param address the address itself
  * @param last_validation when was the address validated last
  * @param valid_until until when is the address valid
@@ -907,14 +925,13 @@ resolve_validation_address (const struct GNUNET_PeerIdentity *id,
  */
 static void
 process_validation_cb (void *cls,
-                       const struct GNUNET_PeerIdentity *peer,
                        const struct GNUNET_HELLO_Address *address,
                        struct GNUNET_TIME_Absolute last_validation,
                        struct GNUNET_TIME_Absolute valid_until,
                        struct GNUNET_TIME_Absolute next_validation,
                        enum GNUNET_TRANSPORT_ValidationState state)
 {
-  if ((NULL == peer) && (NULL == address))
+  if (NULL == address)
   {
     if (monitor_validation)
     {
@@ -926,22 +943,21 @@ process_validation_cb (void *cls,
 
     /* done */
     vic = NULL;
-    if (GNUNET_SCHEDULER_NO_TASK != end)
+    if (NULL != end)
       GNUNET_SCHEDULER_cancel (end);
     end = GNUNET_SCHEDULER_add_now (&shutdown_task, NULL);
     return;
   }
-  if ((NULL == peer) || (NULL == address))
+  if (NULL == address)
   {
     /* invalid response */
     vic = NULL;
-    if (GNUNET_SCHEDULER_NO_TASK != end)
+    if (NULL != end)
       GNUNET_SCHEDULER_cancel (end);
     end = GNUNET_SCHEDULER_add_now (&shutdown_task, NULL);
     return;
   }
-  resolve_validation_address (peer,
-                              address,
+  resolve_validation_address (address,
                               numeric,
                               last_validation,
                               valid_until,
@@ -1100,23 +1116,23 @@ notify_connect (void *cls,
         GNUNET_i2s_full (peer));
     ret = 0;
 
-    if (GNUNET_SCHEDULER_NO_TASK != op_timeout)
+    if (NULL != op_timeout)
     {
       GNUNET_SCHEDULER_cancel (op_timeout);
-      op_timeout = GNUNET_SCHEDULER_NO_TASK;
+      op_timeout = NULL;
     }
 
-    if (GNUNET_SCHEDULER_NO_TASK != end)
+    if (NULL != end)
       GNUNET_SCHEDULER_cancel (end);
     end = GNUNET_SCHEDULER_add_now (&shutdown_task, NULL);
     return;
   }
   if (benchmark_send)
   {
-    if (GNUNET_SCHEDULER_NO_TASK != op_timeout)
+    if (NULL != op_timeout)
     {
       GNUNET_SCHEDULER_cancel (op_timeout);
-      op_timeout = GNUNET_SCHEDULER_NO_TASK;
+      op_timeout = NULL;
     }
     if (verbosity > 0)
       FPRINTF (stdout,
@@ -1157,13 +1173,13 @@ notify_disconnect (void *cls,
         GNUNET_i2s_full (peer));
     ret = 0;
 
-    if (GNUNET_SCHEDULER_NO_TASK != op_timeout)
+    if (NULL != op_timeout)
     {
       GNUNET_SCHEDULER_cancel (op_timeout);
-      op_timeout = GNUNET_SCHEDULER_NO_TASK;
+      op_timeout = NULL;
     }
 
-    if (GNUNET_SCHEDULER_NO_TASK != end)
+    if (NULL != end)
       GNUNET_SCHEDULER_cancel (end);
     end = GNUNET_SCHEDULER_add_now (&shutdown_task, NULL);
     return;
@@ -1178,7 +1194,7 @@ notify_disconnect (void *cls,
   {
     FPRINTF (stdout, _("Disconnected from peer `%s' while benchmarking\n"),
         GNUNET_i2s (&pid));
-    if (GNUNET_SCHEDULER_NO_TASK != end)
+    if (NULL != end)
       GNUNET_SCHEDULER_cancel (end);
     return;
   }
@@ -1333,10 +1349,10 @@ process_peer_string (void *cls,
     if (GNUNET_SYSERR == res)
     {
       FPRINTF (stderr,
-               "Failed to convert address for peer `%s' plugin `%s' length %lu to string \n",
+               "Failed to convert address for peer `%s' plugin `%s' length %u to string \n",
                GNUNET_i2s (&rc->id),
                rc->addrcp->transport_name,
-               rc->addrcp->address_length);
+               (unsigned int) rc->addrcp->address_length);
       print_info (&rc->id,
                   rc->transport,
                   NULL,
@@ -1391,15 +1407,15 @@ process_peer_string (void *cls,
   GNUNET_free (rc);
   if ((0 == address_resolutions) && (iterate_connections))
   {
-    if (GNUNET_SCHEDULER_NO_TASK != end)
+    if (NULL != end)
     {
       GNUNET_SCHEDULER_cancel (end);
-      end = GNUNET_SCHEDULER_NO_TASK;
+      end = NULL;
     }
-    if (GNUNET_SCHEDULER_NO_TASK != op_timeout)
+    if (NULL != op_timeout)
     {
       GNUNET_SCHEDULER_cancel (op_timeout);
-      op_timeout = GNUNET_SCHEDULER_NO_TASK;
+      op_timeout = NULL;
     }
     ret = 0;
     end = GNUNET_SCHEDULER_add_now (&shutdown_task, NULL);
@@ -1421,7 +1437,7 @@ resolve_peer_address (const struct GNUNET_PeerIdentity *id,
   GNUNET_CONTAINER_DLL_insert(rc_head, rc_tail, rc);
   address_resolutions++;
 
-  rc->id = (*id);
+  rc->id = *id;
   rc->transport = GNUNET_strdup(address->transport_name);
   rc->addrcp = GNUNET_HELLO_address_copy (address);
   rc->printed = GNUNET_NO;
@@ -1458,7 +1474,7 @@ process_peer_iteration_cb (void *cls,
     /* done */
     address_resolution_in_progress = GNUNET_NO;
     pic = NULL;
-    if (GNUNET_SCHEDULER_NO_TASK != end)
+    if (NULL != end)
       GNUNET_SCHEDULER_cancel (end);
     end = GNUNET_SCHEDULER_add_now (&shutdown_task, NULL);
     return;
@@ -1468,7 +1484,7 @@ process_peer_iteration_cb (void *cls,
        (GNUNET_NO == GNUNET_TRANSPORT_is_connected(state)))
       return; /* Display only connected peers */
 
-  if (GNUNET_SCHEDULER_NO_TASK != op_timeout)
+  if (NULL != op_timeout)
     GNUNET_SCHEDULER_cancel (op_timeout);
   op_timeout = GNUNET_SCHEDULER_add_delayed (OP_TIMEOUT,
                                              &operation_timeout,
@@ -1486,6 +1502,165 @@ process_peer_iteration_cb (void *cls,
 }
 
 
+/**
+ * Context for address resolution by #plugin_monitoring_cb().
+ */
+struct PluginMonitorAddress
+{
+
+  /**
+   * Ongoing resolution request.
+   */
+  struct GNUNET_TRANSPORT_AddressToStringContext *asc;
+
+  /**
+   * Resolved address as string.
+   */
+  char *str;
+};
+
+
+/**
+ * Function called with a textual representation of an address.  This
+ * function will be called several times with different possible
+ * textual representations, and a last time with @a address being NULL
+ * to signal the end of the iteration.  Note that @a address NULL
+ * always is the last call, regardless of the value in @a res.
+ *
+ * @param cls closure
+ * @param address NULL on end of iteration,
+ *        otherwise 0-terminated printable UTF-8 string,
+ *        in particular an empty string if @a res is #GNUNET_NO
+ * @param res result of the address to string conversion:
+ *        if #GNUNET_OK: conversion successful
+ *        if #GNUNET_NO: address was invalid (or not supported)
+ *        if #GNUNET_SYSERR: communication error (IPC error)
+ */
+static void
+address_cb (void *cls,
+            const char *address,
+            int res)
+{
+  struct PluginMonitorAddress *addr = cls;
+
+  if (NULL == address)
+  {
+    addr->asc = NULL;
+    return;
+  }
+  if (NULL != addr->str)
+    return;
+  addr->str = GNUNET_strdup (address);
+}
+
+
+/**
+ * Function called by the plugin with information about the
+ * current sessions managed by the plugin (for monitoring).
+ *
+ * @param cls closure (NULL)
+ * @param session session handle this information is about,
+ *        NULL to indicate that we are "in sync" (initial
+ *        iteration complete)
+ * @param session_ctx storage location where the application
+ *        can store data; will point to NULL on #GNUNET_TRANSPORT_SS_INIT,
+ *        and must be reset to NULL on #GNUNET_TRANSPORT_SS_DONE
+ * @param info information about the state of the session,
+ *        NULL if @a session is also NULL and we are
+ *        merely signalling that the initial iteration is over;
+ *        NULL with @a session being non-NULL if the monitor
+ *        was being cancelled while sessions were active
+ */
+static void
+plugin_monitoring_cb (void *cls,
+                      struct GNUNET_TRANSPORT_PluginSession *session,
+                      void **session_ctx,
+                      const struct GNUNET_TRANSPORT_SessionInfo *info)
+{
+  const char *state;
+  struct PluginMonitorAddress *addr;
+
+  if ( (NULL == info) &&
+       (NULL == session) )
+    return; /* in sync with transport service */
+  addr = *session_ctx;
+  if (NULL == info)
+  {
+    if (NULL != addr)
+    {
+      if (NULL != addr->asc)
+      {
+        GNUNET_TRANSPORT_address_to_string_cancel (addr->asc);
+        addr->asc = NULL;
+      }
+      GNUNET_free_non_null (addr->str);
+      GNUNET_free (addr);
+      *session_ctx = NULL;
+    }
+    return; /* shutdown */
+  }
+  if ( (NULL != cpid) &&
+       (0 != memcmp (&info->address->peer,
+                     cpid,
+                     sizeof (struct GNUNET_PeerIdentity))) )
+    return; /* filtered */
+  if (NULL == addr)
+  {
+    addr = GNUNET_new (struct PluginMonitorAddress);
+    addr->asc = GNUNET_TRANSPORT_address_to_string (cfg,
+                                                    info->address,
+                                                    GNUNET_NO,
+                                                    GNUNET_TIME_UNIT_FOREVER_REL,
+                                                    &address_cb,
+                                                    addr);
+    *session_ctx = addr;
+  }
+  switch (info->state)
+  {
+  case GNUNET_TRANSPORT_SS_INIT:
+    state = "INIT";
+    break;
+  case GNUNET_TRANSPORT_SS_HANDSHAKE:
+    state = "HANDSHAKE";
+    break;
+  case GNUNET_TRANSPORT_SS_UP:
+    state = "UP";
+    break;
+  case GNUNET_TRANSPORT_SS_UPDATE:
+    state = "UPDATE";
+    break;
+  case GNUNET_TRANSPORT_SS_DONE:
+    state = "DONE";
+    break;
+  default:
+    state = "UNKNOWN";
+    break;
+  }
+  fprintf (stdout,
+           "%s: %s %s (# %u/%u b) blocked until %s timeout in %s [%s]\n",
+           GNUNET_i2s (&info->address->peer),
+           addr->str,
+           (info->is_inbound == GNUNET_YES) ? "<-" : ((info->is_inbound == GNUNET_NO) ? "->" : "<>"),
+           info->num_msg_pending,
+           info->num_bytes_pending,
+           GNUNET_STRINGS_absolute_time_to_string (info->receive_delay),
+           GNUNET_STRINGS_relative_time_to_string (GNUNET_TIME_absolute_get_remaining (info->session_timeout),
+                                                GNUNET_YES),
+           state);
+  if (GNUNET_TRANSPORT_SS_DONE == info->state)
+  {
+    if (NULL != addr->asc)
+    {
+      GNUNET_TRANSPORT_address_to_string_cancel (addr->asc);
+      addr->asc = NULL;
+    }
+    GNUNET_free_non_null (addr->str);
+    GNUNET_free (addr);
+    *session_ctx = NULL;
+  }
+}
+
+
 /**
  * Function called with information about a peers
  *
@@ -1514,7 +1689,7 @@ process_peer_monitoring_cb (void *cls,
     return;
   }
 
-  if (GNUNET_SCHEDULER_NO_TASK != op_timeout)
+  if (NULL != op_timeout)
     GNUNET_SCHEDULER_cancel (op_timeout);
   op_timeout = GNUNET_SCHEDULER_add_delayed (OP_TIMEOUT,
                                              &operation_timeout,
@@ -1564,59 +1739,74 @@ process_peer_monitoring_cb (void *cls,
 }
 
 
+/**
+ * Function called with our result of trying to connect to a peer
+ * using the transport service. Will retry 10 times, and if we still
+ * fail to connect terminate with an error message.
+ *
+ * @param cls NULL
+ * @param result #GNUNET_OK if we connected to the service
+ */
 static void
 try_connect_cb (void *cls,
                 const int result)
 {
   static int retries = 0;
 
+  tc_handle = NULL;
   if (GNUNET_OK == result)
-  {
-    tc_handle = NULL;
     return;
-  }
   retries++;
   if (retries < 10)
-    tc_handle = GNUNET_TRANSPORT_try_connect (handle, &pid, try_connect_cb,
-        NULL);
-  else
   {
-    FPRINTF (stderr,
-             "%s",
-             _("Failed to send connect request to transport service\n"));
-    if (GNUNET_SCHEDULER_NO_TASK != end)
-      GNUNET_SCHEDULER_cancel (end);
-    ret = 1;
-    end = GNUNET_SCHEDULER_add_now (&shutdown_task, NULL);
+    tc_handle = GNUNET_TRANSPORT_try_connect (handle,
+                                              &pid,
+                                              &try_connect_cb,
+                                              NULL);
     return;
   }
+  FPRINTF (stderr,
+           "%s",
+           _("Failed to send connect request to transport service\n"));
+  if (NULL != end)
+    GNUNET_SCHEDULER_cancel (end);
+  ret = 1;
+  end = GNUNET_SCHEDULER_add_now (&shutdown_task, NULL);
 }
 
 
+/**
+ * Function called with our result of trying to disconnect a peer
+ * using the transport service. Will retry 10 times, and if we still
+ * fail to disconnect, terminate with an error message.
+ *
+ * @param cls NULL
+ * @param result #GNUNET_OK if we connected to the service
+ */
 static void
 try_disconnect_cb (void *cls,
                    const int result)
 {
   static int retries = 0;
+
+  td_handle = NULL;
   if (GNUNET_OK == result)
-  {
-    tc_handle = NULL;
     return;
-  }
   retries++;
   if (retries < 10)
-    tc_handle = GNUNET_TRANSPORT_try_disconnect (handle, &pid, try_disconnect_cb,
-        NULL);
-  else
   {
-    FPRINTF (stderr, "%s",
-        _("Failed to send connect request to transport service\n"));
-    if (GNUNET_SCHEDULER_NO_TASK != end)
-      GNUNET_SCHEDULER_cancel (end);
-    ret = 1;
-    end = GNUNET_SCHEDULER_add_now (&shutdown_task, NULL);
+    td_handle = GNUNET_TRANSPORT_try_disconnect (handle,
+                                                 &pid,
+                                                 &try_disconnect_cb,
+                                                 NULL);
     return;
   }
+  FPRINTF (stderr, "%s",
+           _("Failed to send disconnect request to transport service\n"));
+  if (NULL != end)
+    GNUNET_SCHEDULER_cancel (end);
+  ret = 1;
+  end = GNUNET_SCHEDULER_add_now (&shutdown_task, NULL);
 }
 
 
@@ -1628,7 +1818,8 @@ try_disconnect_cb (void *cls,
  * @param result #GNUNET_YES if transport is running
  */
 static void
-testservice_task (void *cls, int result)
+testservice_task (void *cls,
+                  int result)
 {
   int counter = 0;
   ret = 1;
@@ -1650,22 +1841,22 @@ testservice_task (void *cls, int result)
 
   counter = benchmark_send + benchmark_receive + iterate_connections
       + monitor_connections + monitor_connects + try_connect + try_disconnect +
-      + iterate_validation + monitor_validation;
+      + iterate_validation + monitor_validation + monitor_plugins;
 
   if (1 < counter)
   {
     FPRINTF (stderr,
-        _("Multiple operations given. Please choose only one operation: %s, %s, %s, %s, %s, %s\n"),
+        _("Multiple operations given. Please choose only one operation: %s, %s, %s, %s, %s, %s %s\n"),
         "connect", "benchmark send", "benchmark receive", "information",
-        "monitor", "events");
+             "monitor", "events", "plugins");
     return;
   }
   if (0 == counter)
   {
     FPRINTF (stderr,
-        _("No operation given. Please choose one operation: %s, %s, %s, %s, %s, %s\n"),
+        _("No operation given. Please choose one operation: %s, %s, %s, %s, %s, %s, %s\n"),
         "connect", "benchmark send", "benchmark receive", "information",
-        "monitor", "events");
+             "monitor", "events", "plugins");
     return;
   }
 
@@ -1716,9 +1907,10 @@ testservice_task (void *cls, int result)
       ret = 1;
       return;
     }
-    tc_handle = GNUNET_TRANSPORT_try_disconnect (handle, &pid, try_disconnect_cb,
-        NULL);
-    if (NULL == tc_handle)
+    td_handle = GNUNET_TRANSPORT_try_disconnect (handle, &pid,
+                                                 &try_disconnect_cb,
+                                                 NULL);
+    if (NULL == td_handle)
     {
       FPRINTF (stderr, "%s",
           _("Failed to send request to transport service\n"));
@@ -1738,16 +1930,20 @@ testservice_task (void *cls, int result)
       ret = 1;
       return;
     }
-    handle = GNUNET_TRANSPORT_connect (cfg, NULL, NULL, &notify_receive,
-        &notify_connect, &notify_disconnect);
+    handle = GNUNET_TRANSPORT_connect (cfg, NULL, NULL,
+                                       &notify_receive,
+                                       &notify_connect,
+                                       &notify_disconnect);
     if (NULL == handle)
     {
       FPRINTF (stderr, "%s", _("Failed to connect to transport service\n"));
       ret = 1;
       return;
     }
-    tc_handle = GNUNET_TRANSPORT_try_connect (handle, &pid, try_connect_cb,
-        NULL);
+    tc_handle = GNUNET_TRANSPORT_try_connect (handle,
+                                              &pid,
+                                              &try_connect_cb,
+                                              NULL);
     if (NULL == tc_handle)
     {
       FPRINTF (stderr, "%s",
@@ -1756,8 +1952,9 @@ testservice_task (void *cls, int result)
       return;
     }
     start_time = GNUNET_TIME_absolute_get ();
-    op_timeout = GNUNET_SCHEDULER_add_delayed (OP_TIMEOUT, &operation_timeout,
-        NULL);
+    op_timeout = GNUNET_SCHEDULER_add_delayed (OP_TIMEOUT,
+                                               &operation_timeout,
+                                               NULL);
   }
   else if (benchmark_receive) /* -b: Benchmark receiving */
   {
@@ -1790,6 +1987,13 @@ testservice_task (void *cls, int result)
                                           GNUNET_NO, TIMEOUT,
                                           &process_peer_monitoring_cb, (void *) cfg);
   }
+  else if (monitor_plugins) /* -P: List information about plugins continuously */
+  {
+    monitored_plugins = GNUNET_CONTAINER_multipeermap_create (10, GNUNET_NO);
+    pm = GNUNET_TRANSPORT_monitor_plugins (cfg,
+                                           &plugin_monitoring_cb,
+                                           NULL);
+  }
   else if (iterate_validation) /* -d: Print information about validations */
   {
     vic = GNUNET_TRANSPORT_monitor_validation_entries (cfg,
@@ -1894,6 +2098,9 @@ main (int argc, char * const *argv)
     { 'p', "peer", "PEER",
       gettext_noop ("peer identity"), 1, &GNUNET_GETOPT_set_string,
       &cpid },
+    { 'P', "plugins", NULL,
+      gettext_noop ("monitor plugin sessions"), 0, &GNUNET_GETOPT_set_one,
+      &monitor_plugins },
     { 's', "send", NULL, gettext_noop
       ("send data for benchmarking to the other peer (until CTRL-C)"), 0,
       &GNUNET_GETOPT_set_one, &benchmark_send },