-allow caller ID to differ from zone used for resolution
[oweals/gnunet.git] / src / transport / gnunet-transport.c
index 56df0fbf622840003e91879fa14725b76ec04642..85f97e04c7edc46e719e56c827a78c9d534416d0 100644 (file)
@@ -39,7 +39,7 @@
  * How long do we wait for the NAT test to report success?
  * Should match NAT_SERVER_TIMEOUT in 'nat_test.c'.
  */
-#define TIMEOUT GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_SECONDS, 60)
+#define TIMEOUT GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_SECONDS, 20)
 #define RESOLUTION_TIMEOUT GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_SECONDS, 30)
 #define OP_TIMEOUT GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_SECONDS, 30)
 
@@ -123,6 +123,11 @@ static int monitor_validation;
  */
 static int try_connect;
 
+/**
+ * Option -D.
+ */
+static int try_disconnect;
+
 /**
  * Option -n.
  */
@@ -196,11 +201,6 @@ static int verbosity;
  */
 struct GNUNET_OS_Process *resolver;
 
-/**
- * Number of tasks running that still need the resolver.
- */
-static unsigned int resolver_users;
-
 /**
  * Number of address resolutions pending
  */
@@ -211,12 +211,30 @@ static unsigned int address_resolutions;
  */
 static unsigned int address_resolution_in_progress;
 
+/**
+ * DLL for NAT Test Contexts: head
+ */
+struct TestContext *head;
+
+/**
+ * DLL for NAT Test Contexts: tail
+ */
+struct TestContext *tail;
 
 /**
  * Context for a plugin test.
  */
 struct TestContext
 {
+  /**
+   * Previous in DLL
+   */
+  struct TestContext *prev;
+
+  /**
+   * Next in DLL
+   */
+  struct TestContext *next;
 
   /**
    * Handle to the active NAT test.
@@ -231,10 +249,59 @@ struct TestContext
   /**
    * Name of plugin under test.
    */
-  const char *name;
+  char *name;
+
+  /**
+   * Bound port
+   */
+  unsigned long long bnd_port;
+
+  /**
+   * Advertised ports
+   */
+  unsigned long long adv_port;
 
 };
 
+enum TestResult
+{
+  /* NAT returned success */
+  NAT_TEST_SUCCESS = GNUNET_OK,
+
+  /* NAT returned failure  */
+  NAT_TEST_FAIL = GNUNET_NO,
+
+  /* NAT returned failure while running test */
+  NAT_TEST_INTERNAL_FAIL = GNUNET_SYSERR,
+
+  /* We could not start the test */
+  NAT_TEST_FAILED_TO_START = 2,
+
+  /* We had a timeout while running the test */
+  NAT_TEST_TIMEOUT = 3,
+};
+
+static struct ValidationResolutionContext *vc_head;
+static struct ValidationResolutionContext *vc_tail;
+
+struct ValidationResolutionContext
+{
+  struct ValidationResolutionContext *next;
+  struct ValidationResolutionContext *prev;
+
+  struct GNUNET_PeerIdentity id;
+  struct GNUNET_HELLO_Address *addrcp;
+  struct GNUNET_TIME_Absolute last_validation;
+  struct GNUNET_TIME_Absolute valid_until;
+  struct GNUNET_TIME_Absolute next_validation;
+  enum GNUNET_TRANSPORT_ValidationState state;
+
+  struct GNUNET_TRANSPORT_AddressToStringContext *asc;
+
+  char *transport;
+  int printed;
+};
+
 struct MonitoredPeer
 {
   enum GNUNET_TRANSPORT_PeerState state;
@@ -243,17 +310,21 @@ struct MonitoredPeer
 };
 
 
- int destroy_it (void *cls,
-    const struct GNUNET_PeerIdentity *key,
-    void *value)
+static int
+destroy_it (void *cls,
+            const struct GNUNET_PeerIdentity *key,
+            void *value)
 {
-   struct MonitoredPeer *m = value;
-   GNUNET_CONTAINER_multipeermap_remove (monitored_peers, key, value);
-   GNUNET_free_non_null (m->address);
-   GNUNET_free (value);
-   return GNUNET_OK;
+  struct MonitoredPeer *m = value;
+
+  GNUNET_assert (GNUNET_OK == GNUNET_CONTAINER_multipeermap_remove (monitored_peers,
+                                                                    key, value));
+  GNUNET_free_non_null (m->address);
+  GNUNET_free (value);
+  return GNUNET_OK;
 }
 
+
 /**
  * Task run in monitor mode when the user presses CTRL-C to abort.
  * Stops monitoring activity.
@@ -265,6 +336,8 @@ static void
 shutdown_task (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
 {
   struct GNUNET_TIME_Relative duration;
+  struct ValidationResolutionContext *cur;
+  struct ValidationResolutionContext *next;
   end = GNUNET_SCHEDULER_NO_TASK;
   if (GNUNET_SCHEDULER_NO_TASK != op_timeout)
   {
@@ -286,6 +359,19 @@ shutdown_task (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
     GNUNET_TRANSPORT_monitor_validation_entries_cancel (vic);
     vic = NULL;
   }
+
+  next = vc_head;
+  for (cur = next; NULL != cur; cur = next)
+  {
+    next = cur->next;
+
+    GNUNET_TRANSPORT_address_to_string_cancel (cur->asc);
+    GNUNET_CONTAINER_DLL_remove (vc_head, vc_tail, cur);
+    GNUNET_free (cur->transport);
+    GNUNET_HELLO_address_free (cur->addrcp);
+    GNUNET_free (cur);
+  }
+
   if (NULL != th)
   {
     GNUNET_TRANSPORT_notify_transmit_ready_cancel (th);
@@ -337,26 +423,7 @@ struct PeerResolutionContext
   int printed;
 };
 
-static struct ValidationResolutionContext *vc_head;
-static struct ValidationResolutionContext *vc_tail;
 
-struct ValidationResolutionContext
-{
-  struct ValidationResolutionContext *next;
-  struct ValidationResolutionContext *prev;
-
-  struct GNUNET_PeerIdentity id;
-  struct GNUNET_HELLO_Address *addrcp;
-  struct GNUNET_TIME_Absolute last_validation;
-  struct GNUNET_TIME_Absolute valid_until;
-  struct GNUNET_TIME_Absolute next_validation;
-  enum GNUNET_TRANSPORT_ValidationState state;
-
-  struct GNUNET_TRANSPORT_AddressToStringContext *asc;
-
-  char *transport;
-  int printed;
-};
 
 static void
 operation_timeout (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
@@ -399,6 +466,9 @@ operation_timeout (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
 
 }
 
+static void
+run_nat_test ();
+
 /**
  * Display the result of the test.
  *
@@ -406,8 +476,33 @@ operation_timeout (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
  * @param result #GNUNET_YES on success
  */
 static void
-display_test_result (struct TestContext *tc, int result)
+display_test_result (struct TestContext *tc, enum TestResult result)
 {
+  switch (result) {
+    case NAT_TEST_FAIL:
+      FPRINTF (stderr, _("Configuration for plugin `%s' did not work!\n"),
+          tc->name);
+      break;
+    case NAT_TEST_SUCCESS:
+      FPRINTF (stderr, _("Configuration for plugin `%s' did work!\n"),
+          tc->name);
+      break;
+    case NAT_TEST_INTERNAL_FAIL:
+      FPRINTF (stderr, _("Internal NAT error while running test for plugin `%s'\n"),
+          tc->name);
+      break;
+    case NAT_TEST_FAILED_TO_START:
+      FPRINTF (stderr, _("Failed to start NAT test for plugin `%s'\n"),
+          tc->name);
+      break;
+    case NAT_TEST_TIMEOUT:
+      FPRINTF (stderr, _("Timeout while waiting for result of NAT test for plugin `%s'\n"),
+          tc->name);
+      break;
+    default:
+      break;
+  }
+
   if (GNUNET_YES != result)
   {
     FPRINTF (stderr, "Configuration for plugin `%s' did not work!\n", tc->name);
@@ -426,14 +521,19 @@ display_test_result (struct TestContext *tc, int result)
     GNUNET_NAT_test_stop (tc->tst);
     tc->tst = NULL;
   }
-  GNUNET_free(tc);
-  resolver_users--;
-  if ((0 == resolver_users) && (NULL != resolver))
+
+  GNUNET_CONTAINER_DLL_remove (head, tail, tc);
+  GNUNET_free (tc->name);
+  GNUNET_free (tc);
+
+  if ((NULL == head) && (NULL != resolver))
   {
     GNUNET_break(0 == GNUNET_OS_process_kill (resolver, GNUNET_TERM_SIG));
     GNUNET_OS_process_destroy (resolver);
     resolver = NULL;
   }
+  if (NULL != head)
+    run_nat_test ();
 }
 
 /**
@@ -445,11 +545,10 @@ display_test_result (struct TestContext *tc, int result)
  * @param emsg error message, NULL on success
  */
 static void
-result_callback (void *cls, int success, const char *emsg)
+result_callback (void *cls, enum GNUNET_NAT_FailureCode result)
 {
   struct TestContext *tc = cls;
-
-  display_test_result (tc, success);
+  display_test_result (tc, result);
 }
 
 /**
@@ -465,20 +564,22 @@ fail_timeout (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
   struct TestContext *tstc = cls;
 
   tstc->tsk = GNUNET_SCHEDULER_NO_TASK;
-  display_test_result (tstc, GNUNET_NO);
+  display_test_result (tstc, NAT_TEST_TIMEOUT);
 }
 
 
 static void
 resolve_validation_address (const struct GNUNET_PeerIdentity *id,
-    const struct GNUNET_HELLO_Address *address, int numeric,
-    struct GNUNET_TIME_Absolute last_validation,
-    struct GNUNET_TIME_Absolute valid_until,
-    struct GNUNET_TIME_Absolute next_validation,
-    enum GNUNET_TRANSPORT_ValidationState state);
+                            const struct GNUNET_HELLO_Address *address,
+                            int numeric,
+                            struct GNUNET_TIME_Absolute last_validation,
+                            struct GNUNET_TIME_Absolute valid_until,
+                            struct GNUNET_TIME_Absolute next_validation,
+                            enum GNUNET_TRANSPORT_ValidationState state);
+
 
 static void
-process_validation_string (void *cls, const char *address)
+process_validation_string (void *cls, const char *address, int res)
 {
   struct ValidationResolutionContext *vc = cls;
   char *s_valid;
@@ -487,6 +588,13 @@ process_validation_string (void *cls, const char *address)
 
   if (address != NULL )
   {
+    if (GNUNET_SYSERR == res)
+    {
+      FPRINTF (stderr, "Failed to convert address for peer `%s' plugin `%s' length %lu to string \n",
+          GNUNET_i2s (&vc->id),
+          vc->addrcp->transport_name,
+          vc->addrcp->address_length);
+    }
     if (GNUNET_TIME_UNIT_ZERO_ABS.abs_value_us == vc->valid_until.abs_value_us)
       s_valid = GNUNET_strdup("never");
     else
@@ -504,7 +612,8 @@ process_validation_string (void *cls, const char *address)
 
     FPRINTF (stdout,
         _("Peer `%s' %s %s\n\t%s%s\n\t%s%s\n\t%s%s\n"),
-        GNUNET_i2s (&vc->id), address,
+        GNUNET_i2s (&vc->id),
+        (GNUNET_OK == res) ? address : "<invalid address>",
         (monitor_validation) ? GNUNET_TRANSPORT_vs2s (vc->state) : "",
         "Valid until    : ", s_valid,
         "Last validation: ",s_last,
@@ -517,9 +626,10 @@ process_validation_string (void *cls, const char *address)
   else
   {
     /* done */
+
     GNUNET_assert(address_resolutions > 0);
     address_resolutions--;
-    if (GNUNET_NO == vc->printed)
+    if ((GNUNET_SYSERR == res) && (GNUNET_NO == vc->printed))
     {
       if (numeric == GNUNET_NO)
       {
@@ -589,16 +699,25 @@ resolve_validation_address (const struct GNUNET_PeerIdentity *id,
 }
 
 
-void process_validation_cb (void *cls,
-    const struct GNUNET_PeerIdentity *peer,
-    const struct GNUNET_HELLO_Address *address,
-    struct GNUNET_TIME_Absolute last_validation,
-    struct GNUNET_TIME_Absolute valid_until,
-    struct GNUNET_TIME_Absolute next_validation,
-    enum GNUNET_TRANSPORT_ValidationState state)
+static void
+process_validation_cb (void *cls,
+                       const struct GNUNET_PeerIdentity *peer,
+                       const struct GNUNET_HELLO_Address *address,
+                       struct GNUNET_TIME_Absolute last_validation,
+                       struct GNUNET_TIME_Absolute valid_until,
+                       struct GNUNET_TIME_Absolute next_validation,
+                       enum GNUNET_TRANSPORT_ValidationState state)
 {
   if ((NULL == peer) && (NULL == address))
   {
+    if (monitor_validation)
+    {
+      FPRINTF (stdout,
+               "%s",
+               _("Monitor disconnected from transport service. Reconnecting.\n"));
+      return;
+    }
+
     /* done */
     vic = NULL;
     if (GNUNET_SCHEDULER_NO_TASK != end)
@@ -620,6 +739,28 @@ void process_validation_cb (void *cls,
      valid_until, next_validation, state);
 }
 
+
+static void
+run_nat_test ()
+{
+  GNUNET_log (GNUNET_ERROR_TYPE_INFO,
+      "Running test for plugin `%s' using bind port %u and advertised port %u \n",
+      head->name, (uint16_t) head->bnd_port, (uint16_t) head->adv_port);
+
+  head->tst = GNUNET_NAT_test_start (cfg,
+      (0 == strcasecmp (head->name, "udp")) ? GNUNET_NO : GNUNET_YES,
+      (uint16_t) head->bnd_port,
+      (uint16_t) head->adv_port,
+      &result_callback, head);
+  if (NULL == head->tst)
+  {
+    display_test_result (head, NAT_TEST_FAILED_TO_START);
+    return;
+  }
+  head->tsk = GNUNET_SCHEDULER_add_delayed (TIMEOUT, &fail_timeout, head);
+}
+
+
 /**
  * Test our plugin's configuration (NAT traversal, etc.).
  *
@@ -644,10 +785,10 @@ do_test_configuration (const struct GNUNET_CONFIGURATION_Handle *cfg)
     ret = 4;
     return;
   }
+
   for (tok = strtok (plugins, " "); tok != NULL ; tok = strtok (NULL, " "))
   {
     char section[12 + strlen (tok)];
-
     GNUNET_snprintf (section, sizeof(section), "transport-%s", tok);
     if (GNUNET_OK
         != GNUNET_CONFIGURATION_get_value_number (cfg, section, "PORT",
@@ -657,33 +798,36 @@ do_test_configuration (const struct GNUNET_CONFIGURATION_Handle *cfg)
           _("No port configured for plugin `%s', cannot test it\n"), tok);
       continue;
     }
-    if (GNUNET_OK
-        != GNUNET_CONFIGURATION_get_value_number (cfg, section,
+    if (GNUNET_OK != GNUNET_CONFIGURATION_get_value_number (cfg, section,
             "ADVERTISED_PORT", &adv_port))
       adv_port = bnd_port;
-    if (NULL == resolver)
-    {
-      binary = GNUNET_OS_get_libexec_binary_path ("gnunet-service-resolver");
-      resolver = GNUNET_OS_start_process (GNUNET_YES,
-          GNUNET_OS_INHERIT_STD_OUT_AND_ERR, NULL, NULL, binary,
-          "gnunet-service-resolver", NULL );
-      GNUNET_free(binary);
-    }
-    resolver_users++;
-    GNUNET_RESOLVER_connect (cfg);
+
     tc = GNUNET_new (struct TestContext);
     tc->name = GNUNET_strdup (tok);
-    tc->tst = GNUNET_NAT_test_start (cfg,
-        (0 == strcasecmp (tok, "udp")) ? GNUNET_NO : GNUNET_YES,
-        (uint16_t) bnd_port, (uint16_t) adv_port, &result_callback, tc);
-    if (NULL == tc->tst)
+    tc->adv_port = adv_port;
+    tc->bnd_port = bnd_port;
+    GNUNET_CONTAINER_DLL_insert_tail (head, tail, tc);
+  }
+  GNUNET_free(plugins);
+
+  if ((NULL != head) && (NULL == resolver))
+  {
+    binary = GNUNET_OS_get_libexec_binary_path ("gnunet-service-resolver");
+    resolver = GNUNET_OS_start_process (GNUNET_YES,
+                                        GNUNET_OS_INHERIT_STD_OUT_AND_ERR,
+                                        NULL, NULL, NULL,
+                                        binary,
+                                        "gnunet-service-resolver", NULL );
+    if (NULL == resolver)
     {
-      display_test_result (tc, GNUNET_SYSERR);
-      continue;
+      FPRINTF (stderr, _("Failed to start resolver!\n"));
+      return;
     }
-    tc->tsk = GNUNET_SCHEDULER_add_delayed (TIMEOUT, &fail_timeout, tc);
+
+    GNUNET_free(binary);
+    GNUNET_RESOLVER_connect (cfg);
+    run_nat_test ();
   }
-  GNUNET_free(plugins);
 }
 
 /**
@@ -714,14 +858,17 @@ transmit_data (void *cls, size_t size, void *buf)
   m->type = ntohs (GNUNET_MESSAGE_TYPE_DUMMY);
   memset (&m[1], 52, size - sizeof(struct GNUNET_MessageHeader));
   traffic_sent += size;
-  th = GNUNET_TRANSPORT_notify_transmit_ready (handle, &pid, BLOCKSIZE * 1024,
-      0, GNUNET_TIME_UNIT_FOREVER_REL, &transmit_data, NULL );
+  th = GNUNET_TRANSPORT_notify_transmit_ready (handle, &pid,
+                                               BLOCKSIZE * 1024,
+                                               GNUNET_TIME_UNIT_FOREVER_REL,
+                                               &transmit_data, NULL );
   if (verbosity > 0)
     FPRINTF (stdout, _("Transmitting %u bytes to %s\n"), (unsigned int) size,
         GNUNET_i2s (&pid));
   return size;
 }
 
+
 /**
  * Function called to notify transport users that another
  * peer connected to us.
@@ -767,8 +914,10 @@ notify_connect (void *cls, const struct GNUNET_PeerIdentity *peer)
     start_time = GNUNET_TIME_absolute_get ();
     if (NULL == th)
       th = GNUNET_TRANSPORT_notify_transmit_ready (handle, peer,
-          BLOCKSIZE * 1024, 0, GNUNET_TIME_UNIT_FOREVER_REL, &transmit_data,
-          NULL );
+                                                   BLOCKSIZE * 1024,
+                                                   GNUNET_TIME_UNIT_FOREVER_REL,
+                                                   &transmit_data,
+                                                   NULL);
     else
       GNUNET_break(0);
     return;
@@ -788,6 +937,25 @@ notify_disconnect (void *cls, const struct GNUNET_PeerIdentity *peer)
   if (0 != memcmp (&pid, peer, sizeof(struct GNUNET_PeerIdentity)))
     return;
 
+  if (try_disconnect)
+  {
+    /* all done, terminate instantly */
+    FPRINTF (stdout, _("Successfully disconnected from `%s'\n"),
+        GNUNET_i2s_full (peer));
+    ret = 0;
+
+    if (GNUNET_SCHEDULER_NO_TASK != op_timeout)
+    {
+      GNUNET_SCHEDULER_cancel (op_timeout);
+      op_timeout = GNUNET_SCHEDULER_NO_TASK;
+    }
+
+    if (GNUNET_SCHEDULER_NO_TASK != end)
+      GNUNET_SCHEDULER_cancel (end);
+    end = GNUNET_SCHEDULER_add_now (&shutdown_task, NULL );
+    return;
+  }
+
   if (NULL != th)
   {
     GNUNET_TRANSPORT_notify_transmit_ready_cancel (th);
@@ -821,6 +989,7 @@ monitor_notify_connect (void *cls, const struct GNUNET_PeerIdentity *peer)
       _("Connected to"), GNUNET_i2s (peer), monitor_connect_counter);
 }
 
+
 /**
  * Function called to notify transport users that another
  * peer disconnected from us.
@@ -841,6 +1010,7 @@ monitor_notify_disconnect (void *cls, const struct GNUNET_PeerIdentity *peer)
       _("Disconnected from"), GNUNET_i2s (peer), monitor_connect_counter);
 }
 
+
 /**
  * Function called by the transport for each received message.
  *
@@ -849,8 +1019,9 @@ monitor_notify_disconnect (void *cls, const struct GNUNET_PeerIdentity *peer)
  * @param message the message
  */
 static void
-notify_receive (void *cls, const struct GNUNET_PeerIdentity *peer,
-    const struct GNUNET_MessageHeader *message)
+notify_receive (void *cls,
+                const struct GNUNET_PeerIdentity *peer,
+                const struct GNUNET_MessageHeader *message)
 {
   if (benchmark_receive)
   {
@@ -867,18 +1038,25 @@ notify_receive (void *cls, const struct GNUNET_PeerIdentity *peer,
   }
 }
 
+
 static void
 resolve_peer_address (const struct GNUNET_PeerIdentity *id,
-    const struct GNUNET_HELLO_Address *address, int numeric,
-    enum GNUNET_TRANSPORT_PeerState state,
-    struct GNUNET_TIME_Absolute state_timeout);
+                      const struct GNUNET_HELLO_Address *address,
+                      int numeric,
+                      enum GNUNET_TRANSPORT_PeerState state,
+                      struct GNUNET_TIME_Absolute state_timeout);
+
 
 static void
-print_info (const struct GNUNET_PeerIdentity *id, const char *transport,
-    const char *addr, enum GNUNET_TRANSPORT_PeerState state,
-    struct GNUNET_TIME_Absolute state_timeout)
+print_info (const struct GNUNET_PeerIdentity *id,
+            const char *transport,
+            const char *addr,
+            enum GNUNET_TRANSPORT_PeerState state,
+            struct GNUNET_TIME_Absolute state_timeout)
 {
-  if ((GNUNET_YES == iterate_all) || (GNUNET_YES == monitor_connections) )
+
+  if ( ((GNUNET_YES == iterate_connections) && (GNUNET_YES == iterate_all)) ||
+       (GNUNET_YES == monitor_connections) )
   {
     FPRINTF (stdout, _("Peer `%s': %s %s in state `%s' until %s\n"),
         GNUNET_i2s (id),
@@ -887,25 +1065,39 @@ print_info (const struct GNUNET_PeerIdentity *id, const char *transport,
         GNUNET_TRANSPORT_ps2s (state),
         GNUNET_STRINGS_absolute_time_to_string (state_timeout));
   }
-  else
+  else if ( (GNUNET_YES == iterate_connections) &&
+             (GNUNET_TRANSPORT_is_connected(state)) )
   {
     /* Only connected peers, skip state */
     FPRINTF (stdout, _("Peer `%s': %s %s\n"), GNUNET_i2s (id), transport, addr);
   }
-
 }
 
+
 static void
-process_peer_string (void *cls, const char *address)
+process_peer_string (void *cls, const char *address, int res)
 {
   struct PeerResolutionContext *rc = cls;
 
-  if (address != NULL )
+  if (GNUNET_SYSERR == res)
+  {
+    FPRINTF (stderr, "Failed to convert address for peer `%s' plugin `%s' length %lu to string \n",
+        GNUNET_i2s (&rc->id),
+        rc->addrcp->transport_name,
+        rc->addrcp->address_length);
+    print_info (&rc->id, rc->transport, NULL, rc->state, rc->state_timeout);
+    rc->printed = GNUNET_YES;
+    return;
+  }
+
+  if ((GNUNET_OK == res) && (address != NULL))
   {
     print_info (&rc->id, rc->transport, address, rc->state, rc->state_timeout);
     rc->printed = GNUNET_YES;
+    return; /* Wait for done call */
   }
-  else
+
+  if (NULL == address)
   {
     /* done */
     GNUNET_assert(address_resolutions > 0);
@@ -920,7 +1112,7 @@ process_peer_string (void *cls, const char *address)
       }
       else
       {
-        print_info (&rc->id, rc->transport, "<unable to resolve address>",
+        print_info (&rc->id, rc->transport, NULL,
             rc->state, rc->state_timeout);
       }
     }
@@ -946,11 +1138,13 @@ process_peer_string (void *cls, const char *address)
   }
 }
 
+
 static void
 resolve_peer_address (const struct GNUNET_PeerIdentity *id,
-    const struct GNUNET_HELLO_Address *address, int numeric,
-    enum GNUNET_TRANSPORT_PeerState state,
-    struct GNUNET_TIME_Absolute state_timeout)
+                      const struct GNUNET_HELLO_Address *address,
+                      int numeric,
+                      enum GNUNET_TRANSPORT_PeerState state,
+                      struct GNUNET_TIME_Absolute state_timeout)
 {
   struct PeerResolutionContext *rc;
 
@@ -970,6 +1164,7 @@ resolve_peer_address (const struct GNUNET_PeerIdentity *id,
       RESOLUTION_TIMEOUT, &process_peer_string, rc);
 }
 
+
 /**
  * Function called with information about a peers during a one shot iteration
  *
@@ -979,15 +1174,15 @@ resolve_peer_address (const struct GNUNET_PeerIdentity *id,
  *  NULL on disconnect or when done
  * @param state current state this peer is in
  * @param state_timeout time out for the current state
- *
  */
 static void
-process_peer_iteration_cb (void *cls, const struct GNUNET_PeerIdentity *peer,
-    const struct GNUNET_HELLO_Address *address,
-    enum GNUNET_TRANSPORT_PeerState state,
-    struct GNUNET_TIME_Absolute state_timeout)
+process_peer_iteration_cb (void *cls,
+                           const struct GNUNET_PeerIdentity *peer,
+                           const struct GNUNET_HELLO_Address *address,
+                           enum GNUNET_TRANSPORT_PeerState state,
+                           struct GNUNET_TIME_Absolute state_timeout)
 {
-  if (peer == NULL )
+  if (NULL == peer)
   {
     /* done */
     address_resolution_in_progress = GNUNET_NO;
@@ -998,16 +1193,18 @@ process_peer_iteration_cb (void *cls, const struct GNUNET_PeerIdentity *peer,
     return;
   }
 
-  if ((GNUNET_NO == iterate_all) && (GNUNET_NO == GNUNET_TRANSPORT_is_connected(state)) )
+  if ( (GNUNET_NO == iterate_all) &&
+       (GNUNET_NO == GNUNET_TRANSPORT_is_connected(state)) )
       return; /* Display only connected peers */
 
   if (GNUNET_SCHEDULER_NO_TASK != op_timeout)
     GNUNET_SCHEDULER_cancel (op_timeout);
   op_timeout = GNUNET_SCHEDULER_add_delayed (OP_TIMEOUT, &operation_timeout,
-      NULL );
+                                             NULL);
 
-  GNUNET_log(GNUNET_ERROR_TYPE_DEBUG, "Received address for peer `%s': %s\n",
-      GNUNET_i2s (peer), address->transport_name);
+  GNUNET_log(GNUNET_ERROR_TYPE_DEBUG,
+             "Received address for peer `%s': %s\n",
+             GNUNET_i2s (peer), address->transport_name);
 
   if (NULL != address)
     resolve_peer_address (peer, address, numeric, state, state_timeout);
@@ -1028,28 +1225,26 @@ process_peer_iteration_cb (void *cls, const struct GNUNET_PeerIdentity *peer,
  *
  */
 static void
-process_peer_monitoring_cb (void *cls, const struct GNUNET_PeerIdentity *peer,
-    const struct GNUNET_HELLO_Address *address,
-    enum GNUNET_TRANSPORT_PeerState state,
-    struct GNUNET_TIME_Absolute state_timeout)
+process_peer_monitoring_cb (void *cls,
+                            const struct GNUNET_PeerIdentity *peer,
+                            const struct GNUNET_HELLO_Address *address,
+                            enum GNUNET_TRANSPORT_PeerState state,
+                            struct GNUNET_TIME_Absolute state_timeout)
 {
   struct MonitoredPeer *m;
 
-  if (peer == NULL )
+  if (NULL == peer)
   {
-    /* done */
-    address_resolution_in_progress = GNUNET_NO;
-    pic = NULL;
-    if (GNUNET_SCHEDULER_NO_TASK != end)
-      GNUNET_SCHEDULER_cancel (end);
-    end = GNUNET_SCHEDULER_add_now (&shutdown_task, NULL );
+    FPRINTF (stdout,
+             "%s",
+             _("Monitor disconnected from transport service. Reconnecting.\n"));
     return;
   }
 
   if (GNUNET_SCHEDULER_NO_TASK != op_timeout)
     GNUNET_SCHEDULER_cancel (op_timeout);
   op_timeout = GNUNET_SCHEDULER_add_delayed (OP_TIMEOUT, &operation_timeout,
-      NULL );
+                                             NULL);
 
   if (NULL == (m = GNUNET_CONTAINER_multipeermap_get (monitored_peers, peer)))
   {
@@ -1065,12 +1260,11 @@ process_peer_monitoring_cb (void *cls, const struct GNUNET_PeerIdentity *peer,
     {
       return; /* No real change */
     }
-    if ( ((NULL != address) && (NULL != m->address)) &&
+    if ( (m->state == state) && ((NULL != address) && (NULL != m->address)) &&
         (0 == GNUNET_HELLO_address_cmp(m->address, address)) )
       return; /* No real change */
   }
 
-
   if (NULL != m->address)
   {
     GNUNET_free (m->address);
@@ -1112,6 +1306,31 @@ try_connect_cb (void *cls, const int result)
   }
 }
 
+static void
+try_disconnect_cb (void *cls, const int result)
+{
+  static int retries = 0;
+  if (GNUNET_OK == result)
+  {
+    tc_handle = NULL;
+    return;
+  }
+  retries++;
+  if (retries < 10)
+    tc_handle = GNUNET_TRANSPORT_try_disconnect (handle, &pid, try_disconnect_cb,
+        NULL );
+  else
+  {
+    FPRINTF (stderr, "%s",
+        _("Failed to send connect request to transport service\n") );
+    if (GNUNET_SCHEDULER_NO_TASK != end)
+      GNUNET_SCHEDULER_cancel (end);
+    ret = 1;
+    end = GNUNET_SCHEDULER_add_now (&shutdown_task, NULL );
+    return;
+  }
+}
+
 /**
  * Function called with the result of the check if the 'transport'
  * service is running.
@@ -1141,7 +1360,7 @@ testservice_task (void *cls, int result)
   }
 
   counter = benchmark_send + benchmark_receive + iterate_connections
-      + monitor_connections + monitor_connects + try_connect
+      + monitor_connections + monitor_connects + try_connect + try_disconnect +
       + iterate_validation + monitor_validation;
 
   if (1 < counter)
@@ -1190,6 +1409,36 @@ testservice_task (void *cls, int result)
     op_timeout = GNUNET_SCHEDULER_add_delayed (OP_TIMEOUT, &operation_timeout,
         NULL );
 
+  }
+  else if (try_disconnect) /* -D: Disconnect from peer */
+  {
+    if (NULL == cpid)
+    {
+      FPRINTF (stderr, _("Option `%s' makes no sense without option `%s'.\n"),
+          "-D", "-p");
+      ret = 1;
+      return;
+    }
+    handle = GNUNET_TRANSPORT_connect (cfg, NULL, NULL, &notify_receive,
+        &notify_connect, &notify_disconnect);
+    if (NULL == handle)
+    {
+      FPRINTF (stderr, "%s", _("Failed to connect to transport service\n") );
+      ret = 1;
+      return;
+    }
+    tc_handle = GNUNET_TRANSPORT_try_disconnect (handle, &pid, try_disconnect_cb,
+        NULL );
+    if (NULL == tc_handle)
+    {
+      FPRINTF (stderr, "%s",
+          _("Failed to send request to transport service\n") );
+      ret = 1;
+      return;
+    }
+    op_timeout = GNUNET_SCHEDULER_add_delayed (OP_TIMEOUT, &operation_timeout,
+        NULL );
+
   }
   else if (benchmark_send) /* -s: Benchmark sending */
   {
@@ -1267,7 +1516,8 @@ testservice_task (void *cls, int result)
   {
     monitor_connect_counter = 0;
     handle = GNUNET_TRANSPORT_connect (cfg, NULL, NULL, NULL,
-        &monitor_notify_connect, &monitor_notify_disconnect);
+                                       &monitor_notify_connect,
+                                       &monitor_notify_disconnect);
     if (NULL == handle)
     {
       FPRINTF (stderr, "%s", _("Failed to connect to transport service\n") );
@@ -1320,9 +1570,13 @@ main (int argc, char * const *argv)
               0, &GNUNET_GETOPT_set_one, &iterate_all },
           { 'b', "benchmark", NULL,
               gettext_noop ("measure how fast we are receiving data from all peers (until CTRL-C)"),
-              0, &GNUNET_GETOPT_set_one, &benchmark_receive }, { 'C', "connect",
+              0, &GNUNET_GETOPT_set_one, &benchmark_receive },
+          { 'C', "connect",
               NULL, gettext_noop ("connect to a peer"), 0,
               &GNUNET_GETOPT_set_one, &try_connect },
+          { 'D', "disconnect",
+              NULL, gettext_noop ("disconnect to a peer"), 0,
+              &GNUNET_GETOPT_set_one, &try_disconnect },
           { 'd', "validation", NULL,
               gettext_noop ("print information for all pending validations "),
               0, &GNUNET_GETOPT_set_one, &iterate_validation },