-some minor code cleanup
[oweals/gnunet.git] / src / transport / gnunet-service-transport_validation.c
index 13d48bce2d737539565a9abc9ce025f22af25501..95a7eb04a4678c48ba0cd42960ffaba6ce1db4be 100644 (file)
@@ -1,6 +1,6 @@
 /*
      This file is part of GNUnet.
-     (C) 2010,2011 Christian Grothoff (and other contributing authors)
+     (C) 2010-2013 Christian Grothoff (and other contributing authors)
 
      GNUnet is free software; you can redistribute it and/or modify
      it under the terms of the GNU General Public License as published
 #include "gnunet-service-transport_validation.h"
 #include "gnunet-service-transport_plugins.h"
 #include "gnunet-service-transport_hello.h"
+#include "gnunet-service-transport_blacklist.h"
 #include "gnunet-service-transport.h"
 #include "gnunet_hello_lib.h"
+#include "gnunet_ats_service.h"
 #include "gnunet_peerinfo_service.h"
 #include "gnunet_signatures.h"
 
-// TODO: observe latency between PING/PONG and give information to ATS!
 
 /**
  * How long is a PONG signature valid?  We'll recycle a signature until
 #define HELLO_ADDRESS_EXPIRATION GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_HOURS, 12)
 
 /**
- * How long before an existing address expires should we again try to
- * validate it?  Must be (significantly) smaller than
- * HELLO_ADDRESS_EXPIRATION.
+ * How often do we allow PINGing an address that we have not yet
+ * validated?  This also determines how long we track an address that
+ * we cannot validate (because after this time we can destroy the
+ * validation record).
  */
-#define HELLO_REVALIDATION_START_TIME GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_HOURS, 1)
+#define UNVALIDATED_PING_KEEPALIVE GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_MINUTES, 5)
+
+/**
+ * How often do we PING an address that we have successfully validated
+ * in the past but are not actively using?  Should be (significantly)
+ * smaller than HELLO_ADDRESS_EXPIRATION.
+ */
+#define VALIDATED_PING_FREQUENCY GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_MINUTES, 15)
+
+/**
+ * How often do we PING an address that we are currently using?
+ */
+#define CONNECTED_PING_FREQUENCY GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_MINUTES, 2)
+
+/**
+ * How much delay is acceptable for sending the PING or PONG?
+ */
+#define ACCEPTABLE_PING_DELAY GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_SECONDS, 1)
 
 /**
  * Size of the validation map hashmap.
 
 /**
  * Priority to use for PINGs
- */ 
+ */
 #define PING_PRIORITY 2
 
 /**
  * Priority to use for PONGs
- */ 
+ */
 #define PONG_PRIORITY 4
 
 
+GNUNET_NETWORK_STRUCT_BEGIN
+
 /**
  * Message used to ask a peer to validate receipt (to check an address
  * from a HELLO).  Followed by the address we are trying to validate,
@@ -127,29 +148,19 @@ struct TransportPongMessage
   /**
    * Signature.
    */
-  struct GNUNET_CRYPTO_RsaSignature signature;
+  struct GNUNET_CRYPTO_EccSignature signature;
 
   /**
-   * What are we signing and why?  Two possible reason codes can be here:
    * GNUNET_SIGNATURE_PURPOSE_TRANSPORT_PONG_OWN to confirm that this is a
-   * plausible address for this peer (pid is set to identity of signer); or
-   * GNUNET_SIGNATURE_PURPOSE_TRANSPORT_PONG_USING to confirm that this is
-   * an address we used to connect to the peer with the given pid.
+   * plausible address for the signing peer.
    */
-  struct GNUNET_CRYPTO_RsaSignaturePurpose purpose;
+  struct GNUNET_CRYPTO_EccSignaturePurpose purpose;
 
   /**
    * When does this signature expire?
    */
   struct GNUNET_TIME_AbsoluteNBO expiration;
 
-  /**
-   * Either the identity of the peer Who signed this message, or the
-   * identity of the peer that we're connected to using the given
-   * address (depending on purpose.type).
-   */
-  struct GNUNET_PeerIdentity pid;
-
   /**
    * Size of address appended to this message (part of what is
    * being signed, hence not redundant).
@@ -157,42 +168,51 @@ struct TransportPongMessage
   uint32_t addrlen GNUNET_PACKED;
 
 };
-
+GNUNET_NETWORK_STRUCT_END
 
 /**
  * Information about an address under validation
  */
-struct ValidationEntry 
+struct ValidationEntry
 {
 
   /**
-   * Name of the transport.
+   * The address.
    */
-  char *transport_name;
+  struct GNUNET_HELLO_Address *address;
 
   /**
-   * The address, actually a pointer to the end
-   * of this struct.  Do not free!
+   * Handle to the blacklist check (if we're currently in it).
    */
-  const void *addr;
+  struct GST_BlacklistCheck *bc;
 
   /**
    * Public key of the peer.
    */
-  struct GNUNET_CRYPTO_RsaPublicKeyBinaryEncoded public_key;                                                
+  struct GNUNET_CRYPTO_EccPublicKey public_key;
 
   /**
-   * The identity of the peer.
+   * The identity of the peer. FIXME: duplicated (also in 'address')
    */
   struct GNUNET_PeerIdentity pid;
 
+  /**
+   * Cached PONG signature
+   */
+  struct GNUNET_CRYPTO_EccSignature pong_sig_cache;
+
   /**
    * ID of task that will clean up this entry if nothing happens.
    */
   GNUNET_SCHEDULER_TaskIdentifier timeout_task;
 
   /**
-   * At what time did we send the latest validation request?
+   * ID of task that will trigger address revalidation.
+   */
+  GNUNET_SCHEDULER_TaskIdentifier revalidation_task;
+
+  /**
+   * At what time did we send the latest validation request (PING)?
    */
   struct GNUNET_TIME_Absolute send_time;
 
@@ -202,24 +222,52 @@ struct ValidationEntry
    */
   struct GNUNET_TIME_Absolute valid_until;
 
+  /**
+   * Until when is the cached PONG signature valid?
+   * ZERO if it is not currently considered valid.
+   */
+  struct GNUNET_TIME_Absolute pong_sig_valid_until;
+
   /**
    * How long until we can try to validate this address again?
    * FOREVER if the address is for an unsupported plugin (from PEERINFO)
    * ZERO if the address is considered valid (no validation needed)
    * otherwise a time in the future if we're currently denying re-validation
    */
-  struct GNUNET_TIME_Absolute validation_block;
-                                           
+  struct GNUNET_TIME_Absolute revalidation_block;
+
+  /**
+   * Last observed latency for this address (round-trip), delay between
+   * last PING sent and PONG received; FOREVER if we never got a PONG.
+   */
+  struct GNUNET_TIME_Relative latency;
+
   /**
    * Challenge number we used.
    */
   uint32_t challenge;
 
   /**
-   * Length of addr.
+   * When passing the address in 'add_valid_peer_address', did we
+   * copy the address to the HELLO yet?
    */
-  size_t addrlen;
+  int copied;
 
+  /**
+   * Are we currently using this address for a connection?
+   */
+  int in_use;
+
+  /**
+   * Are we expecting a PONG message for this validation entry?
+   */
+  int expecting_pong;
+
+  /* FIXME: DEBUGGING */
+  int last_line_set_to_no;
+  int last_line_set_to_yes;
+
+  enum GNUNET_ATS_Network_Type network;
 };
 
 
@@ -248,28 +296,6 @@ struct CheckHelloValidatedContext
 };
 
 
-/**
- * Opaque handle to stop incremental validation address callbacks.
- */
-struct GST_ValidationIteratorContext
-{
-  /**
-   * Function to call on each address.
-   */
-  GST_ValidationAddressCallback cb;
-
-  /**
-   * Closure for 'cb'.
-   */
-  void *cb_cls;
-
-  /**
-   * Which peer are we monitoring?
-   */   
-  struct GNUNET_PeerIdentity target;
-};
-
-
 /**
  * Head of linked list of HELLOs awaiting validation.
  */
@@ -288,15 +314,30 @@ static struct CheckHelloValidatedContext *chvc_tail;
 static struct GNUNET_CONTAINER_MultiHashMap *validation_map;
 
 /**
- * Map of PeerIdentities to 'struct GST_ValidationIteratorContext's.
+ * Context for peerinfo iteration.
  */
-static struct GNUNET_CONTAINER_MultiHashMap *notify_map;
+static struct GNUNET_PEERINFO_NotifyContext *pnc;
+
 
 /**
- * Context for peerinfo iteration.
+ * Minimum delay between to validations
  */
-static struct GNUNET_PEERINFO_NotifyContext *pnc;
+static struct GNUNET_TIME_Relative validation_delay;
+
+/**
+ * Number of validations running
+ */
+static unsigned int validations_running;
+
+/**
+ * Validition fast start threshold
+ */
+static unsigned int validations_fast_start_threshold;
 
+/**
+ * When is next validation allowed
+ */
+static struct GNUNET_TIME_Absolute validation_next;
 
 /**
  * Context for the validation entry match function.
@@ -307,21 +348,12 @@ struct ValidationEntryMatchContext
    * Where to store the result?
    */
   struct ValidationEntry *ve;
-  
-  /**
-   * Transport name we're looking for.
-   */
-  const char *transport_name;
 
   /**
    * Address we're interested in.
    */
-  const char *addr;
+  const struct GNUNET_HELLO_Address *address;
 
-  /**
-   * Number of bytes in 'addr'.
-   */
-  size_t addrlen;
 };
 
 
@@ -335,21 +367,303 @@ struct ValidationEntryMatchContext
  *         GNUNET_NO if the entry does match
  */
 static int
-validation_entry_match (void *cls,
-                       const GNUNET_HashCode *key,
-                       void *value)
+validation_entry_match (void *cls, const struct GNUNET_HashCode * key, void *value)
 {
   struct ValidationEntryMatchContext *vemc = cls;
   struct ValidationEntry *ve = value;
 
-  if ( (ve->addrlen == vemc->addrlen) &&
-       (0 == memcmp (ve->addr, vemc->addr, ve->addrlen)) &&
-       (0 == strcmp (ve->transport_name, vemc->transport_name)) )
+  if (0 == GNUNET_HELLO_address_cmp (ve->address, vemc->address))
+  {
+    vemc->ve = ve;
+    return GNUNET_NO;
+  }
+  return GNUNET_YES;
+}
+
+
+/**
+ * Iterate over validation entries and free them.
+ *
+ * @param cls (unused)
+ * @param key peer identity (unused)
+ * @param value a 'struct ValidationEntry' to clean up
+ * @return GNUNET_YES (continue to iterate)
+ */
+static int
+cleanup_validation_entry (void *cls, const struct GNUNET_HashCode * key, void *value)
+{
+  struct ValidationEntry *ve = value;
+
+  if (NULL != ve->bc)
+  {
+    GST_blacklist_test_cancel (ve->bc);
+    ve->bc = NULL;
+  }
+  GNUNET_break (GNUNET_OK ==
+                GNUNET_CONTAINER_multihashmap_remove (validation_map,
+                                                      &ve->pid.hashPubKey, ve));
+  GNUNET_HELLO_address_free (ve->address);
+  if (GNUNET_SCHEDULER_NO_TASK != ve->timeout_task)
+  {
+    GNUNET_SCHEDULER_cancel (ve->timeout_task);
+    ve->timeout_task = GNUNET_SCHEDULER_NO_TASK;
+  }
+  if (GNUNET_SCHEDULER_NO_TASK != ve->revalidation_task)
+  {
+    GNUNET_SCHEDULER_cancel (ve->revalidation_task);
+    ve->revalidation_task = GNUNET_SCHEDULER_NO_TASK;
+  }
+  if ((GNUNET_YES == ve->expecting_pong) &&
+               (validations_running > 0))
+  {
+               validations_running --;
+         GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                     "Validation finished, %u validation processes running\n",
+                     validations_running);
+  }
+  GNUNET_free (ve);
+  return GNUNET_OK;
+}
+
+
+/**
+ * Address validation cleanup task.  Assesses if the record is no
+ * longer valid and then possibly triggers its removal.
+ *
+ * @param cls the 'struct ValidationEntry'
+ * @param tc scheduler context (unused)
+ */
+static void
+timeout_hello_validation (void *cls,
+                          const struct GNUNET_SCHEDULER_TaskContext *tc)
+{
+  struct ValidationEntry *ve = cls;
+  struct GNUNET_TIME_Absolute max;
+  struct GNUNET_TIME_Relative left;
+
+  ve->timeout_task = GNUNET_SCHEDULER_NO_TASK;
+  max = GNUNET_TIME_absolute_max (ve->valid_until, ve->revalidation_block);
+  left = GNUNET_TIME_absolute_get_remaining (max);
+  if (left.rel_value_us > 0)
+  {
+    /* should wait a bit longer */
+    ve->timeout_task =
+        GNUNET_SCHEDULER_add_delayed (left, &timeout_hello_validation, ve);
+    return;
+  }
+  GNUNET_STATISTICS_update (GST_stats,
+                            gettext_noop ("# address records discarded"), 1,
+                            GNUNET_NO);
+  cleanup_validation_entry (NULL, &ve->pid.hashPubKey, ve);
+}
+
+
+/**
+ * Function called with the result from blacklisting.
+ * Send a PING to the other peer if a communication is allowed.
+ *
+ * @param cls our 'struct ValidationEntry'
+ * @param pid identity of the other peer
+ * @param result GNUNET_OK if the connection is allowed, GNUNET_NO if not
+ */
+static void
+transmit_ping_if_allowed (void *cls, const struct GNUNET_PeerIdentity *pid,
+                          int result)
+{
+  struct ValidationEntry *ve = cls;
+  struct TransportPingMessage ping;
+  struct GNUNET_TRANSPORT_PluginFunctions *papi;
+  struct GNUNET_TIME_Absolute next;
+  const struct GNUNET_MessageHeader *hello;
+  enum GNUNET_ATS_Network_Type network;
+  ssize_t ret;
+  size_t tsize;
+  size_t slen;
+  uint16_t hsize;
+
+  ve->bc = NULL;
+
+  if (GNUNET_NO == result)
+  {
+         GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Blacklist denies to send PING to `%s' %s %s\n",
+                     GNUNET_i2s (pid), GST_plugins_a2s (ve->address), ve->address->transport_name);
+               return;
+  }
+
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Transmitting plain PING to `%s' %s %s\n",
+              GNUNET_i2s (pid), GST_plugins_a2s (ve->address), ve->address->transport_name);
+
+  next = GNUNET_TIME_absolute_add (GNUNET_TIME_absolute_get(), validation_delay);
+  if (next.abs_value_us > validation_next.abs_value_us)
+       validation_next = next; /* We're going to send a PING so delay next validation */
+
+  slen = strlen (ve->address->transport_name) + 1;
+  hello = GST_hello_get ();
+  hsize = ntohs (hello->size);
+  tsize =
+      sizeof (struct TransportPingMessage) + ve->address->address_length +
+      slen + hsize;
+
+  ping.header.size =
+      htons (sizeof (struct TransportPingMessage) +
+             ve->address->address_length + slen);
+  ping.header.type = htons (GNUNET_MESSAGE_TYPE_TRANSPORT_PING);
+  ping.challenge = htonl (ve->challenge);
+  ping.target = *pid;
+
+  if (tsize >= GNUNET_SERVER_MAX_MESSAGE_SIZE)
+  {
+    GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+                _
+                ("Not transmitting `%s' with `%s', message too big (%u bytes!). This should not happen.\n"),
+                "HELLO", "PING", (unsigned int) tsize);
+    /* message too big (!?), get rid of HELLO */
+    hsize = 0;
+    tsize =
+        sizeof (struct TransportPingMessage) + ve->address->address_length +
+        slen + hsize;
+  }
+  {
+    char message_buf[tsize];
+
+    /* build message with structure:
+     *  [HELLO][TransportPingMessage][Transport name][Address] */
+    memcpy (message_buf, hello, hsize);
+    memcpy (&message_buf[hsize], &ping, sizeof (struct TransportPingMessage));
+    memcpy (&message_buf[sizeof (struct TransportPingMessage) + hsize],
+            ve->address->transport_name, slen);
+    memcpy (&message_buf[sizeof (struct TransportPingMessage) + slen + hsize],
+            ve->address->address, ve->address->address_length);
+    papi = GST_plugins_find (ve->address->transport_name);
+    if (papi == NULL)
+      ret = -1;
+    else
     {
-      vemc->ve = ve;
-      return GNUNET_NO;
+      GNUNET_assert (papi->send != NULL);
+      GNUNET_assert (papi->get_session != NULL);
+      struct Session * session = papi->get_session(papi->cls, ve->address);
+
+      if (session != NULL)
+      {
+        ret = papi->send (papi->cls, session,
+                          message_buf, tsize,
+                          PING_PRIORITY, ACCEPTABLE_PING_DELAY,
+                          NULL, NULL);
+        network = papi->get_network (ve->address, session);
+        if (GNUNET_ATS_NET_UNSPECIFIED == network)
+        {
+          GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+                                                       "Could not obtain a valid network for `%s' %s\n",
+                      GNUNET_i2s (pid), GST_plugins_a2s (ve->address));
+               GNUNET_break (0);
+        }
+      }
+      else
+      {
+        /* Could not get a valid session */
+        GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Could not get a valid session for `%s' %s\n",
+                    GNUNET_i2s (pid), GST_plugins_a2s (ve->address));
+        ret = -1;
+      }
     }
-  return GNUNET_YES;
+  }
+  if (-1 != ret)
+  {
+    ve->send_time = GNUNET_TIME_absolute_get ();
+    GNUNET_STATISTICS_update (GST_stats,
+                              gettext_noop
+                              ("# PING without HELLO messages sent"), 1,
+                              GNUNET_NO);
+
+    ve->network = network;
+    ve->expecting_pong = GNUNET_YES;
+    validations_running ++;
+         GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                     "Validation started, %u validation processes running\n",
+                     validations_running);
+  }
+}
+
+
+/**
+ * Do address validation again to keep address valid.
+ *
+ * @param cls the 'struct ValidationEntry'
+ * @param tc scheduler context (unused)
+ */
+static void
+revalidate_address (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
+{
+  struct ValidationEntry *ve = cls;
+  struct GNUNET_TIME_Relative canonical_delay;
+  struct GNUNET_TIME_Relative delay;
+  struct GNUNET_TIME_Relative blocked_for;
+  struct GST_BlacklistCheck *bc;
+  uint32_t rdelay;
+
+  ve->revalidation_task = GNUNET_SCHEDULER_NO_TASK;
+  delay = GNUNET_TIME_absolute_get_remaining (ve->revalidation_block);
+  /* How long until we can possibly permit the next PING? */
+  canonical_delay =
+      (ve->in_use ==
+       GNUNET_YES) ? CONNECTED_PING_FREQUENCY
+      : ((GNUNET_TIME_absolute_get_remaining (ve->valid_until).rel_value_us >
+          0) ? VALIDATED_PING_FREQUENCY : UNVALIDATED_PING_KEEPALIVE);
+  if (delay.rel_value_us > canonical_delay.rel_value_us * 2)
+  {
+    /* situation changed, recalculate delay */
+    delay = canonical_delay;
+    ve->revalidation_block = GNUNET_TIME_relative_to_absolute (delay);
+  }
+  if (delay.rel_value_us > 0)
+  {
+    /* should wait a bit longer */
+    ve->revalidation_task =
+        GNUNET_SCHEDULER_add_delayed (delay, &revalidate_address, ve);
+    return;
+  }
+  blocked_for = GNUNET_TIME_absolute_get_remaining(validation_next);
+  if ((validations_running > validations_fast_start_threshold) &&
+               (blocked_for.rel_value_us > 0))
+  {
+    /* Validations are blocked, have to wait for blocked_for time */
+    ve->revalidation_task =
+      GNUNET_SCHEDULER_add_delayed (blocked_for, &revalidate_address, ve);
+    return;
+  }
+  ve->revalidation_block = GNUNET_TIME_relative_to_absolute (canonical_delay);
+
+  /* schedule next PINGing with some extra random delay to avoid synchronous re-validations */
+  rdelay =
+      GNUNET_CRYPTO_random_u32 (GNUNET_CRYPTO_QUALITY_WEAK,
+                                canonical_delay.rel_value_us);
+
+  /* Debug code for mantis 0002726 */
+  if (GNUNET_TIME_UNIT_FOREVER_REL.rel_value_us ==
+      GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_MICROSECONDS, rdelay).rel_value_us)
+  {
+    GNUNET_break (0);
+    delay = canonical_delay;
+  }
+  else
+  {
+    delay = GNUNET_TIME_relative_add (canonical_delay,
+                                     GNUNET_TIME_relative_multiply
+                                     (GNUNET_TIME_UNIT_MICROSECONDS, rdelay));
+  }
+  /* End debug code for mantis 0002726*/
+  ve->revalidation_task =
+      GNUNET_SCHEDULER_add_delayed (delay, &revalidate_address, ve);
+
+  /* start PINGing by checking blacklist */
+  GNUNET_STATISTICS_update (GST_stats,
+                            gettext_noop ("# address revalidations started"), 1,
+                            GNUNET_NO);
+  bc = GST_blacklist_test_allowed (&ve->pid, ve->address->transport_name,
+                                   &transmit_ping_if_allowed, ve);
+  if (NULL != bc)
+    ve->bc = bc;                /* only set 'bc' if 'transmit_ping_if_allowed' was not already
+                                 * called... */
 }
 
 
@@ -359,189 +673,150 @@ validation_entry_match (void *cls,
  * without starting any validation).
  *
  * @param public_key public key of the peer, NULL for unknown
- * @param neighbour which peer we care about
- * @param tname name of the transport plugin
- * @param session session to look for, NULL for 'any'; otherwise
- *        can be used for the service to "learn" this session ID
- *        if 'addr' matches
- * @param addr binary address
- * @param addrlen length of addr
+ * @param address address to find
  * @return validation entry matching the given specifications, NULL
  *         if we don't have an existing entry and no public key was given
  */
 static struct ValidationEntry *
-find_validation_entry (const struct GNUNET_CRYPTO_RsaPublicKeyBinaryEncoded *public_key,
-                      const struct GNUNET_PeerIdentity *neighbour,
-                      const char *tname,
-                      const char *addr,
-                      size_t addrlen)
+find_validation_entry (const struct GNUNET_CRYPTO_EccPublicKey *public_key,
+                      const struct GNUNET_HELLO_Address *address)
 {
   struct ValidationEntryMatchContext vemc;
   struct ValidationEntry *ve;
 
   vemc.ve = NULL;
-  vemc.transport_name = tname;
-  vemc.addr = addr;
-  vemc.addrlen = addrlen;
+  vemc.address = address;
   GNUNET_CONTAINER_multihashmap_get_multiple (validation_map,
-                                             &neighbour->hashPubKey,
-                                             &validation_entry_match,
-                                             &vemc);
+                                              &address->peer.hashPubKey,
+                                              &validation_entry_match, &vemc);
   if (NULL != (ve = vemc.ve))
     return ve;
   if (public_key == NULL)
     return NULL;
-  ve = GNUNET_malloc (sizeof (struct ValidationEntry) + addrlen);
-  ve->transport_name = GNUNET_strdup (tname);
-  ve->addr = (void*) &ve[1];
+  ve = GNUNET_malloc (sizeof (struct ValidationEntry));
+  ve->in_use = GNUNET_SYSERR; /* not defined */
+  ve->last_line_set_to_no  = 0;
+  ve->last_line_set_to_yes  = 0;
+  ve->address = GNUNET_HELLO_address_copy (address);
   ve->public_key = *public_key;
-  ve->pid = *neighbour;
-  ve->challenge = GNUNET_CRYPTO_random_u32 (GNUNET_CRYPTO_QUALITY_NONCE,
-                                           UINT32_MAX);
-  memcpy (&ve[1], addr, addrlen);
-  ve->addrlen = addrlen;
-  GNUNET_CONTAINER_multihashmap_put (validation_map,
-                                    &neighbour->hashPubKey,
-                                    ve,
-                                    GNUNET_CONTAINER_MULTIHASHMAPOPTION_MULTIPLE);
+  ve->pid = address->peer;
+  ve->pong_sig_valid_until = GNUNET_TIME_absolute_get_zero_();
+  memset (&ve->pong_sig_cache, '\0', sizeof (struct GNUNET_CRYPTO_EccSignature));
+  ve->latency = GNUNET_TIME_UNIT_FOREVER_REL;
+  ve->challenge =
+      GNUNET_CRYPTO_random_u32 (GNUNET_CRYPTO_QUALITY_NONCE, UINT32_MAX);
+  ve->timeout_task =
+      GNUNET_SCHEDULER_add_delayed (UNVALIDATED_PING_KEEPALIVE,
+                                    &timeout_hello_validation, ve);
+  GNUNET_CONTAINER_multihashmap_put (validation_map, &address->peer.hashPubKey,
+                                     ve,
+                                     GNUNET_CONTAINER_MULTIHASHMAPOPTION_MULTIPLE);
+  ve->expecting_pong = GNUNET_NO;
   return ve;
 }
 
 
-/**
- * Notify validation watcher that an entry is now valid
- *
- * @param cls 'struct ValidationEntry' that is now valid
- * @param key peer identity (unused)
- * @param value a 'GST_ValidationIteratorContext' to notify
- * @return GNUNET_YES (continue to iterate)
- */
-static int
-notify_valid (void *cls,
-             const GNUNET_HashCode *key,
-             void *value)
-{
-  struct ValidationEntry *ve = cls;
-  struct GST_ValidationIteratorContext *vic = value;
-
-  vic->cb (vic->cb_cls,
-          &ve->public_key,
-          &vic->target,
-          ve->valid_until,
-          ve->validation_block,
-          ve->transport_name,
-          ve->addr,
-          ve->addrlen);           
-  return GNUNET_OK;
-}
-
-
 /**
  * Iterator which adds the given address to the set of validated
  * addresses.
  *
  * @param cls original HELLO message
- * @param tname name of the transport
+ * @param address the address
  * @param expiration expiration time
- * @param addr the address
- * @param addrlen length of the address
  * @return GNUNET_OK (keep the address)
  */
 static int
-add_valid_address (void *cls,
-                  const char *tname,
-                  struct GNUNET_TIME_Absolute expiration,
-                  const void *addr, 
-                  uint16_t addrlen)
+add_valid_address (void *cls, const struct GNUNET_HELLO_Address *address,
+                   struct GNUNET_TIME_Absolute expiration)
 {
   const struct GNUNET_HELLO_Message *hello = cls;
   struct ValidationEntry *ve;
   struct GNUNET_PeerIdentity pid;
-  struct GNUNET_CRYPTO_RsaPublicKeyBinaryEncoded public_key;
-
-  if (GNUNET_TIME_absolute_get_remaining (expiration).rel_value == 0)
-    return GNUNET_OK; /* expired */
-  if ( (GNUNET_OK !=
-       GNUNET_HELLO_get_id (hello, &pid)) ||
-       (GNUNET_OK !=
-       GNUNET_HELLO_get_key (hello, &public_key)) )
-    {
-      GNUNET_break (0);
-      return GNUNET_OK; /* invalid HELLO !? */
-    }
-  ve = find_validation_entry (&public_key, &pid, tname, addr, addrlen);
-  ve->valid_until = GNUNET_TIME_absolute_max (ve->valid_until,
-                                             expiration);
-  GNUNET_CONTAINER_multihashmap_get_multiple (notify_map,
-                                             &pid.hashPubKey,
-                                             &notify_valid,
-                                             ve);
+  struct GNUNET_ATS_Information ats;
+  struct GNUNET_CRYPTO_EccPublicKey public_key;
+
+  if (0 == GNUNET_TIME_absolute_get_remaining (expiration).rel_value_us)
+    return GNUNET_OK;           /* expired */
+  if ((GNUNET_OK != GNUNET_HELLO_get_id (hello, &pid)) ||
+      (GNUNET_OK != GNUNET_HELLO_get_key (hello, &public_key)))
+  {
+    GNUNET_break (0);
+    return GNUNET_OK;           /* invalid HELLO !? */
+  }
+  if (0 == memcmp (&GST_my_identity, &pid, sizeof (struct GNUNET_PeerIdentity)))
+  {
+    /* Peerinfo returned own identity, skip validation */
+    return GNUNET_OK;
+  }
+
+  ve = find_validation_entry (&public_key, address);
+  ve->valid_until = GNUNET_TIME_absolute_max (ve->valid_until, expiration);
+
+  if (GNUNET_SCHEDULER_NO_TASK == ve->revalidation_task)
+    ve->revalidation_task = GNUNET_SCHEDULER_add_now (&revalidate_address, ve);
+
+  ats.type = htonl (GNUNET_ATS_NETWORK_TYPE);
+  ats.value = htonl (ve->network);
+  GNUNET_ATS_address_add (GST_ats, address, NULL, &ats, 1);
+
   return GNUNET_OK;
 }
 
 
 /**
- * Function called for any HELLO known to PEERINFO. 
+ * Function called for any HELLO known to PEERINFO.
  *
  * @param cls unused
  * @param peer id of the peer, NULL for last call
  * @param hello hello message for the peer (can be NULL)
- * @param error message
+ * @param err_msg error message
  */
 static void
-process_peerinfo_hello (void *cls,
-                       const struct GNUNET_PeerIdentity *peer,
-                       const struct GNUNET_HELLO_Message *hello,
-                       const char *err_msg)
+process_peerinfo_hello (void *cls, const struct GNUNET_PeerIdentity *peer,
+                        const struct GNUNET_HELLO_Message *hello,
+                        const char *err_msg)
 {
   GNUNET_assert (NULL != peer);
   if (NULL == hello)
     return;
   GNUNET_assert (NULL ==
-                GNUNET_HELLO_iterate_addresses (hello,
-                                                GNUNET_NO,
-                                                &add_valid_address,
-                                                (void*) hello));  
+                 GNUNET_HELLO_iterate_addresses (hello, GNUNET_NO,
+                                                 &add_valid_address,
+                                                 (void *) hello));
 }
 
 
 /**
  * Start the validation subsystem.
- */
-void 
-GST_validation_start ()
-{
-  validation_map = GNUNET_CONTAINER_multihashmap_create (VALIDATION_MAP_SIZE);
-  notify_map = GNUNET_CONTAINER_multihashmap_create (VALIDATION_MAP_SIZE);
-  pnc = GNUNET_PEERINFO_notify (GST_cfg,
-                               &process_peerinfo_hello,
-                               NULL);
-}
-
-
-/**
- * Iterate over validation entries and free them.
  *
- * @param cls (unused)
- * @param key peer identity (unused)
- * @param value a 'struct ValidationEntry' to clean up
- * @return GNUNET_YES (continue to iterate)
+ * @param max_fds maximum number of fds to use
  */
-static int
-cleanup_validation_entry (void *cls,
-                         const GNUNET_HashCode *key,
-                         void *value)
+void
+GST_validation_start (unsigned int max_fds)
 {
-  struct ValidationEntry *ve = value;
-    
-  GNUNET_free (ve->transport_name);
-  if (GNUNET_SCHEDULER_NO_TASK != ve->timeout_task)
-    {
-      GNUNET_SCHEDULER_cancel (ve->timeout_task);
-      ve->timeout_task = GNUNET_SCHEDULER_NO_TASK;
-    }
-  GNUNET_free (ve);
-  return GNUNET_OK;
+       /**
+        * Initialization for validation throttling
+        *
+        * We have a maximum number max_fds of connections we can use for validation
+        * We monitor the number of validations in parallel and start to throttle it
+        * when doing to many validations in parallel:
+        * if (running validations < (max_fds / 2))
+        * - "fast start": run validation immediately
+        * - have delay of (GNUNET_CONSTANTS_IDLE_CONNECTION_TIMEOUT.rel_value_us) / (max_fds / 2)
+        *   (300 sec / ~150 == ~2 sec.) between two validations
+        */
+
+       validation_next = GNUNET_TIME_absolute_get();
+       validation_delay.rel_value_us = (GNUNET_CONSTANTS_IDLE_CONNECTION_TIMEOUT.rel_value_us) / (max_fds / 2);
+       validations_fast_start_threshold = (max_fds / 2);
+       validations_running = 0;
+       GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Validation uses a fast start threshold of %u connections and a delay between of %s\n ",
+                   validations_fast_start_threshold, 
+                   GNUNET_STRINGS_relative_time_to_string (validation_delay,
+                                                           GNUNET_YES));
+  validation_map = GNUNET_CONTAINER_multihashmap_create (VALIDATION_MAP_SIZE,
+                                                        GNUNET_NO);
+  pnc = GNUNET_PEERINFO_notify (GST_cfg, GNUNET_YES, &process_peerinfo_hello, NULL);
 }
 
 
@@ -554,92 +829,58 @@ GST_validation_stop ()
   struct CheckHelloValidatedContext *chvc;
 
   GNUNET_CONTAINER_multihashmap_iterate (validation_map,
-                                        &cleanup_validation_entry,
-                                        NULL);
+                                         &cleanup_validation_entry, NULL);
   GNUNET_CONTAINER_multihashmap_destroy (validation_map);
   validation_map = NULL;
-  GNUNET_assert (GNUNET_CONTAINER_multihashmap_size (notify_map) == 0);
-  GNUNET_CONTAINER_multihashmap_destroy (notify_map);
-  notify_map = NULL;
   while (NULL != (chvc = chvc_head))
-    {
-      GNUNET_CONTAINER_DLL_remove (chvc_head,
-                                  chvc_tail,
-                                  chvc);
-      GNUNET_free (chvc);
-    }
+  {
+    GNUNET_CONTAINER_DLL_remove (chvc_head, chvc_tail, chvc);
+    GNUNET_free (chvc);
+  }
   GNUNET_PEERINFO_notify_cancel (pnc);
 }
 
 
 /**
- * Address validation cleanup task (record no longer needed).
+ * Send the given PONG to the given address.
  *
- * @param cls the 'struct ValidationEntry'
- * @param tc scheduler context (unused)
- */
-static void
-timeout_hello_validation (void *cls, 
-                         const struct GNUNET_SCHEDULER_TaskContext *tc)
-{
-  struct ValidationEntry *va = cls;
-
-  va->timeout_task = GNUNET_SCHEDULER_NO_TASK;
-  GNUNET_STATISTICS_update (GST_stats,
-                           gettext_noop ("# address records discarded"),
-                           1,
-                           GNUNET_NO);
-  GNUNET_break (GNUNET_OK ==
-                GNUNET_CONTAINER_multihashmap_remove (validation_map,
-                                                     &va->pid.hashPubKey,
-                                                     va));
-  GNUNET_free (va->transport_name);
-  GNUNET_free (va);
-}
-
-
-/**
- * Send the given PONG to the given address.
- *
- * @param cls the PONG message
- * @param public_key public key for the peer, never NULL
- * @param target peer this change is about, never NULL
- * @param valid_until is ZERO if we never validated the address,
- *                    otherwise a time up to when we consider it (or was) valid
- * @param validation_block  is FOREVER if the address is for an unsupported plugin (from PEERINFO)
- *                          is ZERO if the address is considered valid (no validation needed)
- *                          otherwise a time in the future if we're currently denying re-validation
- * @param plugin_name name of the plugin
- * @param plugin_address binary address
- * @param plugin_address_len length of address
+ * @param cls the PONG message
+ * @param public_key public key for the peer, never NULL
+ * @param valid_until is ZERO if we never validated the address,
+ *                    otherwise a time up to when we consider it (or was) valid
+ * @param validation_block  is FOREVER if the address is for an unsupported plugin (from PEERINFO)
+ *                          is ZERO if the address is considered valid (no validation needed)
+ *                          otherwise a time in the future if we're currently denying re-validation
+ * @param address target address
  */
 static void
 multicast_pong (void *cls,
-               const struct GNUNET_CRYPTO_RsaPublicKeyBinaryEncoded *public_key,
-               const struct GNUNET_PeerIdentity *target,
+                const struct GNUNET_CRYPTO_EccPublicKey *public_key, 
                struct GNUNET_TIME_Absolute valid_until,
-               struct GNUNET_TIME_Absolute validation_block,
-               const char *plugin_name,
-               const void *plugin_address,
-               size_t plugin_address_len)
+                struct GNUNET_TIME_Absolute validation_block,
+                const struct GNUNET_HELLO_Address *address)
 {
   struct TransportPongMessage *pong = cls;
   struct GNUNET_TRANSPORT_PluginFunctions *papi;
 
-  papi = GST_plugins_find (plugin_name);
+  papi = GST_plugins_find (address->transport_name);
   if (papi == NULL)
     return;
-  (void) papi->send (papi->cls,
-                    target,
-                    (const char*) pong,
-                    ntohs (pong->header.size),
-                    PONG_PRIORITY,
-                    HELLO_REVALIDATION_START_TIME,
-                    NULL,
-                    plugin_address,
-                    plugin_address_len,
-                    GNUNET_YES,
-                    NULL, NULL);
+
+  GNUNET_assert (papi->send != NULL);
+  GNUNET_assert (papi->get_session != NULL);
+
+  struct Session * session = papi->get_session(papi->cls, address);
+  if (session == NULL)
+  {
+     GNUNET_break (0);
+     return;
+  }
+
+  papi->send (papi->cls, session,
+              (const char *) pong, ntohs (pong->header.size),
+              PONG_PRIORITY, ACCEPTABLE_PING_DELAY,
+              NULL, NULL);
 }
 
 
@@ -648,163 +889,241 @@ multicast_pong (void *cls,
  *
  * @param sender peer sending the PING
  * @param hdr the PING
+ * @param sender_address the sender address as we got it
  * @param session session we got the PING from
- * @param plugin_name name of plugin that received the PING
- * @param sender_address address of the sender as known to the plugin, NULL
- *                       if we did not initiate the connection
- * @param sender_address_len number of bytes in sender_address
  */
 void
 GST_validation_handle_ping (const struct GNUNET_PeerIdentity *sender,
-                           const struct GNUNET_MessageHeader *hdr,
-                           const char *plugin_name,
-                           struct Session *session,
-                           const void *sender_address,
-                           size_t sender_address_len)
+                            const struct GNUNET_MessageHeader *hdr,
+                            const struct GNUNET_HELLO_Address *sender_address,
+                            struct Session *session)
 {
-
   const struct TransportPingMessage *ping;
   struct TransportPongMessage *pong;
   struct GNUNET_TRANSPORT_PluginFunctions *papi;
-  struct GNUNET_CRYPTO_RsaSignature *sig_cache;
+  struct GNUNET_CRYPTO_EccSignature *sig_cache;
   struct GNUNET_TIME_Absolute *sig_cache_exp;
   const char *addr;
   const char *addrend;
+  char *plugin_name;
+  char *pos;
   size_t alen;
   size_t slen;
   ssize_t ret;
+  int buggy = GNUNET_NO;
+  struct GNUNET_HELLO_Address address;
 
   if (ntohs (hdr->size) < sizeof (struct TransportPingMessage))
-    {
-      GNUNET_break_op (0);
-      return;
-    }
+  {
+    GNUNET_break_op (0);
+    return;
+  }
   ping = (const struct TransportPingMessage *) hdr;
-  if (0 != memcmp (&ping->target,
-                   &GST_my_identity,
-                   sizeof (struct GNUNET_PeerIdentity)))
-    {
-      GNUNET_break_op (0);
-      return;
-    }
-#if DEBUG_TRANSPORT
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG | GNUNET_ERROR_TYPE_BULK,
-             "Processing `%s' from `%s'\n",
-             "PING",
-             (sender_address != NULL)
-             ? GST_plugin_a2s (plugin_name,
-                               sender_address,
-                               sender_address_len)
-             : "<inbound>");
-#endif
+  if (0 !=
+      memcmp (&ping->target, &GST_my_identity,
+              sizeof (struct GNUNET_PeerIdentity)))
+  {
+    GNUNET_STATISTICS_update (GST_stats,
+                              gettext_noop
+                              ("# PING message for different peer received"), 1,
+                              GNUNET_NO);
+    return;
+  }
   GNUNET_STATISTICS_update (GST_stats,
-                           gettext_noop ("# PING messages received"),
-                           1,
-                           GNUNET_NO);
-  addr = (const char*) &ping[1];
+                            gettext_noop ("# PING messages received"), 1,
+                            GNUNET_NO);
+  addr = (const char *) &ping[1];
   alen = ntohs (hdr->size) - sizeof (struct TransportPingMessage);
   /* peer wants to confirm that this is one of our addresses, this is what is
-     used for address validation */
-  
-  addrend = memchr (addr, '\0', alen);
-  if (NULL == addrend)
+   * used for address validation */
+
+  sig_cache = NULL;
+  sig_cache_exp = NULL;
+  papi = NULL;
+  if (alen > 0)
+  {
+    addrend = memchr (addr, '\0', alen);
+    if (NULL == addrend)
     {
       GNUNET_break_op (0);
       return;
     }
-  addrend++;
-  slen = strlen(addr);
-  alen -= slen;
-  
-  if (GNUNET_YES !=
-      GST_hello_test_address (addr,
-                             addrend,
-                             alen,
-                             &sig_cache,
-                             &sig_cache_exp))
+    addrend++;
+    slen = strlen (addr) + 1;
+    alen -= slen;
+    address.address = addrend;
+    address.address_length = alen;
+    address.transport_name = addr;
+    address.peer = GST_my_identity;
+
+    if (NULL == address.transport_name)
     {
-      GNUNET_log (GNUNET_ERROR_TYPE_INFO,
-                 _("Not confirming PING with address `%s' since I cannot confirm having this address.\n"),
-                 GST_plugins_a2s (addr,
-                                  addrend,
-                                  alen));
+       GNUNET_break (0);
+    }
+
+    if (0 != strstr (address.transport_name, "_client"))
+               {
+       plugin_name = GNUNET_strdup (address.transport_name);
+       pos = strstr (plugin_name, "_client");
+       GNUNET_assert (NULL != pos);
+       GNUNET_snprintf (pos, strlen ("_server") + 1, "%s", "_server");
+               }
+    else
+       plugin_name = GNUNET_strdup (address.transport_name);
+
+    if (NULL == (papi = GST_plugins_find (plugin_name)))
+    {
+      /* we don't have the plugin for this address */
+      GNUNET_log (GNUNET_ERROR_TYPE_ERROR, "Plugin `%s' not available, cannot confirm having this address \n",
+               plugin_name);
+      GNUNET_free (plugin_name);
       return;
     }
-  
+    GNUNET_free (plugin_name);
+    if (GNUNET_OK != papi->check_address (papi->cls, addrend, alen))
+               {
+      GNUNET_STATISTICS_update (GST_stats,
+                                gettext_noop
+                                ("# failed address checks during validation"), 1,
+                                GNUNET_NO);
+       GNUNET_log (GNUNET_ERROR_TYPE_ERROR, "Address `%s' is not one of my addresses, not confirming PING\n",
+               GST_plugins_a2s (&address));
+       return;
+               }
+    else
+    {
+      GNUNET_STATISTICS_update (GST_stats,
+                                gettext_noop
+                                ("# successful address checks during validation"), 1,
+                                GNUNET_NO);
+       GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Address `%s' is one of my addresses, confirming PING\n",
+                       GST_plugins_a2s (&address));
+    }
+
+    if (GNUNET_YES != GST_hello_test_address (&address, &sig_cache, &sig_cache_exp))
+    {
+      if (GNUNET_NO == buggy)
+      {
+        GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                    "Not confirming PING from peer `%s' with address `%s' since I cannot confirm having this address.\n",
+                    GNUNET_i2s (sender),
+                    GST_plugins_a2s (&address));
+        return;
+      }
+      else
+      {
+        GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                    _("Received a PING message with validation bug from `%s'\n"),
+                    GNUNET_i2s (sender));
+      }
+    }
+  }
+  else
+  {
+    addrend = NULL;             /* make gcc happy */
+    slen = 0;
+    static struct GNUNET_CRYPTO_EccSignature no_address_signature;
+    static struct GNUNET_TIME_Absolute no_address_signature_expiration;
+
+    sig_cache = &no_address_signature;
+    sig_cache_exp = &no_address_signature_expiration;
+  }
+
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+              "I am `%s', sending PONG to peer `%s'\n",
+             GNUNET_h2s (&GST_my_identity.hashPubKey),
+              GNUNET_i2s (sender));
+
+  /* message with structure:
+   * [TransportPongMessage][Transport name][Address] */
+
   pong = GNUNET_malloc (sizeof (struct TransportPongMessage) + alen + slen);
-  pong->header.size = htons (sizeof (struct TransportPongMessage) + alen + slen);
+  pong->header.size =
+      htons (sizeof (struct TransportPongMessage) + alen + slen);
   pong->header.type = htons (GNUNET_MESSAGE_TYPE_TRANSPORT_PONG);
   pong->purpose.size =
-    htonl (sizeof (struct GNUNET_CRYPTO_RsaSignaturePurpose) +
-          sizeof (uint32_t) +
-          sizeof (struct GNUNET_TIME_AbsoluteNBO) +
-          sizeof (struct GNUNET_PeerIdentity) + alen + slen);
+      htonl (sizeof (struct GNUNET_CRYPTO_EccSignaturePurpose) +
+             sizeof (uint32_t) + sizeof (struct GNUNET_TIME_AbsoluteNBO) +
+             alen + slen);
   pong->purpose.purpose = htonl (GNUNET_SIGNATURE_PURPOSE_TRANSPORT_PONG_OWN);
-  pong->challenge = ping->challenge;
-  pong->addrlen = htonl(alen + slen);
-  pong->pid = GST_my_identity;
-  memcpy (&pong[1], addr, slen);
-  memcpy (&((char*)&pong[1])[slen], addrend, alen);
-  if (GNUNET_TIME_absolute_get_remaining (*sig_cache_exp).rel_value < PONG_SIGNATURE_LIFETIME.rel_value / 4)
+  memcpy (&pong->challenge, &ping->challenge, sizeof (ping->challenge));
+  pong->addrlen = htonl (alen + slen);
+  memcpy (&pong[1], addr, slen);   /* Copy transport plugin */
+  if (alen > 0)
+  {
+    GNUNET_assert (NULL != addrend);
+    memcpy (&((char *) &pong[1])[slen], addrend, alen);
+  }
+  if (GNUNET_TIME_absolute_get_remaining (*sig_cache_exp).rel_value_us <
+      PONG_SIGNATURE_LIFETIME.rel_value_us / 4)
+  {
+    /* create / update cached sig */
+    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+               "Creating PONG signature to indicate ownership.\n");
+    *sig_cache_exp = GNUNET_TIME_relative_to_absolute (PONG_SIGNATURE_LIFETIME);
+    pong->expiration = GNUNET_TIME_absolute_hton (*sig_cache_exp);
+    if (GNUNET_OK !=
+                  GNUNET_CRYPTO_ecc_sign (GST_my_private_key, &pong->purpose,
+                                          sig_cache))
     {
-      /* create / update cached sig */
-#if DEBUG_TRANSPORT
-      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                 "Creating PONG signature to indicate ownership.\n");
-#endif
-      *sig_cache_exp = GNUNET_TIME_relative_to_absolute (PONG_SIGNATURE_LIFETIME);
-      pong->expiration = GNUNET_TIME_absolute_hton (*sig_cache_exp);
-      GNUNET_assert (GNUNET_OK ==
-                    GNUNET_CRYPTO_rsa_sign (GST_my_private_key,
-                                            &pong->purpose,
-                                            sig_cache));
+        GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+               _("Failed to create PONG signature for peer `%s'\n"), GNUNET_i2s (sender));
     }
+  }
   else
-    {
-      pong->expiration = GNUNET_TIME_absolute_hton (*sig_cache_exp);
-    }
+  {
+    pong->expiration = GNUNET_TIME_absolute_hton (*sig_cache_exp);
+  }
   pong->signature = *sig_cache;
+  
+  GNUNET_assert (sender_address != NULL);
 
   /* first see if the session we got this PING from can be used to transmit
-     a response reliably */
-  papi = GST_plugins_find (plugin_name);
+   * a response reliably */
   if (papi == NULL)
     ret = -1;
   else
-    ret = papi->send (papi->cls,
-                     sender,
-                     (const char*) pong,
-                     ntohs (pong->header.size),
-                     PONG_PRIORITY,
-                     HELLO_REVALIDATION_START_TIME,
-                     session,
-                     sender_address,
-                     sender_address_len,
-                     GNUNET_SYSERR,
-                     NULL, NULL);
-  if (ret != -1)
+  {
+    GNUNET_assert (papi->send != NULL);
+    GNUNET_assert (papi->get_session != NULL);
+
+    if (session == NULL)
     {
-      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                 "Transmitted PONG to `%s' via reliable mechanism\n",
-                 GNUNET_i2s (sender));
-      /* done! */
-      GNUNET_STATISTICS_update (GST_stats,
-                               gettext_noop ("# PONGs unicast via reliable transport"),
-                               1,
-                               GNUNET_NO);
-      GNUNET_free (pong);
-      return;
+      session = papi->get_session (papi->cls, sender_address);
     }
-  
+    if (session == NULL)
+    {
+      GNUNET_break (0);
+      ret = -1;
+    }
+    else
+    {
+      ret = papi->send (papi->cls, session,
+                        (const char *) pong, ntohs (pong->header.size),
+                        PONG_PRIORITY, ACCEPTABLE_PING_DELAY,
+                        NULL, NULL);
+    }
+  }
+  if (ret != -1)
+  {
+    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                "Transmitted PONG to `%s' via reliable mechanism\n",
+                GNUNET_i2s (sender));
+    /* done! */
+    GNUNET_STATISTICS_update (GST_stats,
+                              gettext_noop
+                              ("# PONGs unicast via reliable transport"), 1,
+                              GNUNET_NO);
+    GNUNET_free (pong);
+    return;
+  }
+
   /* no reliable method found, try transmission via all known addresses */
   GNUNET_STATISTICS_update (GST_stats,
-                           gettext_noop ("# PONGs multicast to all available addresses"),
-                           1,
-                           GNUNET_NO);
-  (void) GST_validation_get_addresses (sender,
-                                      GNUNET_YES,
-                                      &multicast_pong,
-                                      pong);
+                            gettext_noop
+                            ("# PONGs multicast to all available addresses"), 1,
+                            GNUNET_NO);
+  GST_validation_get_addresses (sender, &multicast_pong, pong);
   GNUNET_free (pong);
 }
 
@@ -816,13 +1135,13 @@ struct ValidateAddressContext
 {
   /**
    * Hash of the public key of the peer whose address is being validated.
-   */ 
+   */
   struct GNUNET_PeerIdentity pid;
 
   /**
    * Public key of the peer whose address is being validated.
    */
-  struct GNUNET_CRYPTO_RsaPublicKeyBinaryEncoded public_key;
+  struct GNUNET_CRYPTO_EccPublicKey public_key;
 };
 
 
@@ -831,164 +1150,45 @@ struct ValidateAddressContext
  * (unless blocked or already validated).
  *
  * @param cls pointer to a 'struct ValidateAddressContext'
- * @param tname name of the transport
+ * @param address the address
  * @param expiration expiration time
- * @param addr the address
- * @param addrlen length of the address
  * @return GNUNET_OK (keep the address)
  */
 static int
-validate_address (void *cls,
-                 const char *tname,
-                 struct GNUNET_TIME_Absolute expiration,
-                 const void *addr, 
-                 uint16_t addrlen)
+validate_address_iterator (void *cls,
+                           const struct GNUNET_HELLO_Address *address,
+                           struct GNUNET_TIME_Absolute expiration)
 {
   const struct ValidateAddressContext *vac = cls;
-  const struct GNUNET_PeerIdentity *pid = &vac->pid;
   struct ValidationEntry *ve;
-  struct TransportPingMessage ping;
-  struct GNUNET_TRANSPORT_PluginFunctions *papi;
-  const struct GNUNET_MessageHeader *hello;
-  ssize_t ret;
-  size_t tsize;
-  size_t slen;
-  uint16_t hsize;
 
-  if (GNUNET_TIME_absolute_get_remaining (expiration).rel_value == 0)
-    return GNUNET_OK; /* expired */
-  ve = find_validation_entry (&vac->public_key, pid, tname, addr, addrlen);
-  if (GNUNET_TIME_absolute_get_remaining (ve->validation_block).rel_value > 0)
-    return GNUNET_OK; /* blocked */
-  if ( (GNUNET_SCHEDULER_NO_TASK != ve->timeout_task) &&
-       (GNUNET_TIME_absolute_get_remaining (ve->valid_until).rel_value > 0) )
-    return GNUNET_OK; /* revalidation task already scheduled & still  valid */
-  ve->validation_block = GNUNET_TIME_relative_to_absolute (HELLO_REVALIDATION_START_TIME);
-  if (GNUNET_SCHEDULER_NO_TASK != ve->timeout_task)
-    GNUNET_SCHEDULER_cancel (ve->timeout_task);
-  ve->timeout_task = GNUNET_SCHEDULER_add_delayed (HELLO_REVALIDATION_START_TIME,
-                                                  &timeout_hello_validation,
-                                                  ve);
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-             "Transmitting plain PING to `%s'\n",
-             GNUNET_i2s (pid));  
-  ping.header.size = htons(sizeof(struct TransportPingMessage));
-  ping.header.type = htons(GNUNET_MESSAGE_TYPE_TRANSPORT_PING);
-  ping.challenge = htonl(ve->challenge);
-  ping.target = *pid;
-  
-  slen = strlen(ve->transport_name) + 1;
-  hello = GST_hello_get ();
-  hsize = ntohs (hello->size);
-  tsize = sizeof(struct TransportPingMessage) + ve->addrlen + slen + hsize;
-  if (tsize >= GNUNET_SERVER_MAX_MESSAGE_SIZE)
-    {
-      GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
-                 _("Not transmitting `%s' with `%s', message too big (%u bytes!). This should not happen.\n"),
-                 "HELLO",
-                 "PING",
-                 (unsigned int) tsize);
-      /* message too big (!?), get rid of HELLO */
-      hsize = 0;
-      tsize = sizeof(struct TransportPingMessage) + ve->addrlen + slen + hsize;
-    }
-  {
-    char message_buf[tsize];
-
-    memcpy(message_buf, hello, hsize);
-    memcpy(&message_buf[hsize], &ping, sizeof (struct TransportPingMessage));
-    memcpy(&message_buf[sizeof (struct TransportPingMessage) + hsize],
-          ve->transport_name,
-          slen);
-    memcpy(&message_buf[sizeof (struct TransportPingMessage) + slen + hsize],
-          ve->addr,
-          ve->addrlen);
-    papi = GST_plugins_find (ve->transport_name);
-    if (papi == NULL)
-      ret = -1;
-    else
-      ret = papi->send (papi->cls,
-                       pid,
-                       message_buf,
-                       tsize,
-                       PING_PRIORITY,
-                       HELLO_REVALIDATION_START_TIME,
-                       NULL /* no session */,
-                       ve->addr,
-                       ve->addrlen,
-                       GNUNET_YES,
-                       NULL, NULL);
-  }
-  if (-1 != ret)
-    {
-      ve->send_time = GNUNET_TIME_absolute_get ();
-      GNUNET_STATISTICS_update (GST_stats,
-                               gettext_noop ("# PING without HELLO messages sent"),
-                               1,
-                               GNUNET_NO);
-    }
+  if (0 == GNUNET_TIME_absolute_get_remaining (expiration).rel_value_us)
+    return GNUNET_OK;           /* expired */
+  ve = find_validation_entry (&vac->public_key, address);
+  if (GNUNET_SCHEDULER_NO_TASK == ve->revalidation_task)
+    ve->revalidation_task = GNUNET_SCHEDULER_add_now (&revalidate_address, ve);
   return GNUNET_OK;
 }
 
 
-/**
- * Do address validation again to keep address valid.
- *
- * @param cls the 'struct ValidationEntry'
- * @param tc scheduler context (unused)
- */
-static void
-revalidate_address (void *cls, 
-                   const struct GNUNET_SCHEDULER_TaskContext *tc)
-{
-  struct ValidationEntry *ve = cls;
-  struct GNUNET_TIME_Relative delay;
-  struct ValidateAddressContext vac;
-
-  ve->timeout_task = GNUNET_SCHEDULER_NO_TASK;
-  delay = GNUNET_TIME_absolute_get_remaining (ve->validation_block);
-  if (delay.rel_value > 0)
-    {
-      /* should wait a bit longer */
-      ve->timeout_task = GNUNET_SCHEDULER_add_delayed (delay,
-                                                      &revalidate_address,
-                                                      ve);
-      return;
-    }
-  GNUNET_STATISTICS_update (GST_stats,
-                           gettext_noop ("# address revalidations started"),
-                           1,
-                           GNUNET_NO);
-  vac.pid = ve->pid;
-  vac.public_key = ve->public_key;
-  validate_address (&vac,
-                   ve->transport_name,
-                   ve->valid_until,
-                   ve->addr,
-                   (uint16_t) ve->addrlen);
-}
-
-
 /**
  * Add the validated peer address to the HELLO.
  *
  * @param cls the 'struct ValidationEntry' with the validated address
  * @param max space in buf
  * @param buf where to add the address
+ * @return number of bytes written, 0 to signal the
+ *         end of the iteration.
  */
 static size_t
-add_valid_peer_address (void *cls,
-                       size_t max,
-                       void *buf)
+add_valid_peer_address (void *cls, size_t max, void *buf)
 {
   struct ValidationEntry *ve = cls;
 
-  return GNUNET_HELLO_add_address (ve->transport_name,
-                                  ve->valid_until,
-                                  ve->addr,
-                                  ve->addrlen,
-                                  buf,
-                                  max);
+  if (GNUNET_YES == ve->copied)
+    return 0;                   /* terminate */
+  ve->copied = GNUNET_YES;
+  return GNUNET_HELLO_add_address (ve->address, ve->valid_until, buf, max);
 }
 
 
@@ -998,121 +1198,142 @@ add_valid_peer_address (void *cls,
  *
  * @param sender peer sending the PONG
  * @param hdr the PONG
- * @param plugin_name name of plugin that received the PONG
- * @param sender_address address of the sender as known to the plugin, NULL
- *                       if we did not initiate the connection
- * @param sender_address_len number of bytes in sender_address
  */
 void
 GST_validation_handle_pong (const struct GNUNET_PeerIdentity *sender,
-                           const struct GNUNET_MessageHeader *hdr,
-                           const char *plugin_name,
-                           const void *sender_address,
-                           size_t sender_address_len)
+                            const struct GNUNET_MessageHeader *hdr)
 {
   const struct TransportPongMessage *pong;
   struct ValidationEntry *ve;
+  const char *tname;
   const char *addr;
-  const char *addrend;
-  size_t alen;
+  size_t addrlen;
   size_t slen;
-  uint32_t rdelay;
-  struct GNUNET_TIME_Relative delay;
+  size_t size;
   struct GNUNET_HELLO_Message *hello;
+  struct GNUNET_HELLO_Address address;
+  int sig_res;
+  int do_verify;
 
   if (ntohs (hdr->size) < sizeof (struct TransportPongMessage))
-    {
-      GNUNET_break_op (0);
-      return;
-    }
+  {
+    GNUNET_break_op (0);
+    return;
+  }
   GNUNET_STATISTICS_update (GST_stats,
-                           gettext_noop ("# PONG messages received"),
-                           1,
-                           GNUNET_NO);
+                            gettext_noop ("# PONG messages received"), 1,
+                            GNUNET_NO);
+
+  /* message with structure:
+   * [TransportPongMessage][Transport name][Address] */
+
   pong = (const struct TransportPongMessage *) hdr;
-  if (0 != memcmp (&pong->pid,
-                   sender,
-                   sizeof (struct GNUNET_PeerIdentity)))
-    {
-      GNUNET_break_op (0);
-      return;
-    }
-#if DEBUG_TRANSPORT
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG | GNUNET_ERROR_TYPE_BULK,
-             "Processing `%s' from `%s'\n",
-             "PONG",
-             (sender_address != NULL)
-             ? GST_plugin_a2s (plugin_name,
-                               sender_address,
-                               sender_address_len)
-             : "<inbound>");
-#endif
-  addr = (const char*) &pong[1];
-  alen = ntohs (hdr->size) - sizeof (struct TransportPongMessage);
-  addrend = memchr (addr, '\0', alen);
-  if (NULL == addrend)
-    {
-      GNUNET_break_op (0);
-      return;
-    }
-  addrend++;
-  slen = strlen(addr);
-  alen -= slen;
-  ve = find_validation_entry (NULL,
-                             sender,
-                             addr,
-                             addrend,
-                             alen);
-  if (NULL == ve)
-    {
-      GNUNET_STATISTICS_update (GST_stats,
-                               gettext_noop ("# PONGs dropped, no matching pending validation"),
-                               1,
-                               GNUNET_NO);
-      return;
-    }
+  tname = (const char *) &pong[1];
+  size = ntohs (hdr->size) - sizeof (struct TransportPongMessage);
+  addr = memchr (tname, '\0', size);
+  if (NULL == addr)
+  {
+    GNUNET_break_op (0);
+    return;
+  }
+  addr++;
+  slen = strlen (tname) + 1;
+  addrlen = size - slen;
+  address.peer = *sender;
+  address.address = addr;
+  address.address_length = addrlen;
+  address.transport_name = tname;
+  ve = find_validation_entry (NULL, &address);
+  if ((NULL == ve) || (GNUNET_NO == ve->expecting_pong))
+  {
+    GNUNET_STATISTICS_update (GST_stats,
+                              gettext_noop
+                              ("# PONGs dropped, no matching pending validation"),
+                              1, GNUNET_NO);
+    return;
+  }
   /* now check that PONG is well-formed */
-  if (GNUNET_TIME_absolute_get_remaining (GNUNET_TIME_absolute_ntoh (pong->expiration)).rel_value == 0)
-    {
-      GNUNET_STATISTICS_update (GST_stats,
-                               gettext_noop ("# PONGs dropped, signature expired"),
-                               1,
-                               GNUNET_NO);
-      return;
-    }
-  if (GNUNET_OK !=
-      GNUNET_CRYPTO_rsa_verify (GNUNET_SIGNATURE_PURPOSE_TRANSPORT_PONG_OWN,
-                               &pong->purpose,
-                               &pong->signature,
-                               &ve->public_key))
-    {
-      GNUNET_break_op (0);
-      return;
-    }
-  
+  if (0 != memcmp (&ve->pid, sender, sizeof (struct GNUNET_PeerIdentity)))
+  {
+    GNUNET_break_op (0);
+    return;
+  }
+  if (GNUNET_TIME_absolute_get_remaining
+      (GNUNET_TIME_absolute_ntoh (pong->expiration)).rel_value_us == 0)
+  {
+    GNUNET_STATISTICS_update (GST_stats,
+                              gettext_noop
+                              ("# PONGs dropped, signature expired"), 1,
+                              GNUNET_NO);
+    return;
+  }
+
+  sig_res = GNUNET_SYSERR;
+  do_verify = GNUNET_YES;
+  if (0 != GNUNET_TIME_absolute_get_remaining(ve->pong_sig_valid_until).rel_value_us)
+  {
+               /* We have a cached and valid signature for this peer,
+                * try to compare instead of verify */
+               if (0 == memcmp (&ve->pong_sig_cache, &pong->signature, sizeof (struct GNUNET_CRYPTO_EccSignature)))
+               {
+                       /* signatures are identical, we can skip verification */
+                       sig_res = GNUNET_OK;
+                       do_verify = GNUNET_NO;
+               }
+               else
+               {
+                       sig_res = GNUNET_SYSERR;
+                       /* signatures do not match, we have to verify */
+               }
+  }
+
+  if (GNUNET_YES == do_verify)
+  {
+                       /* Do expensive verification */
+               sig_res = GNUNET_CRYPTO_ecc_verify (GNUNET_SIGNATURE_PURPOSE_TRANSPORT_PONG_OWN,
+                                &pong->purpose, &pong->signature,
+                                &ve->public_key);
+               if (sig_res == GNUNET_SYSERR)
+                       GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
+                                       "Failed to verify: invalid signature on address %s:%s from peer `%s'\n",
+                                       tname, GST_plugins_a2s (ve->address),GNUNET_i2s (sender));
+  }
+
+  if (sig_res == GNUNET_SYSERR)
+    return;
+
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+              "Address validated for peer `%s' with plugin `%s': `%s'\n",
+              GNUNET_i2s (sender), tname, GST_plugins_a2s (ve->address));
   /* validity achieved, remember it! */
+  ve->expecting_pong = GNUNET_NO;
   ve->valid_until = GNUNET_TIME_relative_to_absolute (HELLO_ADDRESS_EXPIRATION);
+  ve->pong_sig_cache = pong->signature;
+       ve->pong_sig_valid_until = GNUNET_TIME_absolute_ntoh (pong->expiration);
+  ve->latency = GNUNET_TIME_absolute_get_duration (ve->send_time);
+  {
+    struct GNUNET_ATS_Information ats[2];
+    ats[0].type = htonl (GNUNET_ATS_QUALITY_NET_DELAY);
+    ats[0].value = htonl ((uint32_t) ve->latency.rel_value_us);
+    ats[1].type = htonl (GNUNET_ATS_NETWORK_TYPE);
+    ats[1].value = htonl ((uint32_t) ve->network);
+    GNUNET_ATS_address_add (GST_ats, ve->address, NULL, ats, 2);
+  }
+  if (validations_running > 0)
+  {
+       validations_running --;
+         GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                     "Validation finished, %u validation processes running\n",
+                     validations_running);
+  }
+  else
+       GNUNET_break (0);
 
   /* build HELLO to store in PEERINFO */
-  hello = GNUNET_HELLO_create (&ve->public_key,
-                              &add_valid_peer_address,
-                              ve);
-  GNUNET_PEERINFO_add_peer (GST_peerinfo,
-                           hello);
+  ve->copied = GNUNET_NO;
+  hello = GNUNET_HELLO_create (&ve->public_key, &add_valid_peer_address, ve, GNUNET_NO);
+  GNUNET_PEERINFO_add_peer (GST_peerinfo, hello, NULL, NULL);
   GNUNET_free (hello);
-
-  if (GNUNET_SCHEDULER_NO_TASK != ve->timeout_task)
-    GNUNET_SCHEDULER_cancel (ve->timeout_task);
-
-  /* randomly delay by up to 1h to avoid synchronous validations */
-  rdelay = GNUNET_CRYPTO_random_u32 (GNUNET_CRYPTO_QUALITY_WEAK,
-                                    60 * 60);
-  delay = GNUNET_TIME_relative_add (HELLO_REVALIDATION_START_TIME,
-                                   GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_SECONDS,
-                                                                  rdelay));
-  ve->timeout_task = GNUNET_SCHEDULER_add_delayed (delay,
-                                                  &revalidate_address,
-                                                  ve);
 }
 
 
@@ -1125,26 +1346,58 @@ GST_validation_handle_pong (const struct GNUNET_PeerIdentity *sender,
 void
 GST_validation_handle_hello (const struct GNUNET_MessageHeader *hello)
 {
-  const struct GNUNET_HELLO_Message* hm = (const struct GNUNET_HELLO_Message*) hello;
+  const struct GNUNET_HELLO_Message *hm =
+      (const struct GNUNET_HELLO_Message *) hello;
   struct ValidateAddressContext vac;
+  struct GNUNET_HELLO_Message *h;
+  int friend;
 
-  if ( (GNUNET_OK !=
-       GNUNET_HELLO_get_id (hm, &vac.pid)) ||
-       (GNUNET_OK !=
-       GNUNET_HELLO_get_key (hm, &vac.public_key)) )
-    {
-      /* malformed HELLO */
-      GNUNET_break (0);
-      return; 
-    }
+  friend = GNUNET_HELLO_is_friend_only (hm);
+  if (((GNUNET_YES != friend) && (GNUNET_NO != friend)) ||
+               (GNUNET_OK != GNUNET_HELLO_get_id (hm, &vac.pid)) ||
+      (GNUNET_OK != GNUNET_HELLO_get_key (hm, &vac.public_key)))
+  {
+    /* malformed HELLO */
+    GNUNET_break (0);
+    return;
+  }
+  if (0 ==
+      memcmp (&GST_my_identity, &vac.pid, sizeof (struct GNUNET_PeerIdentity)))
+    return;
+  /* Add peer identity without addresses to peerinfo service */
+  h = GNUNET_HELLO_create (&vac.public_key, NULL, NULL, friend);
+  GNUNET_PEERINFO_add_peer (GST_peerinfo, h, NULL, NULL);
+
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+              _("Adding `%s' without addresses for peer `%s'\n"), "HELLO",
+              GNUNET_i2s (&vac.pid));
+
+  GNUNET_free (h);
   GNUNET_assert (NULL ==
-                GNUNET_HELLO_iterate_addresses (hm,
-                                                GNUNET_NO,
-                                                &validate_address,
-                                                &vac));
+                 GNUNET_HELLO_iterate_addresses (hm, GNUNET_NO,
+                                                 &validate_address_iterator,
+                                                 &vac));
 }
 
 
+/**
+ * Closure for 'iterate_addresses'
+ */
+struct IteratorContext
+{
+  /**
+   * Function to call on each address.
+   */
+  GST_ValidationAddressCallback cb;
+
+  /**
+   * Closure for 'cb'.
+   */
+  void *cb_cls;
+
+};
+
+
 /**
  * Call the callback in the closure for each validation entry.
  *
@@ -1154,21 +1407,13 @@ GST_validation_handle_hello (const struct GNUNET_MessageHeader *hello)
  * @return GNUNET_OK (continue to iterate)
  */
 static int
-iterate_addresses (void *cls,
-                  const GNUNET_HashCode *key,
-                  void *value)
+iterate_addresses (void *cls, const struct GNUNET_HashCode * key, void *value)
 {
-  struct GST_ValidationIteratorContext *vic = cls;
+  struct IteratorContext *ic = cls;
   struct ValidationEntry *ve = value;
 
-  vic->cb (vic->cb_cls,
-          &ve->public_key,
-          &ve->pid,
-          ve->valid_until,
-          ve->validation_block,
-          ve->transport_name,
-          ve->addr,
-          ve->addrlen);
+  ic->cb (ic->cb_cls, &ve->public_key, ve->valid_until, ve->revalidation_block,
+          ve->address);
   return GNUNET_OK;
 }
 
@@ -1178,55 +1423,116 @@ iterate_addresses (void *cls,
  * Can either give a snapshot (synchronous API) or be continuous.
  *
  * @param target peer information is requested for
- * @param snapshot_only GNUNET_YES to iterate over addresses once, GNUNET_NO to
- *                      continue to give information about addresses as it evolves
  * @param cb function to call; will not be called after this function returns
- *                             if snapshot_only is GNUNET_YES
  * @param cb_cls closure for 'cb'
- * @return context to cancel, NULL if 'snapshot_only' is GNUNET_YES
  */
-struct GST_ValidationIteratorContext *
+void
 GST_validation_get_addresses (const struct GNUNET_PeerIdentity *target,
-                             int snapshot_only,
-                             GST_ValidationAddressCallback cb,
-                             void *cb_cls)
+                              GST_ValidationAddressCallback cb, void *cb_cls)
 {
-  struct GST_ValidationIteratorContext *vic;
+  struct IteratorContext ic;
 
-  vic = GNUNET_malloc (sizeof (struct GST_ValidationIteratorContext));
-  vic->cb = cb;
-  vic->cb_cls = cb_cls;
-  vic->target = *target;
+  ic.cb = cb;
+  ic.cb_cls = cb_cls;
   GNUNET_CONTAINER_multihashmap_get_multiple (validation_map,
-                                             &target->hashPubKey,
-                                             &iterate_addresses,
-                                             vic);
-  if (GNUNET_YES == snapshot_only)
+                                              &target->hashPubKey,
+                                              &iterate_addresses, &ic);
+}
+
+
+/**
+ * Update if we are using an address for a connection actively right now.
+ * Based on this, the validation module will measure latency for the
+ * address more or less often.
+ *
+ * @param address the address
+ * @param session the session
+ * @param in_use GNUNET_YES if we are now using the address for a connection,
+ *               GNUNET_NO if we are no longer using the address for a connection
+ * @param line line of caller just for DEBUGGING!
+ */
+void
+GST_validation_set_address_use (const struct GNUNET_HELLO_Address *address,
+                                struct Session *session,
+                                int in_use,
+                                int line)
+{
+  struct ValidationEntry *ve;
+
+  if (NULL != address)
+    ve = find_validation_entry (NULL, address);
+  else
+    ve = NULL;                  /* FIXME: lookup based on session... */
+  if (NULL == ve)
+  {
+    /* this can happen for inbound connections (sender_address_len == 0); */
+    return;
+  }
+  if (ve->in_use == in_use)
+  {
+
+    if (GNUNET_YES == in_use)
+    {
+      GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+                  "Error setting address in use for peer `%s' `%s' to USED: set last time by %i, called now by %i\n",
+                  GNUNET_i2s (&address->peer), GST_plugins_a2s (address),
+                  ve->last_line_set_to_yes, line);
+    }
+    if (GNUNET_NO == in_use)
     {
-      GNUNET_free (vic);
-      return NULL;
+      GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+                  "Error setting address in use for peer `%s' `%s' to NOT_USED: set last time by %i, called now by %i\n",
+                  GNUNET_i2s (&address->peer), GST_plugins_a2s (address),
+                  ve->last_line_set_to_no, line);
     }
-  GNUNET_CONTAINER_multihashmap_put (notify_map,
-                                    &target->hashPubKey,
-                                    vic,
-                                    GNUNET_CONTAINER_MULTIHASHMAPOPTION_MULTIPLE);
-  return vic;
+  }
+
+  if (GNUNET_YES == in_use)
+  {
+    ve->last_line_set_to_yes = line;
+  }
+  if (GNUNET_NO == in_use)
+  {
+    ve->last_line_set_to_no = line;
+  }
+
+  GNUNET_break (ve->in_use != in_use);  /* should be different... */
+  ve->in_use = in_use;
+  if (in_use == GNUNET_YES)
+  {
+    /* from now on, higher frequeny, so reschedule now */
+    GNUNET_SCHEDULER_cancel (ve->revalidation_task);
+    ve->revalidation_task = GNUNET_SCHEDULER_add_now (&revalidate_address, ve);
+  }
 }
 
 
 /**
- * Cancel an active validation address iteration.
+ * Query validation about the latest observed latency on a given
+ * address.
  *
- * @param ctx the context of the operation that is cancelled
+ * @param sender peer
+ * @param address the address
+ * @param session session
+ * @return observed latency of the address, FOREVER if the address was
+ *         never successfully validated
  */
-void
-GST_validation_get_addresses_cancel (struct GST_ValidationIteratorContext *ctx)
+struct GNUNET_TIME_Relative
+GST_validation_get_address_latency (const struct GNUNET_PeerIdentity *sender,
+                                    const struct GNUNET_HELLO_Address *address,
+                                    struct Session *session)
 {
-  GNUNET_assert (GNUNET_OK ==
-                GNUNET_CONTAINER_multihashmap_remove (notify_map,
-                                                      &ctx->target.hashPubKey,
-                                                      ctx));
-  GNUNET_free (ctx);
+  struct ValidationEntry *ve;
+
+  if (NULL == address)
+  {
+    GNUNET_break (0);           // FIXME: support having latency only with session...
+    return GNUNET_TIME_UNIT_FOREVER_REL;
+  }
+  ve = find_validation_entry (NULL, address);
+  if (NULL == ve)
+    return GNUNET_TIME_UNIT_FOREVER_REL;
+  return ve->latency;
 }