remove output
[oweals/gnunet.git] / src / transport / gnunet-service-transport_neighbours.c
index cad325d9883aea6920752309dc4c966510d020fb..8f53b93beb3772d6e89f3f353afc0e40f4e6669a 100644 (file)
@@ -318,7 +318,7 @@ struct SessionDisconnectMessage
    * Purpose of the signature.  Extends over the timestamp.
    * Purpose should be GNUNET_SIGNATURE_PURPOSE_TRANSPORT_DISCONNECT.
    */
-  struct GNUNET_CRYPTO_RsaSignaturePurpose purpose;
+  struct GNUNET_CRYPTO_EccSignaturePurpose purpose;
 
   /**
    * Absolute time at the sender.  Only the most recent connect
@@ -329,14 +329,14 @@ struct SessionDisconnectMessage
   /**
    * Public key of the sender.
    */
-  struct GNUNET_CRYPTO_RsaPublicKeyBinaryEncoded public_key;
+  struct GNUNET_CRYPTO_EccPublicKey public_key;
 
   /**
    * Signature of the peer that sends us the disconnect.  Only
    * valid if the timestamp is AFTER the timestamp from the
    * corresponding 'CONNECT' message.
    */
-  struct GNUNET_CRYPTO_RsaSignature signature;
+  struct GNUNET_CRYPTO_EccSignature signature;
 
 };
 
@@ -728,22 +728,11 @@ struct BlackListCheckContext
    * Address that is being checked.
    */
   struct NeighbourAddress na;
-  
-  /**
-   * ATS information about the address.
-   */
-  struct GNUNET_ATS_Information *ats;
 
   /**
    * Handle to the ongoing blacklist check.
    */
   struct GST_BlacklistCheck *bc;
-
-  /**
-   * Size of the 'ats' array.
-   */
-  uint32_t ats_count;
-
 };
 
 
@@ -1205,8 +1194,8 @@ send_disconnect (struct NeighbourMapEntry *n)
       htons (GNUNET_MESSAGE_TYPE_TRANSPORT_SESSION_DISCONNECT);
   disconnect_msg.reserved = htonl (0);
   disconnect_msg.purpose.size =
-      htonl (sizeof (struct GNUNET_CRYPTO_RsaSignaturePurpose) +
-             sizeof (struct GNUNET_CRYPTO_RsaPublicKeyBinaryEncoded) +
+      htonl (sizeof (struct GNUNET_CRYPTO_EccSignaturePurpose) +
+             sizeof (struct GNUNET_CRYPTO_EccPublicKey) +
              sizeof (struct GNUNET_TIME_AbsoluteNBO));
   disconnect_msg.purpose.purpose =
       htonl (GNUNET_MESSAGE_TYPE_TRANSPORT_SESSION_DISCONNECT);
@@ -1214,7 +1203,7 @@ send_disconnect (struct NeighbourMapEntry *n)
       GNUNET_TIME_absolute_hton (GNUNET_TIME_absolute_get ());
   disconnect_msg.public_key = GST_my_public_key;
   GNUNET_assert (GNUNET_OK ==
-                 GNUNET_CRYPTO_rsa_sign (GST_my_private_key,
+                 GNUNET_CRYPTO_ecc_sign (GST_my_private_key,
                                          &disconnect_msg.purpose,
                                          &disconnect_msg.signature));
 
@@ -1516,17 +1505,13 @@ GST_neighbours_keepalive (const struct GNUNET_PeerIdentity *neighbour)
  * plus calculated latency) to ATS.
  *
  * @param neighbour neighbour to keep alive
- * @param ats performance data
- * @param ats_count number of entries in ats
  */
 void
-GST_neighbours_keepalive_response (const struct GNUNET_PeerIdentity *neighbour,
-                                   const struct GNUNET_ATS_Information *ats,
-                                   uint32_t ats_count)
+GST_neighbours_keepalive_response (const struct GNUNET_PeerIdentity *neighbour)
 {
   struct NeighbourMapEntry *n;
   uint32_t latency;
-  struct GNUNET_ATS_Information ats_new[ats_count + 1];
+  struct GNUNET_ATS_Information ats;
 
   if (NULL == (n = lookup_neighbour (neighbour)))
   {
@@ -1551,18 +1536,17 @@ GST_neighbours_keepalive_response (const struct GNUNET_PeerIdentity *neighbour,
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
              "Latency for peer `%s' is %llu ms\n",
               GNUNET_i2s (&n->id), n->latency.rel_value);
-  memcpy (ats_new, ats, sizeof (struct GNUNET_ATS_Information) * ats_count);
   /* append latency */
-  ats_new[ats_count].type = htonl (GNUNET_ATS_QUALITY_NET_DELAY);
+  ats.type = htonl (GNUNET_ATS_QUALITY_NET_DELAY);
   if (n->latency.rel_value > UINT32_MAX)
     latency = UINT32_MAX;
   else
     latency = n->latency.rel_value;
-  ats_new[ats_count].value = htonl (latency);
-  GNUNET_ATS_address_update (GST_ats, 
-                            n->primary_address.address, 
-                            n->primary_address.session, ats_new,
-                            ats_count + 1);
+  ats.value = htonl (latency);
+  GST_ats_update_metrics (&n->id,
+                                                                                         n->primary_address.address,
+                                                                                       n->primary_address.session,
+                                                                                       &ats, 1);
 }
 
 
@@ -1856,12 +1840,16 @@ GST_neighbours_try_connect (const struct GNUNET_PeerIdentity *target)
   struct NeighbourMapEntry *n;
 
   if (NULL == neighbours)  
-    return; /* during shutdown, do nothing */
+  {
+         GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                     "Asked to connect to peer `%s' during shutdown\n",
+                     GNUNET_i2s (target));
+               return; /* during shutdown, do nothing */
+  }
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, 
              "Asked to connect to peer `%s'\n",
               GNUNET_i2s (target));
-  if (0 ==
-      memcmp (target, &GST_my_identity, sizeof (struct GNUNET_PeerIdentity)))
+  if (0 == memcmp (target, &GST_my_identity, sizeof (struct GNUNET_PeerIdentity)))
   {
     /* refuse to connect to myself */
     /* FIXME: can this happen? Is this not an API violation? */
@@ -2000,13 +1988,8 @@ handle_test_blacklist_cont (void *cls,
     break; 
   case S_CONNECT_RECV_BLACKLIST_INBOUND:
     if (GNUNET_OK == result)
-    {
-      /* valid new address, let ATS know! */
-      GNUNET_ATS_address_add (GST_ats,
-                              bcc->na.address,
-                              bcc->na.session,
-                              bcc->ats, bcc->ats_count);
-    }
+       GST_ats_add_address (bcc->na.address, bcc->na.session);
+
     n->state = S_CONNECT_RECV_ATS;
     n->timeout = GNUNET_TIME_relative_to_absolute (ATS_RESPONSE_TIMEOUT);
     GNUNET_ATS_reset_backoff (GST_ats, peer);
@@ -2158,30 +2141,22 @@ handle_test_blacklist_cont (void *cls,
  * @param address address of the other peer, NULL if other peer
  *                       connected to us
  * @param session session to use (or NULL)
- * @param ats performance data
- * @param ats_count number of entries in ats (excluding 0-termination)
  */
 static void
 check_blacklist (const struct GNUNET_PeerIdentity *peer,
                 struct GNUNET_TIME_Absolute ts,
                 const struct GNUNET_HELLO_Address *address,
-                struct Session *session,
-                const struct GNUNET_ATS_Information *ats,
-                uint32_t ats_count)
+                struct Session *session)
 {
   struct BlackListCheckContext *bcc;
   struct GST_BlacklistCheck *bc;
 
   bcc =
-      MEMDEBUG_malloc (sizeof (struct BlackListCheckContext) +
-                     sizeof (struct GNUNET_ATS_Information) * ats_count, __LINE__);
-  bcc->ats_count = ats_count;
+      MEMDEBUG_malloc (sizeof (struct BlackListCheckContext), __LINE__);
   bcc->na.address = GNUNET_HELLO_address_copy (address);
   MEMDEBUG_add_alloc (bcc->na.address, GNUNET_HELLO_address_get_size (address), __LINE__);
   bcc->na.session = session;
   bcc->na.connect_timestamp = ts;
-  bcc->ats = (struct GNUNET_ATS_Information *) &bcc[1];
-  memcpy (bcc->ats, ats, sizeof (struct GNUNET_ATS_Information) * ats_count);
   GNUNET_CONTAINER_DLL_insert (bc_head,
                               bc_tail,
                               bcc);
@@ -2203,16 +2178,12 @@ check_blacklist (const struct GNUNET_PeerIdentity *peer,
  * @param address address of the other peer, NULL if other peer
  *                       connected to us
  * @param session session to use (or NULL)
- * @param ats performance data
- * @param ats_count number of entries in ats (excluding 0-termination)
  */
 void
 GST_neighbours_handle_connect (const struct GNUNET_MessageHeader *message,
                                const struct GNUNET_PeerIdentity *peer,
                                const struct GNUNET_HELLO_Address *address,
-                               struct Session *session,
-                               const struct GNUNET_ATS_Information *ats,
-                               uint32_t ats_count)
+                               struct Session *session)
 {
   const struct SessionConnectMessage *scm;
   struct NeighbourMapEntry *n;
@@ -2243,7 +2214,7 @@ GST_neighbours_handle_connect (const struct GNUNET_MessageHeader *message,
   case S_NOT_CONNECTED:
     n->state = S_CONNECT_RECV_BLACKLIST_INBOUND;
     /* Do a blacklist check for the new address */
-    check_blacklist (peer, ts, address, session, ats, ats_count);
+    check_blacklist (peer, ts, address, session);
     break;
   case S_INIT_ATS:
     /* CONNECT message takes priority over us asking ATS for address */
@@ -2257,7 +2228,7 @@ GST_neighbours_handle_connect (const struct GNUNET_MessageHeader *message,
   case S_CONNECT_RECV_ACK:
     /* It can never hurt to have an alternative address in the above cases, 
        see if it is allowed */
-    check_blacklist (peer, ts, address, session, ats, ats_count);
+    check_blacklist (peer, ts, address, session);
     break;
   case S_CONNECTED:
     /* we are already connected and can thus send the ACK immediately;
@@ -2268,14 +2239,14 @@ GST_neighbours_handle_connect (const struct GNUNET_MessageHeader *message,
     n->send_connect_ack = 0;
     send_session_connect_ack_message (n->primary_address.address,
                                      n->primary_address.session, ts);
-    check_blacklist (peer, ts, address, session, ats, ats_count);
+    check_blacklist (peer, ts, address, session);
     break;
   case S_RECONNECT_ATS:
   case S_RECONNECT_BLACKLIST:
   case S_RECONNECT_SENT:
     /* It can never hurt to have an alternative address in the above cases, 
        see if it is allowed */
-    check_blacklist (peer, ts, address, session, ats, ats_count);
+    check_blacklist (peer, ts, address, session);
     break;
   case S_CONNECTED_SWITCHING_BLACKLIST:
   case S_CONNECTED_SWITCHING_CONNECT_SENT:
@@ -2287,7 +2258,7 @@ GST_neighbours_handle_connect (const struct GNUNET_MessageHeader *message,
     n->send_connect_ack = 0;
     send_session_connect_ack_message (n->primary_address.address,
                                      n->primary_address.session, ts);
-    check_blacklist (peer, ts, address, session, ats, ats_count);
+    check_blacklist (peer, ts, address, session);
     break;
   case S_DISCONNECT:
     /* get rid of remains without terminating sessions, ready to re-try */
@@ -2396,7 +2367,7 @@ GST_neighbours_switch_to_address (const struct GNUNET_PeerIdentity *peer,
     n->timeout = GNUNET_TIME_relative_to_absolute (BLACKLIST_RESPONSE_TIMEOUT);
     check_blacklist (&n->id,
                     n->connect_ack_timestamp,
-                    address, session, ats, ats_count);    
+                    address, session);
     break;
   case S_INIT_BLACKLIST:
     /* ATS suggests a different address, switch again */
@@ -2405,7 +2376,7 @@ GST_neighbours_switch_to_address (const struct GNUNET_PeerIdentity *peer,
     n->timeout = GNUNET_TIME_relative_to_absolute (BLACKLIST_RESPONSE_TIMEOUT);
     check_blacklist (&n->id,
                     n->connect_ack_timestamp,
-                    address, session, ats, ats_count);    
+                    address, session);
     break;
   case S_CONNECT_SENT:
     /* ATS suggests a different address, switch again */
@@ -2415,7 +2386,7 @@ GST_neighbours_switch_to_address (const struct GNUNET_PeerIdentity *peer,
     n->timeout = GNUNET_TIME_relative_to_absolute (BLACKLIST_RESPONSE_TIMEOUT);
     check_blacklist (&n->id,
                     n->connect_ack_timestamp,
-                    address, session, ats, ats_count);    
+                    address, session);
     break;
   case S_CONNECT_RECV_ATS:
     set_address (&n->primary_address,
@@ -2424,13 +2395,13 @@ GST_neighbours_switch_to_address (const struct GNUNET_PeerIdentity *peer,
     n->timeout = GNUNET_TIME_relative_to_absolute (BLACKLIST_RESPONSE_TIMEOUT);
     check_blacklist (&n->id,
                     n->connect_ack_timestamp,
-                    address, session, ats, ats_count);    
+                    address, session);
     break;
   case S_CONNECT_RECV_BLACKLIST_INBOUND:
     n->timeout = GNUNET_TIME_relative_to_absolute (BLACKLIST_RESPONSE_TIMEOUT);
     check_blacklist (&n->id,
                      n->connect_ack_timestamp,
-                     address, session, ats, ats_count);
+                     address, session);
     break;
   case S_CONNECT_RECV_BLACKLIST:
   case S_CONNECT_RECV_ACK:
@@ -2441,7 +2412,7 @@ GST_neighbours_switch_to_address (const struct GNUNET_PeerIdentity *peer,
     n->timeout = GNUNET_TIME_relative_to_absolute (BLACKLIST_RESPONSE_TIMEOUT);
     check_blacklist (&n->id,
                     n->connect_ack_timestamp,
-                    address, session, ats, ats_count);    
+                    address, session);
     break;
   case S_CONNECTED:
     GNUNET_assert (NULL != n->primary_address.address);
@@ -2460,7 +2431,7 @@ GST_neighbours_switch_to_address (const struct GNUNET_PeerIdentity *peer,
     n->state = S_CONNECTED_SWITCHING_BLACKLIST;
     check_blacklist (&n->id,
                     GNUNET_TIME_absolute_get (),
-                    address, session, ats, ats_count);
+                    address, session);
     break;
   case S_RECONNECT_ATS:
     set_address (&n->primary_address,
@@ -2469,7 +2440,7 @@ GST_neighbours_switch_to_address (const struct GNUNET_PeerIdentity *peer,
     n->timeout = GNUNET_TIME_relative_to_absolute (BLACKLIST_RESPONSE_TIMEOUT);
     check_blacklist (&n->id,
                     n->connect_ack_timestamp,
-                    address, session, ats, ats_count);    
+                    address, session);
     break;
   case S_RECONNECT_BLACKLIST:
     /* ATS asks us to switch while we were trying to reconnect; switch to new
@@ -2479,7 +2450,7 @@ GST_neighbours_switch_to_address (const struct GNUNET_PeerIdentity *peer,
     n->timeout = GNUNET_TIME_relative_to_absolute (BLACKLIST_RESPONSE_TIMEOUT);
     check_blacklist (&n->id,
                     n->connect_ack_timestamp,
-                    address, session, ats, ats_count);    
+                    address, session);
     break;
   case S_RECONNECT_SENT:
     /* ATS asks us to switch while we were trying to reconnect; switch to new
@@ -2490,7 +2461,7 @@ GST_neighbours_switch_to_address (const struct GNUNET_PeerIdentity *peer,
     n->timeout = GNUNET_TIME_relative_to_absolute (BLACKLIST_RESPONSE_TIMEOUT);
     check_blacklist (&n->id,
                     n->connect_ack_timestamp,
-                    address, session, ats, ats_count); 
+                    address, session);
     break;
   case S_CONNECTED_SWITCHING_BLACKLIST:
     if (n->primary_address.session == session)
@@ -2505,7 +2476,7 @@ GST_neighbours_switch_to_address (const struct GNUNET_PeerIdentity *peer,
                 address, session, bandwidth_in, bandwidth_out, GNUNET_NO);
     check_blacklist (&n->id,
                     GNUNET_TIME_absolute_get (),
-                    address, session, ats, ats_count);
+                    address, session);
     break;
   case S_CONNECTED_SWITCHING_CONNECT_SENT:
     if (n->primary_address.session == session)
@@ -2521,7 +2492,7 @@ GST_neighbours_switch_to_address (const struct GNUNET_PeerIdentity *peer,
     n->state = S_CONNECTED_SWITCHING_BLACKLIST;
     check_blacklist (&n->id,
                     GNUNET_TIME_absolute_get (),
-                    address, session, ats, ats_count);
+                    address, session);
     break;
   case S_DISCONNECT:
     /* not going to switch addresses while disconnecting */
@@ -2769,16 +2740,12 @@ send_session_ack_message (struct NeighbourMapEntry *n)
  * @param address address of the other peer, NULL if other peer
  *                       connected to us
  * @param session session to use (or NULL)
- * @param ats performance data
- * @param ats_count number of entries in ats
  */
 void
 GST_neighbours_handle_connect_ack (const struct GNUNET_MessageHeader *message,
                                    const struct GNUNET_PeerIdentity *peer,
                                    const struct GNUNET_HELLO_Address *address,
-                                   struct Session *session,
-                                   const struct GNUNET_ATS_Information *ats,
-                                   uint32_t ats_count)
+                                   struct Session *session)
 {
   const struct SessionConnectMessage *scm;
   struct GNUNET_TIME_Absolute ts;
@@ -2826,14 +2793,11 @@ GST_neighbours_handle_connect_ack (const struct GNUNET_MessageHeader *message,
                           gettext_noop ("# peers connected"), 
                           ++neighbours_connected,
                           GNUNET_NO);
-    connect_notify_cb (callback_cls, &n->id, ats, ats_count,
+    connect_notify_cb (callback_cls, &n->id,
                        n->primary_address.bandwidth_in,
                        n->primary_address.bandwidth_out);
     /* Tell ATS that the outbound session we created to send CONNECT was successfull */
-    GNUNET_ATS_address_add (GST_ats,
-                            n->primary_address.address,
-                            n->primary_address.session,
-                            ats, ats_count);
+    GST_ats_add_address (n->primary_address.address, n->primary_address.session);
     set_address (&n->primary_address,
                 n->primary_address.address,
                 n->primary_address.session,
@@ -2878,10 +2842,8 @@ GST_neighbours_handle_connect_ack (const struct GNUNET_MessageHeader *message,
     n->state = S_CONNECTED;
     n->timeout = GNUNET_TIME_relative_to_absolute (GNUNET_CONSTANTS_IDLE_CONNECTION_TIMEOUT);
     GNUNET_break (GNUNET_NO == n->alternative_address.ats_active);
-    GNUNET_ATS_address_add(GST_ats,
-                           n->alternative_address.address,
-                           n->alternative_address.session,
-                           ats, ats_count);
+
+    GST_ats_add_address (n->alternative_address.address, n->alternative_address.session);
     set_address (&n->primary_address,
                 n->alternative_address.address,
                 n->alternative_address.session,
@@ -3049,16 +3011,12 @@ GST_neighbours_session_terminated (const struct GNUNET_PeerIdentity *peer,
  * @param address address of the other peer, NULL if other peer
  *                       connected to us
  * @param session session to use (or NULL)
- * @param ats performance data
- * @param ats_count number of entries in ats
  */
 void
 GST_neighbours_handle_session_ack (const struct GNUNET_MessageHeader *message,
                                   const struct GNUNET_PeerIdentity *peer,
                                   const struct GNUNET_HELLO_Address *address,
-                                  struct Session *session,
-                                  const struct GNUNET_ATS_Information *ats,
-                                  uint32_t ats_count)
+                                  struct Session *session)
 {
   struct NeighbourMapEntry *n;
 
@@ -3089,13 +3047,11 @@ GST_neighbours_handle_session_ack (const struct GNUNET_MessageHeader *message,
                         gettext_noop ("# peers connected"), 
                         ++neighbours_connected,
                         GNUNET_NO);
-  connect_notify_cb (callback_cls, &n->id, ats, ats_count,
+  connect_notify_cb (callback_cls, &n->id,
                      n->primary_address.bandwidth_in,
                      n->primary_address.bandwidth_out);
-  GNUNET_ATS_address_add(GST_ats,
-                         n->primary_address.address,
-                         n->primary_address.session,
-                         ats, ats_count);
+
+  GST_ats_add_address (n->primary_address.address, n->primary_address.session);
   set_address (&n->primary_address,
               n->primary_address.address,
               n->primary_address.session,
@@ -3195,7 +3151,7 @@ GST_neighbours_handle_disconnect_message (const struct GNUNET_PeerIdentity
     return;
   }
   GNUNET_CRYPTO_hash (&sdm->public_key,
-                      sizeof (struct GNUNET_CRYPTO_RsaPublicKeyBinaryEncoded),
+                      sizeof (struct GNUNET_CRYPTO_EccPublicKey),
                       &hc);
   if (0 != memcmp (peer, &hc, sizeof (struct GNUNET_PeerIdentity)))
   {
@@ -3203,18 +3159,26 @@ GST_neighbours_handle_disconnect_message (const struct GNUNET_PeerIdentity
     return;
   }
   if (ntohl (sdm->purpose.size) !=
-      sizeof (struct GNUNET_CRYPTO_RsaSignaturePurpose) +
-      sizeof (struct GNUNET_CRYPTO_RsaPublicKeyBinaryEncoded) +
+      sizeof (struct GNUNET_CRYPTO_EccSignaturePurpose) +
+      sizeof (struct GNUNET_CRYPTO_EccPublicKey) +
       sizeof (struct GNUNET_TIME_AbsoluteNBO))
   {
+    GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
+                "%s message from peer `%s' has invalid size \n",
+                "DISCONNECT",
+                GNUNET_i2s (peer));
     GNUNET_break_op (0);
     return;
   }
   if (GNUNET_OK !=
-      GNUNET_CRYPTO_rsa_verify
+      GNUNET_CRYPTO_ecc_verify
       (GNUNET_MESSAGE_TYPE_TRANSPORT_SESSION_DISCONNECT, &sdm->purpose,
        &sdm->signature, &sdm->public_key))
   {
+    GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
+                "%s message from peer `%s' cannot be verified \n",
+                "DISCONNECT",
+                GNUNET_i2s (peer));
     GNUNET_break_op (0);
     return;
   }
@@ -3274,7 +3238,7 @@ neighbours_iterate (void *cls, const struct GNUNET_HashCode * key, void *value)
       bandwidth_out = GNUNET_CONSTANTS_DEFAULT_BW_IN_OUT;
     }
 
-    ic->cb (ic->cb_cls, &n->id, NULL, 0,
+    ic->cb (ic->cb_cls, &n->id,
             n->primary_address.address,
             bandwidth_in, bandwidth_out);
   }