clean up, asserts, FIXME
[oweals/gnunet.git] / src / transport / gnunet-service-transport_neighbours.c
index e0af12b3c9b7a2dec562e36ffe6a6649e9398614..62fc441a15f20d274f31322b88a68a4effc7f477 100644 (file)
@@ -184,22 +184,36 @@ struct MessageQueue
 
 };
 
+
 enum State
 {
-  /* fresh peer or completely disconnected */
-  S_NOT_CONNECTED = 0,
-  /* sent CONNECT message to other peer, waiting for CONNECT_ACK */
-  S_CONNECT_SENT = 1,
-  /* received CONNECT message to other peer, sending CONNECT_ACK */
-  S_CONNECT_RECV = 4,
-  /* sent CONNECT_ACK message to other peer, wait for ACK or payload */
-  S_CONNECT_RECV_ACK_SENT = 8,
-  /* received ACK or payload */
-  S_CONNECTED = 16,
-  /* Disconnect in progress */
-  S_DISCONNECT = 32
+  /**
+   * fresh peer or completely disconnected 
+   */
+  S_NOT_CONNECTED,
+
+  /**
+   * sent CONNECT message to other peer, waiting for CONNECT_ACK 
+   */
+  S_CONNECT_SENT,
+
+  /**
+   * received CONNECT message to other peer, sending CONNECT_ACK 
+   */
+  S_CONNECT_RECV,
+
+  /**
+   * received ACK or payload 
+   */
+  S_CONNECTED,
+
+  /**
+   * Disconnect in progress 
+   */
+  S_DISCONNECT
 };
 
+
 /**
  * Entry in neighbours.
  */
@@ -234,19 +248,9 @@ struct NeighbourMapEntry
   struct Session *session;
 
   /**
-   * Name of the plugin we currently use.
+   * Address we currently use.
    */
-  char *plugin_name;
-
-  /**
-   * Address used for communicating with the peer, NULL for inbound connections.
-   */
-  void *addr;
-
-  /**
-   * Number of bytes in 'addr'.
-   */
-  size_t addrlen;
+  struct GNUNET_HELLO_Address *address;
 
   /**
    * Identity of this neighbour.
@@ -393,9 +397,6 @@ print_state (int state)
   case S_CONNECT_RECV:
     return "S_CONNECT_RECV";
     break;
-  case S_CONNECT_RECV_ACK_SENT:
-    return "S_CONNECT_RECV_ACK_SENT";
-    break;
   case S_CONNECT_SENT:
     return "S_CONNECT_SENT";
     break;
@@ -426,12 +427,15 @@ reset_task (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
   n->state_reset = GNUNET_SCHEDULER_NO_TASK;
 
 #if DEBUG_TRANSPORT
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Connection to peer `%s' %s failed in state `%s', resetting connection attempt \n",
-              GNUNET_i2s (&n->id), GST_plugins_a2s (n->plugin_name, n->addr,
-                                                    n->addrlen),
-              print_state (n->state));
 #endif
+  /* This jut a temporary debug message to check if a the value
+   * SETUP_CONNECTION_TIMEOUT was choosen to small for slow machines
+   */
+  GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
+              "Information for developers: Connection to peer `%s' %s failed in state `%s', resetting connection attempt \n",
+              GNUNET_i2s (&n->id), GST_plugins_a2s (n->address),
+              print_state (n->state));
+
   GNUNET_STATISTICS_update (GST_stats,
                             gettext_noop
                             ("# failed connection attempts due to timeout"), 1,
@@ -441,8 +445,7 @@ reset_task (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
   n->state = S_NOT_CONNECTED;
 
   /* destroying address */
-  GNUNET_ATS_address_destroyed (GST_ats, &n->id, n->plugin_name, n->addr,
-                                n->addrlen, NULL);
+  GNUNET_ATS_address_destroyed (GST_ats, n->address, NULL);
 
   /* request new address */
   if (n->ats_suggest != GNUNET_SCHEDULER_NO_TASK)
@@ -456,9 +459,6 @@ reset_task (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
 static int
 change (struct NeighbourMapEntry *n, int state, int line)
 {
-  char *old = strdup (print_state (n->state));
-  char *new = strdup (print_state (state));
-
   /* allowed transitions */
   int allowed = GNUNET_NO;
 
@@ -467,92 +467,28 @@ change (struct NeighbourMapEntry *n, int state, int line)
   case S_NOT_CONNECTED:
     if ((state == S_CONNECT_RECV) || (state == S_CONNECT_SENT) ||
         (state == S_DISCONNECT))
-    {
       allowed = GNUNET_YES;
-
-      /* Schedule reset task */
-      if ((state == S_CONNECT_RECV) || (state == S_CONNECT_SENT))
-      {
-        GNUNET_assert (n->state_reset == GNUNET_SCHEDULER_NO_TASK);
-        n->state_reset =
-            GNUNET_SCHEDULER_add_delayed (SETUP_CONNECTION_TIMEOUT, &reset_task,
-                                          n);
-      }
-
-      break;
-    }
     break;
   case S_CONNECT_RECV:
-    if ((state == S_NOT_CONNECTED) || (state == S_DISCONNECT) ||
-        (state == S_CONNECTED) ||
-        /* FIXME SENT -> RECV ISSUE! */ (state == S_CONNECT_SENT))
-    {
-      if ((state == S_CONNECTED) || (state == S_DISCONNECT) ||
-          (state == S_NOT_CONNECTED))
-      {
-#if DEBUG_TRANSPORT
-        GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                    "Removed reset task for peer `%s' %s failed in state transition `%s' -> `%s' \n",
-                    GNUNET_i2s (&n->id), GST_plugins_a2s (n->plugin_name,
-                                                          n->addr, n->addrlen),
-                    print_state (n->state), print_state (state));
-#endif
-        GNUNET_assert (n->state_reset != GNUNET_SCHEDULER_NO_TASK);
-        GNUNET_SCHEDULER_cancel (n->state_reset);
-        n->state_reset = GNUNET_SCHEDULER_NO_TASK;
-      }
-
-      allowed = GNUNET_YES;
-      break;
-    }
+    allowed = GNUNET_YES;
     break;
   case S_CONNECT_SENT:
-    if ((state == S_NOT_CONNECTED) || (state == S_CONNECTED) ||
-        (state == S_DISCONNECT) ||
-        /* FIXME SENT -> RECV ISSUE! */ (state == S_CONNECT_RECV))
-    {
-      if ((state == S_CONNECTED) || (state == S_DISCONNECT) ||
-          (state == S_NOT_CONNECTED))
-      {
-#if DEBUG_TRANSPORT
-        GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                    "Removed reset task for peer `%s' %s failed in state transition `%s' -> `%s' \n",
-                    GNUNET_i2s (&n->id), GST_plugins_a2s (n->plugin_name,
-                                                          n->addr, n->addrlen),
-                    print_state (n->state), print_state (state));
-#endif
-        GNUNET_assert (n->state_reset != GNUNET_SCHEDULER_NO_TASK);
-        GNUNET_SCHEDULER_cancel (n->state_reset);
-        n->state_reset = GNUNET_SCHEDULER_NO_TASK;
-      }
-
-      allowed = GNUNET_YES;
-      break;
-    }
+    allowed = GNUNET_YES;
     break;
   case S_CONNECTED:
     if (state == S_DISCONNECT)
-    {
       allowed = GNUNET_YES;
-      break;
-    }
     break;
   case S_DISCONNECT:
-    /*
-     * if (state == S_NOT_CONNECTED)
-     * {
-     * allowed = GNUNET_YES;
-     * break;
-     * } */
     break;
   default:
     GNUNET_break (0);
     break;
-
   }
-
   if (allowed == GNUNET_NO)
   {
+    char *old = GNUNET_strdup (print_state (n->state));
+    char *new = GNUNET_strdup (print_state (state));
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                 "Illegal state transition from `%s' to `%s' in line %u \n", old,
                 new, line);
@@ -564,12 +500,52 @@ change (struct NeighbourMapEntry *n, int state, int line)
 
   n->state = state;
 #if DEBUG_TRANSPORT
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "State for neighbour `%s' %X changed from `%s' to `%s' in line %u\n",
-              GNUNET_i2s (&n->id), n, old, new, line);
+  {
+    char *old = GNUNET_strdup (print_state (n->state));
+    char *new = GNUNET_strdup (print_state (state));
+    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+               "State for neighbour `%s' %X changed from `%s' to `%s' in line %u\n",
+               GNUNET_i2s (&n->id), n, old, new, line);
+    GNUNET_free (old);
+    GNUNET_free (new);
+  }
+#endif
+  switch (n->state)
+  {
+  case S_CONNECT_RECV:
+  case S_CONNECT_SENT:
+    if (n->state_reset != GNUNET_SCHEDULER_NO_TASK)
+      GNUNET_SCHEDULER_cancel (n->state_reset);
+    n->state_reset =
+      GNUNET_SCHEDULER_add_delayed (SETUP_CONNECTION_TIMEOUT, &reset_task,
+                                   n);   
+    break;
+  case S_CONNECTED:
+  case S_NOT_CONNECTED:
+  case S_DISCONNECT:
+    if (GNUNET_SCHEDULER_NO_TASK != n->state_reset)
+    {
+#if DEBUG_TRANSPORT
+      char *old = GNUNET_strdup (print_state (n->state));
+      char *new = GNUNET_strdup (print_state (state));
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                 "Removed reset task for peer `%s' %s failed in state transition `%s' -> `%s' \n",
+                 GNUNET_i2s (&n->id), GST_plugins_a2s (n->address),
+                 old, new);
+      GNUNET_free (old);
+      GNUNET_free (new);
 #endif
-  GNUNET_free (old);
-  GNUNET_free (new);
+      GNUNET_assert (n->state_reset != GNUNET_SCHEDULER_NO_TASK);
+      GNUNET_SCHEDULER_cancel (n->state_reset);
+      n->state_reset = GNUNET_SCHEDULER_NO_TASK;
+    }
+    break;
+  default:
+    GNUNET_assert (0);
+  }
+  
+
+
   return GNUNET_OK;
 }
 
@@ -577,7 +553,7 @@ static ssize_t
 send_with_plugin (const struct GNUNET_PeerIdentity *target, const char *msgbuf,
                   size_t msgbuf_size, uint32_t priority,
                   struct GNUNET_TIME_Relative timeout, struct Session *session,
-                  const char *plugin_name, const void *addr, size_t addrlen,
+                 const struct GNUNET_HELLO_Address *address,
                   int force_address, GNUNET_TRANSPORT_TransmitContinuation cont,
                   void *cont_cls)
 {
@@ -585,21 +561,21 @@ send_with_plugin (const struct GNUNET_PeerIdentity *target, const char *msgbuf,
   size_t ret = GNUNET_SYSERR;
 
   /* FIXME : ats returns an address with all values 0 */
-  if (plugin_name == NULL)
+  if (address == NULL)
   {
     if (cont != NULL)
       cont (cont_cls, target, GNUNET_SYSERR);
     return GNUNET_SYSERR;
   }
 
-  if ((session == NULL) && (addr == NULL) && (addrlen == 0))
+  if ((session == NULL) && (address == NULL))
   {
     if (cont != NULL)
       cont (cont_cls, target, GNUNET_SYSERR);
     return GNUNET_SYSERR;
   }
 
-  papi = GST_plugins_find (plugin_name);
+  papi = GST_plugins_find (address->transport_name);
   if (papi == NULL)
   {
     if (cont != NULL)
@@ -609,7 +585,8 @@ send_with_plugin (const struct GNUNET_PeerIdentity *target, const char *msgbuf,
 
   ret =
       papi->send (papi->cls, target, msgbuf, msgbuf_size, 0, timeout, session,
-                  addr, addrlen, GNUNET_YES, cont, cont_cls);
+                  address->address, 
+                 address->address_length, GNUNET_YES, cont, cont_cls);
 
   if (ret == -1)
   {
@@ -703,7 +680,7 @@ try_transmission_to_peer (struct NeighbourMapEntry *n)
   if (NULL == mq)
     return;                     /* no more messages */
 
-  if (GST_plugins_find (n->plugin_name) == NULL)
+  if (GST_plugins_find (n->address->transport_name) == NULL)
   {
     GNUNET_break (0);
     return;
@@ -712,9 +689,10 @@ try_transmission_to_peer (struct NeighbourMapEntry *n)
   n->is_active = mq;
   mq->n = n;
 
-  if ((n->session == NULL) && (n->addr == NULL) && (n->addrlen == 0))
+  if ( (n->session == NULL) && (NULL == n->address) )
   {
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "No address for peer `%s'\n",
+    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, 
+               "No address for peer `%s'\n",
                 GNUNET_i2s (&n->id));
     transmit_send_continuation (mq, &n->id, GNUNET_SYSERR);
     GNUNET_assert (n->transmission_task == GNUNET_SCHEDULER_NO_TASK);
@@ -724,8 +702,8 @@ try_transmission_to_peer (struct NeighbourMapEntry *n)
 
   ret =
       send_with_plugin (&n->id, mq->message_buf, mq->message_buf_size, 0,
-                        timeout, n->session, n->plugin_name, n->addr,
-                        n->addrlen, GNUNET_YES, &transmit_send_continuation,
+                        timeout, n->session, n->address, 
+                       GNUNET_YES, &transmit_send_continuation,
                         mq);
   if (ret == -1)
   {
@@ -786,8 +764,8 @@ send_disconnect_cont (void *cls, const struct GNUNET_PeerIdentity *target,
 
 static int
 send_disconnect (const struct GNUNET_PeerIdentity *target,
-                 const char *plugin_name, const char *sender_address,
-                 uint16_t sender_address_len, struct Session *session)
+                 const struct GNUNET_HELLO_Address *address,
+                 struct Session *session)
 {
   size_t ret;
   struct SessionDisconnectMessage disconnect_msg;
@@ -818,8 +796,8 @@ send_disconnect (const struct GNUNET_PeerIdentity *target,
   ret =
       send_with_plugin (target, (const char *) &disconnect_msg,
                         sizeof (disconnect_msg), UINT32_MAX,
-                        GNUNET_TIME_UNIT_FOREVER_REL, session, plugin_name,
-                        sender_address, sender_address_len, GNUNET_YES,
+                        GNUNET_TIME_UNIT_FOREVER_REL, session, address,
+                       GNUNET_YES,
                         &send_disconnect_cont, NULL);
 
   if (ret == GNUNET_SYSERR)
@@ -841,13 +819,15 @@ static void
 disconnect_neighbour (struct NeighbourMapEntry *n)
 {
   struct MessageQueue *mq;
-  int was_connected = is_connected (n);
+  int is_connected;
+
+  is_connected = (n->state == S_CONNECTED);
 
   /* send DISCONNECT MESSAGE */
-  if (is_connected (n) || is_connecting (n))
+  if (is_connected || is_connecting (n))
   {
     if (GNUNET_OK ==
-        send_disconnect (&n->id, n->plugin_name, n->addr, n->addrlen,
+        send_disconnect (&n->id, n->address,
                          n->session))
       GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Sent DISCONNECT_MSG to `%s'\n",
                   GNUNET_i2s (&n->id));
@@ -857,10 +837,27 @@ disconnect_neighbour (struct NeighbourMapEntry *n)
                   GNUNET_i2s (&n->id));
   }
 
+  if (is_connected)
+  {
+     GNUNET_ATS_address_in_use (GST_ats, n->address, n->session, GNUNET_NO);
+  }
+
 
   if (is_disconnecting (n))
     return;
   change_state (n, S_DISCONNECT);
+  GST_validation_set_address_use (&n->id,
+                                 n->address,
+                                 n->session,
+                                 GNUNET_NO);
+
+  if (n->address != NULL)
+  {
+    struct GNUNET_TRANSPORT_PluginFunctions *papi;
+    papi = GST_plugins_find (n->address->transport_name);
+    if (papi != NULL)
+      papi->disconnect (papi->cls, &n->id);
+  }
 
   while (NULL != (mq = n->messages_head))
   {
@@ -874,7 +871,7 @@ disconnect_neighbour (struct NeighbourMapEntry *n)
     n->is_active->n = NULL;
     n->is_active = NULL;
   }
-  if (was_connected)
+  if (is_connected)
   {
     GNUNET_assert (GNUNET_SCHEDULER_NO_TASK != n->keepalive_task);
     GNUNET_SCHEDULER_cancel (n->keepalive_task);
@@ -903,16 +900,10 @@ disconnect_neighbour (struct NeighbourMapEntry *n)
     GNUNET_SCHEDULER_cancel (n->transmission_task);
     n->transmission_task = GNUNET_SCHEDULER_NO_TASK;
   }
-  if (NULL != n->plugin_name)
-  {
-    GNUNET_free (n->plugin_name);
-    n->plugin_name = NULL;
-  }
-  if (NULL != n->addr)
+  if (NULL != n->address)
   {
-    GNUNET_free (n->addr);
-    n->addr = NULL;
-    n->addrlen = 0;
+    GNUNET_HELLO_address_free (n->address);
+    n->address = NULL;
   }
   n->session = NULL;
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Deleting peer `%4s', %X\n",
@@ -959,7 +950,7 @@ neighbour_keepalive_task (void *cls,
   n->keepalive_task =
       GNUNET_SCHEDULER_add_delayed (KEEPALIVE_FREQUENCY,
                                     &neighbour_keepalive_task, n);
-  GNUNET_assert (is_connected (n));
+  GNUNET_assert (S_CONNECTED == n->state);
   GNUNET_STATISTICS_update (GST_stats, gettext_noop ("# keepalives sent"), 1,
                             GNUNET_NO);
   m.size = htons (sizeof (struct GNUNET_MessageHeader));
@@ -967,8 +958,8 @@ neighbour_keepalive_task (void *cls,
 
   send_with_plugin (&n->id, (const void *) &m, sizeof (m),
                     UINT32_MAX /* priority */ ,
-                    GNUNET_TIME_UNIT_FOREVER_REL, n->session, n->plugin_name,
-                    n->addr, n->addrlen, GNUNET_YES, NULL, NULL);
+                    GNUNET_TIME_UNIT_FOREVER_REL, n->session, n->address, 
+                   GNUNET_YES, NULL, NULL);
 }
 
 
@@ -988,7 +979,7 @@ disconnect_all_neighbours (void *cls, const GNUNET_HashCode * key, void *value)
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Disconnecting peer `%4s', %s\n",
               GNUNET_i2s (&n->id), "SHUTDOWN_TASK");
 #endif
-  if (is_connected (n))
+  if (S_CONNECTED == n->state)
     GNUNET_STATISTICS_update (GST_stats,
                               gettext_noop
                               ("# peers disconnected due to global disconnect"),
@@ -1040,47 +1031,41 @@ GST_neighbours_stop ()
  * succeeded, we change the state.  If it failed, we should tell
  * ATS to not use this address anymore (until it is re-validated).
  *
- * @param cls the 'struct NeighbourMapEntry'
+ * @param cls the 'struct GNUNET_HELLO_Address' of the address that was tried
  * @param success GNUNET_OK on success
  */
 static void
 send_connect_continuation (void *cls, const struct GNUNET_PeerIdentity *target,
                            int success)
 {
-  struct NeighbourMapEntry *n = cls;
-
-  GNUNET_assert (n != NULL);
-  GNUNET_assert (!is_connected (n));
-
-  if (is_disconnecting (n))
-    return;                     /* neighbour is going away */
-
+  struct GNUNET_HELLO_Address *address = cls;
+  struct NeighbourMapEntry *n;
+  
   if (GNUNET_YES != success)
+    GNUNET_ATS_address_destroyed (GST_ats, address, NULL);  
+  if ( (NULL == neighbours) ||
+       (NULL == (n = lookup_neighbour (&address->peer))) ||
+       (n->state == S_DISCONNECT) ||
+       (GNUNET_YES == success) )
   {
-#if DEBUG_TRANSPORT
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                "Failed to send CONNECT_MSG to peer `%4s' with plugin `%s' address '%s' session %X, asking ATS for new address \n",
-                GNUNET_i2s (&n->id), n->plugin_name,
-                (n->addrlen ==
-                 0) ? "<inbound>" : GST_plugins_a2s (n->plugin_name, n->addr,
-                                                     n->addrlen), n->session);
-#endif
-
-    GNUNET_ATS_address_destroyed (GST_ats, &n->id, n->plugin_name, n->addr,
-                                  n->addrlen, NULL);
-
-    change_state (n, S_NOT_CONNECTED);
-
-    if (n->ats_suggest != GNUNET_SCHEDULER_NO_TASK)
-      GNUNET_SCHEDULER_cancel (n->ats_suggest);
-    n->ats_suggest =
-        GNUNET_SCHEDULER_add_delayed (ATS_RESPONSE_TIMEOUT, ats_suggest_cancel,
-                                      n);
-    GNUNET_ATS_suggest_address (GST_ats, &n->id);
+    GNUNET_HELLO_address_free (address);
     return;
   }
-
-
+#if DEBUG_TRANSPORT
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+             "Failed to send CONNECT_MSG to peer `%4s' with address '%s' session %p, asking ATS for new address \n",
+             GNUNET_i2s (&n->id), 
+             GST_plugins_a2s (n->address), 
+             n->session);
+#endif
+  change_state (n, S_NOT_CONNECTED);
+  if (n->ats_suggest != GNUNET_SCHEDULER_NO_TASK)
+    GNUNET_SCHEDULER_cancel (n->ats_suggest);
+  n->ats_suggest =
+    GNUNET_SCHEDULER_add_delayed (ATS_RESPONSE_TIMEOUT, &ats_suggest_cancel,
+                                 n);
+  GNUNET_ATS_suggest_address (GST_ats, &n->id);
+  GNUNET_HELLO_address_free (address);
 }
 
 
@@ -1108,14 +1093,12 @@ send_switch_address_continuation (void *cls,
 #if DEBUG_TRANSPORT
     GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                 "Failed to switch connected peer `%s' to plugin `%s' address '%s' session %X, asking ATS for new address \n",
-                GNUNET_i2s (&n->id), n->plugin_name,
+                GNUNET_i2s (&n->id), n->address->transport_name,
                 (n->addrlen ==
-                 0) ? "<inbound>" : GST_plugins_a2s (n->plugin_name, n->addr,
-                                                     n->addrlen), n->session);
+                 0) ? "<inbound>" : GST_plugins_a2s (n->address), n->session);
 #endif
 
-    GNUNET_ATS_address_destroyed (GST_ats, &n->id, n->plugin_name, n->addr,
-                                  n->addrlen, NULL);
+    GNUNET_ATS_address_destroyed (GST_ats, n->address, NULL);
 
     if (n->ats_suggest != GNUNET_SCHEDULER_NO_TASK)
       GNUNET_SCHEDULER_cancel (n->ats_suggest);
@@ -1125,6 +1108,8 @@ send_switch_address_continuation (void *cls,
     GNUNET_ATS_suggest_address (GST_ats, &n->id);
     return;
   }
+  /* Tell ATS that switching addresses was successful */
+  GNUNET_ATS_address_in_use (GST_ats, n->address, n->session, GNUNET_YES);
 }
 
 /**
@@ -1151,16 +1136,13 @@ send_connect_ack_continuation (void *cls,
 #if DEBUG_TRANSPORT
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
               "Failed to send CONNECT_MSG to peer `%4s' with plugin `%s' address '%s' session %X, asking ATS for new address \n",
-              GNUNET_i2s (&n->id), n->plugin_name,
-              (n->addrlen == 0) ? "<inbound>" : GST_plugins_a2s (n->plugin_name,
-                                                                 n->addr,
-                                                                 n->addrlen),
+              GNUNET_i2s (&n->id), n->address->transport_name,
+              (n->addrlen == 0) ? "<inbound>" : GST_plugins_a2s (n->address),
               n->session);
 #endif
   change_state (n, S_NOT_CONNECTED);
 
-  GNUNET_ATS_address_destroyed (GST_ats, &n->id, n->plugin_name, n->addr,
-                                n->addrlen, NULL);
+  GNUNET_ATS_address_destroyed (GST_ats, n->address, NULL);
 
   if (n->ats_suggest != GNUNET_SCHEDULER_NO_TASK)
     GNUNET_SCHEDULER_cancel (n->ats_suggest);
@@ -1170,15 +1152,14 @@ send_connect_ack_continuation (void *cls,
   GNUNET_ATS_suggest_address (GST_ats, &n->id);
 }
 
+
 /**
  * For an existing neighbour record, set the active connection to
  * the given address.
  *
  * @param peer identity of the peer to switch the address for
- * @param plugin_name name of transport that delivered the PONG
  * @param address address of the other peer, NULL if other peer
  *                       connected to us
- * @param address_len number of bytes in address
  * @param session session to use (or NULL)
  * @param ats performance data
  * @param ats_count number of entries in ats
@@ -1187,8 +1168,7 @@ send_connect_ack_continuation (void *cls,
  */
 int
 GST_neighbours_switch_to_address_3way (const struct GNUNET_PeerIdentity *peer,
-                                       const char *plugin_name,
-                                       const void *address, size_t address_len,
+                                       const struct GNUNET_HELLO_Address *address,
                                        struct Session *session,
                                        const struct GNUNET_ATS_Information *ats,
                                        uint32_t ats_count,
@@ -1201,112 +1181,95 @@ GST_neighbours_switch_to_address_3way (const struct GNUNET_PeerIdentity *peer,
   struct SessionConnectMessage connect_msg;
   size_t msg_len;
   size_t ret;
-  int checks_failed;
 
-  // This can happen during shutdown
   if (neighbours == NULL)
   {
+    /* This can happen during shutdown */
     return GNUNET_NO;
   }
-
-  checks_failed = GNUNET_NO;
-
-  if (plugin_name == NULL)
+  n = lookup_neighbour (peer);
+  if (NULL == n)
+    return GNUNET_NO;
+  if (n->state == S_DISCONNECT)
   {
-    GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
-                "ATS offered suggested us empty address: plugin NULL");
-    GNUNET_break_op (0);
-    checks_failed = GNUNET_YES;
+    /* We are disconnecting, nothing to do here */
+    return GNUNET_NO;
   }
-  if ((address == NULL) && (address_len == 0) && (session == NULL))
+  GNUNET_assert (address->transport_name != NULL);
+  if ( (session == NULL) && (0 == address->address_length) )
   {
-    GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
-                "ATS offered suggested us empty address: address NULL & session NULL");
     GNUNET_break_op (0);
-    checks_failed = GNUNET_YES;
-  }
-
-  n = lookup_neighbour (peer);
-  if (NULL == n)
-    checks_failed = GNUNET_YES;
-
-  if (checks_failed == GNUNET_YES)
-  {
-    GNUNET_ATS_address_destroyed (GST_ats, peer, plugin_name, address,
-                                  address_len, session);
-    if (n != NULL)
-      GNUNET_ATS_suggest_address (GST_ats, peer);
+    GNUNET_ATS_address_destroyed (GST_ats, address, session);
+    GNUNET_ATS_suggest_address (GST_ats, peer);
     return GNUNET_NO;
   }
 
   /* checks successful and neighbour != NULL */
 #if DEBUG_TRANSPORT
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "ATS tells us to switch to plugin `%s' address '%s' session %X for %s peer `%s'\n",
-              plugin_name,
-              (address_len == 0) ? "<inbound>" : GST_plugins_a2s (plugin_name,
-                                                                  address,
-                                                                  address_len),
-              session, (is_connected (n) ? "CONNECTED" : "NOT CONNECTED"),
+              "ATS tells us to switch to address '%s' session %p for %s peer `%s'\n",
+              GST_plugins_a2s (address),
+              session, (S_CONNECTED == n->state) ? "CONNECTED" : "NOT CONNECTED",
               GNUNET_i2s (peer));
 #endif
-
   if (n->ats_suggest != GNUNET_SCHEDULER_NO_TASK)
   {
     GNUNET_SCHEDULER_cancel (n->ats_suggest);
     n->ats_suggest = GNUNET_SCHEDULER_NO_TASK;
   }
-
-  // do not switch addresses just update quotas
-  if ((is_connected (n)) && (address_len == n->addrlen))
+  /* do not switch addresses just update quotas */
+  if ( (n->state == S_CONNECTED) && 
+       (NULL != n->address) &&
+       (0 == GNUNET_HELLO_address_cmp (address,
+                                      n->address)) &&
+       (n->session == session) )
   {
-    if ((0 == memcmp (address, n->addr, address_len)) &&
-        (n->session == session))
-    {
-      struct QuotaSetMessage q_msg;
-
+    struct QuotaSetMessage q_msg;
+    
 #if DEBUG_TRANSPORT
-      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                  "Sending outbound quota of %u Bps and inbound quota of %u Bps for peer `%s' to all clients\n",
-                  ntohl (n->bandwidth_out.value__),
-                  ntohl (n->bandwidth_in.value__), GNUNET_i2s (peer));
+    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+               "Sending outbound quota of %u Bps and inbound quota of %u Bps for peer `%s' to all clients\n",
+               ntohl (n->bandwidth_out.value__),
+               ntohl (n->bandwidth_in.value__), GNUNET_i2s (peer));
 #endif
-
-      n->bandwidth_in = bandwidth_in;
-      n->bandwidth_out = bandwidth_out;
-      GST_neighbours_set_incoming_quota (&n->id, n->bandwidth_in);
-
-      q_msg.header.size = htons (sizeof (struct QuotaSetMessage));
-      q_msg.header.type = htons (GNUNET_MESSAGE_TYPE_TRANSPORT_SET_QUOTA);
-      q_msg.quota = n->bandwidth_out;
-      q_msg.peer = (*peer);
-      GST_clients_broadcast (&q_msg.header, GNUNET_NO);
-      return GNUNET_NO;
-    }
-  }
-
-  GNUNET_free_non_null (n->addr);
-  n->addr = GNUNET_malloc (address_len);
-  memcpy (n->addr, address, address_len);
+    
+    n->bandwidth_in = bandwidth_in;
+    n->bandwidth_out = bandwidth_out;
+    GST_neighbours_set_incoming_quota (&n->id, n->bandwidth_in);
+    
+    q_msg.header.size = htons (sizeof (struct QuotaSetMessage));
+    q_msg.header.type = htons (GNUNET_MESSAGE_TYPE_TRANSPORT_SET_QUOTA);
+    q_msg.quota = n->bandwidth_out;
+    q_msg.peer = (*peer);
+    GST_clients_broadcast (&q_msg.header, GNUNET_NO);
+    return GNUNET_NO;    
+  }
+  if (n->state == S_CONNECTED) 
+  {
+    /* mark old address as no longer used */
+    GNUNET_assert (NULL != n->address);
+    GST_validation_set_address_use (&n->id,
+                                   n->address,
+                                   n->session,
+                                   GNUNET_NO);
+    GNUNET_ATS_address_in_use (GST_ats, n->address, n->session, GNUNET_NO);
+  }
+
+  /* set new address */
+  if (NULL != n->address)
+    GNUNET_HELLO_address_free (n->address);
+  n->address = GNUNET_HELLO_address_copy (address);
+  n->session = session;
   n->bandwidth_in = bandwidth_in;
   n->bandwidth_out = bandwidth_out;
-  n->addrlen = address_len;
-  n->session = session;
-  GNUNET_free_non_null (n->plugin_name);
-  n->plugin_name = GNUNET_strdup (plugin_name);
   GNUNET_SCHEDULER_cancel (n->timeout_task);
   n->timeout_task =
       GNUNET_SCHEDULER_add_delayed (GNUNET_CONSTANTS_IDLE_CONNECTION_TIMEOUT,
                                     &neighbour_timeout_task, n);
-
-  if (n->state == S_DISCONNECT)
-  {
-    /* We are disconnecting, nothing to do here */
-    return GNUNET_NO;
-  }
-  /* We are not connected/connecting and initiate a fresh connect */
-  if (n->state == S_NOT_CONNECTED)
+  switch (n->state)
   {
+  case S_NOT_CONNECTED:  
+  case S_CONNECT_SENT:
     msg_len = sizeof (struct SessionConnectMessage);
     connect_msg.header.size = htons (msg_len);
     connect_msg.header.type =
@@ -1314,20 +1277,16 @@ GST_neighbours_switch_to_address_3way (const struct GNUNET_PeerIdentity *peer,
     connect_msg.reserved = htonl (0);
     connect_msg.timestamp =
         GNUNET_TIME_absolute_hton (GNUNET_TIME_absolute_get ());
-
     change_state (n, S_CONNECT_SENT);
-
     ret =
         send_with_plugin (peer, (const char *) &connect_msg, msg_len,
                           UINT32_MAX, GNUNET_TIME_UNIT_FOREVER_REL, session,
-                          plugin_name, address, address_len, GNUNET_YES,
-                          &send_connect_continuation, n);
-
+                          address, GNUNET_YES,
+                          &send_connect_continuation, 
+                         GNUNET_HELLO_address_copy (address));
     return GNUNET_NO;
-  }
-  /* We received a CONNECT message and asked ATS for an address */
-  else if (n->state == S_CONNECT_RECV)
-  {
+  case S_CONNECT_RECV:
+    /* We received a CONNECT message and asked ATS for an address */
     msg_len = sizeof (struct SessionConnectMessage);
     connect_msg.header.size = htons (msg_len);
     connect_msg.header.type =
@@ -1335,17 +1294,18 @@ GST_neighbours_switch_to_address_3way (const struct GNUNET_PeerIdentity *peer,
     connect_msg.reserved = htonl (0);
     connect_msg.timestamp =
         GNUNET_TIME_absolute_hton (GNUNET_TIME_absolute_get ());
-
     ret =
         send_with_plugin (&n->id, (const void *) &connect_msg, msg_len,
                           UINT32_MAX, GNUNET_TIME_UNIT_FOREVER_REL, session,
-                          plugin_name, address, address_len, GNUNET_YES,
+                          address, GNUNET_YES,
                           &send_connect_ack_continuation, n);
     return GNUNET_NO;
-  }
-  /* connected peer is switching addresses */
-  else if (n->state == S_CONNECTED)
-  {
+  case S_CONNECTED:
+    /* connected peer is switching addresses */
+    GST_validation_set_address_use (&n->id,
+                                   n->address,
+                                   n->session,
+                                   GNUNET_YES);
     msg_len = sizeof (struct SessionConnectMessage);
     connect_msg.header.size = htons (msg_len);
     connect_msg.header.type =
@@ -1353,31 +1313,47 @@ GST_neighbours_switch_to_address_3way (const struct GNUNET_PeerIdentity *peer,
     connect_msg.reserved = htonl (0);
     connect_msg.timestamp =
         GNUNET_TIME_absolute_hton (GNUNET_TIME_absolute_get ());
-
     ret =
         send_with_plugin (peer, (const char *) &connect_msg, msg_len,
                           UINT32_MAX, GNUNET_TIME_UNIT_FOREVER_REL, session,
-                          plugin_name, address, address_len, GNUNET_YES,
+                          address, GNUNET_YES,
                           &send_switch_address_continuation, n);
     if (ret == GNUNET_SYSERR)
     {
       GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                  "Failed to send CONNECT_MESSAGE to `%4s' using plugin `%s' address '%s' session %X\n",
-                  GNUNET_i2s (peer), plugin_name,
-                  (address_len ==
-                   0) ? "<inbound>" : GST_plugins_a2s (plugin_name, address,
-                                                       address_len), session);
+                  "Failed to send CONNECT_MESSAGE to `%4s' using address '%s' session %X\n",
+                  GNUNET_i2s (peer), 
+                 GST_plugins_a2s (address), session);
     }
     return GNUNET_NO;
-  }
-  else if (n->state == S_CONNECT_SENT)
-  {
+  default:
+    GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+               "Invalid connection state to switch addresses %u \n", n->state);
+    GNUNET_break_op (0);
     return GNUNET_NO;
   }
-  GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
-              "Invalid connection state to switch addresses %u \n", n->state);
-  GNUNET_break_op (0);
-  return GNUNET_NO;
+}
+
+
+/**
+ * Obtain current latency information for the given neighbour.
+ *
+ * @param peer 
+ * @return observed latency of the address, FOREVER if the address was
+ *         never successfully validated
+ */
+struct GNUNET_TIME_Relative
+GST_neighbour_get_latency (const struct GNUNET_PeerIdentity *peer)
+{
+  struct NeighbourMapEntry *n;
+
+  n = lookup_neighbour (peer);
+  if ( (NULL == n) ||
+       ( (n->address == NULL) && (n->session == NULL) ) )
+    return GNUNET_TIME_UNIT_FOREVER_REL;
+  return GST_validation_get_address_latency (peer,
+                                            n->address,
+                                            n->session);
 }
 
 
@@ -1442,7 +1418,7 @@ GST_neighbours_try_connect (const struct GNUNET_PeerIdentity *target)
 
   if (NULL != n)
   {
-    if ((is_connected (n)) || (is_connecting (n)))
+    if ((S_CONNECTED == n->state) || (is_connecting (n)))
       return;                   /* already connecting or connected */
     if (is_disconnecting (n))
       change_state (n, S_NOT_CONNECTED);
@@ -1479,7 +1455,7 @@ GST_neighbours_test_connected (const struct GNUNET_PeerIdentity *target)
 
   n = lookup_neighbour (target);
 
-  if ((NULL == n) || (!is_connected (n)))
+  if ((NULL == n) || (S_CONNECTED != n->state))
     return GNUNET_NO;           /* not connected */
   return GNUNET_YES;
 }
@@ -1497,9 +1473,9 @@ GST_neighbours_session_terminated (const struct GNUNET_PeerIdentity *peer,
 {
   struct NeighbourMapEntry *n;
 
-  // This can happen during shutdown
   if (neighbours == NULL)
   {
+    /* This can happen during shutdown */
     return;
   }
 
@@ -1513,15 +1489,22 @@ GST_neighbours_session_terminated (const struct GNUNET_PeerIdentity *peer,
     return;
   if (session != n->session)
     return;                     /* doesn't affect us */
-
+  if (n->state == S_CONNECTED)
+    GST_validation_set_address_use (&n->id,
+                                   n->address,
+                                   n->session,
+                                   GNUNET_NO);
   n->session = NULL;
-  GNUNET_free (n->addr);
-  n->addr = NULL;
-  n->addrlen = 0;
-
+  if (NULL != n->address)
+  {
+    GNUNET_HELLO_address_free (n->address);
+    n->address = NULL;
+  }
+  
   /* not connected anymore anyway, shouldn't matter */
-  if ((!is_connected (n)) && (!is_connecting (n)))
+  if ((S_CONNECTED != n->state) && (!is_connecting (n)))
     return;
+  // FIXME: n->state = S_FAST_RECONNECT;
 
   /* We are connected, so ask ATS to switch addresses */
   GNUNET_SCHEDULER_cancel (n->timeout_task);
@@ -1532,7 +1515,7 @@ GST_neighbours_session_terminated (const struct GNUNET_PeerIdentity *peer,
   if (n->ats_suggest != GNUNET_SCHEDULER_NO_TASK)
     GNUNET_SCHEDULER_cancel (n->ats_suggest);
   n->ats_suggest =
-      GNUNET_SCHEDULER_add_delayed (ATS_RESPONSE_TIMEOUT, ats_suggest_cancel,
+      GNUNET_SCHEDULER_add_delayed (ATS_RESPONSE_TIMEOUT, &ats_suggest_cancel,
                                     n);
   GNUNET_ATS_suggest_address (GST_ats, peer);
 }
@@ -1584,7 +1567,7 @@ GST_neighbours_send (const struct GNUNET_PeerIdentity *target, const void *msg,
     return;
   }
 
-  if ((n->session == NULL) && (n->addr == NULL) && (n->addrlen == 0))
+  if ((n->session == NULL) && (n->address == NULL) )
   {
     GNUNET_STATISTICS_update (GST_stats,
                               gettext_noop
@@ -1826,7 +1809,7 @@ neighbours_iterate (void *cls, const GNUNET_HashCode * key, void *value)
   if (!is_connected (n))
     return GNUNET_OK;
 
-  ic->cb (ic->cb_cls, &n->id, NULL, 0, n->plugin_name, n->addr, n->addrlen);
+  ic->cb (ic->cb_cls, &n->id, NULL, 0, n->address);
   return GNUNET_OK;
 }
 
@@ -1874,7 +1857,7 @@ GST_neighbours_force_disconnect (const struct GNUNET_PeerIdentity *target)
     return;                     /* not active */
   if (is_connected (n))
   {
-    send_disconnect (&n->id, n->plugin_name, n->addr, n->addrlen, n->session);
+    send_disconnect (&n->id, n->address, n->session);
 
     n = lookup_neighbour (target);
     if (NULL == n)
@@ -1956,26 +1939,23 @@ GST_neighbours_handle_disconnect_message (const struct GNUNET_PeerIdentity
   GST_neighbours_force_disconnect (peer);
 }
 
+
 /**
  * We received a 'SESSION_CONNECT_ACK' message from the other peer.
  * Consider switching to it.
  *
  * @param message possibly a 'struct SessionConnectMessage' (check format)
  * @param peer identity of the peer to switch the address for
- * @param plugin_name name of transport that delivered the PONG
  * @param address address of the other peer, NULL if other peer
  *                       connected to us
- * @param address_len number of bytes in address
  * @param session session to use (or NULL)
  * @param ats performance data
  * @param ats_count number of entries in ats
 */
+ */
 void
 GST_neighbours_handle_connect_ack (const struct GNUNET_MessageHeader *message,
                                    const struct GNUNET_PeerIdentity *peer,
-                                   const char *plugin_name,
-                                   const char *sender_address,
-                                   uint16_t sender_address_len,
+                                   const struct GNUNET_HELLO_Address *address,
                                    struct Session *session,
                                    const struct GNUNET_ATS_Information *ats,
                                    uint32_t ats_count)
@@ -1986,48 +1966,46 @@ GST_neighbours_handle_connect_ack (const struct GNUNET_MessageHeader *message,
   struct NeighbourMapEntry *n;
   size_t msg_len;
   size_t ret;
-  int was_connected;
 
 #if DEBUG_TRANSPORT
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
               "Received CONNECT_ACK message from peer `%s'\n",
               GNUNET_i2s (peer));
 #endif
-
   if (ntohs (message->size) != sizeof (struct SessionConnectMessage))
   {
     GNUNET_break_op (0);
     return;
   }
-
   scm = (const struct SessionConnectMessage *) message;
   GNUNET_break_op (ntohl (scm->reserved) == 0);
   n = lookup_neighbour (peer);
   if (NULL == n)
-    n = setup_neighbour (peer);
-/*
+  {
+    /* we did not send 'CONNECT' (how could we? no record for this peer!) */
+    GNUNET_break_op (0);
+    return;
+  }  
   if (n->state != S_CONNECT_SENT)
   {
-    GNUNET_break (0);
-    send_disconnect(&n->id, n->plugin_name, n->addr, n->addrlen, n->session);
+    GNUNET_STATISTICS_update (GST_stats,
+                             gettext_noop ("# unexpected CONNECT_ACK messages"), 1,
+                             GNUNET_NO);
     return;
   }
-*/
   if (NULL != session)
     GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG | GNUNET_ERROR_TYPE_BULK,
                      "transport-ats",
                      "Giving ATS session %p of plugin %s for peer %s\n",
-                     session, plugin_name, GNUNET_i2s (peer));
-  GNUNET_ATS_address_update (GST_ats, peer, plugin_name, sender_address,
-                             sender_address_len, session, ats, ats_count);
-
-  was_connected = is_connected (n);
-  if (!is_connected (n))
-    change_state (n, S_CONNECTED);
-
-  GNUNET_ATS_address_in_use (GST_ats, peer, plugin_name, sender_address,
-                             sender_address_len, session, GNUNET_YES);
-
+                     session, address->transport_name, GNUNET_i2s (peer));
+  GNUNET_ATS_address_update (GST_ats, address, session, ats, ats_count);
+  GNUNET_assert (NULL != n->address);
+  change_state (n, S_CONNECTED);
+  GST_validation_set_address_use (&n->id,
+                                 n->address,
+                                 n->session,
+                                 GNUNET_YES);
+  GNUNET_ATS_address_in_use (GST_ats, n->address, n->session, GNUNET_YES);
 #if DEBUG_TRANSPORT
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
               "Setting inbound quota of %u for peer `%s' to \n",
@@ -2043,39 +2021,32 @@ GST_neighbours_handle_connect_ack (const struct GNUNET_MessageHeader *message,
   ret =
       send_with_plugin (&n->id, (const char *) &msg, msg_len, UINT32_MAX,
                         GNUNET_TIME_UNIT_FOREVER_REL, n->session,
-                        n->plugin_name, n->addr, n->addrlen, GNUNET_YES, NULL,
+                        n->address, GNUNET_YES, NULL,
                         NULL);
 
   if (ret == GNUNET_SYSERR)
     GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                "Failed to send SESSION_ACK to `%4s' using plugin `%s' address '%s' session %X\n",
-                GNUNET_i2s (&n->id), n->plugin_name,
-                (n->addrlen ==
-                 0) ? "<inbound>" : GST_plugins_a2s (n->plugin_name, n->addr,
-                                                     n->addrlen), n->session);
+                "Failed to send SESSION_ACK to `%4s' using address '%s' session %X\n",
+                GNUNET_i2s (&n->id), 
+                GST_plugins_a2s (n->address), n->session);
 
 
-  if (!was_connected)
-  {
-    if (n->keepalive_task == GNUNET_SCHEDULER_NO_TASK)
-      n->keepalive_task =
-          GNUNET_SCHEDULER_add_delayed (KEEPALIVE_FREQUENCY,
-                                        &neighbour_keepalive_task, n);
-
-    neighbours_connected++;
-    GNUNET_STATISTICS_update (GST_stats, gettext_noop ("# peers connected"), 1,
-                              GNUNET_NO);
+  if (n->keepalive_task == GNUNET_SCHEDULER_NO_TASK)
+    n->keepalive_task =
+      GNUNET_SCHEDULER_add_delayed (KEEPALIVE_FREQUENCY,
+                                   &neighbour_keepalive_task, n);
+  
+  neighbours_connected++;
+  GNUNET_STATISTICS_update (GST_stats, gettext_noop ("# peers connected"), 1,
+                           GNUNET_NO);
 #if DEBUG_TRANSPORT
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                "Notify about connect of `%4s' using plugin `%s' address '%s' session %X LINE %u\n",
-                GNUNET_i2s (&n->id), n->plugin_name,
-                (n->addrlen ==
-                 0) ? "<inbound>" : GST_plugins_a2s (n->plugin_name, n->addr,
-                                                     n->addrlen), n->session,
-                __LINE__);
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+             "Notify about connect of `%4s' using address '%s' session %X LINE %u\n",
+             GNUNET_i2s (&n->id),
+             GST_plugins_a2s (n->address), n->session,
+             __LINE__);
 #endif
-    connect_notify_cb (callback_cls, &n->id, ats, ats_count);
-  }
+  connect_notify_cb (callback_cls, &n->id, ats, ats_count);  
 
 #if DEBUG_TRANSPORT
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
@@ -2090,20 +2061,21 @@ GST_neighbours_handle_connect_ack (const struct GNUNET_MessageHeader *message,
 
 }
 
+
 void
 GST_neighbours_handle_ack (const struct GNUNET_MessageHeader *message,
                            const struct GNUNET_PeerIdentity *peer,
-                           const char *plugin_name, const char *sender_address,
-                           uint16_t sender_address_len, struct Session *session,
+                           const struct GNUNET_HELLO_Address *address,
+                          struct Session *session,
                            const struct GNUNET_ATS_Information *ats,
                            uint32_t ats_count)
 {
   struct NeighbourMapEntry *n;
   struct QuotaSetMessage q_msg;
-  int was_connected;
 
 #if DEBUG_TRANSPORT
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Received ACK message from peer `%s'\n",
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, 
+             "Received ACK message from peer `%s'\n",
               GNUNET_i2s (peer));
 #endif
 
@@ -2112,32 +2084,31 @@ GST_neighbours_handle_ack (const struct GNUNET_MessageHeader *message,
     GNUNET_break_op (0);
     return;
   }
-
   n = lookup_neighbour (peer);
   if (NULL == n)
   {
-    send_disconnect (peer, plugin_name, sender_address, sender_address_len,
+    send_disconnect (peer, address,
                      session);
     GNUNET_break (0);
     return;
   }
-
-  if (is_connected (n))
+  if (S_CONNECTED == n->state)
     return;
-
+  if (!is_connecting(n))
+  {
+    GNUNET_STATISTICS_update (GST_stats, gettext_noop ("# unexpected ACK messages"), 1,
+                              GNUNET_NO);
+    return;
+  }
   if (NULL != session)
     GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG | GNUNET_ERROR_TYPE_BULK,
                      "transport-ats",
                      "Giving ATS session %p of plugin %s for peer %s\n",
-                     session, plugin_name, GNUNET_i2s (peer));
-  GNUNET_ATS_address_update (GST_ats, peer, plugin_name, sender_address,
-                             sender_address_len, session, ats, ats_count);
-
-  was_connected = is_connected (n);
+                     session, address->transport_name, GNUNET_i2s (peer));
+  GNUNET_ATS_address_update (GST_ats, address, session, ats, ats_count);
+  GNUNET_assert (n->address != NULL);
   change_state (n, S_CONNECTED);
-
-  GNUNET_ATS_address_in_use (GST_ats, peer, plugin_name, sender_address,
-                             sender_address_len, session, GNUNET_YES);
+  GNUNET_ATS_address_in_use (GST_ats, n->address, n->session, GNUNET_YES);
 
   GST_neighbours_set_incoming_quota (&n->id, n->bandwidth_in);
 
@@ -2145,24 +2116,22 @@ GST_neighbours_handle_ack (const struct GNUNET_MessageHeader *message,
     n->keepalive_task =
         GNUNET_SCHEDULER_add_delayed (KEEPALIVE_FREQUENCY,
                                       &neighbour_keepalive_task, n);
-
-  if (!was_connected)
-  {
-    neighbours_connected++;
-    GNUNET_STATISTICS_update (GST_stats, gettext_noop ("# peers connected"), 1,
-                              GNUNET_NO);
-
+  GST_validation_set_address_use (&n->id,
+                                 n->address,
+                                 n->session,
+                                 GNUNET_YES);
+  neighbours_connected++;
+  GNUNET_STATISTICS_update (GST_stats, gettext_noop ("# peers connected"), 1,
+                           GNUNET_NO);
+  
 #if DEBUG_TRANSPORT
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                "Notify about connect of `%4s' using plugin `%s' address '%s' session %X LINE %u\n",
-                GNUNET_i2s (&n->id), n->plugin_name,
-                (n->addrlen ==
-                 0) ? "<inbound>" : GST_plugins_a2s (n->plugin_name, n->addr,
-                                                     n->addrlen), n->session,
-                __LINE__);
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+             "Notify about connect of `%4s' using address '%s' session %X LINE %u\n",
+             GNUNET_i2s (&n->id),
+             GST_plugins_a2s (n->address), n->session,
+             __LINE__);
 #endif
-    connect_notify_cb (callback_cls, &n->id, ats, ats_count);
-  }
+  connect_notify_cb (callback_cls, &n->id, ats, ats_count);  
 #if DEBUG_TRANSPORT
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
               "Sending outbound quota of %u Bps for peer `%s' to all clients\n",
@@ -2183,11 +2152,7 @@ struct BlackListCheckContext
 
   struct Session *session;
 
-  char *sender_address;
-
-  uint16_t sender_address_len;
-
-  char *plugin_name;
+  struct GNUNET_HELLO_Address *address;
 
   struct GNUNET_TIME_Absolute ts;
 };
@@ -2211,6 +2176,7 @@ handle_connect_blacklist_cont (void *cls,
   /* not allowed */
   if (GNUNET_OK != result)
   {
+    GNUNET_HELLO_address_free (bcc->address);
     GNUNET_free (bcc);
     return;
   }
@@ -2224,13 +2190,11 @@ handle_connect_blacklist_cont (void *cls,
     if (NULL != bcc->session)
       GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG | GNUNET_ERROR_TYPE_BULK,
                        "transport-ats",
-                       "Giving ATS session %p of plugin %s address `%s' for peer %s\n",
-                       bcc->session, bcc->plugin_name,
-                       GST_plugins_a2s (bcc->plugin_name, bcc->sender_address,
-                                        bcc->sender_address_len),
+                       "Giving ATS session %p of address `%s' for peer %s\n",
+                       bcc->session, 
+                       GST_plugins_a2s (bcc->address),
                        GNUNET_i2s (peer));
-    GNUNET_ATS_address_update (GST_ats, peer, bcc->plugin_name,
-                               bcc->sender_address, bcc->sender_address_len,
+    GNUNET_ATS_address_update (GST_ats, bcc->address,
                                bcc->session, bcc->ats, bcc->ats_count);
     n->connect_ts = bcc->ts;
   }
@@ -2255,20 +2219,16 @@ handle_connect_blacklist_cont (void *cls,
  *
  * @param message possibly a 'struct SessionConnectMessage' (check format)
  * @param peer identity of the peer to switch the address for
- * @param plugin_name name of transport that delivered the PONG
  * @param address address of the other peer, NULL if other peer
  *                       connected to us
- * @param address_len number of bytes in address
  * @param session session to use (or NULL)
  * @param ats performance data
  * @param ats_count number of entries in ats (excluding 0-termination)
 */
+ */
 void
 GST_neighbours_handle_connect (const struct GNUNET_MessageHeader *message,
                                const struct GNUNET_PeerIdentity *peer,
-                               const char *plugin_name,
-                               const char *sender_address,
-                               uint16_t sender_address_len,
+                               const struct GNUNET_HELLO_Address *address,
                                struct Session *session,
                                const struct GNUNET_ATS_Information *ats,
                                uint32_t ats_count)
@@ -2292,40 +2252,28 @@ GST_neighbours_handle_connect (const struct GNUNET_MessageHeader *message,
   GNUNET_break_op (ntohl (scm->reserved) == 0);
 
   n = lookup_neighbour (peer);
-  if (n != NULL)
+  if ( (n != NULL) &&
+       (S_CONNECTED == n->state) )
   {
     /* connected peer switches addresses */
-    if (is_connected (n))
-    {
-      GNUNET_ATS_address_update (GST_ats, peer, plugin_name, sender_address,
-                                 sender_address_len, session, ats, ats_count);
-      return;
-    }
+    GNUNET_ATS_address_update (GST_ats, address, session, ats, ats_count);
+    return;
   }
 
   /* we are not connected to this peer */
   /* do blacklist check */
   bcc =
       GNUNET_malloc (sizeof (struct BlackListCheckContext) +
-                     sizeof (struct GNUNET_ATS_Information) * ats_count +
-                     sender_address_len + strlen (plugin_name) + 1);
-
+                     sizeof (struct GNUNET_ATS_Information) * (ats_count + 1));
   bcc->ts = GNUNET_TIME_absolute_ntoh (scm->timestamp);
-
-  bcc->ats_count = ats_count;
-  bcc->sender_address_len = sender_address_len;
+  bcc->ats_count = ats_count + 1;
+  bcc->address = GNUNET_HELLO_address_copy (address);
   bcc->session = session;
-
   bcc->ats = (struct GNUNET_ATS_Information *) &bcc[1];
   memcpy (bcc->ats, ats, sizeof (struct GNUNET_ATS_Information) * ats_count);
-
-  bcc->sender_address = (char *) &bcc->ats[ats_count];
-  memcpy (bcc->sender_address, sender_address, sender_address_len);
-
-  bcc->plugin_name = &bcc->sender_address[sender_address_len];
-  strcpy (bcc->plugin_name, plugin_name);
-
-  GST_blacklist_test_allowed (peer, plugin_name, handle_connect_blacklist_cont,
+  bcc->ats[ats_count].type = htonl (GNUNET_ATS_QUALITY_NET_DELAY);
+  bcc->ats[ats_count].value = htonl ((uint32_t) GST_neighbour_get_latency (peer).rel_value);
+  GST_blacklist_test_allowed (peer, address->transport_name, handle_connect_blacklist_cont,
                               bcc);
 }