-fix NPE
[oweals/gnunet.git] / src / transport / gnunet-service-transport_neighbours.c
index 461d2669a00b416c65f75ba76dfc80d03088f6d2..07af225c1296e4934847db2f8e474f858c66468e 100644 (file)
 #include "gnunet_constants.h"
 #include "transport.h"
 
+/**
+ * Experimental option to ignore SessionQuotaMessages from
+ * the other peer.
+ */
+#define IGNORE_INBOUND_QUOTA GNUNET_YES
 
 /**
  * Size of the neighbour hash map.
@@ -143,7 +148,7 @@ struct TransportSynMessage
  * When the keep alive response with type is received, transport service
  * will call the respective plugin to update the session timeout
  */
-struct SessionKeepAliveMessage
+struct GNUNET_ATS_SessionKeepAliveMessage
 {
   /**
    * Header of type #GNUNET_MESSAGE_TYPE_TRANSPORT_SESSION_KEEPALIVE or
@@ -163,7 +168,7 @@ struct SessionKeepAliveMessage
  * the other peer should limit transmissions to the indicated
  * quota.
  */
-struct SessionQuotaMessage
+struct GNUNET_ATS_SessionQuotaMessage
 {
   /**
    * Header of type #GNUNET_MESSAGE_TYPE_TRANSPORT_SESSION_QUOTA.
@@ -183,7 +188,7 @@ struct SessionQuotaMessage
  * notification, peers must not rely on always receiving disconnect
  * messages.
  */
-struct SessionDisconnectMessage
+struct GNUNET_ATS_SessionDisconnectMessage
 {
   /**
    * Header of type #GNUNET_MESSAGE_TYPE_TRANSPORT_SESSION_DISCONNECT
@@ -279,7 +284,7 @@ struct NeighbourAddress
   /**
    * Active session for this address.
    */
-  struct Session *session;
+  struct GNUNET_ATS_Session *session;
 
   /**
    * Network-level address information.
@@ -554,28 +559,32 @@ print_ack_state (enum GST_ACK_State s)
 /**
  * Notify our clients that another peer connected to us.
  *
- * @param peer the peer that connected
- * @param bandwidth_in inbound bandwidth in NBO
- * @param bandwidth_out outbound bandwidth in NBO
+ * @param n the peer that connected
  */
 static void
-neighbours_connect_notification (const struct GNUNET_PeerIdentity *peer,
-                                 struct GNUNET_BANDWIDTH_Value32NBO bandwidth_in,
-                                 struct GNUNET_BANDWIDTH_Value32NBO bandwidth_out)
+neighbours_connect_notification (struct NeighbourMapEntry *n)
 {
   size_t len = sizeof(struct ConnectInfoMessage);
   char buf[len] GNUNET_ALIGN;
   struct ConnectInfoMessage *connect_msg = (struct ConnectInfoMessage *) buf;
+  struct GNUNET_BANDWIDTH_Value32NBO bandwidth_min;
 
+#if IGNORE_INBOUND_QUOTA
+  bandwidth_min = n->primary_address.bandwidth_out;
+#else
+  bandwidth_min = GNUNET_BANDWIDTH_value_min (n->primary_address.bandwidth_out,
+                                              n->neighbour_receive_quota);
+#endif
   GNUNET_log (GNUNET_ERROR_TYPE_INFO,
               "We are now connected to peer `%s'\n",
-              GNUNET_i2s (peer));
+              GNUNET_i2s (&n->id));
   connect_msg->header.size = htons (sizeof(buf));
   connect_msg->header.type = htons (GNUNET_MESSAGE_TYPE_TRANSPORT_CONNECT);
-  connect_msg->id = *peer;
-  connect_msg->quota_in = bandwidth_in;
-  connect_msg->quota_out = bandwidth_out;
-  GST_clients_broadcast (&connect_msg->header, GNUNET_NO);
+  connect_msg->id = n->id;
+  connect_msg->quota_in = n->primary_address.bandwidth_in;
+  connect_msg->quota_out = bandwidth_min;
+  GST_clients_broadcast (&connect_msg->header,
+                         GNUNET_NO);
 }
 
 
@@ -583,21 +592,21 @@ neighbours_connect_notification (const struct GNUNET_PeerIdentity *peer,
  * Notify our clients (and manipulation) that a peer disconnected from
  * us.
  *
- * @param peer the peer that disconnected
+ * @param n the peer that disconnected
  */
 static void
-neighbours_disconnect_notification (const struct GNUNET_PeerIdentity *peer)
+neighbours_disconnect_notification (struct NeighbourMapEntry *n)
 {
   struct DisconnectInfoMessage disconnect_msg;
 
   GNUNET_log (GNUNET_ERROR_TYPE_INFO,
               "Peer `%s' disconnected\n",
-              GNUNET_i2s (peer));
-  GST_manipulation_peer_disconnect (peer);
+              GNUNET_i2s (&n->id));
+  GST_manipulation_peer_disconnect (&n->id);
   disconnect_msg.header.size = htons (sizeof(struct DisconnectInfoMessage));
   disconnect_msg.header.type = htons (GNUNET_MESSAGE_TYPE_TRANSPORT_DISCONNECT);
   disconnect_msg.reserved = htonl (0);
-  disconnect_msg.peer = *peer;
+  disconnect_msg.peer = n->id;
   GST_clients_broadcast (&disconnect_msg.header,
                          GNUNET_NO);
 }
@@ -671,23 +680,31 @@ test_connected (struct NeighbourMapEntry *n)
  * Note that the outbound quota is enforced client-side (i.e.
  * in libgnunettransport).
  *
- * @param target affected peer
- * @param quota new quota
+ * @param n affected peer
  */
 static void
-send_outbound_quota_to_clients (const struct GNUNET_PeerIdentity *target,
-                                struct GNUNET_BANDWIDTH_Value32NBO quota)
+send_outbound_quota_to_clients (struct NeighbourMapEntry *n)
 {
   struct QuotaSetMessage q_msg;
+  struct GNUNET_BANDWIDTH_Value32NBO bandwidth_min;
+
+  if (! GNUNET_TRANSPORT_is_connected (n->state))
+    return;
+#if IGNORE_INBOUND_QUOTA
+  bandwidth_min = n->primary_address.bandwidth_out;
+#else
+  bandwidth_min = GNUNET_BANDWIDTH_value_min (n->primary_address.bandwidth_out,
+                                              n->neighbour_receive_quota);
+#endif
 
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
               "Sending outbound quota of %u Bps for peer `%s' to all clients\n",
-              ntohl (quota.value__),
-              GNUNET_i2s (target));
+              ntohl (bandwidth_min.value__),
+              GNUNET_i2s (&n->id));
   q_msg.header.size = htons (sizeof (struct QuotaSetMessage));
   q_msg.header.type = htons (GNUNET_MESSAGE_TYPE_TRANSPORT_SET_QUOTA);
-  q_msg.quota = quota;
-  q_msg.peer = (*target);
+  q_msg.quota = bandwidth_min;
+  q_msg.peer = n->id;
   GST_clients_broadcast (&q_msg.header, GNUNET_NO);
 }
 
@@ -748,9 +765,7 @@ set_state_and_timeout (struct NeighbourMapEntry *n,
   if (GNUNET_TRANSPORT_is_connected (s) &&
       ! GNUNET_TRANSPORT_is_connected (n->state) )
   {
-    neighbours_connect_notification (&n->id,
-                                     n->primary_address.bandwidth_in,
-                                     n->primary_address.bandwidth_out);
+    neighbours_connect_notification (n);
     GNUNET_STATISTICS_set (GST_stats,
                           gettext_noop ("# peers connected"),
                           ++neighbours_connected,
@@ -763,7 +778,7 @@ set_state_and_timeout (struct NeighbourMapEntry *n,
                           gettext_noop ("# peers connected"),
                           --neighbours_connected,
                           GNUNET_NO);
-    neighbours_disconnect_notification (&n->id);
+    neighbours_disconnect_notification (n);
   }
   n->state = s;
   if ( (timeout.abs_value_us < n->timeout.abs_value_us) &&
@@ -804,7 +819,7 @@ set_state_and_timeout (struct NeighbourMapEntry *n,
 static void
 set_alternative_address (struct NeighbourMapEntry *n,
                          const struct GNUNET_HELLO_Address *address,
-                         struct Session *session,
+                         struct GNUNET_ATS_Session *session,
                          struct GNUNET_BANDWIDTH_Value32NBO bandwidth_in,
                          struct GNUNET_BANDWIDTH_Value32NBO bandwidth_out)
 {
@@ -862,87 +877,57 @@ set_alternative_address (struct NeighbourMapEntry *n,
 
 
 /**
- * Initialize the primary address of a neighbour
+ * Transmit a message using the current session of the given
+ * neighbour.
  *
- * @param n the neighbour
- * @param address address of the other peer, NULL if other peer
- *                       connected to us
- * @param session session to use (or NULL, in which case an
- *        address must be setup)
- * @param bandwidth_in inbound quota to be used when connection is up
- * @param bandwidth_out outbound quota to be used when connection is up
+ * @param n entry for the recipient
+ * @param msgbuf buffer to transmit
+ * @param msgbuf_size number of bytes in @a msgbuf buffer
+ * @param priority transmission priority
+ * @param timeout transmission timeout
+ * @param use_keepalive_timeout #GNUNET_YES to use plugin-specific keep-alive
+ *        timeout (@a timeout is ignored in that case), #GNUNET_NO otherwise
+ * @param cont continuation to call when finished (can be NULL)
+ * @param cont_cls closure for @a cont
+ * @return timeout (copy of @a timeout or a calculated one if
+ *         @a use_keepalive_timeout is #GNUNET_YES.
  */
-static void
-set_primary_address (struct NeighbourMapEntry *n,
-                     const struct GNUNET_HELLO_Address *address,
-                     struct Session *session,
-                     struct GNUNET_BANDWIDTH_Value32NBO bandwidth_in,
-                     struct GNUNET_BANDWIDTH_Value32NBO bandwidth_out)
+static struct GNUNET_TIME_Relative
+send_with_session (struct NeighbourMapEntry *n,
+                   const void *msgbuf,
+                   size_t msgbuf_size,
+                   uint32_t priority,
+                   struct GNUNET_TIME_Relative timeout,
+                  unsigned int use_keepalive_timeout,
+                   GNUNET_TRANSPORT_TransmitContinuation cont,
+                  void *cont_cls)
 {
-  if (session == n->primary_address.session)
-  {
-    GST_validation_set_address_use (n->primary_address.address,
-                                    GNUNET_YES);
-    if (n->primary_address.bandwidth_in.value__ != bandwidth_in.value__)
-    {
-      n->primary_address.bandwidth_in = bandwidth_in;
-      GST_neighbours_set_incoming_quota (&address->peer,
-                                         bandwidth_in);
-    }
-    if (n->primary_address.bandwidth_out.value__ != bandwidth_out.value__)
-    {
-      n->primary_address.bandwidth_out = bandwidth_out;
-      send_outbound_quota_to_clients (&address->peer,
-                                      bandwidth_out);
-    }
-    return;
-  }
-  if ( (NULL != n->primary_address.address) &&
-       (0 == GNUNET_HELLO_address_cmp (address,
-                                       n->primary_address.address)) )
-  {
-    GNUNET_break (0);
-    return;
-  }
-  if (NULL == session)
-  {
-    GNUNET_break (0);
-    GST_ats_block_address (address,
-                           session);
-    return;
-  }
-  if (NULL != n->primary_address.address)
-  {
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                "Replacing existing primary address with another one\n");
-    free_address (&n->primary_address);
-  }
-  n->primary_address.address = GNUNET_HELLO_address_copy (address);
-  n->primary_address.bandwidth_in = bandwidth_in;
-  n->primary_address.bandwidth_out = bandwidth_out;
-  n->primary_address.session = session;
-  n->primary_address.keep_alive_nonce = 0;
-  GNUNET_assert (GNUNET_YES ==
-                 GST_ats_is_known (n->primary_address.address,
-                                   n->primary_address.session));
-  /* subsystems about address use */
-  GST_validation_set_address_use (n->primary_address.address,
-                                  GNUNET_YES);
-  GST_neighbours_set_incoming_quota (&address->peer,
-                                     bandwidth_in);
-  send_outbound_quota_to_clients (&address->peer,
-                                  bandwidth_out);
-  GNUNET_log (GNUNET_ERROR_TYPE_INFO,
-              "Neighbour `%s' switched to address `%s'\n",
-              GNUNET_i2s (&n->id),
-              GST_plugins_a2s(address));
+  struct GNUNET_TRANSPORT_PluginFunctions *papi;
+  struct GNUNET_TIME_Relative result = GNUNET_TIME_UNIT_FOREVER_REL;
 
-  neighbours_changed_notification (&n->id,
-                                   n->primary_address.address,
-                                   n->state,
-                                   n->timeout,
-                                   n->primary_address.bandwidth_in,
-                                   n->primary_address.bandwidth_out);
+  GNUNET_assert (NULL != n->primary_address.session);
+  if ( ((NULL == (papi = GST_plugins_find (n->primary_address.address->transport_name)) ||
+        (-1 == papi->send (papi->cls,
+                           n->primary_address.session,
+                           msgbuf,
+                            msgbuf_size,
+                           priority,
+                           (result = (GNUNET_NO == use_keepalive_timeout) ? timeout :
+                             GNUNET_TIME_relative_divide (GNUNET_CONSTANTS_IDLE_CONNECTION_TIMEOUT,
+                                                          papi->query_keepalive_factor (papi->cls))),
+                           cont,
+                            cont_cls)))) &&
+       (NULL != cont))
+    cont (cont_cls,
+          &n->id,
+          GNUNET_SYSERR,
+          msgbuf_size,
+          0);
+  GST_neighbours_notify_data_sent (n->primary_address.address,
+                                  n->primary_address.session,
+                                  msgbuf_size);
+  GNUNET_break (NULL != papi);
+  return result;
 }
 
 
@@ -1040,61 +1025,6 @@ free_neighbour (struct NeighbourMapEntry *n)
 }
 
 
-/**
- * Transmit a message using the current session of the given
- * neighbour.
- *
- * @param n entry for the recipient
- * @param msgbuf buffer to transmit
- * @param msgbuf_size number of bytes in @a msgbuf buffer
- * @param priority transmission priority
- * @param timeout transmission timeout
- * @param use_keepalive_timeout #GNUNET_YES to use plugin-specific keep-alive
- *        timeout (@a timeout is ignored in that case), #GNUNET_NO otherwise
- * @param cont continuation to call when finished (can be NULL)
- * @param cont_cls closure for @a cont
- * @return timeout (copy of @a timeout or a calculated one if
- *         @a use_keepalive_timeout is #GNUNET_YES.
- */
-static struct GNUNET_TIME_Relative
-send_with_session (struct NeighbourMapEntry *n,
-                   const void *msgbuf,
-                   size_t msgbuf_size,
-                   uint32_t priority,
-                   struct GNUNET_TIME_Relative timeout,
-                  unsigned int use_keepalive_timeout,
-                   GNUNET_TRANSPORT_TransmitContinuation cont,
-                  void *cont_cls)
-{
-  struct GNUNET_TRANSPORT_PluginFunctions *papi;
-  struct GNUNET_TIME_Relative result = GNUNET_TIME_UNIT_FOREVER_REL;
-
-  GNUNET_assert (NULL != n->primary_address.session);
-  if ( ((NULL == (papi = GST_plugins_find (n->primary_address.address->transport_name)) ||
-        (-1 == papi->send (papi->cls,
-                           n->primary_address.session,
-                           msgbuf,
-                            msgbuf_size,
-                           priority,
-                           (result = (GNUNET_NO == use_keepalive_timeout) ? timeout :
-                             GNUNET_TIME_relative_divide (GNUNET_CONSTANTS_IDLE_CONNECTION_TIMEOUT,
-                                                          papi->query_keepalive_factor (papi->cls))),
-                           cont,
-                            cont_cls)))) &&
-       (NULL != cont))
-    cont (cont_cls,
-          &n->id,
-          GNUNET_SYSERR,
-          msgbuf_size,
-          0);
-  GST_neighbours_notify_data_sent (n->primary_address.address,
-                                  n->primary_address.session,
-                                  msgbuf_size);
-  GNUNET_break (NULL != papi);
-  return result;
-}
-
-
 /**
  * Function called when the 'DISCONNECT' message has been sent by the
  * plugin.  Frees the neighbour --- if the entry still exists.
@@ -1133,12 +1063,12 @@ send_disconnect_cont (void *cls,
 static void
 send_disconnect (struct NeighbourMapEntry *n)
 {
-  struct SessionDisconnectMessage disconnect_msg;
+  struct GNUNET_ATS_SessionDisconnectMessage disconnect_msg;
 
   GNUNET_log (GNUNET_ERROR_TYPE_INFO,
               "Sending DISCONNECT message to peer `%4s'\n",
               GNUNET_i2s (&n->id));
-  disconnect_msg.header.size = htons (sizeof (struct SessionDisconnectMessage));
+  disconnect_msg.header.size = htons (sizeof (struct GNUNET_ATS_SessionDisconnectMessage));
   disconnect_msg.header.type =
       htons (GNUNET_MESSAGE_TYPE_TRANSPORT_SESSION_DISCONNECT);
   disconnect_msg.reserved = htonl (0);
@@ -1247,6 +1177,133 @@ disconnect_neighbour (struct NeighbourMapEntry *n)
 }
 
 
+/**
+ * Change the incoming quota for the given peer.  Updates
+ * our own receive rate and informs the neighbour about
+ * the new quota.
+ *
+ * @param n neighbour entry to change qutoa for
+ * @param quota new quota
+ */
+static void
+set_incoming_quota (struct NeighbourMapEntry *n,
+                    struct GNUNET_BANDWIDTH_Value32NBO quota)
+{
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+              "Setting inbound quota of %u Bps for peer `%s' to all clients\n",
+              ntohl (quota.value__), GNUNET_i2s (&n->id));
+  GNUNET_BANDWIDTH_tracker_update_quota (&n->in_tracker,
+                                         quota);
+  if (0 != ntohl (quota.value__))
+  {
+    struct GNUNET_ATS_SessionQuotaMessage sqm;
+
+    sqm.header.size = htons (sizeof (struct GNUNET_ATS_SessionQuotaMessage));
+    sqm.header.type = htons (GNUNET_MESSAGE_TYPE_TRANSPORT_SESSION_QUOTA);
+    sqm.quota = quota.value__;
+    (void) send_with_session (n,
+                              &sqm,
+                              sizeof (sqm),
+                              UINT32_MAX - 1,
+                              GNUNET_TIME_UNIT_FOREVER_REL,
+                              GNUNET_NO,
+                              NULL, NULL);
+    return;
+  }
+  GNUNET_log (GNUNET_ERROR_TYPE_INFO,
+              "Disconnecting peer `%4s' due to SET_QUOTA\n",
+              GNUNET_i2s (&n->id));
+  if (GNUNET_YES == test_connected (n))
+    GNUNET_STATISTICS_update (GST_stats,
+                              gettext_noop ("# disconnects due to quota of 0"),
+                              1, GNUNET_NO);
+  disconnect_neighbour (n);
+}
+
+
+/**
+ * Initialize the primary address of a neighbour
+ *
+ * @param n the neighbour
+ * @param address address of the other peer, NULL if other peer
+ *                       connected to us
+ * @param session session to use (or NULL, in which case an
+ *        address must be setup)
+ * @param bandwidth_in inbound quota to be used when connection is up
+ * @param bandwidth_out outbound quota to be used when connection is up
+ */
+static void
+set_primary_address (struct NeighbourMapEntry *n,
+                     const struct GNUNET_HELLO_Address *address,
+                     struct GNUNET_ATS_Session *session,
+                     struct GNUNET_BANDWIDTH_Value32NBO bandwidth_in,
+                     struct GNUNET_BANDWIDTH_Value32NBO bandwidth_out)
+{
+  if (session == n->primary_address.session)
+  {
+    GST_validation_set_address_use (n->primary_address.address,
+                                    GNUNET_YES);
+    if (n->primary_address.bandwidth_in.value__ != bandwidth_in.value__)
+    {
+      n->primary_address.bandwidth_in = bandwidth_in;
+      set_incoming_quota (n,
+                          bandwidth_in);
+    }
+    if (n->primary_address.bandwidth_out.value__ != bandwidth_out.value__)
+    {
+      n->primary_address.bandwidth_out = bandwidth_out;
+      send_outbound_quota_to_clients (n);
+    }
+    return;
+  }
+  if ( (NULL != n->primary_address.address) &&
+       (0 == GNUNET_HELLO_address_cmp (address,
+                                       n->primary_address.address)) )
+  {
+    GNUNET_break (0);
+    return;
+  }
+  if (NULL == session)
+  {
+    GNUNET_break (0);
+    GST_ats_block_address (address,
+                           session);
+    return;
+  }
+  if (NULL != n->primary_address.address)
+  {
+    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                "Replacing existing primary address with another one\n");
+    free_address (&n->primary_address);
+  }
+  n->primary_address.address = GNUNET_HELLO_address_copy (address);
+  n->primary_address.bandwidth_in = bandwidth_in;
+  n->primary_address.bandwidth_out = bandwidth_out;
+  n->primary_address.session = session;
+  n->primary_address.keep_alive_nonce = 0;
+  GNUNET_assert (GNUNET_YES ==
+                 GST_ats_is_known (n->primary_address.address,
+                                   n->primary_address.session));
+  /* subsystems about address use */
+  GST_validation_set_address_use (n->primary_address.address,
+                                  GNUNET_YES);
+  set_incoming_quota (n,
+                      bandwidth_in);
+  send_outbound_quota_to_clients (n);
+  GNUNET_log (GNUNET_ERROR_TYPE_INFO,
+              "Neighbour `%s' switched to address `%s'\n",
+              GNUNET_i2s (&n->id),
+              GST_plugins_a2s(address));
+
+  neighbours_changed_notification (&n->id,
+                                   n->primary_address.address,
+                                   n->state,
+                                   n->timeout,
+                                   n->primary_address.bandwidth_in,
+                                   n->primary_address.bandwidth_out);
+}
+
+
 /**
  * We're done with our transmission attempt, continue processing.
  *
@@ -1418,7 +1475,7 @@ try_transmission_to_peer (struct NeighbourMapEntry *n)
 static void
 send_keepalive (struct NeighbourMapEntry *n)
 {
-  struct SessionKeepAliveMessage m;
+  struct GNUNET_ATS_SessionKeepAliveMessage m;
   struct GNUNET_TIME_Relative timeout;
   uint32_t nonce;
 
@@ -1436,7 +1493,7 @@ send_keepalive (struct NeighbourMapEntry *n)
               "Sending KEEPALIVE to peer `%s' with nonce %u\n",
               GNUNET_i2s (&n->id),
               nonce);
-  m.header.size = htons (sizeof (struct SessionKeepAliveMessage));
+  m.header.size = htons (sizeof (struct GNUNET_ATS_SessionKeepAliveMessage));
   m.header.type = htons (GNUNET_MESSAGE_TYPE_TRANSPORT_SESSION_KEEPALIVE);
   m.nonce = htonl (nonce);
 
@@ -1470,16 +1527,16 @@ GST_neighbours_keepalive (const struct GNUNET_PeerIdentity *neighbour,
                           const struct GNUNET_MessageHeader *m)
 {
   struct NeighbourMapEntry *n;
-  const struct SessionKeepAliveMessage *msg_in;
-  struct SessionKeepAliveMessage msg;
+  const struct GNUNET_ATS_SessionKeepAliveMessage *msg_in;
+  struct GNUNET_ATS_SessionKeepAliveMessage msg;
 
-  if (sizeof (struct SessionKeepAliveMessage) != ntohs (m->size))
+  if (sizeof (struct GNUNET_ATS_SessionKeepAliveMessage) != ntohs (m->size))
   {
     GNUNET_break_op (0);
     return;
   }
 
-  msg_in = (const struct SessionKeepAliveMessage *) m;
+  msg_in = (const struct GNUNET_ATS_SessionKeepAliveMessage *) m;
   if (NULL == (n = lookup_neighbour (neighbour)))
   {
     GNUNET_STATISTICS_update (GST_stats,
@@ -1507,12 +1564,12 @@ GST_neighbours_keepalive (const struct GNUNET_PeerIdentity *neighbour,
                            GNUNET_NO);
 
   /* send reply to allow neighbour to measure latency */
-  msg.header.size = htons (sizeof (struct SessionKeepAliveMessage));
+  msg.header.size = htons (sizeof (struct GNUNET_ATS_SessionKeepAliveMessage));
   msg.header.type = htons (GNUNET_MESSAGE_TYPE_TRANSPORT_SESSION_KEEPALIVE_RESPONSE);
   msg.nonce = msg_in->nonce;
   (void) send_with_session (n,
                             &msg,
-                            sizeof (struct SessionKeepAliveMessage),
+                            sizeof (struct GNUNET_ATS_SessionKeepAliveMessage),
                             UINT32_MAX /* priority */,
                             GNUNET_TIME_UNIT_FOREVER_REL,
                             GNUNET_YES,
@@ -1533,17 +1590,17 @@ GST_neighbours_keepalive_response (const struct GNUNET_PeerIdentity *neighbour,
                                    const struct GNUNET_MessageHeader *m)
 {
   struct NeighbourMapEntry *n;
-  const struct SessionKeepAliveMessage *msg;
+  const struct GNUNET_ATS_SessionKeepAliveMessage *msg;
   struct GNUNET_TRANSPORT_PluginFunctions *papi;
   struct GNUNET_TIME_Relative latency;
 
-  if (sizeof (struct SessionKeepAliveMessage) != ntohs (m->size))
+  if (sizeof (struct GNUNET_ATS_SessionKeepAliveMessage) != ntohs (m->size))
   {
     GNUNET_break_op (0);
     return;
   }
 
-  msg = (const struct SessionKeepAliveMessage *) m;
+  msg = (const struct GNUNET_ATS_SessionKeepAliveMessage *) m;
   if (NULL == (n = lookup_neighbour (neighbour)))
   {
     GNUNET_STATISTICS_update (GST_stats,
@@ -2023,7 +2080,7 @@ send_syn_ack_message (struct NeighbourAddress *na,
                       struct GNUNET_TIME_Absolute timestamp)
 {
   const struct GNUNET_HELLO_Address *address = na->address;
-  struct Session *session = na->session;
+  struct GNUNET_ATS_Session *session = na->session;
   struct GNUNET_TRANSPORT_PluginFunctions *papi;
   struct TransportSynMessage connect_msg;
   struct NeighbourMapEntry *n;
@@ -2152,10 +2209,12 @@ setup_neighbour (const struct GNUNET_PeerIdentity *peer)
                          GNUNET_TIME_UNIT_FOREVER_ABS);
   GNUNET_assert (GNUNET_OK ==
                  GNUNET_CONTAINER_multipeermap_put (neighbours,
-                                                    &n->id, n,
+                                                    &n->id,
+                                                    n,
                                                     GNUNET_CONTAINER_MULTIHASHMAPOPTION_UNIQUE_ONLY));
   n->suggest_handle = GNUNET_ATS_connectivity_suggest (GST_ats_connect,
-                                                       peer);
+                                                       peer,
+                                                       0);
 
   return n;
 }
@@ -2209,7 +2268,7 @@ static void
 try_connect_bl_check_cont (void *cls,
                            const struct GNUNET_PeerIdentity *peer,
                           const struct GNUNET_HELLO_Address *address,
-                          struct Session *session,
+                          struct GNUNET_ATS_Session *session,
                            int result)
 {
   struct BlacklistCheckSwitchContext *blc_ctx = cls;
@@ -2476,12 +2535,11 @@ GST_neighbours_handle_session_syn (const struct GNUNET_MessageHeader *message,
  */
 static int
 try_run_fast_ats_update (const struct GNUNET_HELLO_Address *address,
-                         struct Session *session,
+                         struct GNUNET_ATS_Session *session,
                          struct GNUNET_BANDWIDTH_Value32NBO bandwidth_in,
                          struct GNUNET_BANDWIDTH_Value32NBO bandwidth_out)
 {
   struct NeighbourMapEntry *n;
-  struct GNUNET_BANDWIDTH_Value32NBO bandwidth_min;
 
   n = lookup_neighbour (&address->peer);
   if ( (NULL == n) ||
@@ -2503,16 +2561,13 @@ try_run_fast_ats_update (const struct GNUNET_HELLO_Address *address,
   if (n->primary_address.bandwidth_in.value__ != bandwidth_in.value__)
   {
     n->primary_address.bandwidth_in = bandwidth_in;
-    GST_neighbours_set_incoming_quota (&address->peer,
-                                       bandwidth_in);
+    set_incoming_quota (n,
+                        bandwidth_in);
   }
   if (n->primary_address.bandwidth_out.value__ != bandwidth_out.value__)
   {
     n->primary_address.bandwidth_out = bandwidth_out;
-    bandwidth_min = GNUNET_BANDWIDTH_value_min (bandwidth_out,
-                                                n->neighbour_receive_quota);
-    send_outbound_quota_to_clients (&address->peer,
-                                    bandwidth_min);
+    send_outbound_quota_to_clients (n);
   }
   return GNUNET_OK;
 }
@@ -2535,7 +2590,7 @@ static void
 switch_address_bl_check_cont (void *cls,
                               const struct GNUNET_PeerIdentity *peer,
                              const struct GNUNET_HELLO_Address *address,
-                             struct Session *session,
+                             struct GNUNET_ATS_Session *session,
                               int result)
 {
   struct BlacklistCheckSwitchContext *blc_ctx = cls;
@@ -2828,7 +2883,7 @@ switch_address_bl_check_cont (void *cls,
  */
 void
 GST_neighbours_switch_to_address (const struct GNUNET_HELLO_Address *address,
-                                 struct Session *session,
+                                 struct GNUNET_ATS_Session *session,
                                  struct GNUNET_BANDWIDTH_Value32NBO bandwidth_in,
                                  struct GNUNET_BANDWIDTH_Value32NBO bandwidth_out)
 {
@@ -2988,7 +3043,7 @@ GST_neighbours_notify_data_recv (const struct GNUNET_HELLO_Address *address,
  */
 void
 GST_neighbours_notify_data_sent (const struct GNUNET_HELLO_Address *address,
-                                 struct Session *session,
+                                 struct GNUNET_ATS_Session *session,
                                  size_t size)
 {
   struct NeighbourMapEntry *n;
@@ -3186,7 +3241,7 @@ send_session_ack_message (struct NeighbourMapEntry *n)
  * We received a 'SESSION_SYN_ACK' message from the other peer.
  * Consider switching to it.
  *
- * @param message possibly a `struct SessionConnectMessage` (check format)
+ * @param message possibly a `struct GNUNET_ATS_SessionConnectMessage` (check format)
  * @param peer identity of the peer to switch the address for
  * @param address address of the other peer, NULL if other peer
  *                       connected to us
@@ -3196,7 +3251,7 @@ send_session_ack_message (struct NeighbourMapEntry *n)
 int
 GST_neighbours_handle_session_syn_ack (const struct GNUNET_MessageHeader *message,
                                       const struct GNUNET_HELLO_Address *address,
-                                      struct Session *session)
+                                      struct GNUNET_ATS_Session *session)
 {
   const struct TransportSynMessage *scm;
   struct GNUNET_TIME_Absolute ts;
@@ -3337,7 +3392,7 @@ GST_neighbours_handle_session_syn_ack (const struct GNUNET_MessageHeader *messag
  */
 int
 GST_neighbours_session_terminated (const struct GNUNET_PeerIdentity *peer,
-                                   struct Session *session)
+                                   struct GNUNET_ATS_Session *session)
 {
   struct NeighbourMapEntry *n;
   struct BlackListCheckContext *bcc;
@@ -3485,7 +3540,7 @@ GST_neighbours_session_terminated (const struct GNUNET_PeerIdentity *peer,
  * If we sent a 'SYN_ACK' last, this means we are now
  * connected.  Otherwise, do nothing.
  *
- * @param message possibly a 'struct SessionConnectMessage' (check format)
+ * @param message possibly a 'struct GNUNET_ATS_SessionConnectMessage' (check format)
  * @param address address of the other peer
  * @param session session to use (or NULL)
  * @return #GNUNET_OK if the message was fine, #GNUNET_SYSERR on serious error
@@ -3493,7 +3548,7 @@ GST_neighbours_session_terminated (const struct GNUNET_PeerIdentity *peer,
 int
 GST_neighbours_handle_session_ack (const struct GNUNET_MessageHeader *message,
                                   const struct GNUNET_HELLO_Address *address,
-                                  struct Session *session)
+                                  struct GNUNET_ATS_Session *session)
 {
   struct NeighbourMapEntry *n;
 
@@ -3587,59 +3642,6 @@ GST_neighbours_test_connected (const struct GNUNET_PeerIdentity *target)
 }
 
 
-/**
- * Change the incoming quota for the given peer.  Updates
- * our own receive rate and informs the neighbour about
- * the new quota.
- *
- * @param neighbour identity of peer to change qutoa for
- * @param quota new quota
- */
-void
-GST_neighbours_set_incoming_quota (const struct GNUNET_PeerIdentity *neighbour,
-                                   struct GNUNET_BANDWIDTH_Value32NBO quota)
-{
-  struct NeighbourMapEntry *n;
-
-  if (NULL == (n = lookup_neighbour (neighbour)))
-  {
-    GNUNET_STATISTICS_update (GST_stats,
-                              gettext_noop
-                              ("# SET QUOTA messages ignored (no such peer)"),
-                              1, GNUNET_NO);
-    return;
-  }
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Setting inbound quota of %u Bps for peer `%s' to all clients\n",
-              ntohl (quota.value__), GNUNET_i2s (&n->id));
-  GNUNET_BANDWIDTH_tracker_update_quota (&n->in_tracker, quota);
-  if (0 != ntohl (quota.value__))
-  {
-    struct SessionQuotaMessage sqm;
-
-    sqm.header.size = htons (sizeof (struct SessionQuotaMessage));
-    sqm.header.type = htons (GNUNET_MESSAGE_TYPE_TRANSPORT_SESSION_QUOTA);
-    sqm.quota = quota.value__;
-    (void) send_with_session (n,
-                              &sqm,
-                              sizeof (sqm),
-                              UINT32_MAX - 1,
-                              GNUNET_TIME_UNIT_FOREVER_REL,
-                              GNUNET_NO,
-                              NULL, NULL);
-    return;
-  }
-  GNUNET_log (GNUNET_ERROR_TYPE_INFO,
-              "Disconnecting peer `%4s' due to SET_QUOTA\n",
-              GNUNET_i2s (&n->id));
-  if (GNUNET_YES == test_connected (n))
-    GNUNET_STATISTICS_update (GST_stats,
-                              gettext_noop ("# disconnects due to quota of 0"),
-                              1, GNUNET_NO);
-  disconnect_neighbour (n);
-}
-
-
 /**
  * Task to asynchronously run #free_neighbour().
  *
@@ -3661,7 +3663,7 @@ delayed_disconnect (void *cls,
 
 
 /**
- * We received a quoat message from the given peer,
+ * We received a quota message from the given peer,
  * validate and process.
  *
  * @param peer sender of the message
@@ -3672,13 +3674,12 @@ GST_neighbours_handle_quota_message (const struct GNUNET_PeerIdentity *peer,
                                      const struct GNUNET_MessageHeader *msg)
 {
   struct NeighbourMapEntry *n;
-  const struct SessionQuotaMessage *sqm;
-  struct GNUNET_BANDWIDTH_Value32NBO bandwidth_min;
+  const struct GNUNET_ATS_SessionQuotaMessage *sqm;
 
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
               "Received QUOTA message from peer `%s'\n",
               GNUNET_i2s (peer));
-  if (ntohs (msg->size) != sizeof (struct SessionQuotaMessage))
+  if (ntohs (msg->size) != sizeof (struct GNUNET_ATS_SessionQuotaMessage))
   {
     GNUNET_break_op (0);
     GNUNET_STATISTICS_update (GST_stats,
@@ -3691,7 +3692,7 @@ GST_neighbours_handle_quota_message (const struct GNUNET_PeerIdentity *peer,
                             gettext_noop
                             ("# QUOTA messages received"),
                             1, GNUNET_NO);
-  sqm = (const struct SessionQuotaMessage *) msg;
+  sqm = (const struct GNUNET_ATS_SessionQuotaMessage *) msg;
   if (NULL == (n = lookup_neighbour (peer)))
   {
     /* gone already */
@@ -3700,11 +3701,7 @@ GST_neighbours_handle_quota_message (const struct GNUNET_PeerIdentity *peer,
   n->neighbour_receive_quota
     = GNUNET_BANDWIDTH_value_max (GNUNET_CONSTANTS_DEFAULT_BW_IN_OUT,
                                   GNUNET_BANDWIDTH_value_init (ntohl (sqm->quota)));
-
-  bandwidth_min = GNUNET_BANDWIDTH_value_min (n->primary_address.bandwidth_out,
-                                              n->neighbour_receive_quota);
-  send_outbound_quota_to_clients (peer,
-                                  bandwidth_min);
+  send_outbound_quota_to_clients (n);
 }
 
 
@@ -3720,12 +3717,12 @@ GST_neighbours_handle_disconnect_message (const struct GNUNET_PeerIdentity *peer
                                           const struct GNUNET_MessageHeader *msg)
 {
   struct NeighbourMapEntry *n;
-  const struct SessionDisconnectMessage *sdm;
+  const struct GNUNET_ATS_SessionDisconnectMessage *sdm;
 
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
               "Received DISCONNECT message from peer `%s'\n",
               GNUNET_i2s (peer));
-  if (ntohs (msg->size) != sizeof (struct SessionDisconnectMessage))
+  if (ntohs (msg->size) != sizeof (struct GNUNET_ATS_SessionDisconnectMessage))
   {
     GNUNET_break_op (0);
     GNUNET_STATISTICS_update (GST_stats,
@@ -3739,7 +3736,7 @@ GST_neighbours_handle_disconnect_message (const struct GNUNET_PeerIdentity *peer
                             gettext_noop
                             ("# DISCONNECT messages received"),
                             1, GNUNET_NO);
-  sdm = (const struct SessionDisconnectMessage *) msg;
+  sdm = (const struct GNUNET_ATS_SessionDisconnectMessage *) msg;
   if (NULL == (n = lookup_neighbour (peer)))
   {
     /* gone already */
@@ -3898,7 +3895,7 @@ GST_neighbours_force_disconnect (const struct GNUNET_PeerIdentity *target)
  * @param peer
  * @return address currently used
  */
-struct GNUNET_HELLO_Address *
+const struct GNUNET_HELLO_Address *
 GST_neighbour_get_current_address (const struct GNUNET_PeerIdentity *peer)
 {
   struct NeighbourMapEntry *n;