fix more leaks
[oweals/gnunet.git] / src / transport / gnunet-service-transport.c
index 54342bfde4abde5e5698f02d8b0ae3f3da8e3531..d6be384bdbe5d8b7150dcbd46ec687d9278edd4f 100644 (file)
@@ -62,21 +62,11 @@ struct GNUNET_PeerIdentity GST_my_identity;
  */
 struct GNUNET_PEERINFO_Handle *GST_peerinfo;
 
-/**
- * Hostkey generation context
- */
-struct GNUNET_CRYPTO_EccKeyGenerationContext *GST_keygen;
-
 /**
  * Handle to our service's server.
  */
 static struct GNUNET_SERVER_Handle *GST_server;
 
-/**
- * Our public key.
- */
-struct GNUNET_CRYPTO_EccPublicKeyBinaryEncoded GST_my_public_key;
-
 /**
  * Our private key.
  */
@@ -158,7 +148,6 @@ process_payload (const struct GNUNET_PeerIdentity *peer,
       sizeof (struct InboundMessage) + msg_size;
   char buf[size] GNUNET_ALIGN;
 
-  ret = GNUNET_TIME_UNIT_ZERO;
   do_forward = GNUNET_SYSERR;
   ret = GST_neighbours_calculate_receive_delay (peer, msg_size, &do_forward);
 
@@ -176,6 +165,8 @@ process_payload (const struct GNUNET_PeerIdentity *peer,
     return ret;
   }
 
+  GST_ats_add_address ((struct GNUNET_HELLO_Address *) address, session);
+
   if (do_forward != GNUNET_YES)
     return ret;
   im = (struct InboundMessage *) buf;
@@ -184,7 +175,6 @@ process_payload (const struct GNUNET_PeerIdentity *peer,
   im->peer = *peer;
   memcpy (&im[1], message, ntohs (message->size));
 
-  GNUNET_ATS_address_add (GST_ats, address, session, NULL, 0);
   GST_clients_broadcast (&im->header, GNUNET_YES);
 
   return ret;
@@ -241,6 +231,9 @@ GST_receive_callback (void *cls, const struct GNUNET_PeerIdentity *peer,
 
   switch (type)
   {
+  case GNUNET_MESSAGE_TYPE_HELLO_LEGACY:
+    /* Legacy HELLO message, discard  */
+    return ret;
   case GNUNET_MESSAGE_TYPE_HELLO:
     GST_validation_handle_hello (message);
     return ret;
@@ -248,14 +241,14 @@ GST_receive_callback (void *cls, const struct GNUNET_PeerIdentity *peer,
     GNUNET_log (GNUNET_ERROR_TYPE_DEBUG | GNUNET_ERROR_TYPE_BULK,
                 "Processing `%s' from `%s'\n", "PING",
                 (sender_address !=
-                 NULL) ? GST_plugins_a2s (&address) : "<inbound>");
+                 NULL) ? GST_plugins_a2s (&address) : TRANSPORT_SESSION_INBOUND_STRING);
     GST_validation_handle_ping (peer, message, &address, session);
     break;
   case GNUNET_MESSAGE_TYPE_TRANSPORT_PONG:
     GNUNET_log (GNUNET_ERROR_TYPE_DEBUG | GNUNET_ERROR_TYPE_BULK,
                 "Processing `%s' from `%s'\n", "PONG",
                 (sender_address !=
-                 NULL) ? GST_plugins_a2s (&address) : "<inbound>");
+                 NULL) ? GST_plugins_a2s (&address) : TRANSPORT_SESSION_INBOUND_STRING);
     GST_validation_handle_pong (peer, message);
     break;
   case GNUNET_MESSAGE_TYPE_TRANSPORT_SESSION_CONNECT:
@@ -287,8 +280,9 @@ GST_receive_callback (void *cls, const struct GNUNET_PeerIdentity *peer,
   }
 end:
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Allowing receive from peer %s to continue in %llu ms\n",
-              GNUNET_i2s (peer), (unsigned long long) ret.rel_value);
+              "Allowing receive from peer %s to continue in %s\n",
+              GNUNET_i2s (peer),
+             GNUNET_STRINGS_relative_time_to_string (ret, GNUNET_YES));
   return ret;
 }
 
@@ -394,16 +388,97 @@ plugin_env_address_to_type (void *cls,
   return GNUNET_ATS_address_get_type(GST_ats, addr, addrlen);
 }
 
+
+/**
+ * Notify ATS about the new address including the network this address is
+ * located in.
+ *
+ * @param address the address
+ * @param session the session
+ */
+void
+GST_ats_add_address (const struct GNUNET_HELLO_Address *address,
+                                                                                struct Session *session)
+{
+  struct GNUNET_TRANSPORT_PluginFunctions *papi;
+       struct GNUNET_ATS_Information ats;
+       uint32_t net;
+
+  /* valid new address, let ATS know! */
+  if (NULL == address->transport_name)
+  {
+       GNUNET_break (0);
+       return;
+  }
+  if (NULL == (papi = GST_plugins_find (address->transport_name)))
+  {
+    /* we don't have the plugin for this address */
+       GNUNET_break (0);
+       return;
+  }
+
+  if (GNUNET_YES == GNUNET_ATS_session_known (GST_ats, address, session))
+       return;
+
+       net = papi->get_network (NULL, (void *) session);
+  if (GNUNET_ATS_NET_UNSPECIFIED == net)
+  {
+    GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+                                               _("Could not obtain a valid network for `%s' %s\n"),
+                GNUNET_i2s (&address->peer), GST_plugins_a2s (address));
+       GNUNET_break (0);
+  }
+       ats.type = htonl (GNUNET_ATS_NETWORK_TYPE);
+       ats.value = htonl(net);
+       GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                       "Notifying ATS about peer `%s''s new address `%s' session %p in network %s\n",
+                       GNUNET_i2s (&address->peer),
+                       (0 == address->address_length) ? "<inbound>" : GST_plugins_a2s (address),
+                       session,
+                       GNUNET_ATS_print_network_type(net));
+       GNUNET_ATS_address_add (GST_ats,
+                       address, session, &ats, 1);
+}
+
+
+/**
+ * Notify ATS about property changes to an address
+ *
+ * @param peer the peer
+ * @param address the address
+ * @param session the session
+ * @param ats performance information
+ * @param ats_count number of elements in ats
+ */
 void
-GST_update_ats_metrics (struct GNUNET_PeerIdentity *peer,
-                                                                                         struct GNUNET_HELLO_Address *address,
-                                                                                         struct Session *session,
-                                                                                         struct GNUNET_ATS_Information *ats,
-                                                                                         uint32_t ats_count)
+GST_ats_update_metrics (const struct GNUNET_PeerIdentity *peer,
+                       const struct GNUNET_HELLO_Address *address,
+                       struct Session *session,
+                       const struct GNUNET_ATS_Information *ats,
+                       uint32_t ats_count)
 {
-  GNUNET_ATS_address_update (GST_ats, address, session, ats, ats_count);
+       struct GNUNET_ATS_Information *ats_new;
+
+  if (GNUNET_NO == GNUNET_ATS_session_known (GST_ats, address, session))
+       return;
+
+       /* Call to manipulation to manipulate ATS information */
+       ats_new = GST_manipulation_manipulate_metrics (peer, address, session, ats, ats_count);
+       if (NULL == ats_new)
+       {
+                       GNUNET_break (0);
+                       return;
+       }
+  if (GNUNET_NO == GNUNET_ATS_address_update (GST_ats, address, session, ats_new, ats_count))
+  {
+       GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+                       _("Address or session unknown: failed to update properties for peer `%s' plugin `%s' address `%s' session %p\n"),
+                       GNUNET_i2s (peer), address->transport_name, GST_plugins_a2s (address), session);
+  }
+  GNUNET_free (ats_new);
 }
 
+
 /**
  * Function that will be called to figure if an address is an loopback,
  * LAN, WAN etc. address
@@ -418,12 +493,12 @@ GST_update_ats_metrics (struct GNUNET_PeerIdentity *peer,
  */
 static void
 plugin_env_update_metrics (void *cls,
-                                                                                                        struct GNUNET_PeerIdentity *peer,
-                                                                                                        const void *address,
-                                                                                                        uint16_t address_len,
-                                                                                                        struct Session *session,
-                                                                                                        struct GNUNET_ATS_Information *ats,
-                                                                                                        uint32_t ats_count)
+                          const struct GNUNET_PeerIdentity *peer,
+                          const void *address,
+                          uint16_t address_len,
+                          struct Session *session,
+                          const struct GNUNET_ATS_Information *ats,
+                          uint32_t ats_count)
 {
   struct GNUNET_HELLO_Address haddress;
   const char *plugin_name = cls;
@@ -432,14 +507,63 @@ plugin_env_update_metrics (void *cls,
                return;
        GNUNET_assert (NULL != GST_ats);
 
+
        haddress.peer = *peer;
        haddress.address = address;
   haddress.address_length = address_len;
   haddress.transport_name = plugin_name;
 
-  GST_update_ats_metrics (peer, &haddress, session, ats, ats_count);
+       GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Updating metrics for peer `%s' address %s session %p\n",
+                       GNUNET_i2s (peer), GST_plugins_a2s(&haddress), session);
+  GST_ats_update_metrics (peer, &haddress, session, ats, ats_count);
 }
 
+/**
+ * Plugin tells transport service about a new (inbound) session
+ *
+ * @param cls unused
+ * @param peer the peer
+ * @param plugin plugin name
+ * @param address address
+ * @param address_len address length
+ * @param session the new session
+ * @param ats ats information
+ * @param ats_count number of ats information
+ */
+
+static void
+plugin_env_session_start (void *cls, const struct GNUNET_PeerIdentity *peer,
+    const char *plugin, const void *address, uint16_t address_len,
+    struct Session *session, const struct GNUNET_ATS_Information *ats,
+    uint32_t ats_count)
+{
+  struct GNUNET_HELLO_Address *addr;
+  if (NULL == peer)
+  {
+    GNUNET_break(0);
+    return;
+  }
+  if (NULL == plugin)
+  {
+    GNUNET_break(0);
+    return;
+  }
+  if (NULL == session)
+  {
+    GNUNET_break(0);
+    return;
+  }
+
+  addr = GNUNET_HELLO_address_allocate (peer, plugin, address, address_len);
+  GNUNET_log(GNUNET_ERROR_TYPE_DEBUG,
+      "Notification from plugin `%s' about new session %p from peer `%s' address `%s'\n",
+      plugin, session, GNUNET_i2s (peer), GST_plugins_a2s (addr));
+  GST_ats_add_address (addr, session);
+
+  if (0 < ats_count)
+    GST_ats_update_metrics (peer, addr, session, ats, ats_count);
+  GNUNET_free(addr);
+}
 
 /**
  * Function called by ATS to notify the callee that the
@@ -451,8 +575,10 @@ plugin_env_update_metrics (void *cls,
  * @param cls closure
  * @param address address to use (for peer given in address)
  * @param session session to use (if available)
- * @param bandwidth_out assigned outbound bandwidth for the connection, 0 to disconnect from peer
- * @param bandwidth_in assigned inbound bandwidth for the connection, 0 to disconnect from peer
+ * @param bandwidth_out assigned outbound bandwidth for the connection in NBO,
+ *     0 to disconnect from peer
+ * @param bandwidth_in assigned inbound bandwidth for the connection in NBO,
+ *     0 to disconnect from peer
  * @param ats ATS information
  * @param ats_count number of ATS elements
  */
@@ -471,7 +597,7 @@ ats_request_address_change (void *cls,
   /* ATS tells me to disconnect from peer */
   if ((bw_in == 0) && (bw_out == 0))
   {
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+    GNUNET_log (GNUNET_ERROR_TYPE_INFO,
                 "ATS tells me to disconnect from peer `%s'\n",
                 GNUNET_i2s (&address->peer));
     GST_neighbours_force_disconnect (&address->peer);
@@ -534,6 +660,7 @@ neighbours_disconnect_notification (void *cls,
               "Peer `%s' disconnected and we are connected to %u peers\n",
               GNUNET_i2s (peer), connections);
 
+  GST_manipulation_peer_disconnect (peer);
   disconnect_msg.header.size = htons (sizeof (struct DisconnectInfoMessage));
   disconnect_msg.header.type = htons (GNUNET_MESSAGE_TYPE_TRANSPORT_DISCONNECT);
   disconnect_msg.reserved = htonl (0);
@@ -569,11 +696,6 @@ neighbours_address_notification (void *cls,
 static void
 shutdown_task (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
 {
-  if (NULL != GST_keygen)
-  {
-    GNUNET_CRYPTO_ecc_key_create_stop (GST_keygen);
-    GST_keygen = NULL;
-  }
   GST_neighbours_stop ();
   GST_validation_stop ();
   GST_plugins_unload ();
@@ -597,7 +719,7 @@ shutdown_task (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
   }
   if (NULL != GST_my_private_key)
   {
-    GNUNET_CRYPTO_ecc_key_free (GST_my_private_key);
+    GNUNET_free (GST_my_private_key);
     GST_my_private_key = NULL;
   }
   GST_server = NULL;
@@ -605,39 +727,56 @@ shutdown_task (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
 
 
 /**
- * Callback for hostkey read/generation
+ * Initiate transport service.
  *
- * @param cls NULL
- * @param pk the private key
- * @param emsg error message
+ * @param cls closure
+ * @param server the initialized server
+ * @param c configuration to use
  */
 static void
-key_generation_cb (void *cls,
-                   struct GNUNET_CRYPTO_EccPrivateKey *pk,
-                   const char *emsg)
+run (void *cls, struct GNUNET_SERVER_Handle *server,
+     const struct GNUNET_CONFIGURATION_Handle *c)
 {
+  char *keyfile;
+  struct GNUNET_CRYPTO_EccPrivateKey *pk;
   long long unsigned int max_fd_cfg;
   int max_fd_rlimit;
   int max_fd;
+  int friend_only;
 
-  GST_keygen = NULL;
-  if (NULL == pk)
+  /* setup globals */
+  GST_cfg = c;
+  if (GNUNET_OK !=
+      GNUNET_CONFIGURATION_get_value_filename (c, "PEER", "PRIVATE_KEY",
+                                               &keyfile))
   {
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
-                _("Transport service could not access hostkey: %s. Exiting.\n"),
-                emsg);
+                _
+                ("Transport service is lacking key configuration settings.  Exiting.\n"));
     GNUNET_SCHEDULER_shutdown ();
     return;
   }
+  if (GNUNET_OK !=
+      GNUNET_CONFIGURATION_get_value_time (c, "transport", "HELLO_EXPIRATION",
+                                           &hello_expiration))
+  {
+    hello_expiration = GNUNET_CONSTANTS_HELLO_ADDRESS_EXPIRATION;
+  }
+  GST_server = server;
+  pk = GNUNET_CRYPTO_ecc_key_create_from_file (keyfile);
+  GNUNET_free (keyfile);
+  GNUNET_assert (NULL != pk);
   GST_my_private_key = pk;
 
   GST_stats = GNUNET_STATISTICS_create ("transport", GST_cfg);
   GST_peerinfo = GNUNET_PEERINFO_connect (GST_cfg);
-  GNUNET_CRYPTO_ecc_key_get_public (GST_my_private_key, &GST_my_public_key);
-  GNUNET_CRYPTO_hash (&GST_my_public_key, sizeof (GST_my_public_key),
-                      &GST_my_identity.hashPubKey);
+  GNUNET_CRYPTO_ecc_key_get_public_for_signature (GST_my_private_key,
+                                                 &GST_my_identity.public_key);
   GNUNET_assert (NULL != GST_my_private_key);
 
+  GNUNET_log (GNUNET_ERROR_TYPE_INFO,
+              "My identity is `%4s'\n", GNUNET_i2s (&GST_my_identity));
+
   GNUNET_SCHEDULER_add_delayed (GNUNET_TIME_UNIT_FOREVER_REL, &shutdown_task,
                                 NULL);
   if (NULL == GST_peerinfo)
@@ -650,15 +789,14 @@ key_generation_cb (void *cls,
 
   max_fd_rlimit = 0;
   max_fd_cfg = 0;
-  max_fd = 0;
 #if HAVE_GETRLIMIT
   struct rlimit r_file;
   if (0 == getrlimit (RLIMIT_NOFILE, &r_file))
   {
-               max_fd_rlimit = r_file.rlim_cur;
-               GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                                                               "Maximum number of open files was: %u/%u\n", r_file.rlim_cur,
-                                                               r_file.rlim_max);
+    max_fd_rlimit = r_file.rlim_cur;
+    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+               "Maximum number of open files was: %u/%u\n", r_file.rlim_cur,
+               r_file.rlim_max);
   }
   max_fd_rlimit = (9 * max_fd_rlimit) / 10; /* Keep 10% for rest of transport */
 #endif
@@ -675,15 +813,19 @@ key_generation_cb (void *cls,
               "Limiting number of sockets to %u: validation %u, neighbors: %u\n",
               max_fd, (max_fd / 3) , (max_fd / 3) * 2);
 
+  friend_only = GNUNET_CONFIGURATION_get_value_yesno(GST_cfg, "topology","FRIENDS-ONLY");
+  if (GNUNET_SYSERR == friend_only)
+       friend_only = GNUNET_NO; /* According to topology defaults */
   /* start subsystems */
-  GST_hello_start (&process_hello_update, NULL);
+  GST_hello_start (friend_only, &process_hello_update, NULL);
   GNUNET_assert (NULL != GST_hello_get());
-  GST_blacklist_start (GST_server);
+  GST_blacklist_start (GST_server, GST_cfg, &GST_my_identity);
   GST_ats =
       GNUNET_ATS_scheduling_init (GST_cfg, &ats_request_address_change, NULL);
-  GST_manipulation_init (GST_cfg, &plugin_env_update_metrics);
+  GST_manipulation_init (GST_cfg);
   GST_plugins_load (&GST_manipulation_recv,
                     &plugin_env_address_change_notification,
+                    &plugin_env_session_start,
                     &plugin_env_session_end,
                     &plugin_env_address_to_type,
                     &plugin_env_update_metrics);
@@ -694,52 +836,6 @@ key_generation_cb (void *cls,
                         (max_fd / 3) * 2);
   GST_clients_start (GST_server);
   GST_validation_start ((max_fd / 3));
-  if (NULL != GST_server)
-    GNUNET_SERVER_resume (GST_server);
-}
-
-
-/**
- * Initiate transport service.
- *
- * @param cls closure
- * @param server the initialized server
- * @param c configuration to use
- */
-static void
-run (void *cls, struct GNUNET_SERVER_Handle *server,
-     const struct GNUNET_CONFIGURATION_Handle *c)
-{
-  char *keyfile;
-
-  /* setup globals */
-  GST_cfg = c;
-  if (GNUNET_OK !=
-      GNUNET_CONFIGURATION_get_value_filename (c, "PEER", "PRIVATE_KEY",
-                                               &keyfile))
-  {
-    GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
-                _
-                ("Transport service is lacking key configuration settings.  Exiting.\n"));
-    GNUNET_SCHEDULER_shutdown ();
-    return;
-  }
-  if (GNUNET_OK !=
-      GNUNET_CONFIGURATION_get_value_time (c, "transport", "HELLO_EXPIRATION",
-                                           &hello_expiration))
-  {
-    hello_expiration = GNUNET_CONSTANTS_HELLO_ADDRESS_EXPIRATION;
-  }
-  GST_server = server;
-  GNUNET_SERVER_suspend (server);
-  GST_keygen = GNUNET_CRYPTO_ecc_key_create_start (keyfile, &key_generation_cb, NULL);
-  GNUNET_free (keyfile);
-  if (NULL == GST_keygen)
-  {
-    GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
-                _("Transport service is unable to access hostkey. Exiting.\n"));
-    GNUNET_SCHEDULER_shutdown ();
-  }
 }