- fix error messages
[oweals/gnunet.git] / src / transport / gnunet-service-transport.c
index f9585e5124795f2ff19518b6ffdd2aa6cac68218..a5ce3fa4a86ff76fc333188fe1986dae314c49cb 100644 (file)
 #include "gnunet-service-transport_manipulation.h"
 #include "transport.h"
 
+
+/**
+ * Information we need for an asynchronous session kill.
+ */
+struct SessionKiller
+{
+  /**
+   * Kept in a DLL.
+   */
+  struct SessionKiller *next;
+
+  /**
+   * Kept in a DLL.
+   */
+  struct SessionKiller *prev;
+
+  /**
+   * Session to kill.
+   */
+  struct Session *session;
+
+  /**
+   * Plugin for the session.
+   */
+  struct GNUNET_TRANSPORT_PluginFunctions *plugin;
+
+  /**
+   * The kill task.
+   */
+  GNUNET_SCHEDULER_TaskIdentifier task;
+};
+
+
 /* globals */
 
 /**
@@ -67,30 +100,35 @@ struct GNUNET_PEERINFO_Handle *GST_peerinfo;
  */
 static struct GNUNET_SERVER_Handle *GST_server;
 
-/**
- * Our public key.
- */
-struct GNUNET_CRYPTO_EccPublicKey GST_my_public_key;
-
 /**
  * Our private key.
  */
-struct GNUNET_CRYPTO_EccPrivateKey *GST_my_private_key;
+struct GNUNET_CRYPTO_EddsaPrivateKey *GST_my_private_key;
 
 /**
  * ATS handle.
  */
 struct GNUNET_ATS_SchedulingHandle *GST_ats;
 
+/**
+ * Hello address expiration
+ */
+struct GNUNET_TIME_Relative hello_expiration;
+
 /**
  * DEBUGGING connection counter
  */
 static int connections;
 
 /**
- * Hello address expiration
+ * Head of DLL of asynchronous tasks to kill sessions.
  */
-struct GNUNET_TIME_Relative hello_expiration;
+static struct SessionKiller *sk_head;
+
+/**
+ * Tail of DLL of asynchronous tasks to kill sessions.
+ */
+static struct SessionKiller *sk_tail;
 
 
 /**
@@ -99,18 +137,27 @@ struct GNUNET_TIME_Relative hello_expiration;
  * @param cls the 'HELLO' message
  * @param target a connected neighbour
  * @param address the address
+ * @param state current state this peer is in
+ * @param state_timeout timeout for the current state of the peer
  * @param bandwidth_in inbound quota in NBO
  * @param bandwidth_out outbound quota in NBO
  */
 static void
 transmit_our_hello (void *cls, const struct GNUNET_PeerIdentity *target,
                     const struct GNUNET_HELLO_Address *address,
+                    enum GNUNET_TRANSPORT_PeerState state,
+                    struct GNUNET_TIME_Absolute state_timeout,
                     struct GNUNET_BANDWIDTH_Value32NBO bandwidth_in,
                     struct GNUNET_BANDWIDTH_Value32NBO bandwidth_out)
 {
   const struct GNUNET_MessageHeader *hello = cls;
 
-  GST_neighbours_send (target, (const char *) hello, ntohs (hello->size),
+  if ( GNUNET_NO == GST_neighbours_test_connected(target) )
+    return;
+
+  GST_neighbours_send (target,
+                       hello,
+                       ntohs (hello->size),
                        hello_expiration, NULL, NULL);
 }
 
@@ -122,14 +169,14 @@ transmit_our_hello (void *cls, const struct GNUNET_PeerIdentity *target,
  * @param hello new HELLO
  */
 static void
-process_hello_update (void *cls, const struct GNUNET_MessageHeader *hello)
+process_hello_update (void *cls,
+                      const struct GNUNET_MessageHeader *hello)
 {
   GST_clients_broadcast (hello, GNUNET_NO);
   GST_neighbours_iterate (&transmit_our_hello, (void *) hello);
 }
 
 
-
 /**
  * We received some payload.  Prepare to pass it on to our clients.
  *
@@ -153,49 +200,95 @@ process_payload (const struct GNUNET_PeerIdentity *peer,
       sizeof (struct InboundMessage) + msg_size;
   char buf[size] GNUNET_ALIGN;
 
-  ret = GNUNET_TIME_UNIT_ZERO;
   do_forward = GNUNET_SYSERR;
   ret = GST_neighbours_calculate_receive_delay (peer, msg_size, &do_forward);
-
-  if (!GST_neighbours_test_connected (peer))
+  if (! GST_neighbours_test_connected (peer))
   {
-
     GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                "Discarded %u bytes type %u payload from peer `%s'\n", msg_size,
+                "Discarded %u bytes type %u payload from peer `%s'\n",
+                msg_size,
                 ntohs (message->type), GNUNET_i2s (peer));
-
     GNUNET_STATISTICS_update (GST_stats,
                               gettext_noop
-                              ("# bytes payload discarded due to not connected peer "),
+                              ("# bytes payload discarded due to not connected peer"),
                               msg_size, GNUNET_NO);
     return ret;
   }
 
-  GST_ats_add_address ((struct GNUNET_HELLO_Address *) address, session);
+  GST_ats_add_address (address, session, NULL, 0);
 
-  if (do_forward != GNUNET_YES)
+  if (GNUNET_YES != do_forward)
     return ret;
   im = (struct InboundMessage *) buf;
   im->header.size = htons (size);
   im->header.type = htons (GNUNET_MESSAGE_TYPE_TRANSPORT_RECV);
   im->peer = *peer;
   memcpy (&im[1], message, ntohs (message->size));
-
   GST_clients_broadcast (&im->header, GNUNET_YES);
-
   return ret;
 }
 
 
+/**
+ * Task to asynchronously terminate a session.
+ *
+ * @param cls the `struct SessionKiller` with the information for the kill
+ * @param tc scheduler context
+ */
+static void
+kill_session_task (void *cls,
+                   const struct GNUNET_SCHEDULER_TaskContext *tc)
+{
+  struct SessionKiller *sk = cls;
+
+  sk->task = GNUNET_SCHEDULER_NO_TASK;
+  GNUNET_CONTAINER_DLL_remove (sk_head, sk_tail, sk);
+  sk->plugin->disconnect_session (sk->plugin->cls,
+                                  sk->session);
+  GNUNET_free (sk);
+}
+
+
+/**
+ * Force plugin to terminate session due to communication
+ * issue.
+ *
+ * @param plugin_name name of the plugin
+ * @param session session to termiante
+ */
+static void
+kill_session (const char *plugin_name,
+              struct Session *session)
+{
+  struct GNUNET_TRANSPORT_PluginFunctions *plugin;
+  struct SessionKiller *sk;
+
+  for (sk = sk_head; NULL != sk; sk = sk->next)
+    if (sk->session == session)
+      return;
+  plugin = GST_plugins_find (plugin_name);
+  if (NULL == plugin)
+  {
+    GNUNET_break (0);
+    return;
+  }
+  /* need to issue disconnect asynchronously */
+  sk = GNUNET_new (struct SessionKiller);
+  sk->session = session;
+  sk->plugin = plugin;
+  sk->task = GNUNET_SCHEDULER_add_now (&kill_session_task,
+                                       sk);
+  GNUNET_CONTAINER_DLL_insert (sk_head, sk_tail, sk);
+}
+
+
 /**
  * Function called by the transport for each received message.
- * This function should also be called with "NULL" for the
- * message to signal that the other peer disconnected.
  *
  * @param cls closure, const char* with the name of the plugin we received the message from
  * @param peer (claimed) identity of the other peer
  * @param message the message, NULL if we only care about
- *                learning about the delay until we should receive again -- FIXME!
+ *                learning about the delay until we should receive again
  * @param session identifier used for this session (NULL for plugins
  *                that do not offer bi-directional communication to the sender
  *                using the same "connection")
@@ -204,16 +297,17 @@ process_payload (const struct GNUNET_PeerIdentity *peer,
  *                for inbound TCP/UDP connections since it it not clear
  *                that we could establish ourselves a connection to that
  *                IP address and get the same system)
- * @param sender_address_len number of bytes in sender_address
+ * @param sender_address_len number of bytes in @a sender_address
  * @return how long the plugin should wait until receiving more data
  *         (plugins that do not support this, can ignore the return value)
  */
 struct GNUNET_TIME_Relative
-GST_receive_callback (void *cls, const struct GNUNET_PeerIdentity *peer,
-                             const struct GNUNET_MessageHeader *message,
-                             struct Session *session,
-                             const char *sender_address,
-                             uint16_t sender_address_len)
+GST_receive_callback (void *cls,
+                      const struct GNUNET_PeerIdentity *peer,
+                      const struct GNUNET_MessageHeader *message,
+                      struct Session *session,
+                      const char *sender_address,
+                      uint16_t sender_address_len)
 {
   const char *plugin_name = cls;
   struct GNUNET_TIME_Relative ret;
@@ -228,12 +322,16 @@ GST_receive_callback (void *cls, const struct GNUNET_PeerIdentity *peer,
   if (NULL == message)
     goto end;
   type = ntohs (message->type);
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Received Message with type %u from peer `%s'\n", type, GNUNET_i2s (peer));
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+              "Received Message with type %u from peer `%s'\n",
+              type,
+              GNUNET_i2s (peer));
 
   GNUNET_STATISTICS_update (GST_stats,
-                        gettext_noop
-                        ("# bytes total received"),
+                            gettext_noop
+                            ("# bytes total received"),
                             ntohs (message->size), GNUNET_NO);
+  GST_neighbours_notify_data_recv (peer, &address, session, message);
 
   switch (type)
   {
@@ -241,39 +339,65 @@ GST_receive_callback (void *cls, const struct GNUNET_PeerIdentity *peer,
     /* Legacy HELLO message, discard  */
     return ret;
   case GNUNET_MESSAGE_TYPE_HELLO:
-    GST_validation_handle_hello (message);
+    if (GNUNET_OK !=
+        GST_validation_handle_hello (message))
+    {
+      GNUNET_break_op (0);
+      kill_session (plugin_name, session);
+    }
     return ret;
   case GNUNET_MESSAGE_TYPE_TRANSPORT_PING:
     GNUNET_log (GNUNET_ERROR_TYPE_DEBUG | GNUNET_ERROR_TYPE_BULK,
                 "Processing `%s' from `%s'\n", "PING",
                 (sender_address !=
                  NULL) ? GST_plugins_a2s (&address) : TRANSPORT_SESSION_INBOUND_STRING);
-    GST_validation_handle_ping (peer, message, &address, session);
+    if (GNUNET_OK !=
+        GST_validation_handle_ping (peer, message, &address, session))
+      kill_session (plugin_name, session);
     break;
   case GNUNET_MESSAGE_TYPE_TRANSPORT_PONG:
     GNUNET_log (GNUNET_ERROR_TYPE_DEBUG | GNUNET_ERROR_TYPE_BULK,
                 "Processing `%s' from `%s'\n", "PONG",
                 (sender_address !=
                  NULL) ? GST_plugins_a2s (&address) : TRANSPORT_SESSION_INBOUND_STRING);
-    GST_validation_handle_pong (peer, message);
+    if (GNUNET_OK !=
+        GST_validation_handle_pong (peer, message))
+    {
+      GNUNET_break_op (0);
+      kill_session (plugin_name, session);
+    }
     break;
   case GNUNET_MESSAGE_TYPE_TRANSPORT_SESSION_CONNECT:
-    GST_neighbours_handle_connect (message, peer, &address, session);
+    if (GNUNET_OK !=
+        GST_neighbours_handle_connect (message, peer, &address, session))
+    {
+      GNUNET_break_op (0);
+      kill_session (plugin_name, session);
+    }
     break;
   case GNUNET_MESSAGE_TYPE_TRANSPORT_SESSION_CONNECT_ACK:
-    GST_neighbours_handle_connect_ack (message, peer, &address, session);
+    if (GNUNET_OK !=
+        GST_neighbours_handle_connect_ack (message, peer, &address, session))
+    {
+      kill_session (plugin_name, session);
+    }
     break;
   case GNUNET_MESSAGE_TYPE_TRANSPORT_SESSION_ACK:
-    GST_neighbours_handle_session_ack (message, peer, &address, session);
+    if (GNUNET_OK !=
+        GST_neighbours_handle_session_ack (message, peer, &address, session))
+    {
+      GNUNET_break_op (0);
+      kill_session (plugin_name, session);
+    }
     break;
   case GNUNET_MESSAGE_TYPE_TRANSPORT_SESSION_DISCONNECT:
     GST_neighbours_handle_disconnect_message (peer, message);
     break;
   case GNUNET_MESSAGE_TYPE_TRANSPORT_SESSION_KEEPALIVE:
-    GST_neighbours_keepalive (peer);
+    GST_neighbours_keepalive (peer, message);
     break;
   case GNUNET_MESSAGE_TYPE_TRANSPORT_SESSION_KEEPALIVE_RESPONSE:
-    GST_neighbours_keepalive_response (peer);
+    GST_neighbours_keepalive_response (peer, message);
     break;
   default:
     /* should be payload */
@@ -281,13 +405,15 @@ GST_receive_callback (void *cls, const struct GNUNET_PeerIdentity *peer,
                               gettext_noop
                               ("# bytes payload received"),
                               ntohs (message->size), GNUNET_NO);
+    GST_neighbours_notify_payload_recv (peer, &address, session, message);
     ret = process_payload (peer, &address, session, message);
     break;
   }
 end:
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Allowing receive from peer %s to continue in %llu ms\n",
-              GNUNET_i2s (peer), (unsigned long long) ret.rel_value);
+              "Allowing receive from peer %s to continue in %s\n",
+              GNUNET_i2s (peer),
+             GNUNET_STRINGS_relative_time_to_string (ret, GNUNET_YES));
   return ret;
 }
 
@@ -301,7 +427,7 @@ end:
  *                   set of valid addresses?
  * @param addr one of the addresses of the host
  *        the specific address format depends on the transport
- * @param addrlen length of the address
+ * @param addrlen length of the @a addr
  * @param dest_plugin destination plugin to use this address with
  */
 static void
@@ -338,10 +464,13 @@ plugin_env_session_end (void *cls, const struct GNUNET_PeerIdentity *peer,
 {
   const char *transport_name = cls;
   struct GNUNET_HELLO_Address address;
+  struct SessionKiller *sk;
 
   GNUNET_assert (strlen (transport_name) > 0);
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Session %p to peer `%s' ended \n",
-              session, GNUNET_i2s (peer));
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+              "Session %p to peer `%s' ended \n",
+              session,
+              GNUNET_i2s (peer));
   if (NULL != session)
     GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG | GNUNET_ERROR_TYPE_BULK,
                      "transport-ats",
@@ -355,6 +484,16 @@ plugin_env_session_end (void *cls, const struct GNUNET_PeerIdentity *peer,
 
   /* Tell ATS that session has ended */
   GNUNET_ATS_address_destroyed (GST_ats, &address, session);
+  for (sk = sk_head; NULL != sk; sk = sk->next)
+  {
+    if (sk->session == session)
+    {
+      GNUNET_CONTAINER_DLL_remove (sk_head, sk_tail, sk);
+      GNUNET_SCHEDULER_cancel (sk->task);
+      GNUNET_free (sk);
+      break;
+    }
+  }
 }
 
 
@@ -373,9 +512,10 @@ plugin_env_address_to_type (void *cls,
                             size_t addrlen)
 {
   struct GNUNET_ATS_Information ats;
+
   ats.type = htonl (GNUNET_ATS_NETWORK_TYPE);
   ats.value = htonl (GNUNET_ATS_NET_UNSPECIFIED);
-  if (GST_ats == NULL)
+  if (NULL == GST_ats)
   {
     GNUNET_break (0);
     return ats;
@@ -384,13 +524,14 @@ plugin_env_address_to_type (void *cls,
       ((addr->sa_family != AF_INET6) && (addrlen != sizeof (struct sockaddr_in6))) &&
       (addr->sa_family != AF_UNIX))
   {
-    GNUNET_log (GNUNET_ERROR_TYPE_ERROR, "Malformed address with length %u `%s'\n",
+    GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+                "Malformed address with length %u `%s'\n",
                 addrlen,
-                GNUNET_a2s(addr, addrlen));
+                GNUNET_a2s (addr, addrlen));
     GNUNET_break (0);
     return ats;
   }
-  return GNUNET_ATS_address_get_type(GST_ats, addr, addrlen);
+  return GNUNET_ATS_address_get_type (GST_ats, addr, addrlen);
 }
 
 
@@ -400,49 +541,61 @@ plugin_env_address_to_type (void *cls,
  *
  * @param address the address
  * @param session the session
+ * @param ats ats information
+ * @param ats_count number of @a ats information
  */
 void
 GST_ats_add_address (const struct GNUNET_HELLO_Address *address,
-                                                                                struct Session *session)
+                     struct Session *session,
+                     const struct GNUNET_ATS_Information *ats,
+                     uint32_t ats_count)
 {
   struct GNUNET_TRANSPORT_PluginFunctions *papi;
-       struct GNUNET_ATS_Information ats;
-       uint32_t net;
+  struct GNUNET_ATS_Information ats2[ats_count + 1];
+  uint32_t net;
 
   /* valid new address, let ATS know! */
   if (NULL == address->transport_name)
   {
-       GNUNET_break (0);
-       return;
+    GNUNET_break (0);
+    return;
   }
   if (NULL == (papi = GST_plugins_find (address->transport_name)))
   {
     /* we don't have the plugin for this address */
-       GNUNET_break (0);
-       return;
+    GNUNET_break (0);
+    return;
   }
 
   if (GNUNET_YES == GNUNET_ATS_session_known (GST_ats, address, session))
-       return;
+  {
+    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                "ATS already knows the address, not passing it on again\n");
+    return;
+  }
 
-       net = papi->get_network (NULL, (void *) session);
+  net = papi->get_network (NULL, session);
   if (GNUNET_ATS_NET_UNSPECIFIED == net)
   {
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
-                                               _("Could not obtain a valid network for `%s' %s\n"),
-                GNUNET_i2s (&address->peer), GST_plugins_a2s (address));
-       GNUNET_break (0);
+                _("Could not obtain a valid network for `%s' %s (%s)\n"),
+                GNUNET_i2s (&address->peer),
+                GST_plugins_a2s (address),
+                address->transport_name);
+    GNUNET_break (0);
   }
-       ats.type = htonl (GNUNET_ATS_NETWORK_TYPE);
-       ats.value = htonl(net);
-       GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                       "Notifying ATS about peer `%s''s new address `%s' session %p in network %s\n",
-                       GNUNET_i2s (&address->peer),
-                       (0 == address->address_length) ? "<inbound>" : GST_plugins_a2s (address),
-                       session,
-                       GNUNET_ATS_print_network_type(net));
-       GNUNET_ATS_address_add (GST_ats,
-                       address, session, &ats, 1);
+  ats2[0].type = htonl (GNUNET_ATS_NETWORK_TYPE);
+  ats2[0].value = htonl(net);
+  memcpy (&ats2[1], ats, sizeof (struct GNUNET_ATS_Information) * ats_count);
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+              "Notifying ATS about peer `%s''s new address `%s' session %p in network %s\n",
+              GNUNET_i2s (&address->peer),
+              (0 == address->address_length) ? "<inbound>" : GST_plugins_a2s (address),
+              session,
+              GNUNET_ATS_print_network_type(net));
+  GNUNET_ATS_address_add (GST_ats,
+                          address, session,
+                          ats2, ats_count + 1);
 }
 
 
@@ -453,7 +606,7 @@ GST_ats_add_address (const struct GNUNET_HELLO_Address *address,
  * @param address the address
  * @param session the session
  * @param ats performance information
- * @param ats_count number of elements in ats
+ * @param ats_count number of elements in @a ats
  */
 void
 GST_ats_update_metrics (const struct GNUNET_PeerIdentity *peer,
@@ -462,23 +615,28 @@ GST_ats_update_metrics (const struct GNUNET_PeerIdentity *peer,
                        const struct GNUNET_ATS_Information *ats,
                        uint32_t ats_count)
 {
-       struct GNUNET_ATS_Information *ats_new;
+  struct GNUNET_ATS_Information *ats_new;
 
   if (GNUNET_NO == GNUNET_ATS_session_known (GST_ats, address, session))
-       return;
-
-       /* Call to manipulation to manipulate ATS information */
-       ats_new = GST_manipulation_manipulate_metrics (peer, address, session, ats, ats_count);
-       if (NULL == ats_new)
-       {
-                       GNUNET_break (0);
-                       return;
-       }
-  if (GNUNET_NO == GNUNET_ATS_address_update (GST_ats, address, session, ats_new, ats_count))
+    return;
+
+  /* Call to manipulation to manipulate ATS information */
+  ats_new = GST_manipulation_manipulate_metrics (peer, address, session, ats,
+                                                 ats_count);
+  if (NULL == ats_new)
   {
-       GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
-                       _("Address or session unknown: failed to update properties for peer `%s' plugin `%s' address `%s' session %p\n"),
-                       GNUNET_i2s (peer), address->transport_name, GST_plugins_a2s (address), session);
+    GNUNET_break(0);
+    return;
+  }
+  if (GNUNET_NO == GNUNET_ATS_address_update (GST_ats,
+      address, session, ats_new, ats_count))
+  {
+    GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+                _("Address or session unknown: failed to update properties for peer `%s' plugin `%s' address `%s' session %p\n"),
+                GNUNET_i2s (peer),
+                address->transport_name,
+                GST_plugins_a2s (address),
+                session);
   }
   GNUNET_free (ats_new);
 }
@@ -491,10 +649,10 @@ GST_ats_update_metrics (const struct GNUNET_PeerIdentity *peer,
  * @param cls closure
  * @param peer the peer
  * @param address binary address
- * @param address_len length of the address
+ * @param address_len length of the @a address
  * @param session the session
  * @param ats the ats information to update
- * @param ats_count the number of ats elements
+ * @param ats_count the number of @a ats elements
  */
 static void
 plugin_env_update_metrics (void *cls,
@@ -505,67 +663,78 @@ plugin_env_update_metrics (void *cls,
                           const struct GNUNET_ATS_Information *ats,
                           uint32_t ats_count)
 {
-  struct GNUNET_HELLO_Address haddress;
   const char *plugin_name = cls;
+  struct GNUNET_HELLO_Address haddress;
 
-       if ((NULL == ats) || (0 == ats_count))
-               return;
-       GNUNET_assert (NULL != GST_ats);
-
+  if ((NULL == ats) || (0 == ats_count))
+    return;
+  GNUNET_assert (NULL != GST_ats);
 
-       haddress.peer = *peer;
-       haddress.address = address;
+  haddress.peer = *peer;
+  haddress.address = address;
   haddress.address_length = address_len;
   haddress.transport_name = plugin_name;
 
-       GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Updating metrics for peer `%s' address %s session %p\n",
-                       GNUNET_i2s (peer), GST_plugins_a2s(&haddress), session);
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+              "Updating metrics for peer `%s' address %s session %p\n",
+              GNUNET_i2s (peer),
+              GST_plugins_a2s (&haddress),
+              session);
   GST_ats_update_metrics (peer, &haddress, session, ats, ats_count);
 }
 
+
+/**
+ * Plugin tells transport service about a new (inbound) session
+ *
+ * @param cls unused
+ * @param peer the peer
+ * @param plugin plugin name
+ * @param address address
+ * @param address_len @a address length
+ * @param session the new session
+ * @param ats ats information
+ * @param ats_count number of @a ats information
+ */
 static void
 plugin_env_session_start (void *cls,
-          const struct GNUNET_PeerIdentity *peer,
-          const char *plugin,
-          const void *address,
-          uint16_t address_len,
-          struct Session *session,
-          const struct GNUNET_ATS_Information *ats,
-          uint32_t ats_count)
+                          const struct GNUNET_PeerIdentity *peer,
+                          const char *plugin,
+                          const void *address, uint16_t address_len,
+                          struct Session *session,
+                          const struct GNUNET_ATS_Information *ats,
+                          uint32_t ats_count)
 {
-       if (NULL == peer)
-       {
-               GNUNET_break (0);
-               return;
-       }
-       if (NULL == plugin)
-       {
-               GNUNET_break (0);
-               return;
-       }
-       if ((address_len != 0) && (NULL == address))
-       {
-               GNUNET_break (0);
-               return;
-       }
-       if (NULL == session)
-       {
-               GNUNET_break (0);
-               return;
-       }
-
-       struct GNUNET_HELLO_Address *addr;
-       addr = GNUNET_HELLO_address_allocate (peer, plugin, address, address_len);
-       GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                       "Notification from plugin `%s' about new session %p from peer `%s' address `%s'\n",
-                       plugin, session, GNUNET_i2s (peer), GST_plugins_a2s(addr));
-       GST_ats_add_address (addr, session);
-
-       if (0 < ats_count)
-               GST_ats_update_metrics (peer, addr, session, ats, ats_count);
-       GNUNET_free (addr);
+  struct GNUNET_HELLO_Address *addr;
+
+  if (NULL == peer)
+  {
+    GNUNET_break(0);
+    return;
+  }
+  if (NULL == plugin)
+  {
+    GNUNET_break(0);
+    return;
+  }
+  if (NULL == session)
+  {
+    GNUNET_break(0);
+    return;
+  }
+
+  addr = GNUNET_HELLO_address_allocate (peer, plugin, address, address_len);
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+              "Notification from plugin `%s' about new session %p from peer `%s' address `%s'\n",
+              plugin,
+              session,
+              GNUNET_i2s (peer),
+              GST_plugins_a2s (addr));
+  GST_ats_add_address (addr, session, ats, ats_count);
+  GNUNET_free(addr);
 }
 
+
 /**
  * Function called by ATS to notify the callee that the
  * assigned bandwidth or address for a given peer was changed.  If the
@@ -576,13 +745,16 @@ plugin_env_session_start (void *cls,
  * @param cls closure
  * @param address address to use (for peer given in address)
  * @param session session to use (if available)
- * @param bandwidth_out assigned outbound bandwidth for the connection, 0 to disconnect from peer
- * @param bandwidth_in assigned inbound bandwidth for the connection, 0 to disconnect from peer
+ * @param bandwidth_out assigned outbound bandwidth for the connection in NBO,
+ *     0 to disconnect from peer
+ * @param bandwidth_in assigned inbound bandwidth for the connection in NBO,
+ *     0 to disconnect from peer
  * @param ats ATS information
- * @param ats_count number of ATS elements
+ * @param ats_count number of @a ats elements
  */
 static void
 ats_request_address_change (void *cls,
+                            const struct GNUNET_PeerIdentity *peer,
                             const struct GNUNET_HELLO_Address *address,
                             struct Session *session,
                             struct GNUNET_BANDWIDTH_Value32NBO bandwidth_out,
@@ -594,17 +766,18 @@ ats_request_address_change (void *cls,
   uint32_t bw_out = ntohl (bandwidth_out.value__);
 
   /* ATS tells me to disconnect from peer */
-  if ((bw_in == 0) && (bw_out == 0))
+  if ((0 == bw_in) && (0 == bw_out))
   {
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+    GNUNET_log (GNUNET_ERROR_TYPE_INFO,
                 "ATS tells me to disconnect from peer `%s'\n",
                 GNUNET_i2s (&address->peer));
     GST_neighbours_force_disconnect (&address->peer);
     return;
   }
+
   GST_neighbours_switch_to_address (&address->peer, address, session, ats,
-                                         ats_count, bandwidth_in,
-                                         bandwidth_out);
+                                    ats_count, bandwidth_in,
+                                    bandwidth_out);
 }
 
 
@@ -631,7 +804,6 @@ neighbours_connect_notification (void *cls,
   GNUNET_log (GNUNET_ERROR_TYPE_INFO,
               "We are now connected to peer `%s' and %u peers in total\n",
               GNUNET_i2s (peer), connections);
-
   connect_msg->header.size = htons (sizeof (buf));
   connect_msg->header.type = htons (GNUNET_MESSAGE_TYPE_TRANSPORT_CONNECT);
   connect_msg->id = *peer;
@@ -675,13 +847,28 @@ neighbours_disconnect_notification (void *cls,
  * @param cls closure
  * @param peer peer this update is about (never NULL)
  * @param address address, NULL on disconnect
+ * @param state current state this peer is in
+ * @param state_timeout timeout for the current state of the peer
+ * @param bandwidth_in bandwidth assigned inbound
+ * @param bandwidth_out bandwidth assigned outbound
  */
 static void
-neighbours_address_notification (void *cls,
+neighbours_changed_notification (void *cls,
                                  const struct GNUNET_PeerIdentity *peer,
-                                 const struct GNUNET_HELLO_Address *address)
+                                 const struct GNUNET_HELLO_Address *address,
+                                 enum GNUNET_TRANSPORT_PeerState state,
+                                 struct GNUNET_TIME_Absolute state_timeout,
+                                 struct GNUNET_BANDWIDTH_Value32NBO bandwidth_in,
+                                 struct GNUNET_BANDWIDTH_Value32NBO bandwidth_out)
 {
-  GST_clients_broadcast_address_notification (peer, address);
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+      "Notifying about change for peer `%s' with address `%s' in state `%s' timing out at %s\n",
+      GNUNET_i2s (peer),
+      (NULL != address) ? GST_plugins_a2s (address) : "<none>",
+      GNUNET_TRANSPORT_p2s(state),
+      GNUNET_STRINGS_absolute_time_to_string(state_timeout));
+
+  GST_clients_broadcast_peer_notification (peer, address, state, state_timeout);
 }
 
 
@@ -718,7 +905,7 @@ shutdown_task (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
   }
   if (NULL != GST_my_private_key)
   {
-    GNUNET_CRYPTO_ecc_key_free (GST_my_private_key);
+    GNUNET_free (GST_my_private_key);
     GST_my_private_key = NULL;
   }
   GST_server = NULL;
@@ -737,7 +924,7 @@ run (void *cls, struct GNUNET_SERVER_Handle *server,
      const struct GNUNET_CONFIGURATION_Handle *c)
 {
   char *keyfile;
-  struct GNUNET_CRYPTO_EccPrivateKey *pk;
+  struct GNUNET_CRYPTO_EddsaPrivateKey *pk;
   long long unsigned int max_fd_cfg;
   int max_fd_rlimit;
   int max_fd;
@@ -750,8 +937,7 @@ run (void *cls, struct GNUNET_SERVER_Handle *server,
                                                &keyfile))
   {
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
-                _
-                ("Transport service is lacking key configuration settings.  Exiting.\n"));
+                _("Transport service is lacking key configuration settings. Exiting.\n"));
     GNUNET_SCHEDULER_shutdown ();
     return;
   }
@@ -762,16 +948,15 @@ run (void *cls, struct GNUNET_SERVER_Handle *server,
     hello_expiration = GNUNET_CONSTANTS_HELLO_ADDRESS_EXPIRATION;
   }
   GST_server = server;
-  pk = GNUNET_CRYPTO_ecc_key_create_from_file (keyfile);
+  pk = GNUNET_CRYPTO_eddsa_key_create_from_file (keyfile);
   GNUNET_free (keyfile);
   GNUNET_assert (NULL != pk);
   GST_my_private_key = pk;
 
   GST_stats = GNUNET_STATISTICS_create ("transport", GST_cfg);
   GST_peerinfo = GNUNET_PEERINFO_connect (GST_cfg);
-  GNUNET_CRYPTO_ecc_key_get_public (GST_my_private_key, &GST_my_public_key);
-  GNUNET_CRYPTO_hash (&GST_my_public_key, sizeof (GST_my_public_key),
-                      &GST_my_identity.hashPubKey);
+  GNUNET_CRYPTO_eddsa_key_get_public (GST_my_private_key,
+                                                 &GST_my_identity.public_key);
   GNUNET_assert (NULL != GST_my_private_key);
 
   GNUNET_log (GNUNET_ERROR_TYPE_INFO,
@@ -789,14 +974,14 @@ run (void *cls, struct GNUNET_SERVER_Handle *server,
 
   max_fd_rlimit = 0;
   max_fd_cfg = 0;
-  max_fd = 0;
 #if HAVE_GETRLIMIT
   struct rlimit r_file;
   if (0 == getrlimit (RLIMIT_NOFILE, &r_file))
   {
     max_fd_rlimit = r_file.rlim_cur;
     GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-               "Maximum number of open files was: %u/%u\n", r_file.rlim_cur,
+               "Maximum number of open files was: %u/%u\n",
+                r_file.rlim_cur,
                r_file.rlim_max);
   }
   max_fd_rlimit = (9 * max_fd_rlimit) / 10; /* Keep 10% for rest of transport */
@@ -833,7 +1018,7 @@ run (void *cls, struct GNUNET_SERVER_Handle *server,
   GST_neighbours_start (NULL,
                         &neighbours_connect_notification,
                         &neighbours_disconnect_notification,
-                        &neighbours_address_notification,
+                        &neighbours_changed_notification,
                         (max_fd / 3) * 2);
   GST_clients_start (GST_server);
   GST_validation_start ((max_fd / 3));