*/
#define VERBOSE 0
+/**
+ * Must match IP given in the client.
+ */
+#define DUMMY_IP "192.0.2.86"
+
/**
* TTL to use for our outgoing messages.
*/
#define ICMP_TIME_EXCEEDED 11 /* Time Exceeded */
-/**
- * Must match IP given in the client.
- */
-#define DUMMY_IP "192.0.2.86"
-
/**
* How often do we send our ICMP messages to receive replies?
*/
/**
* Version (4 bits) + Internet header length (4 bits)
*/
- u_char vers_ihl;
+ uint8_t vers_ihl;
/**
* Type of service
*/
- u_char tos;
+ uint8_t tos;
/**
* Total length
*/
- u_short pkt_len;
+ uint16_t pkt_len;
/**
* Identification
*/
- u_short id;
+ uint16_t id;
/**
* Flags (3 bits) + Fragment offset (13 bits)
*/
- u_short flags_frag_offset;
+ uint16_t flags_frag_offset;
/**
* Time to live
*/
- u_char ttl;
+ uint8_t ttl;
/**
* Protocol
*/
- u_char proto;
+ uint8_t proto;
/**
* Header checksum
*/
- u_short checksum;
+ uint16_t checksum;
/**
* Source address
*/
- u_long src_ip;
+ uint32_t src_ip;
/**
* Destination address
*/
- u_long dst_ip;
+ uint32_t dst_ip;
};
/**
struct udp_packet udp_pkt;
size_t off;
int have_port;
- int have_udp;
uint32_t port;
have = read (icmpsock, buf, sizeof (buf));
sizeof (sip));
memcpy (&ip_pkt, &buf[off], sizeof (ip_pkt));
off += sizeof (ip_pkt);
- have_udp = (ip_pkt.proto == IPPROTO_UDP);
if (have_port)
{
buf,
port);
}
- else if (have_udp)
+ else if (ip_pkt.proto == IPPROTO_UDP)
{
memcpy(&udp_pkt,
&buf[off],
fprintf (stdout,
"%s:%d\n",
buf,
- ntohs((int)udp_pkt.length));
+ ntohs((uint16_t)udp_pkt.length));
}
else
{
/**
* Create an ICMP raw socket for reading.
+ *
+ * @return INVALID_SOCKET on error
*/
static SOCKET
make_icmp_socket ()
fprintf (stderr,
"Error opening RAW socket: %s\n",
strerror (errno));
- return -1;
+ return INVALID_SOCKET;
}
return ret;
}
/**
* Create an ICMP raw socket for writing.
+ *
+ * @return INVALID_SOCKET on error
*/
static SOCKET
make_raw_socket ()
fprintf (stderr, "Failed to find Winsock 2.1 or better.\n");
return 2;
}
- if (-1 == (icmpsock = make_icmp_socket()))
+ if (INVALID_SOCKET == (icmpsock = make_icmp_socket()))
{
return 3;
}
- if (-1 == (make_raw_socket()))
+ if (INVALID_SOCKET == (make_raw_socket()))
{
closesocket (icmpsock);
return 3;
FD_SET (icmpsock, &rs);
tv.tv_sec = 0;
tv.tv_usec = ICMP_SEND_FREQUENCY_MS * 1000;
- if (0 != select (icmpsock + 1, &rs, NULL, NULL, &tv))
+ if (-1 == select (icmpsock + 1, &rs, NULL, NULL, &tv))
{
if (errno == EINTR)
continue;