-adding some rudimentary logging
[oweals/gnunet.git] / src / topology / gnunet-daemon-topology.c
index 91d0ed12de37a99aa1f130542c00d6fe47d6338f..38a648afc03bce3d24f19f91857e42d951375427 100644 (file)
@@ -88,12 +88,6 @@ struct Peer
    */
   struct GNUNET_CORE_TransmitHandle *hello_req;
 
-  /**
-   * Our handle for the request to connect to this peer; NULL if no
-   * such request is pending.
-   */
-  struct GNUNET_CORE_PeerRequestHandle *connect_req;
-
   /**
    * Pointer to the HELLO message of this peer; can be NULL.
    */
@@ -231,7 +225,7 @@ static int autoconnect;
 
 
 /**
- * Function that decides if a connection is acceptable or not.  
+ * Function that decides if a connection is acceptable or not.
  * If we have a blacklist, only friends are allowed, so the check
  * is rather simple.
  *
@@ -247,8 +241,8 @@ blacklist_check (void *cls, const struct GNUNET_PeerIdentity *pid)
   pos = GNUNET_CONTAINER_multihashmap_get (peers, &pid->hashPubKey);
   if ((pos != NULL) && (pos->is_friend == GNUNET_YES))
     return GNUNET_OK;
-  GNUNET_STATISTICS_update (stats,
-                            gettext_noop ("# peers blacklisted"), 1, GNUNET_NO);
+  GNUNET_STATISTICS_update (stats, gettext_noop ("# peers blacklisted"), 1,
+                            GNUNET_NO);
   return GNUNET_SYSERR;
 }
 
@@ -268,32 +262,17 @@ whitelist_peers ()
 }
 
 
-/**
- * Function called by core when our request to connect was transmitted.
- *
- * @param cls the 'struct Peer' for which we issued the connect request
- * @param success was the request transmitted
- */
-static void
-connect_completed_callback (void *cls, int success)
-{
-  struct Peer *pos = cls;
-
-  pos->connect_req = NULL;
-}
-
-
 /**
  * Check if an additional connection from the given peer is allowed.
- * 
+ *
  * @param peer connection to check
  * @return GNUNET_OK if the connection is allowed
  */
 static int
 is_connection_allowed (struct Peer *peer)
 {
-  if (0 == memcmp (&my_identity,
-                   &peer->pid, sizeof (struct GNUNET_PeerIdentity)))
+  if (0 ==
+      memcmp (&my_identity, &peer->pid, sizeof (struct GNUNET_PeerIdentity)))
     return GNUNET_SYSERR;       /* disallow connections to self */
   if (peer->is_friend)
     return GNUNET_OK;
@@ -334,8 +313,6 @@ free_peer (void *cls, const GNUNET_HashCode * pid, void *value)
                 GNUNET_CONTAINER_multihashmap_remove (peers, pid, pos));
   if (pos->hello_req != NULL)
     GNUNET_CORE_notify_transmit_ready_cancel (pos->hello_req);
-  if (pos->connect_req != NULL)
-    GNUNET_CORE_peer_request_connect_cancel (pos->connect_req);
   if (pos->hello_delay_task != GNUNET_SCHEDULER_NO_TASK)
     GNUNET_SCHEDULER_cancel (pos->hello_delay_task);
   if (pos->greylist_clean_task != GNUNET_SCHEDULER_NO_TASK)
@@ -392,19 +369,17 @@ attempt_connect (struct Peer *pos)
   pos->greylisted_until = GNUNET_TIME_relative_to_absolute (rem);
   if (pos->greylist_clean_task != GNUNET_SCHEDULER_NO_TASK)
     GNUNET_SCHEDULER_cancel (pos->greylist_clean_task);
-  pos->greylist_clean_task
-      GNUNET_SCHEDULER_add_delayed (rem, &remove_from_greylist, pos);
+  pos->greylist_clean_task =
+      GNUNET_SCHEDULER_add_delayed (rem, &remove_from_greylist, pos);
 #if DEBUG_TOPOLOGY
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Asking  to connect to `%s'\n", GNUNET_i2s (&pos->pid));
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Asking  to connect to `%s'\n",
+              GNUNET_i2s (&pos->pid));
 #endif
   GNUNET_STATISTICS_update (stats,
-                            gettext_noop ("# connect requests issued to core"),
-                            1, GNUNET_NO);
-  pos->connect_req = GNUNET_CORE_peer_request_connect (handle,
-                                                       &pos->pid,
-                                                       &connect_completed_callback,
-                                                       pos);
+                            gettext_noop
+                            ("# connect requests issued to transport"), 1,
+                            GNUNET_NO);
+  GNUNET_TRANSPORT_try_connect (transport, &pos->pid);
 }
 
 
@@ -429,11 +404,11 @@ remove_from_greylist (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
   }
   else
   {
-    pos->greylist_clean_task
-        GNUNET_SCHEDULER_add_delayed (rem, &remove_from_greylist, pos);
+    pos->greylist_clean_task =
+        GNUNET_SCHEDULER_add_delayed (rem, &remove_from_greylist, pos);
   }
-  if ((GNUNET_NO == pos->is_friend) &&
-      (GNUNET_NO == pos->is_connected) && (NULL == pos->hello))
+  if ((GNUNET_NO == pos->is_friend) && (GNUNET_NO == pos->is_connected) &&
+      (NULL == pos->hello))
   {
     free_peer (NULL, &pos->pid.hashPubKey, pos);
     return;
@@ -450,8 +425,7 @@ remove_from_greylist (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
  * @return the new entry
  */
 static struct Peer *
-make_peer (const struct
-           GNUNET_PeerIdentity *peer,
+make_peer (const struct GNUNET_PeerIdentity *peer,
            const struct GNUNET_HELLO_Message *hello, int is_friend)
 {
   struct Peer *ret;
@@ -465,8 +439,7 @@ make_peer (const struct
     memcpy (ret->hello, hello, GNUNET_HELLO_size (hello));
   }
   GNUNET_break (GNUNET_OK ==
-                GNUNET_CONTAINER_multihashmap_put (peers,
-                                                   &peer->hashPubKey,
+                GNUNET_CONTAINER_multihashmap_put (peers, &peer->hashPubKey,
                                                    ret,
                                                    GNUNET_CONTAINER_MULTIHASHMAPOPTION_UNIQUE_ONLY));
   return ret;
@@ -505,7 +478,8 @@ setup_filter (struct Peer *peer)
  * @param buf where the callee should write the message
  * @return number of bytes written to buf
  */
-static size_t hello_advertising_ready (void *cls, size_t size, void *buf);
+static size_t
+hello_advertising_ready (void *cls, size_t size, void *buf);
 
 
 /**
@@ -538,7 +512,7 @@ struct FindAdvHelloContext
  *
  * @param cls closure
  * @param pid identity of a peer
- * @param value 'struct Peer*' for the peer we are considering 
+ * @param value 'struct Peer*' for the peer we are considering
  * @return GNUNET_YES (continue iteration)
  */
 static int
@@ -599,8 +573,8 @@ schedule_next_hello (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
   fah.max_size = GNUNET_SERVER_MAX_MESSAGE_SIZE - 1;
   fah.next_adv = GNUNET_TIME_UNIT_FOREVER_REL;
   GNUNET_CONTAINER_multihashmap_iterate (peers, &find_advertisable_hello, &fah);
-  pl->hello_delay_task
-      GNUNET_SCHEDULER_add_delayed (fah.next_adv, &schedule_next_hello, pl);
+  pl->hello_delay_task =
+      GNUNET_SCHEDULER_add_delayed (fah.next_adv, &schedule_next_hello, pl);
   if (fah.result == NULL)
     return;
   next_want = GNUNET_HELLO_size (fah.result->hello);
@@ -608,14 +582,11 @@ schedule_next_hello (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
   if (delay.rel_value == 0)
   {
     /* now! */
-    pl->hello_req = GNUNET_CORE_notify_transmit_ready (handle,
-                                                       GNUNET_YES,
-                                                       0,
-                                                       GNUNET_CONSTANTS_SERVICE_TIMEOUT,
-                                                       &pl->pid,
-                                                       next_want,
-                                                       &hello_advertising_ready,
-                                                       pl);
+    pl->hello_req =
+        GNUNET_CORE_notify_transmit_ready (handle, GNUNET_YES, 0,
+                                           GNUNET_CONSTANTS_SERVICE_TIMEOUT,
+                                           &pl->pid, next_want,
+                                           &hello_advertising_ready, pl);
   }
 }
 
@@ -650,8 +621,8 @@ reschedule_hellos (void *cls, const GNUNET_HashCode * pid, void *value)
     GNUNET_SCHEDULER_cancel (peer->hello_delay_task);
     peer->hello_delay_task = GNUNET_SCHEDULER_NO_TASK;
   }
-  peer->hello_delay_task
-      GNUNET_SCHEDULER_add_now (&schedule_next_hello, peer);
+  peer->hello_delay_task =
+      GNUNET_SCHEDULER_add_now (&schedule_next_hello, peer);
   return GNUNET_YES;
 }
 
@@ -662,12 +633,12 @@ reschedule_hellos (void *cls, const GNUNET_HashCode * pid, void *value)
  * @param cls closure
  * @param peer peer identity this notification is about
  * @param atsi performance data
+ * @param atsi_count number of records in 'atsi'
  */
 static void
-connect_notify (void *cls,
-                const struct
-                GNUNET_PeerIdentity *peer,
-                const struct GNUNET_TRANSPORT_ATS_Information *atsi)
+connect_notify (void *cls, const struct GNUNET_PeerIdentity *peer,
+                const struct GNUNET_ATS_Information *atsi,
+                unsigned int atsi_count)
 {
   struct Peer *pos;
 
@@ -680,8 +651,7 @@ connect_notify (void *cls,
     return;
 
   connection_count++;
-  GNUNET_STATISTICS_set (stats,
-                         gettext_noop ("# peers connected"),
+  GNUNET_STATISTICS_set (stats, gettext_noop ("# peers connected"),
                          connection_count, GNUNET_NO);
   pos = GNUNET_CONTAINER_multihashmap_get (peers, &peer->hashPubKey);
   if (pos == NULL)
@@ -702,8 +672,7 @@ connect_notify (void *cls,
         (GNUNET_YES != friends_only))
       whitelist_peers ();
     friend_count++;
-    GNUNET_STATISTICS_set (stats,
-                           gettext_noop ("# friends connected"),
+    GNUNET_STATISTICS_set (stats, gettext_noop ("# friends connected"),
                            friend_count, GNUNET_NO);
   }
   reschedule_hellos (NULL, &peer->hashPubKey, pos);
@@ -784,14 +753,12 @@ disconnect_notify (void *cls, const struct GNUNET_PeerIdentity *peer)
     GNUNET_SCHEDULER_cancel (pos->hello_delay_task);
     pos->hello_delay_task = GNUNET_SCHEDULER_NO_TASK;
   }
-  GNUNET_STATISTICS_set (stats,
-                         gettext_noop ("# peers connected"),
+  GNUNET_STATISTICS_set (stats, gettext_noop ("# peers connected"),
                          connection_count, GNUNET_NO);
   if (pos->is_friend)
   {
     friend_count--;
-    GNUNET_STATISTICS_set (stats,
-                           gettext_noop ("# friends connected"),
+    GNUNET_STATISTICS_set (stats, gettext_noop ("# friends connected"),
                            friend_count, GNUNET_NO);
   }
   if (((connection_count < target_connection_count) ||
@@ -807,17 +774,13 @@ disconnect_notify (void *cls, const struct GNUNET_PeerIdentity *peer)
  * Iterator called on each address.
  *
  * @param cls flag that we will set if we see any addresses
- * @param tname name of the transport
+ * @param address the address of the peer
  * @param expiration when will the given address expire
- * @param addr the address of the peer
- * @param addrlen number of bytes in addr
  * @return GNUNET_SYSERR always, to terminate iteration
  */
 static int
-address_iterator (void *cls,
-                  const char *tname,
-                  struct GNUNET_TIME_Absolute expiration,
-                  const void *addr, uint16_t addrlen)
+address_iterator (void *cls, const struct GNUNET_HELLO_Address *address,
+                  struct GNUNET_TIME_Absolute expiration)
 {
   int *flag = cls;
 
@@ -850,8 +813,8 @@ consider_for_advertising (const struct GNUNET_HELLO_Message *hello)
   if (0 == memcmp (&pid, &my_identity, sizeof (struct GNUNET_PeerIdentity)))
     return;                     /* that's me! */
   have_address = GNUNET_NO;
-  GNUNET_HELLO_iterate_addresses (hello,
-                                  GNUNET_NO, &address_iterator, &have_address);
+  GNUNET_HELLO_iterate_addresses (hello, GNUNET_NO, &address_iterator,
+                                  &have_address);
   if (GNUNET_NO == have_address)
     return;                     /* no point in advertising this one... */
   peer = GNUNET_CONTAINER_multihashmap_get (peers, &pid.hashPubKey);
@@ -867,8 +830,8 @@ consider_for_advertising (const struct GNUNET_HELLO_Message *hello)
   }
 #if DEBUG_TOPOLOGY
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Found `%s' from peer `%s' for advertising\n",
-              "HELLO", GNUNET_i2s (&pid));
+              "Found `%s' from peer `%s' for advertising\n", "HELLO",
+              GNUNET_i2s (&pid));
 #endif
   if (peer->hello != NULL)
   {
@@ -901,8 +864,7 @@ consider_for_advertising (const struct GNUNET_HELLO_Message *hello)
  * @param err_msg NULL if successful, otherwise contains error message
  */
 static void
-process_peer (void *cls,
-              const struct GNUNET_PeerIdentity *peer,
+process_peer (void *cls, const struct GNUNET_PeerIdentity *peer,
               const struct GNUNET_HELLO_Message *hello, const char *err_msg)
 {
   struct Peer *pos;
@@ -932,8 +894,7 @@ process_peer (void *cls,
         GNUNET_CONTAINER_bloomfilter_free (pos->filter);
         pos->filter = NULL;
       }
-      if ((!pos->is_connected) &&
-          (!pos->is_friend) &&
+      if ((!pos->is_connected) && (!pos->is_friend) &&
           (0 ==
            GNUNET_TIME_absolute_get_remaining (pos->
                                                greylisted_until).rel_value))
@@ -949,22 +910,22 @@ process_peer (void *cls,
   if (GNUNET_YES == pos->is_connected)
   {
 #if DEBUG_TOPOLOGY
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                "Already connected to peer `%s'\n", GNUNET_i2s (peer));
+    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Already connected to peer `%s'\n",
+                GNUNET_i2s (peer));
 #endif
     return;
   }
   if (GNUNET_TIME_absolute_get_remaining (pos->greylisted_until).rel_value > 0)
   {
 #if DEBUG_TOPOLOGY
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                "Already tried peer `%s' recently\n", GNUNET_i2s (peer));
+    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Already tried peer `%s' recently\n",
+                GNUNET_i2s (peer));
 #endif
     return;                     /* peer still greylisted */
   }
 #if DEBUG_TOPOLOGY
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Considering connecting to peer `%s'\n", GNUNET_i2s (peer));
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Considering connecting to peer `%s'\n",
+              GNUNET_i2s (peer));
 #endif
   attempt_connect (pos);
 }
@@ -977,13 +938,10 @@ process_peer (void *cls,
  * @param cls closure
  * @param server handle to the server, NULL if we failed
  * @param my_id ID of this peer, NULL if we failed
- * @param publicKey public key of this peer, NULL if we failed
  */
 static void
-core_init (void *cls,
-           struct GNUNET_CORE_Handle *server,
-           const struct GNUNET_PeerIdentity *my_id,
-           const struct GNUNET_CRYPTO_RsaPublicKeyBinaryEncoded *publicKey)
+core_init (void *cls, struct GNUNET_CORE_Handle *server,
+           const struct GNUNET_PeerIdentity *my_id)
 {
   if (server == NULL)
   {
@@ -1021,14 +979,14 @@ read_friends_file (const struct GNUNET_CONFIGURATION_Handle *cfg)
       GNUNET_CONFIGURATION_get_value_filename (cfg, "TOPOLOGY", "FRIENDS", &fn))
   {
     GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
-                _("Option `%s' in section `%s' not specified!\n"),
-                "FRIENDS", "TOPOLOGY");
+                _("Option `%s' in section `%s' not specified!\n"), "FRIENDS",
+                "TOPOLOGY");
     return;
   }
   if (GNUNET_OK != GNUNET_DISK_file_test (fn))
     GNUNET_DISK_fn_write (fn, NULL, 0,
-                          GNUNET_DISK_PERM_USER_READ
-                          GNUNET_DISK_PERM_USER_WRITE);
+                          GNUNET_DISK_PERM_USER_READ |
+                          GNUNET_DISK_PERM_USER_WRITE);
   if (0 != STAT (fn, &frstat))
   {
     if ((friends_only) || (minimum_friend_count > 0))
@@ -1039,8 +997,8 @@ read_friends_file (const struct GNUNET_CONFIGURATION_Handle *cfg)
   }
   if (frstat.st_size == 0)
   {
-    GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
-                _("Friends file `%s' is empty.\n"), fn);
+    GNUNET_log (GNUNET_ERROR_TYPE_WARNING, _("Friends file `%s' is empty.\n"),
+                fn);
     GNUNET_free (fn);
     return;
   }
@@ -1115,8 +1073,7 @@ read_friends_file (const struct GNUNET_CONFIGURATION_Handle *cfg)
   }
   GNUNET_free (data);
   GNUNET_free (fn);
-  GNUNET_STATISTICS_update (stats,
-                            gettext_noop ("# friends in configuration"),
+  GNUNET_STATISTICS_update (stats, gettext_noop ("# friends in configuration"),
                             entries_found, GNUNET_NO);
   if ((minimum_friend_count > entries_found) && (friends_only == GNUNET_NO))
   {
@@ -1143,21 +1100,21 @@ read_friends_file (const struct GNUNET_CONFIGURATION_Handle *cfg)
  *        for loopback messages where we are both sender and receiver)
  * @param message the actual HELLO message
  * @param atsi performance data
+ * @param atsi_count number of records in 'atsi'
  * @return GNUNET_OK to keep the connection open,
  *         GNUNET_SYSERR to close it (signal serious error)
  */
 static int
-handle_encrypted_hello (void *cls,
-                        const struct GNUNET_PeerIdentity *other,
+handle_encrypted_hello (void *cls, const struct GNUNET_PeerIdentity *other,
                         const struct GNUNET_MessageHeader *message,
-                        const struct GNUNET_TRANSPORT_ATS_Information *atsi)
+                        const struct GNUNET_ATS_Information *atsi,
+                        unsigned int atsi_count)
 {
   struct Peer *peer;
   struct GNUNET_PeerIdentity pid;
 
 #if DEBUG_TOPOLOGY
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Received encrypted `%s' from peer `%s'",
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Received encrypted `%s' from peer `%s'",
               "HELLO", GNUNET_i2s (other));
 #endif
   if (GNUNET_OK !=
@@ -1166,8 +1123,7 @@ handle_encrypted_hello (void *cls,
     GNUNET_break_op (0);
     return GNUNET_SYSERR;
   }
-  GNUNET_STATISTICS_update (stats,
-                            gettext_noop ("# HELLO messages received"),
+  GNUNET_STATISTICS_update (stats, gettext_noop ("# HELLO messages received"),
                             1, GNUNET_NO);
   peer = GNUNET_CONTAINER_multihashmap_get (peers, &pid.hashPubKey);
   if (peer == NULL)
@@ -1220,12 +1176,12 @@ hello_advertising_ready (void *cls, size_t size, void *buf)
     memcpy (buf, fah.result->hello, want);
     GNUNET_CONTAINER_bloomfilter_add (fah.result->filter, &pl->pid.hashPubKey);
 #if DEBUG_TOPOLOGY
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                "Sending `%s' with %u bytes", "HELLO", (unsigned int) want);
+    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Sending `%s' with %u bytes", "HELLO",
+                (unsigned int) want);
 #endif
     GNUNET_STATISTICS_update (stats,
-                              gettext_noop ("# HELLO messages gossipped"),
-                              1, GNUNET_NO);
+                              gettext_noop ("# HELLO messages gossipped"), 1,
+                              GNUNET_NO);
   }
 
   if (pl->hello_delay_task != GNUNET_SCHEDULER_NO_TASK)
@@ -1284,9 +1240,8 @@ cleaning_task (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
  * @param c configuration
  */
 static void
-run (void *cls,
-     char *const *args,
-     const char *cfgfile, const struct GNUNET_CONFIGURATION_Handle *c)
+run (void *cls, char *const *args, const char *cfgfile,
+     const struct GNUNET_CONFIGURATION_Handle *c)
 {
   static struct GNUNET_CORE_MessageHandler handlers[] = {
     {&handle_encrypted_hello, GNUNET_MESSAGE_TYPE_HELLO, 0},
@@ -1296,21 +1251,17 @@ run (void *cls,
 
   cfg = c;
   stats = GNUNET_STATISTICS_create ("topology", cfg);
-  autoconnect = GNUNET_CONFIGURATION_get_value_yesno (cfg,
-                                                      "TOPOLOGY",
-                                                      "AUTOCONNECT");
-  friends_only = GNUNET_CONFIGURATION_get_value_yesno (cfg,
-                                                       "TOPOLOGY",
-                                                       "FRIENDS-ONLY");
+  autoconnect =
+      GNUNET_CONFIGURATION_get_value_yesno (cfg, "TOPOLOGY", "AUTOCONNECT");
+  friends_only =
+      GNUNET_CONFIGURATION_get_value_yesno (cfg, "TOPOLOGY", "FRIENDS-ONLY");
   if (GNUNET_OK !=
-      GNUNET_CONFIGURATION_get_value_number (cfg,
-                                             "TOPOLOGY",
-                                             "MINIMUM-FRIENDS", &opt))
+      GNUNET_CONFIGURATION_get_value_number (cfg, "TOPOLOGY", "MINIMUM-FRIENDS",
+                                             &opt))
     opt = 0;
   minimum_friend_count = (unsigned int) opt;
   if (GNUNET_OK !=
-      GNUNET_CONFIGURATION_get_value_number (cfg,
-                                             "TOPOLOGY",
+      GNUNET_CONFIGURATION_get_value_number (cfg, "TOPOLOGY",
                                              "TARGET-CONNECTION-COUNT", &opt))
     opt = 16;
   target_connection_count = (unsigned int) opt;
@@ -1321,23 +1272,18 @@ run (void *cls,
 #if DEBUG_TOPOLOGY
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
               "Topology would like %u connections with at least %u friends (%s)\n",
-              target_connection_count,
-              minimum_friend_count,
+              target_connection_count, minimum_friend_count,
               autoconnect ? "autoconnect enabled" : "autoconnect disabled");
 #endif
   if ((friend_count < minimum_friend_count) && (blacklist == NULL))
     blacklist = GNUNET_TRANSPORT_blacklist (cfg, &blacklist_check, NULL);
   transport = GNUNET_TRANSPORT_connect (cfg, NULL, NULL, NULL, NULL, NULL);
-  handle = GNUNET_CORE_connect (cfg,
-                                1,
-                                NULL,
-                                &core_init,
-                                &connect_notify,
-                                &disconnect_notify,
-                                NULL,
-                                NULL, GNUNET_NO, NULL, GNUNET_NO, handlers);
-  GNUNET_SCHEDULER_add_delayed (GNUNET_TIME_UNIT_FOREVER_REL,
-                                &cleaning_task, NULL);
+  handle =
+      GNUNET_CORE_connect (cfg, 1, NULL, &core_init, &connect_notify,
+                           &disconnect_notify, NULL, GNUNET_NO, NULL, GNUNET_NO,
+                           handlers);
+  GNUNET_SCHEDULER_add_delayed (GNUNET_TIME_UNIT_FOREVER_REL, &cleaning_task,
+                                NULL);
   if (NULL == transport)
   {
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
@@ -1370,13 +1316,12 @@ main (int argc, char *const *argv)
   };
   int ret;
 
-  ret = (GNUNET_OK ==
-         GNUNET_PROGRAM_run (argc,
-                             argv,
-                             "gnunet-daemon-topology",
-                             _
-                             ("GNUnet topology control (maintaining P2P mesh and F2F constraints)"),
-                             options, &run, NULL)) ? 0 : 1;
+  ret =
+      (GNUNET_OK ==
+       GNUNET_PROGRAM_run (argc, argv, "gnunet-daemon-topology",
+                           _
+                           ("GNUnet topology control (maintaining P2P mesh and F2F constraints)"),
+                           options, &run, NULL)) ? 0 : 1;
   return ret;
 }