testing bug fixes (hopefully)
[oweals/gnunet.git] / src / testing / testing.c
index 78ef9bb1f7695cc859df709922b586c5f0ceae90..fcc8c97678022ed723a120b1e39fbeb5c10bf4ff 100644 (file)
  *        ONLY for writing testcases!
  * @author Christian Grothoff
  *
- * TODO:
- * - modify configuration to allow 2087-connections from
- *   controlling host (otherwise shutdown won't work)
- * 
  */
 #include "platform.h"
 #include "gnunet_arm_service.h"
 #include "gnunet_constants.h"
 #include "gnunet_testing_lib.h"
 #include "gnunet_transport_service.h"
+#include "gnunet_hello_lib.h"
 
 #define DEBUG_TESTING GNUNET_NO
+#define DEBUG_TESTING_RECONNECT GNUNET_YES
 
 /**
  * How long do we wait after starting gnunet-service-arm
  * for the core service to be alive?
  */
-#define ARM_START_WAIT GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_SECONDS, 60)
+#define ARM_START_WAIT GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_SECONDS, 120)
 
 /**
  * How many times are we willing to try to wait for "scp" or
  */
 #define MAX_EXEC_WAIT_RUNS 50
 
+static struct GNUNET_CORE_MessageHandler no_handlers[] = { {NULL, 0, 0} };
+
+/**
+ * Receive the HELLO from one peer, give it to the other
+ * and ask them to connect.
+ *
+ * @param cls "struct ConnectContext"
+ * @param message HELLO message of peer
+ */
+static void
+process_hello (void *cls, const struct GNUNET_MessageHeader *message)
+{
+  struct GNUNET_TESTING_Daemon *daemon = cls;
+  if (daemon == NULL)
+    return;
+
+  if (daemon->server != NULL)
+    {
+      GNUNET_CORE_disconnect(daemon->server);
+      daemon->server = NULL;
+    }
+
+  GNUNET_assert (message != NULL);
+  if (daemon->th != NULL)
+    {
+      GNUNET_TRANSPORT_get_hello_cancel(daemon->th, &process_hello, daemon);
+    }
+#if DEBUG_TESTING
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+              "Received `%s' from transport service of `%4s'\n",
+              "HELLO", GNUNET_i2s (&daemon->id));
+#endif
+
+  GNUNET_free_non_null(daemon->hello);
+  daemon->hello = GNUNET_malloc(ntohs(message->size));
+  memcpy(daemon->hello, message, ntohs(message->size));
+
+  if (daemon->th != NULL)
+    {
+      GNUNET_TRANSPORT_disconnect(daemon->th);
+      daemon->th = NULL;
+    }
+
+}
 
 /**
  * Function called after GNUNET_CORE_connect has succeeded
@@ -97,10 +139,30 @@ testing_init (void *cls,
   d->id = *my_identity;
   d->shortname = strdup (GNUNET_i2s (my_identity));
   d->server = server;
+  d->running = GNUNET_YES;
   if (GNUNET_YES == d->dead)
     GNUNET_TESTING_daemon_stop (d, d->dead_cb, d->dead_cb_cls);
   else if (NULL != cb)
     cb (d->cb_cls, my_identity, d->cfg, d, NULL);
+#if DEBUG_TESTING
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+              "Successfully started peer `%4s'.\n", GNUNET_i2s (my_identity));
+#endif
+
+
+  d->th = GNUNET_TRANSPORT_connect (d->sched,
+                                    d->cfg, d, NULL, NULL, NULL);
+  if (d->th == NULL)
+    {
+      if (GNUNET_YES == d->dead)
+        GNUNET_TESTING_daemon_stop (d, d->dead_cb, d->dead_cb_cls);
+      else if (NULL != d->cb)
+        d->cb (d->cb_cls, &d->id, d->cfg, d,
+            _("Failed to connect to transport service!\n"));
+      return;
+    }
+
+  GNUNET_TRANSPORT_get_hello (d->th, &process_hello, d);
 }
 
 
@@ -113,7 +175,6 @@ testing_init (void *cls,
 static void
 start_fsm (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
 {
-  static struct GNUNET_CORE_MessageHandler no_handlers[] = { {NULL, 0, 0} };
   struct GNUNET_TESTING_Daemon *d = cls;
   GNUNET_TESTING_NotifyDaemonRunning cb;
   enum GNUNET_OS_ProcessStatusType type;
@@ -124,6 +185,7 @@ start_fsm (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
               "Peer FSM is in phase %u.\n", d->phase);
 #endif
+
   d->task = GNUNET_SCHEDULER_NO_TASK;
   switch (d->phase)
     {
@@ -168,13 +230,20 @@ start_fsm (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
       /* start GNUnet on remote host */
       if (NULL == d->hostname)
         {
-          d->pid = GNUNET_OS_start_process (NULL, NULL, "gnunet-service-arm",
-                                            "gnunet-service-arm",
+#if DEBUG_TESTING
+          GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                      "Starting `%s', with command `%s %s %s %s %s %s'.\n",
+                      "gnunet-arm", "gnunet-arm", "-c", d->cfgfile,
+                      "-L", "DEBUG",
+                      "-s");
+#endif
+          d->pid = GNUNET_OS_start_process (NULL, NULL, "gnunet-arm",
+                                            "gnunet-arm",
                                             "-c", d->cfgfile,
 #if DEBUG_TESTING
                                             "-L", "DEBUG",
 #endif
-                                            "-d", NULL);
+                                            "-s", "-q", NULL);
         }
       else
         {
@@ -182,18 +251,28 @@ start_fsm (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
             GNUNET_asprintf (&dst, "%s@%s", d->username, d->hostname);
           else
             dst = GNUNET_strdup (d->hostname);
+
+#if DEBUG_TESTING
+          GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                      "Starting `%s', with command `%s %s %s %s %s %s %s %s'.\n",
+                      "gnunet-arm", "ssh", dst, "gnunet-arm", "-c", d->cfgfile,
+                      "-L", "DEBUG", "-s", "-q");
+#endif
           d->pid = GNUNET_OS_start_process (NULL, NULL, "ssh",
                                             "ssh",
                                             dst,
-                                            "gnunet-service-arm",
-                                            "-c", d->cfgfile, "-d", NULL);
+                                            "gnunet-arm",
+#if DEBUG_TESTING
+                                            "-L", "DEBUG",
+#endif
+                                            "-c", d->cfgfile, "-s", "-q", NULL);
           GNUNET_free (dst);
         }
       if (-1 == d->pid)
         {
           GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                       _("Could not start `%s' process to start GNUnet.\n"),
-                      (NULL == d->hostname) ? "gnunet-service-arm" : "ssh");
+                      (NULL == d->hostname) ? "gnunet-arm" : "ssh");
           cb = d->cb;
           d->cb = NULL;
           if (NULL != cb)
@@ -202,13 +281,13 @@ start_fsm (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
                 d->cfg,
                 d,
                 (NULL == d->hostname)
-                ? _("Failed to start `gnunet-service-arm' process.\n")
+                ? _("Failed to start `gnunet-arm' process.\n")
                 : _("Failed to start `ssh' process.\n"));
         }
 #if DEBUG_TESTING
       GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                   "Started `%s', waiting for `%s' to be up.\n",
-                  "gnunet-service-arm", "gnunet-service-core");
+                  "gnunet-arm", "gnunet-service-core");
 #endif
       d->phase = SP_START_ARMING;
       d->wait_runs = 0;
@@ -231,7 +310,7 @@ start_fsm (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
                     d->cfg,
                     d,
                     (NULL == d->hostname)
-                    ? _("`gnunet-service-arm' does not seem to terminate.\n")
+                    ? _("`gnunet-arm' does not seem to terminate.\n")
                     : _("`ssh' does not seem to terminate.\n"));
               return;
             }
@@ -244,7 +323,7 @@ start_fsm (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
         }
 #if DEBUG_TESTING
       GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                  "Successfully started `%s'.\n", "gnunet-service-arm");
+                  "Successfully started `%s'.\n", "gnunet-arm");
 #endif
       d->phase = SP_START_CORE;
       d->server = GNUNET_CORE_connect (d->sched,
@@ -252,7 +331,7 @@ start_fsm (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
                                        ARM_START_WAIT,
                                        d,
                                        &testing_init,
-                                       NULL, NULL, NULL,
+                                       NULL, NULL,
                                        NULL, GNUNET_NO,
                                        NULL, GNUNET_NO, no_handlers);
       break;
@@ -262,7 +341,7 @@ start_fsm (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
     case SP_START_DONE:
       GNUNET_break (0);
       break;
-    case SP_CLEANUP:
+    case SP_SHUTDOWN_START:
       /* confirm copying complete */
       if (GNUNET_OK != GNUNET_OS_process_status (d->pid, &type, &code))
         {
@@ -270,10 +349,19 @@ start_fsm (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
           if (d->wait_runs > MAX_EXEC_WAIT_RUNS)
             {
               d->dead_cb (d->dead_cb_cls,
-                          _("`ssh' does not seem to terminate.\n"));
+                          _("either `gnunet-arm' or `ssh' does not seem to terminate.\n"));
+              if (d->th != NULL)
+                {
+                  GNUNET_TRANSPORT_get_hello_cancel(d->th, &process_hello, d);
+                  GNUNET_TRANSPORT_disconnect(d->th);
+                  d->th = NULL;
+                }
+              GNUNET_CONFIGURATION_destroy (d->cfg);
               GNUNET_free (d->cfgfile);
+              GNUNET_free_non_null(d->hello);
               GNUNET_free_non_null (d->hostname);
               GNUNET_free_non_null (d->username);
+              GNUNET_free_non_null (d->shortname);
               GNUNET_free (d);
               return;
             }
@@ -288,19 +376,38 @@ start_fsm (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
         {
           if (NULL != d->dead_cb)
             d->dead_cb (d->dead_cb_cls,
-                        _("`ssh' did not complete cleanly.\n"));
+                        _("shutdown (either `gnunet-arm' or `ssh') did not complete cleanly.\n"));
+          if (d->th != NULL)
+            {
+              GNUNET_TRANSPORT_get_hello_cancel(d->th, &process_hello, d);
+              GNUNET_TRANSPORT_disconnect(d->th);
+              d->th = NULL;
+            }
+          GNUNET_CONFIGURATION_destroy (d->cfg);
           GNUNET_free (d->cfgfile);
+          GNUNET_free_non_null(d->hello);
           GNUNET_free_non_null (d->hostname);
           GNUNET_free_non_null (d->username);
+          GNUNET_free_non_null (d->shortname);
           GNUNET_free (d);
           return;
         }
 #if DEBUG_TESTING
       GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Peer shutdown complete.\n");
 #endif
+      if (d->th != NULL)
+        {
+          GNUNET_TRANSPORT_get_hello_cancel(d->th, &process_hello, d);
+          GNUNET_TRANSPORT_disconnect(d->th);
+          d->th = NULL;
+        }
+      /* state clean up and notifications */
+      GNUNET_CONFIGURATION_destroy (d->cfg);
       GNUNET_free (d->cfgfile);
+      GNUNET_free_non_null(d->hello);
       GNUNET_free_non_null (d->hostname);
       GNUNET_free_non_null (d->username);
+      GNUNET_free_non_null (d->shortname);
       if (NULL != d->dead_cb)
         d->dead_cb (d->dead_cb_cls, NULL);
       GNUNET_free (d);
@@ -352,7 +459,7 @@ start_fsm (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
  * reachable via "ssh" (unless the hostname is "NULL") without the
  * need to enter a password.
  *
- * @param sched scheduler to use 
+ * @param sched scheduler to use
  * @param cfg configuration to use
  * @param hostname name of the machine where to run GNUnet
  *        (use NULL for localhost).
@@ -477,14 +584,14 @@ void
 GNUNET_TESTING_daemon_stop (struct GNUNET_TESTING_Daemon *d,
                             GNUNET_TESTING_NotifyCompletion cb, void *cb_cls)
 {
-  struct GNUNET_CLIENT_Connection *cc;
-  char *dst;
+  char *arg;
+
+  d->dead_cb = cb;
+  d->dead_cb_cls = cb_cls;
 
   if (NULL != d->cb)
     {
       d->dead = GNUNET_YES;
-      d->dead_cb = cb;
-      d->dead_cb_cls = cb_cls;
       return;
     }
   if (d->phase == SP_CONFIG_UPDATE)
@@ -497,62 +604,57 @@ GNUNET_TESTING_daemon_stop (struct GNUNET_TESTING_Daemon *d,
       GNUNET_CORE_disconnect (d->server);
       d->server = NULL;
     }
-  /* shutdown ARM process (will also terminate others) */
+  /* shutdown ARM process (will terminate others) */
 #if DEBUG_TESTING
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
               _("Terminating peer `%4s'\n"), GNUNET_i2s (&d->id));
+  /* sleep(15); Manual check for running */
 #endif
-  cc = GNUNET_CLIENT_connect (d->sched, "arm", d->cfg);
-  GNUNET_CLIENT_service_shutdown (cc);
 
-  /* state clean up and notifications */
-  if (0 != UNLINK (d->cfgfile))
-    GNUNET_log_strerror_file (GNUNET_ERROR_TYPE_WARNING,
-                              "unlink", d->cfgfile);
-  if (d->hostname != NULL)
+  d->phase = SP_SHUTDOWN_START;
+
+  /* Check if this is a local or remote process */
+  if (NULL != d->hostname)
     {
 #if DEBUG_TESTING
       GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                  "Removing configuration file on remote host `%s'.\n",
-                  d->hostname);
+                  "Stopping gnunet-arm with config `%s' on host `%s'.\n", d->cfgfile, d->hostname);
 #endif
-      if (NULL != d->username)
-        GNUNET_asprintf (&dst, "%s@%s", d->username, d->hostname);
+
+      if (d->username != NULL)
+        GNUNET_asprintf (&arg, "%s@%s", d->username, d->hostname);
       else
-        dst = GNUNET_strdup (d->hostname);
-      d->pid = GNUNET_OS_start_process (NULL, NULL, "ssh",
-                                        "ssh", dst, "rm", d->cfgfile, NULL);
-      GNUNET_free (dst);
-      if (-1 == d->pid)
-        {
-          GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
-                      _
-                      ("Could not start `%s' process to delete configuration file.\n"),
-                      "ssh");
-          GNUNET_free (d->cfgfile);
-          GNUNET_free_non_null (d->hostname);
-          GNUNET_free_non_null (d->username);
-          GNUNET_free (d);
-          cb (cb_cls, _("Error cleaning up configuration file.\n"));
-          return;
-        }
-      d->phase = SP_CLEANUP;
-      d->dead_cb = cb;
-      d->dead_cb_cls = cb_cls;
-      d->task
-        = GNUNET_SCHEDULER_add_delayed (d->sched,
-                                        GNUNET_CONSTANTS_EXEC_WAIT,
-                                        &start_fsm, d);
-      return;
+        arg = GNUNET_strdup (d->hostname);
+
+      d->pid = GNUNET_OS_start_process (NULL, NULL, "ssh", "ssh",
+                                              arg, "gnunet-arm",
+#if DEBUG_TESTING
+                                              "-L", "DEBUG",
+#endif
+                                              "-c", d->cfgfile, "-e", "-d", "-q", NULL);
+      /* Use -e to end arm, and -d to remove temp files */
+
+      GNUNET_free (arg);
     }
-  GNUNET_CONFIGURATION_destroy (d->cfg);
-  GNUNET_free (d->cfgfile);
-  GNUNET_free_non_null (d->hostname);
-  GNUNET_free_non_null (d->username);
-  GNUNET_free_non_null (d->shortname);
-  GNUNET_free (d);
-  if (NULL != cb)
-    cb (cb_cls, NULL);
+  else
+  {
+#if DEBUG_TESTING
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                  "Stopping gnunet-arm with config `%s' locally.\n", d->cfgfile);
+#endif
+    d->pid = GNUNET_OS_start_process (NULL, NULL, "gnunet-arm",
+                                            "gnunet-arm",
+#if DEBUG_TESTING
+                                            "-L", "DEBUG",
+#endif
+                                            "-c", d->cfgfile, "-e", "-d", "-q", NULL);
+  }
+
+  d->wait_runs = 0;
+  d->task
+    = GNUNET_SCHEDULER_add_delayed (d->sched,
+                                    GNUNET_CONSTANTS_EXEC_WAIT,
+                                    &start_fsm, d);
 }
 
 
@@ -650,16 +752,6 @@ struct ConnectContext
    */
   struct GNUNET_TESTING_Daemon *d2;
 
-  /**
-   * Handle to core of second daemon (to check connect)
-   */
-  struct GNUNET_CORE_Handle * d2core;
-
-  /**
-   * Transport handle to the first daemon.
-   */
-  struct GNUNET_TRANSPORT_Handle *d1th;
-
   /**
    * Transport handle to the second daemon.
    */
@@ -675,18 +767,24 @@ struct ConnectContext
    */
   void *cb_cls;
 
-  /**
-   * Transmit handle for our request for transmission
-   * (as given to d2 asking to talk to d1).
-   */
-  struct GNUNET_CORE_TransmitHandle *ntr;
-
   /**
    * When should this operation be complete (or we must trigger
    * a timeout).
    */
   struct GNUNET_TIME_Absolute timeout;
 
+  /**
+   * The relative timeout from whence this connect attempt was
+   * started.  Allows for reconnect attempts.
+   */
+  struct GNUNET_TIME_Relative relative_timeout;
+
+  /**
+   * Maximum number of connect attempts, will retry connection
+   * this number of times on failures.
+   */
+  unsigned int max_connect_attempts;
+
   /**
    * Hello timeout task
    */
@@ -703,48 +801,23 @@ struct ConnectContext
    */
   struct GNUNET_TIME_Relative timeout_hello;
 
-  /**
-   * The current hello message we have (for d1)
-   */
-  struct GNUNET_MessageHeader *hello;
 
   /**
-   * Was the connection successful?
+   * Was the connection attempt successful?
    */
   int connected;
 };
 
 
-/**
- * Receive the HELLO from one peer, give it to the other
- * and ask them to connect.
- *
- * @param cls "struct ConnectContext"
- * @param message HELLO message of peer
- */
+/** Forward declaration **/
 static void
-process_hello (void *cls, const struct GNUNET_MessageHeader *message)
-{
-  struct ConnectContext *ctx = cls;
-
-#if DEBUG_TESTING
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Received `%s' from transport service of `%4s'\n",
-              "HELLO", GNUNET_i2s (&ctx->d1->id));
-#endif
-
-  GNUNET_assert (message != NULL);
-  GNUNET_free_non_null(ctx->hello);
-  ctx->hello = GNUNET_malloc(ntohs(message->size));
-  memcpy(ctx->hello, message, ntohs(message->size));
-
-}
+reattempt_daemons_connect(void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc);
 
 
 /**
  * Notify callback about success or failure of the attempt
  * to connect the two peers
- * 
+ *
  * @param cls our "struct ConnectContext" (freed)
  * @param tc reason tells us if we succeeded or failed
  */
@@ -753,34 +826,73 @@ notify_connect_result (void *cls,
                        const struct GNUNET_SCHEDULER_TaskContext *tc)
 {
   struct ConnectContext *ctx = cls;
+  struct GNUNET_TIME_Relative remaining;
+
+  if (ctx->hello_send_task != GNUNET_SCHEDULER_NO_TASK)
+    {
+      GNUNET_SCHEDULER_cancel(ctx->d1->sched, ctx->hello_send_task);
+      ctx->hello_send_task = GNUNET_SCHEDULER_NO_TASK;
+    }
 
-  GNUNET_TRANSPORT_get_hello_cancel (ctx->d1th, &process_hello, ctx);
-  GNUNET_SCHEDULER_cancel(ctx->d1->sched, ctx->hello_send_task);
+  if ((ctx->timeout_task != GNUNET_SCHEDULER_NO_TASK) && (tc->reason != GNUNET_SCHEDULER_REASON_TIMEOUT))
+    {
+      GNUNET_SCHEDULER_cancel(ctx->d1->sched, ctx->timeout_task);
+      ctx->timeout_task = GNUNET_SCHEDULER_NO_TASK;
+    }
 
-  if (ctx->cb != NULL)
+  if (tc->reason == GNUNET_SCHEDULER_REASON_SHUTDOWN)
     {
-      if (ctx->connected == GNUNET_NO)
+      if (ctx->d2th != NULL)
+        GNUNET_TRANSPORT_disconnect (ctx->d2th);
+      ctx->d2th = NULL;
+      if (ctx->d1core != NULL)
+        GNUNET_CORE_disconnect (ctx->d1core);
+
+      ctx->d1core = NULL;
+      GNUNET_free (ctx);
+      return;
+    }
+
+  remaining = GNUNET_TIME_absolute_get_remaining(ctx->timeout);
+
+  if (ctx->connected == GNUNET_YES)
+    {
+      if (ctx->cb != NULL)
         {
           ctx->cb (ctx->cb_cls, &ctx->d1->id, &ctx->d2->id, ctx->d1->cfg,
-                  ctx->d2->cfg, ctx->d1, ctx->d2,
-                  _("Peers failed to connect"));
+                   ctx->d2->cfg, ctx->d1, ctx->d2, NULL);
         }
-      else
+    }
+  else if (remaining.value > 0)
+    {
+      if (ctx->d1core != NULL)
+        {
+          GNUNET_CORE_disconnect(ctx->d1core);
+          ctx->d1core = NULL;
+        }
+
+      if (ctx->d2th != NULL)
+        {
+          GNUNET_TRANSPORT_disconnect(ctx->d2th);
+          ctx->d2th = NULL;
+        }
+      GNUNET_SCHEDULER_add_now(ctx->d1->sched, &reattempt_daemons_connect, ctx);
+      return;
+    }
+  else
+    {
+      if (ctx->cb != NULL)
         {
           ctx->cb (ctx->cb_cls, &ctx->d1->id, &ctx->d2->id, ctx->d1->cfg,
-                   ctx->d2->cfg, ctx->d1, ctx->d2, NULL);
-          GNUNET_SCHEDULER_cancel(ctx->d1->sched, ctx->timeout_task);
+                   ctx->d2->cfg, ctx->d1, ctx->d2,
+                   _("Peers failed to connect"));
         }
     }
 
-  ctx->ntr = NULL;
-  GNUNET_TRANSPORT_disconnect (ctx->d1th);
-  ctx->d1th = NULL;
   GNUNET_TRANSPORT_disconnect (ctx->d2th);
   ctx->d2th = NULL;
   GNUNET_CORE_disconnect (ctx->d1core);
   ctx->d1core = NULL;
-  GNUNET_free_non_null (ctx->hello);
   GNUNET_free (ctx);
 }
 
@@ -800,21 +912,11 @@ connect_notify (void *cls, const struct GNUNET_PeerIdentity * peer, struct GNUNE
 {
   struct ConnectContext *ctx = cls;
 
-#if DEBUG_TESTING
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Core notified us about connection to a peer\n");
-#endif
   if (memcmp(&ctx->d2->id, peer, sizeof(struct GNUNET_PeerIdentity)) == 0)
     {
-#if DEBUG_TESTING
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Core notified us about connection to peer %s\n", GNUNET_i2s(peer));
-#endif
-      /*
-       * If we disconnect here, then the hello may never get sent (if it was delayed!)
-       * However I'm sure there was a reason it was here... so I'm just commenting.
-       */
       ctx->connected = GNUNET_YES;
+      GNUNET_SCHEDULER_cancel(ctx->d1->sched, ctx->timeout_task);
+      ctx->timeout_task = GNUNET_SCHEDULER_NO_TASK;
       GNUNET_SCHEDULER_add_now (ctx->d1->sched,
                                 &notify_connect_result,
                                 ctx);
@@ -827,19 +929,21 @@ send_hello(void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
 {
   struct ConnectContext *ctx = cls;
 
-  if (ctx->hello != NULL)
+  if (tc->reason == GNUNET_SCHEDULER_REASON_SHUTDOWN)
+    return;
+
+  if (ctx->d1->hello != NULL)
     {
-      GNUNET_TRANSPORT_offer_hello (ctx->d2th, ctx->hello);
+      GNUNET_TRANSPORT_offer_hello (ctx->d2th, GNUNET_HELLO_get_header(ctx->d1->hello));
       ctx->timeout_hello = GNUNET_TIME_relative_add(ctx->timeout_hello,
-                                                   GNUNET_TIME_relative_multiply(GNUNET_TIME_UNIT_MILLISECONDS, 
-                                                                                 200));
+                                                   GNUNET_TIME_relative_multiply(GNUNET_TIME_UNIT_MILLISECONDS,
+                                                                                 500));
     }
-  ctx->hello_send_task = GNUNET_SCHEDULER_add_delayed(ctx->d1->sched, 
-                                                     ctx->timeout_hello, 
+  ctx->hello_send_task = GNUNET_SCHEDULER_add_delayed(ctx->d1->sched,
+                                                     ctx->timeout_hello,
                                                      &send_hello, ctx);
 }
 
-
 /**
  * Establish a connection between two GNUnet daemons.
  *
@@ -847,6 +951,8 @@ send_hello(void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
  * @param d2 handle for the second daemon
  * @param timeout how long is the connection attempt
  *        allowed to take?
+ * @param max_connect_attempts how many times should we try to reconnect
+ *        (within timeout)
  * @param cb function to call at the end
  * @param cb_cls closure for cb
  */
@@ -854,13 +960,13 @@ void
 GNUNET_TESTING_daemons_connect (struct GNUNET_TESTING_Daemon *d1,
                                 struct GNUNET_TESTING_Daemon *d2,
                                 struct GNUNET_TIME_Relative timeout,
+                                unsigned int max_connect_attempts,
                                 GNUNET_TESTING_NotifyConnection cb,
                                 void *cb_cls)
 {
   struct ConnectContext *ctx;
-  static struct GNUNET_CORE_MessageHandler no_handlers[] = { {NULL, 0, 0} };
 
-  if ((d1->server == NULL) || (d2->server == NULL))
+  if ((d1->running == GNUNET_NO) || (d2->running == GNUNET_NO))
     {
       if (NULL != cb)
         cb (cb_cls, &d1->id, &d2->id, d1->cfg, d2->cfg, d1, d2,
@@ -871,16 +977,16 @@ GNUNET_TESTING_daemons_connect (struct GNUNET_TESTING_Daemon *d1,
   ctx->d1 = d1;
   ctx->d2 = d2;
   ctx->timeout = GNUNET_TIME_relative_to_absolute (timeout);
+  ctx->timeout_hello = GNUNET_TIME_relative_multiply(GNUNET_TIME_UNIT_MILLISECONDS, 500);
+  ctx->relative_timeout = timeout;
   ctx->cb = cb;
   ctx->cb_cls = cb_cls;
-  ctx->timeout_hello = GNUNET_TIME_relative_multiply(GNUNET_TIME_UNIT_MILLISECONDS, 400);
+  ctx->max_connect_attempts = max_connect_attempts;
   ctx->connected = GNUNET_NO;
 #if DEBUG_TESTING
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
               "Asked to connect peer %s to peer %s\n",
               d1->shortname, d2->shortname);
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Connecting to transport service of peer %s\n", d1->shortname);
 #endif
 
   ctx->d1core = GNUNET_CORE_connect (d1->sched,
@@ -888,7 +994,7 @@ GNUNET_TESTING_daemons_connect (struct GNUNET_TESTING_Daemon *d1,
                                      timeout,
                                      ctx,
                                      NULL,
-                                     NULL, &connect_notify, NULL,
+                                     &connect_notify, NULL,
                                      NULL, GNUNET_NO,
                                      NULL, GNUNET_NO, no_handlers);
   if (ctx->d1core == NULL)
@@ -900,17 +1006,7 @@ GNUNET_TESTING_daemons_connect (struct GNUNET_TESTING_Daemon *d1,
       return;
     }
 
-  ctx->d1th = GNUNET_TRANSPORT_connect (d1->sched,
-                                        d1->cfg, d1, NULL, NULL, NULL);
-  if (ctx->d1th == NULL)
-    {
-      GNUNET_free (ctx);
-      if (NULL != cb)
-        cb (cb_cls, &d1->id, &d2->id, d1->cfg, d2->cfg, d1, d2,
-            _("Failed to connect to transport service!\n"));
-      return;
-    }
-#if DEBUG_TESTING
+#if DEBUG_TESTING > 2
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
               "Asked to connect peer %s to peer %s\n",
               d1->shortname, d2->shortname);
@@ -923,7 +1019,7 @@ GNUNET_TESTING_daemons_connect (struct GNUNET_TESTING_Daemon *d1,
                                         d2->cfg, d2, NULL, NULL, NULL);
   if (ctx->d2th == NULL)
     {
-      GNUNET_TRANSPORT_disconnect (ctx->d1th);
+      GNUNET_CORE_disconnect(ctx->d1core);
       GNUNET_free (ctx);
       if (NULL != cb)
         cb (cb_cls, &d1->id, &d2->id, d1->cfg, d2->cfg, d1, d2,
@@ -931,19 +1027,63 @@ GNUNET_TESTING_daemons_connect (struct GNUNET_TESTING_Daemon *d1,
       return;
     }
 
-#if DEBUG_TESTING
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Asking for HELLO from peer %s\n", GNUNET_i2s (&d1->id));
-#endif
-
   ctx->timeout_task = GNUNET_SCHEDULER_add_delayed (d1->sched,
-                                                    timeout,
+                                                    GNUNET_TIME_relative_divide(ctx->relative_timeout, max_connect_attempts), /* Allow up to 8 reconnect attempts */
                                                     &notify_connect_result, ctx);
 
-  GNUNET_TRANSPORT_get_hello (ctx->d1th, &process_hello, ctx);
-  ctx->hello_send_task = GNUNET_SCHEDULER_add_delayed(ctx->d1->sched, ctx->timeout_hello,
-                                                     &send_hello, ctx);
+  ctx->hello_send_task = GNUNET_SCHEDULER_add_now(ctx->d1->sched, &send_hello, ctx);
 }
 
+static void
+reattempt_daemons_connect (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
+{
+
+  struct ConnectContext *ctx = cls;
+  if (tc->reason == GNUNET_SCHEDULER_REASON_SHUTDOWN)
+    {
+      return;
+    }
+#if DEBUG_TESTING_RECONNECT
+  GNUNET_log(GNUNET_ERROR_TYPE_DEBUG, "re-attempting connect of peer %s to peer %s\n",
+              ctx->d1->shortname, ctx->d2->shortname);
+#endif
+
+  GNUNET_assert(ctx->d1core == NULL);
+
+  ctx->d1core = GNUNET_CORE_connect (ctx->d1->sched,
+                                     ctx->d1->cfg,
+                                     GNUNET_TIME_absolute_get_remaining(ctx->timeout),
+                                     ctx,
+                                     NULL,
+                                     &connect_notify, NULL,
+                                     NULL, GNUNET_NO,
+                                     NULL, GNUNET_NO, no_handlers);
+  if (ctx->d1core == NULL)
+    {
+      if (NULL != ctx->cb)
+        ctx->cb (ctx->cb_cls, &ctx->d1->id, &ctx->d2->id, ctx->d1->cfg, ctx->d2->cfg, ctx->d1, ctx->d2,
+                 _("Failed to connect to core service of first peer!\n"));
+      GNUNET_free (ctx);
+      return;
+    }
+
+  ctx->d2th = GNUNET_TRANSPORT_connect (ctx->d2->sched,
+                                        ctx->d2->cfg, ctx->d2, NULL, NULL, NULL);
+  if (ctx->d2th == NULL)
+    {
+      GNUNET_CORE_disconnect(ctx->d1core);
+      GNUNET_free (ctx);
+      if (NULL != ctx->cb)
+        ctx->cb (ctx->cb_cls, &ctx->d1->id, &ctx->d2->id, ctx->d1->cfg, ctx->d2->cfg, ctx->d1, ctx->d2,
+            _("Failed to connect to transport service!\n"));
+      return;
+    }
+
+  ctx->timeout_task = GNUNET_SCHEDULER_add_delayed (ctx->d1->sched,
+                                                    GNUNET_TIME_relative_divide(ctx->relative_timeout, ctx->max_connect_attempts),
+                                                    &notify_connect_result, ctx);
+
+  ctx->hello_send_task = GNUNET_SCHEDULER_add_now(ctx->d1->sched, &send_hello, ctx);
+}
 
 /* end of testing.c */