- remove dead assignments

[oweals/gnunet.git] / src / testbed / testbed_api_peers.c

diff --git a/src/testbed/testbed_api_peers.c b/src/testbed/testbed_api_peers.c
index f54d737664690cd320f63153960d03d6c88f0997..b6de233311a3b21f6dc40246aee01736991b7360 100644 (file)
--- a/src/testbed/testbed_api_peers.c
+++ b/src/testbed/testbed_api_peers.c
@@ -97,7 +97,7 @@ static void
 opstart_peer_create (void *cls)
 {
   struct OperationContext *opc = cls;
-  struct PeerCreateData *data;
+  struct PeerCreateData *data = opc->data;
   struct GNUNET_TESTBED_PeerCreateMessage *msg;
   char *config;
   char *xconfig;
@@ -106,7 +106,7 @@ opstart_peer_create (void *cls)
   uint16_t msize;
 
   GNUNET_assert (OP_PEER_CREATE == opc->type);  
-  GNUNET_assert (NULL != (data = opc->data));
+  GNUNET_assert (NULL != data);
   GNUNET_assert (NULL != data->peer);
   opc->state = OPC_STATE_STARTED;
   config = GNUNET_CONFIGURATION_serialize (data->cfg, &c_size);
@@ -374,7 +374,8 @@ oprelease_peer_getinfo (void *cls)
     GNUNET_free (opc->data);
     break;
   case OPC_STATE_FINISHED:
-    GNUNET_assert (NULL != (data = opc->data));
+    data = opc->data;
+    GNUNET_assert (NULL != data);
     switch (data->pit)
     {
     case GNUNET_TESTBED_PIT_CONFIGURATION:
@@ -684,6 +685,7 @@ GNUNET_TESTBED_peer_stop (void *op_cls,
  * with event type GNUNET_TESTBED_ET_OPERATION_FINISHED when result for this
  * operation is available. Instead, the GNUNET_TESTBED_PeerInfoCallback() will
  * be called.
+ * The peer information in the callback is valid until the operation is canceled.
  *
  * @param peer peer to request information about
  * @param pit desired information
@@ -877,10 +879,10 @@ static void
 opstart_manage_service (void *cls)
 {
   struct OperationContext *opc = cls;
+  struct ManageServiceData *data = opc->data;
   struct GNUNET_TESTBED_ManagePeerServiceMessage *msg;
-  struct ManageServiceData *data;
   
-  GNUNET_assert (NULL != (data = opc->data));  
+  GNUNET_assert (NULL != data);  
   msg = GNUNET_malloc (data->msize);
   msg->header.size = htons (data->msize);
   msg->header.type = htons (GNUNET_MESSAGE_TYPE_TESTBED_MANAGE_PEER_SERVICE);