-only trigger check config if we actually need it
[oweals/gnunet.git] / src / statistics / gnunet-statistics.c
index 2b2b1c74556dff7bb6c5020c2c369465f396c801..192a450ac69a83263be7fbdec00accb1dc2f0699 100644 (file)
@@ -1,6 +1,6 @@
 /*
      This file is part of GNUnet.
-     (C) 2001, 2002, 2004, 2005, 2006, 2007, 2009 Christian Grothoff (and other contributing authors)
+     Copyright (C) 2001, 2002, 2004, 2005, 2006, 2007, 2009 GNUnet e.V.
 
      GNUnet is free software; you can redistribute it and/or modify
      it under the terms of the GNU General Public License as published
@@ -14,8 +14,8 @@
 
      You should have received a copy of the GNU General Public License
      along with GNUnet; see the file COPYING.  If not, write to the
-     Free Software Foundation, Inc., 59 Temple Place - Suite 330,
-     Boston, MA 02111-1307, USA.
+     Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+     Boston, MA 02110-1301, USA.
 */
 
 /**
  * @author Igor Wronsky
  */
 #include "platform.h"
-#include "gnunet_getopt_lib.h"
-#include "gnunet_program_lib.h"
 #include "gnunet_util_lib.h"
 #include "gnunet_statistics_service.h"
 #include "statistics.h"
 
-#define GET_TIMEOUT GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_SECONDS, 1)
 
 /**
  * Final status code.
@@ -71,7 +68,7 @@ static char *remote_host;
 /**
  * Remote host's port
  */
-static unsigned long long  remote_port;
+static unsigned long long remote_port;
 
 /**
  * Value to set
@@ -83,6 +80,12 @@ static unsigned long long set_val;
  */
 static int set_value;
 
+/**
+ * Handle for pending GET operation.
+ */
+static struct GNUNET_STATISTICS_GetHandle *gh;
+
+
 /**
  * Callback function to process statistic values.
  *
@@ -90,11 +93,14 @@ static int set_value;
  * @param subsystem name of subsystem that created the statistic
  * @param name the name of the datum
  * @param value the current value
- * @param is_persistent GNUNET_YES if the value is persistent, GNUNET_NO if not
- * @return GNUNET_OK to continue, GNUNET_SYSERR to abort iteration
+ * @param is_persistent #GNUNET_YES if the value is persistent, #GNUNET_NO if not
+ * @return #GNUNET_OK to continue, #GNUNET_SYSERR to abort iteration
  */
 static int
-printer (void *cls, const char *subsystem, const char *name, uint64_t value,
+printer (void *cls,
+         const char *subsystem,
+         const char *name,
+         uint64_t value,
          int is_persistent)
 {
   struct GNUNET_TIME_Absolute now = GNUNET_TIME_absolute_get();
@@ -128,20 +134,25 @@ printer (void *cls, const char *subsystem, const char *name, uint64_t value,
  * Function called last by the statistics code.
  *
  * @param cls closure
- * @param success GNUNET_OK if statistics were
- *        successfully obtained, GNUNET_SYSERR if not.
+ * @param success #GNUNET_OK if statistics were
+ *        successfully obtained, #GNUNET_SYSERR if not.
  */
 static void
-cleanup (void *cls, int success)
+cleanup (void *cls,
+         int success)
 {
-
-  if (success != GNUNET_OK)
+  gh = NULL;
+  if (GNUNET_OK != success)
   {
     if (NULL == remote_host)
-      FPRINTF (stderr, "%s", _("Failed to obtain statistics.\n"));
+      FPRINTF (stderr,
+               "%s",
+               _("Failed to obtain statistics.\n"));
     else
-      FPRINTF (stderr,  _("Failed to obtain statistics from host `%s:%llu'\n"),
-              remote_host, remote_port);
+      FPRINTF (stderr,
+               _("Failed to obtain statistics from host `%s:%llu'\n"),
+               remote_host,
+               remote_port);
     ret = 1;
   }
   GNUNET_SCHEDULER_shutdown ();
@@ -152,18 +163,30 @@ cleanup (void *cls, int success)
  * Function run on shutdown to clean up.
  *
  * @param cls the statistics handle
- * @param tc scheduler context
  */
 static void
-shutdown_task (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
+shutdown_task (void *cls)
 {
   struct GNUNET_STATISTICS_Handle *h = cls;
 
   if (NULL == h)
     return;
-  GNUNET_STATISTICS_watch_cancel (h, subsystem, name, &printer, h);
-  GNUNET_STATISTICS_destroy (h, GNUNET_NO);
-  h = NULL;  
+  if (NULL != gh)
+  {
+    GNUNET_STATISTICS_get_cancel (gh);
+    gh = NULL;
+  }
+  if ( (GNUNET_YES == watch) &&
+       (NULL != subsystem) &&
+       (NULL != name) )
+    GNUNET_assert (GNUNET_OK ==
+                  GNUNET_STATISTICS_watch_cancel (h,
+                                                   subsystem,
+                                                   name,
+                                                   &printer, h));
+  GNUNET_STATISTICS_destroy (h,
+                             GNUNET_NO);
+  h = NULL;
 }
 
 
@@ -171,23 +194,22 @@ shutdown_task (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
  * Main task that does the actual work.
  *
  * @param cls closure with our configuration
- * @param tc schedueler context
  */
 static void
-main_task (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
+main_task (void *cls)
 {
   const struct GNUNET_CONFIGURATION_Handle *cfg = cls;
   struct GNUNET_STATISTICS_Handle *h;
 
   if (set_value)
   {
-    if (subsystem == NULL)
+    if (NULL == subsystem)
     {
       FPRINTF (stderr, "%s", _("Missing argument: subsystem \n"));
       ret = 1;
       return;
     }
-    if (name == NULL)
+    if (NULL == name)
     {
       FPRINTF (stderr, "%s", _("Missing argument: name\n"));
       ret = 1;
@@ -199,12 +221,17 @@ main_task (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
       ret = 1;
       return;
     }
-    GNUNET_STATISTICS_set (h, name, (uint64_t) set_val, persistent);
-    GNUNET_STATISTICS_destroy (h, GNUNET_YES);
+    GNUNET_STATISTICS_set (h,
+                           name,
+                           (uint64_t) set_val,
+                           persistent);
+    GNUNET_STATISTICS_destroy (h,
+                               GNUNET_YES);
     h = NULL;
     return;
   }
-  if (NULL == (h = GNUNET_STATISTICS_create ("gnunet-statistics", cfg)))
+  if (NULL == (h = GNUNET_STATISTICS_create ("gnunet-statistics",
+                                             cfg)))
   {
     ret = 1;
     return;
@@ -212,9 +239,12 @@ main_task (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
   if (GNUNET_NO == watch)
   {
     if (NULL ==
-      GNUNET_STATISTICS_get (h, subsystem, name, GET_TIMEOUT, &cleanup,
-                             &printer, h))
-    cleanup (h, GNUNET_SYSERR);
+        (gh = GNUNET_STATISTICS_get (h,
+                                     subsystem,
+                                     name,
+                                     &cleanup,
+                                     &printer, h)) )
+      cleanup (h, GNUNET_SYSERR);
   }
   else
   {
@@ -226,16 +256,21 @@ main_task (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
       ret = 1;
       return;
     }
-    if (GNUNET_OK != GNUNET_STATISTICS_watch (h, subsystem, name, &printer, h))
+    if (GNUNET_OK !=
+        GNUNET_STATISTICS_watch (h,
+                                 subsystem,
+                                 name,
+                                 &printer, h))
     {
-      fprintf (stderr, _("Failed to initialize watch routine\n"));
-      GNUNET_SCHEDULER_add_now (&shutdown_task, h);
+      fprintf (stderr,
+               _("Failed to initialize watch routine\n"));
+      GNUNET_SCHEDULER_add_now (&shutdown_task,
+                                h);
       return;
     }
   }
-  GNUNET_SCHEDULER_add_delayed (GNUNET_TIME_UNIT_FOREVER_REL,
-                                &shutdown_task, h);
-
+  GNUNET_SCHEDULER_add_shutdown (&shutdown_task,
+                                 h);
 }
 
 
@@ -244,43 +279,56 @@ main_task (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
  * running.
  *
  * @param cls closure with our configuration
- * @param result GNUNET_YES if the resolver is running
- */ 
+ * @param result #GNUNET_YES if the resolver is running
+ */
 static void
-resolver_test_task (void *cls, 
+resolver_test_task (void *cls,
                    int result)
 {
   struct GNUNET_CONFIGURATION_Handle *cfg = cls;
 
   if (GNUNET_YES != result)
    {
-     FPRINTF (stderr, 
-             _("Trying to connect to remote host, but service `%s' is not running\n"), "resolver");
+     FPRINTF (stderr,
+             _("Trying to connect to remote host, but service `%s' is not running\n"),
+              "resolver");
      return;
    }
   /* connect to a remote host */
   if (0 == remote_port)
   {
-    if (GNUNET_SYSERR == GNUNET_CONFIGURATION_get_value_number (cfg, "statistics", "PORT", &remote_port))
+    if (GNUNET_SYSERR ==
+        GNUNET_CONFIGURATION_get_value_number (cfg, "statistics",
+                                               "PORT",
+                                               &remote_port))
     {
-      FPRINTF (stderr, _("A port is required to connect to host `%s'\n"), remote_host);
+      FPRINTF (stderr,
+               _("A port is required to connect to host `%s'\n"),
+               remote_host);
       return;
     }
   }
   else if (65535 <= remote_port)
   {
-    FPRINTF (stderr, 
-            _("A port has to be between 1 and 65535 to connect to host `%s'\n"), remote_host);
+    FPRINTF (stderr,
+            _("A port has to be between 1 and 65535 to connect to host `%s'\n"),
+             remote_host);
     return;
   }
 
   /* Manipulate configuration */
-  GNUNET_CONFIGURATION_set_value_string (cfg, 
-                                        "statistics", "UNIXPATH", "");
   GNUNET_CONFIGURATION_set_value_string (cfg,
-                                        "statistics", "HOSTNAME", remote_host);
+                                        "statistics",
+                                         "UNIXPATH",
+                                         "");
+  GNUNET_CONFIGURATION_set_value_string (cfg,
+                                        "statistics",
+                                         "HOSTNAME",
+                                         remote_host);
   GNUNET_CONFIGURATION_set_value_number (cfg,
-                                        "statistics", "PORT", remote_port);
+                                        "statistics",
+                                         "PORT",
+                                         remote_port);
   GNUNET_SCHEDULER_add_now (&main_task, cfg);
 }
 
@@ -294,7 +342,9 @@ resolver_test_task (void *cls,
  * @param cfg configuration
  */
 static void
-run (void *cls, char *const *args, const char *cfgfile,
+run (void *cls,
+     char *const *args,
+     const char *cfgfile,
      const struct GNUNET_CONFIGURATION_Handle *cfg)
 {
   set_value = GNUNET_NO;
@@ -309,7 +359,9 @@ run (void *cls, char *const *args, const char *cfgfile,
     set_value = GNUNET_YES;
   }
   if (NULL != remote_host)
-    GNUNET_CLIENT_service_test ("resolver", cfg, GNUNET_TIME_UNIT_SECONDS, 
+    GNUNET_CLIENT_service_test ("resolver",
+                                cfg,
+                                GNUNET_TIME_UNIT_SECONDS,
                                &resolver_test_task, (void *) cfg);
   else
     GNUNET_SCHEDULER_add_now (&main_task, (void *) cfg);
@@ -352,7 +404,8 @@ main (int argc, char *const *argv)
   };
   remote_port = 0;
   remote_host = NULL;
-  if (GNUNET_OK != GNUNET_STRINGS_get_utf8_args (argc, argv, &argc, &argv))
+  if (GNUNET_OK != GNUNET_STRINGS_get_utf8_args (argc, argv,
+                                                 &argc, &argv))
     return 2;
 
   ret = (GNUNET_OK ==