make it easy to start service by hand

[oweals/gnunet.git] / src / statistics / gnunet-statistics.c

diff --git a/src/statistics/gnunet-statistics.c b/src/statistics/gnunet-statistics.c
index dd9850418db3ba9a6ac77a3cc0178f75286d8667..159a7548dfaca6b504e060c3edc7373d24dd7e6a 100644 (file)
--- a/src/statistics/gnunet-statistics.c
+++ b/src/statistics/gnunet-statistics.c
@@ -30,7 +30,7 @@
 #include "gnunet_statistics_service.h"
 #include "statistics.h"
 
-#define GET_TIMEOUT GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_SECONDS, 15)
+#define GET_TIMEOUT GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_SECONDS, 1)
 
 /**
  * Final status code.
@@ -69,7 +69,7 @@ printer (void *cls,
         uint64_t value, int is_persistent)
 {
   FPRINTF (stdout,
-           "%s%-20s %-40s: %16llu\n",
+           "%s%-12s %-50s: %16llu\n",
            is_persistent ? "!" : " ", subsystem, _(name),
           (unsigned long long) value);
   return GNUNET_OK;
@@ -89,9 +89,14 @@ cleanup (void *cls, int success)
   struct GNUNET_STATISTICS_Handle *h = cls;
 
   if (success != GNUNET_OK)
-    ret = 1;
+    {
+      fprintf (stderr,
+              _("Failed to obtain statistics.\n"));
+      ret = 1;
+    }
   if (h != NULL)
-    GNUNET_STATISTICS_destroy (h);
+    GNUNET_STATISTICS_destroy (h,
+                              GNUNET_NO);
 }
 
 
@@ -130,7 +135,7 @@ run (void *cls,
           return;
         }
       GNUNET_STATISTICS_set (h, name, (uint64_t) val, persistent);
-      GNUNET_STATISTICS_destroy (h);
+      GNUNET_STATISTICS_destroy (h, GNUNET_YES);
       return;
     }
   h = GNUNET_STATISTICS_create (sched, "gnunet-statistics", cfg);
@@ -139,27 +144,11 @@ run (void *cls,
       ret = 1;
       return;
     }
-  GNUNET_STATISTICS_get (h,
-                         subsystem, name, GET_TIMEOUT, &cleanup, &printer, h);
+  if (NULL == GNUNET_STATISTICS_get (h,
+                                    subsystem, name, GET_TIMEOUT, &cleanup, &printer, h))
+    cleanup (h, GNUNET_SYSERR);
 }
 
-/**
- * gnunet-statistics command line options
- */
-static struct GNUNET_GETOPT_CommandLineOption options[] = {
-  {'n', "name", "NAME",
-   gettext_noop ("limit output to statistcs for the given NAME"), 1,
-   &GNUNET_GETOPT_set_string, &name},
-  {'p', "persistent", NULL,
-   gettext_noop ("make the value being set persistent"), 0,
-   &GNUNET_GETOPT_set_one, &persistent},
-  {'s', "subsystem", "SUBSYSTEM",
-   gettext_noop ("limit output to the given SUBSYSTEM"), 1,
-   &GNUNET_GETOPT_set_string, &subsystem},
-  GNUNET_GETOPT_OPTION_END
-};
-
-
 /**
  * The main function to obtain statistics in GNUnet.
  *
@@ -170,10 +159,22 @@ static struct GNUNET_GETOPT_CommandLineOption options[] = {
 int
 main (int argc, char *const *argv)
 {
+  static const struct GNUNET_GETOPT_CommandLineOption options[] = {
+    {'n', "name", "NAME",
+     gettext_noop ("limit output to statistcs for the given NAME"), 1,
+     &GNUNET_GETOPT_set_string, &name},
+    {'p', "persistent", NULL,
+     gettext_noop ("make the value being set persistent"), 0,
+     &GNUNET_GETOPT_set_one, &persistent},
+    {'s', "subsystem", "SUBSYSTEM",
+     gettext_noop ("limit output to the given SUBSYSTEM"), 1,
+     &GNUNET_GETOPT_set_string, &subsystem},
+    GNUNET_GETOPT_OPTION_END
+  };
   return (GNUNET_OK ==
           GNUNET_PROGRAM_run (argc,
                               argv,
-                              "gnunet-statistics",
+                              "gnunet-statistics [options [value]]",
                               gettext_noop
                               ("Print statistics about GNUnet operations."),
                               options, &run, NULL)) ? ret : 1;