social: crashing free() removed.. was it redundant?
[oweals/gnunet.git] / src / social / social_api.c
index 3404160a937df20dbc6609044e148b7a20ef3bde..f7b536bcfb387a49a2e2f44919ade24a2241d57c 100644 (file)
@@ -1,6 +1,6 @@
 /*
  * This file is part of GNUnet
- * Copyright (C) 2013 Christian Grothoff (and other contributing authors)
+ * Copyright (C) 2013 GNUnet e.V.
  *
  * GNUnet is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published
@@ -102,13 +102,8 @@ struct GNUNET_SOCIAL_App
   GNUNET_SOCIAL_AppEgoCallback ego_cb;
   GNUNET_SOCIAL_AppHostPlaceCallback host_cb;
   GNUNET_SOCIAL_AppGuestPlaceCallback guest_cb;
+  GNUNET_SOCIAL_AppConnectedCallback connected_cb;
   void *cb_cls;
-
-  /**
-   * Is this place in the process of disconnecting from the service?
-   * #GNUNET_YES or #GNUNET_NO
-   */
-  uint8_t is_disconnecting;
 };
 
 
@@ -149,12 +144,7 @@ struct GNUNET_SOCIAL_Place
   struct GNUNET_PSYC_TransmitHandle *tmit;
 
   /**
-   * Receipt handle.
-   */
-  struct GNUNET_PSYC_ReceiveHandle *recv;
-
-  /**
-   * Slicer for processing incoming methods.
+   * Slicer for processing incoming messages.
    */
   struct GNUNET_PSYC_Slicer *slicer;
 
@@ -187,12 +177,6 @@ struct GNUNET_SOCIAL_Place
    * Does this place belong to a host (#GNUNET_YES) or guest (#GNUNET_NO)?
    */
   uint8_t is_host;
-
-  /**
-   * Is this place in the process of disconnecting from the service?
-   * #GNUNET_YES or #GNUNET_NO
-   */
-  uint8_t is_disconnecting;
 };
 
 
@@ -204,12 +188,7 @@ struct GNUNET_SOCIAL_Host
   struct GNUNET_SOCIAL_Place plc;
 
   /**
-   * Receipt handle.
-   */
-  struct GNUNET_PSYC_ReceiveHandle *recv;
-
-  /**
-   * Slicer for processing incoming methods.
+   * Slicer for processing incoming messages from guests.
    */
   struct GNUNET_PSYC_Slicer *slicer;
 
@@ -236,16 +215,6 @@ struct GNUNET_SOCIAL_Guest
 {
   struct GNUNET_SOCIAL_Place plc;
 
-  /**
-   * Receipt handle.
-   */
-  struct GNUNET_PSYC_ReceiveHandle *recv;
-
-  /**
-   * Slicer for processing incoming methods.
-   */
-  struct GNUNET_PSYC_Slicer *slicer;
-
   GNUNET_SOCIAL_GuestEnterCallback enter_cb;
 
   GNUNET_SOCIAL_EntryDecisionCallback entry_dcsn_cb;
@@ -298,9 +267,9 @@ struct GNUNET_SOCIAL_HistoryRequest
   uint64_t op_id;
 
   /**
-   * Message handler.
+   * Slicer for processing incoming messages.
    */
-  struct GNUNET_PSYC_ReceiveHandle *recv;
+  struct GNUNET_PSYC_Slicer *slicer;
 
   /**
    * Function to call when the operation finished.
@@ -418,19 +387,18 @@ nym_destroy (struct GNUNET_SOCIAL_Nym *nym)
 
 static void
 host_recv_notice_place_leave_method (void *cls,
+                                     const struct GNUNET_PSYC_MessageHeader *msg,
                                      const struct GNUNET_PSYC_MessageMethod *meth,
                                      uint64_t message_id,
-                                     uint32_t flags,
-                                     const struct GNUNET_CRYPTO_EcdsaPublicKey *nym_pub_key,
                                      const char *method_name)
 {
   struct GNUNET_SOCIAL_Host *hst = cls;
 
   if (0 == memcmp (&(struct GNUNET_CRYPTO_EcdsaPublicKey) {},
-                   nym_pub_key, sizeof (*nym_pub_key)))
+                   &msg->slave_pub_key, sizeof (msg->slave_pub_key)))
     return;
 
-  struct GNUNET_SOCIAL_Nym *nym = nym_get_or_create (nym_pub_key);
+  struct GNUNET_SOCIAL_Nym *nym = nym_get_or_create (&msg->slave_pub_key);
 
   GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
               "Host received method for message ID %" PRIu64 " from nym %s: %s\n",
@@ -443,12 +411,14 @@ host_recv_notice_place_leave_method (void *cls,
   GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
               "_notice_place_leave: got method from nym %s (%s).\n",
               GNUNET_h2s (&hst->notice_place_leave_nym->pub_key_hash), str);
+  GNUNET_free (str);
 }
 
 
 static void
 host_recv_notice_place_leave_modifier (void *cls,
-                                       const struct GNUNET_MessageHeader *msg,
+                                       const struct GNUNET_PSYC_MessageHeader *msg,
+                                       const struct GNUNET_MessageHeader *pmsg,
                                        uint64_t message_id,
                                        enum GNUNET_PSYC_Operator oper,
                                        const char *name,
@@ -463,7 +433,7 @@ host_recv_notice_place_leave_modifier (void *cls,
   GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
               "Host received modifier for _notice_place_leave message with ID %" PRIu64 ":\n"
               "%c%s: %.*s\n",
-              message_id, oper, name, value_size, value);
+              message_id, oper, name, value_size, (const char *) value);
 
   /* skip _nym, it's added later in eom() */
   if (0 == memcmp (name, "_nym", sizeof ("_nym"))
@@ -477,9 +447,10 @@ host_recv_notice_place_leave_modifier (void *cls,
 
 static void
 host_recv_notice_place_leave_eom (void *cls,
-                                  const struct GNUNET_MessageHeader *msg,
+                                  const struct GNUNET_PSYC_MessageHeader *msg,
+                                  const struct GNUNET_MessageHeader *pmsg,
                                   uint64_t message_id,
-                                  uint8_t cancelled)
+                                  uint8_t is_cancelled)
 {
   struct GNUNET_SOCIAL_Host *hst = cls;
   if (NULL == hst->notice_place_leave_env)
@@ -489,8 +460,9 @@ host_recv_notice_place_leave_eom (void *cls,
   GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
               "_notice_place_leave: got EOM from nym %s (%s).\n",
               GNUNET_h2s (&hst->notice_place_leave_nym->pub_key_hash), str);
+  GNUNET_free (str);
 
-  if (GNUNET_YES != cancelled)
+  if (GNUNET_YES != is_cancelled)
   {
     if (NULL != hst->farewell_cb)
       hst->farewell_cb (hst->cb_cls, hst->notice_place_leave_nym,
@@ -517,8 +489,9 @@ app_send_connect_msg (struct GNUNET_SOCIAL_App *app)
 {
   uint16_t cmsg_size = ntohs (app->connect_msg->size);
   struct GNUNET_MessageHeader * cmsg = GNUNET_malloc (cmsg_size);
-  memcpy (cmsg, app->connect_msg, cmsg_size);
+  GNUNET_memcpy (cmsg, app->connect_msg, cmsg_size);
   GNUNET_CLIENT_MANAGER_transmit_now (app->client, cmsg);
+  GNUNET_free (cmsg);
 }
 
 
@@ -543,8 +516,9 @@ place_send_connect_msg (struct GNUNET_SOCIAL_Place *plc)
 {
   uint16_t cmsg_size = ntohs (plc->connect_msg->size);
   struct GNUNET_MessageHeader * cmsg = GNUNET_malloc (cmsg_size);
-  memcpy (cmsg, plc->connect_msg, cmsg_size);
+  GNUNET_memcpy (cmsg, plc->connect_msg, cmsg_size);
   GNUNET_CLIENT_MANAGER_transmit_now (plc->client, cmsg);
+  GNUNET_free (cmsg);
 }
 
 
@@ -625,7 +599,6 @@ op_recv_history_result (void *cls, int64_t result,
   if (NULL != hist->result_cb)
     hist->result_cb (hist->cls, result, err_msg, err_msg_size);
 
-  GNUNET_PSYC_receive_destroy (hist->recv);
   GNUNET_free (hist);
 }
 
@@ -684,8 +657,8 @@ place_recv_history_result (void *cls,
     return;
   }
 
-  GNUNET_PSYC_receive_message (hist->recv,
-                               (const struct GNUNET_PSYC_MessageHeader *) pmsg);
+  GNUNET_PSYC_slicer_message (hist->slicer,
+                              (const struct GNUNET_PSYC_MessageHeader *) pmsg);
 }
 
 
@@ -745,7 +718,7 @@ place_recv_state_result (void *cls,
     {
         look->mod_value_remaining = look->mod_value_size;
         look->mod_name = GNUNET_malloc (name_size);
-        memcpy (look->mod_name, name, name_size);
+        GNUNET_memcpy (look->mod_name, name, name_size);
     }
     break;
   }
@@ -781,7 +754,7 @@ place_recv_message (void *cls,
 {
   struct GNUNET_SOCIAL_Place *
     plc = GNUNET_CLIENT_MANAGER_get_user_context_ (client, sizeof (*plc));
-  GNUNET_PSYC_receive_message (plc->recv,
+  GNUNET_PSYC_slicer_message (plc->slicer,
                                (const struct GNUNET_PSYC_MessageHeader *) msg);
 }
 
@@ -793,10 +766,10 @@ host_recv_message (void *cls,
 {
   struct GNUNET_SOCIAL_Host *
     hst = GNUNET_CLIENT_MANAGER_get_user_context_ (client, sizeof (hst->plc));
-  GNUNET_PSYC_receive_message (hst->recv,
-                               (const struct GNUNET_PSYC_MessageHeader *) msg);
-  GNUNET_PSYC_receive_message (hst->plc.recv,
-                               (const struct GNUNET_PSYC_MessageHeader *) msg);
+  GNUNET_PSYC_slicer_message (hst->slicer,
+                              (const struct GNUNET_PSYC_MessageHeader *) msg);
+  GNUNET_PSYC_slicer_message (hst->plc.slicer,
+                              (const struct GNUNET_PSYC_MessageHeader *) msg);
 }
 
 
@@ -855,7 +828,7 @@ host_recv_enter_request (void *cls,
                                                   &data, &data_size))
       {
         GNUNET_break_op (0);
-        str = GNUNET_CRYPTO_ecdsa_public_key_to_string (&req->slave_key);
+        str = GNUNET_CRYPTO_ecdsa_public_key_to_string (&req->slave_pub_key);
         LOG (GNUNET_ERROR_TYPE_WARNING,
              "Ignoring invalid entry request from nym %s.\n",
              str);
@@ -864,9 +837,9 @@ host_recv_enter_request (void *cls,
       }
     }
 
-    struct GNUNET_SOCIAL_Nym *nym = nym_get_or_create (&req->slave_key);
+    struct GNUNET_SOCIAL_Nym *nym = nym_get_or_create (&req->slave_pub_key);
     hst->answer_door_cb (hst->cb_cls, nym, method_name, env,
-                         data_size, data);
+                         data, data_size);
   } while (0);
 
   if (NULL != env)
@@ -889,7 +862,8 @@ guest_recv_enter_ack (void *cls,
     cres = (struct GNUNET_PSYC_CountersResultMessage *) msg;
   int32_t result = ntohl (cres->result_code);
   if (NULL != gst->enter_cb)
-    gst->enter_cb (gst->cb_cls, result, GNUNET_ntohll (cres->max_message_id));
+    gst->enter_cb (gst->cb_cls, result, &gst->plc.pub_key,
+                   GNUNET_ntohll (cres->max_message_id));
 }
 
 
@@ -937,12 +911,12 @@ app_recv_ego (void *cls,
     ego = GNUNET_malloc (sizeof (*ego));
     ego->pub_key = emsg->ego_pub_key;
     ego->name = GNUNET_malloc (name_size);
-    memcpy (ego->name, &emsg[1], name_size);
+    GNUNET_memcpy (ego->name, &emsg[1], name_size);
   }
   else
   {
     ego->name = GNUNET_realloc (ego->name, name_size);
-    memcpy (ego->name, &emsg[1], name_size);
+    GNUNET_memcpy (ego->name, &emsg[1], name_size);
   }
 
   GNUNET_CONTAINER_multihashmap_put (app->egos, &ego_pub_hash, ego,
@@ -953,6 +927,16 @@ app_recv_ego (void *cls,
 }
 
 
+static void
+app_recv_ego_end (void *cls,
+                  struct GNUNET_CLIENT_MANAGER_Connection *client,
+                  const struct GNUNET_MessageHeader *msg)
+{
+  struct GNUNET_SOCIAL_App *
+    app = GNUNET_CLIENT_MANAGER_get_user_context_ (client, sizeof (*app));
+}
+
+
 static void
 app_recv_place (void *cls,
                 struct GNUNET_CLIENT_MANAGER_Connection *client,
@@ -975,27 +959,46 @@ app_recv_place (void *cls,
     ego = GNUNET_CONTAINER_multihashmap_get (app->egos, &ego_pub_hash);
   if (NULL == ego)
   {
+    GNUNET_log (GNUNET_ERROR_TYPE_ERROR, "Failure to obtain ego %s.\n",
+               GNUNET_h2s (&ego_pub_hash));
     GNUNET_break (0);
     return;
   }
 
   if (GNUNET_YES == pmsg->is_host)
   {
-    struct GNUNET_SOCIAL_HostConnection *hconn = GNUNET_malloc (sizeof (*hconn));
-    hconn->app = app;
-    hconn->plc_msg = *pmsg;
-    app->host_cb (app->cb_cls, hconn, ego, &pmsg->place_pub_key, pmsg->place_state);
+    if (NULL != app->host_cb) {
+      struct GNUNET_SOCIAL_HostConnection *hconn = GNUNET_malloc (sizeof (*hconn));
+      hconn->app = app;
+      hconn->plc_msg = *pmsg;
+      app->host_cb (app->cb_cls, hconn, ego, &pmsg->place_pub_key, pmsg->place_state);
+      // FIXME: should this have a GNUNET_free (hconn) here?
+    }
   }
-  else
+  else if (NULL != app->guest_cb)
   {
     struct GNUNET_SOCIAL_GuestConnection *gconn = GNUNET_malloc (sizeof (*gconn));
     gconn->app = app;
     gconn->plc_msg = *pmsg;
     app->guest_cb (app->cb_cls, gconn, ego, &pmsg->place_pub_key, pmsg->place_state);
+    // GNUNET_free (gconn); // FIXME: is this correct here? apparently not!
   }
 }
 
 
+static void
+app_recv_place_end (void *cls,
+                  struct GNUNET_CLIENT_MANAGER_Connection *client,
+                  const struct GNUNET_MessageHeader *msg)
+{
+  struct GNUNET_SOCIAL_App *
+    app = GNUNET_CLIENT_MANAGER_get_user_context_ (client, sizeof (*app));
+
+  if (NULL != app->connected_cb)
+    app->connected_cb (app->cb_cls);
+}
+
+
 static struct GNUNET_CLIENT_MANAGER_MessageHandler host_handlers[] =
 {
   { host_recv_enter_ack, NULL,
@@ -1072,17 +1075,24 @@ static struct GNUNET_CLIENT_MANAGER_MessageHandler guest_handlers[] =
 };
 
 
-
 static struct GNUNET_CLIENT_MANAGER_MessageHandler app_handlers[] =
 {
   { app_recv_ego, NULL,
     GNUNET_MESSAGE_TYPE_SOCIAL_APP_EGO,
     sizeof (struct AppEgoMessage), GNUNET_YES },
 
+  { app_recv_ego_end, NULL,
+    GNUNET_MESSAGE_TYPE_SOCIAL_APP_EGO_END,
+    sizeof (struct GNUNET_MessageHeader), GNUNET_NO },
+
   { app_recv_place, NULL,
     GNUNET_MESSAGE_TYPE_SOCIAL_APP_PLACE,
     sizeof (struct AppPlaceMessage), GNUNET_NO },
 
+  { app_recv_place_end, NULL,
+    GNUNET_MESSAGE_TYPE_SOCIAL_APP_PLACE_END,
+    sizeof (struct GNUNET_MessageHeader), GNUNET_NO },
+
   { app_recv_result, NULL,
     GNUNET_MESSAGE_TYPE_PSYC_RESULT_CODE,
     sizeof (struct GNUNET_OperationResultMessage), GNUNET_YES },
@@ -1096,10 +1106,15 @@ static struct GNUNET_CLIENT_MANAGER_MessageHandler app_handlers[] =
 static void
 place_cleanup (struct GNUNET_SOCIAL_Place *plc)
 {
+  struct GNUNET_HashCode place_pub_hash;
+  GNUNET_CRYPTO_hash (&plc->pub_key, sizeof (plc->pub_key), &place_pub_hash);
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+              "%s place cleanup: %s\n",
+              GNUNET_YES == plc->is_host ? "host" : "guest",
+              GNUNET_h2s (&place_pub_hash));
+
   if (NULL != plc->tmit)
     GNUNET_PSYC_transmit_destroy (plc->tmit);
-  if (NULL != plc->recv)
-    GNUNET_PSYC_receive_destroy (plc->recv);
   if (NULL != plc->connect_msg)
     GNUNET_free (plc->connect_msg);
   if (NULL != plc->disconnect_cb)
@@ -1112,11 +1127,6 @@ host_cleanup (void *cls)
 {
   struct GNUNET_SOCIAL_Host *hst = cls;
   place_cleanup (&hst->plc);
-  if (NULL != hst->recv)
-  {
-    GNUNET_PSYC_receive_destroy (hst->recv);
-    hst->recv = NULL;
-  }
   if (NULL != hst->slicer)
   {
     GNUNET_PSYC_slicer_destroy (hst->slicer);
@@ -1147,9 +1157,6 @@ guest_cleanup (void *cls)
  *        Application handle.
  * @param ego
  *        Identity of the host.
- * @param place_key
- *        Private-public key pair of the place.
- *        NULL to generate a key.
  * @param policy
  *        Policy specifying entry and history restrictions for the place.
  * @param slicer
@@ -1163,7 +1170,7 @@ guest_cleanup (void *cls)
  * @param cls
  *        Closure for the callbacks.
  *
- * @return Handle for the host.
+ * @return Handle for the host. This handle contains the pubkey.
  */
 struct GNUNET_SOCIAL_Host *
 GNUNET_SOCIAL_host_enter (const struct GNUNET_SOCIAL_App *app,
@@ -1191,14 +1198,12 @@ GNUNET_SOCIAL_host_enter (const struct GNUNET_SOCIAL_App *app,
   GNUNET_CLIENT_MANAGER_set_user_context_ (plc->client, hst, sizeof (*plc));
 
   plc->tmit = GNUNET_PSYC_transmit_create (plc->client);
-  plc->recv = GNUNET_PSYC_receive_create (NULL, GNUNET_PSYC_slicer_message, plc->slicer);
 
   hst->slicer = GNUNET_PSYC_slicer_create ();
-  GNUNET_PSYC_slicer_method_add (hst->slicer, "_notice_place_leave",
+  GNUNET_PSYC_slicer_method_add (hst->slicer, "_notice_place_leave", NULL,
                                  host_recv_notice_place_leave_method,
                                  host_recv_notice_place_leave_modifier,
                                  NULL, host_recv_notice_place_leave_eom, hst);
-  hst->recv = GNUNET_PSYC_receive_create (NULL, GNUNET_PSYC_slicer_message, hst->slicer);
 
   uint16_t app_id_size = strlen (app->id) + 1;
   struct HostEnterRequest *hreq = GNUNET_malloc (sizeof (*hreq) + app_id_size);
@@ -1206,7 +1211,7 @@ GNUNET_SOCIAL_host_enter (const struct GNUNET_SOCIAL_App *app,
   hreq->header.type = htons (GNUNET_MESSAGE_TYPE_SOCIAL_HOST_ENTER);
   hreq->policy = policy;
   hreq->ego_pub_key = ego->pub_key;
-  memcpy (&hreq[1], app->id, app_id_size);
+  GNUNET_memcpy (&hreq[1], app->id, app_id_size);
 
   plc->connect_msg = &hreq->header;
   place_send_connect_msg (plc);
@@ -1263,20 +1268,18 @@ GNUNET_SOCIAL_host_enter_reconnect (struct GNUNET_SOCIAL_HostConnection *hconn,
   GNUNET_CLIENT_MANAGER_set_user_context_ (plc->client, hst, sizeof (*plc));
 
   plc->tmit = GNUNET_PSYC_transmit_create (plc->client);
-  plc->recv = GNUNET_PSYC_receive_create (NULL, GNUNET_PSYC_slicer_message, plc->slicer);
 
   hst->slicer = GNUNET_PSYC_slicer_create ();
-  GNUNET_PSYC_slicer_method_add (hst->slicer, "_notice_place_leave",
+  GNUNET_PSYC_slicer_method_add (hst->slicer, "_notice_place_leave", NULL,
                                  host_recv_notice_place_leave_method,
                                  host_recv_notice_place_leave_modifier,
                                  NULL, host_recv_notice_place_leave_eom, hst);
-  hst->recv = GNUNET_PSYC_receive_create (NULL, GNUNET_PSYC_slicer_message, hst->slicer);
 
   hreq->header.size = htons (sizeof (*hreq) + app_id_size);
   hreq->header.type = htons (GNUNET_MESSAGE_TYPE_SOCIAL_HOST_ENTER);
   hreq->place_pub_key = hconn->plc_msg.place_pub_key;
   hreq->ego_pub_key = hconn->plc_msg.ego_pub_key;
-  memcpy (&hreq[1], hconn->app->id, app_id_size);
+  GNUNET_memcpy (&hreq[1], hconn->app->id, app_id_size);
 
   plc->connect_msg = &hreq->header;
   place_send_connect_msg (plc);
@@ -1325,12 +1328,13 @@ GNUNET_SOCIAL_host_entry_decision (struct GNUNET_SOCIAL_Host *hst,
   dcsn->header.size = htons (sizeof (*dcsn) + entry_resp_size);
   dcsn->header.type = htons (GNUNET_MESSAGE_TYPE_PSYC_JOIN_DECISION);
   dcsn->is_admitted = htonl (is_admitted);
-  dcsn->slave_key = nym->pub_key;
+  dcsn->slave_pub_key = nym->pub_key;
 
   if (0 < entry_resp_size)
-    memcpy (&dcsn[1], entry_resp, entry_resp_size);
+    GNUNET_memcpy (&dcsn[1], entry_resp, entry_resp_size);
 
   GNUNET_CLIENT_MANAGER_transmit (hst->plc.client, &dcsn->header);
+  GNUNET_free (dcsn);
   return GNUNET_OK;
 }
 
@@ -1352,14 +1356,17 @@ GNUNET_SOCIAL_host_entry_decision (struct GNUNET_SOCIAL_Host *hst,
 void
 GNUNET_SOCIAL_host_eject (struct GNUNET_SOCIAL_Host *hst,
                           const struct GNUNET_SOCIAL_Nym *nym,
-                          struct GNUNET_PSYC_Environment *env)
+                          struct GNUNET_PSYC_Environment *e)
 {
+  struct GNUNET_PSYC_Environment *env = e;
   if (NULL == env)
     env = GNUNET_PSYC_env_create ();
   GNUNET_PSYC_env_add (env, GNUNET_PSYC_OP_SET,
                        "_nym", &nym->pub_key, sizeof (nym->pub_key));
   GNUNET_SOCIAL_host_announce (hst, "_notice_place_leave", env, NULL, NULL,
                                GNUNET_SOCIAL_ANNOUNCE_NONE);
+  if (NULL == e)
+    GNUNET_PSYC_env_destroy (env);
 }
 
 
@@ -1515,7 +1522,6 @@ GNUNET_SOCIAL_host_get_place (struct GNUNET_SOCIAL_Host *hst)
 }
 
 
-
 void
 place_leave (struct GNUNET_SOCIAL_Place *plc)
 {
@@ -1531,7 +1537,6 @@ place_disconnect (struct GNUNET_SOCIAL_Place *plc,
                   GNUNET_ContinuationCallback disconnect_cb,
                   void *disconnect_cls)
 {
-  plc->is_disconnecting = GNUNET_YES;
   plc->disconnect_cb = disconnect_cb;
   plc->disconnect_cls = disconnect_cls;
 
@@ -1562,7 +1567,7 @@ GNUNET_SOCIAL_host_disconnect (struct GNUNET_SOCIAL_Host *hst,
 /**
  * Stop hosting the home.
  *
- * Sends a _notice_place_closed announcement to the home.
+ * Sends a _notice_place_closing announcement to the home.
  * Invalidates host handle.
  *
  * @param hst
@@ -1582,7 +1587,7 @@ GNUNET_SOCIAL_host_leave (struct GNUNET_SOCIAL_Host *hst,
                           GNUNET_ContinuationCallback disconnect_cb,
                           void *cls)
 {
-  GNUNET_SOCIAL_host_announce (hst, "_notice_place_closed", env, NULL, NULL,
+  GNUNET_SOCIAL_host_announce (hst, "_notice_place_closing", env, NULL, NULL,
                                GNUNET_SOCIAL_ANNOUNCE_NONE);
   place_leave (&hst->plc);
   GNUNET_SOCIAL_host_disconnect (hst, disconnect_cb, cls);
@@ -1615,16 +1620,16 @@ guest_enter_request_create (const char *app_id,
   greq->relay_count = htonl (relay_count);
 
   char *p = (char *) &greq[1];
-  memcpy (p, app_id, app_id_size);
+  GNUNET_memcpy (p, app_id, app_id_size);
   p += app_id_size;
 
   if (0 < relay_size)
   {
-    memcpy (p, relays, relay_size);
+    GNUNET_memcpy (p, relays, relay_size);
     p += relay_size;
   }
 
-  memcpy (p, join_msg, join_msg_size);
+  GNUNET_memcpy (p, join_msg, join_msg_size);
   return greq;
 }
 
@@ -1679,7 +1684,7 @@ GNUNET_SOCIAL_guest_enter (const struct GNUNET_SOCIAL_App *app,
   plc->ego_pub_key = ego->pub_key;
   plc->pub_key = *place_pub_key;
   plc->cfg = app->cfg;
-  plc->is_host = GNUNET_YES;
+  plc->is_host = GNUNET_NO;
   plc->slicer = slicer;
 
   gst->enter_cb = local_enter_cb;
@@ -1690,7 +1695,6 @@ GNUNET_SOCIAL_guest_enter (const struct GNUNET_SOCIAL_App *app,
   GNUNET_CLIENT_MANAGER_set_user_context_ (plc->client, gst, sizeof (*plc));
 
   plc->tmit = GNUNET_PSYC_transmit_create (plc->client);
-  plc->recv = GNUNET_PSYC_receive_create (NULL, GNUNET_PSYC_slicer_message, plc->slicer);
 
   struct GuestEnterRequest *
     greq = guest_enter_request_create (app->id, &ego->pub_key, &plc->pub_key,
@@ -1749,7 +1753,7 @@ GNUNET_SOCIAL_guest_enter_by_name (const struct GNUNET_SOCIAL_App *app,
   uint16_t password_size = strlen (password) + 1;
 
   uint16_t join_msg_size = 0;
-  if (NULL != join_msg);
+  if (NULL != join_msg)
     join_msg_size = ntohs (join_msg->header.size);
 
   uint16_t greq_size = sizeof (struct GuestEnterByNameRequest)
@@ -1760,14 +1764,14 @@ GNUNET_SOCIAL_guest_enter_by_name (const struct GNUNET_SOCIAL_App *app,
   greq->ego_pub_key = ego->pub_key;
 
   char *p = (char *) &greq[1];
-  memcpy (p, app->id, app_id_size);
+  GNUNET_memcpy (p, app->id, app_id_size);
   p += app_id_size;
-  memcpy (p, gns_name, gns_name_size);
+  GNUNET_memcpy (p, gns_name, gns_name_size);
   p += gns_name_size;
-  memcpy (p, password, password_size);
+  GNUNET_memcpy (p, password, password_size);
   p += password_size;
   if (NULL != join_msg)
-    memcpy (p, join_msg, join_msg_size);
+    GNUNET_memcpy (p, join_msg, join_msg_size);
 
   gst->enter_cb = local_enter_cb;
   gst->entry_dcsn_cb = entry_decision_cb;
@@ -1782,7 +1786,6 @@ GNUNET_SOCIAL_guest_enter_by_name (const struct GNUNET_SOCIAL_App *app,
   GNUNET_CLIENT_MANAGER_set_user_context_ (plc->client, gst, sizeof (*plc));
 
   plc->tmit = GNUNET_PSYC_transmit_create (plc->client);
-  plc->recv = GNUNET_PSYC_receive_create (NULL, GNUNET_PSYC_slicer_message, plc->slicer);
 
   plc->connect_msg = &greq->header;
   place_send_connect_msg (plc);
@@ -1827,7 +1830,7 @@ GNUNET_SOCIAL_guest_enter_reconnect (struct GNUNET_SOCIAL_GuestConnection *gconn
   greq->place_pub_key = gconn->plc_msg.place_pub_key;
   greq->flags = htonl (flags);
 
-  memcpy (&greq[1], gconn->app->id, app_id_size);
+  GNUNET_memcpy (&greq[1], gconn->app->id, app_id_size);
 
   gst->enter_cb = local_enter_cb;
   gst->cb_cls = cls;
@@ -1842,7 +1845,6 @@ GNUNET_SOCIAL_guest_enter_reconnect (struct GNUNET_SOCIAL_GuestConnection *gconn
   GNUNET_CLIENT_MANAGER_set_user_context_ (plc->client, gst, sizeof (*plc));
 
   plc->tmit = GNUNET_PSYC_transmit_create (plc->client);
-  plc->recv = GNUNET_PSYC_receive_create (NULL, GNUNET_PSYC_slicer_message, plc->slicer);
 
   plc->connect_msg = &greq->header;
   place_send_connect_msg (plc);
@@ -1988,12 +1990,58 @@ GNUNET_SOCIAL_guest_get_place (struct GNUNET_SOCIAL_Guest *gst)
  * @return Public key of the place.
  */
 const struct GNUNET_CRYPTO_EddsaPublicKey *
-GNUNET_SOCIAL_place_get_key (struct GNUNET_SOCIAL_Place *plc)
+GNUNET_SOCIAL_place_get_pub_key (const struct GNUNET_SOCIAL_Place *plc)
 {
   return &plc->pub_key;
 }
 
 
+/**
+ * Set message processing @a flags for a @a method_prefix.
+ *
+ * @param plc
+ *        Place.
+ * @param method_prefix
+ *        Method prefix @a flags apply to.
+ * @param flags
+ *        The flags that apply to a matching @a method_prefix.
+ */
+void
+GNUNET_SOCIAL_place_msg_proc_set (struct GNUNET_SOCIAL_Place *plc,
+                                  const char *method_prefix,
+                                  enum GNUNET_SOCIAL_MsgProcFlags flags)
+{
+  GNUNET_assert (NULL != method_prefix);
+  struct MsgProcRequest *mpreq;
+  uint16_t method_size = strnlen (method_prefix,
+                                  GNUNET_SERVER_MAX_MESSAGE_SIZE
+                                  - sizeof (*mpreq)) + 1;
+  GNUNET_assert ('\0' == method_prefix[method_size - 1]);
+  mpreq = GNUNET_malloc (sizeof (*mpreq) + method_size);
+
+  mpreq->header.type = htons (GNUNET_MESSAGE_TYPE_SOCIAL_MSG_PROC_SET);
+  mpreq->header.size = htons (sizeof (*mpreq) + method_size);
+  mpreq->flags = htonl (flags);
+  GNUNET_memcpy (&mpreq[1], method_prefix, method_size);
+
+  GNUNET_CLIENT_MANAGER_transmit (plc->client, &mpreq->header);
+  GNUNET_free (mpreq);
+}
+
+
+/**
+ * Clear all message processing flags previously set for this place.
+ */
+void
+GNUNET_SOCIAL_place_msg_proc_clear (struct GNUNET_SOCIAL_Place *plc)
+{
+  struct GNUNET_MessageHeader req;
+  req.type = htons (GNUNET_MESSAGE_TYPE_SOCIAL_MSG_PROC_CLEAR);
+  req.size = htons (sizeof (req));
+  GNUNET_CLIENT_MANAGER_transmit (plc->client, &req);
+}
+
+
 static struct GNUNET_SOCIAL_HistoryRequest *
 place_history_replay (struct GNUNET_SOCIAL_Place *plc,
                       uint64_t start_message_id,
@@ -2008,7 +2056,7 @@ place_history_replay (struct GNUNET_SOCIAL_Place *plc,
   struct GNUNET_PSYC_HistoryRequestMessage *req;
   struct GNUNET_SOCIAL_HistoryRequest *hist = GNUNET_malloc (sizeof (*hist));
   hist->plc = plc;
-  hist->recv = GNUNET_PSYC_receive_create (NULL, GNUNET_PSYC_slicer_message, slicer);
+  hist->slicer = slicer;
   hist->result_cb = result_cb;
   hist->cls = cls;
   hist->op_id = GNUNET_CLIENT_MANAGER_op_add (plc->client,
@@ -2027,9 +2075,10 @@ place_history_replay (struct GNUNET_SOCIAL_Place *plc,
   req->message_limit = GNUNET_htonll (message_limit);
   req->flags = htonl (flags);
   req->op_id = GNUNET_htonll (hist->op_id);
-  memcpy (&req[1], method_prefix, method_size);
+  GNUNET_memcpy (&req[1], method_prefix, method_size);
 
   GNUNET_CLIENT_MANAGER_transmit (plc->client, &req->header);
+  GNUNET_free (req);
   return hist;
 }
 
@@ -2118,7 +2167,6 @@ GNUNET_SOCIAL_place_history_replay_latest (struct GNUNET_SOCIAL_Place *plc,
 void
 GNUNET_SOCIAL_place_history_replay_cancel (struct GNUNET_SOCIAL_HistoryRequest *hist)
 {
-  GNUNET_PSYC_receive_destroy (hist->recv);
   GNUNET_CLIENT_MANAGER_op_cancel (hist->plc->client, hist->op_id);
   GNUNET_free (hist);
 }
@@ -2149,9 +2197,10 @@ place_state_get (struct GNUNET_SOCIAL_Place *plc,
   req->header.type = htons (type);
   req->header.size = htons (sizeof (*req) + name_size);
   req->op_id = GNUNET_htonll (look->op_id);
-  memcpy (&req[1], name, name_size);
+  GNUNET_memcpy (&req[1], name, name_size);
 
   GNUNET_CLIENT_MANAGER_transmit (plc->client, &req->header);
+  GNUNET_free (req);
   return look;
 }
 
@@ -2299,11 +2348,11 @@ GNUNET_SOCIAL_zone_add_place (const struct GNUNET_SOCIAL_App *app,
   preq->relay_count = htonl (relay_count);
 
   char *p = (char *) &preq[1];
-  memcpy (p, name, name_size);
+  GNUNET_memcpy (p, name, name_size);
   p += name_size;
-  memcpy (p, password, password_size);
+  GNUNET_memcpy (p, password, password_size);
   p += password_size;
-  memcpy (p, relays, relay_size);
+  GNUNET_memcpy (p, relays, relay_size);
 
   struct ZoneAddPlaceHandle * add_plc = GNUNET_malloc (sizeof (*add_plc));
   add_plc->req = preq;
@@ -2376,7 +2425,7 @@ GNUNET_SOCIAL_zone_add_nym (const struct GNUNET_SOCIAL_App *app,
   nreq->expiration_time = GNUNET_htonll (expiration_time.abs_value_us);
   nreq->ego_pub_key = ego->pub_key;
   nreq->nym_pub_key = *nym_pub_key;
-  memcpy (&nreq[1], name, name_size);
+  GNUNET_memcpy (&nreq[1], name, name_size);
 
   struct ZoneAddNymHandle * add_nym = GNUNET_malloc (sizeof (*add_nym));
   add_nym->req = nreq;
@@ -2402,11 +2451,13 @@ GNUNET_SOCIAL_zone_add_nym (const struct GNUNET_SOCIAL_App *app,
  *        Configuration.
  * @param id
  *        Application ID.
- * @param notify_host
+ * @param ego_cb
+ *        Function to notify about an available ego.
+ * @param host_cb
  *        Function to notify about a place entered as host.
- * @param notify_guest
- *        Function to notify about a place entered as guest..
- * @param notify_cls
+ * @param guest_cb
+ *        Function to notify about a place entered as guest.
+ * @param cls
  *        Closure for the callbacks.
  *
  * @return Handle that can be used to stop listening.
@@ -2417,6 +2468,7 @@ GNUNET_SOCIAL_app_connect (const struct GNUNET_CONFIGURATION_Handle *cfg,
                            GNUNET_SOCIAL_AppEgoCallback ego_cb,
                            GNUNET_SOCIAL_AppHostPlaceCallback host_cb,
                            GNUNET_SOCIAL_AppGuestPlaceCallback guest_cb,
+                           GNUNET_SOCIAL_AppConnectedCallback connected_cb,
                            void *cls)
 {
   uint16_t app_id_size = strnlen (id, GNUNET_SOCIAL_APP_MAX_ID_SIZE);
@@ -2429,6 +2481,7 @@ GNUNET_SOCIAL_app_connect (const struct GNUNET_CONFIGURATION_Handle *cfg,
   app->ego_cb = ego_cb;
   app->host_cb = host_cb;
   app->guest_cb = guest_cb;
+  app->connected_cb = connected_cb;
   app->cb_cls = cls;
   app->egos = GNUNET_CONTAINER_multihashmap_create (1, GNUNET_NO);
   app->client = GNUNET_CLIENT_MANAGER_connect (cfg, "social",
@@ -2436,12 +2489,12 @@ GNUNET_SOCIAL_app_connect (const struct GNUNET_CONFIGURATION_Handle *cfg,
   GNUNET_CLIENT_MANAGER_set_user_context_ (app->client, app, sizeof (*app));
 
   app->id = GNUNET_malloc (app_id_size);
-  memcpy (app->id, id, app_id_size);
+  GNUNET_memcpy (app->id, id, app_id_size);
 
   struct AppConnectRequest *creq = GNUNET_malloc (sizeof (*creq) + app_id_size);
   creq->header.size = htons (sizeof (*creq) + app_id_size);
   creq->header.type = htons (GNUNET_MESSAGE_TYPE_SOCIAL_APP_CONNECT);
-  memcpy (&creq[1], app->id, app_id_size);
+  GNUNET_memcpy (&creq[1], app->id, app_id_size);
 
   app->connect_msg = &creq->header;
   app_send_connect_msg (app);
@@ -2455,11 +2508,18 @@ GNUNET_SOCIAL_app_connect (const struct GNUNET_CONFIGURATION_Handle *cfg,
  *
  * @param app
  *        Application handle.
+ * @param disconnect_cb
+ *        Disconnect callback.
+ * @param disconnect_cls
+ *        Disconnect closure.
  */
 void
-GNUNET_SOCIAL_app_disconnect (struct GNUNET_SOCIAL_App *app)
+GNUNET_SOCIAL_app_disconnect (struct GNUNET_SOCIAL_App *app,
+                              GNUNET_ContinuationCallback disconnect_cb,
+                              void *disconnect_cls)
 {
-  GNUNET_CLIENT_MANAGER_disconnect (app->client, GNUNET_NO, NULL, NULL);
+  GNUNET_CLIENT_MANAGER_disconnect (app->client, GNUNET_NO,
+                                    disconnect_cb, disconnect_cls);
 }