memcmp() -> GNUNET_memcmp(), first take
[oweals/gnunet.git] / src / pt / gnunet-daemon-pt.c
index dc7eef061d407c87403d889a0c237a6e7cf19959..cd17c2b7bc34dde2ce468ad6b81747fa4583d25a 100644 (file)
@@ -1,23 +1,22 @@
 /*
      This file is part of GNUnet.
-     (C) 2010, 2012 Christian Grothoff
+     Copyright (C) 2010, 2012, 2017 Christian Grothoff
 
-     GNUnet is free software; you can redistribute it and/or modify
-     it under the terms of the GNU General Public License as published
-     by the Free Software Foundation; either version 3, or (at your
-     option) any later version.
+     GNUnet is free software: you can redistribute it and/or modify it
+     under the terms of the GNU Affero General Public License as published
+     by the Free Software Foundation, either version 3 of the License,
+     or (at your option) any later version.
 
      GNUnet is distributed in the hope that it will be useful, but
      WITHOUT ANY WARRANTY; without even the implied warranty of
      MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-     General Public License for more details.
+     Affero General Public License for more details.
+    
+     You should have received a copy of the GNU Affero General Public License
+     along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
-     You should have received a copy of the GNU General Public License
-     along with GNUnet; see the file COPYING.  If not, write to the
-     Free Software Foundation, Inc., 59 Temple Place - Suite 330,
-     Boston, MA 02111-1307, USA.
+     SPDX-License-Identifier: AGPL3.0-or-later
 */
-
 /**
  * @file pt/gnunet-daemon-pt.c
  * @brief tool to manipulate DNS and VPN services to perform protocol translation (IPvX over GNUnet)
 #include "gnunet_util_lib.h"
 #include "gnunet_dns_service.h"
 #include "gnunet_dnsparser_lib.h"
-#include "gnunet_mesh_service.h"
+#include "gnunet_cadet_service.h"
 #include "gnunet_tun_lib.h"
+#include "gnunet_dht_service.h"
 #include "gnunet_vpn_service.h"
 #include "gnunet_statistics_service.h"
 #include "gnunet_applications.h"
-
-#define PORT_PT 4242 // FIXME
+#include "block_dns.h"
 
 
 /**
- * After how long do we time out if we could not get an IP from VPN or MESH?
+ * After how long do we time out if we could not get an IP from VPN or CADET?
  */
 #define TIMEOUT GNUNET_TIME_UNIT_MINUTES
 
-
 /**
  * How many bytes of payload do we allow at most for a DNS reply?
  * Given that this is pretty much limited to loopback, we can be
  */
 #define MAX_DNS_SIZE (8 * 1024)
 
+/**
+ * How many channels do we open at most at the same time?
+ */
+#define MAX_OPEN_TUNNELS 4
+
 
 /**
  * Which group of DNS records are we currently processing?
  */
 enum RequestGroup
-  {
-    /**
-     * DNS answers
-     */
-    ANSWERS = 0, 
-
-    /**
-     * DNS authority records
-     */
-    AUTHORITY_RECORDS = 1,
-
-    /**
-     * DNS additional records
-     */
-    ADDITIONAL_RECORDS = 2,
-
-    /**
-     * We're done processing.
-     */
-    END = 3
-  };
+{
+  /**
+   * DNS answers
+   */
+  ANSWERS = 0,
+
+  /**
+   * DNS authority records
+   */
+  AUTHORITY_RECORDS = 1,
+
+  /**
+   * DNS additional records
+   */
+  ADDITIONAL_RECORDS = 2,
+
+  /**
+   * We're done processing.
+   */
+  END = 3
+};
 
 
 /**
@@ -88,7 +91,7 @@ struct ReplyContext
    * Handle to submit the final result.
    */
   struct GNUNET_DNS_RequestHandle *rh;
-  
+
   /**
    * DNS packet that is being modified.
    */
@@ -113,12 +116,75 @@ struct ReplyContext
    * Group that is being modified
    */
   enum RequestGroup group;
-  
+
+};
+
+
+/**
+ * Handle to a peer that advertised that it is willing to serve
+ * as a DNS exit.  We try to keep a few channels open and a few
+ * peers in reserve.
+ */
+struct CadetExit
+{
+
+  /**
+   * Kept in a DLL.
+   */
+  struct CadetExit *next;
+
+  /**
+   * Kept in a DLL.
+   */
+  struct CadetExit *prev;
+
+  /**
+   * Channel we use for DNS requests over CADET, NULL if we did
+   * not initialze a channel to this peer yet.
+   */
+  struct GNUNET_CADET_Channel *cadet_channel;
+
+  /**
+   * At what time did the peer's advertisement expire?
+   */
+  struct GNUNET_TIME_Absolute expiration;
+
+  /**
+   * Head of DLL of requests waiting for a response.
+   */
+  struct RequestContext *receive_queue_head;
+
+  /**
+   * Tail of DLL of requests waiting for a response.
+   */
+  struct RequestContext *receive_queue_tail;
+
+  /**
+   * Identity of the peer that is providing the exit for us.
+   */
+  struct GNUNET_PeerIdentity peer;
+
+  /**
+   * How many DNS requests did we transmit via this channel?
+   */
+  unsigned int num_transmitted;
+
+  /**
+   * How many DNS requests were answered via this channel?
+   */
+  unsigned int num_answered;
+
+  /**
+   * Size of the window, 0 if we are busy.
+   */
+  /* unsigned */ int idle;
+
 };
 
 
+
 /**
- * State we keep for a request that is going out via MESH.
+ * State we keep for a request that is going out via CADET.
  */
 struct RequestContext
 {
@@ -132,36 +198,51 @@ struct RequestContext
    */
   struct RequestContext *prev;
 
+  /**
+   * Exit that was chosen for this request.
+   */
+  struct CadetExit *exit;
+
   /**
    * Handle for interaction with DNS service.
    */
   struct GNUNET_DNS_RequestHandle *rh;
-  
+
   /**
-   * Message we're sending out via MESH, allocated at the
-   * end of this struct.
+   * Envelope with the request we are transmitting.
    */
-  const struct GNUNET_MessageHeader *mesh_message;
+  struct GNUNET_MQ_Envelope *env;
 
   /**
    * Task used to abort this operation with timeout.
    */
-  GNUNET_SCHEDULER_TaskIdentifier timeout_task;
+  struct GNUNET_SCHEDULER_Task *timeout_task;
 
   /**
-   * ID of the original DNS request (used to match the reply).
+   * Length of the request message that follows this struct.
    */
-  uint16_t dns_id;
+  uint16_t mlen;
 
   /**
-   * GNUNET_NO if this request is still in the transmit_queue,
-   * GNUNET_YES if we are in the receive_queue.
-   */ 
-  int16_t was_transmitted;
+   * ID of the original DNS request (used to match the reply).
+   */
+  uint16_t dns_id;
 
 };
 
 
+/**
+ * Head of DLL of cadet exits.  Cadet exits with an open channel are
+ * always at the beginning (so we do not have to traverse the entire
+ * list to find them).
+ */
+static struct CadetExit *exit_head;
+
+/**
+ * Tail of DLL of cadet exits.
+ */
+static struct CadetExit *exit_tail;
+
 /**
  * The handle to the configuration used throughout the process
  */
@@ -173,75 +254,151 @@ static const struct GNUNET_CONFIGURATION_Handle *cfg;
 static struct GNUNET_VPN_Handle *vpn_handle;
 
 /**
- * The handle to the MESH service
+ * The handle to the CADET service
  */
-static struct GNUNET_MESH_Handle *mesh_handle;
+static struct GNUNET_CADET_Handle *cadet_handle;
 
 /**
- * Tunnel we use for DNS requests over MESH.
+ * Statistics.
  */
-static struct GNUNET_MESH_Tunnel *mesh_tunnel;
+static struct GNUNET_STATISTICS_Handle *stats;
 
 /**
- * Active transmission request with MESH (or NULL).
+ * The handle to DNS post-resolution modifications.
  */
-static struct GNUNET_MESH_TransmitHandle *mesh_th;
+static struct GNUNET_DNS_Handle *dns_post_handle;
 
 /**
- * Head of DLL of requests to be transmitted to mesh_tunnel.
+ * The handle to DNS pre-resolution modifications.
  */
-static struct RequestContext *transmit_queue_head;
+static struct GNUNET_DNS_Handle *dns_pre_handle;
 
 /**
- * Tail of DLL of requests to be transmitted to mesh_tunnel.
+ * Handle to access the DHT.
  */
-static struct RequestContext *transmit_queue_tail;
+static struct GNUNET_DHT_Handle *dht;
 
 /**
- * Head of DLL of requests waiting for a response.
+ * Our DHT GET operation to find DNS exits.
  */
-static struct RequestContext *receive_queue_head;
+static struct GNUNET_DHT_GetHandle *dht_get;
 
 /**
- * Tail of DLL of requests waiting for a response.
+ * Are we doing IPv4-pt?
  */
-static struct RequestContext *receive_queue_tail;
+static int ipv4_pt;
 
 /**
- * Statistics.
+ * Are we doing IPv6-pt?
  */
-static struct GNUNET_STATISTICS_Handle *stats;
+static int ipv6_pt;
 
 /**
- * The handle to DNS post-resolution modifications.
+ * Are we channeling DNS queries?
  */
-static struct GNUNET_DNS_Handle *dns_post_handle;
+static int dns_channel;
 
 /**
- * The handle to DNS pre-resolution modifications.
+ * Number of DNS exit peers we currently have in the cadet channel.
+ * Used to see if using the cadet channel makes any sense right now,
+ * as well as to decide if we should open new channels.
  */
-static struct GNUNET_DNS_Handle *dns_pre_handle;
+static unsigned int dns_exit_available;
 
-/**
- * Are we doing IPv4-pt?
- */
-static int ipv4_pt;
 
 /**
- * Are we doing IPv6-pt?
+ * We are short on cadet exits, try to open another one.
  */
-static int ipv6_pt;
+static void
+try_open_exit (void);
+
 
 /**
- * Are we tunneling DNS queries?
+ * Compute the weight of the given exit.  The higher the weight,
+ * the more likely it will be that the channel will be chosen.
+ * A weigt of zero means that we should close the channel as it
+ * is so bad, that we should not use it.
+ *
+ * @param exit exit to calculate the weight for
+ * @return weight of the channel
  */
-static int dns_tunnel;
+static uint32_t
+get_channel_weight (struct CadetExit *exit)
+{
+  uint32_t dropped;
+  uint32_t drop_percent;
+  uint32_t good_percent;
+
+  GNUNET_assert (exit->num_transmitted >= exit->num_answered);
+  dropped = exit->num_transmitted - exit->num_answered;
+  if (exit->num_transmitted > 0)
+    drop_percent = (uint32_t) ((100LL * dropped) / exit->num_transmitted);
+  else
+    drop_percent = 50; /* no data */
+  if ( (exit->num_transmitted > 20) &&
+       (drop_percent > 25) )
+    return 0; /* statistically significant, and > 25% loss, die */
+  good_percent = 100 - drop_percent;
+  GNUNET_assert (0 != good_percent);
+  if ( UINT32_MAX / good_percent / good_percent < exit->num_transmitted)
+    return UINT32_MAX; /* formula below would overflow */
+  return 1 + good_percent * good_percent * exit->num_transmitted;
+}
+
 
 /**
- * Number of DNS exit peers we currently have in the mesh tunnel.
- * Used to see if using the mesh tunnel makes any sense right now.
+ * Choose a cadet exit for a DNS request.  We try to use a channel
+ * that is reliable and currently available.  All existing
+ * channels are given a base weight of 1, plus a score relating
+ * to the total number of queries answered in relation to the
+ * total number of queries we sent to that channel.  That
+ * score is doubled if the channel is currently idle.
+ *
+ * @return NULL if no exit is known, otherwise the
+ *         exit that we should use to queue a message with
  */
-static unsigned int dns_exit_available;
+static struct CadetExit *
+choose_exit ()
+{
+  struct CadetExit *pos;
+  uint64_t total_transmitted;
+  uint64_t selected_offset;
+  uint32_t channel_weight;
+
+  total_transmitted = 0;
+  for (pos = exit_head; NULL != pos; pos = pos->next)
+  {
+    if (NULL == pos->cadet_channel)
+      break;
+    channel_weight = get_channel_weight (pos);
+    total_transmitted += channel_weight;
+    /* double weight for idle channels */
+    if (0 != pos->idle)
+      total_transmitted += channel_weight;
+  }
+  if (0 == total_transmitted)
+  {
+    /* no channels available, or only a very bad one... */
+    return exit_head;
+  }
+  selected_offset = GNUNET_CRYPTO_random_u64 (GNUNET_CRYPTO_QUALITY_WEAK,
+                                             total_transmitted);
+  total_transmitted = 0;
+  for (pos = exit_head; NULL != pos; pos = pos->next)
+  {
+    if (NULL == pos->cadet_channel)
+      break;
+    channel_weight = get_channel_weight (pos);
+    total_transmitted += channel_weight;
+    /* double weight for idle channels */
+    if (0 != pos->idle)
+      total_transmitted += channel_weight;
+    if (total_transmitted > selected_offset)
+      return pos;
+  }
+  GNUNET_break (0);
+  return NULL;
+}
 
 
 /**
@@ -272,7 +429,8 @@ finish_request (struct ReplyContext *rc)
                              gettext_noop ("# DNS requests mapped to VPN"),
                              1, GNUNET_NO);
     GNUNET_DNS_request_answer (rc->rh,
-                              buf_len, buf);
+                              buf_len,
+                               buf);
     GNUNET_free (buf);
   }
   GNUNET_DNSPARSER_free_packet (rc->dns);
@@ -298,12 +456,12 @@ submit_request (struct ReplyContext *rc);
  * record and then continue with 'submit_request' to look at
  * the other records.
  *
- * @param cls our 'struct ReplyContext'
+ * @param cls our `struct ReplyContext`
  * @param af address family, AF_INET or AF_INET6; AF_UNSPEC on error;
  *                will match 'result_af' from the request
  * @param address IP address (struct in_addr or struct in_addr6, depending on 'af')
  *                that the VPN allocated for the redirection;
- *                traffic to this IP will now be redirected to the 
+ *                traffic to this IP will now be redirected to the
  *                specified target peer; NULL on error
  */
 static void
@@ -323,16 +481,21 @@ vpn_allocation_callback (void *cls,
   }
   GNUNET_STATISTICS_update (stats,
                            gettext_noop ("# DNS records modified"),
-                           1, GNUNET_NO);
+                           1,
+                            GNUNET_NO);
   switch (rc->rec->type)
   {
   case GNUNET_DNSPARSER_TYPE_A:
     GNUNET_assert (AF_INET == af);
-    memcpy (rc->rec->data.raw.data, address, sizeof (struct in_addr));
+    GNUNET_memcpy (rc->rec->data.raw.data,
+                   address,
+                   sizeof (struct in_addr));
     break;
   case GNUNET_DNSPARSER_TYPE_AAAA:
     GNUNET_assert (AF_INET6 == af);
-    memcpy (rc->rec->data.raw.data, address, sizeof (struct in6_addr));
+    GNUNET_memcpy (rc->rec->data.raw.data,
+                   address,
+                   sizeof (struct in6_addr));
     break;
   default:
     GNUNET_assert (0);
@@ -344,7 +507,7 @@ vpn_allocation_callback (void *cls,
 
 
 /**
- * Modify the given DNS record by asking VPN to create a tunnel
+ * Modify the given DNS record by asking VPN to create a channel
  * to the given address.  When done, continue with submitting
  * other records from the request context ('submit_request' is
  * our continuation).
@@ -374,9 +537,9 @@ modify_address (struct ReplyContext *rc,
   }
   rc->rec = rec;
   rc->rr = GNUNET_VPN_redirect_to_ip (vpn_handle,
-                                     af, af,
+                                     af,
+                                      af,
                                      rec->data.raw.data,
-                                     GNUNET_NO /* nac */,
                                      GNUNET_TIME_relative_to_absolute (TIMEOUT),
                                      &vpn_allocation_callback,
                                      rc);
@@ -417,7 +580,7 @@ submit_request (struct ReplyContext *rc)
       finish_request (rc);
       return;
     default:
-      GNUNET_assert (0);      
+      GNUNET_assert (0);
     }
     for (i=rc->offset;i<ra_len;i++)
     {
@@ -427,7 +590,8 @@ submit_request (struct ReplyContext *rc)
        if (ipv4_pt)
        {
          rc->offset = i + 1;
-         modify_address (rc, &ra[i]);
+         modify_address (rc,
+                          &ra[i]);
          return;
        }
        break;
@@ -435,7 +599,8 @@ submit_request (struct ReplyContext *rc)
        if (ipv6_pt)
        {
          rc->offset = i + 1;
-         modify_address (rc, &ra[i]);
+         modify_address (rc,
+                          &ra[i]);
          return;
        }
        break;
@@ -450,8 +615,8 @@ submit_request (struct ReplyContext *rc)
  * Test if any of the given records need protocol-translation work.
  *
  * @param ra array of records
- * @param ra_len number of entries in ra
- * @return GNUNET_YES if any of the given records require protocol-translation
+ * @param ra_len number of entries in @a ra
+ * @return #GNUNET_YES if any of the given records require protocol-translation
  */
 static int
 work_test (const struct GNUNET_DNSPARSER_Record *ra,
@@ -478,17 +643,17 @@ work_test (const struct GNUNET_DNSPARSER_Record *ra,
 
 
 /**
- * This function is called AFTER we got an IP address for a 
+ * This function is called AFTER we got an IP address for a
  * DNS request.  Now, the PT daemon has the chance to substitute
- * the IP address with one from the VPN range to tunnel requests
- * destined for this IP address via VPN and MESH.
+ * the IP address with one from the VPN range to channel requests
+ * destined for this IP address via VPN and CADET.
  *
  * @param cls closure
  * @param rh request handle to user for reply
  * @param request_length number of bytes in request
  * @param request udp payload of the DNS request
  */
-static void 
+static void
 dns_post_request_handler (void *cls,
                          struct GNUNET_DNS_RequestHandle *rh,
                          size_t request_length,
@@ -501,7 +666,8 @@ dns_post_request_handler (void *cls,
   GNUNET_STATISTICS_update (stats,
                            gettext_noop ("# DNS replies intercepted"),
                            1, GNUNET_NO);
-  dns = GNUNET_DNSPARSER_parse (request, request_length);
+  dns = GNUNET_DNSPARSER_parse (request,
+                                request_length);
   if (NULL == dns)
   {
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
@@ -510,16 +676,19 @@ dns_post_request_handler (void *cls,
     return;
   }
   work = GNUNET_NO;
-  work |= work_test (dns->answers, dns->num_answers);
-  work |= work_test (dns->authority_records, dns->num_authority_records);
-  work |= work_test (dns->additional_records, dns->num_additional_records);
+  work |= work_test (dns->answers,
+                     dns->num_answers);
+  work |= work_test (dns->authority_records,
+                     dns->num_authority_records);
+  work |= work_test (dns->additional_records,
+                     dns->num_additional_records);
   if (! work)
   {
     GNUNET_DNS_request_forward (rh);
     GNUNET_DNSPARSER_free_packet (dns);
     return;
   }
-  rc = GNUNET_malloc (sizeof (struct ReplyContext));
+  rc = GNUNET_new (struct ReplyContext);
   rc->rh = rh;
   rc->dns = dns;
   rc->offset = 0;
@@ -529,106 +698,71 @@ dns_post_request_handler (void *cls,
 
 
 /**
- * Transmit a DNS request via MESH and move the request
- * handle to the receive queue.
+ * Task run if the time to answer a DNS request via CADET is over.
  *
- * @param cls NULL
- * @param size number of bytes available in buf
- * @param buf where to copy the message
- * @return number of bytes written to buf
- */
-static size_t
-transmit_dns_request_to_mesh (void *cls,
-                             size_t size,
-                             void *buf)
-{
-  struct RequestContext *rc;
-  size_t mlen;
-
-  mesh_th = NULL;
-  if (NULL == (rc = transmit_queue_head))
-    return 0;
-  mlen = ntohs (rc->mesh_message->size);
-  if (mlen > size)
-  {
-    mesh_th = GNUNET_MESH_notify_transmit_ready (mesh_tunnel,
-                                                GNUNET_NO,
-                                                TIMEOUT,
-                                                mlen,
-                                                &transmit_dns_request_to_mesh,
-                                                NULL);
-    return 0;
-  }
-  GNUNET_assert (GNUNET_NO == rc->was_transmitted);
-  memcpy (buf, rc->mesh_message, mlen);
-  GNUNET_CONTAINER_DLL_remove (transmit_queue_head,
-                              transmit_queue_tail,
-                              rc);
-  rc->was_transmitted = GNUNET_YES;
-  GNUNET_CONTAINER_DLL_insert (receive_queue_head,
-                              receive_queue_tail,
-                              rc);
-  rc = transmit_queue_head;
-  if (NULL != rc)
-    mesh_th = GNUNET_MESH_notify_transmit_ready (mesh_tunnel,
-                                                GNUNET_NO,
-                                                TIMEOUT,
-                                                ntohs (rc->mesh_message->size),
-                                                &transmit_dns_request_to_mesh,
-                                                NULL);
-  return mlen;
-}
-
-
-/**
- * Task run if the time to answer a DNS request via MESH is over.
- *
- * @param cls the 'struct RequestContext' to abort
- * @param tc scheduler context
+ * @param cls the `struct RequestContext` to abort
  */
 static void
-timeout_request (void *cls,
-                const struct GNUNET_SCHEDULER_TaskContext *tc)
+timeout_request (void *cls)
 {
   struct RequestContext *rc = cls;
-  
-  if (rc->was_transmitted)
-    GNUNET_CONTAINER_DLL_remove (receive_queue_head,
-                                receive_queue_tail,
-                                rc);
-  else
-    GNUNET_CONTAINER_DLL_remove (transmit_queue_head,
-                                transmit_queue_tail,
-                                rc);
+  struct CadetExit *exit = rc->exit;
+
   GNUNET_STATISTICS_update (stats,
                            gettext_noop ("# DNS requests dropped (timeout)"),
-                           1, GNUNET_NO);
+                           1,
+                            GNUNET_NO);
   GNUNET_DNS_request_drop (rc->rh);
   GNUNET_free (rc);
+  if ( (0 == get_channel_weight (exit)) &&
+       (NULL == exit->receive_queue_head) )
+  {
+    /* this straw broke the camel's back: this channel now has
+       such a low score that it will not be used; close it! */
+    GNUNET_CADET_channel_destroy (exit->cadet_channel);
+    exit->cadet_channel = NULL;
+    GNUNET_CONTAINER_DLL_remove (exit_head,
+                                exit_tail,
+                                exit);
+    GNUNET_CONTAINER_DLL_insert_tail (exit_head,
+                                     exit_tail,
+                                     exit);
+    /* go back to semi-innocent: mark as not great, but
+       avoid a prohibitively negative score (see
+       #get_channel_weight(), which checks for a certain
+       minimum number of transmissions before making
+       up an opinion) */
+    exit->num_transmitted = 5;
+    exit->num_answered = 0;
+    dns_exit_available--;
+    /* now try to open an alternative exit */
+    try_open_exit ();
+  }
 }
 
 
 /**
- * This function is called *before* the DNS request has been 
- * given to a "local" DNS resolver.  Tunneling for DNS requests
- * was enabled, so we now need to send the request via some MESH
- * tunnel to a DNS EXIT for resolution.
+ * This function is called *before* the DNS request has been
+ * given to a "local" DNS resolver.  Channeling for DNS requests
+ * was enabled, so we now need to send the request via some CADET
+ * channel to a DNS EXIT for resolution.
  *
  * @param cls closure
  * @param rh request handle to user for reply
  * @param request_length number of bytes in request
  * @param request udp payload of the DNS request
  */
-static void 
+static void
 dns_pre_request_handler (void *cls,
                         struct GNUNET_DNS_RequestHandle *rh,
                         size_t request_length,
                         const char *request)
 {
   struct RequestContext *rc;
-  size_t mlen;
-  struct GNUNET_MessageHeader hdr;
+  struct GNUNET_MQ_Envelope *env;
+  struct GNUNET_MessageHeader *hdr;
   struct GNUNET_TUN_DnsHeader dns;
+  struct CadetExit *exit;
 
   GNUNET_STATISTICS_update (stats,
                            gettext_noop ("# DNS requests intercepted"),
@@ -636,7 +770,7 @@ dns_pre_request_handler (void *cls,
   if (0 == dns_exit_available)
   {
     GNUNET_STATISTICS_update (stats,
-                             gettext_noop ("# DNS requests dropped (DNS mesh tunnel down)"),
+                             gettext_noop ("# DNS requests dropped (DNS cadet channel down)"),
                              1, GNUNET_NO);
     GNUNET_DNS_request_drop (rh);
     return;
@@ -649,217 +783,390 @@ dns_pre_request_handler (void *cls,
     GNUNET_DNS_request_drop (rh);
     return;
   }
-  memcpy (&dns, request, sizeof (dns));
-  GNUNET_assert (NULL != mesh_tunnel);
-  mlen = sizeof (struct GNUNET_MessageHeader) + request_length;
-  rc = GNUNET_malloc (sizeof (struct RequestContext) + mlen);
+  exit = choose_exit ();
+  GNUNET_assert (NULL != exit);
+  GNUNET_assert (NULL != exit->cadet_channel);
+
+  env = GNUNET_MQ_msg_extra (hdr,
+                             request_length,
+                             GNUNET_MESSAGE_TYPE_VPN_DNS_TO_INTERNET);
+  GNUNET_memcpy (&hdr[1],
+                 request,
+                 request_length);
+  rc = GNUNET_new (struct RequestContext);
+  rc->exit = exit;
   rc->rh = rh;
-  rc->mesh_message = (const struct GNUNET_MessageHeader*) &rc[1];
   rc->timeout_task = GNUNET_SCHEDULER_add_delayed (TIMEOUT,
                                                   &timeout_request,
                                                   rc);
+  GNUNET_memcpy (&dns,
+                 request,
+                 sizeof (dns));
   rc->dns_id = dns.id;
-  hdr.type = htons (GNUNET_MESSAGE_TYPE_VPN_DNS_TO_INTERNET);
-  hdr.size = htons (mlen);
-  memcpy (&rc[1], &hdr, sizeof (struct GNUNET_MessageHeader));
-  memcpy (&(((char*)&rc[1])[sizeof (struct GNUNET_MessageHeader)]),
-         request,
-         request_length);
-  GNUNET_CONTAINER_DLL_insert_tail (transmit_queue_head,
-                                   transmit_queue_tail,
-                                   rc);
-  if (NULL == mesh_th)
-    mesh_th = GNUNET_MESH_notify_transmit_ready (mesh_tunnel,
-                                                GNUNET_NO,
-                                                TIMEOUT,
-                                                mlen,
-                                                &transmit_dns_request_to_mesh,
-                                                NULL);
+  rc->env = env;
+  GNUNET_CONTAINER_DLL_remove (exit->receive_queue_head,
+                               exit->receive_queue_tail,
+                               rc);
+  if (0 < exit->idle)
+    exit->idle--;
+  exit->num_transmitted++;
+  GNUNET_MQ_send (GNUNET_CADET_get_mq (exit->cadet_channel),
+                  GNUNET_MQ_env_copy (env));
 }
 
 
+GNUNET_NETWORK_STRUCT_BEGIN
+
+/**
+ * Message with a DNS response.
+ */
+struct DnsResponseMessage
+{
+  /**
+   * GNUnet header, of type #GNUNET_MESSAGE_TYPE_VPN_DNS_FROM_INTERNET
+   */
+  struct GNUNET_MessageHeader header;
+
+  /**
+   * DNS header.
+   */
+  struct GNUNET_TUN_DnsHeader dns;
+
+  /* Followed by more DNS payload */
+};
+
+GNUNET_NETWORK_STRUCT_END
+
 /**
- * Process a request via mesh to perform a DNS query.
+ * Process a request via cadet to perform a DNS query.
  *
- * @param cls closure, NULL
- * @param tunnel connection to the other end
- * @param tunnel_ctx pointer to our 'struct TunnelState *'
- * @param message the actual message
- * 
- * @return GNUNET_OK to keep the connection open,
- *         GNUNET_SYSERR to close it (signal serious error)
+ * @param cls the `struct CadetExit` which got the message
+ * @param msg the actual message
+ * @return #GNUNET_OK to keep the connection open,
+ *         #GNUNET_SYSERR to close it (signal serious error)
  */
 static int
-receive_dns_response (void *cls GNUNET_UNUSED, struct GNUNET_MESH_Tunnel *tunnel,
-                     void **tunnel_ctx,
-                     const struct GNUNET_MessageHeader *message)
+check_dns_response (void *cls,
+                     const struct DnsResponseMessage *msg)
 {
-  struct GNUNET_TUN_DnsHeader dns;
+  return GNUNET_OK; /* all OK */
+}
+
+
+/**
+ * Process a request via cadet to perform a DNS query.
+ *
+ * @param cls the `struct CadetExit` which got the message
+ * @param msg the actual message
+ */
+static void
+handle_dns_response (void *cls,
+                     const struct DnsResponseMessage *msg)
+{
+  struct CadetExit *exit = cls;
   size_t mlen;
   struct RequestContext *rc;
 
-  mlen = ntohs (message->size);
-  mlen -= sizeof (struct GNUNET_MessageHeader);
-  if (mlen < sizeof (struct GNUNET_TUN_DnsHeader))
-  {
-    GNUNET_break_op (0);
-    return GNUNET_SYSERR;
-  }
-  memcpy (&dns, &message[1], sizeof (dns));
-  for (rc = receive_queue_head; NULL != rc; rc = rc->next)
+  mlen = ntohs (msg->header.size) - sizeof (*msg);
+  for (rc = exit->receive_queue_head; NULL != rc; rc = rc->next)
   {
-    GNUNET_assert (GNUNET_YES == rc->was_transmitted);
-    if (dns.id == rc->dns_id)
+    if (msg->dns.id == rc->dns_id)
     {
       GNUNET_STATISTICS_update (stats,
                                gettext_noop ("# DNS replies received"),
-                               1, GNUNET_NO);
+                               1,
+                                GNUNET_NO);
       GNUNET_DNS_request_answer (rc->rh,
-                                mlen,
-                                (const void*) &message[1]);
-      GNUNET_CONTAINER_DLL_remove (receive_queue_head,
-                                  receive_queue_tail,
+                                mlen + sizeof (struct GNUNET_TUN_DnsHeader),
+                                (const void*) &msg->dns);
+      GNUNET_CONTAINER_DLL_remove (exit->receive_queue_head,
+                                  exit->receive_queue_tail,
                                   rc);
       GNUNET_SCHEDULER_cancel (rc->timeout_task);
+      GNUNET_MQ_discard (rc->env);
       GNUNET_free (rc);
-      return GNUNET_OK;      
+      exit->num_answered++;
+      return;
     }
   }
   GNUNET_STATISTICS_update (stats,
                            gettext_noop ("# DNS replies dropped (too late?)"),
                            1, GNUNET_NO);
-  return GNUNET_OK;
 }
 
 
 /**
- * The MESH DNS tunnel went down.  Abort all pending DNS
- * requests (we're unlikely to get an answer in time).
- */ 
+ * Abort all pending DNS requests with the given cadet exit.
+ *
+ * @param exit cadet exit to abort requests for
+ */
 static void
-abort_all_requests ()
+abort_all_requests (struct CadetExit *exit)
 {
   struct RequestContext *rc;
 
-  while (NULL != (rc = receive_queue_head))
+  while (NULL != (rc = exit->receive_queue_head))
   {
-    GNUNET_STATISTICS_update (stats,
-                             gettext_noop ("# DNS requests aborted (tunnel down)"),
-                             1, GNUNET_NO);
-    GNUNET_CONTAINER_DLL_remove (receive_queue_head,
-                                receive_queue_tail,
+    GNUNET_CONTAINER_DLL_remove (exit->receive_queue_head,
+                                exit->receive_queue_tail,
                                 rc);
     GNUNET_DNS_request_drop (rc->rh);
     GNUNET_SCHEDULER_cancel (rc->timeout_task);
-    GNUNET_free (rc);    
+    GNUNET_MQ_discard (rc->env);
+    GNUNET_free (rc);
   }
-  while (NULL != (rc = transmit_queue_head))
+}
+
+
+/**
+ * Function scheduled as very last function, cleans up after us
+ *
+ * @param cls closure, NULL
+ */
+static void
+cleanup (void *cls)
+{
+  struct CadetExit *exit;
+
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+             "Protocol translation daemon is shutting down now\n");
+  if (NULL != vpn_handle)
   {
-    GNUNET_STATISTICS_update (stats,
-                             gettext_noop ("# DNS requests aborted (tunnel down)"),
-                             1, GNUNET_NO);
-    GNUNET_CONTAINER_DLL_remove (transmit_queue_head,
-                                transmit_queue_tail,
-                                rc);
-    GNUNET_DNS_request_drop (rc->rh);
-    GNUNET_SCHEDULER_cancel (rc->timeout_task);
-    GNUNET_free (rc);    
+    GNUNET_VPN_disconnect (vpn_handle);
+    vpn_handle = NULL;
+  }
+  while (NULL != (exit = exit_head))
+  {
+    GNUNET_CONTAINER_DLL_remove (exit_head,
+                                exit_tail,
+                                exit);
+    if (NULL != exit->cadet_channel)
+    {
+      GNUNET_CADET_channel_destroy (exit->cadet_channel);
+      exit->cadet_channel = NULL;
+    }
+    abort_all_requests (exit);
+    GNUNET_free (exit);
+  }
+  if (NULL != cadet_handle)
+  {
+    GNUNET_CADET_disconnect (cadet_handle);
+    cadet_handle = NULL;
+  }
+  if (NULL != dns_post_handle)
+  {
+    GNUNET_DNS_disconnect (dns_post_handle);
+    dns_post_handle = NULL;
+  }
+  if (NULL != dns_pre_handle)
+  {
+    GNUNET_DNS_disconnect (dns_pre_handle);
+    dns_pre_handle = NULL;
+  }
+  if (NULL != stats)
+  {
+    GNUNET_STATISTICS_destroy (stats, GNUNET_YES);
+    stats = NULL;
+  }
+  if (NULL != dht_get)
+  {
+    GNUNET_DHT_get_stop (dht_get);
+    dht_get = NULL;
+  }
+  if (NULL != dht)
+  {
+    GNUNET_DHT_disconnect (dht);
+    dht = NULL;
   }
 }
 
 
 /**
- * Method called whenever a peer has disconnected from the tunnel.
+ * Function called whenever a channel is destroyed.  Should clean up
+ * the associated state and attempt to build a new one.
  *
- * FIXME merge with inbound cleaner
- * 
- * @param cls closure
- * @param peer peer identity the tunnel stopped working with
+ * It must NOT call #GNUNET_CADET_channel_destroy on the channel.
+ *
+ * @param cls closure (the `struct CadetExit` set from #GNUNET_CADET_connect)
+ * @param channel connection to the other end (henceforth invalid)
+ * @param channel_ctx place where local state associated
+ *                   with the channel is stored
  */
-void
-mesh_disconnect_handler (void *cls,
-                        const struct
-                        GNUNET_PeerIdentity * peer)
+static void
+cadet_channel_end_cb (void *cls,
+                      const struct GNUNET_CADET_Channel *channel)
 {
-  GNUNET_assert (dns_exit_available > 0);
+  struct CadetExit *exit = cls;
+  struct CadetExit *alt;
+  struct RequestContext *rc;
+
+  exit->cadet_channel = NULL;
   dns_exit_available--;
-  if (0 == dns_exit_available)
+  /* open alternative channels */
+  /* our channel is now closed, move our requests to an alternative
+     channel */
+  alt = choose_exit ();
+  while (NULL != (rc = exit->receive_queue_head))
   {
-    if (NULL != mesh_th)
-    {
-      GNUNET_MESH_notify_transmit_ready_cancel (mesh_th);
-      mesh_th = NULL;
-    }
-    abort_all_requests ();
+    GNUNET_CONTAINER_DLL_remove (exit->receive_queue_head,
+                                 exit->receive_queue_tail,
+                                 rc);
+    rc->exit = alt;
+    GNUNET_CONTAINER_DLL_insert (alt->receive_queue_head,
+                                 alt->receive_queue_tail,
+                                 rc);
+    GNUNET_MQ_send (GNUNET_CADET_get_mq (alt->cadet_channel),
+                    GNUNET_MQ_env_copy (rc->env));
   }
+  try_open_exit ();
 }
 
 
 /**
- * Method called whenever a peer has connected to the tunnel.
+ * Function called whenever a channel has excess capacity.
  *
- * FIXME find anouther way (in tmt_ready_callback ?)
- * 
- * @param cls closure
- * @param peer peer identity the tunnel was created to, NULL on timeout
- * @param atsi performance data for the connection
- */
-void
-mesh_connect_handler (void *cls,
-                     const struct GNUNET_PeerIdentity
-                     * peer,
-                     const struct
-                     GNUNET_ATS_Information * atsi)
+ * @param cls the `struct CadetExit`
+ * @param channel connection to the other end
+ * @param window_size how much capacity do we have
+ */
+static void
+channel_idle_notify_cb (void *cls,
+                        const struct GNUNET_CADET_Channel *channel,
+                        int window_size)
 {
-  dns_exit_available++;
+  struct CadetExit *pos = cls;
+
+  pos->idle = window_size;
 }
 
 
 /**
- * Function scheduled as very last function, cleans up after us
+ * We are short on cadet exits, try to open another one.
  */
 static void
-cleanup (void *cls GNUNET_UNUSED,
-         const struct GNUNET_SCHEDULER_TaskContext *tskctx)
+try_open_exit ()
 {
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-             "Protocol translation daemon is shutting down now\n");
-  if (vpn_handle != NULL)
-  {
-    GNUNET_VPN_disconnect (vpn_handle);
-    vpn_handle = NULL;
-  }
-  if (NULL != mesh_th)
-  {
-    GNUNET_MESH_notify_transmit_ready_cancel (mesh_th);
-    mesh_th = NULL;
-  }
-  if (NULL != mesh_tunnel)
-  {
-    GNUNET_MESH_tunnel_destroy (mesh_tunnel);
-    mesh_tunnel = NULL;
-  }
-  if (mesh_handle != NULL)
-  {
-    GNUNET_MESH_disconnect (mesh_handle);
-    mesh_handle = NULL;
-  }
-  abort_all_requests ();
-  if (dns_post_handle != NULL)
+  struct CadetExit *pos;
+  uint32_t candidate_count;
+  uint32_t candidate_selected;
+  struct GNUNET_HashCode port;
+
+  GNUNET_CRYPTO_hash (GNUNET_APPLICATION_PORT_INTERNET_RESOLVER,
+                      strlen (GNUNET_APPLICATION_PORT_INTERNET_RESOLVER),
+                      &port);
+  candidate_count = 0;
+  for (pos = exit_head; NULL != pos; pos = pos->next)
+    if (NULL == pos->cadet_channel)
+      candidate_count++;
+  if (0 == candidate_count)
   {
-    GNUNET_DNS_disconnect (dns_post_handle);
-    dns_post_handle = NULL;
+    GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
+                "No DNS exits available yet.\n");
+    return;
   }
-  if (dns_pre_handle != NULL)
+  candidate_selected = GNUNET_CRYPTO_random_u32 (GNUNET_CRYPTO_QUALITY_WEAK,
+                                                candidate_count);
+  candidate_count = 0;
+  for (pos = exit_head; NULL != pos; pos = pos->next)
+    if (NULL == pos->cadet_channel)
+    {
+      candidate_count++;
+      if (candidate_selected < candidate_count)
+      {
+        struct GNUNET_MQ_MessageHandler cadet_handlers[] = {
+          GNUNET_MQ_hd_var_size (dns_response,
+                                 GNUNET_MESSAGE_TYPE_VPN_DNS_FROM_INTERNET,
+                                 struct DnsResponseMessage,
+                                 pos),
+          GNUNET_MQ_handler_end ()
+        };
+
+
+        /* move to the head of the DLL */
+       pos->cadet_channel
+          = GNUNET_CADET_channel_create (cadet_handle,
+                                         pos,
+                                         &pos->peer,
+                                         &port,
+                                         GNUNET_CADET_OPTION_DEFAULT,
+                                         &channel_idle_notify_cb,
+                                         &cadet_channel_end_cb,
+                                         cadet_handlers);
+       if (NULL == pos->cadet_channel)
+       {
+         GNUNET_break (0);
+         continue;
+       }
+       GNUNET_CONTAINER_DLL_remove (exit_head,
+                                    exit_tail,
+                                    pos);
+       GNUNET_CONTAINER_DLL_insert (exit_head,
+                                    exit_tail,
+                                    pos);
+       dns_exit_available++;
+       return;
+      }
+    }
+  GNUNET_assert (NULL == exit_head);
+}
+
+
+/**
+ * Function called whenever we find an advertisement for a
+ * DNS exit in the DHT.  If we don't have a cadet channel,
+ * we should build one; otherwise, we should save the
+ * advertisement for later use.
+ *
+ * @param cls closure
+ * @param exp when will this value expire
+ * @param key key of the result
+ * @param get_path peers on reply path (or NULL if not recorded)
+ *                 [0] = datastore's first neighbor, [length - 1] = local peer
+ * @param get_path_length number of entries in @a get_path
+ * @param put_path peers on the PUT path (or NULL if not recorded)
+ *                 [0] = origin, [length - 1] = datastore
+ * @param put_path_length number of entries in @a put_path
+ * @param type type of the result
+ * @param size number of bytes in @a data
+ * @param data pointer to the result data
+ */
+static void
+handle_dht_result (void *cls,
+                  struct GNUNET_TIME_Absolute exp,
+                  const struct GNUNET_HashCode *key,
+                  const struct GNUNET_PeerIdentity *get_path,
+                  unsigned int get_path_length,
+                  const struct GNUNET_PeerIdentity *put_path,
+                  unsigned int put_path_length,
+                  enum GNUNET_BLOCK_Type type,
+                  size_t size, const void *data)
+{
+  const struct GNUNET_DNS_Advertisement *ad;
+  struct CadetExit *exit;
+
+  if (sizeof (struct GNUNET_DNS_Advertisement) != size)
   {
-    GNUNET_DNS_disconnect (dns_pre_handle);
-    dns_pre_handle = NULL;
+    GNUNET_break (0);
+    return;
   }
-  if (stats != NULL)
+  ad = data;
+  for (exit = exit_head; NULL != exit; exit = exit->next)
+    if (0 == GNUNET_memcmp (&ad->peer,
+                    &exit->peer))
+      break;
+  if (NULL == exit)
   {
-    GNUNET_STATISTICS_destroy (stats, GNUNET_YES);
-    stats = NULL;
+    exit = GNUNET_new (struct CadetExit);
+    exit->peer = ad->peer;
+    /* channel is closed, so insert at the end */
+    GNUNET_CONTAINER_DLL_insert_tail (exit_head,
+                                     exit_tail,
+                                     exit);
   }
+  exit->expiration = GNUNET_TIME_absolute_max (exit->expiration,
+                                              GNUNET_TIME_absolute_ntoh (ad->expiration_time));
+  if (dns_exit_available < MAX_OPEN_TUNNELS)
+    try_open_exit ();
 }
 
 
@@ -876,26 +1183,36 @@ run (void *cls, char *const *args GNUNET_UNUSED,
      const char *cfgfile GNUNET_UNUSED,
      const struct GNUNET_CONFIGURATION_Handle *cfg_)
 {
+  struct GNUNET_HashCode dns_key;
+
   cfg = cfg_;
-  stats = GNUNET_STATISTICS_create ("pt", cfg);
-  ipv4_pt = GNUNET_CONFIGURATION_get_value_yesno (cfg, "pt", "TUNNEL_IPV4");
-  ipv6_pt = GNUNET_CONFIGURATION_get_value_yesno (cfg, "pt", "TUNNEL_IPV6"); 
-  dns_tunnel = GNUNET_CONFIGURATION_get_value_yesno (cfg, "pt", "TUNNEL_DNS"); 
-  if (! (ipv4_pt || ipv6_pt || dns_tunnel))
+  stats = GNUNET_STATISTICS_create ("pt",
+                                    cfg);
+  ipv4_pt = GNUNET_CONFIGURATION_get_value_yesno (cfg,
+                                                  "pt",
+                                                  "TUNNEL_IPV4");
+  ipv6_pt = GNUNET_CONFIGURATION_get_value_yesno (cfg,
+                                                  "pt",
+                                                  "TUNNEL_IPV6");
+  dns_channel = GNUNET_CONFIGURATION_get_value_yesno (cfg,
+                                                      "pt",
+                                                      "TUNNEL_DNS");
+  if (! (ipv4_pt || ipv6_pt || dns_channel))
   {
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                _("No useful service enabled.  Exiting.\n"));
     GNUNET_SCHEDULER_shutdown ();
-    return;    
+    return;
   }
-  GNUNET_SCHEDULER_add_delayed (GNUNET_TIME_UNIT_FOREVER_REL, &cleanup, cls);
+  GNUNET_SCHEDULER_add_shutdown (&cleanup, cls);
   if (ipv4_pt || ipv6_pt)
   {
-    dns_post_handle 
-      = GNUNET_DNS_connect (cfg, 
+    dns_post_handle
+      = GNUNET_DNS_connect (cfg,
                            GNUNET_DNS_FLAG_POST_RESOLUTION,
-                           &dns_post_request_handler, NULL);
-    if (NULL == dns_post_handle)       
+                           &dns_post_request_handler,
+                            NULL);
+    if (NULL == dns_post_handle)
     {
       GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                  _("Failed to connect to %s service.  Exiting.\n"),
@@ -913,18 +1230,14 @@ run (void *cls, char *const *args GNUNET_UNUSED,
       return;
     }
   }
-  if (dns_tunnel)
+  if (dns_channel)
   {
-    static struct GNUNET_MESH_MessageHandler mesh_handlers[] = {
-      {&receive_dns_response, GNUNET_MESSAGE_TYPE_VPN_DNS_FROM_INTERNET, 0},
-      {NULL, 0, 0}
-    };
-
-    dns_pre_handle 
-      = GNUNET_DNS_connect (cfg, 
+    dns_pre_handle
+      = GNUNET_DNS_connect (cfg,
                            GNUNET_DNS_FLAG_PRE_RESOLUTION,
-                           &dns_pre_request_handler, NULL);
-    if (NULL == dns_pre_handle)       
+                           &dns_pre_request_handler,
+                            NULL);
+    if (NULL == dns_pre_handle)
     {
       GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                  _("Failed to connect to %s service.  Exiting.\n"),
@@ -932,24 +1245,35 @@ run (void *cls, char *const *args GNUNET_UNUSED,
       GNUNET_SCHEDULER_shutdown ();
       return;
     }
-    mesh_handle = GNUNET_MESH_connect (cfg, NULL, NULL, NULL, // FIXME use end handler
-                                      mesh_handlers, NULL);
-    if (NULL == mesh_handle)
+    cadet_handle = GNUNET_CADET_connect (cfg);
+    if (NULL == cadet_handle)
+    {
+      GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+                 _("Failed to connect to %s service.  Exiting.\n"),
+                 "CADET");
+      GNUNET_SCHEDULER_shutdown ();
+      return;
+    }
+    dht = GNUNET_DHT_connect (cfg, 1);
+    if (NULL == dht)
     {
       GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                  _("Failed to connect to %s service.  Exiting.\n"),
-                 "MESH");
+                 "DHT");
       GNUNET_SCHEDULER_shutdown ();
       return;
     }
-    mesh_tunnel = GNUNET_MESH_tunnel_create (mesh_handle,
-                                             NULL,
-                                             NULL, /* FIXME peer ID*/
-                                             PORT_PT,
-                                             GNUNET_YES,
-                                             GNUNET_NO);
-//     GNUNET_MESH_peer_request_connect_by_type (mesh_tunnel, FIXME use regex
-//                                           GNUNET_APPLICATION_TYPE_INTERNET_RESOLVER); 
+    GNUNET_CRYPTO_hash ("dns",
+                        strlen ("dns"),
+                        &dns_key);
+    dht_get = GNUNET_DHT_get_start (dht,
+                                   GNUNET_BLOCK_TYPE_DNS,
+                                   &dns_key,
+                                   1,
+                                   GNUNET_DHT_RO_DEMULTIPLEX_EVERYWHERE,
+                                   NULL, 0,
+                                   &handle_dht_result,
+                                    NULL);
   }
 }
 
@@ -962,20 +1286,29 @@ run (void *cls, char *const *args GNUNET_UNUSED,
  * @return 0 ok, 1 on error
  */
 int
-main (int argc, char *const *argv)
+main (int argc,
+      char *const *argv)
 {
   static const struct GNUNET_GETOPT_CommandLineOption options[] = {
     GNUNET_GETOPT_OPTION_END
   };
   int ret;
 
-  if (GNUNET_OK != GNUNET_STRINGS_get_utf8_args (argc, argv, &argc, &argv))
+  if (GNUNET_OK != GNUNET_STRINGS_get_utf8_args (argc,
+                                                 argv,
+                                                 &argc,
+                                                 &argv))
     return 2;
   ret = (GNUNET_OK ==
-        GNUNET_PROGRAM_run (argc, argv, "gnunet-daemon-pt",
-                            gettext_noop
-                            ("Daemon to run to perform IP protocol translation to GNUnet"),
-                            options, &run, NULL)) ? 0 : 1;
+        GNUNET_PROGRAM_run (argc,
+                             argv,
+                             "gnunet-daemon-pt",
+                            gettext_noop ("Daemon to run to perform IP protocol translation to GNUnet"),
+                            options,
+                             &run,
+                             NULL))
+    ? 0
+    : 1;
   GNUNET_free ((void*) argv);
   return ret;
 }