- The next_message in the previous round should have the now current_timestamp.
[oweals/gnunet.git] / src / nse / gnunet-service-nse.c
index a0e7923ace61f758316e82d11d310b4515750a78..bf78e23718ed609f5c785d7f432331078e542c9d 100644 (file)
 /**
  * Over how many values do we calculate the weighted average?
  */
-#define HISTORY_SIZE 8
-
-/**
- * Size of the queue to core.
- */
-#define CORE_QUEUE_SIZE 2
+#define HISTORY_SIZE 64
 
 /**
  * Message priority to use.
@@ -109,11 +104,6 @@ static struct GNUNET_BIO_WriteHandle *wh;
 struct NSEPeerEntry
 {
 
-  /**
-   * Pending message for this peer.
-   */
-  struct GNUNET_MessageHeader *pending_message;
-
   /**
    * Core handle for sending messages to this peer.
    */
@@ -135,9 +125,31 @@ struct NSEPeerEntry
    * been taken care of.
    */
   int previous_round;
+
+#if ENABLE_HISTOGRAM
+
+  /**
+   * Amount of messages received from this peer on this round.
+   */
+  unsigned int received_messages;
+
+  /**
+   * Amount of messages transmitted to this peer on this round.
+   */
+  unsigned int transmitted_messages;
+
+  /**
+   * Which size did we tell the peer the network is?
+   */
+  unsigned int last_transmitted_size;
+
+#endif
+
 };
 
 
+GNUNET_NETWORK_STRUCT_BEGIN
+
 /**
  * Network size estimate reply; sent when "this"
  * peer's timer has run out before receiving a
@@ -188,7 +200,7 @@ struct GNUNET_NSE_FloodMessage
    */
   struct GNUNET_CRYPTO_RsaSignature signature;
 };
-
+GNUNET_NETWORK_STRUCT_END
 
 /**
  * Handle to our current configuration.
@@ -303,40 +315,69 @@ static void
 setup_estimate_message (struct GNUNET_NSE_ClientMessage *em)
 {
   unsigned int i;
+  unsigned int j;
   double mean;
   double sum;
   double std_dev;
   double variance;
   double val;
-  double weight;
+  double nsize;
+
+#define WEST 1
+  /* Weighted incremental algorithm for stddev according to West (1979) */
+#if WEST
   double sumweight;
+  double weight;
   double q;
   double r;
   double temp;
-  double nsize;
 
-  /* Weighted incremental algorithm for stddev according to West (1979) */
   mean = 0.0;
   sum = 0.0;
   sumweight = 0.0;
+  variance = 0.0;
   for (i = 0; i < estimate_count; i++)
   {
-    val =
-        htonl (size_estimate_messages
-               [(estimate_index - i +
-                 HISTORY_SIZE) % HISTORY_SIZE].matching_bits);
-    weight = 1;                 /* was: estimate_count + 1 - i; */
+    j = (estimate_index - i + HISTORY_SIZE) % HISTORY_SIZE;
+    val = htonl (size_estimate_messages[j].matching_bits);
+    weight = estimate_count + 1 - i;
 
     temp = weight + sumweight;
     q = val - mean;
     r = q * weight / temp;
-    sum += sumweight * q * r;
     mean += r;
+    sum += sumweight * q * r;
     sumweight = temp;
   }
-  variance = sum / (sumweight - 1.0);
-  GNUNET_assert (variance >= 0);
-  std_dev = sqrt (variance);
+  if (estimate_count > 0)
+    variance = (sum / sumweight) * estimate_count / (estimate_count - 1.0);
+#else
+  /* trivial version for debugging */
+  double vsq;
+
+  /* non-weighted trivial version */
+  sum = 0.0;
+  vsq = 0.0;
+  variance = 0.0;
+  mean = 0.0;
+
+  for (i = 0; i < estimate_count; i++)
+  {
+    j = (estimate_index - i + HISTORY_SIZE) % HISTORY_SIZE;
+    val = htonl (size_estimate_messages[j].matching_bits);
+    sum += val;
+    vsq += val * val;
+  }
+  if (0 != estimate_count)
+  {
+    mean = sum / estimate_count;
+    variance = (vsq - mean * sum) / (estimate_count - 1.0);     // terrible for numerical stability...
+  }
+#endif
+  if (variance >= 0)
+    std_dev = sqrt (variance);
+  else
+    std_dev = variance;         /* must be infinity due to estimate_count == 0 */
   current_std_dev = std_dev;
   current_size_estimate = mean;
 
@@ -344,11 +385,10 @@ setup_estimate_message (struct GNUNET_NSE_ClientMessage *em)
   em->header.type = htons (GNUNET_MESSAGE_TYPE_NSE_ESTIMATE);
   em->reserved = htonl (0);
   em->timestamp = GNUNET_TIME_absolute_hton (GNUNET_TIME_absolute_get ());
-  em->size_estimate = mean - 0.332747;
+  double se = mean - 0.332747;
   nsize = log2 (GNUNET_CONTAINER_multihashmap_size (peers) + 1);
-  if (em->size_estimate < nsize)
-    em->size_estimate = nsize;
-  em->std_deviation = std_dev;
+  em->size_estimate = GNUNET_hton_double (GNUNET_MAX (se, nsize));
+  em->std_deviation = GNUNET_hton_double (std_dev);
   GNUNET_STATISTICS_set (stats, "# nodes in the network (estimate)",
                          (uint64_t) pow (2, mean - 1.0 / 3.0), GNUNET_NO);
 }
@@ -412,15 +452,17 @@ get_delay_randomization (uint32_t matching_bits)
 {
 #if USE_RANDOM_DELAYS
   struct GNUNET_TIME_Relative ret;
+  uint32_t i;
+  double d;
 
-  if (matching_bits == 0)
-    return GNUNET_TIME_UNIT_ZERO;
-  ret.rel_value =
-      GNUNET_CRYPTO_random_u32 (GNUNET_CRYPTO_QUALITY_WEAK,
-                                (uint32_t) (get_matching_bits_delay
-                                            (matching_bits -
-                                             1) / (double) (hop_count_max +
-                                                            1)));
+  d = get_matching_bits_delay (matching_bits);
+  i = (uint32_t) (d / (double) (hop_count_max + 1));
+#if DEBUG_NSE
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+             "Randomizing flood using latencies up to %u ms\n",
+             (unsigned int) i);
+#endif
+  ret.rel_value = GNUNET_CRYPTO_random_u32 (GNUNET_CRYPTO_QUALITY_WEAK, i + 1);
   return ret;
 #else
   return GNUNET_TIME_UNIT_ZERO;
@@ -508,7 +550,7 @@ get_transmit_delay (int round_offset)
  * @param tc scheduler context
  */
 static void
-transmit_task (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc);
+transmit_task_cb (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc);
 
 
 /**
@@ -539,7 +581,7 @@ transmit_ready (void *cls, size_t size, void *buf)
     idx = (idx + HISTORY_SIZE - 1) % HISTORY_SIZE;
     peer_entry->previous_round = GNUNET_YES;
     peer_entry->transmit_task =
-        GNUNET_SCHEDULER_add_delayed (get_transmit_delay (0), &transmit_task,
+        GNUNET_SCHEDULER_add_delayed (get_transmit_delay (0), &transmit_task_cb,
                                       peer_entry);
   }
   if ((ntohl (size_estimate_messages[idx].hop_count) == 0) &&
@@ -550,6 +592,13 @@ transmit_ready (void *cls, size_t size, void *buf)
                               1, GNUNET_NO);
     return 0;
   }
+  if (ntohs (size_estimate_messages[idx].header.size) == 0)
+  {
+    GNUNET_STATISTICS_update (stats,
+                              "# flood messages not generated (lack of history)",
+                              1, GNUNET_NO);
+    return 0;
+  }
 #if DEBUG_NSE
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
               "In round %llu, sending to `%s' estimate with %u bits\n",
@@ -563,9 +612,13 @@ transmit_ready (void *cls, size_t size, void *buf)
     GNUNET_STATISTICS_update (stats, "# flood messages started", 1, GNUNET_NO);
   GNUNET_STATISTICS_update (stats, "# flood messages transmitted", 1,
                             GNUNET_NO);
+#if ENABLE_HISTOGRAM
+  peer_entry->transmitted_messages++;
+  peer_entry->last_transmitted_size = 
+      ntohl(size_estimate_messages[idx].matching_bits);
+#endif
   memcpy (buf, &size_estimate_messages[idx],
           sizeof (struct GNUNET_NSE_FloodMessage));
-  GNUNET_STATISTICS_update (stats, "# flood messages sent", 1, GNUNET_NO);
   return sizeof (struct GNUNET_NSE_FloodMessage);
 }
 
@@ -577,7 +630,7 @@ transmit_ready (void *cls, size_t size, void *buf)
  * @param tc scheduler context
  */
 static void
-transmit_task (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
+transmit_task_cb (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
 {
   struct NSEPeerEntry *peer_entry = cls;
 
@@ -636,9 +689,12 @@ setup_flood_message (unsigned int slot, struct GNUNET_TIME_Absolute ts)
   fm->timestamp = GNUNET_TIME_absolute_hton (ts);
   fm->pkey = my_public_key;
   fm->proof_of_work = my_proof;
-  GNUNET_assert (GNUNET_OK ==
-                 GNUNET_CRYPTO_rsa_sign (my_private_key, &fm->purpose,
-                                         &fm->signature));
+  if (nse_work_required > 0)
+    GNUNET_assert (GNUNET_OK ==
+                   GNUNET_CRYPTO_rsa_sign (my_private_key, &fm->purpose,
+                                           &fm->signature));
+  else
+    memset (&fm->signature, 0, sizeof (fm->signature));
 }
 
 
@@ -667,10 +723,18 @@ schedule_current_round (void *cls, const GNUNET_HashCode * key, void *value)
     GNUNET_SCHEDULER_cancel (peer_entry->transmit_task);
     peer_entry->previous_round = GNUNET_NO;
   }
+#if ENABLE_HISTOGRAM
+  if (peer_entry->received_messages > 1)
+    GNUNET_STATISTICS_update(stats, "# extra messages",
+                             peer_entry->received_messages - 1, GNUNET_NO);
+  peer_entry->transmitted_messages = 0;
+  peer_entry->last_transmitted_size = 0;
+  peer_entry->received_messages = 0;
+#endif
   delay =
       get_transmit_delay ((peer_entry->previous_round == GNUNET_NO) ? -1 : 0);
   peer_entry->transmit_task =
-      GNUNET_SCHEDULER_add_delayed (delay, &transmit_task, peer_entry);
+      GNUNET_SCHEDULER_add_delayed (delay, &transmit_task_cb, peer_entry);
   return GNUNET_OK;
 }
 
@@ -688,6 +752,8 @@ update_flood_message (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
   unsigned int i;
 
   flood_task = GNUNET_SCHEDULER_NO_TASK;
+  if (0 != (tc->reason & GNUNET_SCHEDULER_REASON_SHUTDOWN))
+    return;
   offset = GNUNET_TIME_absolute_get_remaining (next_timestamp);
   if (0 != offset.rel_value)
   {
@@ -702,8 +768,10 @@ update_flood_message (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
   estimate_index = (estimate_index + 1) % HISTORY_SIZE;
   if (estimate_count < HISTORY_SIZE)
     estimate_count++;
-  if (next_timestamp.abs_value ==
-      GNUNET_TIME_absolute_ntoh (next_message.timestamp).abs_value)
+  if ((current_timestamp.abs_value ==
+      GNUNET_TIME_absolute_ntoh (next_message.timestamp).abs_value) &&
+      (get_matching_bits (current_timestamp, &my_identity) >
+      ntohl(next_message.matching_bits)))
   {
     /* we received a message for this round way early, use it! */
     size_estimate_messages[estimate_index] = next_message;
@@ -822,18 +890,8 @@ find_proof (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
       GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Proof of work found: %llu!\n",
                   (unsigned long long) GNUNET_ntohll (counter));
 #endif
-      for (i = 0; i < HISTORY_SIZE; i++)
-        if (ntohl (size_estimate_messages[i].hop_count) == 0)
-        {
-          size_estimate_messages[i].proof_of_work = my_proof;
-          GNUNET_assert (GNUNET_OK ==
-                         GNUNET_CRYPTO_rsa_sign (my_private_key,
-                                                 &size_estimate_messages
-                                                 [i].purpose,
-                                                 &size_estimate_messages
-                                                 [i].signature));
-        }
       write_proof ();
+      setup_flood_message (estimate_index, current_timestamp);
       return;
     }
     counter++;
@@ -854,7 +912,9 @@ find_proof (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
     my_proof = counter;
   }
   proof_task =
-      GNUNET_SCHEDULER_add_delayed (proof_find_delay, &find_proof, NULL);
+      GNUNET_SCHEDULER_add_delayed_with_priority (proof_find_delay,
+                                                 GNUNET_SCHEDULER_PRIORITY_IDLE,
+                                                 &find_proof, NULL);
 }
 
 
@@ -881,11 +941,12 @@ verify_message_crypto (const struct GNUNET_NSE_FloodMessage *incoming_flood)
     GNUNET_break_op (0);
     return GNUNET_NO;
   }
-  if (GNUNET_OK !=
-      GNUNET_CRYPTO_rsa_verify (GNUNET_SIGNATURE_PURPOSE_NSE_SEND,
-                                &incoming_flood->purpose,
-                                &incoming_flood->signature,
-                                &incoming_flood->pkey))
+  if ((nse_work_required > 0) &&
+      (GNUNET_OK !=
+       GNUNET_CRYPTO_rsa_verify (GNUNET_SIGNATURE_PURPOSE_NSE_SEND,
+                                 &incoming_flood->purpose,
+                                 &incoming_flood->signature,
+                                 &incoming_flood->pkey)))
   {
     GNUNET_break_op (0);
     return GNUNET_NO;
@@ -918,8 +979,7 @@ update_flood_times (void *cls, const GNUNET_HashCode * key, void *value)
   {
     /* still stuck in previous round, no point to update, check that
      * we are active here though... */
-    GNUNET_break ((peer_entry->transmit_task != GNUNET_SCHEDULER_NO_TASK) ||
-                  (peer_entry->th != NULL));
+    GNUNET_break (peer_entry->transmit_task != GNUNET_SCHEDULER_NO_TASK);
     return GNUNET_OK;
   }
   if (peer_entry->transmit_task != GNUNET_SCHEDULER_NO_TASK)
@@ -929,7 +989,7 @@ update_flood_times (void *cls, const GNUNET_HashCode * key, void *value)
   }
   delay = get_transmit_delay (0);
   peer_entry->transmit_task =
-      GNUNET_SCHEDULER_add_delayed (delay, &transmit_task, peer_entry);
+      GNUNET_SCHEDULER_add_delayed (delay, &transmit_task_cb, peer_entry);
   return GNUNET_OK;
 }
 
@@ -988,9 +1048,14 @@ handle_p2p_size_estimate (void *cls, const struct GNUNET_PeerIdentity *peer,
     GNUNET_break (0);
     return GNUNET_OK;
   }
+#if ENABLE_HISTOGRAM
+  peer_entry->received_messages++;
+  if (peer_entry->transmitted_messages > 0 && 
+      peer_entry->last_transmitted_size >= matching_bits)
+    GNUNET_STATISTICS_update(stats, "# cross messages", 1, GNUNET_NO);
+#endif
 
   ts = GNUNET_TIME_absolute_ntoh (incoming_flood->timestamp);
-
   if (ts.abs_value == current_timestamp.abs_value)
     idx = estimate_index;
   else if (ts.abs_value ==
@@ -1024,35 +1089,34 @@ handle_p2p_size_estimate (void *cls, const struct GNUNET_PeerIdentity *peer,
       update_network_size_estimate ();
     return GNUNET_OK;
   }
-  if (matching_bits >= ntohl (size_estimate_messages[idx].matching_bits))
+  if (matching_bits == ntohl (size_estimate_messages[idx].matching_bits))
   {
-    /* cancel transmission from us to this peer for this round */
-    if (idx == estimate_index)
+    /* Cancel transmission in the other direction, as this peer clearly has
+       up-to-date information already. Even if we didn't talk to this peer in
+       the previous round, we should no longer send it stale information as it
+       told us about the current round! */
+    peer_entry->previous_round = GNUNET_YES;
+    if (idx != estimate_index)
     {
-      if (peer_entry->previous_round == GNUNET_YES)
-      {
-        /* cancel any activity for current round */
-        if (peer_entry->transmit_task != GNUNET_SCHEDULER_NO_TASK)
-        {
-          GNUNET_SCHEDULER_cancel (peer_entry->transmit_task);
-          peer_entry->transmit_task = GNUNET_SCHEDULER_NO_TASK;
-        }
-        if (peer_entry->th != NULL)
-        {
-          GNUNET_CORE_notify_transmit_ready_cancel (peer_entry->th);
-          peer_entry->th = NULL;
-        }
-      }
+      /* do not transmit information for the previous round to this peer 
+         anymore (but allow current round) */
+      return GNUNET_OK;
     }
-    else
+    /* got up-to-date information for current round, cancel transmission to
+     * this peer altogether */
+    if (GNUNET_SCHEDULER_NO_TASK != peer_entry->transmit_task)
     {
-      /* cancel previous round only */
-      peer_entry->previous_round = GNUNET_YES;
+      GNUNET_SCHEDULER_cancel (peer_entry->transmit_task);
+      peer_entry->transmit_task = GNUNET_SCHEDULER_NO_TASK;
+    }
+    if (peer_entry->th != NULL)
+    {
+      GNUNET_CORE_notify_transmit_ready_cancel (peer_entry->th);
+      peer_entry->th = NULL;
     }
-  }
-  if (matching_bits == ntohl (size_estimate_messages[idx].matching_bits))
     return GNUNET_OK;
-  if (matching_bits <= ntohl (size_estimate_messages[idx].matching_bits))
+  }
+  if (matching_bits < ntohl (size_estimate_messages[idx].matching_bits))
   {
     if ((idx < estimate_index) && (peer_entry->previous_round == GNUNET_YES))
       peer_entry->previous_round = GNUNET_NO;
@@ -1062,7 +1126,7 @@ handle_p2p_size_estimate (void *cls, const struct GNUNET_PeerIdentity *peer,
       if (peer_entry->transmit_task != GNUNET_SCHEDULER_NO_TASK)
         GNUNET_SCHEDULER_cancel (peer_entry->transmit_task);
       peer_entry->transmit_task =
-          GNUNET_SCHEDULER_add_now (&transmit_task, peer_entry);
+          GNUNET_SCHEDULER_add_now (&transmit_task_cb, peer_entry);
     }
     /* Not closer than our most recent message, no need to do work here */
     GNUNET_STATISTICS_update (stats,
@@ -1075,11 +1139,36 @@ handle_p2p_size_estimate (void *cls, const struct GNUNET_PeerIdentity *peer,
     GNUNET_break_op (0);
     return GNUNET_OK;
   }
+  GNUNET_assert (matching_bits >
+                 ntohl (size_estimate_messages[idx].matching_bits));
+  /* cancel transmission from us to this peer for this round */
+  if (idx == estimate_index)
+  {
+      /* cancel any activity for current round */
+      if (peer_entry->transmit_task != GNUNET_SCHEDULER_NO_TASK)
+      {
+        GNUNET_SCHEDULER_cancel (peer_entry->transmit_task);
+        peer_entry->transmit_task = GNUNET_SCHEDULER_NO_TASK;
+      }
+      if (peer_entry->th != NULL)
+      {
+        GNUNET_CORE_notify_transmit_ready_cancel (peer_entry->th);
+        peer_entry->th = NULL;
+      }
+  }
+  else
+  {
+    /* cancel previous round only */
+    peer_entry->previous_round = GNUNET_YES;
+  }
   size_estimate_messages[idx] = *incoming_flood;
   size_estimate_messages[idx].hop_count =
       htonl (ntohl (incoming_flood->hop_count) + 1);
   hop_count_max =
       GNUNET_MAX (ntohl (incoming_flood->hop_count) + 1, hop_count_max);
+  GNUNET_STATISTICS_set (stats,
+                        "# estimated network diameter",
+                        hop_count_max, GNUNET_NO);
 
   /* have a new, better size estimate, inform clients */
   update_network_size_estimate ();
@@ -1113,11 +1202,14 @@ handle_core_connect (void *cls, const struct GNUNET_PeerIdentity *peer,
 #endif
   peer_entry = GNUNET_malloc (sizeof (struct NSEPeerEntry));
   peer_entry->id = *peer;
-  GNUNET_CONTAINER_multihashmap_put (peers, &peer->hashPubKey, peer_entry,
-                                     GNUNET_CONTAINER_MULTIHASHMAPOPTION_UNIQUE_ONLY);
+  GNUNET_assert (GNUNET_OK ==
+                 GNUNET_CONTAINER_multihashmap_put (peers, &peer->hashPubKey,
+                                                    peer_entry,
+                                                    GNUNET_CONTAINER_MULTIHASHMAPOPTION_UNIQUE_ONLY));
   peer_entry->transmit_task =
-      GNUNET_SCHEDULER_add_delayed (get_transmit_delay (-1), &transmit_task,
+      GNUNET_SCHEDULER_add_delayed (get_transmit_delay (-1), &transmit_task_cb,
                                     peer_entry);
+  GNUNET_STATISTICS_update (stats, "# peers", 1, GNUNET_NO);
 }
 
 
@@ -1153,6 +1245,7 @@ handle_core_disconnect (void *cls, const struct GNUNET_PeerIdentity *peer)
     pos->th = NULL;
   }
   GNUNET_free (pos);
+  GNUNET_STATISTICS_update (stats, "# peers", -1, GNUNET_NO);
 }
 
 
@@ -1224,13 +1317,10 @@ core_init (void *cls, struct GNUNET_CORE_Handle *server,
 {
   struct GNUNET_TIME_Absolute now;
   struct GNUNET_TIME_Absolute prev_time;
-  unsigned int i;
 
   if (server == NULL)
   {
-#if DEBUG_NSE
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Connection to core FAILED!\n");
-#endif
+    GNUNET_log (GNUNET_ERROR_TYPE_ERROR, "Connection to core FAILED!\n");
     GNUNET_SCHEDULER_shutdown ();
     return;
   }
@@ -1241,18 +1331,17 @@ core_init (void *cls, struct GNUNET_CORE_Handle *server,
   current_timestamp.abs_value =
       (now.abs_value / gnunet_nse_interval.rel_value) *
       gnunet_nse_interval.rel_value;
-  next_timestamp.abs_value =
-      current_timestamp.abs_value + gnunet_nse_interval.rel_value;
-
-  for (i = 0; i < HISTORY_SIZE; i++)
+  next_timestamp =
+      GNUNET_TIME_absolute_add (current_timestamp, gnunet_nse_interval);
+  estimate_index = HISTORY_SIZE - 1;
+  estimate_count = 0;
+  if (GNUNET_YES == check_proof_of_work (&my_public_key, my_proof))
   {
     prev_time.abs_value =
-        current_timestamp.abs_value - (HISTORY_SIZE - i -
-                                       1) * gnunet_nse_interval.rel_value;
-    setup_flood_message (i, prev_time);
+        current_timestamp.abs_value - gnunet_nse_interval.rel_value;
+    setup_flood_message (estimate_index, prev_time);
+    estimate_count++;
   }
-  estimate_index = HISTORY_SIZE - 1;
-  estimate_count = 2;
   flood_task =
       GNUNET_SCHEDULER_add_delayed (GNUNET_TIME_absolute_get_remaining
                                     (next_timestamp), &update_flood_message,
@@ -1361,8 +1450,7 @@ run (void *cls, struct GNUNET_SERVER_Handle *server,
   nc = GNUNET_SERVER_notification_context_create (server, 1);
   /* Connect to core service and register core handlers */
   coreAPI = GNUNET_CORE_connect (cfg,   /* Main configuration */
-                                 CORE_QUEUE_SIZE,       /* queue size */
-                                 NULL,  /* Closure passed to functions */
+                                 1, NULL,       /* Closure passed to functions */
                                  &core_init,    /* Call core_init once connected */
                                  &handle_core_connect,  /* Handle connects */
                                  &handle_core_disconnect,       /* Handle disconnects */