- Refactor jsonapi into separate module
[oweals/gnunet.git] / src / identity / plugin_rest_identity.c
index 622653b09bb64520f6aeb57e6ef5fa76ac5722e4..b827bfb2bea8309cdf94d75cd4df7e1a88c4e7b6 100644 (file)
@@ -1,6 +1,6 @@
 /*
    This file is part of GNUnet.
-   Copyright (C) 2012-2015 Christian Grothoff (and other contributing authors)
+   Copyright (C) 2012-2015 GNUnet e.V.
 
    GNUnet is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published
 
    You should have received a copy of the GNU General Public License
    along with GNUnet; see the file COPYING.  If not, write to the
-   Free Software Foundation, Inc., 59 Temple Place - Suite 330,
-   Boston, MA 02111-1307, USA.
+   Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+   Boston, MA 02110-1301, USA.
    */
 /**
  * @author Martin Schanzenbach
- * @file namestore/plugin_rest_namestore.c
+ * @file identity/plugin_rest_identity.c
  * @brief GNUnet Namestore REST plugin
  *
  */
 #include "platform.h"
 #include "gnunet_rest_plugin.h"
 #include "gnunet_identity_service.h"
+#include "gnunet_rest_lib.h"
+#include "gnunet_jsonapi_lib.h"
 #include "microhttpd.h"
 #include <jansson.h>
+#include "gnunet_signatures.h"
 
-#define API_NAMESPACE "/identity"
-
-#define EGO_NAMESPACE "/identity/ego"
-
-#define SVC_NAMESPACE "/identity/service"
+/**
+ * REST root namespace
+ */
+#define GNUNET_REST_API_NS_IDENTITY "/identity"
 
+/**
+ * State while collecting all egos
+ */
 #define ID_REST_STATE_INIT 0
 
+/**
+ * Done collecting egos
+ */
 #define ID_REST_STATE_POST_INIT 1
 
+/**
+ * Resource type
+ */
+#define GNUNET_REST_JSONAPI_IDENTITY_EGO "ego"
+
+/**
+ * Name attribute
+ */
+#define GNUNET_REST_JSONAPI_IDENTITY_NAME "name"
+
+/**
+ * Attribute to rename "name" TODO we changed id to the pubkey
+ * so this can be unified with "name"
+ */
+#define GNUNET_REST_JSONAPI_IDENTITY_NEWNAME "newname"
+
+/**
+ * URL parameter to change the subsytem for ego
+ */
+#define GNUNET_REST_JSONAPI_IDENTITY_SUBSYSTEM "subsystem"
+
+
+/**
+ * Error messages
+ */
+#define GNUNET_REST_ERROR_RESOURCE_INVALID "Resource location invalid"
+#define GNUNET_REST_ERROR_NO_DATA "No data"
+
+/**
+ * GNUid token lifetime
+ */
+#define GNUNET_GNUID_TOKEN_EXPIRATION_MICROSECONDS 300000000
+
+/**
+ * The configuration handle
+ */
+const struct GNUNET_CONFIGURATION_Handle *cfg;
+
+/**
+ * HTTP methods allows for this plugin
+ */
+static char* allow_methods;
+
 /**
  * @brief struct returned by the initialization function of the plugin
  */
@@ -48,31 +99,38 @@ struct Plugin
   const struct GNUNET_CONFIGURATION_Handle *cfg;
 };
 
-const struct GNUNET_CONFIGURATION_Handle *cfg;
-
+/**
+ * The ego list
+ */
 struct EgoEntry
 {
   /**
    * DLL
    */
   struct EgoEntry *next;
-  
+
   /**
    * DLL
    */
   struct EgoEntry *prev;
-  
+
   /**
    * Ego Identifier
    */
   char *identifier;
-  
+
   /**
-   * Ego Pkey
+   * Public key string
    */
-  struct GNUNET_CRYPTO_EcdsaPublicKey pk;
+  char *keystring;
+
+  /**
+   * The Ego
+   */
+  struct GNUNET_IDENTITY_Ego *ego;
 };
 
+
 struct RequestHandle
 {
   /**
@@ -84,7 +142,12 @@ struct RequestHandle
    * Ego list
    */
   struct EgoEntry *ego_tail;
-  
+
+  /**
+   * Handle to the rest connection
+   */
+  struct RestConnectionDataHandle *conndata_handle;
+
   /**
    * The processing state
    */
@@ -96,19 +159,19 @@ struct RequestHandle
   struct GNUNET_IDENTITY_Handle *identity_handle;
 
   /**
-   * Desired timeout for the lookup (default is no timeout).
+   * IDENTITY Operation
    */
-  struct GNUNET_TIME_Relative timeout;
+  struct GNUNET_IDENTITY_Operation *op;
 
   /**
-   * ID of a task associated with the resolution process.
+   * Desired timeout for the lookup (default is no timeout).
    */
-  struct GNUNET_SCHEDULER_Task * timeout_task;    
+  struct GNUNET_TIME_Relative timeout;
 
   /**
-   * The root of the received JSON or NULL
+   * ID of a task associated with the resolution process.
    */
-  json_t *json_root;
+  struct GNUNET_SCHEDULER_Task * timeout_task;
 
   /**
    * The plugin result processor
@@ -125,20 +188,15 @@ struct RequestHandle
    */
   char *name;
 
-  /**
-   * The ego set from REST
-   */
-  char *set_ego;
-  
   /**
    * The subsystem set from REST
    */
-  char *set_subsystem;
+  char *subsys;
 
   /**
    * The url
    */
-  const char *url;
+  char *url;
 
   /**
    * The data from the REST request
@@ -150,37 +208,49 @@ struct RequestHandle
    */
   size_t data_size;
 
+  /**
+   * HTTP method
+   */
+  const char* method;
+
+  /**
+   * Error response message
+   */
+  char *emsg;
+
 };
 
+
 /**
  * Cleanup lookup handle
- * @praram handle Handle to clean up
+ * @param handle Handle to clean up
  */
-void
+static void
 cleanup_handle (struct RequestHandle *handle)
 {
   struct EgoEntry *ego_entry;
   struct EgoEntry *ego_tmp;
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
               "Cleaning up\n");
-  if (NULL != handle->json_root)
-    json_decref (handle->json_root);
   if (NULL != handle->name)
     GNUNET_free (handle->name);
   if (NULL != handle->timeout_task)
     GNUNET_SCHEDULER_cancel (handle->timeout_task);
   if (NULL != handle->identity_handle)
     GNUNET_IDENTITY_disconnect (handle->identity_handle);
-  if (NULL != handle->set_subsystem)
-    GNUNET_free (handle->set_subsystem);
-  if (NULL != handle->set_ego)
-    GNUNET_free (handle->set_ego);
+  if (NULL != handle->subsys)
+    GNUNET_free (handle->subsys);
+  if (NULL != handle->url)
+    GNUNET_free (handle->url);
+  if (NULL != handle->emsg)
+    GNUNET_free (handle->emsg);
   for (ego_entry = handle->ego_head;
        NULL != ego_entry;)
   {
     ego_tmp = ego_entry;
     ego_entry = ego_entry->next;
     GNUNET_free (ego_tmp->identifier);
+    GNUNET_free (ego_tmp->keystring);
     GNUNET_free (ego_tmp);
   }
   GNUNET_free (handle);
@@ -188,73 +258,533 @@ cleanup_handle (struct RequestHandle *handle)
 
 
 /**
- * Task run on shutdown.  Cleans up everything.
+ * Task run on errors.  Reports an error and cleans up everything.
  *
- * @param cls unused
- * @param tc scheduler context
+ * @param cls the `struct RequestHandle`
  */
 static void
-do_error (void *cls,
-          const struct GNUNET_SCHEDULER_TaskContext *tc)
+do_error (void *cls)
 {
   struct RequestHandle *handle = cls;
-  handle->proc (handle->proc_cls, NULL, 0, GNUNET_SYSERR);
+  struct MHD_Response *resp;
+  char *json_error;
+
+  GNUNET_asprintf (&json_error,
+                   "{Error while processing request: %s}",
+                   &handle->emsg);
+
+  resp = GNUNET_REST_create_json_response (json_error);
+  handle->proc (handle->proc_cls,
+               resp,
+               MHD_HTTP_BAD_REQUEST);
   cleanup_handle (handle);
+  GNUNET_free (json_error);
 }
 
 
-
-void
-ego_info_response (struct RequestHandle *handle)
+/**
+ * Callback for IDENTITY_get()
+ *
+ * @param cls the RequestHandle
+ * @param ego the Ego found
+ * @param ctx the context
+ * @param name the id of the ego
+ */
+static void
+get_ego_for_subsys (void *cls,
+                    struct GNUNET_IDENTITY_Ego *ego,
+                    void **ctx,
+                    const char *name)
 {
-  const char* egoname;
-  char* keystring;
-  char* result_str;
+  struct RequestHandle *handle = cls;
+  struct GNUNET_JSONAPI_Object *json_object;
+  struct GNUNET_JSONAPI_Resource *json_resource;
   struct EgoEntry *ego_entry;
-  json_t *ego_arr;
-  json_t *ego_json;
+  struct MHD_Response *resp;
+  json_t *name_json;
+  char *result_str;
+
+  json_object = GNUNET_JSONAPI_object_new ();
 
-  if (strlen (EGO_NAMESPACE) > strlen (handle->url))
+  for (ego_entry = handle->ego_head;
+       NULL != ego_entry;
+       ego_entry = ego_entry->next)
   {
-    handle->proc (handle->proc_cls, NULL, 0, GNUNET_SYSERR);
-    cleanup_handle (handle);
-    GNUNET_break (0);
+    if ( (NULL != name) && (0 != strcmp (name, ego_entry->identifier)) )
+      continue;
+    if (NULL == name)
+      continue;
+    json_resource = GNUNET_JSONAPI_resource_new
+      (GNUNET_REST_JSONAPI_IDENTITY_EGO, ego_entry->keystring);
+    name_json = json_string (ego_entry->identifier);
+    GNUNET_JSONAPI_resource_add_attr (json_resource,
+                                           GNUNET_REST_JSONAPI_IDENTITY_NAME,
+                                           name_json);
+    json_decref (name_json);
+    GNUNET_JSONAPI_object_resource_add (json_object, json_resource);
+    break;
+  }
+  if (0 == GNUNET_JSONAPI_object_resource_count (json_object))
+  {
+    GNUNET_JSONAPI_object_delete (json_object);
+    handle->emsg = GNUNET_strdup("No identity matches results!");
+    GNUNET_SCHEDULER_add_now (&do_error, handle);
     return;
   }
-  ego_arr = json_array ();
+  GNUNET_JSONAPI_data_serialize (json_object, &result_str);
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Result %s\n", result_str);
+  resp = GNUNET_REST_create_json_response (result_str);
+  GNUNET_JSONAPI_object_delete (json_object);
+  handle->proc (handle->proc_cls, resp, MHD_HTTP_OK);
+  GNUNET_free (result_str);
+  cleanup_handle (handle);
+}
 
-  egoname = &handle->url[strlen (EGO_NAMESPACE)];
+/**
+ * Create a response with requested ego(s)
+ *
+ * @param con the Rest handle
+ * @param url the requested url
+ * @param cls the request handle
+ */
+static void
+ego_info_response (struct RestConnectionDataHandle *con,
+                   const char *url,
+                   void *cls)
+{
+  const char *egoname;
+  char *result_str;
+  char *subsys_val;
+  char *keystring;
+  struct RequestHandle *handle = cls;
+  struct EgoEntry *ego_entry;
+  struct GNUNET_HashCode key;
+  struct MHD_Response *resp;
+  struct GNUNET_JSONAPI_Object *json_object;
+  struct GNUNET_JSONAPI_Resource *json_resource;
+  json_t *name_str;
 
-  if (strlen (EGO_NAMESPACE) + 1 >= strlen (handle->url))
+  if (GNUNET_NO == GNUNET_REST_namespace_match (handle->url, GNUNET_REST_API_NS_IDENTITY))
   {
-    egoname = NULL;
+    resp = GNUNET_REST_create_json_response (NULL);
+    handle->proc (handle->proc_cls, resp, MHD_HTTP_BAD_REQUEST);
+    cleanup_handle (handle);
+    return;
   }
+  egoname = NULL;
+  keystring = NULL;
+  if (strlen (GNUNET_REST_API_NS_IDENTITY) < strlen (handle->url))
+  {
+    keystring = &handle->url[strlen (GNUNET_REST_API_NS_IDENTITY)+1];
+    //Return all egos
+    for (ego_entry = handle->ego_head;
+         NULL != ego_entry;
+         ego_entry = ego_entry->next)
+    {
+      if ( (NULL != keystring) && (0 != strcmp (keystring, ego_entry->keystring)) )
+        continue;
+      egoname = ego_entry->identifier;
+    }
+  }
+
+  if ( NULL == egoname ) {
+    GNUNET_CRYPTO_hash (GNUNET_REST_JSONAPI_IDENTITY_SUBSYSTEM,
+                        strlen (GNUNET_REST_JSONAPI_IDENTITY_SUBSYSTEM),
+                        &key);
+    if ( GNUNET_YES ==
+         GNUNET_CONTAINER_multihashmap_contains (handle->conndata_handle->url_param_map,
+                                                 &key) )
+    {
+      subsys_val = GNUNET_CONTAINER_multihashmap_get (handle->conndata_handle->url_param_map,
+                                                      &key);
+      if (NULL != subsys_val)
+      {
+        GNUNET_asprintf (&handle->subsys, "%s", subsys_val);
+        GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Looking for %s's ego\n", subsys_val);
+        handle->op = GNUNET_IDENTITY_get (handle->identity_handle,
+                                          handle->subsys,
+                                          &get_ego_for_subsys,
+                                          handle);
+        return;
+      }
+    }
+  }
+
+  json_object = GNUNET_JSONAPI_object_new ();
 
   //Return all egos
-    for (ego_entry = handle->ego_head;
+  for (ego_entry = handle->ego_head;
        NULL != ego_entry;
        ego_entry = ego_entry->next)
   {
     if ( (NULL != egoname) && (0 != strcmp (egoname, ego_entry->identifier)) )
       continue;
-    ego_json = json_object ();
-    keystring = GNUNET_CRYPTO_ecdsa_public_key_to_string (&ego_entry->pk);
-    json_object_set_new (ego_json, "identity", json_string (ego_entry->identifier));
-    json_object_set_new (ego_json, "key", json_string (keystring));
-    json_array_append (ego_arr, ego_json);
-    json_decref (ego_json);
-    GNUNET_free (keystring);
+    json_resource = GNUNET_JSONAPI_resource_new (GNUNET_REST_JSONAPI_IDENTITY_EGO,
+                                                      ego_entry->keystring);
+    name_str = json_string (ego_entry->identifier);
+    GNUNET_JSONAPI_resource_add_attr (
+                                           json_resource,
+                                           GNUNET_REST_JSONAPI_IDENTITY_NAME,
+                                           name_str);
+    json_decref (name_str);
+    GNUNET_JSONAPI_object_resource_add (json_object, json_resource);
   }
-  result_str = json_dumps (ego_arr, JSON_COMPACT);
+  if (0 == GNUNET_JSONAPI_object_resource_count (json_object))
+  {
+    GNUNET_JSONAPI_object_delete (json_object);
+    handle->emsg = GNUNET_strdup ("No identities found!");
+    GNUNET_SCHEDULER_add_now (&do_error, handle);
+    return;
+  }
+  GNUNET_JSONAPI_data_serialize (json_object, &result_str);
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Result %s\n", result_str);
-  json_decref (ego_arr);
-  handle->proc (handle->proc_cls, result_str, strlen (result_str), GNUNET_OK);
+  resp = GNUNET_REST_create_json_response (result_str);
+  GNUNET_JSONAPI_object_delete (json_object);
+  handle->proc (handle->proc_cls, resp, MHD_HTTP_OK);
   GNUNET_free (result_str);
   cleanup_handle (handle);
+}
 
+/**
+ * Processing finished
+ *
+ * @param cls request handle
+ * @param emsg error message
+ */
+static void
+do_finished (void *cls, const char *emsg)
+{
+  struct RequestHandle *handle = cls;
+  struct MHD_Response *resp;
+
+  handle->op = NULL;
+  if (NULL != emsg)
+  {
+    handle->emsg = GNUNET_strdup (emsg);
+    GNUNET_SCHEDULER_add_now (&do_error, handle);
+    return;
+  }
+  resp = GNUNET_REST_create_json_response (NULL);
+  handle->proc (handle->proc_cls, resp, MHD_HTTP_NO_CONTENT);
+  cleanup_handle (handle);
+}
+
+/**
+ * Create a new ego
+ *
+ * @param con rest handle
+ * @param url url
+ * @param cls request handle
+ */
+static void
+ego_create_cont (struct RestConnectionDataHandle *con,
+                 const char *url,
+                 void *cls)
+{
+  struct RequestHandle *handle = cls;
+  struct EgoEntry *ego_entry;
+  struct MHD_Response *resp;
+  struct GNUNET_JSONAPI_Object *json_obj;
+  struct GNUNET_JSONAPI_Resource *json_res;
+  json_t *egoname_json;
+  const char* egoname;
+  char term_data[handle->data_size+1];
+
+  if (strlen (GNUNET_REST_API_NS_IDENTITY) != strlen (handle->url))
+  {
+    handle->emsg = GNUNET_strdup (GNUNET_REST_ERROR_RESOURCE_INVALID);
+    GNUNET_SCHEDULER_add_now (&do_error, handle);
+    return;
+  }
+  if (0 >= handle->data_size)
+  {
+    handle->emsg = GNUNET_strdup (GNUNET_REST_ERROR_NO_DATA);
+    GNUNET_SCHEDULER_add_now (&do_error, handle);
+    return;
+  }
+  term_data[handle->data_size] = '\0';
+  memcpy (term_data, handle->data, handle->data_size);
+  json_obj = GNUNET_JSONAPI_object_parse (term_data);
+  if (NULL == json_obj)
+  {
+    GNUNET_SCHEDULER_add_now (&do_error, handle);
+    return;
+  }
+  if (1 != GNUNET_JSONAPI_object_resource_count (json_obj))
+  {
+    GNUNET_JSONAPI_object_delete (json_obj);
+    handle->emsg = GNUNET_strdup ("Provided resource count invalid");
+    GNUNET_SCHEDULER_add_now (&do_error, handle);
+    return;
+  }
+  json_res = GNUNET_JSONAPI_object_get_resource (json_obj, 0);
+  if (GNUNET_NO == GNUNET_JSONAPI_resource_check_type (json_res, GNUNET_REST_JSONAPI_IDENTITY_EGO))
+  {
+    GNUNET_JSONAPI_object_delete (json_obj);
+    resp = GNUNET_REST_create_json_response (NULL);
+    handle->proc (handle->proc_cls, resp, MHD_HTTP_CONFLICT);
+    cleanup_handle (handle);
+    return;
+  }
+  egoname_json = GNUNET_JSONAPI_resource_read_attr (json_res, GNUNET_REST_JSONAPI_IDENTITY_NAME);
+  if (!json_is_string (egoname_json))
+  {
+    GNUNET_JSONAPI_object_delete (json_obj);
+    handle->emsg = GNUNET_strdup ("No name provided");
+    GNUNET_SCHEDULER_add_now (&do_error, handle);
+    return;
+  }
+  egoname = json_string_value (egoname_json);
+  for (ego_entry = handle->ego_head;
+       NULL != ego_entry;
+       ego_entry = ego_entry->next)
+  {
+    if (0 == strcasecmp (egoname, ego_entry->identifier))
+    {
+      GNUNET_JSONAPI_object_delete (json_obj);
+      resp = GNUNET_REST_create_json_response (NULL);
+      handle->proc (handle->proc_cls, resp, MHD_HTTP_CONFLICT);
+      cleanup_handle (handle);
+      return;
+    }
+  }
+  GNUNET_asprintf (&handle->name, "%s", egoname);
+  GNUNET_JSONAPI_object_delete (json_obj);
+  handle->op = GNUNET_IDENTITY_create (handle->identity_handle,
+                                       handle->name,
+                                       &do_finished,
+                                       handle);
 }
 
 
+/**
+ * Handle ego edit request
+ *
+ * @param con rest connection handle
+ * @param url the url that is requested
+ * @param cls the RequestHandle
+ */
+static void
+ego_edit_cont (struct RestConnectionDataHandle *con,
+               const char *url,
+               void *cls)
+{
+  struct GNUNET_JSONAPI_Object *json_obj;
+  struct GNUNET_JSONAPI_Resource *json_res;
+  struct RequestHandle *handle = cls;
+  struct EgoEntry *ego_entry;
+  struct MHD_Response *resp;
+  json_t *subsys_json;
+  json_t *name_json;
+  const char *keystring;
+  const char *subsys;
+  const char *newname;
+  char term_data[handle->data_size+1];
+  int ego_exists = GNUNET_NO;
+
+  if (strlen (GNUNET_REST_API_NS_IDENTITY) > strlen (handle->url))
+  {
+    handle->emsg = GNUNET_strdup (GNUNET_REST_ERROR_RESOURCE_INVALID);
+    GNUNET_SCHEDULER_add_now (&do_error, handle);
+    return;
+  }
+
+  keystring = &handle->url[strlen(GNUNET_REST_API_NS_IDENTITY)+1];
+
+  for (ego_entry = handle->ego_head;
+       NULL != ego_entry;
+       ego_entry = ego_entry->next)
+  {
+    if (0 != strcasecmp (keystring, ego_entry->keystring))
+      continue;
+    ego_exists = GNUNET_YES;
+    break;
+  }
+
+  if (GNUNET_NO == ego_exists)
+  {
+    resp = GNUNET_REST_create_json_response (NULL);
+    handle->proc (handle->proc_cls, resp, MHD_HTTP_NOT_FOUND);
+    cleanup_handle (handle);
+    return;
+  }
+
+  if (0 >= handle->data_size)
+  {
+    handle->emsg = GNUNET_strdup (GNUNET_REST_ERROR_NO_DATA);
+    GNUNET_SCHEDULER_add_now (&do_error, handle);
+    return;
+  }
+
+  term_data[handle->data_size] = '\0';
+  memcpy (term_data, handle->data, handle->data_size);
+  json_obj = GNUNET_JSONAPI_object_parse (term_data);
+
+  if (NULL == json_obj)
+  {
+    handle->emsg = GNUNET_strdup ("Data invalid");
+    GNUNET_SCHEDULER_add_now (&do_error, handle);
+    return;
+  }
+
+  if (1 != GNUNET_JSONAPI_object_resource_count (json_obj))
+  {
+    GNUNET_JSONAPI_object_delete (json_obj);
+    handle->emsg = GNUNET_strdup ("Resource amount invalid");
+    GNUNET_SCHEDULER_add_now (&do_error, handle);
+    return;
+  }
+  json_res = GNUNET_JSONAPI_object_get_resource (json_obj, 0);
+
+  if (GNUNET_NO == GNUNET_JSONAPI_resource_check_type (json_res, GNUNET_REST_JSONAPI_IDENTITY_EGO))
+  {
+    GNUNET_JSONAPI_object_delete (json_obj);
+    handle->emsg = GNUNET_strdup ("Resource type invalid");
+    GNUNET_SCHEDULER_add_now (&do_error, handle);
+    return;
+  }
+
+  //This is a rename
+  name_json = GNUNET_JSONAPI_resource_read_attr (json_res,
+                                                      GNUNET_REST_JSONAPI_IDENTITY_NEWNAME);
+  if ((NULL != name_json) && json_is_string (name_json))
+  {
+    newname = json_string_value (name_json);
+    for (ego_entry = handle->ego_head;
+         NULL != ego_entry;
+         ego_entry = ego_entry->next)
+    {
+      if (0 == strcasecmp (newname, ego_entry->identifier) &&
+          0 != strcasecmp (keystring, ego_entry->keystring))
+      {
+        //Ego with same name not allowed
+        GNUNET_JSONAPI_object_delete (json_obj);
+        resp = GNUNET_REST_create_json_response (NULL);
+        handle->proc (handle->proc_cls, resp, MHD_HTTP_CONFLICT);
+        cleanup_handle (handle);
+        return;
+      }
+    }
+    handle->op = GNUNET_IDENTITY_rename (handle->identity_handle,
+                                         ego_entry->identifier,
+                                         newname,
+                                         &do_finished,
+                                         handle);
+    GNUNET_JSONAPI_object_delete (json_obj);
+    return;
+  }
+
+  //Set subsystem
+  subsys_json = GNUNET_JSONAPI_resource_read_attr (json_res, GNUNET_REST_JSONAPI_IDENTITY_SUBSYSTEM);
+  if ( (NULL != subsys_json) && json_is_string (subsys_json))
+  {
+    subsys = json_string_value (subsys_json);
+    GNUNET_asprintf (&handle->subsys, "%s", subsys);
+    GNUNET_JSONAPI_object_delete (json_obj);
+    handle->op = GNUNET_IDENTITY_set (handle->identity_handle,
+                                      handle->subsys,
+                                      ego_entry->ego,
+                                      &do_finished,
+                                      handle);
+    return;
+  }
+  GNUNET_JSONAPI_object_delete (json_obj);
+  handle->emsg = GNUNET_strdup ("Subsystem not provided");
+  GNUNET_SCHEDULER_add_now (&do_error, handle);
+}
+
+void
+ego_delete_cont (struct RestConnectionDataHandle *con_handle,
+                 const char* url,
+                 void *cls)
+{
+  const char *keystring;
+  struct EgoEntry *ego_entry;
+  struct MHD_Response *resp;
+  struct RequestHandle *handle = cls;
+  int ego_exists = GNUNET_NO;
+
+  if (strlen (GNUNET_REST_API_NS_IDENTITY) >= strlen (handle->url))
+  {
+    handle->emsg = GNUNET_strdup (GNUNET_REST_ERROR_RESOURCE_INVALID);
+    GNUNET_SCHEDULER_add_now (&do_error, handle);
+    return;
+  }
+
+  keystring = &handle->url[strlen(GNUNET_REST_API_NS_IDENTITY)+1];
+  for (ego_entry = handle->ego_head;
+       NULL != ego_entry;
+       ego_entry = ego_entry->next)
+  {
+    if (0 != strcasecmp (keystring, ego_entry->keystring))
+      continue;
+    ego_exists = GNUNET_YES;
+    break;
+  }
+  if (GNUNET_NO == ego_exists)
+  {
+    resp = GNUNET_REST_create_json_response (NULL);
+    handle->proc (handle->proc_cls, resp, MHD_HTTP_NOT_FOUND);
+    cleanup_handle (handle);
+    return;
+  }
+  handle->op = GNUNET_IDENTITY_delete (handle->identity_handle,
+                                       ego_entry->identifier,
+                                       &do_finished,
+                                       handle);
+
+}
+
+
+/**
+ * Respond to OPTIONS request
+ *
+ * @param con_handle the connection handle
+ * @param url the url
+ * @param cls the RequestHandle
+ */
+static void
+options_cont (struct RestConnectionDataHandle *con_handle,
+              const char* url,
+              void *cls)
+{
+  struct MHD_Response *resp;
+  struct RequestHandle *handle = cls;
+
+  //For now, independent of path return all options
+  resp = GNUNET_REST_create_json_response (NULL);
+  MHD_add_response_header (resp,
+                           "Access-Control-Allow-Methods",
+                           allow_methods);
+  handle->proc (handle->proc_cls, resp, MHD_HTTP_OK);
+  cleanup_handle (handle);
+  return;
+}
+
+/**
+ * Handle rest request
+ *
+ * @param handle the request handle
+ */
+static void
+init_cont (struct RequestHandle *handle)
+{
+  static const struct GNUNET_REST_RestConnectionHandler handlers[] = {
+    {MHD_HTTP_METHOD_GET, GNUNET_REST_API_NS_IDENTITY, &ego_info_response},
+    {MHD_HTTP_METHOD_POST, GNUNET_REST_API_NS_IDENTITY, &ego_create_cont},
+    {MHD_HTTP_METHOD_PUT, GNUNET_REST_API_NS_IDENTITY, &ego_edit_cont},
+    {MHD_HTTP_METHOD_DELETE, GNUNET_REST_API_NS_IDENTITY, &ego_delete_cont},
+    {MHD_HTTP_METHOD_OPTIONS, GNUNET_REST_API_NS_IDENTITY, &options_cont},
+    GNUNET_REST_HANDLER_END
+  };
+
+  if (GNUNET_NO == GNUNET_REST_handle_request (handle->conndata_handle, handlers, handle))
+  {
+    handle->emsg = GNUNET_strdup ("Request unsupported");
+    GNUNET_SCHEDULER_add_now (&do_error, handle);
+  }
+}
+
 /**
  * If listing is enabled, prints information about the egos.
  *
@@ -287,57 +817,33 @@ ego_info_response (struct RequestHandle *handle)
  * @param identifier identifier assigned by the user for this ego,
  *                   NULL if the user just deleted the ego and it
  *                   must thus no longer be used
-*/
+ */
 static void
 list_ego (void *cls,
-          struct GNUNET_IDENTITY_Ego *ego,
-          void **ctx,
-          const char *identifier)
+          struct GNUNET_IDENTITY_Ego *ego,
+          void **ctx,
+          const char *identifier)
 {
   struct RequestHandle *handle = cls;
   struct EgoEntry *ego_entry;
-  
-  if ( (NULL == handle->set_ego) &&
-       (NULL != ego) &&
-       (NULL != identifier) &&
-       (0 == strcmp (identifier,
-                     handle->set_ego)) )
-  {
-    /*handle->set_op = GNUNET_IDENTITY_set (sh,
-                                          handle->set_subsystem,
-                                          ego,
-                                          &set_done,
-                                          handle);
-    GNUNET_free (handle->set_subsystem);
-    handle->set_subsystem = NULL;
-    GNUNET_free (handle->set_ego); //decref?
-    handle->set_ego = NULL;TODO*/
-  }
-  if ( (NULL == ego) &&
-       (NULL != handle->set_ego) )
-  {
-    GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
-                "Could not set ego to `%s' for subsystem `%s', ego not known\n",
-                handle->set_ego,
-                handle->set_subsystem);
-    GNUNET_free (handle->set_subsystem);
-    handle->set_subsystem = NULL;
-    GNUNET_free (handle->set_ego); //decref?
-    handle->set_ego = NULL;
-  }
+  struct GNUNET_CRYPTO_EcdsaPublicKey pk;
+
   if ((NULL == ego) && (ID_REST_STATE_INIT == handle->state))
   {
-    //TODO all read
     handle->state = ID_REST_STATE_POST_INIT;
-    ego_info_response (handle);
+    init_cont (handle);
     return;
   }
   if (ID_REST_STATE_INIT == handle->state) {
-        ego_entry = GNUNET_new (struct EgoEntry);
-    GNUNET_IDENTITY_ego_get_public_key (ego, &(ego_entry->pk));
+    ego_entry = GNUNET_new (struct EgoEntry);
+    GNUNET_IDENTITY_ego_get_public_key (ego, &pk);
+    ego_entry->keystring =
+      GNUNET_CRYPTO_ecdsa_public_key_to_string (&pk);
+    ego_entry->ego = ego;
     GNUNET_asprintf (&ego_entry->identifier, "%s", identifier);
     GNUNET_CONTAINER_DLL_insert_tail(handle->ego_head,handle->ego_tail, ego_entry);
   }
+
 }
 
 /**
@@ -351,13 +857,10 @@ list_ego (void *cls,
  * @param proc_cls closure for callback function
  * @return GNUNET_OK if request accepted
  */
-void
-rest_identity_process_request(const char *method,
-                               const char *url,
-                               const char *data,
-                               size_t data_size,
-                               GNUNET_REST_ResultProcessor proc,
-                               void *proc_cls)
+static void
+rest_identity_process_request(struct RestConnectionDataHandle *conndata_handle,
+                              GNUNET_REST_ResultProcessor proc,
+                              void *proc_cls)
 {
   struct RequestHandle *handle = GNUNET_new (struct RequestHandle);
 
@@ -368,14 +871,24 @@ rest_identity_process_request(const char *method,
   handle->proc_cls = proc_cls;
   handle->proc = proc;
   handle->state = ID_REST_STATE_INIT;
+  handle->conndata_handle = conndata_handle;
+  handle->data = conndata_handle->data;
+  handle->data_size = conndata_handle->data_size;
+  handle->method = conndata_handle->method;
+  GNUNET_asprintf (&handle->url, "%s", conndata_handle->url);
+  if (handle->url[strlen (handle->url)-1] == '/')
+    handle->url[strlen (handle->url)-1] = '\0';
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
               "Connecting...\n");
-  handle->identity_handle = GNUNET_IDENTITY_connect (cfg, &list_ego, handle); 
-  handle->timeout_task = GNUNET_SCHEDULER_add_delayed (handle->timeout,
-                                                       &do_error, handle);
-  handle->data = data;
-  handle->data_size = data_size;
-  handle->url = url;
+  handle->identity_handle = GNUNET_IDENTITY_connect (cfg,
+                                                     &list_ego,
+                                                     handle);
+  handle->timeout_task =
+    GNUNET_SCHEDULER_add_delayed (handle->timeout,
+                                  &do_error,
+                                  handle);
+
+
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
               "Connected\n");
 }
@@ -390,17 +903,25 @@ void *
 libgnunet_plugin_rest_identity_init (void *cls)
 {
   static struct Plugin plugin;
-  cfg = cls;
   struct GNUNET_REST_Plugin *api;
 
+  cfg = cls;
   if (NULL != plugin.cfg)
     return NULL;                /* can only initialize once! */
   memset (&plugin, 0, sizeof (struct Plugin));
   plugin.cfg = cfg;
   api = GNUNET_new (struct GNUNET_REST_Plugin);
   api->cls = &plugin;
-  api->name = API_NAMESPACE;
+  api->name = GNUNET_REST_API_NS_IDENTITY;
   api->process_request = &rest_identity_process_request;
+  GNUNET_asprintf (&allow_methods,
+                   "%s, %s, %s, %s, %s",
+                   MHD_HTTP_METHOD_GET,
+                   MHD_HTTP_METHOD_POST,
+                   MHD_HTTP_METHOD_PUT,
+                   MHD_HTTP_METHOD_DELETE,
+                   MHD_HTTP_METHOD_OPTIONS);
+
   GNUNET_log (GNUNET_ERROR_TYPE_INFO,
               _("Identity REST API initialized\n"));
   return api;
@@ -420,6 +941,7 @@ libgnunet_plugin_rest_identity_done (void *cls)
   struct Plugin *plugin = api->cls;
 
   plugin->cfg = NULL;
+  GNUNET_free_non_null (allow_methods);
   GNUNET_free (api);
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
               "Identity REST plugin is finished\n");