fix uninit variable causing crash on 0 value
[oweals/gnunet.git] / src / gns / plugin_gnsrecord_gns.c
index 5675599dda2ce4049557b4c102ce09189bdcc199..5faca4578accc258c2cc90d890542fab1c241f66 100644 (file)
@@ -1,6 +1,6 @@
 /*
      This file is part of GNUnet
-     (C) 2013, 2014 Christian Grothoff (and other contributing authors)
+     Copyright (C) 2013, 2014, 2016 GNUnet e.V.
 
      GNUnet is free software; you can redistribute it and/or modify
      it under the terms of the GNU General Public License as published
@@ -14,8 +14,8 @@
 
      You should have received a copy of the GNU General Public License
      along with GNUnet; see the file COPYING.  If not, write to the
-     Free Software Foundation, Inc., 59 Temple Place - Suite 330,
-     Boston, MA 02111-1307, USA.
+     Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+     Boston, MA 02110-1301, USA.
 */
 
 /**
@@ -31,6 +31,7 @@
 #include "gnunet_gnsrecord_lib.h"
 #include "gnunet_dnsparser_lib.h"
 #include "gnunet_gnsrecord_plugin.h"
+#include <inttypes.h>
 
 
 /**
@@ -93,46 +94,76 @@ gns_value_to_string (void *cls,
     }
   case GNUNET_GNSRECORD_TYPE_VPN:
     {
-      const struct GNUNET_TUN_GnsVpnRecord *vpn;
+      struct GNUNET_TUN_GnsVpnRecord vpn;
       char* vpn_str;
 
       cdata = data;
-      if ( (data_size <= sizeof (struct GNUNET_TUN_GnsVpnRecord)) ||
+      if ( (data_size <= sizeof (vpn)) ||
           ('\0' != cdata[data_size - 1]) )
        return NULL; /* malformed */
-      vpn = data;
+      /* need to memcpy for alignment */
+      memcpy (&vpn,
+              data,
+              sizeof (vpn));
       GNUNET_asprintf (&vpn_str,
                        "%u %s %s",
-                       (unsigned int) ntohs (vpn->proto),
-                       (const char*) GNUNET_i2s_full (&vpn->peer),
-                       (const char*) &vpn[1]);
+                       (unsigned int) ntohs (vpn.proto),
+                       (const char*) GNUNET_i2s_full (&vpn.peer),
+                       (const char*) &cdata[sizeof (vpn)]);
       return vpn_str;
     }
   case GNUNET_GNSRECORD_TYPE_BOX:
     {
-      const struct GNUNET_GNSRECORD_BoxRecord *box;
+      struct GNUNET_GNSRECORD_BoxRecord box;
       uint32_t rt;
       char *box_str;
       char *ival;
 
+      cdata = data;
       if (data_size < sizeof (struct GNUNET_GNSRECORD_BoxRecord))
        return NULL; /* malformed */
-      box = data;
-      rt = ntohl (box->record_type);
+      memcpy (&box,
+              data,
+              sizeof (box));
+      rt = ntohl (box.record_type);
       ival = GNUNET_GNSRECORD_value_to_string (rt,
-                                               &box[1],
-                                               data_size - sizeof (struct GNUNET_GNSRECORD_BoxRecord));
+                                               &cdata[sizeof (box)],
+                                               data_size - sizeof (box));
       if (NULL == ival)
         return NULL; /* malformed */
       GNUNET_asprintf (&box_str,
                        "%u %u %u %s",
-                       (unsigned int) ntohs (box->protocol),
-                       (unsigned int) ntohs (box->service),
+                       (unsigned int) ntohs (box.protocol),
+                       (unsigned int) ntohs (box.service),
                        (unsigned int) rt,
                        ival);
       GNUNET_free (ival);
       return box_str;
     }
+  case GNUNET_GNSRECORD_TYPE_REVERSE:
+    {
+      struct GNUNET_GNSRECORD_ReverseRecord rev;
+      char *rev_str;
+      char *pkey_str;
+
+      if (data_size < sizeof (struct GNUNET_GNSRECORD_ReverseRecord))
+        return NULL; /* malformed */
+
+      memcpy (&rev,
+              data,
+              sizeof (rev));
+      cdata = data;
+      pkey_str = GNUNET_CRYPTO_ecdsa_public_key_to_string (&rev.pkey);
+
+      GNUNET_asprintf (&rev_str,
+                       "%s %s %"SCNu64,
+                       &cdata[sizeof (rev)],
+                       pkey_str,
+                       rev.expiration.abs_value_us);
+      GNUNET_free (pkey_str);
+      return rev_str;
+
+    }
   default:
     return NULL;
   }
@@ -164,144 +195,184 @@ gns_string_to_value (void *cls,
   switch (type)
   {
 
-  case GNUNET_GNSRECORD_TYPE_PKEY:
-    if (GNUNET_OK !=
-       GNUNET_CRYPTO_ecdsa_public_key_from_string (s, strlen (s), &pkey))
-    {
-      GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
-           _("Unable to parse PKEY record `%s'\n"),
-           s);
-      return GNUNET_SYSERR;
-    }
-    *data = GNUNET_new (struct GNUNET_CRYPTO_EcdsaPublicKey);
-    memcpy (*data, &pkey, sizeof (pkey));
-    *data_size = sizeof (struct GNUNET_CRYPTO_EcdsaPublicKey);
-    return GNUNET_OK;
-
-  case GNUNET_GNSRECORD_TYPE_NICK:
-    *data = GNUNET_strdup (s);
-    *data_size = strlen (s);
-    return GNUNET_OK;
-  case GNUNET_GNSRECORD_TYPE_LEHO:
-    *data = GNUNET_strdup (s);
-    *data_size = strlen (s);
-    return GNUNET_OK;
-  case GNUNET_GNSRECORD_TYPE_GNS2DNS:
-    {
-      char nsbuf[514];
-      char *cpy;
-      char *at;
-      size_t off;
-
-      cpy = GNUNET_strdup (s);
-      at = strchr (cpy, '@');
-      if (NULL == at)
+    case GNUNET_GNSRECORD_TYPE_PKEY:
+      if (GNUNET_OK !=
+          GNUNET_CRYPTO_ecdsa_public_key_from_string (s, strlen (s), &pkey))
       {
         GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
-                    _("Unable to parse GNS2DNS record `%s'\n"),
+                    _("Unable to parse PKEY record `%s'\n"),
                     s);
-        GNUNET_free (cpy);
         return GNUNET_SYSERR;
       }
-      *at = '\0';
-      at++;
+      *data = GNUNET_new (struct GNUNET_CRYPTO_EcdsaPublicKey);
+      GNUNET_memcpy (*data, &pkey, sizeof (pkey));
+      *data_size = sizeof (struct GNUNET_CRYPTO_EcdsaPublicKey);
+      return GNUNET_OK;
 
-      off = 0;
-      if ( (GNUNET_OK !=
-            GNUNET_DNSPARSER_builder_add_name (nsbuf,
-                                               sizeof (nsbuf),
-                                               &off,
-                                               cpy)) ||
-           (GNUNET_OK !=
-            GNUNET_DNSPARSER_builder_add_name (nsbuf,
-                                               sizeof (nsbuf),
-                                               &off,
-                                               at)) )
+    case GNUNET_GNSRECORD_TYPE_NICK:
+      *data = GNUNET_strdup (s);
+      *data_size = strlen (s);
+      return GNUNET_OK;
+    case GNUNET_GNSRECORD_TYPE_LEHO:
+      *data = GNUNET_strdup (s);
+      *data_size = strlen (s);
+      return GNUNET_OK;
+    case GNUNET_GNSRECORD_TYPE_GNS2DNS:
       {
-       GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
-                    _("Failed to serialize GNS2DNS record with value `%s'\n"),
-                    s);
+        char nsbuf[514];
+        char *cpy;
+        char *at;
+        size_t off;
+
+        cpy = GNUNET_strdup (s);
+        at = strchr (cpy, '@');
+        if (NULL == at)
+        {
+          GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+                      _("Unable to parse GNS2DNS record `%s'\n"),
+                      s);
+          GNUNET_free (cpy);
+          return GNUNET_SYSERR;
+        }
+        *at = '\0';
+        at++;
+
+        off = 0;
+        if ( (GNUNET_OK !=
+              GNUNET_DNSPARSER_builder_add_name (nsbuf,
+                                                 sizeof (nsbuf),
+                                                 &off,
+                                                 cpy)) ||
+             (GNUNET_OK !=
+              GNUNET_DNSPARSER_builder_add_name (nsbuf,
+                                                 sizeof (nsbuf),
+                                                 &off,
+                                                 at)) )
+        {
+          GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+                      _("Failed to serialize GNS2DNS record with value `%s'\n"),
+                      s);
+          GNUNET_free (cpy);
+          return GNUNET_SYSERR;
+        }
         GNUNET_free (cpy);
-       return GNUNET_SYSERR;
+        *data_size = off;
+        *data = GNUNET_malloc (off);
+        GNUNET_memcpy (*data, nsbuf, off);
+        return GNUNET_OK;
       }
-      GNUNET_free (cpy);
-      *data_size = off;
-      *data = GNUNET_malloc (off);
-      memcpy (*data, nsbuf, off);
-      return GNUNET_OK;
-    }
-  case GNUNET_GNSRECORD_TYPE_VPN:
-    {
-      struct GNUNET_TUN_GnsVpnRecord *vpn;
-      char s_peer[103 + 1];
-      char s_serv[253 + 1];
-      unsigned int proto;
-
-      if (3 != SSCANF (s,
-                       "%u %103s %253s",
-                       &proto, s_peer, s_serv))
+    case GNUNET_GNSRECORD_TYPE_VPN:
       {
-        GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
-                    _("Unable to parse VPN record string `%s'\n"),
-                    s);
-        return GNUNET_SYSERR;
+        struct GNUNET_TUN_GnsVpnRecord *vpn;
+        char s_peer[103 + 1];
+        char s_serv[253 + 1];
+        unsigned int proto;
+
+        if (3 != SSCANF (s,
+                         "%u %103s %253s",
+                         &proto, s_peer, s_serv))
+        {
+          GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+                      _("Unable to parse VPN record string `%s'\n"),
+                      s);
+          return GNUNET_SYSERR;
+        }
+        *data_size = sizeof (struct GNUNET_TUN_GnsVpnRecord) + strlen (s_serv) + 1;
+        *data = vpn = GNUNET_malloc (*data_size);
+        if (GNUNET_OK != GNUNET_CRYPTO_eddsa_public_key_from_string ((char*) s_peer,
+                                                                     strlen (s_peer),
+                                                                     &vpn->peer.public_key))
+        {
+          GNUNET_free (vpn);
+          *data_size = 0;
+          return GNUNET_SYSERR;
+        }
+        vpn->proto = htons ((uint16_t) proto);
+        strcpy ((char*)&vpn[1], s_serv);
+        return GNUNET_OK;
       }
-      *data_size = sizeof (struct GNUNET_TUN_GnsVpnRecord) + strlen (s_serv) + 1;
-      *data = vpn = GNUNET_malloc (*data_size);
-      if (GNUNET_OK != GNUNET_CRYPTO_eddsa_public_key_from_string ((char*) s_peer,
-                                                                   strlen (s_peer),
-                                                                   &vpn->peer.public_key))
+    case GNUNET_GNSRECORD_TYPE_BOX:
       {
-        GNUNET_free (vpn);
-        *data_size = 0;
-        return GNUNET_SYSERR;
+        struct GNUNET_GNSRECORD_BoxRecord *box;
+        size_t rest;
+        unsigned int protocol;
+        unsigned int service;
+        unsigned int record_type;
+        void *bval;
+        size_t bval_size;
+
+        if (3 != SSCANF (s,
+                         "%u %u %u ",
+                         &protocol,
+                         &service,
+                         &record_type))
+        {
+          GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+                      _("Unable to parse BOX record string `%s'\n"),
+                      s);
+          return GNUNET_SYSERR;
+        }
+        rest = snprintf (NULL, 0,
+                         "%u %u %u ",
+                         protocol,
+                         service,
+                         record_type);
+        if (GNUNET_OK !=
+            GNUNET_GNSRECORD_string_to_value (record_type,
+                                              &s[rest],
+                                              &bval,
+                                              &bval_size))
+          return GNUNET_SYSERR;
+        *data_size = sizeof (struct GNUNET_GNSRECORD_BoxRecord) + bval_size;
+        *data = box = GNUNET_malloc (*data_size);
+        box->protocol = htons (protocol);
+        box->service = htons (service);
+        box->record_type = htonl (record_type);
+        GNUNET_memcpy (&box[1],
+                       bval,
+                       bval_size);
+        GNUNET_free (bval);
+        return GNUNET_OK;
       }
-      vpn->proto = htons ((uint16_t) proto);
-      strcpy ((char*)&vpn[1], s_serv);
-      return GNUNET_OK;
-    }
-  case GNUNET_GNSRECORD_TYPE_BOX:
-    {
-      struct GNUNET_GNSRECORD_BoxRecord *box;
-      size_t slen = strlen (s) + 1;
-      char rest[slen];
-      unsigned int protocol;
-      unsigned int service;
-      unsigned int record_type;
-      void *bval;
-      size_t bval_size;
-
-      if (4 != SSCANF (s,
-                       "%u %u %u %s",
-                       &protocol,
-                       &service,
-                       &record_type,
-                       rest))
+    case GNUNET_GNSRECORD_TYPE_REVERSE:
       {
-        GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
-                    _("Unable to parse BOX record string `%s'\n"),
-                    s);
-        return GNUNET_SYSERR;
+        struct GNUNET_GNSRECORD_ReverseRecord *rev;
+        char known_by[253 + 1];
+        struct GNUNET_TIME_Absolute expiration;
+
+        /* TODO: From crypto_ecc.c
+         * Why is this not a constant???
+         */
+        size_t enclen = (sizeof (struct GNUNET_CRYPTO_EcdsaPublicKey)) * 8;
+        if (enclen % 5 > 0)
+          enclen += 5 - enclen % 5;
+        enclen /= 5; /* 260/5 = 52 */
+        char pkey_str[enclen + 1];
+
+        if (3 != SSCANF (s,
+                         "%253s %52s %"SCNu64,
+                         known_by,
+                         pkey_str,
+                         &expiration.abs_value_us))
+        {
+          GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+                      _("Unable to parse REVERSE record string `%s'\n"),
+                      s);
+          return GNUNET_SYSERR;
+        }
+        *data_size = sizeof (struct GNUNET_GNSRECORD_ReverseRecord) + strlen (known_by) + 1;
+        *data = rev = GNUNET_malloc (*data_size);
+        GNUNET_CRYPTO_ecdsa_public_key_from_string (pkey_str,
+                                                    strlen (pkey_str),
+                                                    &rev->pkey);
+        rev->expiration = expiration;
+        GNUNET_memcpy (&rev[1],
+                       known_by,
+                       strlen (known_by));
+        return GNUNET_OK;
       }
-      if (GNUNET_OK !=
-          GNUNET_GNSRECORD_string_to_value (record_type,
-                                            rest,
-                                            &bval,
-                                            &bval_size))
-        return GNUNET_SYSERR;
-      *data_size = sizeof (struct GNUNET_GNSRECORD_BoxRecord) + bval_size;
-      *data = box = GNUNET_malloc (*data_size);
-      box->protocol = htons (protocol);
-      box->service = htons (service);
-      box->record_type = htonl (record_type);
-      memcpy (&box[1],
-              bval,
-              bval_size);
-      GNUNET_free (bval);
-      return GNUNET_OK;
-    }
-  default:
-    return GNUNET_SYSERR;
+    default:
+      return GNUNET_SYSERR;
   }
 }
 
@@ -320,6 +391,7 @@ static struct {
   { "VPN", GNUNET_GNSRECORD_TYPE_VPN },
   { "GNS2DNS", GNUNET_GNSRECORD_TYPE_GNS2DNS },
   { "BOX", GNUNET_GNSRECORD_TYPE_BOX },
+  { "REVERSE", GNUNET_GNSRECORD_TYPE_REVERSE },
   { NULL, UINT32_MAX }
 };
 
@@ -338,8 +410,9 @@ gns_typename_to_number (void *cls,
   unsigned int i;
 
   i=0;
-  while ( (gns_name_map[i].name != NULL) &&
-         (0 != strcasecmp (gns_typename, gns_name_map[i].name)) )
+  while ( (NULL != gns_name_map[i].name) &&
+          (0 != strcasecmp (gns_typename,
+                            gns_name_map[i].name)) )
     i++;
   return gns_name_map[i].number;
 }
@@ -359,8 +432,8 @@ gns_number_to_typename (void *cls,
   unsigned int i;
 
   i=0;
-  while ( (gns_name_map[i].name != NULL) &&
-         (type != gns_name_map[i].number) )
+  while ( (NULL != gns_name_map[i].name) &&
+          (type != gns_name_map[i].number) )
     i++;
   return gns_name_map[i].name;
 }