-fix leaks

[oweals/gnunet.git] / src / gns / nss / nss_gns_query.c

diff --git a/src/gns/nss/nss_gns_query.c b/src/gns/nss/nss_gns_query.c
index ab88d22cb2634b4962f0621b2a360a290def1956..b90fd6d0537ea8496202c98205dcaa6beeb4de71 100644 (file)
--- a/src/gns/nss/nss_gns_query.c
+++ b/src/gns/nss/nss_gns_query.c
@@ -1,8 +1,30 @@
+/*
+     This file is part of GNUnet.
+     (C) 2012 Christian Grothoff (and other contributing authors)
+
+     GNUnet is free software; you can redistribute it and/or modify
+     it under the terms of the GNU General Public License as published
+     by the Free Software Foundation; either version 3, or (at your
+     option) any later version.
+
+     GNUnet is distributed in the hope that it will be useful, but
+     WITHOUT ANY WARRANTY; without even the implied warranty of
+     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+     General Public License for more details.
+
+     You should have received a copy of the GNU General Public License
+     along with GNUnet; see the file COPYING.  If not, write to the
+     Free Software Foundation, Inc., 59 Temple Place - Suite 330,
+     Boston, MA 02111-1307, USA.
+*/
 #include <string.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include "nss_gns_query.h"
 #include <arpa/inet.h>
+#include <sys/types.h>
+#include <sys/socket.h>
+#include <netinet/in.h>
 
 
 /**
@@ -14,52 +36,74 @@
  * @param u the userdata (result struct)
  * @return -1 on error else 0
  */
-int gns_resolve_name(int af, const char *name, struct userdata *u)
+int
+gns_resolve_name (int af,
+                 const char *name,
+                 struct userdata *u)
 {
   FILE *p;
   char *cmd;
   char line[128];
 
-  if (af == AF_INET6)
+  if (AF_INET6 == af)
   {
-    if (-1 == asprintf(&cmd, "%s -t AAAA -u %s\n", "gnunet-gns -r", name))
+    if (-1 == asprintf (&cmd,
+                       "%s -t AAAA -u %s\n",
+                       "gnunet-gns -r", name))
       return -1;
   }
   else
   {
-    if (-1 == asprintf(&cmd, "%s %s\n", "gnunet-gns -r -u", name))
+    if (-1 == asprintf (&cmd,
+                       "%s %s\n",
+                       "gnunet-gns -r -u", name))
       return -1;
   }
-
-  p = popen(cmd,"r");
-
-  if (p != NULL )
+  if (NULL == (p = popen (cmd, "r")))
+  {
+    free (cmd);
+    return -1;
+  }
+  while (NULL != fgets (line, sizeof(line), p))
   {
-    while (fgets( line, sizeof(line), p ) != NULL)
+    if (u->count >= MAX_ENTRIES)
+      break;
+    if (line[strlen(line)-1] == '\n')
     {
-
-      if (u->count >= MAX_ENTRIES)
-        break;
-
-      if (line[strlen(line)-1] == '\n')
+      line[strlen(line)-1] = '\0';
+      if (AF_INET == af)
+      {
+       if (inet_pton(af, line, &(u->data.ipv4[u->count])))
+        {
+         u->count++;
+         u->data_len += sizeof(ipv4_address_t);
+       }
+       else
+       {
+         pclose (p);
+         free (cmd);
+         return -1;
+       }
+      }
+      else if (AF_INET6 == af)
       {
-        line[strlen(line)-1] = '\0';
-        if (af == AF_INET)
+       if (inet_pton(af, line, &(u->data.ipv6[u->count])))
         {
-          inet_pton(af, line, &(u->data.ipv4[u->count++]));
-          u->data_len += sizeof(ipv4_address_t);
-        }
-        else if ((af == AF_INET6))
+         u->count++;
+         u->data_len += sizeof(ipv6_address_t);
+       }
+       else
         {
-          inet_pton(af, line, &(u->data.ipv6[u->count++]));
-          u->data_len += sizeof(ipv6_address_t);
-        }
+         pclose (p);
+         free (cmd);
+         return -1;
+       }
       }
     }
   }
-  fclose(p);
-  free(cmd);
-
+  pclose (p);
+  free (cmd);
   return 0;
-
 }
+
+/* end of nss_gns_query.c */