RECLAIM: refactoring; cleanup
[oweals/gnunet.git] / src / gns / gnunet-service-gns.c
index 9f3623e8d2cc6b60d8348a1a0779bdceafd23721..65c232f9374213d2ba73553d7461a140f78c3496 100644 (file)
@@ -1,21 +1,21 @@
 /*
      This file is part of GNUnet.
-     (C) 2011-2013 Christian Grothoff (and other contributing authors)
+     Copyright (C) 2011-2018 GNUnet e.V.
 
-     GNUnet is free software; you can redistribute it and/or modify
-     it under the terms of the GNU General Public License as published
-     by the Free Software Foundation; either version 3, or (at your
-     option) any later version.
+     GNUnet is free software: you can redistribute it and/or modify it
+     under the terms of the GNU Affero General Public License as published
+     by the Free Software Foundation, either version 3 of the License,
+     or (at your option) any later version.
 
      GNUnet is distributed in the hope that it will be useful, but
      WITHOUT ANY WARRANTY; without even the implied warranty of
      MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-     General Public License for more details.
+     Affero General Public License for more details.
 
-     You should have received a copy of the GNU General Public License
-     along with GNUnet; see the file COPYING.  If not, write to the
-     Free Software Foundation, Inc., 59 Temple Place - Suite 330,
-     Boston, MA 02111-1307, USA.
+     You should have received a copy of the GNU Affero General Public License
+     along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+     SPDX-License-Identifier: AGPL3.0-or-later
 */
 /**
  * @file gns/gnunet-service-gns.c
 #include "gnunet_dnsparser_lib.h"
 #include "gnunet_dht_service.h"
 #include "gnunet_namecache_service.h"
-#include "gnunet_namestore_service.h"
+#include "gnunet_gnsrecord_lib.h"
 #include "gnunet_gns_service.h"
 #include "gnunet_statistics_service.h"
 #include "gns.h"
 #include "gnunet-service-gns_resolver.h"
-#include "gnunet-service-gns_shorten.h"
 #include "gnunet-service-gns_interceptor.h"
 #include "gnunet_protocols.h"
 
-/**
- * The initial interval in milliseconds btween puts in
- * a zone iteration
- */
-#define INITIAL_PUT_INTERVAL GNUNET_TIME_UNIT_MILLISECONDS
-
-/**
- * The upper bound for the zone iteration interval in milliseconds
- */
-#define MINIMUM_ZONE_ITERATION_INTERVAL GNUNET_TIME_UNIT_SECONDS
-
-/**
- * The default put interval for the zone iteration. In case
- * no option is found
- */
-#define DEFAULT_ZONE_PUBLISH_TIME_WINDOW GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_HOURS, 4)
-
-/**
- * The factor the current zone iteration interval is divided by for each
- * additional new record
- */
-#define LATE_ITERATION_SPEEDUP_FACTOR 2
-
-/**
- * How long until a DHT PUT attempt should time out?
- */
-#define DHT_OPERATION_TIMEOUT GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_SECONDS, 60)
 
 /**
- * What replication level do we use for DHT PUT operations?
+ * GnsClient prototype
  */
-#define DHT_GNS_REPLICATION_LEVEL 5
-
+struct GnsClient;
 
 /**
- * Handle to a lookup operation from api
+ * Handle to a lookup operation from client via API.
  */
 struct ClientLookupHandle
 {
@@ -89,9 +60,9 @@ struct ClientLookupHandle
   struct ClientLookupHandle *prev;
 
   /**
-   * Handle to the requesting client
+   * Client handle
    */
-  struct GNUNET_SERVER_Client *client;
+  struct GnsClient *gc;
 
   /**
    * Active handle for the lookup.
@@ -107,374 +78,254 @@ struct ClientLookupHandle
 
 
 /**
- * Our handle to the DHT
+ * Information we track per connected client.
  */
-static struct GNUNET_DHT_Handle *dht_handle;
+struct GnsClient
+{
+  /**
+   * The client
+   */
+  struct GNUNET_SERVICE_Client *client;
 
-/**
- * Active DHT put operation (or NULL)
- */
-static struct GNUNET_DHT_PutHandle *active_put;
+  /**
+   * The MQ
  */
+  struct GNUNET_MQ_Handle *mq;
 
-/**
- * Our handle to the namestore service
- */
-static struct GNUNET_NAMESTORE_Handle *namestore_handle;
+  /**
+   * Head of the DLL.
  */
+  struct ClientLookupHandle *clh_head;
 
-/**
- * Our handle to the namecache service
- */
-static struct GNUNET_NAMECACHE_Handle *namecache_handle;
+  /**
+   * Tail of the DLL.
+   */
+  struct ClientLookupHandle *clh_tail;
+};
 
-/**
- * Handle to iterate over our authoritative zone in namestore
- */
-static struct GNUNET_NAMESTORE_ZoneIterator *namestore_iter;
 
 /**
- * Our notification context.
+ * Representation of a TLD, mapping the respective TLD string
+ * (i.e. ".gnu") to the respective public key of the zone.
  */
-static struct GNUNET_SERVER_NotificationContext *nc;
+struct GNS_TopLevelDomain
+{
 
-/**
- * Head of the DLL.
- */
-static struct ClientLookupHandle *clh_head;
+  /**
+   * Kept in a DLL, as there are unlikely enough of these to
+   * warrant a hash map.
+   */
+  struct GNS_TopLevelDomain *next;
+
+  /**
+   * Kept in a DLL, as there are unlikely enough of these to
+   * warrant a hash map.
+   */
+  struct GNS_TopLevelDomain *prev;
+
+  /**
+   * Public key associated with the @a tld.
+   */
+  struct GNUNET_CRYPTO_EcdsaPublicKey pkey;
+
+  /**
+   * Top-level domain as a string, including leading ".".
+   */
+  char *tld;
+
+};
 
-/**
- * Tail of the DLL.
- */
-static struct ClientLookupHandle *clh_tail;
 
 /**
- * Useful for zone update for DHT put
+ * Our handle to the DHT
  */
-static unsigned long long num_public_records;
+static struct GNUNET_DHT_Handle *dht_handle;
 
 /**
- * Last seen record count
+ * Our handle to the namecache service
  */
-static unsigned long long last_num_public_records;
+static struct GNUNET_NAMECACHE_Handle *namecache_handle;
 
 /**
- * Zone iteration PUT interval.
+ * #GNUNET_YES if ipv6 is supported
  */
-static struct GNUNET_TIME_Relative put_interval;
+static int v6_enabled;
 
 /**
- * Time window for zone iteration
+ * #GNUNET_YES if ipv4 is supported
  */
-static struct GNUNET_TIME_Relative zone_publish_time_window;
+static int v4_enabled;
 
 /**
- * zone publish task
+ * Handle to the statistics service
  */
-static GNUNET_SCHEDULER_TaskIdentifier zone_publish_task;
+static struct GNUNET_STATISTICS_Handle *statistics;
 
 /**
- * #GNUNET_YES if zone has never been published before
+ * Head of DLL of TLDs we map to GNS zones.
  */
-static int first_zone_iteration;
+static struct GNS_TopLevelDomain *tld_head;
 
 /**
- * #GNUNET_YES if ipv6 is supported
+ * Tail of DLL of TLDs we map to GNS zones.
  */
-static int v6_enabled;
+static struct GNS_TopLevelDomain *tld_tail;
+
 
 /**
- * #GNUNET_YES if ipv4 is supported
+ * Find GNS zone belonging to TLD @a tld.
+ *
+ * @param tld_str top-level domain to look up
+ * @param[out] pkey public key to set
+ * @return #GNUNET_YES if @a tld was found #GNUNET_NO if not
  */
-static int v4_enabled;
+int
+GNS_find_tld (const char *tld_str,
+              struct GNUNET_CRYPTO_EcdsaPublicKey *pkey)
+{
+  if ('\0' == *tld_str)
+    return GNUNET_NO;
+  for (struct GNS_TopLevelDomain *tld = tld_head;
+       NULL != tld;
+       tld = tld->next)
+  {
+    if (0 == strcasecmp (tld_str,
+                         tld->tld))
+    {
+      *pkey = tld->pkey;
+      return GNUNET_YES;
+    }
+  }
+  if (GNUNET_OK ==
+      GNUNET_GNSRECORD_zkey_to_pkey (tld_str + 1,
+                                     pkey))
+    return GNUNET_YES; /* TLD string *was* the public key */
+  return GNUNET_NO;
+}
+
 
 /**
- * Handle to the statistics service
+ * Obtain the TLD of the given @a name.
+ *
+ * @param name a name
+ * @return the part of @a name after the last ".",
+ *         or @a name if @a name does not contain a "."
  */
-static struct GNUNET_STATISTICS_Handle *statistics;
+const char *
+GNS_get_tld (const char *name)
+{
+  const char *tld;
+
+  tld = strrchr (name,
+                 (unsigned char) '.');
+  if (NULL == tld)
+    tld = name;
+  else
+    tld++; /* skip the '.' */
+  return tld;
+}
 
 
 /**
  * Task run during shutdown.
  *
- * @param cls unused
- * @param tc unused
+ * @param cls unused, NULL
  */
 static void
-shutdown_task (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
+shutdown_task (void *cls)
 {
-  struct ClientLookupHandle *clh;
+  struct GNS_TopLevelDomain *tld;
 
+  (void) cls;
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-             "Shutting down!\n");
-  GNUNET_SERVER_notification_context_destroy (nc);
-  while (NULL != (clh = clh_head))
-  {
-    GNUNET_SERVER_client_set_user_context (clh->client, NULL);
-    GNS_resolver_lookup_cancel (clh->lookup);
-    GNUNET_CONTAINER_DLL_remove (clh_head, clh_tail, clh);
-    GNUNET_free (clh);
-  }
-
+              "Shutting down!\n");
   GNS_interceptor_done ();
   GNS_resolver_done ();
-  GNS_shorten_done ();
   if (NULL != statistics)
   {
-    GNUNET_STATISTICS_destroy (statistics, GNUNET_NO);
+    GNUNET_STATISTICS_destroy (statistics,
+                               GNUNET_NO);
     statistics = NULL;
   }
-  if (GNUNET_SCHEDULER_NO_TASK != zone_publish_task)
-  {
-    GNUNET_SCHEDULER_cancel (zone_publish_task);
-    zone_publish_task = GNUNET_SCHEDULER_NO_TASK;
-  }
-  if (NULL != namestore_iter)
-  {
-    GNUNET_NAMESTORE_zone_iteration_stop (namestore_iter);
-    namestore_iter = NULL;
-  }
-  if (NULL != namestore_handle)
-  {
-    GNUNET_NAMESTORE_disconnect (namestore_handle);
-    namestore_handle = NULL;
-  }
   if (NULL != namecache_handle)
   {
     GNUNET_NAMECACHE_disconnect (namecache_handle);
     namecache_handle = NULL;
   }
-  if (NULL != active_put)
-  {
-    GNUNET_DHT_put_cancel (active_put);
-    active_put = NULL;
-  }
   if (NULL != dht_handle)
   {
     GNUNET_DHT_disconnect (dht_handle);
     dht_handle = NULL;
   }
-}
-
-
-/**
- * Method called periodically that triggers iteration over authoritative records
- *
- * @param cls closure
- * @param tc task context
- */
-static void
-publish_zone_dht_next (void *cls,
-                       const struct GNUNET_SCHEDULER_TaskContext *tc)
-{
-  zone_publish_task = GNUNET_SCHEDULER_NO_TASK;
-  GNUNET_NAMESTORE_zone_iterator_next (namestore_iter);
-}
-
-
-/**
- * Periodically iterate over our zone and store everything in dht
- *
- * @param cls NULL
- * @param tc task context
- */
-static void
-publish_zone_dht_start (void *cls,
-                       const struct GNUNET_SCHEDULER_TaskContext *tc);
-
-
-/**
- * Continuation called from DHT once the PUT operation is done.
- *
- * @param cls closure, NULL
- * @param success #GNUNET_OK on success
- */
-static void
-dht_put_continuation (void *cls,
-                     int success)
-{
-  struct GNUNET_TIME_Relative next_put_interval;
-
-  active_put = NULL;
-  num_public_records++;
-  if ( (num_public_records > last_num_public_records) &&
-       (GNUNET_NO == first_zone_iteration) )
+  while (NULL != (tld = tld_head))
   {
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-               "Last record count was lower than current record count.  Reducing interval.\n");
-    put_interval = GNUNET_TIME_relative_divide (zone_publish_time_window,
-                                               num_public_records);
-    next_put_interval = GNUNET_TIME_relative_divide (put_interval,
-                                                    LATE_ITERATION_SPEEDUP_FACTOR);
+    GNUNET_CONTAINER_DLL_remove (tld_head,
+                                 tld_tail,
+                                 tld);
+    GNUNET_free (tld->tld);
+    GNUNET_free (tld);
   }
-  else
-    next_put_interval = put_interval;
-
-  GNUNET_STATISTICS_set (statistics,
-                        "Current zone iteration interval (ms)",
-                        next_put_interval.rel_value_us / 1000LL,
-                        GNUNET_NO);
-  zone_publish_task = GNUNET_SCHEDULER_add_delayed (next_put_interval,
-                                                   &publish_zone_dht_next,
-                                                   NULL);
 }
 
 
 /**
- * Function used to put all records successively into the DHT.
+ * Called whenever a client is disconnected.
  *
- * @param cls the closure (NULL)
- * @param key the private key of the authority (ours)
- * @param name the name of the records, NULL once the iteration is done
- * @param rd_count the number of records in @a rd
- * @param rd the record data
+ * @param cls closure
+ * @param client identification of the client
+ * @param app_ctx @a client
  */
 static void
-put_gns_record (void *cls,
-                const struct GNUNET_CRYPTO_EcdsaPrivateKey *key,
-                const char *name,
-                unsigned int rd_count,
-                const struct GNUNET_GNSRECORD_Data *rd)
+client_disconnect_cb (void *cls,
+                      struct GNUNET_SERVICE_Client *client,
+                      void *app_ctx)
 {
-  struct GNUNET_GNSRECORD_Block *block;
-  struct GNUNET_HashCode query;
-  struct GNUNET_TIME_Absolute expire;
-  struct GNUNET_TIME_Absolute now;
-  size_t block_size;
-  struct GNUNET_GNSRECORD_Data rd_public[rd_count];
-  unsigned int rd_public_count;
-  unsigned int i;
-
-  if (NULL == name)
-  {
-    /* we're done with one iteration, calculate when to do the next one */
-    namestore_iter = NULL;
-    last_num_public_records = num_public_records;
-    first_zone_iteration = GNUNET_NO;
-    if (0 == num_public_records)
-    {
-      /**
-       * If no records are known (startup) or none present
-       * we can safely set the interval to the value for a single
-       * record
-       */
-      put_interval = zone_publish_time_window;
-      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG | GNUNET_ERROR_TYPE_BULK,
-                 "No records in namestore database.\n");
-    }
-    else
-    {
-      put_interval = GNUNET_TIME_relative_divide (zone_publish_time_window,
-                                                 num_public_records);
-    }
-    put_interval = GNUNET_TIME_relative_max (MINIMUM_ZONE_ITERATION_INTERVAL,
-                                            put_interval);
-
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-               "Zone iteration finished. Adjusted zone iteration interval to %s\n",
-               GNUNET_STRINGS_relative_time_to_string (put_interval, GNUNET_YES));
-    GNUNET_STATISTICS_set (statistics,
-                           "Current zone iteration interval (in ms)",
-                           put_interval.rel_value_us / 1000LL,
-                           GNUNET_NO);
-    GNUNET_STATISTICS_update (statistics,
-                              "Number of zone iterations",
-                             1,
-                             GNUNET_NO);
-    GNUNET_STATISTICS_set (statistics,
-                           "Number of public records in DHT",
-                           last_num_public_records,
-                           GNUNET_NO);
-    if (0 == num_public_records)
-      zone_publish_task = GNUNET_SCHEDULER_add_delayed (put_interval,
-                                                       &publish_zone_dht_start,
-                                                       NULL);
-    else
-      zone_publish_task = GNUNET_SCHEDULER_add_now (&publish_zone_dht_start,
-                                                   NULL);
-    return;
-  }
-
-  /* filter out records that are not public, and convert to
-     absolute expiration time. */
-  rd_public_count = 0;
-  now = GNUNET_TIME_absolute_get ();
-  for (i=0;i<rd_count;i++)
-    if (0 == (rd[i].flags & (GNUNET_GNSRECORD_RF_PRIVATE |
-                            GNUNET_GNSRECORD_RF_PENDING)))
-    {
-      rd_public[rd_public_count] = rd[i];
-      if (0 != (rd[i].flags & GNUNET_GNSRECORD_RF_RELATIVE_EXPIRATION))
-      {
-       rd_public[rd_public_count].flags &= ~GNUNET_GNSRECORD_RF_RELATIVE_EXPIRATION;
-       rd_public[rd_public_count].expiration_time += now.abs_value_us;
-      }
-      rd_public_count++;
-    }
+  struct ClientLookupHandle *clh;
+  struct GnsClient *gc = app_ctx;
 
-  /* We got a set of records to publish */
-  if (0 == rd_public_count)
-  {
-    zone_publish_task = GNUNET_SCHEDULER_add_now (&publish_zone_dht_next,
-                                                   NULL);
-    return;
-  }
-  expire = GNUNET_GNSRECORD_record_get_expiration_time (rd_public_count,
-                                                       rd_public);
-  block = GNUNET_GNSRECORD_block_create (key,
-                                        expire,
-                                        name,
-                                        rd_public,
-                                        rd_public_count);
-  block_size = ntohl (block->purpose.size)
-    + sizeof (struct GNUNET_CRYPTO_EcdsaSignature)
-    + sizeof (struct GNUNET_CRYPTO_EcdsaPublicKey);
-  GNUNET_GNSRECORD_query_from_private_key (key,
-                                          name,
-                                          &query);
-  active_put = GNUNET_DHT_put (dht_handle, &query,
-                              DHT_GNS_REPLICATION_LEVEL,
-                              GNUNET_DHT_RO_DEMULTIPLEX_EVERYWHERE,
-                              GNUNET_BLOCK_TYPE_GNS_NAMERECORD,
-                              block_size,
-                              block,
-                              expire,
-                              DHT_OPERATION_TIMEOUT,
-                              &dht_put_continuation,
-                              NULL);
-  if (NULL == active_put)
+  (void) cls;
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+              "Client %p disconnected\n",
+              client);
+  while (NULL != (clh = gc->clh_head))
   {
-    GNUNET_break (0);
-    dht_put_continuation (NULL, GNUNET_NO);
+    if (NULL != clh->lookup)
+      GNS_resolver_lookup_cancel (clh->lookup);
+    GNUNET_CONTAINER_DLL_remove (gc->clh_head,
+                                 gc->clh_tail,
+                                 clh);
+    GNUNET_free (clh);
   }
-  GNUNET_free (block);
+  GNUNET_free (gc);
 }
 
 
 /**
- * Periodically iterate over our zone and store everything in dht
+ * Add a client to our list of active clients.
  *
  * @param cls NULL
- * @param tc task context
- */
-static void
-publish_zone_dht_start (void *cls,
-                       const struct GNUNET_SCHEDULER_TaskContext *tc)
+ * @param client client to add
+ * @param mq message queue for @a client
+ * @return internal namestore client structure for this client
+ */
+static void *
+client_connect_cb (void *cls,
+                   struct GNUNET_SERVICE_Client *client,
+                   struct GNUNET_MQ_Handle *mq)
 {
-  zone_publish_task = GNUNET_SCHEDULER_NO_TASK;
+  struct GnsClient *gc;
 
+  (void) cls;
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-             "Starting DHT zone update!\n");
-  /* start counting again */
-  num_public_records = 0;
-  namestore_iter = GNUNET_NAMESTORE_zone_iteration_start (namestore_handle,
-                                                         NULL, /* All zones */
-                                                         &put_gns_record,
-                                                         NULL);
+              "Client %p connected\n",
+              client);
+  gc = GNUNET_new (struct GnsClient);
+  gc->client = client;
+  gc->mq = mq;
+  return gc;
 }
 
 
-/* END DHT ZONE PROPAGATION */
-
-
 /**
  * Reply to client with the result from our lookup.
  *
@@ -483,42 +334,81 @@ publish_zone_dht_start (void *cls,
  * @param rd the record data
  */
 static void
-send_lookup_response (voidcls,
-                     uint32_t rd_count,
-                     const struct GNUNET_GNSRECORD_Data *rd)
+send_lookup_response (void *cls,
+                      uint32_t rd_count,
+                      const struct GNUNET_GNSRECORD_Data *rd)
 {
   struct ClientLookupHandle *clh = cls;
-  struct GNUNET_GNS_ClientLookupResultMessage *rmsg;
-  size_t len;
+  struct GnsClient *gc = clh->gc;
+  struct GNUNET_MQ_Envelope *env;
+  struct LookupResultMessage *rmsg;
+  ssize_t len;
 
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-             "Sending `%s' message with %d results\n",
-              "LOOKUP_RESULT",
-             rd_count);
-
-  len = GNUNET_GNSRECORD_records_get_size (rd_count, rd);
-  rmsg = GNUNET_malloc (len + sizeof (struct GNUNET_GNS_ClientLookupResultMessage));
-  rmsg->header.type = htons (GNUNET_MESSAGE_TYPE_GNS_LOOKUP_RESULT);
-  rmsg->header.size = htons (len + sizeof(struct GNUNET_GNS_ClientLookupResultMessage));
+              "Sending LOOKUP_RESULT message with %u results\n",
+              (unsigned int) rd_count);
+  len = GNUNET_GNSRECORD_records_get_size (rd_count,
+                                           rd);
+  if (len < 0)
+  {
+    GNUNET_break (0);
+    GNUNET_SERVICE_client_drop (gc->client);
+    return;
+  }
+  if (len > UINT16_MAX - sizeof (*rmsg))
+  {
+    GNUNET_break (0);
+    GNUNET_SERVICE_client_drop (gc->client);
+    return;
+  }
+  env = GNUNET_MQ_msg_extra (rmsg,
+                             len,
+                             GNUNET_MESSAGE_TYPE_GNS_LOOKUP_RESULT);
   rmsg->id = clh->request_id;
   rmsg->rd_count = htonl (rd_count);
-  GNUNET_GNSRECORD_records_serialize (rd_count, rd, len,
-                                     (char*) &rmsg[1]);
-  GNUNET_SERVER_notification_context_unicast (nc,
-                                             clh->client,
-                                             &rmsg->header,
-                                             GNUNET_NO);
-  GNUNET_free (rmsg);
-  GNUNET_CONTAINER_DLL_remove (clh_head, clh_tail, clh);
-  GNUNET_SERVER_client_set_user_context (clh->client, NULL);
+  GNUNET_assert (len ==
+                 GNUNET_GNSRECORD_records_serialize (rd_count,
+                                                     rd,
+                                                     len,
+                                                     (char*) &rmsg[1]));
+  GNUNET_MQ_send (GNUNET_SERVICE_client_get_mq (gc->client),
+                  env);
+  GNUNET_CONTAINER_DLL_remove (gc->clh_head,
+                               gc->clh_tail,
+                               clh);
   GNUNET_free (clh);
   GNUNET_STATISTICS_update (statistics,
                             "Completed lookups", 1,
-                           GNUNET_NO);
+                            GNUNET_NO);
   GNUNET_STATISTICS_update (statistics,
-                           "Records resolved",
-                           rd_count,
-                           GNUNET_NO);
+                            "Records resolved",
+                            rd_count,
+                            GNUNET_NO);
+}
+
+
+/**
+ * Checks a #GNUNET_MESSAGE_TYPE_GNS_LOOKUP message
+ *
+ * @param cls client sending the message
+ * @param l_msg message of type `struct LookupMessage`
+ * @return #GNUNET_OK if @a l_msg is well-formed
+ */
+static int
+check_lookup (void *cls,
+              const struct LookupMessage *l_msg)
+{
+  size_t nlen;
+
+  (void) cls;
+  GNUNET_MQ_check_zero_termination (l_msg);
+  nlen = ntohs (l_msg->header.size) - sizeof (struct LookupMessage);
+  if (nlen > GNUNET_DNSPARSER_MAX_NAME_LENGTH)
+  {
+    GNUNET_break (0);
+    return GNUNET_SYSERR;
+  }
+  return GNUNET_OK;
 }
 
 
@@ -531,55 +421,35 @@ send_lookup_response (void* cls,
  */
 static void
 handle_lookup (void *cls,
-              struct GNUNET_SERVER_Client *client,
-              const struct GNUNET_MessageHeader *message)
+               const struct LookupMessage *sh_msg)
 {
+  struct GnsClient *gc = cls;
   char name[GNUNET_DNSPARSER_MAX_NAME_LENGTH + 1];
   struct ClientLookupHandle *clh;
   char *nameptr = name;
   const char *utf_in;
-  const struct GNUNET_CRYPTO_EcdsaPrivateKey *key;
-  uint16_t msg_size;
-  const struct GNUNET_GNS_ClientLookupMessage *sh_msg;
 
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-             "Received `%s' message\n",
-             "LOOKUP");
-  msg_size = ntohs (message->size);
-  if (msg_size < sizeof (struct GNUNET_GNS_ClientLookupMessage))
-  {
-    GNUNET_break (0);
-    GNUNET_SERVER_receive_done (client, GNUNET_SYSERR);
-    return;
-  }
-  sh_msg = (const struct GNUNET_GNS_ClientLookupMessage *) message;
-  GNUNET_SERVER_notification_context_add (nc, client);
-  if (GNUNET_YES == ntohs (sh_msg->have_key))
-    key = &sh_msg->shorten_key;
-  else
-    key = NULL;
+  GNUNET_SERVICE_client_continue (gc->client);
   utf_in = (const char *) &sh_msg[1];
-  if ( ('\0' != utf_in[msg_size - sizeof (struct GNUNET_GNS_ClientLookupMessage) - 1]) ||
-       (strlen (utf_in) > GNUNET_DNSPARSER_MAX_NAME_LENGTH) )
-  {
-    GNUNET_break (0);
-    GNUNET_SERVER_receive_done (client, GNUNET_SYSERR);
-    return;
-  }
-  GNUNET_STRINGS_utf8_tolower (utf_in, &nameptr);
-  GNUNET_SERVER_receive_done (client, GNUNET_OK);
-
+  GNUNET_STRINGS_utf8_tolower (utf_in,
+                               nameptr);
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+              "Received LOOKUP `%s' message\n",
+              name);
   clh = GNUNET_new (struct ClientLookupHandle);
-  GNUNET_SERVER_client_set_user_context (client, clh);
-  GNUNET_CONTAINER_DLL_insert (clh_head, clh_tail, clh);
-  clh->client = client;
+  GNUNET_CONTAINER_DLL_insert (gc->clh_head,
+                               gc->clh_tail,
+                               clh);
+  clh->gc = gc;
   clh->request_id = sh_msg->id;
   if ( (GNUNET_DNSPARSER_TYPE_A == ntohl (sh_msg->type)) &&
        (GNUNET_OK != v4_enabled) )
   {
     GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-               "LOOKUP: Query for A record but AF_INET not supported!");
-    send_lookup_response (clh, 0, NULL);
+                "LOOKUP: Query for A record but AF_INET not supported!");
+    send_lookup_response (clh,
+                          0,
+                          NULL);
     return;
   }
   if ( (GNUNET_DNSPARSER_TYPE_AAAA == ntohl (sh_msg->type)) &&
@@ -587,41 +457,61 @@ handle_lookup (void *cls,
   {
     GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                 "LOOKUP: Query for AAAA record but AF_INET6 not supported!");
-    send_lookup_response (clh, 0, NULL);
+    send_lookup_response (clh,
+                          0,
+                          NULL);
     return;
   }
   clh->lookup = GNS_resolver_lookup (&sh_msg->zone,
-                                    ntohl (sh_msg->type),
-                                    name,
-                                    key,
-                                    ntohl (sh_msg->only_cached),
-                                    &send_lookup_response, clh);
+                                     ntohl (sh_msg->type),
+                                     name,
+                                     (enum GNUNET_GNS_LocalOptions) ntohs (sh_msg->options),
+                                     &send_lookup_response, clh);
   GNUNET_STATISTICS_update (statistics,
                             "Lookup attempts",
-                           1, GNUNET_NO);
+                            1, GNUNET_NO);
 }
 
 
 /**
- * One of our clients disconnected, clean up after it.
+ * Reads the configuration and populates TLDs
  *
- * @param cls NULL
- * @param client the client that disconnected
+ * @param cls unused
+ * @param section name of section in config, always "gns"
+ * @param option name of the option, TLDs start with "."
+ * @param value value for the option, public key for TLDs
  */
 static void
-notify_client_disconnect (void *cls,
-                         struct GNUNET_SERVER_Client *client)
+read_service_conf (void *cls,
+                   const char *section,
+                   const char *option,
+                   const char *value)
 {
-  struct ClientLookupHandle *clh;
+  struct GNUNET_CRYPTO_EcdsaPublicKey pk;
+  struct GNS_TopLevelDomain *tld;
 
-  if (NULL == client)
+  (void) cls;
+  (void) section;
+  if (option[0] != '.')
     return;
-  clh = GNUNET_SERVER_client_get_user_context (client, struct ClientLookupHandle);
-  if (NULL == clh)
+  if (GNUNET_OK !=
+      GNUNET_STRINGS_string_to_data (value,
+                                     strlen (value),
+                                     &pk,
+                                     sizeof (pk)))
+  {
+    GNUNET_log_config_invalid (GNUNET_ERROR_TYPE_ERROR,
+                               section,
+                               option,
+                               _("Properly base32-encoded public key required"));
     return;
-  GNS_resolver_lookup_cancel (clh->lookup);
-  GNUNET_CONTAINER_DLL_remove (clh_head, clh_tail, clh);
-  GNUNET_free (clh);
+  }
+  tld = GNUNET_new (struct GNS_TopLevelDomain);
+  tld->tld = GNUNET_strdup (&option[1]);
+  tld->pkey = pk;
+  GNUNET_CONTAINER_DLL_insert (tld_head,
+                               tld_tail,
+                               tld);
 }
 
 
@@ -633,136 +523,84 @@ notify_client_disconnect (void *cls,
  * @param c configuration to use
  */
 static void
-run (void *cls, struct GNUNET_SERVER_Handle *server,
-     const struct GNUNET_CONFIGURATION_Handle *c)
+run (void *cls,
+     const struct GNUNET_CONFIGURATION_Handle *c,
+     struct GNUNET_SERVICE_Handle *service)
 {
-  static const struct GNUNET_SERVER_MessageHandler handlers[] = {
-    { &handle_lookup, NULL, GNUNET_MESSAGE_TYPE_GNS_LOOKUP, 0},
-    {NULL, NULL, 0, 0}
-  };
-  struct GNUNET_CRYPTO_EcdsaPublicKey dns_root;
-  unsigned long long max_parallel_bg_queries = 0;
-  char *dns_root_name;
+  unsigned long long max_parallel_bg_queries = 16;
 
+  GNUNET_CONFIGURATION_iterate_section_values (c,
+                                               "gns",
+                                               &read_service_conf,
+                                               NULL);
   v6_enabled = GNUNET_NETWORK_test_pf (PF_INET6);
   v4_enabled = GNUNET_NETWORK_test_pf (PF_INET);
-
-  namestore_handle = GNUNET_NAMESTORE_connect (c);
-  if (NULL == namestore_handle)
-  {
-    GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
-               _("Failed to connect to the namestore!\n"));
-    GNUNET_SCHEDULER_shutdown ();
-    return;
-  }
   namecache_handle = GNUNET_NAMECACHE_connect (c);
   if (NULL == namecache_handle)
   {
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
-               _("Failed to connect to the namecache!\n"));
+                _("Failed to connect to the namecache!\n"));
     GNUNET_SCHEDULER_shutdown ();
     return;
   }
-
-  put_interval = INITIAL_PUT_INTERVAL;
-  zone_publish_time_window = DEFAULT_ZONE_PUBLISH_TIME_WINDOW;
-
-  if (GNUNET_OK ==
-      GNUNET_CONFIGURATION_get_value_time (c, "gns",
-                                          "ZONE_PUBLISH_TIME_WINDOW",
-                                          &zone_publish_time_window))
-  {
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-               "Time window for zone iteration: %s\n",
-               GNUNET_STRINGS_relative_time_to_string (zone_publish_time_window, GNUNET_YES));
-  }
   if (GNUNET_OK ==
-      GNUNET_CONFIGURATION_get_value_number (c, "gns",
-                                            "MAX_PARALLEL_BACKGROUND_QUERIES",
-                                            &max_parallel_bg_queries))
+      GNUNET_CONFIGURATION_get_value_number (c,
+                                            "gns",
+                                             "MAX_PARALLEL_BACKGROUND_QUERIES",
+                                             &max_parallel_bg_queries))
   {
     GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-               "Number of allowed parallel background queries: %llu\n",
-               max_parallel_bg_queries);
+                "Number of allowed parallel background queries: %llu\n",
+                max_parallel_bg_queries);
   }
-
   dht_handle = GNUNET_DHT_connect (c,
-                                  (unsigned int) max_parallel_bg_queries);
+                                   (unsigned int) max_parallel_bg_queries);
   if (NULL == dht_handle)
   {
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
-               _("Could not connect to DHT!\n"));
-    GNUNET_SCHEDULER_add_now (&shutdown_task, NULL);
+                _("Could not connect to DHT!\n"));
+    GNUNET_SCHEDULER_add_now (&shutdown_task,
+                              NULL);
     return;
   }
-
-  if (GNUNET_OK ==
-      GNUNET_CONFIGURATION_get_value_string (c, "gns", "DNS_ROOT",
-                                            &dns_root_name))
+  GNS_resolver_init (namecache_handle,
+                     dht_handle,
+                     c,
+                     max_parallel_bg_queries);
+  if ( (GNUNET_YES ==
+        GNUNET_CONFIGURATION_get_value_yesno (c,
+                                              "gns",
+                                              "INTERCEPT_DNS")) &&
+       (GNUNET_SYSERR ==
+        GNS_interceptor_init (c)) )
   {
-    if (GNUNET_OK !=
-       GNUNET_CRYPTO_ecdsa_public_key_from_string (dns_root_name,
-                                                 strlen (dns_root_name),
-                                                 &dns_root))
-    {
-      GNUNET_log_config_invalid (GNUNET_ERROR_TYPE_ERROR,
-                                "gns", "DNS_ROOT",
-                                _("valid public key required"));
-      GNUNET_SCHEDULER_add_now (&shutdown_task, NULL);
-      GNUNET_free (dns_root_name);
-      return;
-    }
-    GNUNET_log (GNUNET_ERROR_TYPE_INFO,
-               "DNS hijacking with root `%s' enabled. Connecting to DNS service.\n",
-               dns_root_name);
-    GNUNET_free (dns_root_name);
-    if (GNUNET_SYSERR ==
-       GNS_interceptor_init (&dns_root, c))
-    {
-      GNUNET_SCHEDULER_add_now (&shutdown_task, NULL);
-      return;
-    }
+    GNUNET_break (0);
+    GNUNET_SCHEDULER_add_now (&shutdown_task,
+                              NULL);
+    return;
   }
-  GNS_resolver_init (namestore_handle,
-                     namecache_handle,
-                     dht_handle,
-                    c,
-                    max_parallel_bg_queries);
-  GNS_shorten_init (namestore_handle,
-                    namecache_handle,
-                    dht_handle);
-  GNUNET_SERVER_disconnect_notify (server,
-                                  &notify_client_disconnect,
-                                  NULL);
-  /* Schedule periodic put for our records. */
-  first_zone_iteration = GNUNET_YES;
-  GNUNET_SERVER_add_handlers (server, handlers);
-  statistics = GNUNET_STATISTICS_create ("gns", c);
-  nc = GNUNET_SERVER_notification_context_create (server, 1);
-  zone_publish_task = GNUNET_SCHEDULER_add_now (&publish_zone_dht_start,
-                                               NULL);
-  GNUNET_SCHEDULER_add_delayed (GNUNET_TIME_UNIT_FOREVER_REL,
-                               &shutdown_task, NULL);
+  statistics = GNUNET_STATISTICS_create ("gns",
+                                         c);
+  GNUNET_SCHEDULER_add_shutdown (&shutdown_task,
+                                 NULL);
 }
 
 
 /**
- * The main function for the GNS service.
- *
- * @param argc number of arguments from the command line
- * @param argv command line arguments
- * @return 0 ok, 1 on error
+ * Define "main" method using service macro.
  */
-int
-main (int argc, char *const *argv)
-{
-  int ret;
+GNUNET_SERVICE_MAIN
+("gns",
+ GNUNET_SERVICE_OPTION_NONE,
+ &run,
+ &client_connect_cb,
+ &client_disconnect_cb,
+ NULL,
+ GNUNET_MQ_hd_var_size (lookup,
+                        GNUNET_MESSAGE_TYPE_GNS_LOOKUP,
+                        struct LookupMessage,
+                        NULL),
+ GNUNET_MQ_handler_end());
 
-  ret =
-      (GNUNET_OK ==
-       GNUNET_SERVICE_run (argc, argv, "gns", GNUNET_SERVICE_OPTION_NONE, &run,
-                           NULL)) ? 0 : 1;
-  return ret;
-}
 
 /* end of gnunet-service-gns.c */