-licenses, dce, etc
[oweals/gnunet.git] / src / gns / gnunet-service-gns.c
index 252de1ddd29f666d7dd773cb6907ab5a1819a6a3..5ad0bcf76820c8bc173069a3723ea0a4396db453 100644 (file)
@@ -1,6 +1,6 @@
 /*
      This file is part of GNUnet.
-     (C) 2009, 2010, 2011 Christian Grothoff (and other contributing authors)
+     (C) 2009, 2010, 2011, 2012 Christian Grothoff (and other contributing authors)
 
      GNUnet is free software; you can redistribute it and/or modify
      it under the terms of the GNU General Public License as published
 #include "gnunet_statistics_service.h"
 #include "block_gns.h"
 #include "gns.h"
+#include "gns_common.h"
 #include "gnunet-service-gns_resolver.h"
 #include "gnunet-service-gns_interceptor.h"
-
-
-/* FIXME move to proper header in include */
-#define GNUNET_MESSAGE_TYPE_GNS_LOOKUP 23
-#define GNUNET_MESSAGE_TYPE_GNS_LOOKUP_RESULT 24
-#define GNUNET_MESSAGE_TYPE_GNS_SHORTEN 25
-#define GNUNET_MESSAGE_TYPE_GNS_SHORTEN_RESULT 26
-#define GNUNET_MESSAGE_TYPE_GNS_GET_AUTH 27
-#define GNUNET_MESSAGE_TYPE_GNS_GET_AUTH_RESULT 28
-
+#include "gnunet_protocols.h"
 
 #define INITIAL_ZONE_ITERATION_INTERVAL GNUNET_TIME_UNIT_MILLISECONDS
 #define MINIMUM_ZONE_ITERATION_INTERVAL GNUNET_TIME_UNIT_SECONDS
 #define DEFAULT_RECORD_PUT_INTERVAL GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_HOURS, 4)
 #define LATE_ITERATION_SPEEDUP_FACTOR 2
 
+
 /**
  * Handle to a shorten operation from api
  */
@@ -110,7 +103,7 @@ struct ClientGetAuthHandle
   uint64_t unique_id;
 
   /* name to lookup authority */
-  charname;
+  char *name;
 
 };
 
@@ -140,9 +133,10 @@ struct ClientLookupHandle
   struct GNUNET_CRYPTO_RsaPrivateKey *shorten_key;
 
   /* the name to look up */
-  char* name; //Needed?
+  char *name; 
 };
 
+
 /**
  * Our handle to the DHT
  */
@@ -151,23 +145,18 @@ static struct GNUNET_DHT_Handle *dht_handle;
 /**
  * Our zone's private key
  */
-struct GNUNET_CRYPTO_RsaPrivateKey *zone_key;
+static struct GNUNET_CRYPTO_RsaPrivateKey *zone_key;
 
 /**
  * Our handle to the namestore service
  * FIXME maybe need a second handle for iteration
  */
-struct GNUNET_NAMESTORE_Handle *namestore_handle;
+static struct GNUNET_NAMESTORE_Handle *namestore_handle;
 
 /**
  * Handle to iterate over our authoritative zone in namestore
  */
-struct GNUNET_NAMESTORE_ZoneIterator *namestore_iter;
-
-/**
- * The configuration the GNS service is running with
- */
-const struct GNUNET_CONFIGURATION_Handle *GNS_cfg;
+static struct GNUNET_NAMESTORE_ZoneIterator *namestore_iter;
 
 /**
  * Our notification context.
@@ -177,7 +166,7 @@ static struct GNUNET_SERVER_NotificationContext *nc;
 /**
  * Our zone hash
  */
-struct GNUNET_CRYPTO_ShortHashCode zone_hash;
+static struct GNUNET_CRYPTO_ShortHashCode zone_hash;
 
 /**
  * Useful for zone update for DHT put
@@ -189,13 +178,16 @@ static unsigned long long num_public_records;
  */
 static unsigned long long last_num_public_records;
 
+/**
+ * FIXME!
+ */
 static struct GNUNET_TIME_Relative zone_iteration_interval;
 
 /* dht update interval FIXME define? */
 static struct GNUNET_TIME_Relative record_put_interval;
 
 /* zone update task */
-GNUNET_SCHEDULER_TaskIdentifier zone_update_taskid = GNUNET_SCHEDULER_NO_TASK;
+static GNUNET_SCHEDULER_TaskIdentifier zone_update_taskid;
 
 /* automatic pkey import for name shortening */
 static int auto_import_pkey;
@@ -221,30 +213,6 @@ static struct ClientShortenHandle *csh_tail;
 /* Statistics handle */
 static struct GNUNET_STATISTICS_Handle *statistics;
 
-/**
- * Send shorten response back to client
- * 
- * @param cls the closure containing a client shorten handle
- * @param name the shortened name result or NULL if cannot be shortened
- */
-static void
-send_shorten_response(void* cls, const char* name);
-
-
-/**
- * Continue shutdown
- */
-static void
-on_resolver_cleanup(void)
-{
-  if (NULL != statistics)
-    GNUNET_STATISTICS_destroy (statistics, GNUNET_NO);
-
-  if (NULL != namestore_iter)
-    GNUNET_NAMESTORE_zone_iteration_stop (namestore_iter);
-  GNUNET_NAMESTORE_disconnect(namestore_handle);
-  GNUNET_DHT_disconnect(dht_handle);
-}
 
 /**
  * Task run during shutdown.
@@ -255,41 +223,43 @@ on_resolver_cleanup(void)
 static void
 shutdown_task (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
 {
-  struct ClientShortenHandle *csh_tmp = csh_head;
+  struct ClientShortenHandle *csh_tmp;
 
   GNUNET_log(GNUNET_ERROR_TYPE_DEBUG,
              "Shutting down!");
-  
-  while (csh_tmp != NULL)
+  while (NULL != (csh_tmp = csh_head))
   {
     GNUNET_CONTAINER_DLL_remove (csh_head, csh_tail, csh_tmp);
-    send_shorten_response (csh_tmp, csh_tmp->name);
+    GNUNET_free(csh_tmp);
   }
-  
-  GNUNET_SERVER_notification_context_destroy (nc);
-  
-  gns_interceptor_stop();
-  gns_resolver_cleanup(&on_resolver_cleanup);
-  /* Kill zone task for it may make the scheduler hang */
+  GNUNET_SERVER_notification_context_destroy (nc);  
+  gns_interceptor_stop ();
+  gns_resolver_cleanup ();
+  if (NULL != statistics)
+    GNUNET_STATISTICS_destroy (statistics, GNUNET_NO);
   if (zone_update_taskid != GNUNET_SCHEDULER_NO_TASK)
-    GNUNET_SCHEDULER_cancel(zone_update_taskid);
+    GNUNET_SCHEDULER_cancel (zone_update_taskid);
+  if (NULL != namestore_iter)
+    GNUNET_NAMESTORE_zone_iteration_stop (namestore_iter);
+  GNUNET_NAMESTORE_disconnect(namestore_handle);
+  GNUNET_DHT_disconnect(dht_handle);
 }
 
 
 /**
- * Method called periodicattluy that triggers
- * iteration over root zone
+ * Method called periodically that triggers iteration over authoritative records
  *
  * @param cls closure
  * @param tc task context
  */
 static void
-update_zone_dht_next(void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
+update_zone_dht_next (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
 {
   zone_update_taskid = GNUNET_SCHEDULER_NO_TASK;
   GNUNET_NAMESTORE_zone_iterator_next (namestore_iter);
 }
 
+
 /**
  * Continuation for DHT put
  *
@@ -303,13 +273,15 @@ update_zone_dht_next(void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
 static void
 record_dht_put(void *cls, int success)
 {
-  GNUNET_log(GNUNET_ERROR_TYPE_DEBUG, "put request transmitted\n");
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "put request transmitted\n");
 }
 
+
 /* prototype */
 static void
 update_zone_dht_start(void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc);
 
+
 /**
  * Function used to put all records successively into the DHT.
  *
@@ -329,24 +301,20 @@ put_gns_record(void *cls,
                 unsigned int rd_count,
                 const struct GNUNET_NAMESTORE_RecordData *rd,
                 const struct GNUNET_CRYPTO_RsaSignature *signature)
-{
-  
+{  
   struct GNSNameRecordBlock *nrb;
-  struct GNUNET_CRYPTO_ShortHashCode name_hash;
   struct GNUNET_CRYPTO_ShortHashCode zhash;
-  struct GNUNET_HashCode xor_hash;
-  struct GNUNET_HashCode name_hash_double;
-  struct GNUNET_HashCode zone_hash_double;
+  struct GNUNET_HashCode dht_key;
   uint32_t rd_payload_length;
   char* nrb_data = NULL;
   size_t namelen;
-  struct GNUNET_TIME_Relative next_put_interval;
-
-  
+  struct GNUNET_TIME_Relative next_put_interval; 
 
-  /* we're done */
   if (NULL == name)
   {
+    /* we're done */
+    namestore_iter = NULL;
+    last_num_public_records = num_public_records;
     first_zone_iteration = GNUNET_NO;
     if (0 == num_public_records)
     {
@@ -358,173 +326,136 @@ put_gns_record(void *cls,
       zone_iteration_interval = GNUNET_TIME_relative_divide (record_put_interval,
                                                              1);
 
-      GNUNET_log(GNUNET_ERROR_TYPE_DEBUG,
-                 "No records in db.\n");
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG | GNUNET_ERROR_TYPE_BULK,
+                 "No records in db.\n");
     }
     else
     {
       zone_iteration_interval = GNUNET_TIME_relative_divide (record_put_interval,
                                                              num_public_records);
     }
-
     zone_iteration_interval = GNUNET_TIME_relative_max (MINIMUM_ZONE_ITERATION_INTERVAL,
                                                         zone_iteration_interval);
 
-    GNUNET_log(GNUNET_ERROR_TYPE_DEBUG,
-               "Adjusted zone iteration interval to %llus!\n",
-               zone_iteration_interval.rel_value);
+    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+               "Zone iteration finished. Adjusted zone iteration interval to %s\n",
+               GNUNET_STRINGS_relative_time_to_string (zone_iteration_interval, GNUNET_YES));
     GNUNET_STATISTICS_set (statistics,
-                           "Current zone iteration interval [msec]",
+                           "Current zone iteration interval (in ms)",
                            zone_iteration_interval.rel_value,
                            GNUNET_NO);
-    
-    GNUNET_log(GNUNET_ERROR_TYPE_DEBUG,
-               "Zone iteration finished. Rescheduling zone iteration\n");
-
-    namestore_iter = NULL;
-    if (num_public_records == 0)
-      zone_update_taskid = GNUNET_SCHEDULER_add_delayed (zone_iteration_interval,
-                                                         &update_zone_dht_start,
-                                                         NULL);
-    else
-      zone_update_taskid = GNUNET_SCHEDULER_add_now (&update_zone_dht_start, NULL);
     GNUNET_STATISTICS_update (statistics,
                               "Number of zone iterations", 1, GNUNET_NO);
-
-    last_num_public_records = num_public_records;
     GNUNET_STATISTICS_set (statistics,
                            "Number of public records in DHT",
                            last_num_public_records,
                            GNUNET_NO);
+    if (0 == num_public_records)
+      zone_update_taskid = GNUNET_SCHEDULER_add_delayed (zone_iteration_interval,
+                                                         &update_zone_dht_start,
+                                                         NULL);
+    else
+      zone_update_taskid = GNUNET_SCHEDULER_add_now (&update_zone_dht_start, NULL);
     return;
   }
   
-  namelen = strlen(name) + 1;
-
-  if (rd_count == 0)
+  namelen = strlen (name) + 1;
+  if (0 == rd_count)
   {
-    GNUNET_log(GNUNET_ERROR_TYPE_ERROR,
-               "No records given for name %s! Skipping...\n",
-               name);
+    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+               "No records for name `%s'! Skipping.\n",
+               name);
     zone_update_taskid = GNUNET_SCHEDULER_add_now (&update_zone_dht_next,
                                                    NULL);
     return;
   }
-  
-  if (signature == NULL)
+  if (NULL == signature)
   {
-    GNUNET_log(GNUNET_ERROR_TYPE_ERROR,
-               "No signature for %s record data provided! Skipping...\n",
-               name);
+    GNUNET_break (0);
     zone_update_taskid = GNUNET_SCHEDULER_add_now (&update_zone_dht_next,
                                                    NULL);
     return;
-
   }
   
-  GNUNET_log(GNUNET_ERROR_TYPE_DEBUG,
-             "Putting records for %s into the DHT\n", name);
-  
-  rd_payload_length = GNUNET_NAMESTORE_records_get_size (rd_count, rd);
-  
-  nrb = GNUNET_malloc(rd_payload_length + namelen
-                      + sizeof(struct GNSNameRecordBlock));
-  
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+             "Putting records for `%s' into the DHT\n", name); 
+  rd_payload_length = GNUNET_NAMESTORE_records_get_size (rd_count, rd); 
+  nrb = GNUNET_malloc (rd_payload_length + namelen
+                      + sizeof (struct GNSNameRecordBlock));
   nrb->signature = *signature;
-  
   nrb->public_key = *key;
-
-  nrb->rd_count = htonl(rd_count);
-  
-  memcpy(&nrb[1], name, namelen);
-
-  nrb_data = (char*)&nrb[1];
+  nrb->rd_count = htonl (rd_count);
+  memcpy (&nrb[1], name, namelen);
+  nrb_data = (char *) &nrb[1];
   nrb_data += namelen;
-
   rd_payload_length += sizeof(struct GNSNameRecordBlock) + namelen;
-
+  GNUNET_CRYPTO_short_hash (key,
+                           sizeof (struct GNUNET_CRYPTO_RsaPublicKeyBinaryEncoded),
+                           &zhash);
   if (-1 == GNUNET_NAMESTORE_records_serialize (rd_count,
                                                 rd,
                                                 rd_payload_length,
                                                 nrb_data))
   {
-    GNUNET_log(GNUNET_ERROR_TYPE_ERROR,
-               "Record serialization failed! Skipping...\n");
+    GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+               _("Records for name `%s' in zone %s too large to fit into DHT"),
+               name,
+               GNUNET_short_h2s (&zhash));
     GNUNET_free(nrb);
     zone_update_taskid = GNUNET_SCHEDULER_add_now (&update_zone_dht_next,
                                                    NULL);
     return;
   }
 
-
-  /*
-   * calculate DHT key: H(name) xor H(pubkey)
-   */
-  GNUNET_CRYPTO_short_hash(key,
-                     sizeof(struct GNUNET_CRYPTO_RsaPublicKeyBinaryEncoded),
-                     &zhash);
-  GNUNET_CRYPTO_short_hash(name, strlen(name), &name_hash);
-  GNUNET_CRYPTO_short_hash_double (&name_hash, &name_hash_double);
-  GNUNET_CRYPTO_short_hash_double (&zhash, &zone_hash_double);
-  GNUNET_CRYPTO_hash_xor(&zone_hash_double, &name_hash_double, &xor_hash);
-
-  GNUNET_log(GNUNET_ERROR_TYPE_DEBUG,
-             "zone identity: %s\n", GNUNET_h2s (&zone_hash_double));
-
-  GNUNET_log(GNUNET_ERROR_TYPE_DEBUG,
-             "putting %d records for %s under key: %s with size %d\n",
-             rd_count, name, GNUNET_h2s (&xor_hash), rd_payload_length);
+  GNUNET_GNS_get_key_for_record (name, &zhash, &dht_key);
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+             "putting %u records from zone %s for `%s' under key: %s with size %u and timeout %s\n",
+             rd_count,
+             GNUNET_short_h2s (&zhash),
+             name, 
+             GNUNET_h2s (&dht_key), 
+             (unsigned int) rd_payload_length,
+             GNUNET_STRINGS_relative_time_to_string (DHT_OPERATION_TIMEOUT, GNUNET_YES));
   
-  GNUNET_log(GNUNET_ERROR_TYPE_DEBUG,
-             "DHT req to %d\n", DHT_OPERATION_TIMEOUT.rel_value);
-
   GNUNET_STATISTICS_update (statistics,
                             "Record bytes put into DHT", rd_payload_length, GNUNET_NO);
 
-  /* FIXME: keep return value to possibly cancel? */
-  GNUNET_DHT_put (dht_handle, &xor_hash,
-                  DHT_GNS_REPLICATION_LEVEL,
-                  GNUNET_DHT_RO_NONE,
-                  GNUNET_BLOCK_TYPE_GNS_NAMERECORD,
-                  rd_payload_length,
-                  (char*)nrb,
-                  expiration,
-                  DHT_OPERATION_TIMEOUT,
-                  &record_dht_put,
-                  NULL); //cls for cont
-  
-  num_public_records++;
-  
-  if ((num_public_records > last_num_public_records)
-      && (first_zone_iteration == GNUNET_NO))
+  (void) GNUNET_DHT_put (dht_handle, &dht_key,
+                        DHT_GNS_REPLICATION_LEVEL,
+                        GNUNET_DHT_RO_DEMULTIPLEX_EVERYWHERE,
+                        GNUNET_BLOCK_TYPE_GNS_NAMERECORD,
+                        rd_payload_length,
+                        (char*)nrb,
+                        expiration,
+                        DHT_OPERATION_TIMEOUT,
+                        &record_dht_put,
+                        NULL); 
+  GNUNET_free (nrb);
+
+  num_public_records++;  
+  if ( (num_public_records > last_num_public_records)
+       && (GNUNET_NO == first_zone_iteration) )
   {
+    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+               "Last record count was lower than current record count.  Reducing interval.\n");
     zone_iteration_interval = GNUNET_TIME_relative_divide (record_put_interval,
                                                            num_public_records);
-    GNUNET_log(GNUNET_ERROR_TYPE_DEBUG,
-               "Last record count was lower than current record count... increasing.\n");
     next_put_interval = GNUNET_TIME_relative_divide (zone_iteration_interval,
-                                                 LATE_ITERATION_SPEEDUP_FACTOR);
-
+                                                    LATE_ITERATION_SPEEDUP_FACTOR);
   }
   else
     next_put_interval = zone_iteration_interval;
 
   GNUNET_STATISTICS_set (statistics,
-                            "Current zone iteration interval [msec]",
-                            next_put_interval.rel_value,
-                            GNUNET_NO);
-  
-  /**
-   * Reschedule periodic put
-   */
+                        "Current zone iteration interval (ms)",
+                        next_put_interval.rel_value,
+                        GNUNET_NO); 
   zone_update_taskid = GNUNET_SCHEDULER_add_delayed (next_put_interval,
-                                &update_zone_dht_next,
-                                NULL);
-
-  GNUNET_free(nrb);
-
+                                                    &update_zone_dht_next,
+                                                    NULL);
 }
 
+
 /**
  * Periodically iterate over our zone and store everything in dht
  *
@@ -536,20 +467,21 @@ update_zone_dht_start(void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
 {
   zone_update_taskid = GNUNET_SCHEDULER_NO_TASK;
 
-  GNUNET_log(GNUNET_ERROR_TYPE_DEBUG, "Scheduling DHT zone update!\n");
-  
+  GNUNET_log(GNUNET_ERROR_TYPE_DEBUG, "Scheduling DHT zone update!\n");  
   /* start counting again */
   num_public_records = 0;
   namestore_iter = GNUNET_NAMESTORE_zone_iteration_start (namestore_handle,
-                                                 NULL, //All zones
-                                                 GNUNET_NAMESTORE_RF_AUTHORITY,
-                                                 GNUNET_NAMESTORE_RF_PRIVATE,
-                                                 &put_gns_record,
-                                                 NULL);
+                                                         NULL, /* All zones */
+                                                         GNUNET_NAMESTORE_RF_AUTHORITY,
+                                                         GNUNET_NAMESTORE_RF_PRIVATE,
+                                                         &put_gns_record,
+                                                         NULL);
 }
 
+
 /* END DHT ZONE PROPAGATION */
 
+
 /**
  * Send shorten response back to client
  * 
@@ -557,43 +489,37 @@ update_zone_dht_start(void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
  * @param name the shortened name result or NULL if cannot be shortened
  */
 static void
-send_shorten_response(void* cls, const char* name)
+send_shorten_response (void* cls, const char* name)
 {
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Sending `%s' message with %s\n",
-              "SHORTEN_RESULT", name);
+  struct ClientShortenHandle *csh = cls;
   struct GNUNET_GNS_ClientShortenResultMessage *rmsg;
-  struct ClientShortenHandle *csh = (struct ClientShortenHandle *)cls;
+  size_t name_len;
   
-  if (name == NULL)
-  {
-    name = "";
-  }
-
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Sending `%s' message with %s\n",
+              "SHORTEN_RESULT", name);
+  if (NULL == name)
+    name_len = 0;
+  else
+    name_len = strlen (name) + 1;
   GNUNET_STATISTICS_update (statistics,
                             "Name shorten results", 1, GNUNET_NO);
 
-  rmsg = GNUNET_malloc(sizeof(struct GNUNET_GNS_ClientShortenResultMessage)
-                       + strlen(name) + 1);
+  rmsg = GNUNET_malloc (sizeof (struct GNUNET_GNS_ClientShortenResultMessage) +
+                       name_len);
   
   rmsg->id = csh->unique_id;
   rmsg->header.type = htons(GNUNET_MESSAGE_TYPE_GNS_SHORTEN_RESULT);
   rmsg->header.size = 
     htons(sizeof(struct GNUNET_GNS_ClientShortenResultMessage) +
-          strlen(name) + 1);
-
-  strcpy((char*)&rmsg[1], name);
-
+          name_len);
+  memcpy (&rmsg[1], name, name_len);
   GNUNET_SERVER_notification_context_unicast (nc, csh->client,
-                              (const struct GNUNET_MessageHeader *) rmsg,
-                              GNUNET_NO);
-  GNUNET_SERVER_receive_done (csh->client, GNUNET_OK);
-
+                                             &rmsg->header,
+                                             GNUNET_NO);
   if (NULL != csh->namestore_task)
-    GNUNET_NAMESTORE_cancel (csh->namestore_task);
-  
-  GNUNET_free(rmsg);
-  GNUNET_free(csh);
-
+    GNUNET_NAMESTORE_cancel (csh->namestore_task); 
+  GNUNET_free (rmsg);
+  GNUNET_free (csh);
 }
 
 
@@ -611,18 +537,18 @@ send_shorten_response(void* cls, const char* name)
  */
 static void
 process_shorten_in_private_zone_lookup (void *cls,
-                      const struct GNUNET_CRYPTO_RsaPublicKeyBinaryEncoded *key,
-                      struct GNUNET_TIME_Absolute expiration,
-                      const char *name,
-                      unsigned int rd_count,
-                      const struct GNUNET_NAMESTORE_RecordData *rd,
-                      const struct GNUNET_CRYPTO_RsaSignature *signature)
+                                       const struct GNUNET_CRYPTO_RsaPublicKeyBinaryEncoded *key,
+                                       struct GNUNET_TIME_Absolute expiration,
+                                       const char *name,
+                                       unsigned int rd_count,
+                                       const struct GNUNET_NAMESTORE_RecordData *rd,
+                                       const struct GNUNET_CRYPTO_RsaSignature *signature)
 {
   struct ClientShortenHandle *csh = cls;
-  csh->namestore_task = NULL;
   struct GNUNET_CRYPTO_ShortHashCode *szone = &csh->shorten_zone;
   struct GNUNET_CRYPTO_ShortHashCode *pzone = &csh->private_zone;
 
+  csh->namestore_task = NULL;
   if (0 == strcmp (csh->private_zone_id, ""))
     pzone = NULL;
   
@@ -630,14 +556,11 @@ process_shorten_in_private_zone_lookup (void *cls,
   {
     GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                 "No shorten zone in private zone!\n");
-
     strcpy (csh->shorten_zone_id, "");
     szone = NULL;
-
   }
   else
   {
-
     GNUNET_assert (rd_count == 1);
 
     GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
@@ -682,10 +605,10 @@ process_shorten_in_root_zone_lookup (void *cls,
                       const struct GNUNET_CRYPTO_RsaSignature *signature)
 {
   struct ClientShortenHandle *csh = cls;
-  csh->namestore_task = NULL;
   struct GNUNET_CRYPTO_ShortHashCode *szone = &csh->shorten_zone;
   struct GNUNET_CRYPTO_ShortHashCode *pzone = &csh->private_zone;
   
+  csh->namestore_task = NULL;
   if (0 == strcmp (csh->private_zone_id, ""))
     pzone = NULL;
 
@@ -777,6 +700,7 @@ process_private_in_root_zone_lookup (void *cls,
                                   csh);
 }
 
+
 /**
  * Lookup the zone infos and shorten name
  *
@@ -800,88 +724,87 @@ start_shorten_name (struct ClientShortenHandle *csh)
 /**
  * Handle a shorten message from the api
  *
- * @param cls the closure
+ * @param cls the closure (unused)
  * @param client the client
  * @param message the message
  */
-static void handle_shorten (void *cls,
-                            struct GNUNET_SERVER_Client * client,
-                            const struct GNUNET_MessageHeader * message)
+static void 
+handle_shorten (void *cls,
+               struct GNUNET_SERVER_Client * client,
+               const struct GNUNET_MessageHeader * message)
 {
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Received `%s' message\n", "SHORTEN");
-
-  size_t msg_size = 0;
+  uint16_t msg_size;
+  const struct GNUNET_GNS_ClientShortenMessage *sh_msg;
   struct ClientShortenHandle *csh;
+  const char *utf_in;
   char name[MAX_DNS_NAME_LENGTH];
   char* nameptr = name;
 
-  if (ntohs (message->size) < sizeof (struct GNUNET_GNS_ClientShortenMessage))
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Received `%s' message\n", "SHORTEN");
+  msg_size = ntohs (message->size);
+  if (msg_size < sizeof (struct GNUNET_GNS_ClientShortenMessage))
   {
-    GNUNET_break_op (0);
-    GNUNET_SERVER_receive_done (client, GNUNET_OK);
+    GNUNET_break (0);
+    GNUNET_SERVER_receive_done (client, GNUNET_SYSERR);
     return;
   }
-
-
-  struct GNUNET_GNS_ClientShortenMessage *sh_msg =
-    (struct GNUNET_GNS_ClientShortenMessage *) message;
-  
-  msg_size = ntohs(message->size);
-
-  if (msg_size > GNUNET_SERVER_MAX_MESSAGE_SIZE)
+  sh_msg = (const struct GNUNET_GNS_ClientShortenMessage *) message;
+  utf_in = (const char *) &sh_msg[1];
+  if ('\0' != utf_in[msg_size - sizeof (struct GNUNET_GNS_ClientShortenMessage) - 1])
   {
-    GNUNET_break_op (0);
-    GNUNET_SERVER_receive_done (client, GNUNET_OK);
+    GNUNET_break (0);
+    GNUNET_SERVER_receive_done (client, GNUNET_SYSERR);
     return;
   }
-
-  csh = GNUNET_malloc(sizeof(struct ClientShortenHandle));
+  csh = GNUNET_malloc (sizeof (struct ClientShortenHandle));
   csh->client = client;
   csh->unique_id = sh_msg->id;
-
-  GNUNET_CONTAINER_DLL_insert (csh_head, csh_tail, csh);
-  
-  GNUNET_STRINGS_utf8_tolower((char*)&sh_msg[1], &nameptr);
-
-  if (strlen (name) < strlen(GNUNET_GNS_TLD)) {
+  GNUNET_CONTAINER_DLL_insert (csh_head, csh_tail, csh); 
+  GNUNET_STRINGS_utf8_tolower (utf_in, &nameptr);
+  GNUNET_log(GNUNET_ERROR_TYPE_DEBUG,
+               "SHORTEN: Converted `%s' to `%s'\n", 
+            utf_in, 
+            nameptr);
+  GNUNET_SERVER_notification_context_add (nc, client);  
+  if (strlen (name) < strlen (GNUNET_GNS_TLD)) 
+  {
     GNUNET_log(GNUNET_ERROR_TYPE_DEBUG,
-               "SHORTEN: %s is too short", name);
+               "SHORTEN: %s is too short\n", name);
+    GNUNET_CONTAINER_DLL_remove (csh_head, csh_tail, csh);
     send_shorten_response(csh, name);
+    GNUNET_SERVER_receive_done (client, GNUNET_OK);
     return;
   }
-
-  if (strlen (name) > MAX_DNS_NAME_LENGTH) {
+  if (strlen (name) > MAX_DNS_NAME_LENGTH) 
+  {
     GNUNET_log(GNUNET_ERROR_TYPE_DEBUG,
-               "SHORTEN: %s is too long", name);
+               "SHORTEN: %s is too long\n", name);
+    GNUNET_CONTAINER_DLL_remove (csh_head, csh_tail, csh);
     send_shorten_response(csh, name);
+    GNUNET_SERVER_receive_done (client, GNUNET_OK);
     return;
-  }
-  
-  if (!is_gnunet_tld(name) && !is_zkey_tld(name))
+  }  
+  if ( (! is_gnunet_tld (name)) && 
+       (! is_zkey_tld (name)) )
   {
     GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                 "%s is not our domain. Returning\n", name);
-    send_shorten_response(csh, name);
+    GNUNET_CONTAINER_DLL_remove (csh_head, csh_tail, csh);
+    send_shorten_response (csh, name);
+    GNUNET_SERVER_receive_done (client, GNUNET_OK);
     return;
   }
-
   csh->shorten_zone = sh_msg->shorten_zone;
   csh->private_zone = sh_msg->private_zone;
-
-  strcpy (csh->name, name);
-  
-  GNUNET_SERVER_notification_context_add (nc, client);
-  
+  strcpy (csh->name, name);  
   if (1 == ntohl(sh_msg->use_default_zone))
     csh->root_zone = zone_hash; //Default zone
   else
     csh->root_zone = sh_msg->zone;
-
   start_shorten_name (csh);
-
   GNUNET_STATISTICS_update (statistics,
                             "Name shorten attempts", 1, GNUNET_NO);
-  
+  GNUNET_SERVER_receive_done (client, GNUNET_OK);
 }
 
 
@@ -891,24 +814,21 @@ static void handle_shorten (void *cls,
  * @param cls the closure containing a client get auth handle
  * @param name the shortened name result or NULL if cannot be shortened
  */
-static void
+static void 
 send_get_auth_response(void *cls, const char* name)
 {
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Sending `%s' message with %s\n",
-              "GET_AUTH_RESULT", name);
+  struct ClientGetAuthHandle *cah = cls;
   struct GNUNET_GNS_ClientGetAuthResultMessage *rmsg;
-  struct ClientGetAuthHandle *cah = (struct ClientGetAuthHandle *)cls;
   
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Sending `%s' message with %s\n",
+              "GET_AUTH_RESULT", name);
   if (name != NULL)
   {
     GNUNET_STATISTICS_update (statistics,
                               "Authorities resolved", 1, GNUNET_NO);
-  }
-  
-  if (name == NULL)
-  {
-    name = "";
-  }
+  }  
+  if (name == NULL)  
+    name = "";  
 
   rmsg = GNUNET_malloc(sizeof(struct GNUNET_GNS_ClientGetAuthResultMessage)
                        + strlen(name) + 1);
@@ -918,20 +838,16 @@ send_get_auth_response(void *cls, const char* name)
   rmsg->header.size = 
     htons(sizeof(struct GNUNET_GNS_ClientGetAuthResultMessage) +
           strlen(name) + 1);
-
-  strcpy((char*)&rmsg[1], name);
+  strcpy ((char*)&rmsg[1], name);
 
   GNUNET_SERVER_notification_context_unicast (nc, cah->client,
-                              (const struct GNUNET_MessageHeader *) rmsg,
-                              GNUNET_NO);
+                                             &rmsg->header,
+                                             GNUNET_NO);
   GNUNET_SERVER_receive_done (cah->client, GNUNET_OK);
   
   GNUNET_free(rmsg);
   GNUNET_free_non_null(cah->name);
-  GNUNET_free(cah);
-
-  
-  
+  GNUNET_free(cah);  
 }
 
 
@@ -942,65 +858,58 @@ send_get_auth_response(void *cls, const char* name)
  * @param client the client
  * @param message the message
  */
-static void handle_get_authority(void *cls,
-                           struct GNUNET_SERVER_Client * client,
-                           const struct GNUNET_MessageHeader * message)
+static void 
+handle_get_authority (void *cls,
+                     struct GNUNET_SERVER_Client * client,
+                     const struct GNUNET_MessageHeader * message)
 {
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Received `%s' message\n", "GET_AUTH");
-
-  size_t msg_size = 0;
+  uint16_t msg_size;
+  const struct GNUNET_GNS_ClientGetAuthMessage *sh_msg;
   struct ClientGetAuthHandle *cah;
+  const char *utf_in;
   char name[MAX_DNS_NAME_LENGTH];
   char* nameptr = name;
 
-
-  if (ntohs (message->size) < sizeof (struct GNUNET_GNS_ClientGetAuthMessage))
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Received `%s' message\n", "GET_AUTH");
+  msg_size = ntohs(message->size);
+  if (msg_size < sizeof (struct GNUNET_GNS_ClientGetAuthMessage))
   {
-    GNUNET_break_op (0);
+    GNUNET_break (0);
     GNUNET_SERVER_receive_done (client, GNUNET_OK);
     return;
   }
-
   GNUNET_SERVER_notification_context_add (nc, client);
 
-  struct GNUNET_GNS_ClientGetAuthMessage *sh_msg =
-    (struct GNUNET_GNS_ClientGetAuthMessage *) message;
-  
-  msg_size = ntohs(message->size);
-
-  if (msg_size > GNUNET_SERVER_MAX_MESSAGE_SIZE)
+  sh_msg = (const struct GNUNET_GNS_ClientGetAuthMessage *) message;
+  utf_in = (const char *) &sh_msg[1];
+  if ('\0' != utf_in[msg_size - sizeof (struct GNUNET_GNS_ClientGetAuthMessage) - 1])
   {
-    GNUNET_break_op (0);
-    GNUNET_SERVER_receive_done (client, GNUNET_OK);
+    GNUNET_break (0);
+    GNUNET_SERVER_receive_done (client, GNUNET_SYSERR);
     return;
-  }
-  
-  GNUNET_STRINGS_utf8_tolower((char*)&sh_msg[1], &nameptr);
-
-
+  }  
+  GNUNET_STRINGS_utf8_tolower(utf_in, &nameptr);
   cah = GNUNET_malloc(sizeof(struct ClientGetAuthHandle));
   cah->client = client;
   cah->unique_id = sh_msg->id;
-
-  if (strlen(name) < strlen(GNUNET_GNS_TLD))
+  if (strlen (name) < strlen(GNUNET_GNS_TLD))
   {
     GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                "GET_AUTH: %s is too short. Returning\n", name);
+                "GET_AUTH: `%s' is too short. Returning\n", name);
     cah->name = NULL;
     send_get_auth_response(cah, name);
     return;
-  }
-  
-  if (strlen (name) > MAX_DNS_NAME_LENGTH) {
+  }  
+  if (strlen (name) > MAX_DNS_NAME_LENGTH) 
+  {
     GNUNET_log(GNUNET_ERROR_TYPE_DEBUG,
-               "GET_AUTH: %s is too long", name);
+               "GET_AUTH: `%s' is too long", name);
     cah->name = NULL;
     send_get_auth_response(cah, name);
     return;
-  }
-  
-  if (strcmp(name+strlen(name)-strlen(GNUNET_GNS_TLD),
-             GNUNET_GNS_TLD) != 0)
+  }  
+  if (0 != strcmp (name + strlen (name) - strlen(GNUNET_GNS_TLD),
+                  GNUNET_GNS_TLD))
   {
     GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                 "GET_AUTH: %s is not our domain. Returning\n", name);
@@ -1009,21 +918,20 @@ static void handle_get_authority(void *cls,
     return;
   }
 
-  if (strcmp(name, GNUNET_GNS_TLD) == 0)
+  if (0 == strcmp(name, GNUNET_GNS_TLD))
   {
     GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                 "GET_AUTH: %s is us. Returning\n", name);
     cah->name = NULL;
     send_get_auth_response(cah, name);
     return;
-  }
-  
-  cah->name = GNUNET_malloc(strlen(name)
-                            - strlen(GNUNET_GNS_TLD) + 1);
-  memset(cah->name, 0,
-         strlen(name)-strlen(GNUNET_GNS_TLD) + 1);
-  memcpy(cah->name, name,
-         strlen(name)-strlen(GNUNET_GNS_TLD));
+  }  
+  cah->name = GNUNET_malloc(strlen (name)
+                            - strlen (GNUNET_GNS_TLD) + 1);
+  memset (cah->name, 0,
+         strlen (name) - strlen (GNUNET_GNS_TLD) + 1);
+  memcpy (cah->name, name,
+         strlen (name) - strlen(GNUNET_GNS_TLD));
 
   /* Start delegation resolution in our namestore */
   gns_resolver_get_authority(zone_hash, zone_hash, name, &send_get_auth_response, cah);
@@ -1073,7 +981,7 @@ send_lookup_response(void* cls,
   GNUNET_free(clh->name);
   
   if (NULL != clh->shorten_key)
-    GNUNET_free(clh->shorten_key);
+    GNUNET_CRYPTO_rsa_key_free (clh->shorten_key);
 
   GNUNET_free(clh);
 
@@ -1101,40 +1009,29 @@ handle_lookup(void *cls,
               struct GNUNET_SERVER_Client * client,
               const struct GNUNET_MessageHeader * message)
 {
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Received `%s' message\n", "LOOKUP");
-
-  size_t msg_size = 0;
+  uint16_t msg_size;
+  const struct GNUNET_GNS_ClientLookupMessage *sh_msg;
   size_t namelen;
   char name[MAX_DNS_NAME_LENGTH];
   struct ClientLookupHandle *clh;
   char* nameptr = name;
+  const char *utf_in;
   int only_cached;
   struct GNUNET_CRYPTO_RsaPrivateKey *key;
   struct GNUNET_CRYPTO_RsaPrivateKeyBinaryEncoded *pkey;
   char* tmp_pkey;
 
-  if (ntohs (message->size) < sizeof (struct GNUNET_GNS_ClientLookupMessage))
-  {
-    GNUNET_break_op (0);
-    GNUNET_SERVER_receive_done (client, GNUNET_OK);
-    return;
-  }
-
-  GNUNET_SERVER_notification_context_add (nc, client);
-
-  struct GNUNET_GNS_ClientLookupMessage *sh_msg =
-    (struct GNUNET_GNS_ClientLookupMessage *) message;
-  
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Received `%s' message\n", "LOOKUP");
   msg_size = ntohs(message->size);
-
-  if (msg_size > GNUNET_SERVER_MAX_MESSAGE_SIZE)
+  if (msg_size < sizeof (struct GNUNET_GNS_ClientLookupMessage))
   {
-    GNUNET_break_op (0);
+    GNUNET_break (0);
     GNUNET_SERVER_receive_done (client, GNUNET_OK);
     return;
   }
-
-  if (1 == ntohl(sh_msg->have_key))
+  sh_msg = (const struct GNUNET_GNS_ClientLookupMessage *) message;
+  GNUNET_SERVER_notification_context_add (nc, client);
+  if (GNUNET_YES == ntohl (sh_msg->have_key))
   {
     pkey = (struct GNUNET_CRYPTO_RsaPrivateKeyBinaryEncoded *)&sh_msg[1];
     tmp_pkey = (char*)&sh_msg[1];
@@ -1144,10 +1041,16 @@ handle_lookup(void *cls,
   else
   {
     key = NULL;
-    GNUNET_STRINGS_utf8_tolower((char*)&sh_msg[1], &nameptr);
-  }
-  
-  namelen = strlen(name)+1;
+    utf_in = (const char *) &sh_msg[1];
+    if ('\0' != utf_in[msg_size - sizeof (struct GNUNET_GNS_ClientLookupMessage) - 1])
+    {
+      GNUNET_break (0);
+      GNUNET_SERVER_receive_done (client, GNUNET_SYSERR);
+      return;
+    }  
+    GNUNET_STRINGS_utf8_tolower(utf_in, &nameptr);
+  }  
+  namelen = strlen (name)+1;
   clh = GNUNET_malloc (sizeof (struct ClientLookupHandle));
   memset (clh, 0, sizeof (struct ClientLookupHandle));
   clh->client = client;
@@ -1213,6 +1116,7 @@ handle_lookup(void *cls,
                             "Record lookup attempts", 1, GNUNET_NO);
 }
 
+
 /**
  * Test if the given AF is supported by this system.
  *
@@ -1240,6 +1144,7 @@ test_af (int af)
   return GNUNET_OK;
 }
 
+
 /**
  * Process GNS requests.
  *
@@ -1251,9 +1156,6 @@ static void
 run (void *cls, struct GNUNET_SERVER_Handle *server,
      const struct GNUNET_CONFIGURATION_Handle *c)
 {
-
-  GNUNET_log(GNUNET_ERROR_TYPE_DEBUG, "Initializing GNS\n");
-  
   char* keyfile;
   struct GNUNET_CRYPTO_RsaPublicKeyBinaryEncoded pkey;
   unsigned long long max_parallel_bg_queries = 0;
@@ -1266,8 +1168,6 @@ run (void *cls, struct GNUNET_SERVER_Handle *server,
     {&handle_get_authority, NULL, GNUNET_MESSAGE_TYPE_GNS_GET_AUTH, 0}
   };
 
-  GNS_cfg = c;
-
   v6_enabled = test_af (AF_INET6);
   v4_enabled = test_af (AF_INET);
 
@@ -1290,25 +1190,16 @@ run (void *cls, struct GNUNET_SERVER_Handle *server,
                      sizeof(struct GNUNET_CRYPTO_RsaPublicKeyBinaryEncoded),
                      &zone_hash);
   GNUNET_free(keyfile);
-  
-  /**
-   * handle to our local namestore
-   */
-  namestore_handle = GNUNET_NAMESTORE_connect(c);
-
+  namestore_handle = GNUNET_NAMESTORE_connect (c);
   if (NULL == namestore_handle)
   {
-    //FIXME do error handling;
-    GNUNET_log(GNUNET_ERROR_TYPE_ERROR,
-               "Failed to connect to the namestore!\n");
+    GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+               _("Failed to connect to the namestore!\n"));
     GNUNET_SCHEDULER_shutdown ();
     return;
   }
   
-  
-
   auto_import_pkey = GNUNET_NO;
-
   if (GNUNET_YES ==
       GNUNET_CONFIGURATION_get_value_yesno (c, "gns",
                                             "AUTO_IMPORT_PKEY"))
@@ -1328,9 +1219,9 @@ run (void *cls, struct GNUNET_SERVER_Handle *server,
                                              "RECORD_PUT_INTERVAL",
                                              &record_put_interval))
   {
-    GNUNET_log(GNUNET_ERROR_TYPE_INFO,
-               "Record put interval: %llu\n",
-               record_put_interval);
+    GNUNET_log (GNUNET_ERROR_TYPE_INFO,
+               "Record put interval: %s\n",
+               GNUNET_STRINGS_relative_time_to_string (record_put_interval, GNUNET_YES));
   }
 
   if (GNUNET_OK ==
@@ -1373,7 +1264,7 @@ run (void *cls, struct GNUNET_SERVER_Handle *server,
 
   if (NULL == dht_handle)
   {
-    GNUNET_log(GNUNET_ERROR_TYPE_ERROR, "Could not connect to DHT!\n");
+    GNUNET_log (GNUNET_ERROR_TYPE_ERROR, "Could not connect to DHT!\n");
   }
   
   if (gns_resolver_init(namestore_handle, dht_handle, zone_hash, c,