-remove trailing whitespace
[oweals/gnunet.git] / src / gns / gns_api.c
index 09e5426f9d494fde7418bfc4480235ed51da0f8b..75c2f95301cecb05366b23f521f18d5b3e295216 100644 (file)
@@ -1,6 +1,6 @@
 /*
      This file is part of GNUnet.
-     (C) 2009, 2010 Christian Grothoff (and other contributing authors)
+     (C) 2009-2013 Christian Grothoff (and other contributing authors)
 
      GNUnet is free software; you can redistribute it and/or modify
      it under the terms of the GNU General Public License as published
      Free Software Foundation, Inc., 59 Temple Place - Suite 330,
      Boston, MA 02111-1307, USA.
 */
-
 /**
- *
  * @file gns/gns_api.c
  * @brief library to access the GNS service
  * @author Martin Schanzenbach
+ * @author Christian Grothoff
  */
-
 #include "platform.h"
 #include "gnunet_util_lib.h"
 #include "gnunet_constants.h"
 #include "gns.h"
 #include "gnunet_gns_service.h"
 
-/* TODO into gnunet_protocols */
-#define GNUNET_MESSAGE_TYPE_GNS_LOOKUP 23
-#define GNUNET_MESSAGE_TYPE_GNS_LOOKUP_RESULT 24
-#define GNUNET_MESSAGE_TYPE_GNS_SHORTEN 25
-#define GNUNET_MESSAGE_TYPE_GNS_SHORTEN_RESULT 26
-#define GNUNET_MESSAGE_TYPE_GNS_GET_AUTH 27
-#define GNUNET_MESSAGE_TYPE_GNS_GET_AUTH_RESULT 28
+
+#define LOG(kind,...) GNUNET_log_from (kind, "gns-api",__VA_ARGS__)
 
 /**
- * A QueueEntry.
+ * Handle to a lookup request
  */
-struct GNUNET_GNS_QueueEntry
+struct GNUNET_GNS_LookupRequest
 {
+
   /**
    * DLL
    */
-  struct GNUNET_GNS_QueueEntry *next;
-  
+  struct GNUNET_GNS_LookupRequest *next;
+
   /**
    * DLL
    */
-  struct GNUNET_GNS_QueueEntry *prev;
+  struct GNUNET_GNS_LookupRequest *prev;
 
-  /* request id */
-  uint32_t r_id;
-  
-  /* handle to gns */
+  /**
+   * handle to gns
+   */
   struct GNUNET_GNS_Handle *gns_handle;
-  
-  /* processor to call on shorten result */
-  GNUNET_GNS_ShortenResultProcessor shorten_proc;
-  
-  /* processor to call on lookup result */
+
+  /**
+   * processor to call on lookup result
+   */
   GNUNET_GNS_LookupResultProcessor lookup_proc;
 
-  /* processor to call on authority lookup result */
-  GNUNET_GNS_GetAuthResultProcessor auth_proc;
-  
-  /* processor closure */
+  /**
+   * processor closure
+   */
   void *proc_cls;
-  
+
+  /**
+   * request id
+   */
+  uint32_t r_id;
+
 };
 
 
@@ -99,6 +95,18 @@ struct PendingMessage
    */
   size_t size;
 
+  /**
+   * request id
+   */
+  uint32_t r_id;
+
+  /**
+   * This message has been transmitted.  GNUNET_NO if the message is
+   * in the "pending" DLL, GNUNET_YES if it has been transmitted to
+   * the service via the current client connection.
+   */
+  int transmitted;
+
 };
 
 
@@ -122,9 +130,7 @@ struct GNUNET_GNS_Handle
    * Currently pending transmission request (or NULL).
    */
   struct GNUNET_CLIENT_TransmitHandle *th;
-  
-  uint32_t r_id;
-  
+
   /**
    * Head of linked list of shorten messages we would like to transmit.
    */
@@ -134,53 +140,40 @@ struct GNUNET_GNS_Handle
    * Tail of linked list of shorten messages we would like to transmit.
    */
   struct PendingMessage *pending_tail;
-  
-  /**
-   * Head of linked list of shorten messages we would like to transmit.
-   */
-  struct GNUNET_GNS_QueueEntry *shorten_head;
 
-  /**
-   * Tail of linked list of shorten messages we would like to transmit.
-   */
-  struct GNUNET_GNS_QueueEntry *shorten_tail;
-  
   /**
    * Head of linked list of lookup messages we would like to transmit.
    */
-  struct GNUNET_GNS_QueueEntry *lookup_head;
+  struct GNUNET_GNS_LookupRequest *lookup_head;
 
   /**
    * Tail of linked list of lookup messages we would like to transmit.
    */
-  struct GNUNET_GNS_QueueEntry *lookup_tail;
-  
+  struct GNUNET_GNS_LookupRequest *lookup_tail;
+
   /**
-   * Head of linked list of authority lookup messages we would like to transmit.
+   * Reconnect task
    */
-  struct GNUNET_GNS_QueueEntry *get_auth_head;
+  GNUNET_SCHEDULER_TaskIdentifier reconnect_task;
 
   /**
-   * Tail of linked list of authority lookup messages we would like to transmit.
+   * How long do we wait until we try to reconnect?
    */
-  struct GNUNET_GNS_QueueEntry *get_auth_tail;
+  struct GNUNET_TIME_Relative reconnect_backoff;
 
   /**
-   * Reconnect task
+   * Request Id generator.  Incremented by one for each request.
    */
-  GNUNET_SCHEDULER_TaskIdentifier reconnect_task;
+  uint32_t r_id_gen;
 
   /**
    * Did we start our receive loop yet?
    */
   int in_receive;
 
-  /**
-   * Reconnect necessary
-   */
-  int reconnect;
 };
 
+
 /**
  * Try to send messages from list of messages to send
  * @param handle GNS_Handle
@@ -192,18 +185,20 @@ process_pending_messages (struct GNUNET_GNS_Handle *handle);
 /**
  * Reconnect to GNS service.
  *
- * @param h the handle to the namestore service
+ * @param handle the handle to the GNS service
  */
 static void
-reconnect (struct GNUNET_GNS_Handle *h)
+reconnect (struct GNUNET_GNS_Handle *handle)
 {
-  GNUNET_assert (NULL == h->client);
-  GNUNET_log(GNUNET_ERROR_TYPE_DEBUG,
-             "Trying to connect to GNS...\n");
-  h->client = GNUNET_CLIENT_connect ("gns", h->cfg);
-  GNUNET_assert (NULL != h->client);
+  GNUNET_assert (NULL == handle->client);
+  LOG (GNUNET_ERROR_TYPE_DEBUG,
+       "Trying to connect to GNS\n");
+  handle->client = GNUNET_CLIENT_connect ("gns", handle->cfg);
+  GNUNET_assert (NULL != handle->client);
+  process_pending_messages (handle);
 }
 
+
 /**
  * Reconnect to GNS
  *
@@ -213,35 +208,56 @@ reconnect (struct GNUNET_GNS_Handle *h)
 static void
 reconnect_task (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
 {
-  struct GNUNET_GNS_Handle *h = cls;
+  struct GNUNET_GNS_Handle *handle = cls;
 
-  h->reconnect_task = GNUNET_SCHEDULER_NO_TASK;
-  reconnect (h);
+  handle->reconnect_task = GNUNET_SCHEDULER_NO_TASK;
+  reconnect (handle);
 }
 
 
 /**
  * Disconnect from service and then reconnect.
  *
- * @param h our handle
+ * @param handle our handle
  */
 static void
-force_reconnect (struct GNUNET_GNS_Handle *h)
+force_reconnect (struct GNUNET_GNS_Handle *handle)
 {
-  h->reconnect = GNUNET_NO;
-  GNUNET_CLIENT_disconnect (h->client, GNUNET_NO);
-  h->client = NULL;
-  h->reconnect_task = GNUNET_SCHEDULER_add_delayed (GNUNET_TIME_UNIT_SECONDS,
+  struct GNUNET_GNS_LookupRequest *lh;
+  struct PendingMessage *p;
+
+  GNUNET_CLIENT_disconnect (handle->client);
+  handle->client = NULL;
+  handle->in_receive = GNUNET_NO;
+  for (lh = handle->lookup_head; NULL != lh; lh = lh->next)
+  {
+    p = (struct PendingMessage *) &lh[1];
+    if (GNUNET_NO == p->transmitted)
+      continue;
+    p->transmitted = GNUNET_NO;
+    GNUNET_CONTAINER_DLL_insert (handle->pending_head,
+                                handle->pending_tail,
+                                p);
+  }
+  handle->reconnect_backoff = GNUNET_TIME_STD_BACKOFF (handle->reconnect_backoff);
+  handle->reconnect_task = GNUNET_SCHEDULER_add_delayed (handle->reconnect_backoff,
                                                     &reconnect_task,
-                                                    h);
+                                                    handle);
 }
 
+
 /**
  * Transmit the next pending message, called by notify_transmit_ready
+ *
+ * @param cls the closure
+ * @param size size of pending data
+ * @param buf buffer with pending data
+ * @return size data transmitted
  */
 static size_t
 transmit_pending (void *cls, size_t size, void *buf);
 
+
 /**
  * Handler for messages received from the GNS service
  *
@@ -251,169 +267,92 @@ transmit_pending (void *cls, size_t size, void *buf);
 static void
 process_message (void *cls, const struct GNUNET_MessageHeader *msg);
 
+
 /**
  * Try to send messages from list of messages to send
+ *
+ * @param handle the GNS handle
  */
 static void
 process_pending_messages (struct GNUNET_GNS_Handle *handle)
 {
-  struct PendingMessage *p;
+  struct PendingMessage *p = handle->pending_head;
 
-  if (handle->client == NULL)
-  {
-    GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
-         "process_pending_messages called, but client is null\n");
-    return;
-  }
-  
-  if (handle->th != NULL)
-    return;
-  
-  if (NULL == (p = handle->pending_head))
-    return;
-  
-  GNUNET_log(GNUNET_ERROR_TYPE_DEBUG,
-             "Trying to transmit %d bytes...\n", p->size);
+  if (NULL == handle->client)
+    return; /* wait for reconnect */
+  if (NULL != handle->th)
+    return; /* transmission request already pending */
+
+  while ((NULL != p) && (p->transmitted == GNUNET_YES))
+    p = p->next;
+  if (NULL == p)
+    return; /* no messages pending */
 
+  LOG (GNUNET_ERROR_TYPE_DEBUG,
+       "Trying to transmit %u bytes\n",
+       (unsigned int) p->size);
   handle->th =
     GNUNET_CLIENT_notify_transmit_ready (handle->client,
                                          p->size,
                                          GNUNET_TIME_UNIT_FOREVER_REL,
                                          GNUNET_NO, &transmit_pending,
                                          handle);
-  if (NULL != handle->th)
-    return;
-
-  GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
-              "notify_transmit_ready returned NULL!\n");
+  GNUNET_break (NULL != handle->th);
 }
 
 
 /**
  * Transmit the next pending message, called by notify_transmit_ready
+ *
+ * @param cls the closure
+ * @param size size of pending data
+ * @param buf buffer with pending data
+ * @return size data transmitted
  */
 static size_t
 transmit_pending (void *cls, size_t size, void *buf)
 {
   struct GNUNET_GNS_Handle *handle = cls;
+  char *cbuf = buf;
   struct PendingMessage *p;
   size_t tsize;
-  char *cbuf;
 
   handle->th = NULL;
-  
-  if ((size == 0) || (buf == NULL))
+  if ((0 == size) || (NULL == buf))
   {
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-         "Transmission to GNS service failed!\n");
-    force_reconnect(handle);
+    LOG (GNUNET_ERROR_TYPE_DEBUG,
+        "Transmission to GNS service failed!\n");
+    force_reconnect (handle);
     return 0;
   }
-  
-  tsize = 0;
-  cbuf = buf;
-
   if (NULL == (p = handle->pending_head))
     return 0;
 
+  tsize = 0;
   while ((NULL != (p = handle->pending_head)) && (p->size <= size))
   {
     memcpy (&cbuf[tsize], &p[1], p->size);
     tsize += p->size;
     size -= p->size;
-    GNUNET_CONTAINER_DLL_remove (handle->pending_head, handle->pending_tail, p);
+    p->transmitted = GNUNET_YES;
+    GNUNET_CONTAINER_DLL_remove (handle->pending_head,
+                                handle->pending_tail,
+                                p);
     if (GNUNET_YES != handle->in_receive)
     {
       GNUNET_CLIENT_receive (handle->client, &process_message, handle,
                              GNUNET_TIME_UNIT_FOREVER_REL);
       handle->in_receive = GNUNET_YES;
     }
-    GNUNET_free(p);
   }
-
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Sending %d bytes\n", tsize);
-
-  process_pending_messages(handle);
+  LOG (GNUNET_ERROR_TYPE_DEBUG,
+       "Sending %u bytes\n",
+       (unsigned int) tsize);
+  process_pending_messages (handle);
   return tsize;
 }
 
-/**
- * Process a given reply that might match the given
- * request.
- *
- * @param qe a queue entry
- * @param msg the shorten msg received
- */
-static void
-process_shorten_reply (struct GNUNET_GNS_QueueEntry *qe,
-                       const struct GNUNET_GNS_ClientShortenResultMessage *msg)
-{
-  struct GNUNET_GNS_Handle *h = qe->gns_handle;
-  const char *short_name;
-
-  GNUNET_CONTAINER_DLL_remove(h->shorten_head, h->shorten_tail, qe);
-
-  short_name = (char*)(&msg[1]);
-
-  if (ntohs (((struct GNUNET_MessageHeader*)msg)->size) <
-      sizeof (struct GNUNET_GNS_ClientShortenResultMessage))
-  {
-    GNUNET_break (0);
-    force_reconnect (h);
-    GNUNET_free(qe);
-    return;
-  }
-  
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Received shortened reply `%s' from GNS service\n",
-              short_name);
-  
-  GNUNET_CLIENT_receive (h->client, &process_message, h,
-                         GNUNET_TIME_UNIT_FOREVER_REL);
-  qe->shorten_proc(qe->proc_cls, short_name);
-  GNUNET_free(qe);
-
-}
-
 
-/**
- * Process a given reply that might match the given
- * request.
- *
- * @param qe the handle to the request
- * @param msg the message to process
- */
-static void
-process_get_auth_reply (struct GNUNET_GNS_QueueEntry *qe,
-                       const struct GNUNET_GNS_ClientGetAuthResultMessage *msg)
-{
-  struct GNUNET_GNS_Handle *h = qe->gns_handle;
-  const char *auth_name;
-
-  GNUNET_CONTAINER_DLL_remove(h->get_auth_head, h->get_auth_tail, qe);
-
-  auth_name = (char*)(&msg[1]);
-
-  if (ntohs (((struct GNUNET_MessageHeader*)msg)->size) <
-      sizeof (struct GNUNET_GNS_ClientGetAuthResultMessage))
-  {
-    GNUNET_free(qe);
-    GNUNET_break (0);
-    force_reconnect (h);
-    return;
-  }
-  
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Received GET_AUTH reply `%s' from GNS service\n",
-              auth_name);
-  
-  GNUNET_CLIENT_receive (h->client, &process_message, h,
-                         GNUNET_TIME_UNIT_FOREVER_REL);
-  qe->auth_proc(qe->proc_cls, auth_name);
-  GNUNET_free(qe);
-
-}
 /**
  * Process a given reply to the lookup request
  *
@@ -421,48 +360,45 @@ process_get_auth_reply (struct GNUNET_GNS_QueueEntry *qe,
  * @param msg the lookup message received
  */
 static void
-process_lookup_reply (struct GNUNET_GNS_QueueEntry *qe,
+process_lookup_reply (struct GNUNET_GNS_LookupRequest *qe,
                       const struct GNUNET_GNS_ClientLookupResultMessage *msg)
 {
-  struct GNUNET_GNS_Handle *h = qe->gns_handle;
-  int rd_count = ntohl(msg->rd_count);
-  size_t len = ntohs (((struct GNUNET_MessageHeader*)msg)->size);
+  struct GNUNET_GNS_Handle *handle = qe->gns_handle;
+  struct PendingMessage *p = (struct PendingMessage *) &qe[1];
+  uint32_t rd_count = ntohl (msg->rd_count);
   struct GNUNET_NAMESTORE_RecordData rd[rd_count];
+  size_t mlen;
 
-  GNUNET_CONTAINER_DLL_remove(h->lookup_head, h->lookup_tail, qe);
-
-  if (len < sizeof (struct GNUNET_GNS_ClientLookupResultMessage))
+  if (GNUNET_YES != p->transmitted)
   {
-    GNUNET_free(qe);
+    /* service send reply to query we never managed to send!? */
     GNUNET_break (0);
-    force_reconnect (h);
+    force_reconnect (handle);
     return;
   }
-
-  len -= sizeof(struct GNUNET_GNS_ClientLookupResultMessage);
-
-  GNUNET_CLIENT_receive (h->client, &process_message, h,
-                         GNUNET_TIME_UNIT_FOREVER_REL);
-  if (GNUNET_SYSERR == GNUNET_NAMESTORE_records_deserialize (len,
-                                                             (char*)&msg[1],
+  mlen = ntohs (msg->header.size);
+  mlen -= sizeof (struct GNUNET_GNS_ClientLookupResultMessage);
+  if (GNUNET_SYSERR == GNUNET_NAMESTORE_records_deserialize (mlen,
+                                                             (const char*) &msg[1],
                                                              rd_count,
                                                              rd))
   {
-    GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
-                "Failed to serialize lookup reply from GNS service!\n");
-    qe->lookup_proc(qe->proc_cls, 0, NULL);
+    LOG (GNUNET_ERROR_TYPE_ERROR,
+        _("Failed to serialize lookup reply from GNS service!\n"));
+    qe->lookup_proc (qe->proc_cls, 0, NULL);
   }
   else
   {
-  
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                "Received lookup reply from GNS service (count=%d)\n",
-                ntohl(msg->rd_count));
-    qe->lookup_proc(qe->proc_cls, rd_count, rd);
+    LOG (GNUNET_ERROR_TYPE_DEBUG,
+        "Received lookup reply from GNS service (%u records)\n",
+        (unsigned int) rd_count);
+    qe->lookup_proc (qe->proc_cls, rd_count, rd);
   }
-  GNUNET_free(qe);
+  GNUNET_CONTAINER_DLL_remove (handle->lookup_head, handle->lookup_tail, qe);
+  GNUNET_free (qe);
 }
 
+
 /**
  * Handler for messages received from the GNS service
  *
@@ -473,109 +409,42 @@ static void
 process_message (void *cls, const struct GNUNET_MessageHeader *msg)
 {
   struct GNUNET_GNS_Handle *handle = cls;
-  struct GNUNET_GNS_QueueEntry *qe;
+  struct GNUNET_GNS_LookupRequest *lr;
   const struct GNUNET_GNS_ClientLookupResultMessage *lookup_msg;
-  const struct GNUNET_GNS_ClientShortenResultMessage *shorten_msg;
-  const struct GNUNET_GNS_ClientGetAuthResultMessage *get_auth_msg;
-  uint16_t type;
   uint32_t r_id;
-  
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Got message\n");
-  if (msg == NULL)
-  {
-    GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
-         "Error receiving data from GNS service, reconnecting\n");
-    force_reconnect (handle);
-    return;
-  }
-
-  type = ntohs (msg->type);
-
-  if (type == GNUNET_MESSAGE_TYPE_GNS_LOOKUP_RESULT)
-  {
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                "Got lookup msg\n");
-    lookup_msg = (const struct GNUNET_GNS_ClientLookupResultMessage *) msg;
-    r_id = ntohl (lookup_msg->id);
-    
-    if (r_id > handle->r_id)
-    {
-      /** no request found */
-      GNUNET_break_op (0);
-      GNUNET_CLIENT_receive (handle->client, &process_message, handle,
-                             GNUNET_TIME_UNIT_FOREVER_REL);
-      return;
-    }
 
-    for (qe = handle->lookup_head; qe != NULL; qe = qe->next)
-    {
-      if (qe->r_id == r_id)
-        break;
-    }
-    if (qe)
-      process_lookup_reply(qe, lookup_msg);
-    
-    return;
-
-  }
-  else if (type == GNUNET_MESSAGE_TYPE_GNS_SHORTEN_RESULT)
+  if (NULL == msg)
   {
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                "Got SHORTEN_RESULT msg\n");
-    shorten_msg = (struct GNUNET_GNS_ClientShortenResultMessage *) msg;
-    
-    r_id = ntohl (shorten_msg->id);
-    
-    if (r_id > handle->r_id)
-    {
-      /** no request found */
-      GNUNET_break_op (0);
-      GNUNET_CLIENT_receive (handle->client, &process_message, handle,
-                             GNUNET_TIME_UNIT_FOREVER_REL);
-      return;
-    }
-
-    for (qe = handle->shorten_head; qe != NULL; qe = qe->next)
-    {
-      if (qe->r_id == r_id)
-        break;
-    }
-    if (qe)
-      process_shorten_reply(qe, shorten_msg);
+    force_reconnect (handle);
     return;
   }
-  else if (type == GNUNET_MESSAGE_TYPE_GNS_GET_AUTH_RESULT)
+  switch (ntohs (msg->type))
   {
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                "Got GET_AUTH_RESULT msg\n");
-    get_auth_msg = (struct GNUNET_GNS_ClientGetAuthResultMessage *) msg;
-
-    r_id = ntohl (get_auth_msg->id);
-
-    if (r_id > handle->r_id)
+  case GNUNET_MESSAGE_TYPE_GNS_LOOKUP_RESULT:
+    LOG (GNUNET_ERROR_TYPE_DEBUG,
+        "Got LOOKUP_RESULT msg\n");
+    if (ntohs (msg->size) < sizeof (struct GNUNET_GNS_ClientLookupResultMessage))
     {
-      /** no request found */
-      GNUNET_break_op (0);
-      GNUNET_CLIENT_receive (handle->client, &process_message, handle,
-                             GNUNET_TIME_UNIT_FOREVER_REL);
+      GNUNET_break (0);
+      force_reconnect (handle);
       return;
     }
-
-    for (qe = handle->get_auth_head; qe != NULL; qe = qe->next)
-    {
-      if (qe->r_id == r_id)
-        break;
-    }
-    if (qe)
-      process_get_auth_reply(qe, get_auth_msg);
+    lookup_msg = (const struct GNUNET_GNS_ClientLookupResultMessage *) msg;
+    r_id = ntohl (lookup_msg->id);
+    for (lr = handle->lookup_head; NULL != lr; lr = lr->next)
+      if (lr->r_id == r_id)
+      {
+       process_lookup_reply(lr, lookup_msg);
+       break;
+      }
+    break;
+  default:
+    GNUNET_break (0);
+    force_reconnect (handle);
     return;
   }
-
-
-  if (GNUNET_YES == handle->reconnect)
-    force_reconnect (handle);
-  
+  GNUNET_CLIENT_receive (handle->client, &process_message, handle,
+                        GNUNET_TIME_UNIT_FOREVER_REL);
 }
 
 
@@ -590,14 +459,9 @@ GNUNET_GNS_connect (const struct GNUNET_CONFIGURATION_Handle *cfg)
 {
   struct GNUNET_GNS_Handle *handle;
 
-  handle = GNUNET_malloc (sizeof (struct GNUNET_GNS_Handle));
-  handle->reconnect = GNUNET_NO;
+  handle = GNUNET_new (struct GNUNET_GNS_Handle);
   handle->cfg = cfg;
   reconnect (handle);
-  //handle->reconnect_task = GNUNET_SCHEDULER_add_now (&reconnect_task, handle);
-  handle->reconnect_task = GNUNET_SCHEDULER_NO_TASK;
-  handle->r_id = 0;
-  handle->in_receive = GNUNET_NO;
   return handle;
 }
 
@@ -610,201 +474,117 @@ GNUNET_GNS_connect (const struct GNUNET_CONFIGURATION_Handle *cfg)
 void
 GNUNET_GNS_disconnect (struct GNUNET_GNS_Handle *handle)
 {
-  GNUNET_CLIENT_disconnect (handle->client, GNUNET_NO);
+  if (NULL != handle->client)
+  {
+    GNUNET_CLIENT_disconnect (handle->client);
+    handle->client = NULL;
+  }
   if (GNUNET_SCHEDULER_NO_TASK != handle->reconnect_task)
   {
     GNUNET_SCHEDULER_cancel (handle->reconnect_task);
     handle->reconnect_task = GNUNET_SCHEDULER_NO_TASK;
   }
-  GNUNET_free(handle);
-  /* disco from GNS */
+  GNUNET_assert (NULL == handle->lookup_head);
+  GNUNET_free (handle);
 }
 
-/*
- * Helper function to generate request ids
- * 
- * @param h handle
- * @return a new id
+
+/**
+ * Cancel pending lookup request
+ *
+ * @param lr the lookup request to cancel
  */
-static uint32_t
-get_request_id (struct GNUNET_GNS_Handle *h)
+void
+GNUNET_GNS_lookup_cancel (struct GNUNET_GNS_LookupRequest *lr)
 {
-  uint32_t r_id = h->r_id;
-  h->r_id++;
-  return r_id;
+  struct PendingMessage *p = (struct PendingMessage*) &lr[1];
+
+  GNUNET_assert (NULL != lr->gns_handle);
+  if (GNUNET_NO == p->transmitted)
+    GNUNET_CONTAINER_DLL_remove (lr->gns_handle->pending_head,
+                                 lr->gns_handle->pending_tail,
+                                 p);
+  GNUNET_CONTAINER_DLL_remove (lr->gns_handle->lookup_head,
+                               lr->gns_handle->lookup_tail,
+                               lr);
+  GNUNET_free (lr);
 }
 
+
 /**
- * Perform an asynchronous Lookup operation on the GNS.
+ * Perform an asynchronous lookup operation on the GNS.
  *
  * @param handle handle to the GNS service
  * @param name the name to look up
+ * @param zone the zone to start the resolution in
  * @param type the record type to look up
+ * @param only_cached #GNUNET_YES to only check locally (not in the DHT)
+ * @param shorten_zone_key the private key of the shorten zone (can be NULL)
  * @param proc processor to call on result
  * @param proc_cls closure for processor
- * @return handle to the get
+ * @return handle to the get request
  */
-struct GNUNET_GNS_QueueEntry *
+struct GNUNET_GNS_LookupRequest*
 GNUNET_GNS_lookup (struct GNUNET_GNS_Handle *handle,
-                   const char * name,
-                   enum GNUNET_GNS_RecordType type,
-                   GNUNET_GNS_LookupResultProcessor proc,
-                   void *proc_cls)
+                  const char *name,
+                  const struct GNUNET_CRYPTO_EccPublicSignKey *zone,
+                  int type,
+                  int only_cached,
+                  const struct GNUNET_CRYPTO_EccPrivateKey *shorten_zone_key,
+                  GNUNET_GNS_LookupResultProcessor proc,
+                  void *proc_cls)
 {
   /* IPC to shorten gns names, return shorten_handle */
   struct GNUNET_GNS_ClientLookupMessage *lookup_msg;
-  struct GNUNET_GNS_QueueEntry *qe;
+  struct GNUNET_GNS_LookupRequest *lr;
   size_t msize;
   struct PendingMessage *pending;
 
   if (NULL == name)
   {
+    GNUNET_break (0);
+    return NULL;
+  }
+  LOG (GNUNET_ERROR_TYPE_DEBUG,
+       "Trying to lookup `%s' in GNS\n",
+       name);
+  msize = sizeof (struct GNUNET_GNS_ClientLookupMessage)
+    + strlen (name) + 1;
+  if (msize > UINT16_MAX)
+  {
+    GNUNET_break (0);
     return NULL;
   }
-
-  msize = sizeof (struct GNUNET_GNS_ClientLookupMessage) + strlen(name) + 1;
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Trying to lookup %s in GNS\n", name);
-
-  qe = GNUNET_malloc(sizeof (struct GNUNET_GNS_QueueEntry));
-  qe->gns_handle = handle;
-  qe->lookup_proc = proc;
-  qe->proc_cls = proc_cls;
-  qe->r_id = get_request_id(handle);
-  GNUNET_CONTAINER_DLL_insert_tail(handle->lookup_head,
-                                   handle->lookup_tail, qe);
-
-  pending = GNUNET_malloc (sizeof (struct PendingMessage) + msize);
-  memset(pending, 0, (sizeof (struct PendingMessage) + msize));
-  
+  lr = GNUNET_malloc (sizeof (struct GNUNET_GNS_LookupRequest) +
+                     sizeof (struct PendingMessage) + msize);
+  lr->gns_handle = handle;
+  lr->lookup_proc = proc;
+  lr->proc_cls = proc_cls;
+  lr->r_id = handle->r_id_gen++;
+  pending = (struct PendingMessage *)&lr[1];
   pending->size = msize;
+  pending->r_id = lr->r_id;
+  GNUNET_CONTAINER_DLL_insert_tail (handle->lookup_head,
+                                    handle->lookup_tail, lr);
 
   lookup_msg = (struct GNUNET_GNS_ClientLookupMessage *) &pending[1];
   lookup_msg->header.type = htons (GNUNET_MESSAGE_TYPE_GNS_LOOKUP);
   lookup_msg->header.size = htons (msize);
-  lookup_msg->id = htonl(qe->r_id);
-  lookup_msg->type = htonl(type);
-
-  memcpy(&lookup_msg[1], name, strlen(name));
-
-  GNUNET_CONTAINER_DLL_insert (handle->pending_head, handle->pending_tail,
-                               pending);
-  
-  process_pending_messages (handle);
-  return qe;
-}
-
-
-/**
- * Perform a name shortening operation on the GNS.
- *
- * @param handle handle to the GNS service
- * @param name the name to look up
- * @param proc function to call on result
- * @param proc_cls closure for processor
- * @return handle to the operation
- */
-struct GNUNET_GNS_QueueEntry *
-GNUNET_GNS_shorten (struct GNUNET_GNS_Handle *handle,
-                    const char * name,
-                    GNUNET_GNS_ShortenResultProcessor proc,
-                    void *proc_cls)
-{
-  /* IPC to shorten gns names, return shorten_handle */
-  struct GNUNET_GNS_ClientShortenMessage *shorten_msg;
-  struct GNUNET_GNS_QueueEntry *qe;
-  size_t msize;
-  struct PendingMessage *pending;
-
-  if (NULL == name)
+  lookup_msg->id = htonl (lr->r_id);
+  lookup_msg->only_cached = htonl (only_cached);
+  lookup_msg->zone = *zone;
+  lookup_msg->type = htonl (type);
+  if (NULL != shorten_zone_key)
   {
-    return NULL;
+    lookup_msg->have_key = htons (GNUNET_YES);
+    lookup_msg->shorten_key = *shorten_zone_key;
   }
-
-  msize = sizeof (struct GNUNET_GNS_ClientShortenMessage) + strlen(name) + 1;
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Trying to shorten %s in GNS\n", name);
-
-  qe = GNUNET_malloc(sizeof (struct GNUNET_GNS_QueueEntry));
-  qe->gns_handle = handle;
-  qe->shorten_proc = proc;
-  qe->proc_cls = proc_cls;
-  qe->r_id = get_request_id(handle);
-  GNUNET_CONTAINER_DLL_insert_tail(handle->shorten_head,
-                                   handle->shorten_tail, qe);
-
-  pending = GNUNET_malloc (sizeof (struct PendingMessage) + msize);
-  memset(pending, 0, (sizeof (struct PendingMessage) + msize));
-  
-  pending->size = msize;
-
-  shorten_msg = (struct GNUNET_GNS_ClientShortenMessage *) &pending[1];
-  shorten_msg->header.type = htons (GNUNET_MESSAGE_TYPE_GNS_SHORTEN);
-  shorten_msg->header.size = htons (msize);
-  shorten_msg->id = htonl(qe->r_id);
-
-  memcpy(&shorten_msg[1], name, strlen(name));
-
-  GNUNET_CONTAINER_DLL_insert (handle->pending_head, handle->pending_tail,
-                               pending);
-  
-  process_pending_messages (handle);
-  return qe;
-}
-
-
-/**
- * Perform an authority lookup for a given name.
- *
- * @param handle handle to the GNS service
- * @param name the name to look up authority for
- * @param proc function to call on result
- * @param proc_cls closure for processor
- * @return handle to the operation
- */
-struct GNUNET_GNS_QueueEntry *
-GNUNET_GNS_get_authority (struct GNUNET_GNS_Handle *handle,
-                    const char * name,
-                    GNUNET_GNS_GetAuthResultProcessor proc,
-                    void *proc_cls)
-{
-  struct GNUNET_GNS_ClientGetAuthMessage *get_auth_msg;
-  struct GNUNET_GNS_QueueEntry *qe;
-  size_t msize;
-  struct PendingMessage *pending;
-
-  if (NULL == name)
-  {
-    return NULL;
-  }
-
-  msize = sizeof (struct GNUNET_GNS_ClientGetAuthMessage) + strlen(name) + 1;
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Trying to look up authority for %s in GNS\n", name);
-
-  qe = GNUNET_malloc(sizeof (struct GNUNET_GNS_QueueEntry));
-  qe->gns_handle = handle;
-  qe->auth_proc = proc;
-  qe->proc_cls = proc_cls;
-  qe->r_id = get_request_id(handle);
-  GNUNET_CONTAINER_DLL_insert_tail(handle->get_auth_head,
-                                   handle->get_auth_tail, qe);
-
-  pending = GNUNET_malloc (sizeof (struct PendingMessage) + msize);
-  memset(pending, 0, (sizeof (struct PendingMessage) + msize));
-  
-  pending->size = msize;
-
-  get_auth_msg = (struct GNUNET_GNS_ClientGetAuthMessage *) &pending[1];
-  get_auth_msg->header.type = htons (GNUNET_MESSAGE_TYPE_GNS_GET_AUTH);
-  get_auth_msg->header.size = htons (msize);
-  get_auth_msg->id = htonl(qe->r_id);
-
-  memcpy(&get_auth_msg[1], name, strlen(name));
-
-  GNUNET_CONTAINER_DLL_insert (handle->pending_head, handle->pending_tail,
-                               pending);
-  
+  memcpy (&lookup_msg[1], name, strlen (name) + 1);
+  GNUNET_CONTAINER_DLL_insert_tail (handle->pending_head,
+                                   handle->pending_tail,
+                                   pending);
   process_pending_messages (handle);
-  return qe;
+  return lr;
 }