fixing common off-by-one error with respect to maximum message size
[oweals/gnunet.git] / src / fs / fs_publish.c
index dbecdfab706224faa1b9890a0a75f849aac5648e..13701405ec7f4fa224c0342c0e22a275accde33e 100644 (file)
 /**
  * @file fs/fs_publish.c
  * @brief publish a file or directory in GNUnet
- * @see http://gnunet.org/encoding.php3
+ * @see http://gnunet.org/encoding
  * @author Krista Bennett
  * @author Christian Grothoff
  *
  * TODO:
  * - indexing cleanup: unindex on failure (can wait)
- * - persistence support (can wait)
  * - datastore reservation support (optimization)
  * - location URIs (publish with anonymity-level zero)
  */
 #include "fs.h"
 #include "fs_tree.h"
 
-#define DEBUG_PUBLISH GNUNET_YES
-
-/**
- * Main function that performs the upload.
- * @param cls "struct GNUNET_FS_PublishContext" identifies the upload
- * @param tc task context
- */
-static void
-do_upload (void *cls,
-          const struct GNUNET_SCHEDULER_TaskContext *tc);
+#define DEBUG_PUBLISH GNUNET_NO
 
 
 /**
@@ -81,28 +71,28 @@ struct PutContCtx
 
 /**
  * Fill in all of the generic fields for 
- * a publish event.
+ * a publish event and call the callback.
  *
  * @param pi structure to fill in
  * @param sc overall publishing context
  * @param p file information for the file being published
  * @param offset where in the file are we so far
+ * @return value returned from callback
  */
-static void
-make_publish_status (struct GNUNET_FS_ProgressInfo *pi,
-                    struct GNUNET_FS_PublishContext *sc,
-                    const struct GNUNET_FS_FileInformation *p,
-                    uint64_t offset)
+void *
+GNUNET_FS_publish_make_status_ (struct GNUNET_FS_ProgressInfo *pi,
+                               struct GNUNET_FS_PublishContext *sc,
+                               const struct GNUNET_FS_FileInformation *p,
+                               uint64_t offset)
 {
-  pi->value.publish.sc = sc;
+  pi->value.publish.pc = sc;
   pi->value.publish.fi = p;
   pi->value.publish.cctx
     = p->client_info;
   pi->value.publish.pctx
     = (NULL == p->dir) ? NULL : p->dir->client_info;
-  pi->value.publish.filename
-    = (p->is_directory) ? p->data.dir.dirname : p->data.file.filename;
-  pi->value.publish.size
+  pi->value.publish.filename = p->filename;
+  pi->value.publish.size 
     = (p->is_directory) ? p->data.dir.dir_size : p->data.file.file_size;
   pi->value.publish.eta 
     = GNUNET_TIME_calculate_eta (p->start_time,
@@ -111,25 +101,37 @@ make_publish_status (struct GNUNET_FS_ProgressInfo *pi,
   pi->value.publish.completed = offset;
   pi->value.publish.duration = GNUNET_TIME_absolute_get_duration (p->start_time);
   pi->value.publish.anonymity = p->anonymity;
+  return sc->h->upcb (sc->h->upcb_cls,
+                     pi);
 }
 
 
 /**
- * Cleanup the publish context, we're done
- * with it.
+ * Cleanup the publish context, we're done with it.
  *
- * @param sc struct to clean up after
+ * @param cls struct to clean up after
+ * @param tc scheduler context
  */
 static void
-publish_cleanup (struct GNUNET_FS_PublishContext *sc)
+publish_cleanup (void *cls,
+                const struct GNUNET_SCHEDULER_TaskContext *tc)
 {
-  GNUNET_FS_file_information_destroy (sc->fi, NULL, NULL);
-  if (sc->namespace != NULL)
-    GNUNET_FS_namespace_delete (sc->namespace, GNUNET_NO);
-  GNUNET_free_non_null (sc->nid);  
-  GNUNET_free_non_null (sc->nuid);
-  GNUNET_DATASTORE_disconnect (sc->dsh, GNUNET_NO);
-  GNUNET_free (sc);
+  struct GNUNET_FS_PublishContext *pc = cls;
+
+  GNUNET_FS_file_information_destroy (pc->fi, NULL, NULL);
+  if (pc->namespace != NULL)
+    GNUNET_FS_namespace_delete (pc->namespace, GNUNET_NO);
+  GNUNET_free_non_null (pc->nid);  
+  GNUNET_free_non_null (pc->nuid);
+  GNUNET_free_non_null (pc->serialization);
+  if (pc->dsh != NULL)
+    {
+      GNUNET_DATASTORE_disconnect (pc->dsh, GNUNET_NO);
+      pc->dsh = NULL;
+    }
+  if (pc->client != NULL)
+    GNUNET_CLIENT_disconnect (pc->client, GNUNET_NO);
+  GNUNET_free (pc);
 }
 
 
@@ -151,9 +153,12 @@ ds_put_cont (void *cls,
 
   if (GNUNET_SYSERR == pcc->sc->in_network_wait)
     {
-      /* we were aborted in the meantime,
-        finish shutdown! */
-      publish_cleanup (pcc->sc);
+      /* we were aborted in the meantime, finish shutdown! */
+      GNUNET_SCHEDULER_add_continuation (pcc->sc->h->sched,                                     
+                                        &publish_cleanup,
+                                        pcc->sc,
+                                        GNUNET_SCHEDULER_REASON_PREREQ_DONE);
+      GNUNET_free (pcc);
       return;
     }
   GNUNET_assert (GNUNET_YES == pcc->sc->in_network_wait);
@@ -163,16 +168,11 @@ ds_put_cont (void *cls,
       GNUNET_asprintf (&pcc->p->emsg, 
                       _("Upload failed: %s"),
                       msg);
-      GNUNET_FS_file_information_sync (pcc->p);
       pi.status = GNUNET_FS_STATUS_PUBLISH_ERROR;
-      make_publish_status (&pi, pcc->sc, pcc->p, 0);
       pi.value.publish.eta = GNUNET_TIME_UNIT_FOREVER_REL;
       pi.value.publish.specifics.error.message = pcc->p->emsg;
-      pcc->p->client_info
-       = pcc->sc->h->upcb (pcc->sc->h->upcb_cls,
-                           &pi);
+      pcc->p->client_info = GNUNET_FS_publish_make_status_ (&pi, pcc->sc, pcc->p, 0);
     }
-  GNUNET_FS_file_information_sync (pcc->p);
   if (NULL != pcc->cont)
     pcc->sc->upload_task 
       = GNUNET_SCHEDULER_add_with_priority (pcc->sc->h->sched,
@@ -198,13 +198,10 @@ signal_publish_completion (struct GNUNET_FS_FileInformation *p,
   struct GNUNET_FS_ProgressInfo pi;
   
   pi.status = GNUNET_FS_STATUS_PUBLISH_COMPLETED;
-  make_publish_status (&pi, sc, p,
-                      GNUNET_ntohll (p->chk_uri->data.chk.file_length));
   pi.value.publish.eta = GNUNET_TIME_UNIT_ZERO;
   pi.value.publish.specifics.completed.chk_uri = p->chk_uri;
-  p->client_info
-    = sc->h->upcb (sc->h->upcb_cls,
-                 &pi);
+  p->client_info = GNUNET_FS_publish_make_status_ (&pi, sc, p,
+                                                  GNUNET_ntohll (p->chk_uri->data.chk.file_length));
 }
 
 
@@ -226,12 +223,9 @@ signal_publish_error (struct GNUNET_FS_FileInformation *p,
   
   p->emsg = GNUNET_strdup (emsg);
   pi.status = GNUNET_FS_STATUS_PUBLISH_ERROR;
-  make_publish_status (&pi, sc, p, 0);
   pi.value.publish.eta = GNUNET_TIME_UNIT_FOREVER_REL;
   pi.value.publish.specifics.error.message =emsg;
-  p->client_info
-    = sc->h->upcb (sc->h->upcb_cls,
-                 &pi);
+  p->client_info = GNUNET_FS_publish_make_status_ (&pi, sc, p, 0);
 }
 
 
@@ -248,17 +242,19 @@ publish_sblocks_cont (void *cls,
                      const struct GNUNET_FS_Uri *uri,
                      const char *emsg)
 {
-  struct GNUNET_FS_PublishContext *sc = cls;
+  struct GNUNET_FS_PublishContext *pc = cls;
   if (NULL != emsg)
     {
-      signal_publish_error (sc->fi,
-                           sc,
+      signal_publish_error (pc->fi,
+                           pc,
                            emsg);
+      GNUNET_FS_publish_sync_ (pc);
       return;
     }  
   // FIXME: release the datastore reserve here!
-  signal_publish_completion (sc->fi, sc);
-  sc->all_done = GNUNET_YES;
+  signal_publish_completion (pc->fi, pc);
+  pc->all_done = GNUNET_YES;
+  GNUNET_FS_publish_sync_ (pc);
 }
 
 
@@ -303,32 +299,43 @@ publish_kblocks_cont (void *cls,
                      const struct GNUNET_FS_Uri *uri,
                      const char *emsg)
 {
-  struct GNUNET_FS_PublishContext *sc = cls;
-  struct GNUNET_FS_FileInformation *p = sc->fi_pos;
+  struct GNUNET_FS_PublishContext *pc = cls;
+  struct GNUNET_FS_FileInformation *p = pc->fi_pos;
 
   if (NULL != emsg)
     {
-      signal_publish_error (p, sc, emsg);
-      sc->upload_task 
-       = GNUNET_SCHEDULER_add_with_priority (sc->h->sched,
+#if DEBUG_PUBLISH
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                 "Error uploading KSK blocks: %s\n",
+                 emsg);
+#endif
+      signal_publish_error (p, pc, emsg);
+      GNUNET_FS_file_information_sync_ (p);
+      GNUNET_FS_publish_sync_ (pc);
+      pc->upload_task 
+       = GNUNET_SCHEDULER_add_with_priority (pc->h->sched,
                                              GNUNET_SCHEDULER_PRIORITY_BACKGROUND,
-                                             &do_upload,
-                                             sc);
+                                             &GNUNET_FS_publish_main_,
+                                             pc);
       return;
     }
-  GNUNET_FS_file_information_sync (p);
+#if DEBUG_PUBLISH
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+             "KSK blocks published, moving on to next file\n");
+#endif
   if (NULL != p->dir)
-    signal_publish_completion (p, sc);
+    signal_publish_completion (p, pc);    
   /* move on to next file */
   if (NULL != p->next)
-    sc->fi_pos = p->next;
+    pc->fi_pos = p->next;
   else
-    sc->fi_pos = p->dir;
-  sc->upload_task 
-    = GNUNET_SCHEDULER_add_with_priority (sc->h->sched,
+    pc->fi_pos = p->dir;
+  GNUNET_FS_publish_sync_ (pc);
+  pc->upload_task 
+    = GNUNET_SCHEDULER_add_with_priority (pc->h->sched,
                                          GNUNET_SCHEDULER_PRIORITY_BACKGROUND,
-                                         &do_upload,
-                                         sc);
+                                         &GNUNET_FS_publish_main_,
+                                         pc);
 }
 
 
@@ -402,7 +409,7 @@ encode_cont (void *cls,
   struct GNUNET_FS_FileInformation *p;
   struct GNUNET_FS_ProgressInfo pi;
   char *emsg;
-  
+
   p = sc->fi_pos;
   GNUNET_FS_tree_encoder_finish (p->te,
                                 &p->chk_uri,
@@ -410,25 +417,30 @@ encode_cont (void *cls,
   p->te = NULL;
   if (NULL != emsg)
     {
+#if DEBUG_PUBLISH
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                 "Error during tree walk: %s\n",
+                 emsg);
+#endif
       GNUNET_asprintf (&p->emsg, 
                       _("Upload failed: %s"),
                       emsg);
       GNUNET_free (emsg);
-      GNUNET_FS_file_information_sync (p);
       pi.status = GNUNET_FS_STATUS_PUBLISH_ERROR;
-      make_publish_status (&pi, sc, p, 0);
       pi.value.publish.eta = GNUNET_TIME_UNIT_FOREVER_REL;
       pi.value.publish.specifics.error.message = p->emsg;
-      p->client_info
-       = sc->h->upcb (sc->h->upcb_cls,
-                      &pi);
+      p->client_info =  GNUNET_FS_publish_make_status_ (&pi, sc, p, 0);
     }
+#if DEBUG_PUBLISH
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+             "Finished with tree encoder\n");
+#endif  
   /* continue with main */
   sc->upload_task 
     = GNUNET_SCHEDULER_add_with_priority (sc->h->sched,
                                          GNUNET_SCHEDULER_PRIORITY_BACKGROUND,
-                                   &do_upload,
-                                   sc);
+                                         &GNUNET_FS_publish_main_,
+                                         sc);
 }
 
 
@@ -449,7 +461,7 @@ static void
 block_proc (void *cls,
            const GNUNET_HashCode *query,
            uint64_t offset,
-           uint32_t type,
+           enum GNUNET_BLOCK_Type type,
            const void *block,
            uint16_t block_size)
 {
@@ -461,24 +473,28 @@ block_proc (void *cls,
   p = sc->fi_pos;
   if (NULL == sc->dsh)
     {
+#if DEBUG_PUBLISH
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                 "Waiting for datastore connection\n");
+#endif
       sc->upload_task
        = GNUNET_SCHEDULER_add_with_priority (sc->h->sched,
-                                       GNUNET_SCHEDULER_PRIORITY_BACKGROUND,
-                                       &do_upload,
-                                       sc);
+                                             GNUNET_SCHEDULER_PRIORITY_BACKGROUND,
+                                             &GNUNET_FS_publish_main_,
+                                             sc);
       return;
     }
   
   GNUNET_assert (GNUNET_NO == sc->in_network_wait);
   sc->in_network_wait = GNUNET_YES;
   dpc_cls = GNUNET_malloc(sizeof(struct PutContCtx));
-  dpc_cls->cont = &do_upload;
+  dpc_cls->cont = &GNUNET_FS_publish_main_;
   dpc_cls->cont_cls = sc;
   dpc_cls->sc = sc;
   dpc_cls->p = p;
   if ( (! p->is_directory) &&
        (GNUNET_YES == p->data.file.do_index) &&
-       (type == GNUNET_DATASTORE_BLOCKTYPE_DBLOCK) )
+       (type == GNUNET_BLOCK_TYPE_DBLOCK) )
     {
 #if DEBUG_PUBLISH
       GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
@@ -494,10 +510,11 @@ block_proc (void *cls,
                            query,
                            sizeof(struct OnDemandBlock),
                            &odb,
-                           GNUNET_DATASTORE_BLOCKTYPE_ONDEMAND,
+                           GNUNET_BLOCK_TYPE_ONDEMAND,
                            p->priority,
                            p->anonymity,
                            p->expirationTime,
+                           -2, 1,
                            GNUNET_CONSTANTS_SERVICE_TIMEOUT,
                            &ds_put_cont,
                            dpc_cls);     
@@ -519,6 +536,7 @@ block_proc (void *cls,
                        p->priority,
                        p->anonymity,
                        p->expirationTime,
+                       -2, 1,
                        GNUNET_CONSTANTS_SERVICE_TIMEOUT,
                        &ds_put_cont,
                        dpc_cls);
@@ -548,14 +566,11 @@ progress_proc (void *cls,
 
   p = sc->fi_pos;
   pi.status = GNUNET_FS_STATUS_PUBLISH_PROGRESS;
-  make_publish_status (&pi, sc, p, offset);
   pi.value.publish.specifics.progress.data = pt_block;
   pi.value.publish.specifics.progress.offset = offset;
   pi.value.publish.specifics.progress.data_len = pt_size;
   pi.value.publish.specifics.progress.depth = depth;
-  p->client_info 
-    = sc->h->upcb (sc->h->upcb_cls,
-                  &pi);
+  p->client_info = GNUNET_FS_publish_make_status_ (&pi, sc, p, offset);
 }
 
 
@@ -577,10 +592,15 @@ publish_content (struct GNUNET_FS_PublishContext *sc)
   uint64_t size;
 
   p = sc->fi_pos;
+  GNUNET_assert (p != NULL);
   if (NULL == p->te)
     {
       if (p->is_directory)
        {
+#if DEBUG_PUBLISH
+         GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                     "Creating directory\n");
+#endif
          db = GNUNET_FS_directory_builder_create (p->meta);
          dirpos = p->data.dir.entries;
          while (NULL != dirpos)
@@ -621,10 +641,15 @@ publish_content (struct GNUNET_FS_PublishContext *sc)
          GNUNET_FS_directory_builder_finish (db,
                                              &p->data.dir.dir_size,
                                              &p->data.dir.dir_data);
+         GNUNET_FS_file_information_sync_ (p);
        }
       size = (p->is_directory) 
        ? p->data.dir.dir_size 
        : p->data.file.file_size;
+#if DEBUG_PUBLISH
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                 "Creating tree encoder\n");
+#endif
       p->te = GNUNET_FS_tree_encoder_create (sc->h,
                                             size,
                                             sc,
@@ -634,6 +659,10 @@ publish_content (struct GNUNET_FS_PublishContext *sc)
                                             &encode_cont);
 
     }
+#if DEBUG_PUBLISH
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+             "Processing next block from tree\n");
+#endif
   GNUNET_FS_tree_encoder_next (p->te);
 }
 
@@ -661,9 +690,10 @@ process_index_start_response (void *cls,
     {
       GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
                  _("Can not index file `%s': %s.  Will try to insert instead.\n"),
-                 p->data.file.filename,
+                 p->filename,
                  _("timeout on index-start request to `fs' service"));
       p->data.file.do_index = GNUNET_NO;
+      GNUNET_FS_file_information_sync_ (p);
       publish_content (sc);
       return;
     }
@@ -676,14 +706,16 @@ process_index_start_response (void *cls,
        emsg = gettext_noop ("unknown error");
       GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
                  _("Can not index file `%s': %s.  Will try to insert instead.\n"),
-                 p->data.file.filename,
+                 p->filename,
                  gettext (emsg));
       p->data.file.do_index = GNUNET_NO;
+      GNUNET_FS_file_information_sync_ (p);
       publish_content (sc);
       return;
     }
   p->data.file.index_start_confirmed = GNUNET_YES;
   /* success! continue with indexing */
+  GNUNET_FS_file_information_sync_ (p);
   publish_content (sc);
 }
 
@@ -707,15 +739,17 @@ hash_for_index_cb (void *cls,
   struct GNUNET_CLIENT_Connection *client;
   uint32_t dev;
   uint64_t ino;
+  char *fn;
 
   p = sc->fi_pos;
   if (NULL == res) 
     {
       GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
                  _("Can not index file `%s': %s.  Will try to insert instead.\n"),
-                 p->data.file.filename,
+                 p->filename,
                  _("failed to compute hash"));
       p->data.file.do_index = GNUNET_NO;
+      GNUNET_FS_file_information_sync_ (p);
       publish_content (sc);
       return;
     }
@@ -724,21 +758,25 @@ hash_for_index_cb (void *cls,
       publish_content (sc);
       return;
     }
-  slen = strlen (p->data.file.filename) + 1;
-  if (slen > GNUNET_SERVER_MAX_MESSAGE_SIZE - sizeof(struct IndexStartMessage))
+  fn = GNUNET_STRINGS_filename_expand (p->filename);
+  GNUNET_assert (fn != NULL);
+  slen = strlen (fn) + 1;
+  if (slen >= GNUNET_SERVER_MAX_MESSAGE_SIZE - sizeof(struct IndexStartMessage))
     {
       GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
                  _("Can not index file `%s': %s.  Will try to insert instead.\n"),
-                 p->data.file.filename,
+                 fn,
                  _("filename too long"));
+      GNUNET_free (fn);
       p->data.file.do_index = GNUNET_NO;
+      GNUNET_FS_file_information_sync_ (p);
       publish_content (sc);
       return;
     }
 #if DEBUG_PUBLISH
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
              "Hash of indexed file `%s' is `%s'\n",
-             p->data.file.filename,
+             p->filename,
              GNUNET_h2s (res));
 #endif
   client = GNUNET_CLIENT_connect (sc->h->sched,
@@ -748,21 +786,26 @@ hash_for_index_cb (void *cls,
     {
       GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
                  _("Can not index file `%s': %s.  Will try to insert instead.\n"),
-                 p->data.file.filename,
+                 p->filename,
                  _("could not connect to `fs' service"));
       p->data.file.do_index = GNUNET_NO;
       publish_content (sc);
+      GNUNET_free (fn);
       return;
     }
-  p->data.file.file_id = *res;
-  p->data.file.have_hash = GNUNET_YES;
+  if (p->data.file.have_hash != GNUNET_YES)
+    {
+      p->data.file.file_id = *res;
+      p->data.file.have_hash = GNUNET_YES;
+      GNUNET_FS_file_information_sync_ (p);
+    }
   ism = GNUNET_malloc (sizeof(struct IndexStartMessage) +
                       slen);
   ism->header.size = htons(sizeof(struct IndexStartMessage) +
                           slen);
   ism->header.type = htons(GNUNET_MESSAGE_TYPE_FS_INDEX_START);
   if (GNUNET_OK ==
-      GNUNET_DISK_file_get_identifiers (p->data.file.filename,
+      GNUNET_DISK_file_get_identifiers (p->filename,
                                        &dev,
                                        &ino))
     {
@@ -773,12 +816,13 @@ hash_for_index_cb (void *cls,
     {
       GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
                  _("Failed to get file identifiers for `%s'\n"),
-                 p->data.file.filename);
+                 p->filename);
     }
   ism->file_id = *res;
   memcpy (&ism[1],
-         p->data.file.filename,
+         fn,
          slen);
+  GNUNET_free (fn);
   sc->client = client;
   GNUNET_break (GNUNET_YES ==
                GNUNET_CLIENT_transmit_and_get_response (client,
@@ -793,25 +837,31 @@ hash_for_index_cb (void *cls,
 
 /**
  * Main function that performs the upload.
+ *
  * @param cls "struct GNUNET_FS_PublishContext" identifies the upload
  * @param tc task context
  */
-static void
-do_upload (void *cls,
-          const struct GNUNET_SCHEDULER_TaskContext *tc)
+void
+GNUNET_FS_publish_main_ (void *cls,
+                        const struct GNUNET_SCHEDULER_TaskContext *tc)
 {
-  struct GNUNET_FS_PublishContext *sc = cls;
+  struct GNUNET_FS_PublishContext *pc = cls;
   struct GNUNET_FS_ProgressInfo pi;
   struct GNUNET_FS_FileInformation *p;
   char *fn;
 
-  sc->upload_task = GNUNET_SCHEDULER_NO_TASK;  
-  p = sc->fi_pos;
+  pc->upload_task = GNUNET_SCHEDULER_NO_TASK;  
+  p = pc->fi_pos;
   if (NULL == p)
     {
+#if DEBUG_PUBLISH
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                 "Upload complete, now publishing SKS and KSK blocks.\n");
+#endif
       /* upload of entire hierarchy complete,
         publish namespace entries */
-      publish_sblock (sc);
+      GNUNET_FS_publish_sync_ (pc);
+      publish_sblock (pc);
       return;
     }
   /* find starting position */
@@ -821,11 +871,17 @@ do_upload (void *cls,
          (NULL == p->data.dir.entries->chk_uri) )
     {
       p = p->data.dir.entries;
-      sc->fi_pos = p;
+      pc->fi_pos = p;
+      GNUNET_FS_publish_sync_ (pc);
     }
   /* abort on error */
   if (NULL != p->emsg)
     {
+#if DEBUG_PUBLISH
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                 "Error uploading: %s\n",
+                 p->emsg);
+#endif
       /* error with current file, abort all
         related files as well! */
       while (NULL != p->dir)
@@ -847,38 +903,40 @@ do_upload (void *cls,
                               _("Recursive upload failed: %s"),
                               p->emsg);              
            }
-         GNUNET_FS_file_information_sync (p);
          pi.status = GNUNET_FS_STATUS_PUBLISH_ERROR;
-         make_publish_status (&pi, sc, p, 0);
          pi.value.publish.eta = GNUNET_TIME_UNIT_FOREVER_REL;
          pi.value.publish.specifics.error.message = p->emsg;
-         p->client_info
-           = sc->h->upcb (sc->h->upcb_cls,
-                          &pi);
+         p->client_info = GNUNET_FS_publish_make_status_ (&pi, pc, p, 0);
        }
-      sc->all_done = GNUNET_YES;
+      pc->all_done = GNUNET_YES;
+      GNUNET_FS_publish_sync_ (pc);
       return;
     }
   /* handle completion */
   if (NULL != p->chk_uri)
     {
+#if DEBUG_PUBLISH
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                 "File upload complete, now publishing KSK blocks.\n");
+#endif
+      GNUNET_FS_publish_sync_ (pc);
       /* upload of "p" complete, publish KBlocks! */
       if (p->keywords != NULL)
        {
-         GNUNET_FS_publish_ksk (sc->h,
+         GNUNET_FS_publish_ksk (pc->h,
                                 p->keywords,
                                 p->meta,
                                 p->chk_uri,
                                 p->expirationTime,
                                 p->anonymity,
                                 p->priority,
-                                sc->options,
+                                pc->options,
                                 &publish_kblocks_cont,
-                                sc);
+                                pc);
        }
       else
        {
-         publish_kblocks_cont (sc,
+         publish_kblocks_cont (pc,
                                p->chk_uri,
                                NULL);
        }
@@ -887,32 +945,35 @@ do_upload (void *cls,
   if ( (!p->is_directory) &&
        (p->data.file.do_index) )
     {
-      if (NULL == p->data.file.filename)
+      if (NULL == p->filename)
        {
          p->data.file.do_index = GNUNET_NO;
          GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
                      _("Can not index file `%s': %s.  Will try to insert instead.\n"),
                      "<no-name>",
                      _("needs to be an actual file"));
-         publish_content (sc);
+         GNUNET_FS_file_information_sync_ (p);
+         publish_content (pc);
          return;
        }      
       if (p->data.file.have_hash)
-       hash_for_index_cb (sc,
-                          &p->data.file.file_id);
+       {
+         hash_for_index_cb (pc,
+                            &p->data.file.file_id);
+       }
       else
        {
          p->start_time = GNUNET_TIME_absolute_get ();
-         GNUNET_CRYPTO_hash_file (sc->h->sched,
+         GNUNET_CRYPTO_hash_file (pc->h->sched,
                                   GNUNET_SCHEDULER_PRIORITY_IDLE,
-                                  p->data.file.filename,
+                                  p->filename,
                                   HASHING_BLOCKSIZE,
                                   &hash_for_index_cb,
-                                  sc);
+                                  pc);
        }
       return;
     }
-  publish_content (sc);
+  publish_content (pc);
 }
 
 
@@ -927,6 +988,7 @@ do_upload (void *cls,
  * @param uri pointer to the keywords that will be used for this entry (can be modified)
  * @param anonymity pointer to selected anonymity level (can be modified)
  * @param priority pointer to selected priority (can be modified)
+ * @param do_index should we index?
  * @param expirationTime pointer to selected expiration time (can be modified)
  * @param client_info pointer to client context set upon creation (can be modified)
  * @return GNUNET_OK to continue (always)
@@ -939,6 +1001,7 @@ fip_signal_start(void *cls,
                 struct GNUNET_FS_Uri **uri,
                 uint32_t *anonymity,
                 uint32_t *priority,
+                int *do_index,
                 struct GNUNET_TIME_Absolute *expirationTime,
                 void **client_info)
 {
@@ -946,13 +1009,83 @@ fip_signal_start(void *cls,
   struct GNUNET_FS_ProgressInfo pi;
 
   pi.status = GNUNET_FS_STATUS_PUBLISH_START;
-  make_publish_status (&pi, sc, fi, 0);
-  *client_info = sc->h->upcb (sc->h->upcb_cls,
-                             &pi);
+  *client_info = GNUNET_FS_publish_make_status_ (&pi, sc, fi, 0);
+  GNUNET_FS_file_information_sync_ (fi);
   return GNUNET_OK;
 }
 
 
+/**
+ * Signal the FS's progress function that we are suspending
+ * an upload.
+ *
+ * @param cls closure (of type "struct GNUNET_FS_PublishContext*")
+ * @param fi the entry in the publish-structure
+ * @param length length of the file or directory
+ * @param meta metadata for the file or directory (can be modified)
+ * @param uri pointer to the keywords that will be used for this entry (can be modified)
+ * @param anonymity pointer to selected anonymity level (can be modified)
+ * @param priority pointer to selected priority (can be modified)
+ * @param do_index should we index?
+ * @param expirationTime pointer to selected expiration time (can be modified)
+ * @param client_info pointer to client context set upon creation (can be modified)
+ * @return GNUNET_OK to continue (always)
+ */
+static int
+fip_signal_suspend(void *cls,
+                  struct GNUNET_FS_FileInformation *fi,
+                  uint64_t length,
+                  struct GNUNET_CONTAINER_MetaData *meta,
+                  struct GNUNET_FS_Uri **uri,
+                  uint32_t *anonymity,
+                  uint32_t *priority,
+                  int *do_index,
+                  struct GNUNET_TIME_Absolute *expirationTime,
+                  void **client_info)
+{
+  struct GNUNET_FS_PublishContext*sc = cls;
+  struct GNUNET_FS_ProgressInfo pi;
+  uint64_t off;
+
+  GNUNET_free_non_null (fi->serialization);
+  fi->serialization = NULL;    
+  off = (fi->chk_uri == NULL) ? 0 : length;
+  pi.status = GNUNET_FS_STATUS_PUBLISH_SUSPEND;
+  GNUNET_break (NULL == GNUNET_FS_publish_make_status_ (&pi, sc, fi, off));
+  *client_info = NULL;
+  if (NULL != sc->dsh)
+    {
+      GNUNET_DATASTORE_disconnect (sc->dsh, GNUNET_NO);
+      sc->dsh = NULL;
+    }
+  return GNUNET_OK;
+}
+
+
+/**
+ * Create SUSPEND event for the given publish operation
+ * and then clean up our state (without stop signal).
+ *
+ * @param cls the 'struct GNUNET_FS_PublishContext' to signal for
+ */
+void
+GNUNET_FS_publish_signal_suspend_ (void *cls)
+{
+  struct GNUNET_FS_PublishContext *pc = cls;
+
+  if (GNUNET_SCHEDULER_NO_TASK != pc->upload_task)
+    {
+      GNUNET_SCHEDULER_cancel (pc->h->sched, pc->upload_task);
+      pc->upload_task = GNUNET_SCHEDULER_NO_TASK;
+    }
+  GNUNET_FS_file_information_inspect (pc->fi,
+                                     &fip_signal_suspend,
+                                     pc);
+  GNUNET_FS_end_top (pc->h, pc->top);
+  publish_cleanup (pc, NULL);
+}
+
+
 /**
  * Publish a file or directory.
  *
@@ -1001,22 +1134,21 @@ GNUNET_FS_publish_start (struct GNUNET_FS_Handle *h,
       if (NULL != nuid)
        ret->nuid = GNUNET_strdup (nuid);
     }
-  // FIXME: make upload persistent!
-
   /* signal start */
   GNUNET_FS_file_information_inspect (ret->fi,
                                      &fip_signal_start,
                                      ret);
   ret->fi_pos = ret->fi;
-
+  ret->top = GNUNET_FS_make_top (h, &GNUNET_FS_publish_signal_suspend_, ret);
+  GNUNET_FS_publish_sync_ (ret);
   // FIXME: calculate space needed for "fi"
   // and reserve as first task (then trigger
-  // "do_upload" from that continuation)!
+  // "publish_main" from that continuation)!
   ret->upload_task 
     = GNUNET_SCHEDULER_add_with_priority (h->sched,
-                                   GNUNET_SCHEDULER_PRIORITY_BACKGROUND,
-                                   &do_upload,
-                                   ret);
+                                         GNUNET_SCHEDULER_PRIORITY_BACKGROUND,
+                                         &GNUNET_FS_publish_main_,
+                                         ret);
   return ret;
 }
 
@@ -1032,6 +1164,7 @@ GNUNET_FS_publish_start (struct GNUNET_FS_Handle *h,
  * @param uri pointer to the keywords that will be used for this entry (can be modified)
  * @param anonymity pointer to selected anonymity level (can be modified)
  * @param priority pointer to selected priority (can be modified)
+ * @param do_index should we index?
  * @param expirationTime pointer to selected expiration time (can be modified)
  * @param client_info pointer to client context set upon creation (can be modified)
  * @return GNUNET_OK to continue (always)
@@ -1044,6 +1177,7 @@ fip_signal_stop(void *cls,
                struct GNUNET_FS_Uri **uri,
                uint32_t *anonymity,
                uint32_t *priority,
+               int *do_index,
                struct GNUNET_TIME_Absolute *expirationTime,
                void **client_info)
 {
@@ -1051,12 +1185,17 @@ fip_signal_stop(void *cls,
   struct GNUNET_FS_ProgressInfo pi;
   uint64_t off;
 
+  if (fi->serialization != NULL) 
+    {
+      GNUNET_FS_remove_sync_file_ (sc->h,
+                                  GNUNET_FS_SYNC_PATH_FILE_INFO,
+                                  fi->serialization);
+      GNUNET_free (fi->serialization);
+      fi->serialization = NULL;
+    }
   off = (fi->chk_uri == NULL) ? 0 : length;
   pi.status = GNUNET_FS_STATUS_PUBLISH_STOPPED;
-  make_publish_status (&pi, sc, fi, off);
-  GNUNET_break (NULL ==
-               sc->h->upcb (sc->h->upcb_cls,
-                            &pi));
+  GNUNET_break (NULL == GNUNET_FS_publish_make_status_ (&pi, sc, fi, off));
   *client_info = NULL;
   return GNUNET_OK;
 }
@@ -1068,26 +1207,37 @@ fip_signal_stop(void *cls,
  * simply clean up the state for completed uploads.
  * Must NOT be called from within the event callback!
  *
- * @param sc context for the upload to stop
+ * @param pc context for the upload to stop
  */
 void 
-GNUNET_FS_publish_stop (struct GNUNET_FS_PublishContext *sc)
+GNUNET_FS_publish_stop (struct GNUNET_FS_PublishContext *pc)
 {
-  if (GNUNET_SCHEDULER_NO_TASK != sc->upload_task)
-    GNUNET_SCHEDULER_cancel (sc->h->sched, sc->upload_task);
-  else
-    GNUNET_assert (sc->all_done == GNUNET_YES);
-  // FIXME: remove from persistence DB (?) --- think more about
-  //        shutdown / persistent-resume APIs!!!
-  GNUNET_FS_file_information_inspect (sc->fi,
+  GNUNET_FS_end_top (pc->h, pc->top);
+  if (NULL != pc->dsh)
+    {
+      GNUNET_DATASTORE_disconnect (pc->dsh, GNUNET_NO);
+      pc->dsh = NULL;
+    }
+  if (GNUNET_SCHEDULER_NO_TASK != pc->upload_task)
+    {
+      GNUNET_SCHEDULER_cancel (pc->h->sched, pc->upload_task);
+      pc->upload_task = GNUNET_SCHEDULER_NO_TASK;
+    }
+  if (pc->serialization != NULL) 
+    {
+      GNUNET_FS_remove_sync_file_ (pc->h, GNUNET_FS_SYNC_PATH_MASTER_PUBLISH, pc->serialization);
+      GNUNET_free (pc->serialization);
+      pc->serialization = NULL;
+    }
+  GNUNET_FS_file_information_inspect (pc->fi,
                                      &fip_signal_stop,
-                                     sc);
-  if (GNUNET_YES == sc->in_network_wait)
+                                     pc);
+  if (GNUNET_YES == pc->in_network_wait)
     {
-      sc->in_network_wait = GNUNET_SYSERR;
+      pc->in_network_wait = GNUNET_SYSERR;
       return;
     }
-  publish_cleanup (sc);
+  publish_cleanup (pc, NULL);
 }
 
 
@@ -1198,7 +1348,11 @@ kb_put_cont (void *cls,
 
   if (GNUNET_OK != success)
     {
-      GNUNET_DATASTORE_disconnect (pkc->dsh, GNUNET_NO);
+      if (NULL != pkc->dsh)
+       {
+         GNUNET_DATASTORE_disconnect (pkc->dsh, GNUNET_NO);
+         pkc->dsh = NULL;
+       }
       GNUNET_free (pkc->cpy);
       GNUNET_free (pkc->kb);
       pkc->cont (pkc->cont_cls,
@@ -1239,7 +1393,10 @@ publish_ksk_cont (void *cls,
        (NULL == pkc->dsh) )
     {
       if (NULL != pkc->dsh)
-       GNUNET_DATASTORE_disconnect (pkc->dsh, GNUNET_NO);
+       {
+         GNUNET_DATASTORE_disconnect (pkc->dsh, GNUNET_NO);
+         pkc->dsh = NULL;
+       }
       GNUNET_free (pkc->cpy);
       GNUNET_free (pkc->kb);
       pkc->cont (pkc->cont_cls,
@@ -1260,6 +1417,7 @@ publish_ksk_cont (void *cls,
                             &iv,
                             &pkc->cpy[1]);
   pk = GNUNET_CRYPTO_rsa_key_create_from_hash (&key);
+  GNUNET_assert (NULL != pk);
   GNUNET_CRYPTO_rsa_key_get_public (pk, &pkc->cpy->keyspace);
   GNUNET_CRYPTO_hash (&pkc->cpy->keyspace,
                      sizeof (struct GNUNET_CRYPTO_RsaPublicKeyBinaryEncoded),
@@ -1276,10 +1434,11 @@ publish_ksk_cont (void *cls,
                        sizeof (struct KBlock) + 
                        pkc->slen,
                        pkc->cpy,
-                       GNUNET_DATASTORE_BLOCKTYPE_KBLOCK, 
+                       GNUNET_BLOCK_TYPE_KBLOCK, 
                        pkc->priority,
                        pkc->anonymity,
                        pkc->expirationTime,
+                       -2, 1,
                        GNUNET_CONSTANTS_SERVICE_TIMEOUT,
                        &kb_put_cont,
                        pkc);
@@ -1364,7 +1523,10 @@ GNUNET_FS_publish_ksk (struct GNUNET_FS_Handle *h,
       GNUNET_break (0);
       GNUNET_free (pkc->kb);
       if (pkc->dsh != NULL)
-       GNUNET_DATASTORE_disconnect (pkc->dsh, GNUNET_NO);
+       {
+         GNUNET_DATASTORE_disconnect (pkc->dsh, GNUNET_NO);
+         pkc->dsh = NULL;
+       }
       cont (cont_cls, NULL, _("Internal error."));
       GNUNET_free (pkc);
       return;
@@ -1430,7 +1592,10 @@ sb_put_cont (void *cls,
   struct PublishSksContext *psc = cls;
 
   if (NULL != psc->dsh)
-    GNUNET_DATASTORE_disconnect (psc->dsh, GNUNET_NO);
+    {
+      GNUNET_DATASTORE_disconnect (psc->dsh, GNUNET_NO);
+      psc->dsh = NULL;
+    }
   if (GNUNET_OK != success)
     psc->cont (psc->cont_cls,
               NULL,
@@ -1465,7 +1630,7 @@ GNUNET_FS_publish_sks (struct GNUNET_FS_Handle *h,
                       struct GNUNET_FS_Namespace *namespace,
                       const char *identifier,
                       const char *update,
-                      struct GNUNET_CONTAINER_MetaData *meta,
+                      const struct GNUNET_CONTAINER_MetaData *meta,
                       const struct GNUNET_FS_Uri *uri,
                       struct GNUNET_TIME_Absolute expirationTime,
                       uint32_t anonymity,
@@ -1487,17 +1652,22 @@ GNUNET_FS_publish_sks (struct GNUNET_FS_Handle *h,
   struct SBlock *sb;
   struct SBlock *sb_enc;
   char *dest;
+  struct GNUNET_CONTAINER_MetaData *mmeta;
   GNUNET_HashCode key;         /* hash of thisId = key */
   GNUNET_HashCode id;          /* hash of hc = identifier */
   GNUNET_HashCode query;       /* id ^ nsid = DB query */
 
+  if (NULL == meta)
+    mmeta = GNUNET_CONTAINER_meta_data_create ();
+  else
+    mmeta = GNUNET_CONTAINER_meta_data_duplicate (meta);
   uris = GNUNET_FS_uri_to_string (uri);
   slen = strlen (uris) + 1;
   idlen = strlen (identifier);
   if (update == NULL)
     update = "";
   nidlen = strlen (update) + 1;
-  mdsize = GNUNET_CONTAINER_meta_data_get_serialized_size (meta);
+  mdsize = GNUNET_CONTAINER_meta_data_get_serialized_size (mmeta);
   size = sizeof (struct SBlock) + slen + nidlen + mdsize;
   if (size > MAX_SBLOCK_SIZE)
     {
@@ -1509,15 +1679,16 @@ GNUNET_FS_publish_sks (struct GNUNET_FS_Handle *h,
   memcpy (dest, update, nidlen);
   dest += nidlen;
   memcpy (dest, uris, slen);
+  GNUNET_free (uris);
   dest += slen;
-  mdsize = GNUNET_CONTAINER_meta_data_serialize (meta,
+  mdsize = GNUNET_CONTAINER_meta_data_serialize (mmeta,
                                                 &dest,
                                                 mdsize, 
                                                 GNUNET_CONTAINER_META_DATA_SERIALIZE_PART);
+  GNUNET_CONTAINER_meta_data_destroy (mmeta);
   if (mdsize == -1)
     {
       GNUNET_break (0);
-      GNUNET_free (uris);
       GNUNET_free (sb);
       cont (cont_cls,
            NULL,
@@ -1583,14 +1754,14 @@ GNUNET_FS_publish_sks (struct GNUNET_FS_Handle *h,
                        &sb_enc->identifier,
                        size,
                        sb_enc,
-                       GNUNET_DATASTORE_BLOCKTYPE_SBLOCK, 
+                       GNUNET_BLOCK_TYPE_SBLOCK, 
                        priority,
                        anonymity,
                        expirationTime,
+                       -2, 1,
                        GNUNET_CONSTANTS_SERVICE_TIMEOUT,
                        &sb_put_cont,
                        psc);
-
   GNUNET_free (sb);
   GNUNET_free (sb_enc);
 }