make clang static analysis happy
[oweals/gnunet.git] / src / fs / fs_download.c
index 7776f4b8bf8cd9cfa6873294bff5f527423c2b83..6e215ed27a98025de3769e98f1c5cda7dee6ab96 100644 (file)
@@ -1,6 +1,6 @@
 /*
      This file is part of GNUnet.
-     (C) 2001, 2002, 2003, 2004, 2005, 2006, 2008, 2009 Christian Grothoff (and other contributing authors)
+     (C) 2001, 2002, 2003, 2004, 2005, 2006, 2008, 2009, 2010 Christian Grothoff (and other contributing authors)
 
      GNUnet is free software; you can redistribute it and/or modify
      it under the terms of the GNU General Public License as published
  * @author Christian Grothoff
  *
  * TODO:
+ * - handle recursive downloads (need directory & 
+ *   fs-level download-parallelism management)
+ * - handle recursive downloads where directory file is
+ *   NOT saved on disk (need temporary file instead then!)
  * - location URI suppport (can wait, easy)
  * - check if blocks exist already (can wait, easy)
- * - handle recursive downloads (need directory & 
- *   fs-level download-parallelism management, can wait)
  * - check if iblocks can be computed from existing blocks (can wait, hard)
  * - persistence (can wait)
  */
 #include "fs.h"
 #include "fs_tree.h"
 
-#define DEBUG_DOWNLOAD GNUNET_YES
+#define DEBUG_DOWNLOAD GNUNET_NO
 
 /**
- * We're storing the IBLOCKS after the
- * DBLOCKS on disk (so that we only have
- * to truncate the file once we're done).
+ * We're storing the IBLOCKS after the DBLOCKS on disk (so that we
+ * only have to truncate the file once we're done).
  *
- * Given the offset of a block (with respect
- * to the DBLOCKS) and its depth, return the
- * offset where we would store this block
- * in the file.
-
+ * Given the offset of a block (with respect to the DBLOCKS) and its
+ * depth, return the offset where we would store this block in the
+ * file.
  * 
  * @param fsize overall file size
  * @param off offset of the block in the file
@@ -152,6 +151,10 @@ make_download_status (struct GNUNET_FS_ProgressInfo *pi,
     = dc->completed;
   pi->value.download.anonymity
     = dc->anonymity;
+  pi->value.download.eta
+    = GNUNET_TIME_calculate_eta (dc->start_time,
+                                dc->completed,
+                                dc->length);
 }
 
 /**
@@ -172,8 +175,7 @@ transmit_download_request (void *cls,
 
 
 /**
- * Schedule the download of the specified
- * block in the tree.
+ * Schedule the download of the specified block in the tree.
  *
  * @param dc overall download this block belongs to
  * @param chk content-hash-key of the block
@@ -241,8 +243,143 @@ schedule_block_download (struct GNUNET_FS_DownloadContext *dc,
                                                  GNUNET_CONSTANTS_SERVICE_TIMEOUT,
                                                  GNUNET_NO,
                                                  &transmit_download_request,
-                                                 dc); 
+                                                 dc);
+}
+
+
+
+/**
+ * Suggest a filename based on given metadata.
+ * 
+ * @param md given meta data
+ * @return NULL if meta data is useless for suggesting a filename
+ */
+char *
+GNUNET_FS_meta_data_suggest_filename (const struct GNUNET_CONTAINER_MetaData *md)
+{
+  static const char *mimeMap[][2] = {
+    {"application/bz2", ".bz2"},
+    {"application/gnunet-directory", ".gnd"},
+    {"application/java", ".class"},
+    {"application/msword", ".doc"},
+    {"application/ogg", ".ogg"},
+    {"application/pdf", ".pdf"},
+    {"application/pgp-keys", ".key"},
+    {"application/pgp-signature", ".pgp"},
+    {"application/postscript", ".ps"},
+    {"application/rar", ".rar"},
+    {"application/rtf", ".rtf"},
+    {"application/xml", ".xml"},
+    {"application/x-debian-package", ".deb"},
+    {"application/x-dvi", ".dvi"},
+    {"applixation/x-flac", ".flac"},
+    {"applixation/x-gzip", ".gz"},
+    {"application/x-java-archive", ".jar"},
+    {"application/x-java-vm", ".class"},
+    {"application/x-python-code", ".pyc"},
+    {"application/x-redhat-package-manager", ".rpm"},
+    {"application/x-rpm", ".rpm"},
+    {"application/x-tar", ".tar"},
+    {"application/x-tex-pk", ".pk"},
+    {"application/x-texinfo", ".texinfo"},
+    {"application/x-xcf", ".xcf"},
+    {"application/x-xfig", ".xfig"},
+    {"application/zip", ".zip"},
+    
+    {"audio/midi", ".midi"},
+    {"audio/mpeg", ".mp3"},
+    {"audio/real", ".rm"},
+    {"audio/x-wav", ".wav"},
+    
+    {"image/gif", ".gif"},
+    {"image/jpeg", ".jpg"},
+    {"image/pcx", ".pcx"},
+    {"image/png", ".png"},
+    {"image/tiff", ".tiff"},
+    {"image/x-ms-bmp", ".bmp"},
+    {"image/x-xpixmap", ".xpm"},
+    
+    {"text/css", ".css"},
+    {"text/html", ".html"},
+    {"text/plain", ".txt"},
+    {"text/rtf", ".rtf"},
+    {"text/x-c++hdr", ".h++"},
+    {"text/x-c++src", ".c++"},
+    {"text/x-chdr", ".h"},
+    {"text/x-csrc", ".c"},
+    {"text/x-java", ".java"},
+    {"text/x-moc", ".moc"},
+    {"text/x-pascal", ".pas"},
+    {"text/x-perl", ".pl"},
+    {"text/x-python", ".py"},
+    {"text/x-tex", ".tex"},
+    
+    {"video/avi", ".avi"},
+    {"video/mpeg", ".mpeg"},
+    {"video/quicktime", ".qt"},
+    {"video/real", ".rm"},
+    {"video/x-msvideo", ".avi"},
+    {NULL, NULL},
+  };
+  char *ret;
+  unsigned int i;
+  char *mime;
+  char *base;
+  const char *ext;
 
+  ret = GNUNET_CONTAINER_meta_data_get_by_type (md,
+                                               EXTRACTOR_METATYPE_FILENAME);
+  if (ret != NULL)
+    return ret;  
+  ext = NULL;
+  mime = GNUNET_CONTAINER_meta_data_get_by_type (md,
+                                                EXTRACTOR_METATYPE_MIMETYPE);
+  if (mime != NULL)
+    {
+      i = 0;
+      while ( (mimeMap[i][0] != NULL) && 
+             (0 != strcmp (mime, mimeMap[i][0])))
+        i++;
+      if (mimeMap[i][1] == NULL)
+        GNUNET_log (GNUNET_ERROR_TYPE_DEBUG | 
+                   GNUNET_ERROR_TYPE_BULK,
+                   _("Did not find mime type `%s' in extension list.\n"),
+                   mime);
+      else
+       ext = mimeMap[i][1];
+      GNUNET_free (mime);
+    }
+  base = GNUNET_CONTAINER_meta_data_get_first_by_types (md,
+                                                       EXTRACTOR_METATYPE_TITLE,
+                                                       EXTRACTOR_METATYPE_BOOK_TITLE,
+                                                       EXTRACTOR_METATYPE_ORIGINAL_TITLE,
+                                                       EXTRACTOR_METATYPE_PACKAGE_NAME,
+                                                       EXTRACTOR_METATYPE_URL,
+                                                       EXTRACTOR_METATYPE_URI, 
+                                                       EXTRACTOR_METATYPE_DESCRIPTION,
+                                                       EXTRACTOR_METATYPE_ISRC,
+                                                       EXTRACTOR_METATYPE_JOURNAL_NAME,
+                                                       EXTRACTOR_METATYPE_AUTHOR_NAME,
+                                                       EXTRACTOR_METATYPE_SUBJECT,
+                                                       EXTRACTOR_METATYPE_ALBUM,
+                                                       EXTRACTOR_METATYPE_ARTIST,
+                                                       EXTRACTOR_METATYPE_KEYWORDS,
+                                                       EXTRACTOR_METATYPE_COMMENT,
+                                                       EXTRACTOR_METATYPE_UNKNOWN,
+                                                       -1);
+  if ( (base == NULL) &&
+       (ext == NULL) )
+    return NULL;
+  if (base == NULL)
+    return GNUNET_strdup (ext);
+  if (ext == NULL)
+    return base;
+  GNUNET_asprintf (&ret,
+                  "%s%s",
+                  base,
+                  ext);
+  GNUNET_free (base);
+  return ret;
 }
 
 
@@ -336,6 +473,275 @@ struct ProcessResultClosure
 };
 
 
+/**
+ * We found an entry in a directory.  Check if the respective child
+ * already exists and if not create the respective child download.
+ *
+ * @param cls the parent download
+ * @param filename name of the file in the directory
+ * @param uri URI of the file (CHK or LOC)
+ * @param meta meta data of the file
+ * @param length number of bytes in data
+ * @param data contents of the file (or NULL if they were not inlined)
+ */
+static void 
+trigger_recursive_download (void *cls,
+                           const char *filename,
+                           const struct GNUNET_FS_Uri *uri,
+                           const struct GNUNET_CONTAINER_MetaData *meta,
+                           size_t length,
+                           const void *data)
+{
+  struct GNUNET_FS_DownloadContext *dc = cls;  
+  struct GNUNET_FS_DownloadContext *cpos;
+  struct GNUNET_DISK_FileHandle *fh;
+  char *fn;
+  char *us;
+  char *ext;
+  char *dn;
+  char *full_name;
+
+  if (NULL == uri)
+    return; /* entry for the directory itself */
+  cpos = dc->child_head;
+  while (cpos != NULL)
+    {
+      if ( (GNUNET_FS_uri_test_equal (uri,
+                                     cpos->uri)) ||
+          ( (filename != NULL) &&
+            (0 == strcmp (cpos->filename,
+                          filename)) ) )
+       break;  
+      cpos = cpos->next;
+    }
+  if (cpos != NULL)
+    return; /* already exists */
+  fn = NULL;
+  if (NULL == filename)
+    {
+      fn = GNUNET_FS_meta_data_suggest_filename (meta);      
+      if (fn == NULL)
+       {
+         us = GNUNET_FS_uri_to_string (uri);
+         fn = GNUNET_strdup (&us [strlen (GNUNET_FS_URI_PREFIX 
+                                          GNUNET_FS_URI_CHK_INFIX)]);
+         GNUNET_free (us);
+       }
+      else if (fn[0] == '.')
+       {
+         ext = fn;
+         us = GNUNET_FS_uri_to_string (uri);
+         GNUNET_asprintf (&fn,
+                          "%s%s",
+                          &us[strlen (GNUNET_FS_URI_PREFIX 
+                                      GNUNET_FS_URI_CHK_INFIX)], ext);
+         GNUNET_free (ext);
+         GNUNET_free (us);
+       }
+      filename = fn;
+    }
+  if (dc->filename == NULL)
+    {
+      full_name = NULL;
+    }
+  else
+    {
+      dn = GNUNET_strdup (dc->filename);
+      GNUNET_break ( (strlen (dn) >= strlen (GNUNET_FS_DIRECTORY_EXT)) &&
+                    (NULL !=
+                     strstr (dn + strlen(dn) - strlen(GNUNET_FS_DIRECTORY_EXT),
+                             GNUNET_FS_DIRECTORY_EXT)) );
+      if ( (strlen (dn) >= strlen (GNUNET_FS_DIRECTORY_EXT)) &&
+          (NULL !=
+           strstr (dn + strlen(dn) - strlen(GNUNET_FS_DIRECTORY_EXT),
+                   GNUNET_FS_DIRECTORY_EXT)) )      
+       dn[strlen(dn) - strlen (GNUNET_FS_DIRECTORY_EXT)] = '\0';      
+      if ( (GNUNET_YES == GNUNET_FS_meta_data_test_for_directory (meta)) &&
+          ( (strlen (filename) < strlen (GNUNET_FS_DIRECTORY_EXT)) ||
+            (NULL ==
+             strstr (filename + strlen(filename) - strlen(GNUNET_FS_DIRECTORY_EXT),
+                     GNUNET_FS_DIRECTORY_EXT)) ) )
+       {
+         GNUNET_asprintf (&full_name,
+                          "%s%s%s%s",
+                          dn,
+                          DIR_SEPARATOR_STR,
+                          filename,
+                          GNUNET_FS_DIRECTORY_EXT);
+       }
+      else
+       {
+         GNUNET_asprintf (&full_name,
+                          "%s%s%s",
+                          dn,
+                          DIR_SEPARATOR_STR,
+                          filename);
+       }
+      GNUNET_free (dn);
+    }
+  if ( (full_name != NULL) &&
+       (GNUNET_OK !=
+       GNUNET_DISK_directory_create_for_file (full_name)) )
+    {
+      GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+                 _("Failed to create directory for recursive download of `%s'\n"),
+                 full_name);
+      GNUNET_free (full_name);
+      GNUNET_free_non_null (fn);
+      return;
+    }
+    
+  if (data != NULL) 
+    {
+      if (full_name != NULL)
+       {
+         fh = GNUNET_DISK_file_open (full_name,
+                                     GNUNET_DISK_OPEN_WRITE | GNUNET_DISK_OPEN_TRUNCATE | GNUNET_DISK_OPEN_CREATE,
+                                     GNUNET_DISK_PERM_USER_READ | GNUNET_DISK_PERM_USER_WRITE);
+         if (fh == NULL)
+           {
+             GNUNET_log_strerror_file (GNUNET_ERROR_TYPE_ERROR,
+                                       "open",
+                                       full_name);           
+             GNUNET_free (full_name);
+             GNUNET_free_non_null (fn);
+             return;
+           }
+         if (length != 
+             GNUNET_DISK_file_write (fh,
+                                     data,
+                                     length))
+           {
+             GNUNET_log_strerror_file (GNUNET_ERROR_TYPE_ERROR,
+                                       "write",
+                                       full_name);           
+           }
+         GNUNET_DISK_file_close (fh);
+       }
+      else
+       {
+         /* FIXME: generate 'progress' events and move to
+            instant completion! */
+         GNUNET_break (0); // FIXME: not implemented
+       }
+    }
+  GNUNET_FS_download_start (dc->h,
+                           uri,
+                           meta,
+                           full_name,
+                           0,
+                           GNUNET_FS_uri_chk_get_file_size (uri),
+                           dc->anonymity,
+                           dc->options,
+                           NULL,
+                           dc);
+  GNUNET_free_non_null (full_name);
+  GNUNET_free_non_null (fn);
+}
+
+
+/**
+ * We're done downloading a directory.  Open the file and
+ * trigger all of the (remaining) child downloads.
+ *
+ * @param dc context of download that just completed
+ */
+static void
+full_recursive_download (struct GNUNET_FS_DownloadContext *dc)
+{
+  size_t size;
+  uint64_t size64;
+  void *data;
+  struct GNUNET_DISK_FileHandle *h;
+  struct GNUNET_DISK_MapHandle *m;
+  
+  size64 = GNUNET_FS_uri_chk_get_file_size (dc->uri);
+  size = (size_t) size64;
+  if (size64 != (uint64_t) size)
+    {
+      GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+                 _("Recursive downloads of directories larger than 4 GB are not supported on 32-bit systems\n"));
+      return;
+    }
+  if (dc->filename != NULL)
+    {
+      h = GNUNET_DISK_file_open (dc->filename,
+                                GNUNET_DISK_OPEN_READ,
+                                GNUNET_DISK_PERM_NONE);
+    }
+  else
+    {
+      /* FIXME: need to initialize (and use) temp_filename
+        in various places in order for this assertion to
+        not fail; right now, it will always fail! */
+      GNUNET_assert (dc->temp_filename != NULL);
+      h = GNUNET_DISK_file_open (dc->temp_filename,
+                                GNUNET_DISK_OPEN_READ,
+                                GNUNET_DISK_PERM_NONE);
+    }
+  if (h == NULL)
+    return; /* oops */
+  data = GNUNET_DISK_file_map (h, &m, GNUNET_DISK_MAP_TYPE_READ, size);
+  if (data == NULL)
+    {
+      GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+                 _("Directory too large for system address space\n"));
+    }
+  else
+    {
+      GNUNET_FS_directory_list_contents (size,
+                                        data,
+                                        0,
+                                        &trigger_recursive_download,
+                                        dc);         
+      GNUNET_DISK_file_unmap (m);
+    }
+  GNUNET_DISK_file_close (h);
+  if (dc->filename == NULL)
+    {
+      if (0 != UNLINK (dc->temp_filename))
+       GNUNET_log_strerror_file (GNUNET_ERROR_TYPE_WARNING,
+                                 "unlink",
+                                 dc->temp_filename);
+      GNUNET_free (dc->temp_filename);
+      dc->temp_filename = NULL;
+    }
+}
+
+
+/**
+ * Check if all child-downloads have completed and
+ * if so, signal completion (and possibly recurse to
+ * parent).
+ */
+static void
+check_completed (struct GNUNET_FS_DownloadContext *dc)
+{
+  struct GNUNET_FS_ProgressInfo pi;
+  struct GNUNET_FS_DownloadContext *pos;
+
+  pos = dc->child_head;
+  while (pos != NULL)
+    {
+      if ( (pos->emsg == NULL) &&
+          (pos->completed < pos->length) )
+       return; /* not done yet */
+      if ( (pos->child_head != NULL) &&
+          (pos->has_finished != GNUNET_YES) )
+       return; /* not transitively done yet */
+      pos = pos->next;
+    }
+  dc->has_finished = GNUNET_YES;
+  /* signal completion */
+  pi.status = GNUNET_FS_STATUS_DOWNLOAD_COMPLETED;
+  make_download_status (&pi, dc);
+  dc->client_info = dc->h->upcb (dc->h->upcb_cls,
+                                &pi);
+  if (dc->parent != NULL)
+    check_completed (dc->parent);  
+}
+
+
 /**
  * Iterator over entries in the pending requests in the 'active' map for the
  * reply that we just got.
@@ -390,7 +796,7 @@ process_result_with_request (void *cls,
          GNUNET_CLIENT_notify_transmit_ready_cancel (dc->th);
          dc->th = NULL;
        }
-      GNUNET_CLIENT_disconnect (dc->client);
+      GNUNET_CLIENT_disconnect (dc->client, GNUNET_NO);
       dc->client = NULL;
       return GNUNET_NO;
     }
@@ -404,15 +810,15 @@ process_result_with_request (void *cls,
                             &skey,
                             &iv,
                             pt);
+  off = compute_disk_offset (GNUNET_ntohll (dc->uri->data.chk.file_length),
+                            sm->offset,
+                            sm->depth,
+                            dc->treedepth);
   /* save to disk */
   if ( (NULL != dc->handle) &&
        ( (sm->depth == dc->treedepth) ||
         (0 == (dc->options & GNUNET_FS_DOWNLOAD_NO_TEMPORARIES)) ) )
     {
-      off = compute_disk_offset (GNUNET_ntohll (dc->uri->data.chk.file_length),
-                                sm->offset,
-                                sm->depth,
-                                dc->treedepth);
       emsg = NULL;
 #if DEBUG_DOWNLOAD
       GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
@@ -456,7 +862,7 @@ process_result_with_request (void *cls,
              GNUNET_CLIENT_notify_transmit_ready_cancel (dc->th);
              dc->th = NULL;
            }
-         GNUNET_CLIENT_disconnect (dc->client);
+         GNUNET_CLIENT_disconnect (dc->client, GNUNET_NO);
          dc->client = NULL;
          GNUNET_free (sm);
          return GNUNET_NO;
@@ -480,8 +886,25 @@ process_result_with_request (void *cls,
          app -= (sm->offset + prc->size) - (dc->offset + dc->length);
        }
       dc->completed += app;
-    }
 
+      /* do recursive download if option is set and either meta data
+        says it is a directory or if no meta data is given AND filename 
+        ends in '.gnd' (top-level case) */
+      if ( (0 != (dc->options & GNUNET_FS_DOWNLOAD_OPTION_RECURSIVE)) &&
+          ( (GNUNET_YES == GNUNET_FS_meta_data_test_for_directory (dc->meta)) ||
+            ( (dc->meta == NULL) &&
+              ( (NULL == dc->filename) ||             
+                ( (strlen (dc->filename) >= strlen (GNUNET_FS_DIRECTORY_EXT)) &&
+                  (NULL !=
+                   strstr (dc->filename + strlen(dc->filename) - strlen(GNUNET_FS_DIRECTORY_EXT),
+                           GNUNET_FS_DIRECTORY_EXT)) ) ) ) ) ) 
+       GNUNET_FS_directory_list_contents (prc->size,
+                                          pt,
+                                          off,
+                                          &trigger_recursive_download,
+                                          dc);         
+           
+    }
   pi.status = GNUNET_FS_STATUS_DOWNLOAD_PROGRESS;
   make_download_status (&pi, dc);
   pi.value.download.specifics.progress.data = pt;
@@ -509,11 +932,26 @@ process_result_with_request (void *cls,
                                      "truncate",
                                      dc->filename);
        }
-      /* signal completion */
-      pi.status = GNUNET_FS_STATUS_DOWNLOAD_COMPLETED;
-      make_download_status (&pi, dc);
-      dc->client_info = dc->h->upcb (dc->h->upcb_cls,
-                                    &pi);
+
+      if ( (0 != (dc->options & GNUNET_FS_DOWNLOAD_OPTION_RECURSIVE)) &&
+          ( (GNUNET_YES == GNUNET_FS_meta_data_test_for_directory (dc->meta)) ||
+            ( (dc->meta == NULL) &&
+              ( (NULL == dc->filename) ||             
+                ( (strlen (dc->filename) >= strlen (GNUNET_FS_DIRECTORY_EXT)) &&
+                  (NULL !=
+                   strstr (dc->filename + strlen(dc->filename) - strlen(GNUNET_FS_DIRECTORY_EXT),
+                           GNUNET_FS_DIRECTORY_EXT)) ) ) ) ) ) 
+       full_recursive_download (dc);
+      if (dc->child_head == NULL)
+       {
+         /* signal completion */
+         pi.status = GNUNET_FS_STATUS_DOWNLOAD_COMPLETED;
+         make_download_status (&pi, dc);
+         dc->client_info = dc->h->upcb (dc->h->upcb_cls,
+                                        &pi);
+         if (dc->parent != NULL)
+           check_completed (dc->parent);
+       }
       GNUNET_assert (sm->depth == dc->treedepth);
     }
   // FIXME: make persistent
@@ -772,7 +1210,7 @@ try_reconnect (struct GNUNET_FS_DownloadContext *dc)
       GNUNET_CONTAINER_multihashmap_iterate (dc->active,
                                             &retry_entry,
                                             dc);
-      GNUNET_CLIENT_disconnect (dc->client);
+      GNUNET_CLIENT_disconnect (dc->client, GNUNET_NO);
       dc->client = NULL;
     }
   dc->task
@@ -832,11 +1270,6 @@ GNUNET_FS_download_start (struct GNUNET_FS_Handle *h,
       GNUNET_break (0);
       return NULL;
     }
-  client = GNUNET_CLIENT_connect (h->sched,
-                                 "fs",
-                                 h->cfg);
-  if (NULL == client)
-    return NULL;
   // FIXME: add support for "loc" URIs!
 #if DEBUG_DOWNLOAD
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
@@ -846,11 +1279,17 @@ GNUNET_FS_download_start (struct GNUNET_FS_Handle *h,
 #endif
   dc = GNUNET_malloc (sizeof(struct GNUNET_FS_DownloadContext));
   dc->h = h;
-  dc->client = client;
   dc->parent = parent;
+  if (parent != NULL)
+    {
+      GNUNET_CONTAINER_DLL_insert (parent->child_head,
+                                  parent->child_tail,
+                                  dc);
+    }
   dc->uri = GNUNET_FS_uri_dup (uri);
   dc->meta = GNUNET_CONTAINER_meta_data_duplicate (meta);
   dc->client_info = cctx;
+  dc->start_time = GNUNET_TIME_absolute_get ();
   if (NULL != filename)
     {
       dc->filename = GNUNET_strdup (filename);
@@ -874,7 +1313,6 @@ GNUNET_FS_download_start (struct GNUNET_FS_Handle *h,
          GNUNET_CONTAINER_meta_data_destroy (dc->meta);
          GNUNET_FS_uri_destroy (dc->uri);
          GNUNET_free (dc->filename);
-         GNUNET_CLIENT_disconnect (dc->client);
          GNUNET_free (dc);
          return NULL;
        }
@@ -884,7 +1322,7 @@ GNUNET_FS_download_start (struct GNUNET_FS_Handle *h,
   dc->length = length;
   dc->anonymity = anonymity;
   dc->options = options;
-  dc->active = GNUNET_CONTAINER_multihashmap_create (2 * (length / DBLOCK_SIZE));
+  dc->active = GNUNET_CONTAINER_multihashmap_create (1 + 2 * (length / DBLOCK_SIZE));
   dc->treedepth = GNUNET_FS_compute_depth (GNUNET_ntohll(dc->uri->data.chk.file_length));
 #if DEBUG_DOWNLOAD
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
@@ -892,6 +1330,12 @@ GNUNET_FS_download_start (struct GNUNET_FS_Handle *h,
              dc->treedepth);
 #endif
   // FIXME: make persistent
+  
+  // FIXME: bound parallelism here!
+  client = GNUNET_CLIENT_connect (h->sched,
+                                 "fs",
+                                 h->cfg);
+  dc->client = client;
   schedule_block_download (dc, 
                           &dc->uri->data.chk.chk,
                           0, 
@@ -940,7 +1384,15 @@ GNUNET_FS_download_stop (struct GNUNET_FS_DownloadContext *dc,
 {
   struct GNUNET_FS_ProgressInfo pi;
 
+  while (NULL != dc->child_head)
+    GNUNET_FS_download_stop (dc->child_head, 
+                            do_delete);
   // FIXME: make unpersistent  
+  if (dc->parent != NULL)
+    GNUNET_CONTAINER_DLL_remove (dc->parent->child_head,
+                                dc->parent->child_tail,
+                                dc);
+  
   pi.status = GNUNET_FS_STATUS_DOWNLOAD_STOPPED;
   make_download_status (&pi, dc);
   dc->client_info = dc->h->upcb (dc->h->upcb_cls,
@@ -955,7 +1407,7 @@ GNUNET_FS_download_stop (struct GNUNET_FS_DownloadContext *dc,
       dc->th = NULL;
     }
   if (NULL != dc->client)
-    GNUNET_CLIENT_disconnect (dc->client);
+    GNUNET_CLIENT_disconnect (dc->client, GNUNET_NO);
   GNUNET_CONTAINER_multihashmap_iterate (dc->active,
                                         &free_entry,
                                         NULL);