{
return (0 != (dc->options & GNUNET_FS_DOWNLOAD_OPTION_RECURSIVE)) &&
((GNUNET_YES == GNUNET_FS_meta_data_test_for_directory (dc->meta)) ||
- ((dc->meta == NULL) &&
+ ((NULL == dc->meta) &&
((NULL == dc->filename) ||
((strlen (dc->filename) >= strlen (GNUNET_FS_DIRECTORY_EXT)) &&
(NULL !=
uint64_t loff; /* where do IBlocks for depth "i" start? */
unsigned int ioff; /* which IBlock corresponds to "off" at depth "i"? */
- if (depth == 0)
+ if (0 == depth)
return off;
/* first IBlocks start at the end of file, rounded up
* to full DBLOCK_SIZE */
pi->value.download.dc = dc;
pi->value.download.cctx = dc->client_info;
pi->value.download.pctx =
- (dc->parent == NULL) ? NULL : dc->parent->client_info;
+ (NULL == dc->parent) ? NULL : dc->parent->client_info;
pi->value.download.sctx =
- (dc->search == NULL) ? NULL : dc->search->client_info;
+ (NULL == dc->search) ? NULL : dc->search->client_info;
pi->value.download.uri = dc->uri;
pi->value.download.filename = dc->filename;
pi->value.download.size = dc->length;
pi->value.download.anonymity = dc->anonymity;
pi->value.download.eta =
GNUNET_TIME_calculate_eta (dc->start_time, dc->completed, dc->length);
- pi->value.download.is_active = (dc->client == NULL) ? GNUNET_NO : GNUNET_YES;
+ pi->value.download.is_active = (NULL == dc->client) ? GNUNET_NO : GNUNET_YES;
+ pi->fsh = dc->h;
if (0 == (dc->options & GNUNET_FS_DOWNLOAD_IS_PROBE))
dc->client_info = dc->h->upcb (dc->h->upcb_cls, pi);
else
/**
* Hash of data.
*/
- GNUNET_HashCode query;
+ struct GNUNET_HashCode query;
/**
* Data found in P2P network.
*/
struct GNUNET_FS_DownloadContext *dc;
+ /**
+ * When did we last transmit the request?
+ */
+ struct GNUNET_TIME_Absolute last_transmission;
+
/**
* Number of bytes in data.
*/
int do_store;
/**
- * When did we last transmit the request?
+ * how much respect did we offer to get this reply?
*/
- struct GNUNET_TIME_Absolute last_transmission;
+ uint32_t respect_offered;
+
+ /**
+ * how often did we transmit the query?
+ */
+ uint32_t num_transmissions;
};
* @return GNUNET_YES (we should continue to iterate); unless serious error
*/
static int
-process_result_with_request (void *cls, const GNUNET_HashCode * key,
+process_result_with_request (void *cls, const struct GNUNET_HashCode * key,
void *value);
{
struct ProcessResultClosure prc;
char enc[len];
- struct GNUNET_CRYPTO_AesSessionKey sk;
- struct GNUNET_CRYPTO_AesInitializationVector iv;
- GNUNET_HashCode query;
+ struct GNUNET_CRYPTO_SymmetricSessionKey sk;
+ struct GNUNET_CRYPTO_SymmetricInitializationVector iv;
+ struct GNUNET_HashCode query;
GNUNET_CRYPTO_hash_to_aes_key (&chk->key, &sk, &iv);
- if (-1 == GNUNET_CRYPTO_aes_encrypt (block, len, &sk, &iv, enc))
+ if (-1 == GNUNET_CRYPTO_symmetric_encrypt (block, len, &sk, &iv, enc))
{
GNUNET_break (0);
return GNUNET_SYSERR;
}
GNUNET_CRYPTO_hash (enc, len, &query);
- if (0 != memcmp (&query, &chk->query, sizeof (GNUNET_HashCode)))
+ if (0 != memcmp (&query, &chk->query, sizeof (struct GNUNET_HashCode)))
{
GNUNET_break_op (0);
return GNUNET_SYSERR;
("Recursive downloads of directories larger than 4 GB are not supported on 32-bit systems\n"));
return;
}
- if (dc->filename != NULL)
+ if (NULL != dc->filename)
{
h = GNUNET_DISK_file_open (dc->filename, GNUNET_DISK_OPEN_READ,
GNUNET_DISK_PERM_NONE);
}
else
{
- GNUNET_assert (dc->temp_filename != NULL);
+ GNUNET_assert (NULL != dc->temp_filename);
h = GNUNET_DISK_file_open (dc->temp_filename, GNUNET_DISK_OPEN_READ,
GNUNET_DISK_PERM_NONE);
}
- if (h == NULL)
+ if (NULL == h)
return; /* oops */
data = GNUNET_DISK_file_map (h, &m, GNUNET_DISK_MAP_TYPE_READ, size);
- if (data == NULL)
+ if (NULL == data)
{
GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
_("Directory too large for system address space\n"));
GNUNET_DISK_file_unmap (m);
}
GNUNET_DISK_file_close (h);
- if (dc->filename == NULL)
+ if (NULL == dc->filename)
{
if (0 != UNLINK (dc->temp_filename))
GNUNET_log_strerror_file (GNUNET_ERROR_TYPE_WARNING, "unlink",
struct GNUNET_FS_DownloadContext *pos;
/* first, check if we need to download children */
- if ((dc->child_head == NULL) && (is_recursive_download (dc)))
+ if ((NULL == dc->child_head) && (is_recursive_download (dc)))
full_recursive_download (dc);
/* then, check if children are done already */
- pos = dc->child_head;
- while (pos != NULL)
+ for (pos = dc->child_head; NULL != pos; pos = pos->next)
{
if ((pos->emsg == NULL) && (pos->completed < pos->length))
return; /* not done yet */
if ((pos->child_head != NULL) && (pos->has_finished != GNUNET_YES))
return; /* not transitively done yet */
- pos = pos->next;
}
/* All of our children are done, so mark this download done */
dc->has_finished = GNUNET_YES;
- if (dc->job_queue != NULL)
+ if (NULL != dc->job_queue)
{
GNUNET_FS_dequeue_ (dc->job_queue);
dc->job_queue = NULL;
GNUNET_SCHEDULER_cancel (dc->task);
dc->task = GNUNET_SCHEDULER_NO_TASK;
}
- if (dc->rfh != NULL)
+ if (NULL != dc->rfh)
{
GNUNET_break (GNUNET_OK == GNUNET_DISK_file_close (dc->rfh));
dc->rfh = NULL;
GNUNET_FS_download_make_status_ (&pi, dc);
/* let parent know */
- if (dc->parent != NULL)
+ if (NULL != dc->parent)
check_completed (dc->parent);
}
char enc[DBLOCK_SIZE];
struct ContentHashKey chks[CHK_PER_INODE];
struct ContentHashKey in_chk;
- struct GNUNET_CRYPTO_AesSessionKey sk;
- struct GNUNET_CRYPTO_AesInitializationVector iv;
+ struct GNUNET_CRYPTO_SymmetricSessionKey sk;
+ struct GNUNET_CRYPTO_SymmetricInitializationVector iv;
size_t dlen;
struct DownloadRequest *drc;
struct GNUNET_DISK_FileHandle *fh;
}
GNUNET_CRYPTO_hash (&data[dr->offset], dlen, &in_chk.key);
GNUNET_CRYPTO_hash_to_aes_key (&in_chk.key, &sk, &iv);
- if (-1 == GNUNET_CRYPTO_aes_encrypt (&data[dr->offset], dlen, &sk, &iv, enc))
+ if (-1 == GNUNET_CRYPTO_symmetric_encrypt (&data[dr->offset], dlen, &sk, &iv, enc))
{
GNUNET_break (0);
return;
break;
}
/* write block to disk */
- fn = dc->filename != NULL ? dc->filename : dc->temp_filename;
+ fn = (NULL != dc->filename) ? dc->filename : dc->temp_filename;
fh = GNUNET_DISK_file_open (fn,
GNUNET_DISK_OPEN_READWRITE |
GNUNET_DISK_OPEN_CREATE |
GNUNET_DISK_PERM_USER_WRITE |
GNUNET_DISK_PERM_GROUP_READ |
GNUNET_DISK_PERM_OTHER_READ);
- if (fh == NULL)
+ if (NULL == fh)
{
GNUNET_log_strerror_file (GNUNET_ERROR_TYPE_ERROR, "open", fn);
GNUNET_asprintf (&dc->emsg, _("Failed to open file `%s' for writing"),
pi.value.download.specifics.progress.offset = 0;
pi.value.download.specifics.progress.data_len = dlen;
pi.value.download.specifics.progress.depth = 0;
- pi.value.download.specifics.progress.trust_offered = 0;
+ pi.value.download.specifics.progress.respect_offered = 0;
pi.value.download.specifics.progress.block_download_duration = GNUNET_TIME_UNIT_ZERO;
GNUNET_FS_download_make_status_ (&pi, dc);
if ((NULL != dc->filename) &&
(0 !=
- truncate (dc->filename,
+ TRUNCATE (dc->filename,
GNUNET_ntohll (dc->uri->data.chk.file_length))))
GNUNET_log_strerror_file (GNUNET_ERROR_TYPE_WARNING, "truncate",
dc->filename);
{
struct GNUNET_FS_DownloadContext *dc = cls;
- if (type != EXTRACTOR_METATYPE_GNUNET_FULL_DATA)
+ if (EXTRACTOR_METATYPE_GNUNET_FULL_DATA != type)
return 0;
GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Found %u bytes of FD!\n",
(unsigned int) data_len);
{
dr->state = BRS_DOWNLOAD_UP;
dr = dr->parent;
- if (dr == NULL)
+ if (NULL == dr)
break;
for (i = 0; i < dr->num_children; i++)
if (dr->children[i]->state != BRS_DOWNLOAD_UP)
{
uint64_t off;
char block[DBLOCK_SIZE];
- GNUNET_HashCode key;
+ struct GNUNET_HashCode key;
uint64_t total;
size_t len;
unsigned int i;
const struct ContentHashKey *chks;
int up_done;
- GNUNET_assert (dc->rfh != NULL);
- GNUNET_assert (dr->state == BRS_CHK_SET);
+ GNUNET_assert (NULL != dc->rfh);
+ GNUNET_assert (BRS_CHK_SET == dr->state);
total = GNUNET_FS_uri_chk_get_file_size (dc->uri);
GNUNET_assert (dr->depth < dc->treedepth);
len = GNUNET_FS_tree_calculate_block_size (total, dr->offset, dr->depth);
return; /* failure */
}
GNUNET_CRYPTO_hash (block, len, &key);
- if (0 != memcmp (&key, &dr->chk.key, sizeof (GNUNET_HashCode)))
+ if (0 != memcmp (&key, &dr->chk.key, sizeof (struct GNUNET_HashCode)))
return; /* mismatch */
if (GNUNET_OK !=
encrypt_existing_match (dc, &dr->chk, dr, block, len, GNUNET_NO))
/* hash matches but encrypted block does not, really bad */
dr->state = BRS_ERROR;
/* propagate up */
- while (dr->parent != NULL)
+ while (NULL != dr->parent)
{
dr = dr->parent;
dr->state = BRS_ERROR;
drc = dr->children[i];
GNUNET_assert (drc->offset >= dr->offset);
child_block_size = GNUNET_FS_tree_compute_tree_size (drc->depth);
- GNUNET_assert (0 == (drc->offset - dr->offset) % child_block_size);
- if (drc->state == BRS_INIT)
+ GNUNET_assert (0 == (drc->offset - dr->offset) % child_block_size);
+ if (BRS_INIT == drc->state)
{
drc->state = BRS_CHK_SET;
drc->chk = chks[drc->chk_idx];
try_top_down_reconstruction (dc, drc);
}
- if (drc->state != BRS_DOWNLOAD_UP)
+ if (BRS_DOWNLOAD_UP != drc->state)
up_done = GNUNET_NO; /* children not all done */
}
- if (up_done == GNUNET_YES)
+ if (GNUNET_YES == up_done)
propagate_up (dr); /* children all done (or no children...) */
}
return; /* already active */
GNUNET_CONTAINER_multihashmap_put (dc->active, &dr->chk.query, dr,
GNUNET_CONTAINER_MULTIHASHMAPOPTION_MULTIPLE);
- if (dc->client == NULL)
+ if (NULL == dc->client)
return; /* download not active */
GNUNET_CONTAINER_DLL_insert (dc->pending_head, dc->pending_tail, dr);
dr->is_pending = GNUNET_YES;
if (NULL == uri)
return; /* entry for the directory itself */
cpos = dc->child_head;
- while (cpos != NULL)
+ while (NULL != cpos)
{
if ((GNUNET_FS_uri_test_equal (uri, cpos->uri)) ||
- ((filename != NULL) && (0 == strcmp (cpos->filename, filename))))
+ ((NULL != filename) && (0 == strcmp (cpos->filename, filename))))
break;
cpos = cpos->next;
}
- if (cpos != NULL)
+ if (NULL != cpos)
return; /* already exists */
fn = NULL;
if (NULL == filename)
{
fn = GNUNET_FS_meta_data_suggest_filename (meta);
- if (fn == NULL)
+ if (NULL == fn)
{
us = GNUNET_FS_uri_to_string (uri);
fn = GNUNET_strdup (&us[strlen (GNUNET_FS_URI_CHK_PREFIX)]);
GNUNET_free (us);
}
- else if (fn[0] == '.')
+ else if ('.' == fn[0])
{
ext = fn;
us = GNUNET_FS_uri_to_string (uri);
}
filename = fn;
}
- if (dc->filename == NULL)
+ if (NULL == dc->filename)
{
full_name = NULL;
}
strstr (dn + strlen (dn) - strlen (GNUNET_FS_DIRECTORY_EXT),
GNUNET_FS_DIRECTORY_EXT)));
sfn = GNUNET_strdup (filename);
- while ((strlen (sfn) > 0) && (filename[strlen (sfn) - 1] == '/'))
+ while ((strlen (sfn) > 0) && ('/' == filename[strlen (sfn) - 1]))
sfn[strlen (sfn) - 1] = '\0';
if ((strlen (dn) >= strlen (GNUNET_FS_DIRECTORY_EXT)) &&
(NULL !=
GNUNET_free (sfn);
GNUNET_free (dn);
}
- if ((full_name != NULL) &&
+ if ((NULL != full_name) &&
(GNUNET_OK != GNUNET_DISK_directory_create_for_file (full_name)))
{
GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
{
unsigned int i;
- if (dr == NULL)
+ if (NULL == dr)
return;
for (i = 0; i < dr->num_children; i++)
GNUNET_FS_free_download_request_ (dr->children[i]);
* @return GNUNET_YES (we should continue to iterate); unless serious error
*/
static int
-process_result_with_request (void *cls, const GNUNET_HashCode * key,
+process_result_with_request (void *cls, const struct GNUNET_HashCode * key,
void *value)
{
struct ProcessResultClosure *prc = cls;
struct GNUNET_FS_DownloadContext *dc = prc->dc;
struct DownloadRequest *drc;
struct GNUNET_DISK_FileHandle *fh = NULL;
- struct GNUNET_CRYPTO_AesSessionKey skey;
- struct GNUNET_CRYPTO_AesInitializationVector iv;
+ struct GNUNET_CRYPTO_SymmetricSessionKey skey;
+ struct GNUNET_CRYPTO_SymmetricInitializationVector iv;
char pt[prc->size];
struct GNUNET_FS_ProgressInfo pi;
uint64_t off;
{
GNUNET_asprintf (&dc->emsg,
_
- ("Internal error or bogus download URI (expected %u bytes at depth %u and offset %llu/%llu, got %u bytes)\n"),
+ ("Internal error or bogus download URI (expected %u bytes at depth %u and offset %llu/%llu, got %u bytes)"),
bs, dr->depth, (unsigned long long) dr->offset,
(unsigned long long) GNUNET_ntohll (dc->uri->data.
chk.file_length),
prc->size);
- GNUNET_log (GNUNET_ERROR_TYPE_WARNING, "%s", dc->emsg);
- while (dr->parent != NULL)
+ GNUNET_log (GNUNET_ERROR_TYPE_WARNING, "%s\n", dc->emsg);
+ while (NULL != dr->parent)
{
dr->state = BRS_ERROR;
dr = dr->parent;
}
GNUNET_CRYPTO_hash_to_aes_key (&dr->chk.key, &skey, &iv);
- if (-1 == GNUNET_CRYPTO_aes_decrypt (prc->data, prc->size, &skey, &iv, pt))
+ if (-1 == GNUNET_CRYPTO_symmetric_decrypt (prc->data, prc->size, &skey, &iv, pt))
{
GNUNET_break (0);
dc->emsg = GNUNET_strdup (_("internal error decrypting content"));
dr->offset, dr->depth);
/* save to disk */
if ((GNUNET_YES == prc->do_store) &&
- ((dc->filename != NULL) || (is_recursive_download (dc))) &&
+ ((NULL != dc->filename) || (is_recursive_download (dc))) &&
((dr->depth == dc->treedepth) ||
(0 == (dc->options & GNUNET_FS_DOWNLOAD_NO_TEMPORARIES))))
{
- fh = GNUNET_DISK_file_open (dc->filename !=
- NULL ? dc->filename : dc->temp_filename,
+ fh = GNUNET_DISK_file_open (NULL != dc->filename
+ ? dc->filename : dc->temp_filename,
GNUNET_DISK_OPEN_READWRITE |
GNUNET_DISK_OPEN_CREATE,
GNUNET_DISK_PERM_USER_READ |
if (NULL == fh)
{
GNUNET_asprintf (&dc->emsg,
- _("Download failed: could not open file `%s': %s\n"),
+ _("Download failed: could not open file `%s': %s"),
dc->filename, STRERROR (errno));
goto signal_error;
}
if ((off != GNUNET_DISK_file_seek (fh, off, GNUNET_DISK_SEEK_SET)))
{
GNUNET_asprintf (&dc->emsg,
- _("Failed to seek to offset %llu in file `%s': %s\n"),
+ _("Failed to seek to offset %llu in file `%s': %s"),
(unsigned long long) off, dc->filename,
STRERROR (errno));
goto signal_error;
{
GNUNET_asprintf (&dc->emsg,
_
- ("Failed to write block of %u bytes at offset %llu in file `%s': %s\n"),
+ ("Failed to write block of %u bytes at offset %llu in file `%s': %s"),
(unsigned int) prc->size, (unsigned long long) off,
dc->filename, STRERROR (errno));
goto signal_error;
fh = NULL;
}
- if (dr->depth == 0)
+ if (0 == dr->depth)
{
/* DBLOCK, update progress and try recursion if applicable */
app = prc->size;
if (is_recursive_download (dc))
GNUNET_FS_directory_list_contents (prc->size, pt, off,
&trigger_recursive_download, dc);
-
}
GNUNET_assert (dc->completed <= dc->length);
dr->state = BRS_DOWNLOAD_DOWN;
pi.value.download.specifics.progress.offset = dr->offset;
pi.value.download.specifics.progress.data_len = prc->size;
pi.value.download.specifics.progress.depth = dr->depth;
- pi.value.download.specifics.progress.trust_offered = 0;
- if (prc->last_transmission.abs_value != GNUNET_TIME_UNIT_FOREVER_ABS.abs_value)
- pi.value.download.specifics.progress.block_download_duration
+ pi.value.download.specifics.progress.respect_offered = prc->respect_offered;
+ pi.value.download.specifics.progress.num_transmissions = prc->num_transmissions;
+ if (prc->last_transmission.abs_value_us != GNUNET_TIME_UNIT_FOREVER_ABS.abs_value_us)
+ pi.value.download.specifics.progress.block_download_duration
= GNUNET_TIME_absolute_get_duration (prc->last_transmission);
else
pi.value.download.specifics.progress.block_download_duration
= GNUNET_TIME_UNIT_ZERO; /* found locally */
GNUNET_FS_download_make_status_ (&pi, dc);
- if (dr->depth == 0)
+ if (0 == dr->depth)
propagate_up (dr);
if (dc->completed == dc->length)
(unsigned long long) GNUNET_ntohll (dc->uri->data.
chk.file_length));
/* truncate file to size (since we store IBlocks at the end) */
- if (dc->filename != NULL)
+ if (NULL != dc->filename)
{
if (0 !=
- truncate (dc->filename,
+ TRUNCATE (dc->filename,
GNUNET_ntohll (dc->uri->data.chk.file_length)))
GNUNET_log_strerror_file (GNUNET_ERROR_TYPE_WARNING, "truncate",
dc->filename);
}
- GNUNET_assert (dr->depth == 0);
+ GNUNET_assert (0 == dr->depth);
check_completed (dc);
}
- if (dr->depth == 0)
+ if (0 == dr->depth)
{
/* bottom of the tree, no child downloads possible, just sync */
GNUNET_FS_download_sync_ (dc);
switch (drc->state)
{
case BRS_INIT:
+ if ((drc->chk_idx + 1) * sizeof (struct ContentHashKey) > prc->size)
+ {
+ /* 'chkarr' does not have enough space for this chk_idx;
+ internal error! */
+ GNUNET_break (0); GNUNET_assert (0);
+ dc->emsg = GNUNET_strdup (_("internal error decoding tree"));
+ goto signal_error;
+ }
drc->chk = chkarr[drc->chk_idx];
drc->state = BRS_CHK_SET;
if (GNUNET_YES == dc->issue_requests)
return GNUNET_YES;
signal_error:
- if (fh != NULL)
+ if (NULL != fh)
GNUNET_DISK_file_close (fh);
pi.status = GNUNET_FS_STATUS_DOWNLOAD_ERROR;
pi.value.download.specifics.error.message = dc->emsg;
GNUNET_CLIENT_notify_transmit_ready_cancel (dc->th);
dc->th = NULL;
}
- GNUNET_CLIENT_disconnect (dc->client, GNUNET_NO);
+ GNUNET_CLIENT_disconnect (dc->client);
dc->in_receive = GNUNET_NO;
dc->client = NULL;
GNUNET_FS_free_download_request_ (dc->top_request);
dc->top_request = NULL;
GNUNET_CONTAINER_multihashmap_destroy (dc->active);
dc->active = NULL;
+ if (NULL != dc->job_queue)
+ {
+ GNUNET_FS_dequeue_ (dc->job_queue);
+ dc->job_queue = NULL;
+ }
dc->pending_head = NULL;
dc->pending_tail = NULL;
GNUNET_FS_download_sync_ (dc);
*
* @param dc our download context
* @param type type of the result
+ * @param respect_offered how much respect did we offer to get this reply?
+ * @param num_transmissions how often did we transmit the query?
* @param last_transmission when was this block requested the last time? (FOREVER if unknown/not applicable)
* @param data the (encrypted) response
* @param size size of data
static void
process_result (struct GNUNET_FS_DownloadContext *dc,
enum GNUNET_BLOCK_Type type,
+ uint32_t respect_offered,
+ uint32_t num_transmissions,
struct GNUNET_TIME_Absolute last_transmission,
const void *data, size_t size)
{
prc.dc = dc;
prc.data = data;
+ prc.last_transmission = last_transmission;
prc.size = size;
prc.type = type;
prc.do_store = GNUNET_YES;
- prc.last_transmission = last_transmission;
+ prc.respect_offered = respect_offered;
+ prc.num_transmissions = num_transmissions;
GNUNET_CRYPTO_hash (data, size, &prc.query);
GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
"Received result for query `%s' from `%s'-service\n",
if ((NULL == msg) || (ntohs (msg->type) != GNUNET_MESSAGE_TYPE_FS_PUT) ||
(sizeof (struct ClientPutMessage) > ntohs (msg->size)))
{
- GNUNET_break (msg == NULL);
+ GNUNET_break (NULL == msg);
try_reconnect (dc);
return;
}
msize = ntohs (msg->size);
cm = (const struct ClientPutMessage *) msg;
process_result (dc, ntohl (cm->type),
+ ntohl (cm->respect_offered),
+ ntohl (cm->num_transmissions),
GNUNET_TIME_absolute_ntoh (cm->last_transmission), &cm[1],
msize - sizeof (struct ClientPutMessage));
- if (dc->client == NULL)
+ if (NULL == dc->client)
return; /* fatal error */
/* continue receiving */
GNUNET_CLIENT_receive (dc->client, &receive_results, dc,
}
-
/**
* We're ready to transmit a search request to the
* file-sharing service. Do it. If there is
sm->options = htonl (GNUNET_FS_SEARCH_OPTION_LOOPBACK_ONLY);
else
sm->options = htonl (GNUNET_FS_SEARCH_OPTION_NONE);
- if (dr->depth == 0)
+ if (0 == dr->depth)
sm->type = htonl (GNUNET_BLOCK_TYPE_FS_DBLOCK);
else
sm->type = htonl (GNUNET_BLOCK_TYPE_FS_IBLOCK);
sm->anonymity_level = htonl (dc->anonymity);
- sm->target = dc->target.hashPubKey;
+ sm->target = dc->target;
sm->query = dr->chk.query;
GNUNET_CONTAINER_DLL_remove (dc->pending_head, dc->pending_tail, dr);
dr->is_pending = GNUNET_NO;
msize += sizeof (struct SearchMessage);
sm++;
}
- if (dc->pending_head != NULL)
+ if (NULL != dc->pending_head)
{
dc->th =
GNUNET_CLIENT_notify_transmit_ready (dc->client,
GNUNET_CONSTANTS_SERVICE_TIMEOUT,
GNUNET_NO,
&transmit_download_request, dc);
- GNUNET_assert (dc->th != NULL);
+ GNUNET_assert (NULL != dc->th);
}
if (GNUNET_NO == dc->in_receive)
{
return;
}
dc->client = client;
- if (dc->pending_head != NULL)
+ if (NULL != dc->pending_head)
{
dc->th =
GNUNET_CLIENT_notify_transmit_ready (client,
GNUNET_CONSTANTS_SERVICE_TIMEOUT,
GNUNET_NO,
&transmit_download_request, dc);
- GNUNET_assert (dc->th != NULL);
+ GNUNET_assert (NULL != dc->th);
}
}
* @return GNUNET_OK
*/
static int
-retry_entry (void *cls, const GNUNET_HashCode * key, void *entry)
+retry_entry (void *cls, const struct GNUNET_HashCode * key, void *entry)
{
struct GNUNET_FS_DownloadContext *dc = cls;
struct DownloadRequest *dr = entry;
dc->pending_head = NULL;
dc->pending_tail = NULL;
GNUNET_CONTAINER_multihashmap_iterate (dc->active, &retry_entry, dc);
- GNUNET_CLIENT_disconnect (dc->client, GNUNET_NO);
+ GNUNET_CLIENT_disconnect (dc->client);
dc->in_receive = GNUNET_NO;
dc->client = NULL;
}
- GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Will try to reconnect in 1s\n");
+ if (0 == dc->reconnect_backoff.rel_value_us)
+ dc->reconnect_backoff = GNUNET_TIME_UNIT_MILLISECONDS;
+ else
+ dc->reconnect_backoff = GNUNET_TIME_STD_BACKOFF (dc->reconnect_backoff);
+
+ GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Will try to reconnect in %s\n",
+ GNUNET_STRINGS_relative_time_to_string (dc->reconnect_backoff, GNUNET_YES));
dc->task =
- GNUNET_SCHEDULER_add_delayed (GNUNET_TIME_UNIT_SECONDS, &do_reconnect,
- dc);
+ GNUNET_SCHEDULER_add_delayed (dc->reconnect_backoff,
+ &do_reconnect,
+ dc);
}
GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Download activated\n");
GNUNET_assert (NULL != client);
- GNUNET_assert (dc->client == NULL);
- GNUNET_assert (dc->th == NULL);
+ GNUNET_assert (NULL == dc->client);
+ GNUNET_assert (NULL == dc->th);
+ GNUNET_assert (NULL != dc->active);
dc->client = client;
pi.status = GNUNET_FS_STATUS_DOWNLOAD_ACTIVE;
GNUNET_FS_download_make_status_ (&pi, dc);
GNUNET_CONTAINER_multihashmap_iterate (dc->active, &retry_entry, dc);
GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
"Asking for transmission to FS service\n");
- if (dc->pending_head != NULL)
+ if (NULL != dc->pending_head)
{
dc->th =
GNUNET_CLIENT_notify_transmit_ready (dc->client,
GNUNET_CONSTANTS_SERVICE_TIMEOUT,
GNUNET_NO,
&transmit_download_request, dc);
- GNUNET_assert (dc->th != NULL);
+ GNUNET_assert (NULL != dc->th);
}
}
}
if (NULL != dc->client)
{
- GNUNET_CLIENT_disconnect (dc->client, GNUNET_NO);
+ GNUNET_CLIENT_disconnect (dc->client);
dc->in_receive = GNUNET_NO;
dc->client = NULL;
}
* the specified depth
*/
static struct DownloadRequest *
-create_download_request (struct DownloadRequest *parent,
+create_download_request (struct DownloadRequest *parent,
unsigned int chk_idx,
unsigned int depth,
uint64_t dr_offset, uint64_t file_start_offset,
dr->depth = depth;
dr->offset = dr_offset;
dr->chk_idx = chk_idx;
- if (depth > 0)
+ if (0 == depth)
+ return dr;
+ child_block_size = GNUNET_FS_tree_compute_tree_size (depth - 1);
+
+ /* calculate how many blocks at this level are not interesting
+ * from the start (rounded down), either because of the requested
+ * file offset or because this IBlock is further along */
+ if (dr_offset < file_start_offset)
{
- child_block_size = GNUNET_FS_tree_compute_tree_size (depth - 1);
+ head_skip = (file_start_offset - dr_offset) / child_block_size;
+ }
+ else
+ {
+ head_skip = 0;
+ }
- /* calculate how many blocks at this level are not interesting
- * from the start (rounded down), either because of the requested
- * file offset or because this IBlock is further along */
- if (dr_offset < file_start_offset)
- head_skip = file_start_offset / child_block_size;
- else
- head_skip = 0;
-
- /* calculate index of last block at this level that is interesting (rounded up) */
- dr->num_children = (file_start_offset + desired_length - dr_offset) / child_block_size;
- if (dr->num_children * child_block_size <
- file_start_offset + desired_length - dr_offset)
- dr->num_children++; /* round up */
- if (dr->num_children > CHK_PER_INODE)
- dr->num_children = CHK_PER_INODE; /* cap at max */
- GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
- "Block at offset %llu and depth %u has %u children\n",
- (unsigned long long) dr_offset,
- depth,
- dr->num_children);
+ /* calculate index of last block at this level that is interesting (rounded up) */
+ dr->num_children = (file_start_offset + desired_length - dr_offset) / child_block_size;
+ if (dr->num_children * child_block_size <
+ file_start_offset + desired_length - dr_offset)
+ dr->num_children++; /* round up */
+ GNUNET_assert (dr->num_children > head_skip);
+ dr->num_children -= head_skip;
+ if (dr->num_children > CHK_PER_INODE)
+ dr->num_children = CHK_PER_INODE; /* cap at max */
+ GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+ "Block at offset %llu and depth %u has %u children\n",
+ (unsigned long long) dr_offset,
+ depth,
+ dr->num_children);
- /* now we can get the total number of *interesting* children for this block */
- dr->num_children -= head_skip;
+ /* now we can get the total number of *interesting* children for this block */
- /* why else would we have gotten here to begin with? (that'd be a bad logic error) */
- GNUNET_assert (dr->num_children > 0);
+ /* why else would we have gotten here to begin with? (that'd be a bad logic error) */
+ GNUNET_assert (dr->num_children > 0);
- dr->children =
- GNUNET_malloc (dr->num_children * sizeof (struct DownloadRequest *));
- for (i = 0; i < dr->num_children; i++)
- dr->children[i] =
- create_download_request (dr, i + head_skip, depth - 1,
- dr_offset + (i + head_skip) * child_block_size,
- file_start_offset, desired_length);
+ dr->children =
+ GNUNET_malloc (dr->num_children * sizeof (struct DownloadRequest *));
+ for (i = 0; i < dr->num_children; i++)
+ {
+ dr->children[i] =
+ create_download_request (dr, i + head_skip, depth - 1,
+ dr_offset + (i + head_skip) * child_block_size,
+ file_start_offset, desired_length);
}
return dr;
}
{
struct GNUNET_FS_DownloadContext *dc = cls;
- /* clean up state from tree encoder */
+ /* clean up state from tree encoder */
if (dc->task != GNUNET_SCHEDULER_NO_TASK)
{
GNUNET_SCHEDULER_cancel (dc->task);
dc->task = GNUNET_SCHEDULER_NO_TASK;
}
- if (dc->rfh != NULL)
+ if (NULL != dc->rfh)
{
GNUNET_break (GNUNET_OK == GNUNET_DISK_file_close (dc->rfh));
dc->rfh = NULL;
}
-
/**
* Function called asking for the current (encoded)
* block to be processed. After processing the
GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
"Block %u < %u irrelevant for our range\n",
chld,
- dr->children[dr->num_children-1]->chk_idx);
+ dr->children[0]->chk_idx);
dc->task = GNUNET_SCHEDULER_add_now (&get_next_block, dc);
return; /* irrelevant block */
}
pi.value.download.specifics.progress.offset = offset;
pi.value.download.specifics.progress.data_len = 0;
pi.value.download.specifics.progress.depth = 0;
- pi.value.download.specifics.progress.trust_offered = 0;
+ pi.value.download.specifics.progress.respect_offered = 0;
pi.value.download.specifics.progress.block_download_duration = GNUNET_TIME_UNIT_ZERO;
GNUNET_FS_download_make_status_ (&pi, dc);
/* FIXME: duplicated code from 'process_result_with_request - refactor */
(unsigned long long) GNUNET_ntohll (dc->uri->data.
chk.file_length));
/* truncate file to size (since we store IBlocks at the end) */
- if (dc->filename != NULL)
+ if (NULL != dc->filename)
{
if (0 !=
- truncate (dc->filename,
+ TRUNCATE (dc->filename,
GNUNET_ntohll (dc->uri->data.chk.file_length)))
GNUNET_log_strerror_file (GNUNET_ERROR_TYPE_WARNING, "truncate",
dc->filename);
GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Start task running...\n");
dc->task = GNUNET_SCHEDULER_NO_TASK;
- if (dc->length == 0)
+ if (0 == dc->length)
{
/* no bytes required! */
- if (dc->filename != NULL)
+ if (NULL != dc->filename)
{
fh = GNUNET_DISK_file_open (dc->filename,
GNUNET_DISK_OPEN_READWRITE |
check_completed (dc);
return;
}
- if (dc->emsg != NULL)
+ if (NULL != dc->emsg)
return;
- if (dc->top_request == NULL)
+ if (NULL == dc->top_request)
{
dc->top_request =
create_download_request (NULL, 0, dc->treedepth - 1, 0, dc->offset,
- dc->length);
+ dc->length);
dc->top_request->state = BRS_CHK_SET;
dc->top_request->chk =
(dc->uri->type ==
- chk) ? dc->uri->data.chk.chk : dc->uri->data.loc.fi.chk;
+ GNUNET_FS_URI_CHK) ? dc->uri->data.chk.chk : dc->uri->data.loc.fi.chk;
/* signal start */
GNUNET_FS_download_sync_ (dc);
if (NULL != dc->search)
GNUNET_DISK_PERM_NONE);
if (dc->top_request->state == BRS_CHK_SET)
{
- if (dc->rfh != NULL)
+ if (NULL != dc->rfh)
{
/* first, try top-down */
GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
break; /* normal, some blocks already down */
case BRS_DOWNLOAD_UP:
/* already done entirely, party! */
- if (dc->rfh != NULL)
+ if (NULL != dc->rfh)
{
/* avoid hanging on to file handle longer than
* necessary */
(unsigned int)
GNUNET_CONTAINER_meta_data_get_serialized_size (dc->meta));
GNUNET_CONTAINER_meta_data_iterate (dc->meta, &match_full_data, dc);
- if (dc->top_request->state == BRS_DOWNLOAD_UP)
+ if (BRS_DOWNLOAD_UP == dc->top_request->state)
{
- if (dc->rfh != NULL)
+ if (NULL != dc->rfh)
{
/* avoid hanging on to file handle longer than
* necessary */
return; /* finished, status update was already done for us */
}
}
- if (dc->rfh != NULL)
+ if (NULL != dc->rfh)
{
/* finally, actually run bottom-up */
GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
"Trying bottom-up reconstruction of file `%s'\n", dc->filename);
dc->te =
- GNUNET_FS_tree_encoder_create (dc->h,
+ GNUNET_FS_tree_encoder_create (dc->h,
GNUNET_FS_uri_chk_get_file_size (dc->uri),
dc, &fh_reader,
&reconstruct_cb, NULL,
dc->issue_requests = GNUNET_YES;
schedule_block_download (dc, dc->top_request);
}
- if (dc->top_request->state == BRS_DOWNLOAD_UP)
+ if (BRS_DOWNLOAD_UP == dc->top_request->state)
check_completed (dc);
}
struct GNUNET_FS_DownloadContext *dc = cls;
struct GNUNET_FS_ProgressInfo pi;
- if (dc->top != NULL)
+ if (NULL != dc->top)
GNUNET_FS_end_top (dc->h, dc->top);
while (NULL != dc->child_head)
GNUNET_FS_download_signal_suspend_ (dc->child_head);
- if (dc->search != NULL)
+ if (NULL != dc->search)
{
dc->search->download = NULL;
dc->search = NULL;
}
- if (dc->job_queue != NULL)
+ if (NULL != dc->job_queue)
{
GNUNET_FS_dequeue_ (dc->job_queue);
dc->job_queue = NULL;
}
- if (dc->parent != NULL)
+ if (NULL != dc->parent)
GNUNET_CONTAINER_DLL_remove (dc->parent->child_head, dc->parent->child_tail,
dc);
- if (dc->task != GNUNET_SCHEDULER_NO_TASK)
+ if (GNUNET_SCHEDULER_NO_TASK != dc->task)
{
GNUNET_SCHEDULER_cancel (dc->task);
dc->task = GNUNET_SCHEDULER_NO_TASK;
}
pi.status = GNUNET_FS_STATUS_DOWNLOAD_SUSPEND;
GNUNET_FS_download_make_status_ (&pi, dc);
- if (dc->te != NULL)
+ if (NULL != dc->te)
{
- GNUNET_FS_tree_encoder_finish (dc->te, NULL, NULL);
+ GNUNET_FS_tree_encoder_finish (dc->te, NULL);
dc->te = NULL;
}
- if (dc->rfh != NULL)
+ if (NULL != dc->rfh)
{
GNUNET_DISK_file_close (dc->rfh);
dc->rfh = NULL;
}
GNUNET_FS_free_download_request_ (dc->top_request);
- if (dc->active != NULL)
+ if (NULL != dc->active)
{
GNUNET_CONTAINER_multihashmap_destroy (dc->active);
dc->active = NULL;
GNUNET_FS_uri_destroy (dc->uri);
GNUNET_free_non_null (dc->temp_filename);
GNUNET_free_non_null (dc->serialization);
+ GNUNET_assert (NULL == dc->job_queue);
GNUNET_free (dc);
}
return NULL;
}
dc = GNUNET_malloc (sizeof (struct GNUNET_FS_DownloadContext));
+ GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+ "Starting download %p, %u bytes at offset %llu\n",
+ dc,
+ (unsigned long long) length,
+ (unsigned long long) offset);
dc->h = h;
dc->uri = GNUNET_FS_uri_dup (uri);
dc->meta = GNUNET_CONTAINER_meta_data_duplicate (meta);
dc->anonymity = anonymity;
dc->options = options;
dc->active =
- GNUNET_CONTAINER_multihashmap_create (1 + 2 * (length / DBLOCK_SIZE));
+ GNUNET_CONTAINER_multihashmap_create (1 + 2 * (length / DBLOCK_SIZE), GNUNET_NO);
dc->treedepth =
GNUNET_FS_compute_depth (GNUNET_FS_uri_chk_get_file_size (dc->uri));
if ((NULL == filename) && (is_recursive_download (dc)))
else
dc->temp_filename = GNUNET_DISK_mktemp ("gnunet-directory-download-tmp");
}
- GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+ GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
"Starting download `%s' of %llu bytes with tree depth %u\n",
filename,
(unsigned long long) length,
dc->parent = parent;
if (NULL != parent)
GNUNET_CONTAINER_DLL_insert (parent->child_head, parent->child_tail, dc);
- else
+ else if (0 == (GNUNET_FS_DOWNLOAD_IS_PROBE & options) )
dc->top =
GNUNET_FS_make_top (dc->h, &GNUNET_FS_download_signal_suspend_, dc);
return dc;
GNUNET_FS_download_stop (sr->probe_ctx, GNUNET_YES);
sr->probe_ctx = NULL;
}
+ if (GNUNET_SCHEDULER_NO_TASK != sr->probe_ping_task)
+ {
+ GNUNET_SCHEDULER_cancel (sr->probe_ping_task);
+ sr->probe_ping_task = GNUNET_SCHEDULER_NO_TASK;
+ }
return dc;
}
{
if (dc->completed == dc->length)
return;
- GNUNET_assert (dc->job_queue == NULL);
+ GNUNET_assert (NULL == dc->job_queue);
+ GNUNET_assert (NULL != dc->active);
dc->job_queue =
GNUNET_FS_queue_ (dc->h, &activate_fs_download, &deactivate_fs_download,
dc, (dc->length + DBLOCK_SIZE - 1) / DBLOCK_SIZE,
(0 == (dc->options & GNUNET_FS_DOWNLOAD_IS_PROBE))
- ? GNUNET_FS_QUEUE_PRIORITY_NORMAL
+ ? GNUNET_FS_QUEUE_PRIORITY_NORMAL
: GNUNET_FS_QUEUE_PRIORITY_PROBE);
+ GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+ "Download %p put into queue as job %p\n",
+ dc,
+ dc->job_queue);
}
{
struct GNUNET_FS_ProgressInfo pi;
int have_children;
+ int search_was_null;
- if (dc->top != NULL)
+ if (NULL != dc->top)
GNUNET_FS_end_top (dc->h, dc->top);
- if (dc->task != GNUNET_SCHEDULER_NO_TASK)
+ if (GNUNET_SCHEDULER_NO_TASK != dc->task)
{
GNUNET_SCHEDULER_cancel (dc->task);
dc->task = GNUNET_SCHEDULER_NO_TASK;
}
- if (dc->search != NULL)
+ search_was_null = (NULL == dc->search);
+ if (NULL != dc->search)
{
dc->search->download = NULL;
GNUNET_FS_search_result_sync_ (dc->search);
dc->search = NULL;
}
- if (dc->job_queue != NULL)
+ if (NULL != dc->job_queue)
{
GNUNET_FS_dequeue_ (dc->job_queue);
dc->job_queue = NULL;
}
- if (dc->te != NULL)
+ if (NULL != dc->te)
{
- GNUNET_FS_tree_encoder_finish (dc->te, NULL, NULL);
+ GNUNET_FS_tree_encoder_finish (dc->te, NULL);
dc->te = NULL;
}
have_children = (NULL != dc->child_head) ? GNUNET_YES : GNUNET_NO;
while (NULL != dc->child_head)
GNUNET_FS_download_stop (dc->child_head, do_delete);
- if (dc->parent != NULL)
+ if (NULL != dc->parent)
GNUNET_CONTAINER_DLL_remove (dc->parent->child_head, dc->parent->child_tail,
dc);
- if (dc->serialization != NULL)
+ if (NULL != dc->serialization)
GNUNET_FS_remove_sync_file_ (dc->h,
- ((dc->parent != NULL) ||
- (dc->search !=
- NULL)) ? GNUNET_FS_SYNC_PATH_CHILD_DOWNLOAD :
+ ((NULL != dc->parent) ||
+ (! search_was_null)) ? GNUNET_FS_SYNC_PATH_CHILD_DOWNLOAD :
GNUNET_FS_SYNC_PATH_MASTER_DOWNLOAD,
dc->serialization);
- if ((GNUNET_YES == have_children) && (dc->parent == NULL))
+ if ((GNUNET_YES == have_children) && (NULL == dc->parent))
GNUNET_FS_remove_sync_dir_ (dc->h,
- (dc->search !=
- NULL) ? GNUNET_FS_SYNC_PATH_CHILD_DOWNLOAD :
+ (! search_was_null) ? GNUNET_FS_SYNC_PATH_CHILD_DOWNLOAD :
GNUNET_FS_SYNC_PATH_MASTER_DOWNLOAD,
dc->serialization);
pi.status = GNUNET_FS_STATUS_DOWNLOAD_STOPPED;
GNUNET_FS_download_make_status_ (&pi, dc);
GNUNET_FS_free_download_request_ (dc->top_request);
dc->top_request = NULL;
- if (dc->active != NULL)
+ if (NULL != dc->active)
{
GNUNET_CONTAINER_multihashmap_destroy (dc->active);
dc->active = NULL;
}
- if (dc->filename != NULL)
+ if (NULL != dc->filename)
{
if ((dc->completed != dc->length) && (GNUNET_YES == do_delete))
{
- if (0 != UNLINK (dc->filename))
+ if ( (0 != UNLINK (dc->filename)) &&
+ (ENOENT != errno) )
GNUNET_log_strerror_file (GNUNET_ERROR_TYPE_WARNING, "unlink",
dc->filename);
}
GNUNET_free (dc->temp_filename);
}
GNUNET_free_non_null (dc->serialization);
+ GNUNET_assert (NULL == dc->job_queue);
GNUNET_free (dc);
}