-options to play with
[oweals/gnunet.git] / src / fs / fs_api.c
index d6a434e6e7130aebbd9a3ad409c379e9ec122f9f..678187a27124ba60208c7a3221ca705607eb2e8b 100644 (file)
@@ -61,6 +61,10 @@ start_job (struct GNUNET_FS_QueueEntry *qe)
   qe->h->active_blocks += qe->blocks;
   qe->h->active_downloads++;
   qe->start_time = GNUNET_TIME_absolute_get ();
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+             "Starting job %p (%u active)\n",
+             qe,
+             qe->h->active_downloads);
   GNUNET_CONTAINER_DLL_remove (qe->h->pending_head, qe->h->pending_tail, qe);
   GNUNET_CONTAINER_DLL_insert_after (qe->h->running_head, qe->h->running_tail,
                                      qe->h->running_tail, qe);
@@ -85,6 +89,10 @@ stop_job (struct GNUNET_FS_QueueEntry *qe)
       GNUNET_TIME_relative_add (qe->run_time,
                                 GNUNET_TIME_absolute_get_duration
                                 (qe->start_time));
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+             "Stopping job %p (%u active)\n",
+             qe,
+             qe->h->active_downloads);
   GNUNET_CONTAINER_DLL_remove (qe->h->running_head, qe->h->running_tail, qe);
   GNUNET_CONTAINER_DLL_insert_after (qe->h->pending_head, qe->h->pending_tail,
                                      qe->h->pending_tail, qe);
@@ -146,35 +154,43 @@ process_job_queue (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
   num_probes_expired = 0;
   num_downloads_active = 0;
   num_downloads_expired = 0;
-  for (qe = h->running_head; NULL != qe; qe = qe->next)
+  next = h->running_head;
+  while (NULL != (qe = next))
   {
-    run_time =
-        GNUNET_TIME_relative_multiply (h->avg_block_latency,
-                                       qe->blocks * qe->start_times);
+    next = qe->next;
     switch (qe->priority)
     {
     case GNUNET_FS_QUEUE_PRIORITY_PROBE:
-      num_probes_active++;
-      /* run probes for at most 1s * number-of-restarts; note that
-        as the total runtime of a probe is limited to 2m, we don't
-        need to additionally limit the total time of a probe to 
-        strictly limit its lifetime. */
-      run_time = GNUNET_TIME_relative_min (run_time,
-                                          GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_SECONDS,
-                                                                         1 + qe->start_times));
+      run_time = GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_MINUTES, 2);
       end_time = GNUNET_TIME_absolute_add (qe->start_time, run_time);
       rst = GNUNET_TIME_absolute_get_remaining (end_time);
-      restart_at = GNUNET_TIME_relative_min (rst, restart_at);
       if (0 == rst.rel_value)
+      {
        num_probes_expired++;
+       stop_job (qe);
+      }
+      else
+      {
+       num_probes_active++;
+       restart_at = GNUNET_TIME_relative_min (rst, restart_at);
+      }
       break;
     case GNUNET_FS_QUEUE_PRIORITY_NORMAL:
-      num_downloads_active++;
+      run_time =
+        GNUNET_TIME_relative_multiply (h->avg_block_latency,
+                                       qe->blocks * qe->start_times);
       end_time = GNUNET_TIME_absolute_add (qe->start_time, run_time);
       rst = GNUNET_TIME_absolute_get_remaining (end_time);
-      restart_at = GNUNET_TIME_relative_min (rst, restart_at);
       if (0 == rst.rel_value)
+      {
        num_downloads_expired++;
+       stop_job (qe);
+      }
+      else
+      {
+       num_downloads_active++;
+       restart_at = GNUNET_TIME_relative_min (rst, restart_at);
+      }
       break;
     default:
       GNUNET_break (0);
@@ -189,104 +205,49 @@ process_job_queue (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
              num_downloads_active,
              num_downloads_expired,
              num_downloads_waiting);
-
-  /* calculate stop decisions */
-  num_probes_change = 0;
-  num_downloads_change = 0;
+  /* calculate start/stop decisions */
   if (h->active_downloads + num_downloads_waiting > h->max_parallel_requests)
   {
-    if (num_probes_active > 0)
-      num_probes_change = - GNUNET_MIN (num_probes_active,
-                                       h->max_parallel_requests - (h->active_downloads + num_downloads_waiting));
-    else if (h->active_downloads + num_downloads_waiting > h->max_parallel_requests)
-      num_downloads_change = - GNUNET_MIN (num_downloads_expired,
-                                         h->max_parallel_requests - (h->active_downloads + num_downloads_waiting));
+    /* stop probes if possible */
+    num_probes_change = - num_probes_active;
+    num_downloads_change = h->max_parallel_requests - h->active_downloads;
+  } 
+  else 
+  {
+    /* start all downloads */
+    num_downloads_change = num_downloads_waiting;
+    /* start as many probes as we can */
+    num_probes_change = GNUNET_MIN (num_probes_waiting,
+                                   h->max_parallel_requests - (h->active_downloads + num_downloads_waiting));
   }
-
+       
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-             "Stopping %d probes and %d downloads\n",
+             "Changing %d probes and %d downloads\n",
              num_probes_change,
              num_downloads_change);
-  /* then, check if we should stop some jobs */
+  /* actually stop probes */
   next = h->running_head;
   while (NULL != (qe = next))
   {
     next = qe->next;
-    run_time =
-        GNUNET_TIME_relative_multiply (h->avg_block_latency,
-                                       qe->blocks * qe->start_times);
-    switch (qe->priority)
+    if (GNUNET_FS_QUEUE_PRIORITY_PROBE != qe->priority)
+      continue;
+    if (num_probes_change < 0) 
     {
-    case GNUNET_FS_QUEUE_PRIORITY_PROBE:
-      /* run probes for at most 1s * number-of-restarts; note that
-        as the total runtime of a probe is limited to 2m, we don't
-        need to additionally limit the total time of a probe to 
-        strictly limit its lifetime. */
-      run_time = GNUNET_TIME_relative_min (run_time,
-                                          GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_SECONDS,
-                                                                         1 + qe->start_times));
-      end_time = GNUNET_TIME_absolute_add (qe->start_time, run_time);
-      rst = GNUNET_TIME_absolute_get_remaining (end_time);
-      restart_at = GNUNET_TIME_relative_min (rst, restart_at);
-      if ( (num_probes_change < 0) &&
-          ( (num_probes_expired < - num_probes_change) ||
-            (0 == rst.rel_value) ) )
-      {
-       stop_job (qe);
-       num_probes_change++;
-       if (0 == rst.rel_value)
-         num_probes_expired--;
-      }
-      break;
-    case GNUNET_FS_QUEUE_PRIORITY_NORMAL:
-      end_time = GNUNET_TIME_absolute_add (qe->start_time, run_time);
-      rst = GNUNET_TIME_absolute_get_remaining (end_time);
-      restart_at = GNUNET_TIME_relative_min (rst, restart_at);
-      if ( (num_downloads_change < 0) &&
-          ( (num_downloads_expired < - num_downloads_change) ||
-            (0 == rst.rel_value) ) )
-      {
-       stop_job (qe);
-       num_downloads_change++;
-       if (0 == rst.rel_value)
-         num_downloads_expired--;
-      }
-      break;
-    default:
-      GNUNET_break (0);
-      break;
+      stop_job (qe);
+      num_probes_change++;
+      if (0 == num_probes_change)
+       break;
     }
   }
-  GNUNET_break (0 == num_downloads_change);
-  GNUNET_break (0 == num_probes_change);
+  GNUNET_break (0 <= num_probes_change);
 
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-             "AD: %u, MP: %u\n",
-             h->active_downloads,
-             h->max_parallel_requests);
-
-  /* calculate start decisions */
-  if (h->active_downloads + num_downloads_waiting < h->max_parallel_requests)
-  {
-    /* can start all downloads, fill rest with probes */
-    num_downloads_change = num_downloads_waiting;
-    num_probes_change = GNUNET_MIN (num_probes_waiting,
-                                   h->max_parallel_requests - (h->active_downloads + num_downloads_waiting)); 
-  }
-  else
-  {
-    num_downloads_change = h->max_parallel_requests - h->active_downloads;
-    num_probes_change = 0;
-  }
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-             "Starting %d probes and %d downloads\n",
-             num_probes_change,
-             num_downloads_change);
-
-  /* finally, start some more tasks if we now have empty slots */
+  /* start some more tasks if we now have empty slots */
   block_limit_hit = GNUNET_NO;
   next = h->pending_head;
-  while (NULL != (qe = next))
+  while ( (NULL != (qe = next)) &&
+         ( (num_probes_change > 0) ||
+           (num_downloads_change > 0) ) )
   {
     next = qe->next;
     switch (qe->priority)
@@ -296,6 +257,8 @@ process_job_queue (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
       {
        start_job (qe);
        num_probes_change--;
+       run_time = GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_MINUTES, 2);
+       restart_at = GNUNET_TIME_relative_min (run_time, restart_at);
       }
       break;
     case GNUNET_FS_QUEUE_PRIORITY_NORMAL:
@@ -317,10 +280,14 @@ process_job_queue (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
   }
   GNUNET_break ( (0 == num_downloads_change) || (GNUNET_YES == block_limit_hit) );
   GNUNET_break (0 == num_probes_change);
+
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-             "Left with %d probes and %d downloads to start\n",
+             "AD: %u, MP: %u; %d probes and %d downloads to start, will run again in %s\n",
+             h->active_downloads,
+             h->max_parallel_requests,       
              num_probes_change,
-             num_downloads_change);
+             num_downloads_change,
+             GNUNET_STRINGS_relative_time_to_string (restart_at, GNUNET_YES));
 
   /* make sure we run again */
   h->queue_job =
@@ -359,24 +326,31 @@ GNUNET_FS_queue_ (struct GNUNET_FS_Handle *h, GNUNET_FS_QueueStart start,
   if (h->queue_job != GNUNET_SCHEDULER_NO_TASK)
     GNUNET_SCHEDULER_cancel (h->queue_job);
   h->queue_job = GNUNET_SCHEDULER_add_now (&process_job_queue, h);
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+             "Queueing job %p\n",
+             qe);
   return qe;
 }
 
 
 /**
  * Dequeue a job from the queue.
- * @param qh handle for the job
+ *
+ * @param qe handle for the job
  */
 void
-GNUNET_FS_dequeue_ (struct GNUNET_FS_QueueEntry *qh)
+GNUNET_FS_dequeue_ (struct GNUNET_FS_QueueEntry *qe)
 {
   struct GNUNET_FS_Handle *h;
 
-  h = qh->h;
-  if (NULL != qh->client)
-    stop_job (qh);
-  GNUNET_CONTAINER_DLL_remove (h->pending_head, h->pending_tail, qh);
-  GNUNET_free (qh);
+  h = qe->h;
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+             "Dequeueing job %p\n",
+             qe);
+  if (NULL != qe->client)
+    stop_job (qe);
+  GNUNET_CONTAINER_DLL_remove (h->pending_head, h->pending_tail, qe);
+  GNUNET_free (qe);
   if (h->queue_job != GNUNET_SCHEDULER_NO_TASK)
     GNUNET_SCHEDULER_cancel (h->queue_job);
   h->queue_job = GNUNET_SCHEDULER_add_now (&process_job_queue, h);
@@ -779,7 +753,7 @@ GNUNET_FS_remove_sync_dir_ (struct GNUNET_FS_Handle *h, const char *ext,
   dn = get_serialization_file_name_in_dir (h, ext, uni, "");
   if (NULL == dn)
     return;
-  if ((GNUNET_OK == GNUNET_DISK_directory_test (dn)) &&
+  if ((GNUNET_YES == GNUNET_DISK_directory_test (dn, GNUNET_YES)) &&
       (GNUNET_OK != GNUNET_DISK_directory_remove (dn)))
     GNUNET_log_strerror_file (GNUNET_ERROR_TYPE_WARNING, "rmdir", dn);
   GNUNET_free (dn);
@@ -2722,7 +2696,7 @@ deserialize_download (struct GNUNET_FS_Handle *h,
   }
   dc->options = (enum GNUNET_FS_DownloadOptions) options;
   dc->active =
-      GNUNET_CONTAINER_multihashmap_create (1 + 2 * (dc->length / DBLOCK_SIZE));
+    GNUNET_CONTAINER_multihashmap_create (1 + 2 * (dc->length / DBLOCK_SIZE), GNUNET_NO);
   dc->has_finished = (int) status;
   dc->treedepth =
       GNUNET_FS_compute_depth (GNUNET_FS_uri_chk_get_file_size (dc->uri));
@@ -2741,7 +2715,7 @@ deserialize_download (struct GNUNET_FS_Handle *h,
   dn = get_download_sync_filename (dc, dc->serialization, ".dir");
   if (NULL != dn)
   {
-    if (GNUNET_YES == GNUNET_DISK_directory_test (dn))
+    if (GNUNET_YES == GNUNET_DISK_directory_test (dn, GNUNET_YES))
       GNUNET_DISK_directory_scan (dn, &deserialize_subdownload, dc);
     GNUNET_free (dn);
   }
@@ -2845,7 +2819,7 @@ deserialize_search (struct GNUNET_FS_Handle *h,
     goto cleanup;
   }
   sc->options = (enum GNUNET_FS_SearchOptions) options;
-  sc->master_result_map = GNUNET_CONTAINER_multihashmap_create (16);
+  sc->master_result_map = GNUNET_CONTAINER_multihashmap_create (16, GNUNET_NO);
   dn = get_serialization_file_name_in_dir (h,
                                            (sc->psearch_result ==
                                             NULL) ?
@@ -2854,7 +2828,7 @@ deserialize_search (struct GNUNET_FS_Handle *h,
                                            sc->serialization, "");
   if (NULL != dn)
   {
-    if (GNUNET_YES == GNUNET_DISK_directory_test (dn))
+    if (GNUNET_YES == GNUNET_DISK_directory_test (dn, GNUNET_YES))
       GNUNET_DISK_directory_scan (dn, &deserialize_search_result, sc);
     GNUNET_free (dn);
   }
@@ -2981,7 +2955,7 @@ deserialization_master (const char *master_path, GNUNET_FileNameCallback proc,
   dn = get_serialization_file_name (h, master_path, "");
   if (NULL == dn)
     return;
-  if (GNUNET_YES == GNUNET_DISK_directory_test (dn))
+  if (GNUNET_YES == GNUNET_DISK_directory_test (dn, GNUNET_YES))
     GNUNET_DISK_directory_scan (dn, proc, h);
   GNUNET_free (dn);
 }