fixing common off-by-one error with respect to maximum message size
[oweals/gnunet.git] / src / fs / fs.c
index aa41f6855be20688edb9bb0ca21213dc5eedf531..9ec35ed2f746ffd3a215ee909ed0a1758992cd74 100644 (file)
@@ -466,7 +466,7 @@ get_serialization_file_name_in_dir (struct GNUNET_FS_Handle *h,
                                               &basename))
     return NULL;
   GNUNET_asprintf (&ret,
-                  "%s%s%s%s%s%s%s%s%s",
+                  "%s%s%s%s%s%s%s.dir%s%s",
                   basename,
                   DIR_SEPARATOR_STR,
                   h->client_name,
@@ -529,9 +529,7 @@ get_write_handle (struct GNUNET_FS_Handle *h,
     }
   ret = GNUNET_BIO_write_open (fn);
   if (ret == NULL)
-    fprintf (stderr,
-            "Failed to create write handle for `%s' from `%s/%s'\n",
-            fn, ext, ent);
+    GNUNET_break (0);
   GNUNET_free (fn);
   return ret;
 }
@@ -585,11 +583,14 @@ GNUNET_FS_remove_sync_file_ (struct GNUNET_FS_Handle *h,
       return;
     }
   filename = get_serialization_file_name (h, ext, ent);
-  if (0 != UNLINK (filename))
-    GNUNET_log_strerror_file (GNUNET_ERROR_TYPE_WARNING,
-                             "unlink", 
-                             filename);
-  GNUNET_free (filename);
+  if (filename != NULL)
+    {
+      if (0 != UNLINK (filename))
+       GNUNET_log_strerror_file (GNUNET_ERROR_TYPE_WARNING,
+                                 "unlink", 
+                                 filename);
+      GNUNET_free (filename);
+    }
 }
 
 
@@ -616,11 +617,14 @@ remove_sync_file_in_dir (struct GNUNET_FS_Handle *h,
       return;
     }
   filename = get_serialization_file_name_in_dir (h, ext, uni, ent);
-  if (0 != UNLINK (filename))
-    GNUNET_log_strerror_file (GNUNET_ERROR_TYPE_WARNING,
-                             "unlink", 
-                             filename);
-  GNUNET_free (filename);
+  if (filename != NULL)
+    {
+      if (0 != UNLINK (filename))
+       GNUNET_log_strerror_file (GNUNET_ERROR_TYPE_WARNING,
+                                 "unlink", 
+                                 filename);
+      GNUNET_free (filename);
+    }
 }
 
 
@@ -781,13 +785,19 @@ deserialize_fi_node (struct GNUNET_FS_Handle *h,
        GNUNET_BIO_read_int32 (rh, &ret->anonymity)) ||
        (GNUNET_OK !=
        GNUNET_BIO_read_int32 (rh, &ret->priority)) )
-    goto cleanup;
+    {
+      GNUNET_break (0);      
+      goto cleanup;
+    }
   switch (b)
     {
     case 0: /* file-insert */
       if (GNUNET_OK !=
          GNUNET_BIO_read_int64 (rh, &ret->data.file.file_size))
-       goto cleanup;
+       {
+         GNUNET_break (0);
+         goto cleanup;
+       }
       ret->is_directory = GNUNET_NO;
       ret->data.file.do_index = GNUNET_NO;
       ret->data.file.have_hash = GNUNET_NO;
@@ -802,7 +812,10 @@ deserialize_fi_node (struct GNUNET_FS_Handle *h,
                goto cleanup;
              if (GNUNET_OK !=
                  GNUNET_BIO_read (rh, "file-data", ret->data.file.reader_cls, ret->data.file.file_size))
-               goto cleanup;
+               {
+                 GNUNET_break (0);
+                 goto cleanup;
+               }
            }      
          else
            {
@@ -813,10 +826,16 @@ deserialize_fi_node (struct GNUNET_FS_Handle *h,
       break;
     case 1: /* file-index, no hash */
       if (NULL == ret->filename)
-       goto cleanup;
+       {
+         GNUNET_break (0);               
+         goto cleanup;
+       }
       if (GNUNET_OK !=
          GNUNET_BIO_read_int64 (rh, &ret->data.file.file_size))
-       goto cleanup;
+       {
+         GNUNET_break (0);
+         goto cleanup;
+       }
       ret->is_directory = GNUNET_NO;
       ret->data.file.do_index = GNUNET_YES;
       ret->data.file.have_hash = GNUNET_NO;
@@ -826,12 +845,18 @@ deserialize_fi_node (struct GNUNET_FS_Handle *h,
       break;
     case 2: /* file-index-with-hash */
       if (NULL == ret->filename)
-       goto cleanup;
+       {
+         GNUNET_break (0);
+         goto cleanup;
+       }
       if ( (GNUNET_OK !=
            GNUNET_BIO_read_int64 (rh, &ret->data.file.file_size)) ||
           (GNUNET_OK !=
            GNUNET_BIO_read (rh, "fileid", &ret->data.file.file_id, sizeof (GNUNET_HashCode))) )
-       goto cleanup;
+       {
+         GNUNET_break (0);
+         goto cleanup;
+       }
       ret->is_directory = GNUNET_NO;
       ret->data.file.do_index = GNUNET_YES;
       ret->data.file.have_hash = GNUNET_YES;
@@ -841,13 +866,18 @@ deserialize_fi_node (struct GNUNET_FS_Handle *h,
       break;
     case 3: /* file-index-with-hash-confirmed */
       if (NULL == ret->filename)
-       goto cleanup;
+       {
+         GNUNET_break (0);
+         goto cleanup;
+       }
       if ( (GNUNET_OK !=
            GNUNET_BIO_read_int64 (rh, &ret->data.file.file_size)) ||
           (GNUNET_OK !=
            GNUNET_BIO_read (rh, "fileid", &ret->data.file.file_id, sizeof (GNUNET_HashCode))) )
-       goto cleanup;
-
+       {
+         GNUNET_break (0);
+         goto cleanup;
+       }
       ret->is_directory = GNUNET_NO;
       ret->data.file.do_index = GNUNET_YES;
       ret->data.file.have_hash = GNUNET_YES;
@@ -856,6 +886,7 @@ deserialize_fi_node (struct GNUNET_FS_Handle *h,
       ret->data.file.reader_cls = GNUNET_FS_make_file_reader_context_ (ret->filename);
       break;
     case 4: /* directory */
+      ret->is_directory = GNUNET_YES;
       if ( (GNUNET_OK !=
            GNUNET_BIO_read_int32 (rh, &dsize)) ||
           (NULL == (ret->data.dir.dir_data = GNUNET_malloc_large (dsize))) ||
@@ -863,9 +894,11 @@ deserialize_fi_node (struct GNUNET_FS_Handle *h,
            GNUNET_BIO_read (rh, "dir-data", ret->data.dir.dir_data, dsize)) ||
           (GNUNET_OK !=
            GNUNET_BIO_read_string (rh, "ent-filename", &filename, 16*1024)) )
-       goto cleanup;
+       {
+         GNUNET_break (0);
+         goto cleanup;
+       }
       ret->data.dir.dir_size = (uint32_t) dsize;
-      ret->is_directory = GNUNET_YES;
       if (filename != NULL)
        {
          ret->data.dir.entries = deserialize_file_information (h, filename);
@@ -886,7 +919,10 @@ deserialize_fi_node (struct GNUNET_FS_Handle *h,
   ret->serialization = GNUNET_strdup (fn);
   if (GNUNET_OK !=
       GNUNET_BIO_read_string (rh, "nxt-filename", &filename, 16*1024))
-    goto cleanup;  
+    {
+      GNUNET_break (0);
+      goto cleanup;  
+    }
   if (filename != NULL)
     {
       ret->next = deserialize_file_information (h, filename);
@@ -935,6 +971,13 @@ deserialize_file_information (struct GNUNET_FS_Handle *h,
                  emsg);
       GNUNET_free (emsg);
     }
+  if (ret == NULL)
+    {
+      if (0 != UNLINK (filename))
+       GNUNET_log_strerror_file (GNUNET_ERROR_TYPE_WARNING,
+                                 "unlink",
+                                 filename);
+    }
   return ret;
 }
 
@@ -993,6 +1036,8 @@ make_serialization_file_name (struct GNUNET_FS_Handle *h,
   if (0 == (h->flags & GNUNET_FS_FLAGS_PERSISTENCE))
     return NULL; /* persistence not requested */
   dn = get_serialization_file_name (h, ext, "");
+  if (dn == NULL)
+    return NULL;
   if (GNUNET_OK !=
       GNUNET_DISK_directory_create_for_file (dn))
     {
@@ -1030,6 +1075,8 @@ make_serialization_file_name_in_dir (struct GNUNET_FS_Handle *h,
   if (0 == (h->flags & GNUNET_FS_FLAGS_PERSISTENCE))
     return NULL; /* persistence not requested */
   dn = get_serialization_file_name_in_dir (h, ext, uni, "");
+  if (dn == NULL)
+    return NULL;
   if (GNUNET_OK !=
       GNUNET_DISK_directory_create_for_file (dn))
     {
@@ -1060,14 +1107,16 @@ copy_from_reader (struct GNUNET_BIO_WriteHandle *wh,
   char buf[32 * 1024];
   uint64_t off;
   size_t ret;
+  size_t left;
   char *emsg;
 
   emsg = NULL;
   off = 0;
   while (off < fi->data.file.file_size)
     {
+      left = GNUNET_MIN (sizeof(buf), fi->data.file.file_size - off);
       ret = fi->data.file.reader (fi->data.file.reader_cls,
-                                 off, sizeof (buf),
+                                 off, left,
                                  buf,
                                  &emsg);
       if (ret == 0)
@@ -1148,7 +1197,10 @@ GNUNET_FS_file_information_sync_ (struct GNUNET_FS_FileInformation * fi)
        GNUNET_BIO_write_int32 (wh, fi->anonymity)) ||
        (GNUNET_OK != 
        GNUNET_BIO_write_int32 (wh, fi->priority)) )
-    goto cleanup;
+    {
+      GNUNET_break (0);
+      goto cleanup;
+    }
   GNUNET_free_non_null (chks);
   chks = NULL;
   GNUNET_free_non_null (ksks);
@@ -1159,29 +1211,47 @@ GNUNET_FS_file_information_sync_ (struct GNUNET_FS_FileInformation * fi)
     case 0: /* file-insert */
       if (GNUNET_OK !=
          GNUNET_BIO_write_int64 (wh, fi->data.file.file_size))
-       goto cleanup;
+       {
+         GNUNET_break (0);
+         goto cleanup;
+       }
       if ( (GNUNET_NO == fi->is_published) &&
           (NULL == fi->filename) )     
        if (GNUNET_OK != 
            copy_from_reader (wh, fi))
-         goto cleanup;
+         {
+           GNUNET_break (0);
+           goto cleanup;
+         }
       break;
     case 1: /* file-index, no hash */
       if (NULL == fi->filename)
-       goto cleanup;
+       {
+         GNUNET_break (0);
+         goto cleanup;
+       }
       if (GNUNET_OK !=
          GNUNET_BIO_write_int64 (wh, fi->data.file.file_size))
-       goto cleanup;
+       {
+         GNUNET_break (0);
+         goto cleanup;
+       }
       break;
     case 2: /* file-index-with-hash */
     case 3: /* file-index-with-hash-confirmed */
       if (NULL == fi->filename)
-       goto cleanup;
+       {
+         GNUNET_break (0);
+         goto cleanup;
+       }
       if ( (GNUNET_OK !=
            GNUNET_BIO_write_int64 (wh, fi->data.file.file_size)) ||
           (GNUNET_OK !=
            GNUNET_BIO_write (wh, &fi->data.file.file_id, sizeof (GNUNET_HashCode))) )
-       goto cleanup;
+       {
+         GNUNET_break (0);
+         goto cleanup;
+       }
       break;
     case 4: /* directory */
       if ( (GNUNET_OK !=
@@ -1189,8 +1259,14 @@ GNUNET_FS_file_information_sync_ (struct GNUNET_FS_FileInformation * fi)
           (GNUNET_OK !=
            GNUNET_BIO_write (wh, fi->data.dir.dir_data, (uint32_t) fi->data.dir.dir_size)) ||
           (GNUNET_OK !=
-           GNUNET_BIO_write_string (wh, fi->data.dir.entries->serialization)) )
-       goto cleanup;
+           GNUNET_BIO_write_string (wh, 
+                                    (fi->data.dir.entries == NULL) 
+                                    ?  NULL
+                                    : fi->data.dir.entries->serialization)) )
+       {
+         GNUNET_break (0);
+         goto cleanup;
+       }
       break;
     default:
       GNUNET_assert (0);
@@ -1198,18 +1274,30 @@ GNUNET_FS_file_information_sync_ (struct GNUNET_FS_FileInformation * fi)
     }
   if (GNUNET_OK !=
       GNUNET_BIO_write_string (wh, (fi->next != NULL) ? fi->next->serialization : NULL))
-    goto cleanup;  
-  if (GNUNET_OK ==
+    {
+      GNUNET_break (0);                  
+      goto cleanup;  
+    }
+  if (GNUNET_OK !=
       GNUNET_BIO_write_close (wh))
-    return; /* done! */
+    {
+      wh = NULL;
+      GNUNET_break (0);
+      goto cleanup;
+    }
+  return; /* done! */
  cleanup:
-  (void) GNUNET_BIO_write_close (wh);
+  if (wh != NULL)
+    (void) GNUNET_BIO_write_close (wh);
   GNUNET_free_non_null (chks);
   GNUNET_free_non_null (ksks);
   fn = get_serialization_file_name (fi->h, GNUNET_FS_SYNC_PATH_FILE_INFO, fi->serialization);
-  if (0 != UNLINK (fn))
-    GNUNET_log_strerror_file (GNUNET_ERROR_TYPE_WARNING, "unlink", fn);
-  GNUNET_free (fn);
+  if (NULL != fn)
+    {
+      if (0 != UNLINK (fn))
+       GNUNET_log_strerror_file (GNUNET_ERROR_TYPE_WARNING, "unlink", fn);
+      GNUNET_free (fn);
+    }
   GNUNET_free (fi->serialization);
   fi->serialization = NULL;  
 }
@@ -1259,6 +1347,7 @@ find_file_position (struct GNUNET_FS_FileInformation *pos,
  * @param uri pointer to the keywords that will be used for this entry (can be modified)
  * @param anonymity pointer to selected anonymity level (can be modified)
  * @param priority pointer to selected priority (can be modified)
+ * @param do_index should we index?
  * @param expirationTime pointer to selected expiration time (can be modified)
  * @param client_info pointer to client context set upon creation (can be modified)
  * @return GNUNET_OK to continue (always)
@@ -1271,6 +1360,7 @@ fip_signal_resume(void *cls,
                  struct GNUNET_FS_Uri **uri,
                  uint32_t *anonymity,
                  uint32_t *priority,
+                 int *do_index,
                  struct GNUNET_TIME_Absolute *expirationTime,
                  void **client_info)
 {
@@ -1315,7 +1405,10 @@ deserialize_publish_file (void *cls,
   ns = NULL;
   rh = GNUNET_BIO_read_open (filename);
   if (rh == NULL)
-    goto cleanup;
+    {
+      GNUNET_break (0);
+      goto cleanup;
+    }
   if ( (GNUNET_OK !=
        GNUNET_BIO_read_string (rh, "publish-nid", &pc->nid, 1024)) ||
        (GNUNET_OK !=
@@ -1330,12 +1423,18 @@ deserialize_publish_file (void *cls,
        GNUNET_BIO_read_string (rh, "publish-fipos", &fi_pos, 128)) ||
        (GNUNET_OK !=
        GNUNET_BIO_read_string (rh, "publish-ns", &ns, 1024)) )
-    goto cleanup;          
+    {
+      GNUNET_break (0);
+      goto cleanup;      
+    }    
   pc->options = options;
   pc->all_done = all_done;
   pc->fi = deserialize_file_information (h, fi_root);
   if (pc->fi == NULL)
-    goto cleanup;    
+    {
+      GNUNET_break (0);
+      goto cleanup;    
+    }
   if (ns != NULL)
     {
       pc->namespace = GNUNET_FS_namespace_create (h, ns);
@@ -1347,6 +1446,14 @@ deserialize_publish_file (void *cls,
          goto cleanup;
        }
     }
+  if ( (0 == (pc->options & GNUNET_FS_PUBLISH_OPTION_SIMULATE_ONLY)) &&
+       (GNUNET_YES != pc->all_done) )
+    {
+      pc->dsh = GNUNET_DATASTORE_connect (h->cfg,
+                                         h->sched);
+      if (NULL == pc->dsh)
+       goto cleanup;
+    } 
   if (fi_pos != NULL)
     {
       pc->fi_pos = find_file_position (pc->fi,
@@ -1361,6 +1468,8 @@ deserialize_publish_file (void *cls,
            pc->fi_pos = pc->fi;
        }
     }
+  GNUNET_free (fi_root);
+  fi_root = NULL;
   /* generate RESUME event(s) */
   GNUNET_FS_file_information_inspect (pc->fi,
                                      &fip_signal_resume,
@@ -1405,7 +1514,7 @@ deserialize_publish_file (void *cls,
     GNUNET_FS_file_information_destroy (pc->fi, NULL, NULL);
   if (0 != UNLINK (filename))
     GNUNET_log_strerror_file (GNUNET_ERROR_TYPE_WARNING, "unlink", filename);
-  GNUNET_free_non_null (pc->serialization);
+  GNUNET_free (pc->serialization);
   GNUNET_free (pc);
   return GNUNET_OK;
 }
@@ -1438,7 +1547,10 @@ GNUNET_FS_publish_sync_ (struct GNUNET_FS_PublishContext *pc)
     }
   wh = get_write_handle (pc->h, GNUNET_FS_SYNC_PATH_MASTER_PUBLISH, pc->serialization);
   if (wh == NULL)
-    goto cleanup;
+    {
+      GNUNET_break (0);
+      goto cleanup;
+    }
   if ( (GNUNET_OK !=
        GNUNET_BIO_write_string (wh, pc->nid)) ||
        (GNUNET_OK !=
@@ -1454,12 +1566,14 @@ GNUNET_FS_publish_sync_ (struct GNUNET_FS_PublishContext *pc)
        (GNUNET_OK !=
        GNUNET_BIO_write_string (wh, (pc->namespace == NULL) ? NULL : pc->namespace->name)) )
    {
+     GNUNET_break (0);
      goto cleanup;
    }
  if (GNUNET_OK !=
      GNUNET_BIO_write_close (wh))
    {
      wh = NULL;
+     GNUNET_break (0);
      goto cleanup;
    }
  return;
@@ -1485,8 +1599,6 @@ GNUNET_FS_unindex_sync_ (struct GNUNET_FS_UnindexContext *uc)
 {
   struct GNUNET_BIO_WriteHandle *wh;
 
-  if (UNINDEX_STATE_ABORTED == uc->state)
-    return;
   if (NULL == uc->serialization)
     uc->serialization = make_serialization_file_name (uc->h,
                                                      GNUNET_FS_SYNC_PATH_MASTER_UNINDEX);
@@ -1494,7 +1606,10 @@ GNUNET_FS_unindex_sync_ (struct GNUNET_FS_UnindexContext *uc)
     return;
   wh = get_write_handle (uc->h, GNUNET_FS_SYNC_PATH_MASTER_UNINDEX, uc->serialization);
   if (wh == NULL)
-    goto cleanup;
+    {
+      GNUNET_break (0);
+      goto cleanup;
+    }
   if ( (GNUNET_OK !=
        GNUNET_BIO_write_string (wh, uc->filename)) ||
        (GNUNET_OK !=
@@ -1509,11 +1624,15 @@ GNUNET_FS_unindex_sync_ (struct GNUNET_FS_UnindexContext *uc)
        ( (uc->state == UNINDEX_STATE_ERROR) &&
         (GNUNET_OK !=
          GNUNET_BIO_write_string (wh, uc->emsg)) ) )
-    goto cleanup;
+    {
+      GNUNET_break (0);
+      goto cleanup;
+    }
   if (GNUNET_OK !=
       GNUNET_BIO_write_close (wh))
     {
       wh = NULL;
+      GNUNET_break (0);
       goto cleanup;
     }  
   return;
@@ -1579,11 +1698,13 @@ count_download_requests (void *cls,
  *
  * @param dc download context to compute for
  * @param uni unique filename to use, use "" for the directory name
+ * @param ext extension to use, use ".dir" for our own subdirectory
  * @return the expanded file name, NULL for none
  */
 static char *
 get_download_sync_filename (struct GNUNET_FS_DownloadContext *dc,
-                           const char *uni)
+                           const char *uni,
+                           const char *ext)
 {
   char *par;
   char *epar;
@@ -1596,14 +1717,15 @@ get_download_sync_filename (struct GNUNET_FS_DownloadContext *dc,
                                        uni);
   if (dc->parent->serialization == NULL)
     return NULL;
-  par = get_download_sync_filename (dc->parent, dc->parent->serialization);
+  par = get_download_sync_filename (dc->parent, dc->parent->serialization, "");
   if (par == NULL)
     return NULL;
   GNUNET_asprintf (&epar,
-                  "%s.dir%s%s",
+                  "%s.dir%s%s%s",
                   par,
                   DIR_SEPARATOR_STR,
-                  uni);
+                  uni,
+                  ext);
   GNUNET_free (par);
   return epar;
 }
@@ -1628,7 +1750,7 @@ GNUNET_FS_download_sync_ (struct GNUNET_FS_DownloadContext *dc)
 
   if (NULL == dc->serialization)    
     {
-      dir = get_download_sync_filename (dc, "");
+      dir = get_download_sync_filename (dc, "", "");
       if (dir == NULL)
        return;
       if (GNUNET_OK !=
@@ -1639,11 +1761,20 @@ GNUNET_FS_download_sync_ (struct GNUNET_FS_DownloadContext *dc)
        }
       fn = GNUNET_DISK_mktemp (dir);
       GNUNET_free (dir);
+      if (fn == NULL)
+       return;
       dc->serialization = get_serialization_short_name (fn);
     }
   else
     {
-      fn = get_download_sync_filename (dc, dc->serialization);
+      fn = get_download_sync_filename (dc, dc->serialization, "");
+      if (fn == NULL)
+       {
+         GNUNET_free (dc->serialization);
+         dc->serialization = NULL;
+         GNUNET_free (fn);
+         return;
+       }
     }
   wh = GNUNET_BIO_write_open (fn);
   if (wh == NULL)
@@ -1657,7 +1788,7 @@ GNUNET_FS_download_sync_ (struct GNUNET_FS_DownloadContext *dc)
                  (GNUNET_YES == GNUNET_FS_uri_test_loc (dc->uri)) );
   uris = GNUNET_FS_uri_to_string (dc->uri);
   num_pending = 0;
-  if (dc->emsg != NULL)
+  if (dc->emsg == NULL)
     (void) GNUNET_CONTAINER_multihashmap_iterate (dc->active,
                                                  &count_download_requests,
                                                  &num_pending);    
@@ -1692,17 +1823,25 @@ GNUNET_FS_download_sync_ (struct GNUNET_FS_DownloadContext *dc)
        GNUNET_BIO_write_int32 (wh, (uint32_t) dc->has_finished)) ||
        (GNUNET_OK !=
        GNUNET_BIO_write_int32 (wh, num_pending)) )
-    goto cleanup; 
+    {
+      GNUNET_break (0);                  
+      goto cleanup; 
+    }
   if (GNUNET_SYSERR ==
       GNUNET_CONTAINER_multihashmap_iterate (dc->active,
                                             &write_download_request,
                                             wh))
-    goto cleanup;
+    {
+      GNUNET_break (0);
+      goto cleanup;
+    }
   GNUNET_free_non_null (uris);
+  uris = NULL;
   if (GNUNET_OK !=
       GNUNET_BIO_write_close (wh))
     {
       wh = NULL;
+      GNUNET_break (0);
       goto cleanup;
     }
   GNUNET_free (fn);
@@ -1749,7 +1888,10 @@ GNUNET_FS_search_result_sync_ (struct GNUNET_FS_SearchResult *sr)
                                sr->sc->serialization,
                                sr->serialization);
   if (wh == NULL)
-    goto cleanup;
+    {
+      GNUNET_break (0);
+      goto cleanup;
+    }
   uris = GNUNET_FS_uri_to_string (sr->uri);
   if ( (GNUNET_OK !=
        GNUNET_BIO_write_string (wh, uris)) ||
@@ -1769,11 +1911,15 @@ GNUNET_FS_search_result_sync_ (struct GNUNET_FS_SearchResult *sr)
        GNUNET_BIO_write_int32 (wh, sr->availability_success)) ||
        (GNUNET_OK !=
        GNUNET_BIO_write_int32 (wh, sr->availability_trials)) )
-    goto cleanup;   
+    {
+      GNUNET_break (0);
+      goto cleanup;   
+    }
   if (GNUNET_OK !=
       GNUNET_BIO_write_close (wh))
     {
       wh = NULL;
+      GNUNET_break (0);
       goto cleanup;
     }
   GNUNET_free_non_null (uris);
@@ -1817,9 +1963,13 @@ GNUNET_FS_search_sync_ (struct GNUNET_FS_SearchContext *sc)
                                                      category);
   if (NULL == sc->serialization)
     return;
+  uris = NULL;
   wh = get_write_handle (sc->h, category, sc->serialization);
   if (wh == NULL)
-    goto cleanup;
+    {
+      GNUNET_break (0);                  
+      goto cleanup;
+    }
   GNUNET_assert ( (GNUNET_YES == GNUNET_FS_uri_test_ksk (sc->uri)) ||
                  (GNUNET_YES == GNUNET_FS_uri_test_sks (sc->uri)) );
   uris = GNUNET_FS_uri_to_string (sc->uri);
@@ -1836,13 +1986,17 @@ GNUNET_FS_search_sync_ (struct GNUNET_FS_SearchContext *sc)
        GNUNET_BIO_write (wh, &in_pause, sizeof (in_pause))) ||
        (GNUNET_OK !=
        GNUNET_BIO_write_int32 (wh, sc->anonymity)) )
-    goto cleanup;          
+    {
+      GNUNET_break (0);
+      goto cleanup;          
+    }
   GNUNET_free (uris);
   uris = NULL;
   if (GNUNET_OK !=
       GNUNET_BIO_write_close (wh))
     {
       wh = NULL;
+      GNUNET_break (0);                  
       goto cleanup;
     }
   return;
@@ -1880,7 +2034,10 @@ deserialize_unindex_file (void *cls,
   uc->serialization = get_serialization_short_name (filename);
   rh = GNUNET_BIO_read_open (filename);
   if (rh == NULL)
-    goto cleanup;
+    {
+      GNUNET_break (0);     
+      goto cleanup;
+    }
   if ( (GNUNET_OK !=
        GNUNET_BIO_read_string (rh, "unindex-fn", &uc->filename, 10*1024)) ||
        (GNUNET_OK !=
@@ -1889,7 +2046,10 @@ deserialize_unindex_file (void *cls,
        read_start_time (rh, &uc->start_time)) ||
        (GNUNET_OK !=
        GNUNET_BIO_read_int32 (rh, &state)) )
-    goto cleanup;          
+    {
+      GNUNET_break (0);     
+      goto cleanup;          
+    }
   uc->state = (enum UnindexState) state;
   switch (state)
     {
@@ -1898,7 +2058,10 @@ deserialize_unindex_file (void *cls,
     case UNINDEX_STATE_FS_NOTIFY:
       if (GNUNET_OK !=
          GNUNET_BIO_read (rh, "unindex-hash", &uc->file_id, sizeof (GNUNET_HashCode)))
-       goto cleanup;
+       {
+         GNUNET_break (0);
+         goto cleanup;
+       }
       break;
     case UNINDEX_STATE_DS_REMOVE:
       break;
@@ -1907,11 +2070,11 @@ deserialize_unindex_file (void *cls,
     case UNINDEX_STATE_ERROR:
       if (GNUNET_OK !=
          GNUNET_BIO_read_string (rh, "unindex-emsg", &uc->emsg, 10*1024))
-       goto cleanup;
+       {
+         GNUNET_break (0);
+         goto cleanup;
+       }
       break;
-    case UNINDEX_STATE_ABORTED:
-      GNUNET_break (0);
-      goto cleanup;
     default:
       GNUNET_break (0);
       goto cleanup;
@@ -1929,12 +2092,12 @@ deserialize_unindex_file (void *cls,
   switch (uc->state)
     {
     case UNINDEX_STATE_HASHING:
-      GNUNET_CRYPTO_hash_file (uc->h->sched,
-                              GNUNET_SCHEDULER_PRIORITY_IDLE,
-                              uc->filename,
-                              HASHING_BLOCKSIZE,
-                              &GNUNET_FS_unindex_process_hash_,
-                              uc);
+      uc->fhc = GNUNET_CRYPTO_hash_file (uc->h->sched,
+                                        GNUNET_SCHEDULER_PRIORITY_IDLE,
+                                        uc->filename,
+                                        HASHING_BLOCKSIZE,
+                                        &GNUNET_FS_unindex_process_hash_,
+                                        uc);
       break;
     case UNINDEX_STATE_FS_NOTIFY:
       uc->state = UNINDEX_STATE_HASHING;
@@ -2075,26 +2238,32 @@ deserialize_search_result (void *cls,
        GNUNET_BIO_read_int32 (rh, &sr->availability_success)) ||
        (GNUNET_OK !=
        GNUNET_BIO_read_int32 (rh, &sr->availability_trials)) )
-    goto cleanup;   
+    {
+      GNUNET_break (0);
+      goto cleanup;   
+    }
   GNUNET_free (uris);
   if (download != NULL)
     {
       drh = get_read_handle (sc->h, 
                             GNUNET_FS_SYNC_PATH_CHILD_DOWNLOAD,
                             download);
-      deserialize_download (sc->h,
-                           drh,
-                           NULL,
-                           sr,
-                           download);
-      if (GNUNET_OK !=
-         GNUNET_BIO_read_close (drh, &emsg))
+      if (drh != NULL)
        {
-         GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
-                     _("Failed to resume sub-download `%s': %s\n"),
-                     download,
-                     emsg);
-         GNUNET_free (emsg);
+         deserialize_download (sc->h,
+                               drh,
+                               NULL,
+                               sr,
+                               download);
+         if (GNUNET_OK !=
+             GNUNET_BIO_read_close (drh, &emsg))
+           {
+             GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
+                         _("Failed to resume sub-download `%s': %s\n"),
+                         download,
+                         emsg);
+             GNUNET_free (emsg);
+           }
        }
       GNUNET_free (download);
     }
@@ -2103,18 +2272,21 @@ deserialize_search_result (void *cls,
       drh = get_read_handle (sc->h, 
                             GNUNET_FS_SYNC_PATH_CHILD_SEARCH,
                             update_srch);
-      deserialize_search (sc->h,
-                         drh,
-                         sr,
-                         update_srch);
-      if (GNUNET_OK !=
-         GNUNET_BIO_read_close (drh, &emsg))
+      if (drh != NULL)
        {
-         GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
-                     _("Failed to resume sub-search `%s': %s\n"),
-                     update_srch,
-                     emsg);
-         GNUNET_free (emsg);
+         deserialize_search (sc->h,
+                             drh,
+                             sr,
+                             update_srch);
+         if (GNUNET_OK !=
+             GNUNET_BIO_read_close (drh, &emsg))
+           {
+             GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
+                         _("Failed to resume sub-search `%s': %s\n"),
+                         update_srch,
+                         emsg);
+             GNUNET_free (emsg);
+           }
        }
       GNUNET_free (update_srch);      
     }
@@ -2122,6 +2294,15 @@ deserialize_search_result (void *cls,
                                     &sr->key,
                                     sr,
                                     GNUNET_CONTAINER_MULTIHASHMAPOPTION_MULTIPLE);
+  if (GNUNET_OK !=
+      GNUNET_BIO_read_close (rh, &emsg))
+    {
+      GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
+                 _("Failure while resuming search operation `%s': %s\n"),
+                 filename,
+                 emsg);
+      GNUNET_free (emsg);
+    }
   return GNUNET_OK;
  cleanup:
   GNUNET_free_non_null (download);
@@ -2133,6 +2314,15 @@ deserialize_search_result (void *cls,
     GNUNET_CONTAINER_meta_data_destroy (sr->meta);
   GNUNET_free (sr->serialization);
   GNUNET_free (sr);  
+  if (GNUNET_OK !=
+      GNUNET_BIO_read_close (rh, &emsg))
+    {
+      GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
+                 _("Failure while resuming search operation `%s': %s\n"),
+                 filename,
+                 emsg);
+      GNUNET_free (emsg);
+    }
   return GNUNET_OK;
 }
 
@@ -2312,6 +2502,15 @@ deserialize_subdownload (void *cls,
 
   ser = get_serialization_short_name (filename);
   rh = GNUNET_BIO_read_open (filename);
+  if (rh == NULL)
+    {
+      GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
+                 _("Failed to resume sub-download `%s': could not open file `%s'\n"),
+                 ser,
+                 filename);
+      GNUNET_free (ser);
+      return GNUNET_OK;
+    }
   deserialize_download (parent->h,
                        rh,
                        parent,
@@ -2429,7 +2628,10 @@ deserialize_download (struct GNUNET_FS_Handle *h,
        GNUNET_BIO_read_int32 (rh, &status)) ||
        (GNUNET_OK !=
        GNUNET_BIO_read_int32 (rh, &num_pending)) )
-    goto cleanup;          
+    {
+      GNUNET_break (0);
+      goto cleanup;          
+    }
   dc->options = (enum GNUNET_FS_DownloadOptions) options;
   dc->active = GNUNET_CONTAINER_multihashmap_create (16);
   dc->has_finished = (int) status;
@@ -2440,7 +2642,10 @@ deserialize_download (struct GNUNET_FS_Handle *h,
                                                        &dc->target));
   if ( (dc->length > dc->completed) &&
        (num_pending == 0) )
-    goto cleanup;    
+    {
+      GNUNET_break (0);                  
+      goto cleanup;    
+    }
   while (0 < num_pending--)
     {
       dr = GNUNET_malloc (sizeof (struct DownloadRequest));
@@ -2450,13 +2655,21 @@ deserialize_download (struct GNUNET_FS_Handle *h,
            GNUNET_BIO_read_int64 (rh, &dr->offset)) ||
           (GNUNET_OK !=
            GNUNET_BIO_read_int32 (rh, &dr->depth)) )
-       goto cleanup;      
+       {
+         GNUNET_break (0);
+         goto cleanup;    
+       }
       dr->is_pending = GNUNET_YES;
       dr->next = dc->pending;
       dc->pending = dr;
+      GNUNET_CONTAINER_multihashmap_put (dc->active,
+                                        &dr->chk.query,
+                                        dr,
+                                        GNUNET_CONTAINER_MULTIHASHMAPOPTION_MULTIPLE);
+
       dr = NULL;
     }
-  dn = get_download_sync_filename (dc, "");
+  dn = get_download_sync_filename (dc, dc->serialization, ".dir");
   if (dn != NULL)
     {
       if (GNUNET_YES ==
@@ -2465,20 +2678,25 @@ deserialize_download (struct GNUNET_FS_Handle *h,
       GNUNET_free (dn);
     }
   if (parent != NULL)
-    GNUNET_CONTAINER_DLL_insert (parent->child_head,
-                                parent->child_tail,
-                                dc);
+    {
+      abort (); // for debugging for now
+      GNUNET_CONTAINER_DLL_insert (parent->child_head,
+                                  parent->child_tail,
+                                  dc);
+    }
   if (search != NULL)
     {
       dc->search = search;
       search->download = dc;
     }
-  if ( (parent == NULL) || 
+  if ( (parent == NULL) &&
        (search == NULL) )
-    dc->top = GNUNET_FS_make_top (dc->h,
-                                 &GNUNET_FS_download_signal_suspend_,
-                                 dc);
-  signal_download_resume (dc);  
+    {
+      dc->top = GNUNET_FS_make_top (dc->h,
+                                   &GNUNET_FS_download_signal_suspend_,
+                                   dc);      
+      signal_download_resume (dc);  
+    }
   GNUNET_free (uris);
   return;
  cleanup:
@@ -2564,7 +2782,10 @@ deserialize_search (struct GNUNET_FS_Handle *h,
        GNUNET_BIO_read (rh, "search-pause", &in_pause, sizeof (in_pause))) ||
        (GNUNET_OK !=
        GNUNET_BIO_read_int32 (rh, &sc->anonymity)) )
-    goto cleanup;          
+    {
+      GNUNET_break (0);                  
+      goto cleanup;          
+    }
   sc->options = (enum GNUNET_FS_SearchOptions) options;
   sc->master_result_map = GNUNET_CONTAINER_multihashmap_create (16);
   dn = get_serialization_file_name_in_dir (h,
@@ -2628,7 +2849,8 @@ deserialize_search_file (void *cls,
       return GNUNET_OK;
     }
   sc = deserialize_search (h, rh, NULL, ser);
-  sc->top = GNUNET_FS_make_top (h, &GNUNET_FS_search_signal_suspend_, sc);
+  if (sc != NULL)
+    sc->top = GNUNET_FS_make_top (h, &GNUNET_FS_search_signal_suspend_, sc);
   GNUNET_free (ser);
   if (GNUNET_OK !=
       GNUNET_BIO_read_close (rh, &emsg))
@@ -2664,14 +2886,11 @@ deserialize_download_file (void *cls,
   rh = GNUNET_BIO_read_open (filename);
   if (rh == NULL)
     {
-      if (filename != NULL)
-       {
-         if (0 != UNLINK (filename))
-           GNUNET_log_strerror_file (GNUNET_ERROR_TYPE_WARNING,
-                                     "unlink", 
-                                     filename);
-         GNUNET_free (ser);
-       }
+       if (0 != UNLINK (filename))
+        GNUNET_log_strerror_file (GNUNET_ERROR_TYPE_WARNING,
+                                  "unlink", 
+                                  filename);
+      GNUNET_free (ser);
       return GNUNET_OK;
     }
   deserialize_download (h, rh, NULL, NULL, ser);